[GitHub] [kafka] kkonstantine commented on pull request #8118: KAFKA-9472: Remove deleted tasks from status store

kkonstantine commented on pull request #8118: URL: https://github.com/apache/kafka/pull/8118#issuecomment-633347090 retest this please This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [kafka] kkonstantine commented on pull request #8722: KAFKA-5295: Allow source connectors to specify topic-specific settings for new topics (KIP-158)

kkonstantine commented on pull request #8722: URL: https://github.com/apache/kafka/pull/8722#issuecomment-633345893 Rebased just to resolve conflicts with https://github.com/apache/kafka/pull/2604 This is an automated messag

[GitHub] [kafka] guozhangwang commented on pull request #8549: KAFKA-9911: Add new PRODUCER_FENCED error code

guozhangwang commented on pull request #8549: URL: https://github.com/apache/kafka/pull/8549#issuecomment-68325 test this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] kkonstantine commented on pull request #8722: KAFKA-5295: Allow source connectors to specify topic-specific settings for new topics (KIP-158)

kkonstantine commented on pull request #8722: URL: https://github.com/apache/kafka/pull/8722#issuecomment-65198 Results of the latest completed build: jk8: success jk11: the beta eos failure again jk14: success Coverage is now quite high, but I'm considering adding a few mor

[GitHub] [kafka] jiameixie commented on pull request #8692: KAFKA-10018: Change command line tools from /bin/sh to /bin/bash

jiameixie commented on pull request #8692: URL: https://github.com/apache/kafka/pull/8692#issuecomment-64815 @ijuma Could you have a review for it? Thanks. This is an automated message from the Apache Git Service. To resp

[GitHub] [kafka] guozhangwang commented on a change in pull request #8248: KAFKA-9501: convert between active and standby without closing stores

guozhangwang commented on a change in pull request #8248: URL: https://github.com/apache/kafka/pull/8248#discussion_r429694775 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorContextImpl.java ## @@ -109,7 +94,7 @@ public void logChange

[GitHub] [kafka] kkonstantine commented on a change in pull request #8722: KAFKA-5295: Allow source connectors to specify topic-specific settings for new topics (KIP-158)

kkonstantine commented on a change in pull request #8722: URL: https://github.com/apache/kafka/pull/8722#discussion_r429677323 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java ## @@ -678,7 +701,8 @@ ErrorHandlingMetrics errorHandlingMetr

[GitHub] [kafka] rhauch commented on pull request #8270: KAFKA-9216: Enforce connect internal topic configuration at startup

rhauch commented on pull request #8270: URL: https://github.com/apache/kafka/pull/8270#issuecomment-60784 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] rhauch merged pull request #2604: KAFKA-4794: Add access to OffsetStorageReader from SourceConnector

rhauch merged pull request #2604: URL: https://github.com/apache/kafka/pull/2604 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] levzem commented on a change in pull request #8720: KAFKA-9971: Error Reporting in Sink Connectors

levzem commented on a change in pull request #8720: URL: https://github.com/apache/kafka/pull/8720#discussion_r429689645 ## File path: connect/api/src/main/java/org/apache/kafka/connect/sink/ErrantRecordReporter.java ## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] guozhangwang commented on pull request #8248: KAFKA-9501: convert between active and standby without closing stores

guozhangwang commented on pull request #8248: URL: https://github.com/apache/kafka/pull/8248#issuecomment-633324072 test this please This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Resolved] (KAFKA-10022) console-producer supports the setting of client.id

[ https://issues.apache.org/jira/browse/KAFKA-10022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-10022. --- Fix Version/s: 2.6.0 Resolution: Fixed > console-producer supports the setting of cli

[GitHub] [kafka] guozhangwang merged pull request #8698: KAFKA-10022:console-producer supports the setting of client.id

guozhangwang merged pull request #8698: URL: https://github.com/apache/kafka/pull/8698 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] guozhangwang commented on pull request #8698: KAFKA-10022:console-producer supports the setting of client.id

guozhangwang commented on pull request #8698: URL: https://github.com/apache/kafka/pull/8698#issuecomment-633320764 I also ran the whole suite locally and only one flaky test in `SocketServerTest`. Will merge to trunk. This

[GitHub] [kafka] xiaodongdu commented on a change in pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

xiaodongdu commented on a change in pull request #8691: URL: https://github.com/apache/kafka/pull/8691#discussion_r429683475 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/util/ConnectUtils.java ## @@ -65,4 +68,12 @@ static String lookupKafkaClusterId(Adm

[GitHub] [kafka] xiaodongdu commented on a change in pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

xiaodongdu commented on a change in pull request #8691: URL: https://github.com/apache/kafka/pull/8691#discussion_r429683527 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/storage/KafkaStatusBackingStoreTest.java ## @@ -63,6 +63,7 @@ private static

[GitHub] [kafka] xiaodongdu commented on a change in pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

xiaodongdu commented on a change in pull request #8691: URL: https://github.com/apache/kafka/pull/8691#discussion_r429683348 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/storage/KafkaStatusBackingStoreFormatTest.java ## @@ -59,6 +59,7 @@ private st

[GitHub] [kafka] xiaodongdu commented on a change in pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

xiaodongdu commented on a change in pull request #8691: URL: https://github.com/apache/kafka/pull/8691#discussion_r429683408 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/util/ConnectUtils.java ## @@ -65,4 +68,12 @@ static String lookupKafkaClusterId(Adm

[GitHub] [kafka] xiaodongdu commented on a change in pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

xiaodongdu commented on a change in pull request #8691: URL: https://github.com/apache/kafka/pull/8691#discussion_r429683348 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/storage/KafkaStatusBackingStoreFormatTest.java ## @@ -59,6 +59,7 @@ private st

[GitHub] [kafka] xiaodongdu commented on a change in pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

xiaodongdu commented on a change in pull request #8691: URL: https://github.com/apache/kafka/pull/8691#discussion_r429683370 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerTest.java ## @@ -153,6 +164,7 @@ public void setup() { worke

[GitHub] [kafka] xiaodongdu commented on a change in pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

xiaodongdu commented on a change in pull request #8691: URL: https://github.com/apache/kafka/pull/8691#discussion_r429683340 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/WorkerGroupMember.java ## @@ -223,4 +235,12 @@ private void sto

[GitHub] [kafka] gnkoshelev commented on pull request #8715: KAFKA-10033: AdminClient should throw UnknownTopicOrPartitionException instead of UnknownServerException if altering configs of non-existin

gnkoshelev commented on pull request #8715: URL: https://github.com/apache/kafka/pull/8715#issuecomment-633305898 Hi, @ijuma, You was one of reviewers of `AdminZkClient`. Can you review the PR? This is an automated message

[jira] [Updated] (KAFKA-10033) AdminClient should throw UnknownTopicOrPartitionException instead of UnknownServerException if altering configs of non-existing topic

[ https://issues.apache.org/jira/browse/KAFKA-10033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gregory Koshelev updated KAFKA-10033: - Labels: pull-request-available (was: ) > AdminClient should throw UnknownTopicOrPartiti

[GitHub] [kafka] cmccabe edited a comment on pull request #8703: MINOR: add a getOrCreate function to KRPC collections

cmccabe edited a comment on pull request #8703: URL: https://github.com/apache/kafka/pull/8703#issuecomment-633304837 > Why is it the case that non generated code doesn't know about keys? It's a `Collection` rather than a `Map`. Collections don't have a key type and value type-- the

[GitHub] [kafka] cmccabe commented on pull request #8703: MINOR: add a getOrCreate function to KRPC collections

cmccabe commented on pull request #8703: URL: https://github.com/apache/kafka/pull/8703#issuecomment-633304837 > Why is it the case that non generated code doesn't know about keys? It's a `Collection` rather than a `Map`. Collections don't have a key type and value type-- they just

[jira] [Commented] (KAFKA-3450) Producer blocks on send to topic that doesn't exist if auto create is disabled

[ https://issues.apache.org/jira/browse/KAFKA-3450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17115513#comment-17115513 ] Gregory Koshelev commented on KAFKA-3450: - Hi [~mjsax], As for me, KAFKA-3450 ha

[GitHub] [kafka] kkonstantine edited a comment on pull request #8722: KAFKA-5295: Allow source connectors to specify topic-specific settings for new topics (KIP-158)

kkonstantine edited a comment on pull request #8722: URL: https://github.com/apache/kafka/pull/8722#issuecomment-633282441 Thanks for your comments @rhauch ! I'll be addressing them shortly. I just added unit tests for the source connector configs and I'll be adding a few more plus the i

[GitHub] [kafka] rhauch commented on pull request #2604: KAFKA-4794: Add access to OffsetStorageReader from SourceConnector

rhauch commented on pull request #2604: URL: https://github.com/apache/kafka/pull/2604#issuecomment-633282850 All 3 builds had test failures on known flaky Streams integration tests, but all Connect-related tests passed. Thi

[GitHub] [kafka] kkonstantine commented on pull request #8722: KAFKA-5295: Allow source connectors to specify topic-specific settings for new topics (KIP-158)

kkonstantine commented on pull request #8722: URL: https://github.com/apache/kafka/pull/8722#issuecomment-633282441 Thanks for your comments @rhauch ! I'll addressing shortly. I just added unit tests for the source connector configs and I'll be adding a few more plus the integration test

[GitHub] [kafka] kkonstantine commented on a change in pull request #8722: KAFKA-5295: Allow source connectors to specify topic-specific settings for new topics (KIP-158)

kkonstantine commented on a change in pull request #8722: URL: https://github.com/apache/kafka/pull/8722#discussion_r429666897 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/SourceConnectorConfig.java ## @@ -16,21 +16,153 @@ */ package org.apac

[GitHub] [kafka] kkonstantine commented on a change in pull request #8722: KAFKA-5295: Allow source connectors to specify topic-specific settings for new topics (KIP-158)

kkonstantine commented on a change in pull request #8722: URL: https://github.com/apache/kafka/pull/8722#discussion_r429666952 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/integration/SourceConnectorsIntegrationTest.java ## @@ -0,0 +1,202 @@ +/* + * Lic

[GitHub] [kafka] rhauch commented on a change in pull request #8722: KAFKA-5295: Allow source connectors to specify topic-specific settings for new topics (KIP-158)

rhauch commented on a change in pull request #8722: URL: https://github.com/apache/kafka/pull/8722#discussion_r429658260 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConfig.java ## @@ -250,9 +250,16 @@ + "user requests to rese

[GitHub] [kafka] rhauch commented on a change in pull request #2604: KAFKA-4794: Add access to OffsetStorageReader from SourceConnector

rhauch commented on a change in pull request #2604: URL: https://github.com/apache/kafka/pull/2604#discussion_r429655139 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerConnectorTest.java ## @@ -85,7 +87,7 @@ public void testInitializeFailure

[GitHub] [kafka] rhauch removed a comment on pull request #2604: KAFKA-4794: Add access to OffsetStorageReader from SourceConnector

rhauch removed a comment on pull request #2604: URL: https://github.com/apache/kafka/pull/2604#issuecomment-633259362 retest this please This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [kafka] rhauch commented on pull request #2604: KAFKA-4794: Add access to OffsetStorageReader from SourceConnector

rhauch commented on pull request #2604: URL: https://github.com/apache/kafka/pull/2604#issuecomment-633259499 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] rhauch commented on pull request #2604: KAFKA-4794: Add access to OffsetStorageReader from SourceConnector

rhauch commented on pull request #2604: URL: https://github.com/apache/kafka/pull/2604#issuecomment-633259355 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Comment Edited] (KAFKA-9891) Invalid state store content after task migration with exactly_once and standby replicas

[ https://issues.apache.org/jira/browse/KAFKA-9891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17115366#comment-17115366 ] Mateusz Jadczyk edited comment on KAFKA-9891 at 5/24/20, 4:35 PM: -

[GitHub] [kafka] ijuma merged pull request #8714: MINOR: Improve broker registration and Log logging

ijuma merged pull request #8714: URL: https://github.com/apache/kafka/pull/8714 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] ijuma commented on pull request #8708: MINOR: avoid unnecessary seq iteration in ApiVersion.lastVersion

ijuma commented on pull request #8708: URL: https://github.com/apache/kafka/pull/8708#issuecomment-633257004 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log o

[jira] [Commented] (KAFKA-9891) Invalid state store content after task migration with exactly_once and standby replicas

[ https://issues.apache.org/jira/browse/KAFKA-9891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17115366#comment-17115366 ] Mateusz Jadczyk commented on KAFKA-9891: Maybe this could make this test more rel

[GitHub] [kafka] kkonstantine commented on a change in pull request #8722: KAFKA-5295: Allow source connectors to specify topic-specific settings for new topics (KIP-158)

kkonstantine commented on a change in pull request #8722: URL: https://github.com/apache/kafka/pull/8722#discussion_r429650887 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedConfig.java ## @@ -193,15 +192,6 @@ public st

[GitHub] [kafka] rhauch commented on a change in pull request #2604: KAFKA-4794: Add access to OffsetStorageReader from SourceConnector

rhauch commented on a change in pull request #2604: URL: https://github.com/apache/kafka/pull/2604#discussion_r429650611 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerConnectorTest.java ## @@ -416,6 +436,48 @@ public void testTransitionPaus

[GitHub] [kafka] rhauch commented on a change in pull request #2604: KAFKA-4794: Add access to OffsetStorageReader from SourceConnector

rhauch commented on a change in pull request #2604: URL: https://github.com/apache/kafka/pull/2604#discussion_r429650051 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConnector.java ## @@ -80,19 +86,14 @@ public void initialize(ConnectorCon

[jira] [Updated] (KAFKA-9891) Invalid state store content after task migration with exactly_once and standby replicas

[ https://issues.apache.org/jira/browse/KAFKA-9891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mateusz Jadczyk updated KAFKA-9891: --- Attachment: failedtest3 failedtest3_bug > Invalid state store content after t

[jira] [Commented] (KAFKA-9891) Invalid state store content after task migration with exactly_once and standby replicas

[ https://issues.apache.org/jira/browse/KAFKA-9891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17115352#comment-17115352 ] Mateusz Jadczyk commented on KAFKA-9891: BTW in this test (_failedtest3_) it also

[GitHub] [kafka] rhauch commented on a change in pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

rhauch commented on a change in pull request #8691: URL: https://github.com/apache/kafka/pull/8691#discussion_r429647155 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/storage/KafkaStatusBackingStoreFormatTest.java ## @@ -59,6 +59,7 @@ private static

[GitHub] [kafka] kkonstantine commented on pull request #8722: KAFKA-5295: Allow source connectors to specify topic-specific settings for new topics (KIP-158)

kkonstantine commented on pull request #8722: URL: https://github.com/apache/kafka/pull/8722#issuecomment-633247308 Rebased to resolve conflicts This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [kafka] kkonstantine commented on a change in pull request #2604: KAFKA-4794: Add access to OffsetStorageReader from SourceConnector

kkonstantine commented on a change in pull request #2604: URL: https://github.com/apache/kafka/pull/2604#discussion_r429641860 ## File path: connect/api/src/test/java/org/apache/kafka/connect/connector/ConnectorTest.java ## @@ -0,0 +1,198 @@ +/* + * Licensed to the Apache Soft

[jira] [Comment Edited] (KAFKA-9891) Invalid state store content after task migration with exactly_once and standby replicas

[ https://issues.apache.org/jira/browse/KAFKA-9891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17115324#comment-17115324 ] Mateusz Jadczyk edited comment on KAFKA-9891 at 5/24/20, 2:35 PM: -

[jira] [Commented] (KAFKA-9891) Invalid state store content after task migration with exactly_once and standby replicas

[ https://issues.apache.org/jira/browse/KAFKA-9891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17115324#comment-17115324 ] Mateusz Jadczyk commented on KAFKA-9891: I think I reproduce it in  [https://gith

[jira] [Updated] (KAFKA-9891) Invalid state store content after task migration with exactly_once and standby replicas

[ https://issues.apache.org/jira/browse/KAFKA-9891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mateusz Jadczyk updated KAFKA-9891: --- Attachment: failedtest2 failedtest > Invalid state store content after task m

[jira] [Resolved] (KAFKA-6755) MaskField SMT should optionally take a literal value to use instead of using null

[ https://issues.apache.org/jira/browse/KAFKA-6755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-6755. -- Fix Version/s: 2.6.0 Reviewer: Randall Hauch Resolution: Fixed [KIP-437|https:/

[GitHub] [kafka] rhauch merged pull request #6284: KAFKA-6755: Allow literal value for MaskField SMT

rhauch merged pull request #6284: URL: https://github.com/apache/kafka/pull/6284 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] rhauch commented on pull request #6284: KAFKA-6755: Allow literal value for MaskField SMT

rhauch commented on pull request #6284: URL: https://github.com/apache/kafka/pull/6284#issuecomment-633238260 One green build, and the others failed in non-Connect integration tests. This is an automated message from the Apac

[jira] [Resolved] (KAFKA-9767) Basic auth extension should have logging

[ https://issues.apache.org/jira/browse/KAFKA-9767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-9767. -- Fix Version/s: 2.6.0 Reviewer: Randall Hauch Resolution: Fixed Merged to the `t

[GitHub] [kafka] rhauch merged pull request #8357: KAFKA-9767: Add logging to basic auth rest extension

rhauch merged pull request #8357: URL: https://github.com/apache/kafka/pull/8357 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] rhauch commented on pull request #8357: KAFKA-9767: Add logging to basic auth rest extension

rhauch commented on pull request #8357: URL: https://github.com/apache/kafka/pull/8357#issuecomment-633236491 One green build, and two builds with only a flaky Streams test failure. This is an automated message from the Apach

[jira] [Resolved] (KAFKA-9944) Allow HTTP Response Headers to be Configured for Kafka Connect

[ https://issues.apache.org/jira/browse/KAFKA-9944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-9944. -- Reviewer: Randall Hauch Resolution: Fixed KIP-577 has been approved, and I merged the PR

[jira] [Assigned] (KAFKA-9944) Allow HTTP Response Headers to be Configured for Kafka Connect

[ https://issues.apache.org/jira/browse/KAFKA-9944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch reassigned KAFKA-9944: Assignee: Jeff Huang > Allow HTTP Response Headers to be Configured for Kafka Connect > --

[GitHub] [kafka] rhauch merged pull request #8620: KAFKA-9944: Added supporting customized HTTP response headers for Kafka Connect.

rhauch merged pull request #8620: URL: https://github.com/apache/kafka/pull/8620 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] rhauch commented on pull request #8620: KAFKA-9944: Added supporting customized HTTP response headers for Kafka Connect.

rhauch commented on pull request #8620: URL: https://github.com/apache/kafka/pull/8620#issuecomment-633234287 A few known flaky-test Streams failures in each of the 3 builds, and none were in Connect unit or integration tests. --

[GitHub] [kafka] rhauch commented on pull request #2604: KAFKA-4794: Add access to OffsetStorageReader from SourceConnector

rhauch commented on pull request #2604: URL: https://github.com/apache/kafka/pull/2604#issuecomment-633233831 Just one failure in each of the 3 builds, and none were in Connect unit or integration tests. This is an automated

[jira] [Commented] (KAFKA-6520) When a Kafka Stream can't communicate with the server, it's Status stays RUNNING

[ https://issues.apache.org/jira/browse/KAFKA-6520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17115097#comment-17115097 ] Vince Mu commented on KAFKA-6520: - [~mjsax] your explanation about coordinator metadata a