ijuma commented on pull request #8790:
URL: https://github.com/apache/kafka/pull/8790#issuecomment-637969959
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/KAFKA-9800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124602#comment-17124602
]
Cheng Tan commented on KAFKA-9800:
--
[~skaundinya] [~ijuma]
Thanks for the reply. Let's limit the patch
showuon commented on pull request #8790:
URL: https://github.com/apache/kafka/pull/8790#issuecomment-637956223
Thanks.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
hachikuji commented on pull request #8782:
URL: https://github.com/apache/kafka/pull/8782#issuecomment-637951729
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
hachikuji commented on pull request #8782:
URL: https://github.com/apache/kafka/pull/8782#issuecomment-637951668
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
hachikuji commented on pull request #8782:
URL: https://github.com/apache/kafka/pull/8782#issuecomment-637951275
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
hachikuji commented on a change in pull request #8782:
URL: https://github.com/apache/kafka/pull/8782#discussion_r434306556
##
File path:
core/src/test/scala/unit/kafka/coordinator/transaction/TransactionMarkerChannelManagerTest.scala
##
@@ -86,6 +90,70 @@ class
ijuma commented on pull request #8790:
URL: https://github.com/apache/kafka/pull/8790#issuecomment-637945661
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please log
ijuma commented on pull request #8790:
URL: https://github.com/apache/kafka/pull/8790#issuecomment-637945559
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
ijuma commented on pull request #8790:
URL: https://github.com/apache/kafka/pull/8790#issuecomment-637945035
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
abbccdda commented on pull request #8677:
URL: https://github.com/apache/kafka/pull/8677#issuecomment-637938760
@vvcephei Sounds good, let's wait for KIP-572 PR.
This is an automated message from the Apache Git Service.
To
ijuma commented on pull request #8790:
URL: https://github.com/apache/kafka/pull/8790#issuecomment-637934692
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
guozhangwang merged pull request #8786:
URL: https://github.com/apache/kafka/pull/8786
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
abbccdda commented on a change in pull request #8486:
URL: https://github.com/apache/kafka/pull/8486#discussion_r434289002
##
File path:
clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java
##
@@ -3831,7 +3845,12 @@ private void
[
https://issues.apache.org/jira/browse/KAFKA-10064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
feyman closed KAFKA-10064.
--
> Add documentation for KIP-571
> -
>
> Key: KAFKA-10064
>
[
https://issues.apache.org/jira/browse/KAFKA-10087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Boyang Chen updated KAFKA-10087:
Description:
For OffsetForLeaderEpoch#onSuccess, we could throw either OffsetOutOfRange or
jinshaoling created KAFKA-10088:
---
Summary: The ephemeral node [%s] at %s has gone away while reading
it
Key: KAFKA-10088
URL: https://issues.apache.org/jira/browse/KAFKA-10088
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-7940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124569#comment-17124569
]
Sophie Blee-Goldman commented on KAFKA-7940:
[
https://issues.apache.org/jira/browse/KAFKA-8264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124568#comment-17124568
]
Sophie Blee-Goldman commented on KAFKA-8264:
h3. Stacktrace
Boyang Chen created KAFKA-10087:
---
Summary: Properly throw LogTruncation exception from
OffsetForLeaderEpoch future
Key: KAFKA-10087
URL: https://issues.apache.org/jira/browse/KAFKA-10087
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-9974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124567#comment-17124567
]
Sophie Blee-Goldman commented on KAFKA-9974:
Failed again at a different point:
h3.
ableegoldman commented on pull request #8786:
URL: https://github.com/apache/kafka/pull/8786#issuecomment-637929991
Java14. passed
Java 11 failed with unrelated
`PlaintextProducerSendTest.testNonBlockingProducer`
Java 8 failed with four unrelated:
[
https://issues.apache.org/jira/browse/KAFKA-9516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124565#comment-17124565
]
Sophie Blee-Goldman commented on KAFKA-9516:
[
https://issues.apache.org/jira/browse/KAFKA-9295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sophie Blee-Goldman updated KAFKA-9295:
---
Affects Version/s: 2.6.0
>
[
https://issues.apache.org/jira/browse/KAFKA-9295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124564#comment-17124564
]
Sophie Blee-Goldman commented on KAFKA-9295:
Failed again:
showuon commented on pull request #8770:
URL: https://github.com/apache/kafka/pull/8770#issuecomment-637927162
In the quickstart, the 1st step we described is to download V2.5.0, and the
following steps work well in V2.5.0. @tonytony2020 , could you try again with
V2.5.0? Thanks.
showuon commented on pull request #8790:
URL: https://github.com/apache/kafka/pull/8790#issuecomment-637923073
@ijuma , could you review this small PR to upgrade spotbugsPlugin? Thanks.
This is an automated message from the
showuon opened a new pull request #8790:
URL: https://github.com/apache/kafka/pull/8790
Upgrade spotbugsPlugin to have clear error output to indicate where the
error is.
When investigating KAFKA-10081, I found the error output of spotbugs is very
poor. It doesn't even tell you
brary commented on pull request #8395:
URL: https://github.com/apache/kafka/pull/8395#issuecomment-637917600
Sorry, missed your earlier comment @mjsax . Is there any documentation
around which files need to be changed in kafka-site.
hachikuji commented on a change in pull request #8486:
URL: https://github.com/apache/kafka/pull/8486#discussion_r434267922
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/LogTruncationException.java
##
@@ -36,7 +36,8 @@
private final Map
vitojeng opened a new pull request #8789:
URL: https://github.com/apache/kafka/pull/8789
There are some broken links of streams javadoc, for example:
ReadOnlyKeyValueStore
ReadOnlyWindowStore
### Committer Checklist (excluded from commit message)
- [ ] Verify design and
showuon closed pull request #8778:
URL: https://github.com/apache/kafka/pull/8778
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
showuon commented on pull request #8778:
URL: https://github.com/apache/kafka/pull/8778#issuecomment-637914285
Close this PR since it'll be fixed in #8786. And #8788 will do the test
improvement. Thanks.
This is an
showuon commented on pull request #8788:
URL: https://github.com/apache/kafka/pull/8788#issuecomment-637913934
hi @ableegoldman , could you review this PR? Thanks.
This is an automated message from the Apache Git Service.
To
showuon opened a new pull request #8788:
URL: https://github.com/apache/kafka/pull/8788
Suggested by @ableegoldman in
https://github.com/apache/kafka/pull/8778#discussion_r434008302, remove the
unused isSticky assert out from tests only do `constrainedAssign`. I printed
out the test name
ableegoldman commented on pull request #8775:
URL: https://github.com/apache/kafka/pull/8775#issuecomment-637906677
Tests failed due to the broken consumer StickyAssignor test that will be
fixed via https://github.com/apache/kafka/pull/8786
hachikuji commented on a change in pull request #8724:
URL: https://github.com/apache/kafka/pull/8724#discussion_r434262971
##
File path: core/src/main/scala/kafka/controller/KafkaController.scala
##
@@ -1254,23 +1254,7 @@ class KafkaController(val config: KafkaConfig,
hachikuji commented on a change in pull request #8724:
URL: https://github.com/apache/kafka/pull/8724#discussion_r434262971
##
File path: core/src/main/scala/kafka/controller/KafkaController.scala
##
@@ -1254,23 +1254,7 @@ class KafkaController(val config: KafkaConfig,
guozhangwang commented on a change in pull request #8782:
URL: https://github.com/apache/kafka/pull/8782#discussion_r434258952
##
File path:
core/src/test/scala/unit/kafka/coordinator/transaction/TransactionMarkerChannelManagerTest.scala
##
@@ -86,6 +90,70 @@ class
hachikuji commented on pull request #8486:
URL: https://github.com/apache/kafka/pull/8486#issuecomment-637898597
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
hachikuji commented on pull request #8486:
URL: https://github.com/apache/kafka/pull/8486#issuecomment-637898692
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
ableegoldman commented on pull request #8786:
URL: https://github.com/apache/kafka/pull/8786#issuecomment-637891066
> Will wait for jenkins to pass.
At least we learned from all this
This is an automated message
guozhangwang commented on pull request #8786:
URL: https://github.com/apache/kafka/pull/8786#issuecomment-637889585
test this please
This is an automated message from the Apache Git Service.
To respond to the message, please
guozhangwang commented on pull request #8786:
URL: https://github.com/apache/kafka/pull/8786#issuecomment-637889673
LGTM. Will wait for jenkins to pass.
This is an automated message from the Apache Git Service.
To respond to
vvcephei commented on pull request #8787:
URL: https://github.com/apache/kafka/pull/8787#issuecomment-637888549
Ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
showuon commented on pull request #8786:
URL: https://github.com/apache/kafka/pull/8786#issuecomment-637886411
LGTM. Thanks @ableegoldman
This is an automated message from the Apache Git Service.
To respond to the message,
hachikuji commented on a change in pull request #8486:
URL: https://github.com/apache/kafka/pull/8486#discussion_r434246402
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/OffsetOutOfRangeException.java
##
@@ -30,8 +30,9 @@
private static final long
hachikuji commented on a change in pull request #8486:
URL: https://github.com/apache/kafka/pull/8486#discussion_r434245684
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/LogTruncationException.java
##
@@ -33,18 +32,8 @@
*/
public class
hachikuji commented on pull request #8486:
URL: https://github.com/apache/kafka/pull/8486#issuecomment-637884318
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
hachikuji commented on pull request #8486:
URL: https://github.com/apache/kafka/pull/8486#issuecomment-637884225
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
mjsax commented on pull request #8395:
URL: https://github.com/apache/kafka/pull/8395#issuecomment-637881053
@brary, did you see my last comment?
This is an automated message from the Apache Git Service.
To respond to the
badaiaqrandista commented on pull request #8644:
URL: https://github.com/apache/kafka/pull/8644#issuecomment-637879051
@ijuma Merged against trunk, fixed conflict in ConsumerConfig, and updated
upgrade.html.
This is an
ableegoldman opened a new pull request #8787:
URL: https://github.com/apache/kafka/pull/8787
Split out the optimized source changelogs and fetch the committed offsets
rather than the end offset for task lag computation
This
abbccdda commented on a change in pull request #8486:
URL: https://github.com/apache/kafka/pull/8486#discussion_r434237774
##
File path:
clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java
##
@@ -149,7 +148,11 @@
private TopicPartition tp1
abbccdda commented on a change in pull request #8486:
URL: https://github.com/apache/kafka/pull/8486#discussion_r434235476
##
File path:
clients/src/test/java/org/apache/kafka/common/requests/EpochEndOffsetTest.java
##
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software
ijuma edited a comment on pull request #8644:
URL: https://github.com/apache/kafka/pull/8644#issuecomment-637861009
Can you please rebase against trunk.
This is an automated message from the Apache Git Service.
To respond to
ijuma commented on pull request #8644:
URL: https://github.com/apache/kafka/pull/8644#issuecomment-637861009
Can you please rebase against master.
This is an automated message from the Apache Git Service.
To respond to the
badaiaqrandista commented on a change in pull request #8644:
URL: https://github.com/apache/kafka/pull/8644#discussion_r434227486
##
File path:
clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java
##
@@ -42,9 +42,11 @@
[
https://issues.apache.org/jira/browse/KAFKA-9945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe resolved KAFKA-9945.
-
Fix Version/s: 2.6.0
Reviewer: Colin McCabe
Resolution: Fixed
> TopicCommand
cmccabe closed pull request #8598:
URL: https://github.com/apache/kafka/pull/8598
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
mjsax commented on pull request #8759:
URL: https://github.com/apache/kafka/pull/8759#issuecomment-637856511
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
cmccabe commented on pull request #8598:
URL: https://github.com/apache/kafka/pull/8598#issuecomment-637856682
duplicate of #8737
This is an automated message from the Apache Git Service.
To respond to the message, please
cmccabe commented on pull request #8737:
URL: https://github.com/apache/kafka/pull/8737#issuecomment-637856338
Thanks @vinothchandar !
This is an automated message from the Apache Git Service.
To respond to the message,
cmccabe merged pull request #8737:
URL: https://github.com/apache/kafka/pull/8737
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
cmccabe commented on pull request #8737:
URL: https://github.com/apache/kafka/pull/8737#issuecomment-637855983
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
mjsax commented on pull request #8774:
URL: https://github.com/apache/kafka/pull/8774#issuecomment-637855089
Thanks for pointing out. This PR was opened first though :)
This is an automated message from the Apache Git
cmccabe commented on a change in pull request #8737:
URL: https://github.com/apache/kafka/pull/8737#discussion_r434223936
##
File path: core/src/main/scala/kafka/admin/TopicCommand.scala
##
@@ -259,24 +263,29 @@ object TopicCommand extends Logging {
override def
ableegoldman commented on pull request #8778:
URL: https://github.com/apache/kafka/pull/8778#issuecomment-637851109
Hey @showuon, this failing test has been blocking others so I submitted a
quick PR to fix it ASAP: https://github.com/apache/kafka/pull/8786
But as noted in the PR and
mjsax commented on a change in pull request #8776:
URL: https://github.com/apache/kafka/pull/8776#discussion_r434220229
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StandbyTask.java
##
@@ -247,6 +247,9 @@ private void close(final boolean
vvcephei commented on pull request #8775:
URL: https://github.com/apache/kafka/pull/8775#issuecomment-637850232
Test this please
This is an automated message from the Apache Git Service.
To respond to the message, please log
vvcephei commented on pull request #8775:
URL: https://github.com/apache/kafka/pull/8775#issuecomment-637849595
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
vvcephei commented on pull request #8775:
URL: https://github.com/apache/kafka/pull/8775#issuecomment-637849883
Test this please
This is an automated message from the Apache Git Service.
To respond to the message, please log
vvcephei commented on pull request #8775:
URL: https://github.com/apache/kafka/pull/8775#issuecomment-637849782
Test this please
This is an automated message from the Apache Git Service.
To respond to the message, please
hachikuji commented on a change in pull request #8782:
URL: https://github.com/apache/kafka/pull/8782#discussion_r434218326
##
File path:
core/src/test/scala/unit/kafka/coordinator/transaction/TransactionMarkerChannelManagerTest.scala
##
@@ -86,6 +90,70 @@ class
mjsax commented on a change in pull request #8776:
URL: https://github.com/apache/kafka/pull/8776#discussion_r434217796
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -613,10 +604,14 @@ private long
hachikuji commented on a change in pull request #8486:
URL: https://github.com/apache/kafka/pull/8486#discussion_r434208948
##
File path:
clients/src/test/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinatorTest.java
##
@@ -611,7 +611,7 @@ public void
ableegoldman opened a new pull request #8786:
URL: https://github.com/apache/kafka/pull/8786
Minimum fix needed to stop this test failing and unblock others
This is an automated message from the Apache Git Service.
To
mjsax commented on a change in pull request #8776:
URL: https://github.com/apache/kafka/pull/8776#discussion_r434217037
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
##
@@ -493,28 +549,45 @@ public void closeAndRecycleState()
mjsax commented on a change in pull request #8776:
URL: https://github.com/apache/kafka/pull/8776#discussion_r434216773
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
##
@@ -493,28 +542,45 @@ public void closeAndRecycleState()
mjsax commented on a change in pull request #8776:
URL: https://github.com/apache/kafka/pull/8776#discussion_r434215917
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
##
@@ -493,28 +549,45 @@ public void closeAndRecycleState()
ijuma commented on pull request #8778:
URL: https://github.com/apache/kafka/pull/8778#issuecomment-637846728
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
mjsax commented on a change in pull request #8776:
URL: https://github.com/apache/kafka/pull/8776#discussion_r434215315
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
##
@@ -247,48 +251,75 @@ public void completeRestoration()
ijuma commented on pull request #8774:
URL: https://github.com/apache/kafka/pull/8774#issuecomment-637844195
Btw, this had already been fixed by
https://github.com/apache/kafka/commit/a3d79ff23643d83f9df191522c003fb6335ca80c
.
ijuma merged pull request #8695:
URL: https://github.com/apache/kafka/pull/8695
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ijuma edited a comment on pull request #8695:
URL: https://github.com/apache/kafka/pull/8695#issuecomment-637842859
The failures are unrelated:
```
org.apache.kafka.clients.consumer.CooperativeStickyAssignorTest.testReassignmentWithRandomSubscriptionsAndChanges
ijuma commented on pull request #8695:
URL: https://github.com/apache/kafka/pull/8695#issuecomment-637842859
The failures are unrelated:
```
org.apache.kafka.clients.consumer.CooperativeStickyAssignorTest.testReassignmentWithRandomSubscriptionsAndChanges
badaiaqrandista commented on a change in pull request #8644:
URL: https://github.com/apache/kafka/pull/8644#discussion_r434209688
##
File path: clients/src/test/java/org/apache/kafka/clients/ClientUtilsTest.java
##
@@ -102,7 +102,7 @@ public void
badaiaqrandista commented on a change in pull request #8644:
URL: https://github.com/apache/kafka/pull/8644#discussion_r434204693
##
File path: clients/src/main/java/org/apache/kafka/clients/ClientUtils.java
##
@@ -108,10 +108,15 @@ public static ChannelBuilder
badaiaqrandista commented on a change in pull request #8644:
URL: https://github.com/apache/kafka/pull/8644#discussion_r434204767
##
File path: clients/src/main/java/org/apache/kafka/clients/ClientUtils.java
##
@@ -108,10 +108,15 @@ public static ChannelBuilder
[
https://issues.apache.org/jira/browse/KAFKA-9800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124354#comment-17124354
]
Ismael Juma commented on KAFKA-9800:
For a bit more context, the plan was to add per request timeout
navina commented on pull request #8684:
URL: https://github.com/apache/kafka/pull/8684#issuecomment-637827964
@ijuma I have removed the `intern()` calls. Please take a look. Thanks!
This is an automated message from the
ijuma commented on a change in pull request #8644:
URL: https://github.com/apache/kafka/pull/8644#discussion_r434196900
##
File path:
clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java
##
@@ -42,9 +42,11 @@
cmccabe edited a comment on pull request #8639:
URL: https://github.com/apache/kafka/pull/8639#issuecomment-637823813
The KIP clearly specifies that `describeCluster` will throw a UVE if
`authorizedOperations` is not supported, yet is requested:
> When the AdminClient is talking to
cmccabe edited a comment on pull request #8639:
URL: https://github.com/apache/kafka/pull/8639#issuecomment-637823813
The KIP clearly specifies that `describeCluster` will throw a UVE if
`authorizedOperations` is not supported, yet is requested:
bq. When the AdminClient is talking
[
https://issues.apache.org/jira/browse/KAFKA-9800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124340#comment-17124340
]
Sanjana Kaundinya commented on KAFKA-9800:
--
Here are my thoughts:
1) There should be no changes
cmccabe edited a comment on pull request #8639:
URL: https://github.com/apache/kafka/pull/8639#issuecomment-637823813
**The KIP clearly specifies that `describeCluster` will throw a UVE in this
case:
bq. When the AdminClient is talking to a broker which does not support
KIP-430, it
cmccabe commented on pull request #8639:
URL: https://github.com/apache/kafka/pull/8639#issuecomment-637823813
**The KIP clearly specifies that `describeCluster` will throw a UVE in this
case:
bq. When the AdminClient is talking to a broker which does not support
KIP-430, it will
guozhangwang commented on a change in pull request #8782:
URL: https://github.com/apache/kafka/pull/8782#discussion_r434173517
##
File path:
core/src/test/scala/unit/kafka/coordinator/transaction/TransactionMarkerChannelManagerTest.scala
##
@@ -291,7 +358,7 @@ class
badaiaqrandista commented on a change in pull request #8644:
URL: https://github.com/apache/kafka/pull/8644#discussion_r434171589
##
File path:
clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java
##
@@ -42,9 +42,11 @@
badaiaqrandista commented on a change in pull request #8644:
URL: https://github.com/apache/kafka/pull/8644#discussion_r434168481
##
File path: clients/src/main/java/org/apache/kafka/clients/ClientUtils.java
##
@@ -108,10 +108,15 @@ public static ChannelBuilder
1 - 100 of 234 matches
Mail list logo
