[jira] [Created] (KAFKA-10100) LiveLeaders field in LeaderAndIsrRequest is not used anymore

2020-06-04 Thread David Jacot (Jira)
David Jacot created KAFKA-10100: --- Summary: LiveLeaders field in LeaderAndIsrRequest is not used anymore Key: KAFKA-10100 URL: https://issues.apache.org/jira/browse/KAFKA-10100 Project: Kafka

[GitHub] [kafka] VinceMu commented on a change in pull request #8666: KAFKA-9479: Describe consumer group --state --all-groups show header once

2020-06-04 Thread GitBox
VinceMu commented on a change in pull request #8666: URL: https://github.com/apache/kafka/pull/8666#discussion_r435213295 ## File path: core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala ## @@ -291,14 +291,21 @@ object ConsumerGroupCommand extends Logging { }

[GitHub] [kafka] VinceMu commented on a change in pull request #8666: KAFKA-9479: Describe consumer group --state --all-groups show header once

2020-06-04 Thread GitBox
VinceMu commented on a change in pull request #8666: URL: https://github.com/apache/kafka/pull/8666#discussion_r435213295 ## File path: core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala ## @@ -291,14 +291,21 @@ object ConsumerGroupCommand extends Logging { }

[GitHub] [kafka] VinceMu commented on a change in pull request #8666: KAFKA-9479: Describe consumer group --state --all-groups show header once

2020-06-04 Thread GitBox
VinceMu commented on a change in pull request #8666: URL: https://github.com/apache/kafka/pull/8666#discussion_r435212607 ## File path: core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala ## @@ -291,14 +291,21 @@ object ConsumerGroupCommand extends Logging { }

[GitHub] [kafka] VinceMu commented on a change in pull request #8666: KAFKA-9479: Describe consumer group --state --all-groups show header once

2020-06-04 Thread GitBox
VinceMu commented on a change in pull request #8666: URL: https://github.com/apache/kafka/pull/8666#discussion_r435211987 ## File path: core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala ## @@ -291,14 +291,21 @@ object ConsumerGroupCommand extends Logging { }

[GitHub] [kafka] VinceMu commented on a change in pull request #8666: KAFKA-9479: Describe consumer group --state --all-groups show header once

2020-06-04 Thread GitBox
VinceMu commented on a change in pull request #8666: URL: https://github.com/apache/kafka/pull/8666#discussion_r435211667 ## File path: core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala ## @@ -291,14 +291,21 @@ object ConsumerGroupCommand extends Logging { }

[GitHub] [kafka] mimaison commented on a change in pull request #7577: KAFKA-9076: support consumer offset sync across clusters in MM 2.0

2020-06-04 Thread GitBox
mimaison commented on a change in pull request #7577: URL: https://github.com/apache/kafka/pull/7577#discussion_r435196589 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointTask.java ## @@ -188,4 +219,101 @@ public void

[GitHub] [kafka] mimaison commented on a change in pull request #7577: KAFKA-9076: support consumer offset sync across clusters in MM 2.0

2020-06-04 Thread GitBox
mimaison commented on a change in pull request #7577: URL: https://github.com/apache/kafka/pull/7577#discussion_r435134966 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointTask.java ## @@ -16,6 +16,13 @@ */ package

[GitHub] [kafka] badaiaqrandista commented on a change in pull request #8644: KAFKA-9313: Set `use_all_dns_ips` as the new default for `client.dns.lookup` (KIP-602)

2020-06-04 Thread GitBox
badaiaqrandista commented on a change in pull request #8644: URL: https://github.com/apache/kafka/pull/8644#discussion_r435179495 ## File path: clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java ## @@ -167,4 +176,13 @@ } return rval;

[GitHub] [kafka] tombentley commented on a change in pull request #8311: KAFKA-9434: automated protocol for alterReplicaLogDirs

2020-06-04 Thread GitBox
tombentley commented on a change in pull request #8311: URL: https://github.com/apache/kafka/pull/8311#discussion_r435162174 ## File path: clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java ## @@ -477,6 +484,27 @@ public void testCreateTopics()

[GitHub] [kafka] mimaison commented on pull request #8312: KAFKA-9432 automated protocol for DescribeConfigs

2020-06-04 Thread GitBox
mimaison commented on pull request #8312: URL: https://github.com/apache/kafka/pull/8312#issuecomment-638747057 Let's get https://github.com/apache/kafka/pull/8311 merged first and then rebase this one on top This is an

[GitHub] [kafka] mimaison commented on a change in pull request #8644: KAFKA-9313: Set `use_all_dns_ips` as the new default for `client.dns.lookup` (KIP-602)

2020-06-04 Thread GitBox
mimaison commented on a change in pull request #8644: URL: https://github.com/apache/kafka/pull/8644#discussion_r435128517 ## File path: clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java ## @@ -167,4 +176,13 @@ } return rval; } + +

[GitHub] [kafka] mimaison commented on pull request #8311: KAFKA-9434: automated protocol for alterReplicaLogDirs

2020-06-04 Thread GitBox
mimaison commented on pull request #8311: URL: https://github.com/apache/kafka/pull/8311#issuecomment-638740477 Thanks @tombentley for the PR. It looks good. Happy to merge once the last 2 comments are addressed This is an

[GitHub] [kafka] mimaison commented on a change in pull request #8311: KAFKA-9434: automated protocol for alterReplicaLogDirs

2020-06-04 Thread GitBox
mimaison commented on a change in pull request #8311: URL: https://github.com/apache/kafka/pull/8311#discussion_r435119315 ## File path: clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java ## @@ -477,6 +484,27 @@ public void testCreateTopics()

[GitHub] [kafka] dajac commented on pull request #8724: KAFKA-10040; Make computing the PreferredReplicaImbalanceCount metric more efficient

2020-06-04 Thread GitBox
dajac commented on pull request #8724: URL: https://github.com/apache/kafka/pull/8724#issuecomment-63871 @hachikuji Thanks for the review. I have updated the PR based on your feedback. This is an automated message from

[GitHub] [kafka] jiameixie commented on pull request #8446: KAFKA-9804:Extract consumer configs out of PerfConfig

2020-06-04 Thread GitBox
jiameixie commented on pull request #8446: URL: https://github.com/apache/kafka/pull/8446#issuecomment-638700185 Could you take a look at this PR? Thanks @huxihx This is an automated message from the Apache Git Service. To

[GitHub] [kafka] dajac commented on a change in pull request #8724: KAFKA-10040; Make computing the PreferredReplicaImbalanceCount metric more efficient

2020-06-04 Thread GitBox
dajac commented on a change in pull request #8724: URL: https://github.com/apache/kafka/pull/8724#discussion_r435085001 ## File path: core/src/main/scala/kafka/controller/ControllerContext.scala ## @@ -391,6 +404,90 @@ class ControllerContext {

[GitHub] [kafka] dajac commented on a change in pull request #8724: KAFKA-10040; Make computing the PreferredReplicaImbalanceCount metric more efficient

2020-06-04 Thread GitBox
dajac commented on a change in pull request #8724: URL: https://github.com/apache/kafka/pull/8724#discussion_r435076849 ## File path: core/src/main/scala/kafka/controller/ControllerContext.scala ## @@ -391,6 +404,90 @@ class ControllerContext {

[jira] [Commented] (KAFKA-10097) Avoid getting null map for task checkpoint

2020-06-04 Thread feyman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125652#comment-17125652 ] feyman commented on KAFKA-10097: Hi, [~bchen225242], I'm interested in kafka streams and would like to

[GitHub] [kafka] tombentley commented on pull request #8755: KAFKA-10069: Correctly remove user-defined "predicate" and "negate" configs from transformation properties

2020-06-04 Thread GitBox
tombentley commented on pull request #8755: URL: https://github.com/apache/kafka/pull/8755#issuecomment-638661645 Yes, thanks, that was a goot spot @chia7712! This is an automated message from the Apache Git Service. To

[GitHub] [kafka] highluck commented on pull request #8107: MINOR: Remove Diamond and code code Alignment

2020-06-04 Thread GitBox
highluck commented on pull request #8107: URL: https://github.com/apache/kafka/pull/8107#issuecomment-638630457 @vvcephei code update! This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (KAFKA-9203) kafka-client 2.3.1 fails to consume lz4 compressed topic

2020-06-04 Thread Vitalii Stoianov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125575#comment-17125575 ] Vitalii Stoianov commented on KAFKA-9203: - I know that tickets is resolved but: During uplift to

[GitHub] [kafka] ijuma commented on pull request #8644: KAFKA-9313: Set `use_all_dns_ips` as the new default for `client.dns.lookup` (KIP-602)

2020-06-04 Thread GitBox
ijuma commented on pull request #8644: URL: https://github.com/apache/kafka/pull/8644#issuecomment-638622720 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

<    1   2