[GitHub] [kafka] satishbellapu commented on pull request #8921: KAFKA-10160: Kafka MM2 consumer configuration

2020-06-23 Thread GitBox
satishbellapu commented on pull request #8921: URL: https://github.com/apache/kafka/pull/8921#issuecomment-648602105 @omkreddy cc This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] skaundinya15 commented on a change in pull request #8846: KAFKA-9800: [KIP-580] Client Exponential Backoff Implementation

2020-06-23 Thread GitBox
skaundinya15 commented on a change in pull request #8846: URL: https://github.com/apache/kafka/pull/8846#discussion_r444631685 ## File path: clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java ## @@ -84,6 +84,9 @@ public static final String

[GitHub] [kafka] skaundinya15 commented on a change in pull request #8846: KAFKA-9800: [KIP-580] Client Exponential Backoff Implementation

2020-06-23 Thread GitBox
skaundinya15 commented on a change in pull request #8846: URL: https://github.com/apache/kafka/pull/8846#discussion_r444631685 ## File path: clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java ## @@ -84,6 +84,9 @@ public static final String

[jira] [Comment Edited] (KAFKA-9800) [KIP-580] Client Exponential Backoff Implementation

2020-06-23 Thread Sanjana Kaundinya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124340#comment-17124340 ] Sanjana Kaundinya edited comment on KAFKA-9800 at 6/24/20, 4:24 AM:

[jira] [Comment Edited] (KAFKA-9800) [KIP-580] Client Exponential Backoff Implementation

2020-06-23 Thread Sanjana Kaundinya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124340#comment-17124340 ] Sanjana Kaundinya edited comment on KAFKA-9800 at 6/24/20, 4:24 AM:

[jira] [Resolved] (KAFKA-9678) Introduce bounded exponential backoff in clients

2020-06-23 Thread Sanjana Kaundinya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sanjana Kaundinya resolved KAFKA-9678. -- Resolution: Duplicate > Introduce bounded exponential backoff in clients >

[jira] [Commented] (KAFKA-9678) Introduce bounded exponential backoff in clients

2020-06-23 Thread Sanjana Kaundinya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143505#comment-17143505 ] Sanjana Kaundinya commented on KAFKA-9678: -- The work for this is being done by [~d8tltanc] in

[jira] [Updated] (KAFKA-10177) Replace/improve Percentiles metrics

2020-06-23 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-10177: Description: There's an existing – but seemingly unused – implementation of

[jira] [Updated] (KAFKA-10195) Move offset management codes from ConsumerCoordinator to a new class

2020-06-23 Thread dengziming (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dengziming updated KAFKA-10195: --- Description: ConsumerCoordinator has 2 main functions: # partitions assignment # offset 

[jira] [Updated] (KAFKA-10195) Move offset management codes from ConsumerCoordinator to a new class

2020-06-23 Thread dengziming (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dengziming updated KAFKA-10195: --- Description: ConsumerCoordinator has 2 main functions: # partitions assignment # offset 

[jira] [Updated] (KAFKA-10177) Replace/improve Percentiles metrics

2020-06-23 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-10177: Summary: Replace/improve Percentiles metrics (was: Replace/improve/remove

[jira] [Updated] (KAFKA-10195) Move offset management codes from ConsumerCoordinator to a new class

2020-06-23 Thread dengziming (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dengziming updated KAFKA-10195: --- Attachment: image-2020-06-24-10-47-44-733.png > Move offset management codes from

[jira] [Created] (KAFKA-10196) Add missing '--version' option to Kafka command producer-performance

2020-06-23 Thread jiamei xie (Jira)
jiamei xie created KAFKA-10196: -- Summary: Add missing '--version' option to Kafka command producer-performance Key: KAFKA-10196 URL: https://issues.apache.org/jira/browse/KAFKA-10196 Project: Kafka

[jira] [Commented] (KAFKA-10175) MetadataCache::getClusterMetadata returns null for offline replicas

2020-06-23 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143453#comment-17143453 ] Chia-Ping Tsai commented on KAFKA-10175: just curious, does it cause exception on production? >

[jira] [Commented] (KAFKA-10140) Incremental config api excludes plugin config changes

2020-06-23 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143449#comment-17143449 ] Chia-Ping Tsai commented on KAFKA-10140: It seems to me users should be aware of the config they

[GitHub] [kafka] mjsax commented on pull request #8919: HOTFIX: use .equals to compare HostInfo in StreamsMetadataState

2020-06-23 Thread GitBox
mjsax commented on pull request #8919: URL: https://github.com/apache/kafka/pull/8919#issuecomment-648534515 Merged to `2.5` and cherry-picked to `2.4`. It's fixed in `trunk` and `2.6` via #8900 This is an automated

[GitHub] [kafka] mjsax merged pull request #8919: HOTFIX: use .equals to compare HostInfo in StreamsMetadataState

2020-06-23 Thread GitBox
mjsax merged pull request #8919: URL: https://github.com/apache/kafka/pull/8919 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (KAFKA-9846) Race condition can lead to severe lag underestimate for active tasks

2020-06-23 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143437#comment-17143437 ] Sophie Blee-Goldman commented on KAFKA-9846: I think we can just leave it open and maybe

[GitHub] [kafka] ableegoldman commented on pull request #8919: HOTFIX: use .equals to compare HostInfo in StreamsMetadataState

2020-06-23 Thread GitBox
ableegoldman commented on pull request #8919: URL: https://github.com/apache/kafka/pull/8919#issuecomment-648526072 Wow, all tests passed on the first try! cc @mjsax This is an automated message from the Apache Git Service.

[GitHub] [kafka] guozhangwang commented on pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

2020-06-23 Thread GitBox
guozhangwang commented on pull request #8900: URL: https://github.com/apache/kafka/pull/8900#issuecomment-648525527 Merged to trunk and cherry-picked to 2.6 This is an automated message from the Apache Git Service. To

[GitHub] [kafka] guozhangwang merged pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

2020-06-23 Thread GitBox
guozhangwang merged pull request #8900: URL: https://github.com/apache/kafka/pull/8900 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] satishbellapu commented on a change in pull request #8921: KAFKA-10160: Kafka MM2 consumer configuration

2020-06-23 Thread GitBox
satishbellapu commented on a change in pull request #8921: URL: https://github.com/apache/kafka/pull/8921#discussion_r444586705 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorConnectorConfig.java ## @@ -123,6 +125,10 @@ private static

[GitHub] [kafka] ryannedolan commented on a change in pull request #8921: KAFKA-10160: Kafka MM2 consumer configuration

2020-06-23 Thread GitBox
ryannedolan commented on a change in pull request #8921: URL: https://github.com/apache/kafka/pull/8921#discussion_r444580176 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorConnectorConfig.java ## @@ -123,6 +125,10 @@ private static

[jira] [Commented] (KAFKA-9935) Kafka not releasing member from Consumer Group

2020-06-23 Thread Steve Kecskes (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143428#comment-17143428 ] Steve Kecskes commented on KAFKA-9935: -- Agreed, it does look similar to KAFKA-10105. I see further

[jira] [Commented] (KAFKA-10160) Kafka MM2 consumer configuration

2020-06-23 Thread sats (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143427#comment-17143427 ] sats commented on KAFKA-10160: -- Created a pull request [https://github.com/apache/kafka/pull/8921] > Kafka

[GitHub] [kafka] satishbellapu opened a new pull request #8921: Update MirrorConnectorConfig.java

2020-06-23 Thread GitBox
satishbellapu opened a new pull request #8921: URL: https://github.com/apache/kafka/pull/8921 KAFKA-10160: Removed hardcoded auto.offset.reset in MM2 consumer configuration, retained default as earliest unless specified. ### Committer Checklist (excluded from commit message) -

[GitHub] [kafka] mjsax commented on a change in pull request #8920: DOCS-4446: document timestamped state stores

2020-06-23 Thread GitBox
mjsax commented on a change in pull request #8920: URL: https://github.com/apache/kafka/pull/8920#discussion_r444554053 ## File path: docs/streams/developer-guide/processor-api.html ## @@ -49,6 +49,7 @@ Defining and creating a State Store

[GitHub] [kafka] ableegoldman commented on a change in pull request #8712: KAFKA-10006: Don't create internal topics when LeaderNotAvailableException

2020-06-23 Thread GitBox
ableegoldman commented on a change in pull request #8712: URL: https://github.com/apache/kafka/pull/8712#discussion_r444555724 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java ## @@ -98,9 +98,10 @@ public

[GitHub] [kafka] guozhangwang commented on pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

2020-06-23 Thread GitBox
guozhangwang commented on pull request #8900: URL: https://github.com/apache/kafka/pull/8900#issuecomment-648472153 LGTM! I will merge after green jenkins. This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] ableegoldman commented on a change in pull request #8902: KAFKA-10179: Pass correct changelog topic to state serdes

2020-06-23 Thread GitBox
ableegoldman commented on a change in pull request #8902: URL: https://github.com/apache/kafka/pull/8902#discussion_r444552897 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractProcessorStateManager.java ## @@ -0,0 +1,33 @@ +/* + *

[GitHub] [kafka] JimGalasyn opened a new pull request #8920: DOCS-4446: document timestamped state stores

2020-06-23 Thread GitBox
JimGalasyn opened a new pull request #8920: URL: https://github.com/apache/kafka/pull/8920 Add a section on the timestamped state store interfaces, per [KIP-258](https://cwiki.apache.org/confluence/display/KAFKA/KIP-258%3A+Allow+to+Store+Record+Timestamps+in+RocksDB).

[GitHub] [kafka] mjsax commented on a change in pull request #8902: KAFKA-10179: Pass correct changelog topic to state serdes

2020-06-23 Thread GitBox
mjsax commented on a change in pull request #8902: URL: https://github.com/apache/kafka/pull/8902#discussion_r444541033 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java ## @@ -402,4 +402,9 @@ public TaskType

[GitHub] [kafka] mjsax commented on pull request #8902: KAFKA-10179: Pass correct changelog topic to state serdes

2020-06-23 Thread GitBox
mjsax commented on pull request #8902: URL: https://github.com/apache/kafka/pull/8902#issuecomment-648462369 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] abbccdda commented on pull request #8585: KAFKA-9938; Debug consumer should be able to fetch from followers

2020-06-23 Thread GitBox
abbccdda commented on pull request #8585: URL: https://github.com/apache/kafka/pull/8585#issuecomment-648460501 Only known flaky test failures: ``` org.apache.kafka.connect.mirror.MirrorConnectorsIntegrationTest.testReplication

[GitHub] [kafka] abbccdda commented on pull request #8107: MINOR: Remove Diamond and code code Alignment

2020-06-23 Thread GitBox
abbccdda commented on pull request #8107: URL: https://github.com/apache/kafka/pull/8107#issuecomment-648459539 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] abbccdda commented on pull request #6737: KAFKA-8338: consumer offset expiration should consider subscription.

2020-06-23 Thread GitBox
abbccdda commented on pull request #6737: URL: https://github.com/apache/kafka/pull/6737#issuecomment-648459250 Closed according to @dajac source. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] abbccdda closed pull request #6737: KAFKA-8338: consumer offset expiration should consider subscription.

2020-06-23 Thread GitBox
abbccdda closed pull request #6737: URL: https://github.com/apache/kafka/pull/6737 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] mjsax commented on pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

2020-06-23 Thread GitBox
mjsax commented on pull request #8900: URL: https://github.com/apache/kafka/pull/8900#issuecomment-648457282 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] mjsax commented on pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

2020-06-23 Thread GitBox
mjsax commented on pull request #8900: URL: https://github.com/apache/kafka/pull/8900#issuecomment-648456919 Retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] mjsax commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

2020-06-23 Thread GitBox
mjsax commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r444538711 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/RecordCollectorTest.java ## @@ -474,6 +492,7 @@ public void

[GitHub] [kafka] mjsax commented on pull request #8919: HOTFIX: use .equals to compare HostInfo in StreamsMetadataState

2020-06-23 Thread GitBox
mjsax commented on pull request #8919: URL: https://github.com/apache/kafka/pull/8919#issuecomment-648456709 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] ableegoldman commented on pull request #8919: HOTFIX: use .equals to compare HostInfo in StreamsMetadataState

2020-06-23 Thread GitBox
ableegoldman commented on pull request #8919: URL: https://github.com/apache/kafka/pull/8919#issuecomment-648455230 cc @mjsax This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] ableegoldman commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

2020-06-23 Thread GitBox
ableegoldman commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r444537297 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsMetadataState.java ## @@ -152,9 +152,9 @@ public

[GitHub] [kafka] ableegoldman opened a new pull request #8919: HOTFIX: use .equals to compare HostInfo in StreamsMetadataState

2020-06-23 Thread GitBox
ableegoldman opened a new pull request #8919: URL: https://github.com/apache/kafka/pull/8919 Hotfix for patching this in older branches This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] abbccdda merged pull request #8845: KAFKA-10126:Add a warning message for ConsumerPerformance

2020-06-23 Thread GitBox
abbccdda merged pull request #8845: URL: https://github.com/apache/kafka/pull/8845 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (KAFKA-9509) Fix flaky test MirrorConnectorsIntegrationTest.testReplication

2020-06-23 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143314#comment-17143314 ] Boyang Chen commented on KAFKA-9509: Failed again: h3. Stacktrace java.lang.RuntimeException: Could

[GitHub] [kafka] abbccdda commented on pull request #8845: KAFKA-10126:Add a warning message for ConsumerPerformance

2020-06-23 Thread GitBox
abbccdda commented on pull request #8845: URL: https://github.com/apache/kafka/pull/8845#issuecomment-648449655 Having tested 3 * 3 times, and only flaky test failed such as this one: https://issues.apache.org/jira/browse/KAFKA-9509

[GitHub] [kafka] ableegoldman commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

2020-06-23 Thread GitBox
ableegoldman commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r444530988 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/RecordCollectorTest.java ## @@ -474,6 +492,7 @@ public void

[GitHub] [kafka] ableegoldman commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

2020-06-23 Thread GitBox
ableegoldman commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r444528622 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/RecordCollectorTest.java ## @@ -474,6 +492,7 @@ public void

[GitHub] [kafka] mjsax commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

2020-06-23 Thread GitBox
mjsax commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r444526844 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/RecordCollectorTest.java ## @@ -474,6 +492,7 @@ public void

[GitHub] [kafka] mjsax commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

2020-06-23 Thread GitBox
mjsax commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r444526844 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/RecordCollectorTest.java ## @@ -474,6 +492,7 @@ public void

[GitHub] [kafka] ableegoldman commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

2020-06-23 Thread GitBox
ableegoldman commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r444525997 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -679,92 +675,166 @@ private void

[GitHub] [kafka] ableegoldman commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

2020-06-23 Thread GitBox
ableegoldman commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r444522543 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsMetadataState.java ## @@ -152,9 +152,9 @@ public

[GitHub] [kafka] mjsax commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

2020-06-23 Thread GitBox
mjsax commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r444518329 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -679,92 +675,166 @@ private void cleanupTask(final

[GitHub] [kafka] mjsax commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

2020-06-23 Thread GitBox
mjsax commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r444517907 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -679,92 +675,166 @@ private void cleanupTask(final

[GitHub] [kafka] mjsax commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

2020-06-23 Thread GitBox
mjsax commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r444517746 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -679,92 +675,166 @@ private void cleanupTask(final

[GitHub] [kafka] mjsax commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

2020-06-23 Thread GitBox
mjsax commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r444516858 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsMetadataState.java ## @@ -152,9 +152,9 @@ public StreamsMetadata

[GitHub] [kafka] abbccdda merged pull request #8174: KAFKA-9439: add KafkaProducer API unit tests

2020-06-23 Thread GitBox
abbccdda merged pull request #8174: URL: https://github.com/apache/kafka/pull/8174 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] mimaison commented on a change in pull request #8604: KIP-597: MirrorMaker2 internal topics Formatters

2020-06-23 Thread GitBox
mimaison commented on a change in pull request #8604: URL: https://github.com/apache/kafka/pull/8604#discussion_r444504939 ## File path: core/src/main/scala/kafka/tools/ConsoleConsumer.scala ## @@ -560,16 +561,15 @@ class LoggingMessageFormatter extends MessageFormatter with

[GitHub] [kafka] ableegoldman commented on pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

2020-06-23 Thread GitBox
ableegoldman commented on pull request #8900: URL: https://github.com/apache/kafka/pull/8900#issuecomment-648404327 One unrelated failure: `PlaintextProducerSendTest.testNonBlockingProducer` This is an automated message from

[jira] [Commented] (KAFKA-9846) Race condition can lead to severe lag underestimate for active tasks

2020-06-23 Thread Vinoth Chandar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143275#comment-17143275 ] Vinoth Chandar commented on KAFKA-9846: --- Sounds good. Close this as "Wont fix" then? > Race

[jira] [Commented] (KAFKA-10179) State Store Passes Wrong Changelog Topic to Serde for Optimized Source Tables

2020-06-23 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143238#comment-17143238 ] Sophie Blee-Goldman commented on KAFKA-10179: - [~desai.p.rohan] I'm not sure I understand

[jira] [Commented] (KAFKA-9846) Race condition can lead to severe lag underestimate for active tasks

2020-06-23 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143228#comment-17143228 ] Sophie Blee-Goldman commented on KAFKA-9846: Ok no worries. I don't think it's critical, just

[GitHub] [kafka] cyrusv opened a new pull request #8918: Use debug level logging for noisy log messages in Connect

2020-06-23 Thread GitBox
cyrusv opened a new pull request #8918: URL: https://github.com/apache/kafka/pull/8918 This very simply reduces the log level for these very frequently logged, very infrequently useful log messages to debug level. My experience operating these connectors is that these logs make reading

[jira] [Commented] (KAFKA-10105) Regression in group coordinator dealing with flaky clients joining while leaving

2020-06-23 Thread Gokul Ramanan Subramanian (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143168#comment-17143168 ] Gokul Ramanan Subramanian commented on KAFKA-10105: --- [~ableegoldman], we are unable to

[jira] [Commented] (KAFKA-9846) Race condition can lead to severe lag underestimate for active tasks

2020-06-23 Thread Vinoth Chandar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143158#comment-17143158 ] Vinoth Chandar commented on KAFKA-9846: --- Probably don't have time this week.. But if y'all can take

[jira] [Commented] (KAFKA-10140) Incremental config api excludes plugin config changes

2020-06-23 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143153#comment-17143153 ] Ismael Juma commented on KAFKA-10140: - I understand now. Yeah, I ran into this issue before when

[jira] [Commented] (KAFKA-10192) Flaky test BlockingConnectorTest#testBlockInConnectorStop

2020-06-23 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143135#comment-17143135 ] Chris Egerton commented on KAFKA-10192: --- I think what might be happening is that the worker is

[GitHub] [kafka] ableegoldman commented on a change in pull request #8913: KAFKA-10191 fix flaky StreamsOptimizedTest - call KafkaStreams#cleanU…

2020-06-23 Thread GitBox
ableegoldman commented on a change in pull request #8913: URL: https://github.com/apache/kafka/pull/8913#discussion_r444383211 ## File path: streams/src/test/java/org/apache/kafka/streams/tests/StreamsOptimizedTest.java ## @@ -130,6 +130,8 @@ public static void main(final

[GitHub] [kafka] guozhangwang commented on pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

2020-06-23 Thread GitBox
guozhangwang commented on pull request #8900: URL: https://github.com/apache/kafka/pull/8900#issuecomment-648298106 test this This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] chia7712 commented on a change in pull request #8913: KAFKA-10191 fix flaky StreamsOptimizedTest - call KafkaStreams#cleanU…

2020-06-23 Thread GitBox
chia7712 commented on a change in pull request #8913: URL: https://github.com/apache/kafka/pull/8913#discussion_r444374011 ## File path: streams/src/test/java/org/apache/kafka/streams/tests/StreamsOptimizedTest.java ## @@ -130,6 +130,8 @@ public static void main(final

[GitHub] [kafka] chia7712 commented on a change in pull request #8913: KAFKA-10191 fix flaky StreamsOptimizedTest - call KafkaStreams#cleanU…

2020-06-23 Thread GitBox
chia7712 commented on a change in pull request #8913: URL: https://github.com/apache/kafka/pull/8913#discussion_r444373556 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientState.java ## @@ -303,7 +303,8 @@ public void

[jira] [Commented] (KAFKA-10140) Incremental config api excludes plugin config changes

2020-06-23 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143112#comment-17143112 ] Chia-Ping Tsai commented on KAFKA-10140: alterConfigs does not support APPEND and SUBTRACT so it

[GitHub] [kafka] nizhikov opened a new pull request #8917: KAFKA-10180: Fix security_config caching.

2020-06-23 Thread GitBox
nizhikov opened a new pull request #8917: URL: https://github.com/apache/kafka/pull/8917 After 8b22b8159673bfe22d8ac5dcd4e4312d4f2c863c `security_config` properties are modified during `setup_node`: tls_version patched according to the node jdk version. But python `@property` decorator

[GitHub] [kafka] ableegoldman commented on a change in pull request #8913: KAFKA-10191 fix flaky StreamsOptimizedTest - call KafkaStreams#cleanU…

2020-06-23 Thread GitBox
ableegoldman commented on a change in pull request #8913: URL: https://github.com/apache/kafka/pull/8913#discussion_r444368127 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientState.java ## @@ -303,7 +303,8 @@ public void

[GitHub] [kafka] d8tltanc commented on pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

2020-06-23 Thread GitBox
d8tltanc commented on pull request #8683: URL: https://github.com/apache/kafka/pull/8683#issuecomment-648288498 @dajac @rajinisivaram Thanks for the second round of review. I've addressed your comments and adopted your suggestions. Please let me know if you have more thoughts on this PR.

[jira] [Commented] (KAFKA-10140) Incremental config api excludes plugin config changes

2020-06-23 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143108#comment-17143108 ] Ismael Juma commented on KAFKA-10140: - We should check why alterConfigs handles this correctly and

[jira] [Commented] (KAFKA-10191) fix flaky StreamsOptimizedTest - call KafkaStreams#cleanUp before starting the application up the second time

2020-06-23 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143105#comment-17143105 ] Sophie Blee-Goldman commented on KAFKA-10191: - Cool. Since this is failing pretty regularly,

[jira] [Comment Edited] (KAFKA-10140) Incremental config api excludes plugin config changes

2020-06-23 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143094#comment-17143094 ] Chia-Ping Tsai edited comment on KAFKA-10140 at 6/23/20, 4:49 PM: -- The

[jira] [Updated] (KAFKA-10194) run the reset tool between stopping StreamsOptimizedTest and starting the new one

2020-06-23 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-10194: Labels: newbie (was: ) > run the reset tool between stopping

[jira] [Updated] (KAFKA-10194) run the reset tool between stopping StreamsOptimizedTest and starting the new one

2020-06-23 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-10194: Component/s: system tests streams > run the reset tool between

[GitHub] [kafka] skaundinya15 commented on pull request #8894: KAFKA-9509: increase consume timeout to fix flaky test

2020-06-23 Thread GitBox
skaundinya15 commented on pull request #8894: URL: https://github.com/apache/kafka/pull/8894#issuecomment-648280522 @showuon no more comments > Hi @ryannedolan @skaundinya15 , do you have any other comments? I think we should merge this PR soon since the tests fails today's test

[GitHub] [kafka] skaundinya15 edited a comment on pull request #8894: KAFKA-9509: increase consume timeout to fix flaky test

2020-06-23 Thread GitBox
skaundinya15 edited a comment on pull request #8894: URL: https://github.com/apache/kafka/pull/8894#issuecomment-648280522 > Hi @ryannedolan @skaundinya15 , do you have any other comments? I think we should merge this PR soon since the tests fails today's test again. Thanks.

[jira] [Commented] (KAFKA-10140) Incremental config api excludes plugin config changes

2020-06-23 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143094#comment-17143094 ] Chia-Ping Tsai commented on KAFKA-10140: The plugin component, like JmxReporter, does not offer

[jira] [Commented] (KAFKA-10192) Flaky test BlockingConnectorTest#testBlockInConnectorStop

2020-06-23 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143092#comment-17143092 ] Chris Egerton commented on KAFKA-10192: --- [~bchen225242] I have a hypothesis for why these tests

[jira] [Assigned] (KAFKA-10192) Flaky test BlockingConnectorTest#testBlockInConnectorStop

2020-06-23 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton reassigned KAFKA-10192: - Assignee: Chris Egerton > Flaky test BlockingConnectorTest#testBlockInConnectorStop >

[GitHub] [kafka] cadonna commented on pull request #8902: KAFKA-10179: Pass correct changelog topic to state serdes

2020-06-23 Thread GitBox
cadonna commented on pull request #8902: URL: https://github.com/apache/kafka/pull/8902#issuecomment-648271480 @ableegoldman could you also have a look at this PR since I think I changed some code you are quite familiar with.

[jira] [Commented] (KAFKA-10173) BufferUnderflowException during Kafka Streams Upgrade

2020-06-23 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143075#comment-17143075 ] John Roesler commented on KAFKA-10173: -- Hi [~karsten.schnitter] , Thanks for your efforts. I'm

[GitHub] [kafka] junrao commented on pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-06-23 Thread GitBox
junrao commented on pull request #8657: URL: https://github.com/apache/kafka/pull/8657#issuecomment-648259565 Thanks. Triggering another round of system tests. This is an automated message from the Apache Git Service. To

[jira] [Commented] (KAFKA-10173) BufferUnderflowException during Kafka Streams Upgrade

2020-06-23 Thread Karsten Schnitter (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143066#comment-17143066 ] Karsten Schnitter commented on KAFKA-10173: --- Hi [~vvcephei], the original message is lost due

[GitHub] [kafka] cadonna commented on a change in pull request #8902: KAFKA-10179: Pass correct changelog topic to state serdes

2020-06-23 Thread GitBox
cadonna commented on a change in pull request #8902: URL: https://github.com/apache/kafka/pull/8902#discussion_r444334835 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/graph/TableSourceNodeTest.java ## @@ -0,0 +1,58 @@ +/* + * Licensed to the

[GitHub] [kafka] chia7712 commented on pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-06-23 Thread GitBox
chia7712 commented on pull request #8657: URL: https://github.com/apache/kafka/pull/8657#issuecomment-648254987 > Could you rebase your PR? done This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] junrao commented on pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-06-23 Thread GitBox
junrao commented on pull request #8657: URL: https://github.com/apache/kafka/pull/8657#issuecomment-648254407 @chia7712 : I think the client compatibility test failures are probably because you haven't rebased the PR. #8841 was fixed 6 days ago. Could you rebase your PR?

[GitHub] [kafka] junrao commented on pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-06-23 Thread GitBox
junrao commented on pull request #8657: URL: https://github.com/apache/kafka/pull/8657#issuecomment-648249808 There were still lots of client compatibility related failures

[GitHub] [kafka] cadonna commented on a change in pull request #8902: KAFKA-10179: Pass correct changelog topic to state serdes

2020-06-23 Thread GitBox
cadonna commented on a change in pull request #8902: URL: https://github.com/apache/kafka/pull/8902#discussion_r444325329 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorContextImpl.java ## @@ -120,7 +118,7 @@ public void

[GitHub] [kafka] cadonna commented on a change in pull request #8902: KAFKA-10179: Pass correct changelog topic to state serdes

2020-06-23 Thread GitBox
cadonna commented on a change in pull request #8902: URL: https://github.com/apache/kafka/pull/8902#discussion_r444321667 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorContextImpl.java ## @@ -103,7 +102,6 @@ public

[GitHub] [kafka] cadonna commented on a change in pull request #8902: KAFKA-10179: Pass correct changelog topic to state serdes

2020-06-23 Thread GitBox
cadonna commented on a change in pull request #8902: URL: https://github.com/apache/kafka/pull/8902#discussion_r444321079 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java ## @@ -103,8 +104,12 @@ public void init(final

[GitHub] [kafka] cadonna commented on a change in pull request #8902: KAFKA-10179: Pass correct changelog topic to state serdes

2020-06-23 Thread GitBox
cadonna commented on a change in pull request #8902: URL: https://github.com/apache/kafka/pull/8902#discussion_r444319623 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java ## @@ -103,8 +104,12 @@ public void init(final

[jira] [Commented] (KAFKA-10192) Flaky test BlockingConnectorTest#testBlockInConnectorStop

2020-06-23 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143052#comment-17143052 ] Boyang Chen commented on KAFKA-10192: - Failed again: 

[GitHub] [kafka] abbccdda commented on pull request #8845: KAFKA-10126:Add a warning message for ConsumerPerformance

2020-06-23 Thread GitBox
abbccdda commented on pull request #8845: URL: https://github.com/apache/kafka/pull/8845#issuecomment-648242282 Also failed: ``` kafka.api.PlaintextAdminIntegrationTest.testAlterReplicaLogDirs org.scalatest.exceptions.TestFailedException: only 0 messages are produced within

  1   2   >