[GitHub] [kafka] guozhangwang commented on pull request #8934: KAFKA-10134: Use long poll if we do not have fetchable partitions

2020-06-30 Thread GitBox
guozhangwang commented on pull request #8934: URL: https://github.com/apache/kafka/pull/8934#issuecomment-652202875 @hachikuji Could you take a look at this one since it is a 2.6 blocker? Another alternative if we are less comfortable with the current exponential timeout

[jira] [Commented] (KAFKA-10134) High CPU issue during rebalance in Kafka consumer after upgrading to 2.5

2020-06-30 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17149122#comment-17149122 ] Guozhang Wang commented on KAFKA-10134: --- I've updated the PR. > High CPU issue during rebalance

[GitHub] [kafka] showuon edited a comment on pull request #8712: KAFKA-10006: Don't create internal topics when LeaderNotAvailableException

2020-06-30 Thread GitBox
showuon edited a comment on pull request #8712: URL: https://github.com/apache/kafka/pull/8712#issuecomment-652177809 Thanks for the comments, @abbccdda . I've address your comments in this commit: https://github.com/apache/kafka/pull/8712/commits/4b57a606a3834323302b6d3d33ab95e5b88d183b

[GitHub] [kafka] showuon commented on pull request #8712: KAFKA-10006: Don't create internal topics when LeaderNotAvailableException

2020-06-30 Thread GitBox
showuon commented on pull request #8712: URL: https://github.com/apache/kafka/pull/8712#issuecomment-652177809 Thanks for the comments, @abbccdda . I've address your comments in this commit: https://github.com/apache/kafka/pull/8712/commits/4b57a606a3834323302b6d3d33ab95e5b88d183b

[GitHub] [kafka] showuon commented on a change in pull request #8712: KAFKA-10006: Don't create internal topics when LeaderNotAvailableException

2020-06-30 Thread GitBox
showuon commented on a change in pull request #8712: URL: https://github.com/apache/kafka/pull/8712#discussion_r448103331 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/InternalTopicManagerTest.java ## @@ -287,12 +290,124 @@ public void

[GitHub] [kafka] showuon commented on a change in pull request #8712: KAFKA-10006: Don't create internal topics when LeaderNotAvailableException

2020-06-30 Thread GitBox
showuon commented on a change in pull request #8712: URL: https://github.com/apache/kafka/pull/8712#discussion_r448100930 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/InternalTopicManagerTest.java ## @@ -287,12 +290,124 @@ public void

[GitHub] [kafka] showuon commented on a change in pull request #8712: KAFKA-10006: Don't create internal topics when LeaderNotAvailableException

2020-06-30 Thread GitBox
showuon commented on a change in pull request #8712: URL: https://github.com/apache/kafka/pull/8712#discussion_r448100994 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/InternalTopicManagerTest.java ## @@ -287,12 +290,124 @@ public void

[GitHub] [kafka] vvcephei commented on pull request #8938: KAFKA-10173: Use SmokeTest for upgrade system tests

2020-06-30 Thread GitBox
vvcephei commented on pull request #8938: URL: https://github.com/apache/kafka/pull/8938#issuecomment-652173502 I had a chat with @ableegoldman earlier today. As a general strategy, maybe what we can do is aim to repair the non-downgradability where it exists. For example, when we

[GitHub] [kafka] showuon commented on a change in pull request #8712: KAFKA-10006: Don't create internal topics when LeaderNotAvailableException

2020-06-30 Thread GitBox
showuon commented on a change in pull request #8712: URL: https://github.com/apache/kafka/pull/8712#discussion_r448099598 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/InternalTopicManagerTest.java ## @@ -287,12 +290,124 @@ public void

[GitHub] [kafka] showuon commented on a change in pull request #8712: KAFKA-10006: Don't create internal topics when LeaderNotAvailableException

2020-06-30 Thread GitBox
showuon commented on a change in pull request #8712: URL: https://github.com/apache/kafka/pull/8712#discussion_r448099358 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/InternalTopicManagerTest.java ## @@ -287,12 +290,124 @@ public void

[GitHub] [kafka] vvcephei commented on pull request #8938: KAFKA-10173: Use SmokeTest for upgrade system tests

2020-06-30 Thread GitBox
vvcephei commented on pull request #8938: URL: https://github.com/apache/kafka/pull/8938#issuecomment-652171893 Oof, looks like I missed "something":

[GitHub] [kafka] vvcephei commented on pull request #8961: MINOR: add a retry system test curl commands

2020-06-30 Thread GitBox
vvcephei commented on pull request #8961: URL: https://github.com/apache/kafka/pull/8961#issuecomment-652171595 new run: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4002/ This is an automated message

[GitHub] [kafka] vvcephei commented on pull request #8961: MINOR: add a retry system test curl commands

2020-06-30 Thread GitBox
vvcephei commented on pull request #8961: URL: https://github.com/apache/kafka/pull/8961#issuecomment-652168931 Ah, Thanks @kkonstantine , I see that now: ``` 17:42:20 worker5: + curl --retry-all-errors --retry 5 -s -L

[GitHub] [kafka] showuon commented on a change in pull request #8712: KAFKA-10006: Don't create internal topics when LeaderNotAvailableException

2020-06-30 Thread GitBox
showuon commented on a change in pull request #8712: URL: https://github.com/apache/kafka/pull/8712#discussion_r448095124 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java ## @@ -100,13 +100,19 @@ public

[GitHub] [kafka] guozhangwang commented on a change in pull request #8964: KAFKA-9450: Decouple flushing state from commiting

2020-06-30 Thread GitBox
guozhangwang commented on a change in pull request #8964: URL: https://github.com/apache/kafka/pull/8964#discussion_r448093846 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateManagerUtil.java ## @@ -38,13 +41,39 @@ */ final class

[GitHub] [kafka] guozhangwang opened a new pull request #8964: KAFKA-9450: Decouple flushing state from commiting

2020-06-30 Thread GitBox
guozhangwang opened a new pull request #8964: URL: https://github.com/apache/kafka/pull/8964 1. Do not always flush state stores when committing (in post-commit), move `stateMgr.flush` into post-commit to live with checkpointing. Then in post-commit, we checkpoint when: 1.a. The

[GitHub] [kafka] abbccdda commented on pull request #8962: KAFKA-10166: checkpoint recycled standbys and ignore empty rocksdb base directory

2020-06-30 Thread GitBox
abbccdda commented on pull request #8962: URL: https://github.com/apache/kafka/pull/8962#issuecomment-652159635 test this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] abbccdda commented on pull request #8963: KAFKA-10017: fix flaky EosBetaUpgradeIntegrationTest

2020-06-30 Thread GitBox
abbccdda commented on pull request #8963: URL: https://github.com/apache/kafka/pull/8963#issuecomment-652159442 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] abbccdda commented on pull request #8962: KAFKA-10166: checkpoint recycled standbys and ignore empty rocksdb base directory

2020-06-30 Thread GitBox
abbccdda commented on pull request #8962: URL: https://github.com/apache/kafka/pull/8962#issuecomment-652159560 Test this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] ableegoldman opened a new pull request #8963: KAFKA-10017: fix flaky EosBetaUpgradeIntegrationTest

2020-06-30 Thread GitBox
ableegoldman opened a new pull request #8963: URL: https://github.com/apache/kafka/pull/8963 The current failures we're seeing with this test are due to faulty assumptions that it makes and not any real bug in eos-beta (at least, from what I've seen so far). The test relies on

[GitHub] [kafka] mmolimar commented on a change in pull request #7496: KAFKA-9018: Throw clearer exceptions on serialisation errors

2020-06-30 Thread GitBox
mmolimar commented on a change in pull request #7496: URL: https://github.com/apache/kafka/pull/7496#discussion_r448045788 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSinkTask.java ## @@ -524,6 +524,26 @@ private SinkRecord

[GitHub] [kafka] ableegoldman commented on a change in pull request #8962: KAFKA-10166: checkpoint recycled standbys and ignore empty rocksdb base directory

2020-06-30 Thread GitBox
ableegoldman commented on a change in pull request #8962: URL: https://github.com/apache/kafka/pull/8962#discussion_r448044329 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java ## @@ -136,7 +143,59 @@ private boolean

[GitHub] [kafka] rhauch commented on a change in pull request #7496: KAFKA-9018: Throw clearer exceptions on serialisation errors

2020-06-30 Thread GitBox
rhauch commented on a change in pull request #7496: URL: https://github.com/apache/kafka/pull/7496#discussion_r448029128 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSinkTask.java ## @@ -524,6 +524,26 @@ private SinkRecord

[GitHub] [kafka] rhauch commented on a change in pull request #8858: KAFKA-10153: Error Reporting in Connect Documentation

2020-06-30 Thread GitBox
rhauch commented on a change in pull request #8858: URL: https://github.com/apache/kafka/pull/8858#discussion_r448023368 ## File path: docs/connect.html ## @@ -258,6 +258,48 @@ REST API GET /- return basic information about the Kafka Connect cluster such as the

[GitHub] [kafka] vvcephei commented on pull request #8962: KAFKA-10166: checkpoint recycled standbys and ignore empty rocksdb base directory

2020-06-30 Thread GitBox
vvcephei commented on pull request #8962: URL: https://github.com/apache/kafka/pull/8962#issuecomment-652090962 Test this please This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Commented] (KAFKA-10217) Move nodeLevelSensor and storeLevelSensor methods from StreamsMetricsImpl to StreamsMetrics

2020-06-30 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148994#comment-17148994 ] Sophie Blee-Goldman commented on KAFKA-10217: - [~mhmdchebbi] try rebasing – the PR that

[GitHub] [kafka] kkonstantine removed a comment on pull request #8961: MINOR: add a retry system test curl commands

2020-06-30 Thread GitBox
kkonstantine removed a comment on pull request #8961: URL: https://github.com/apache/kafka/pull/8961#issuecomment-652085184 @vvcephei `--retry-all-error` is not an option that the current curl version recognizes. The system tests fail early on that error.

[GitHub] [kafka] kkonstantine commented on pull request #8961: MINOR: add a retry system test curl commands

2020-06-30 Thread GitBox
kkonstantine commented on pull request #8961: URL: https://github.com/apache/kafka/pull/8961#issuecomment-652085184 @vvcephei `--retry-all-error` is not an option that the current curl version recognizes. The system tests fail early on that error.

[GitHub] [kafka] vvcephei commented on pull request #8961: MINOR: add a retry system test curl commands

2020-06-30 Thread GitBox
vvcephei commented on pull request #8961: URL: https://github.com/apache/kafka/pull/8961#issuecomment-652082007 System test meta run: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4001/console This is an

[GitHub] [kafka] vvcephei commented on pull request #8961: MINOR: add a retry system test curl commands

2020-06-30 Thread GitBox
vvcephei commented on pull request #8961: URL: https://github.com/apache/kafka/pull/8961#issuecomment-652081453 Recently, I have seen a few remote (aws-over-vagrant) system tests fail during setup due to this error: ``` worker15: + curl -O

[GitHub] [kafka] ableegoldman opened a new pull request #8962: KAFKA-10166: checkpoint recycled standbys and ignore empty rocksdb base directory

2020-06-30 Thread GitBox
ableegoldman opened a new pull request #8962: URL: https://github.com/apache/kafka/pull/8962 Two more edge cases I found producing extra TaskcorruptedException while playing around with the failing eos-beta upgrade test (sadly these are unrelated problems, as the test still fails with

[GitHub] [kafka] vvcephei opened a new pull request #8961: MINOR: add a retry system test curl commands

2020-06-30 Thread GitBox
vvcephei opened a new pull request #8961: URL: https://github.com/apache/kafka/pull/8961 Adds a retry to curl, using the built-in exponential backoff mechanism. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test

[GitHub] [kafka] kkonstantine commented on pull request #8859: MINOR: Upgrade jetty to 9.4.27.v20200227 and jersey to 2.31

2020-06-30 Thread GitBox
kkonstantine commented on pull request #8859: URL: https://github.com/apache/kafka/pull/8859#issuecomment-652079556 Same here. Thanks for checking! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] d8tltanc closed pull request #8544: [WIP]KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

2020-06-30 Thread GitBox
d8tltanc closed pull request #8544: URL: https://github.com/apache/kafka/pull/8544 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (KAFKA-10217) Move nodeLevelSensor and storeLevelSensor methods from StreamsMetricsImpl to StreamsMetrics

2020-06-30 Thread mohamed chebbi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148976#comment-17148976 ] mohamed chebbi commented on KAFKA-10217: Hi [~vvcephei] i can't find

[jira] [Assigned] (KAFKA-10166) Excessive TaskCorruptedException seen in testing

2020-06-30 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch reassigned KAFKA-10166: - Assignee: Sophie Blee-Goldman > Excessive TaskCorruptedException seen in testing >

[jira] [Reopened] (KAFKA-10166) Excessive TaskCorruptedException seen in testing

2020-06-30 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman reopened KAFKA-10166: - Assignee: (was: Bruno Cadonna) Found two edge cases we missed earlier so

[GitHub] [kafka] dajac commented on pull request #8544: [WIP]KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

2020-06-30 Thread GitBox
dajac commented on pull request #8544: URL: https://github.com/apache/kafka/pull/8544#issuecomment-652059065 @d8tltanc We can close this one. This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (KAFKA-10219) KStream API support for multiple cluster broker

2020-06-30 Thread Sachin Kurle (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148954#comment-17148954 ] Sachin Kurle commented on KAFKA-10219: -- I have simple use-case where I read off source topic from

[GitHub] [kafka] hachikuji opened a new pull request #8960: KAFKA-9144; Track timestamp from txn markers to prevent early producer expiration

2020-06-30 Thread GitBox
hachikuji opened a new pull request #8960: URL: https://github.com/apache/kafka/pull/8960 Note this is a backport of (#7687) for 2.3. Existing producer state expiration uses timestamps from data records only and not from transaction markers. This can cause premature producer

[GitHub] [kafka] abbccdda commented on pull request #8431: MINOR: Rename description of flatMapValues transformation

2020-06-30 Thread GitBox
abbccdda commented on pull request #8431: URL: https://github.com/apache/kafka/pull/8431#issuecomment-652033261 @maseiler Could you try to attach a screenshot of the fix? This is an automated message from the Apache Git

[GitHub] [kafka] abbccdda commented on pull request #6792: KAFKA 8311 : Augment the error message to let user change `default.api.timeout.ms`

2020-06-30 Thread GitBox
abbccdda commented on pull request #6792: URL: https://github.com/apache/kafka/pull/6792#issuecomment-652030858 Closing the PR due to lack of interest and duplicate. This is an automated message from the Apache Git Service.

[GitHub] [kafka] abbccdda closed pull request #6792: KAFKA 8311 : Augment the error message to let user change `default.api.timeout.ms`

2020-06-30 Thread GitBox
abbccdda closed pull request #6792: URL: https://github.com/apache/kafka/pull/6792 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Resolved] (KAFKA-4996) Fix findbugs multithreaded correctness warnings for streams

2020-06-30 Thread Leah Thomas (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-4996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leah Thomas resolved KAFKA-4996. Resolution: Fixed > Fix findbugs multithreaded correctness warnings for streams >

[GitHub] [kafka] d8tltanc commented on pull request #8846: KAFKA-9800: [KIP-580] Client Exponential Backoff Implementation

2020-06-30 Thread GitBox
d8tltanc commented on pull request #8846: URL: https://github.com/apache/kafka/pull/8846#issuecomment-652013968 @skaundinya15 @abbccdda @ijuma The utility class GeometricProgression is renamed in #8683 and merged into trunk. Now, this patch is rebased and ready for review.

[GitHub] [kafka] d8tltanc commented on a change in pull request #8846: KAFKA-9800: [KIP-580] Client Exponential Backoff Implementation

2020-06-30 Thread GitBox
d8tltanc commented on a change in pull request #8846: URL: https://github.com/apache/kafka/pull/8846#discussion_r447942236 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/AdminClientConfig.java ## @@ -67,9 +67,14 @@ * retry.backoff.ms */

[GitHub] [kafka] junrao commented on a change in pull request #8479: KAFKA-9769: Finish operations for leaderEpoch-updated partitions up to point ZK Exception

2020-06-30 Thread GitBox
junrao commented on a change in pull request #8479: URL: https://github.com/apache/kafka/pull/8479#discussion_r447927722 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -499,7 +500,15 @@ class Partition(val topicPartition: TopicPartition,

[jira] [Commented] (KAFKA-10134) High CPU issue during rebalance in Kafka consumer after upgrading to 2.5

2020-06-30 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148854#comment-17148854 ] Guozhang Wang commented on KAFKA-10134: --- [~neowu0] Thanks for your comments. I will incorporate

[jira] [Updated] (KAFKA-10017) Flaky Test EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta

2020-06-30 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-10017: -- Priority: Blocker (was: Critical) > Flaky Test

[jira] [Commented] (KAFKA-10017) Flaky Test EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta

2020-06-30 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148846#comment-17148846 ] Guozhang Wang commented on KAFKA-10017: --- [~rhauch] I'm making it back as a blocker for 2.6 since

[jira] [Commented] (KAFKA-10219) KStream API support for multiple cluster broker

2020-06-30 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148818#comment-17148818 ] Boyang Chen commented on KAFKA-10219: - Thanks for the proposal, the use case you proposed is

[jira] [Comment Edited] (KAFKA-4273) Streams DSL - Add TTL / retention period support for intermediate topics and state stores

2020-06-30 Thread Di Campo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-4273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148801#comment-17148801 ] Di Campo edited comment on KAFKA-4273 at 6/30/20, 4:12 PM: --- Any news or

[jira] [Commented] (KAFKA-4273) Streams DSL - Add TTL / retention period support for intermediate topics and state stores

2020-06-30 Thread Di Campo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-4273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148801#comment-17148801 ] Di Campo commented on KAFKA-4273: - Any news or improved workaround? I am also interested on this.  In my

[jira] [Commented] (KAFKA-10220) NPE when describing resources

2020-06-30 Thread huxihx (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148774#comment-17148774 ] huxihx commented on KAFKA-10220: Well, from the broker perspective, you are right. Only trunk is

[jira] [Commented] (KAFKA-10220) NPE when describing resources

2020-06-30 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148756#comment-17148756 ] Ismael Juma commented on KAFKA-10220: - >From the link you referenced, it seems like this only

[jira] [Commented] (KAFKA-10220) NPE when describing resources

2020-06-30 Thread huxihx (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148738#comment-17148738 ] huxihx commented on KAFKA-10220: [~ijuma] This should affect 2.6 as well since `configurationKeys`

[jira] [Assigned] (KAFKA-10220) NPE when describing resources

2020-06-30 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen reassigned KAFKA-10220: - Assignee: Luke Chen > NPE when describing resources > - > >

[GitHub] [kafka] omkreddy commented on pull request #8957: KAFKA-5235: GetOffsetShell: support for multiple topics and consumer configuration override

2020-06-30 Thread GitBox
omkreddy commented on pull request #8957: URL: https://github.com/apache/kafka/pull/8957#issuecomment-651811192 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] omkreddy merged pull request #8958: MINOR: Update AlterConfigsOptions' Javadoc

2020-06-30 Thread GitBox
omkreddy merged pull request #8958: URL: https://github.com/apache/kafka/pull/8958 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (KAFKA-10220) NPE when describing resources

2020-06-30 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148680#comment-17148680 ] Ismael Juma commented on KAFKA-10220: - Does this affect 2.6 as well or just trunk? > NPE when

[GitHub] [kafka] rajinisivaram opened a new pull request #8959: MINOR: Fix log entry in FetchSessionHandler to specify throttle correctly

2020-06-30 Thread GitBox
rajinisivaram opened a new pull request #8959: URL: https://github.com/apache/kafka/pull/8959 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including

[GitHub] [kafka] dajac opened a new pull request #8958: MINOR: Update AlterConfigsOptions' Javadoc

2020-06-30 Thread GitBox
dajac opened a new pull request #8958: URL: https://github.com/apache/kafka/pull/8958 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade

[GitHub] [kafka] urbandan opened a new pull request #8957: KAFKA-5235: GetOffsetShell: support for multiple topics and consumer configuration override

2020-06-30 Thread GitBox
urbandan opened a new pull request #8957: URL: https://github.com/apache/kafka/pull/8957 Implements KIP-308 Changes: - Added kafka-get-offsets.sh script - Removed deprecated max-wait-ms and offsets arguments - Updated tool to query all topic-partitions by default -

[GitHub] [kafka] omkreddy commented on a change in pull request #8935: KAFKA-10189: reset event queue time histogram when queue is empty

2020-06-30 Thread GitBox
omkreddy commented on a change in pull request #8935: URL: https://github.com/apache/kafka/pull/8935#discussion_r447662323 ## File path: core/src/main/scala/kafka/controller/ControllerEventManager.scala ## @@ -69,14 +69,16 @@ class QueuedEvent(val event: ControllerEvent,

[GitHub] [kafka] omkreddy merged pull request #8956: MINOR[docs]: fix typo in ssl.client.auth requested to required.

2020-06-30 Thread GitBox
omkreddy merged pull request #8956: URL: https://github.com/apache/kafka/pull/8956 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Comment Edited] (KAFKA-10220) NPE when describing resources

2020-06-30 Thread Edoardo Comar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148576#comment-17148576 ] Edoardo Comar edited comment on KAFKA-10220 at 6/30/20, 11:51 AM: --

[jira] [Comment Edited] (KAFKA-10220) NPE when describing resources

2020-06-30 Thread Edoardo Comar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148576#comment-17148576 ] Edoardo Comar edited comment on KAFKA-10220 at 6/30/20, 11:51 AM: --

[jira] [Comment Edited] (KAFKA-10220) NPE when describing resources

2020-06-30 Thread Edoardo Comar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148576#comment-17148576 ] Edoardo Comar edited comment on KAFKA-10220 at 6/30/20, 11:50 AM: --

[jira] [Commented] (KAFKA-10220) NPE when describing resources

2020-06-30 Thread Edoardo Comar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148576#comment-17148576 ] Edoardo Comar commented on KAFKA-10220: --- {{also note that if the describe comes from the current

[jira] [Commented] (KAFKA-10220) NPE when describing resources

2020-06-30 Thread Edoardo Comar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148575#comment-17148575 ] Edoardo Comar commented on KAFKA-10220: --- ok, a bit more steps to reproduce looks like the

[GitHub] [kafka] dajac commented on pull request #8954: MINOR; Move quota integration tests to using the new quota API.

2020-06-30 Thread GitBox
dajac commented on pull request #8954: URL: https://github.com/apache/kafka/pull/8954#issuecomment-651742771 @ijuma @rajinisivaram Could you review this one when you have time? This is an automated message from the Apache

[GitHub] [kafka] itantiger commented on pull request #8753: KAFKA-10043:Some parameters will be overwritten which was configured …

2020-06-30 Thread GitBox
itantiger commented on pull request #8753: URL: https://github.com/apache/kafka/pull/8753#issuecomment-651738671 @rhauch Can you take a look at this? This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] dajac commented on a change in pull request #8940: KAFKA-10181: AlterConfig/IncrementalAlterConfig should route to the controller for non validation calls

2020-06-30 Thread GitBox
dajac commented on a change in pull request #8940: URL: https://github.com/apache/kafka/pull/8940#discussion_r447557312 ## File path: core/src/test/scala/unit/kafka/server/KafkaApisTest.scala ## @@ -354,13 +401,62 @@ class KafkaApisTest { .setValue("bar"))

[jira] [Commented] (KAFKA-10220) NPE when describing resources

2020-06-30 Thread Edoardo Comar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148564#comment-17148564 ] Edoardo Comar commented on KAFKA-10220: --- [~huxi_2b] I initially hit this when using the 2.5.0 cli

[GitHub] [kafka] omkreddy commented on pull request #8935: KAFKA-10189: reset event queue time histogram when queue is empty

2020-06-30 Thread GitBox
omkreddy commented on pull request #8935: URL: https://github.com/apache/kafka/pull/8935#issuecomment-651735737 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Updated] (KAFKA-10220) NPE when describing resources

2020-06-30 Thread Edoardo Comar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edoardo Comar updated KAFKA-10220: -- Description: In current trunk code Describing a topic from the CLI can fail with an NPE in

[jira] [Commented] (KAFKA-10191) fix flaky StreamsOptimizedTest

2020-06-30 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148556#comment-17148556 ] Chia-Ping Tsai commented on KAFKA-10191: {quote} about adding KafkaStreams#cleanUp() in the

[jira] [Commented] (KAFKA-10220) NPE when describing resources

2020-06-30 Thread huxihx (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148550#comment-17148550 ] huxihx commented on KAFKA-10220: [~ecomar]  Thanks for reporting. I could not reproduce this issue with

[GitHub] [kafka] rajinisivaram merged pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

2020-06-30 Thread GitBox
rajinisivaram merged pull request #8683: URL: https://github.com/apache/kafka/pull/8683 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] rajinisivaram commented on pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

2020-06-30 Thread GitBox
rajinisivaram commented on pull request #8683: URL: https://github.com/apache/kafka/pull/8683#issuecomment-651726976 Streams test failures not related, merging to trunk. This is an automated message from the Apache Git

[GitHub] [kafka] omkreddy commented on pull request #8885: KAFKA-8264: decrease the record size for flaky test

2020-06-30 Thread GitBox
omkreddy commented on pull request #8885: URL: https://github.com/apache/kafka/pull/8885#issuecomment-651724728 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Issue Comment Deleted] (KAFKA-10220) NPE when describing resources

2020-06-30 Thread Edoardo Comar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edoardo Comar updated KAFKA-10220: -- Comment: was deleted (was: deserialized request data has a null configurationKeys

[jira] [Commented] (KAFKA-10220) NPE when describing resources

2020-06-30 Thread Edoardo Comar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148535#comment-17148535 ] Edoardo Comar commented on KAFKA-10220: --- deserialized request data has a null configurationKeys

[jira] [Updated] (KAFKA-10220) NPE when describing resources

2020-06-30 Thread Edoardo Comar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edoardo Comar updated KAFKA-10220: -- Description: In current trunk code Describing a topic from the CLI can fail with an NPE in

[jira] [Updated] (KAFKA-10221) Backport fix for KAFKA-9603 to 2.5

2020-06-30 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-10221: -- Fix Version/s: 2.5.1 > Backport fix for KAFKA-9603 to 2.5 >

[jira] [Created] (KAFKA-10221) Backport fix for KAFKA-9603 to 2.5

2020-06-30 Thread Bruno Cadonna (Jira)
Bruno Cadonna created KAFKA-10221: - Summary: Backport fix for KAFKA-9603 to 2.5 Key: KAFKA-10221 URL: https://issues.apache.org/jira/browse/KAFKA-10221 Project: Kafka Issue Type: Bug

[jira] [Created] (KAFKA-10220) NPE when describing resources

2020-06-30 Thread Edoardo Comar (Jira)
Edoardo Comar created KAFKA-10220: - Summary: NPE when describing resources Key: KAFKA-10220 URL: https://issues.apache.org/jira/browse/KAFKA-10220 Project: Kafka Issue Type: Bug

[GitHub] [kafka] jeqo opened a new pull request #8956: MINOR[docs]: fix typo in ssl.client.auth requested to required.

2020-06-30 Thread GitBox
jeqo opened a new pull request #8956: URL: https://github.com/apache/kafka/pull/8956 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] cadonna commented on pull request #8914: MINOR: Do not swallow exception when collecting PIDs

2020-06-30 Thread GitBox
cadonna commented on pull request #8914: URL: https://github.com/apache/kafka/pull/8914#issuecomment-651699622 The failed system test does not seem to be related to this PR but rather to https://issues.apache.org/jira/browse/KAFKA-10191.

[GitHub] [kafka] cadonna commented on a change in pull request #8902: KAFKA-10179: Pass correct changelog topic to state serdes

2020-06-30 Thread GitBox
cadonna commented on a change in pull request #8902: URL: https://github.com/apache/kafka/pull/8902#discussion_r447567460 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStoreTest.java ## @@ -124,18 +141,19 @@ public void before() {

[GitHub] [kafka] LMnet commented on pull request #8955: KAFKA-10020: Create a new version of a scala Serdes without name clash (KIP-616)

2020-06-30 Thread GitBox
LMnet commented on pull request #8955: URL: https://github.com/apache/kafka/pull/8955#issuecomment-651694260 @vvcephei @mjsax This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] LMnet commented on pull request #8049: MINOR: Added missing default serdes to the streams.scala.Serdes

2020-06-30 Thread GitBox
LMnet commented on pull request #8049: URL: https://github.com/apache/kafka/pull/8049#issuecomment-651690176 Closed in favor of a https://github.com/apache/kafka/pull/8955 This is an automated message from the Apache Git

[GitHub] [kafka] LMnet commented on a change in pull request #8049: MINOR: Added missing default serdes to the streams.scala.Serdes

2020-06-30 Thread GitBox
LMnet commented on a change in pull request #8049: URL: https://github.com/apache/kafka/pull/8049#discussion_r447559838 ## File path: streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/Serdes.scala ## @@ -30,12 +32,15 @@ object Serdes { implicit def

[GitHub] [kafka] LMnet closed pull request #8049: MINOR: Added missing default serdes to the streams.scala.Serdes

2020-06-30 Thread GitBox
LMnet closed pull request #8049: URL: https://github.com/apache/kafka/pull/8049 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] LMnet opened a new pull request #8955: KAFKA-10020: Create a new version of a scala Serdes without name clash

2020-06-30 Thread GitBox
LMnet opened a new pull request #8955: URL: https://github.com/apache/kafka/pull/8955 Implementation of a solution for KIP-616. Wildcard import of the old `org.apache.kafka.streams.scala.Serdes` leads to a name clash because some of implicits has the same names as types from

[GitHub] [kafka] akatona84 commented on pull request #8859: MINOR: Upgrade jetty to 9.4.27.v20200227 and jersey to 2.31

2020-06-30 Thread GitBox
akatona84 commented on pull request #8859: URL: https://github.com/apache/kafka/pull/8859#issuecomment-651684469 I did not find anything for that version, thanks again. This is an automated message from the Apache Git

[jira] [Commented] (KAFKA-10191) fix flaky StreamsOptimizedTest

2020-06-30 Thread mohamed chebbi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148475#comment-17148475 ] mohamed chebbi commented on KAFKA-10191: [~chia7712] sorry to be late, i read the reset tool

[GitHub] [kafka] dajac opened a new pull request #8954: MINOR; Move quota integration tests to using the new quota API.

2020-06-30 Thread GitBox
dajac opened a new pull request #8954: URL: https://github.com/apache/kafka/pull/8954 This PR refactors the various quota integration tests in the `kafka.api` package and migrates them to using the new quota API instead of writing the quota to ZK directly. ### Committer Checklist

[GitHub] [kafka] mimaison commented on pull request #8921: KAFKA-10160: Kafka MM2 consumer configuration

2020-06-30 Thread GitBox
mimaison commented on pull request #8921: URL: https://github.com/apache/kafka/pull/8921#issuecomment-651658489 @satishbellapu I'll try to take a look Thursday or Friday This is an automated message from the Apache Git

[GitHub] [kafka] mimaison commented on pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

2020-06-30 Thread GitBox
mimaison commented on pull request #8295: URL: https://github.com/apache/kafka/pull/8295#issuecomment-651657082 The conflicts are pretty nasty. I started looking at it last week but did not have the time (nor the courage!) to finish. I plan to take another look this week

  1   2   >