[jira] [Assigned] (KAFKA-10131) Minimize use of --zookeeper flag in ducktape tests

2020-07-09 Thread Vinoth Chandar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinoth Chandar reassigned KAFKA-10131: -- Assignee: Ron Dagostino (was: Vinoth Chandar) > Minimize use of --zookeeper flag in

[GitHub] [kafka] vvcephei commented on a change in pull request #8994: KAFKA-10247: Correctly reset state when task is corrupted

2020-07-09 Thread GitBox
vvcephei commented on a change in pull request #8994: URL: https://github.com/apache/kafka/pull/8994#discussion_r452365162 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java ## @@ -232,10 +232,16 @@ void initializeStoreO

[GitHub] [kafka] vvcephei commented on a change in pull request #8994: KAFKA-10247: Correctly reset state when task is corrupted

2020-07-09 Thread GitBox
vvcephei commented on a change in pull request #8994: URL: https://github.com/apache/kafka/pull/8994#discussion_r452357020 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java ## @@ -215,7 +215,7 @@ public StateStore getGl

[jira] [Commented] (KAFKA-10254) 100% cpu usage by kafkaConsumer poll , when broker can‘t be connect

2020-07-09 Thread Arvin Zheng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17154725#comment-17154725 ] Arvin Zheng commented on KAFKA-10254: - [~xiaotong.wang], see KAFKA-10134 > 100% cpu

[GitHub] [kafka] ijuma commented on a change in pull request #8999: MINOR; Return timed out connections as a List instead of a Set

2020-07-09 Thread GitBox
ijuma commented on a change in pull request #8999: URL: https://github.com/apache/kafka/pull/8999#discussion_r452349346 ## File path: clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java ## @@ -443,13 +444,13 @@ public boolean isConnectionSetupTimeout(St

[jira] [Resolved] (KAFKA-10235) Fix flaky transactions_test.py

2020-07-09 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-10235. - Fix Version/s: 3.0.0 Resolution: Fixed merged the PR to trunk. > Fix flaky transactions_test.py

[GitHub] [kafka] junrao merged pull request #8981: KAFKA-10235 Fix flaky transactions_test.py

2020-07-09 Thread GitBox
junrao merged pull request #8981: URL: https://github.com/apache/kafka/pull/8981 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] chia7712 commented on pull request #8981: KAFKA-10235 Fix flaky transactions_test.py

2020-07-09 Thread GitBox
chia7712 commented on pull request #8981: URL: https://github.com/apache/kafka/pull/8981#issuecomment-656223017 > Did this PR fix transaction tests as expected? Yep. core.transactions_test passes :) This is an automate

[jira] [Created] (KAFKA-10257) system test kafkatest.tests.core.security_rolling_upgrade_test fails

2020-07-09 Thread Jun Rao (Jira)
Jun Rao created KAFKA-10257: --- Summary: system test kafkatest.tests.core.security_rolling_upgrade_test fails Key: KAFKA-10257 URL: https://issues.apache.org/jira/browse/KAFKA-10257 Project: Kafka I

[jira] [Commented] (KAFKA-10240) Sink tasks should not throw WakeupException on shutdown

2020-07-09 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17154702#comment-17154702 ] Chris Egerton commented on KAFKA-10240: --- For some background: this was actually di

[GitHub] [kafka] junrao commented on pull request #8981: KAFKA-10235 Fix flaky transactions_test.py

2020-07-09 Thread GitBox
junrao commented on pull request #8981: URL: https://github.com/apache/kafka/pull/8981#issuecomment-656214847 11 failures in system tests. http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/2020-07-08--001.1594266883--chia7712--KAFKA-10235--a76224fff/report

[GitHub] [kafka] mimaison commented on a change in pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

2020-07-09 Thread GitBox
mimaison commented on a change in pull request #8295: URL: https://github.com/apache/kafka/pull/8295#discussion_r452324069 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java ## @@ -965,11 +994,11 @@ public void onFailure(RuntimeExcepti

[jira] [Updated] (KAFKA-10240) Sink tasks should not throw WakeupException on shutdown

2020-07-09 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-10240: -- Description: * When a task is scheduled for shutdown, the framework [wakes up the consumer|ht

[GitHub] [kafka] joel-hamill commented on pull request #8878: MINOR: Generator config-specific HTML ids

2020-07-09 Thread GitBox
joel-hamill commented on pull request #8878: URL: https://github.com/apache/kafka/pull/8878#issuecomment-656205597 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[jira] [Created] (KAFKA-10256) Create a server gradle module for Java code needed only by servers

2020-07-09 Thread Colin McCabe (Jira)
Colin McCabe created KAFKA-10256: Summary: Create a server gradle module for Java code needed only by servers Key: KAFKA-10256 URL: https://issues.apache.org/jira/browse/KAFKA-10256 Project: Kafka

[GitHub] [kafka] cmccabe opened a new pull request #9002: MINOR: Add ApiMessageTypeGenerator

2020-07-09 Thread GitBox
cmccabe opened a new pull request #9002: URL: https://github.com/apache/kafka/pull/9002 Previously, we had some code hard-coded to generate message type classes for RPCs. We might want to generate message type classes for other things as well, so make it more generic. --

[GitHub] [kafka] vvcephei commented on pull request #8902: KAFKA-10179: Pass correct changelog topic to state serdes

2020-07-09 Thread GitBox
vvcephei commented on pull request #8902: URL: https://github.com/apache/kafka/pull/8902#issuecomment-656181429 Test this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] vvcephei commented on pull request #8902: KAFKA-10179: Pass correct changelog topic to state serdes

2020-07-09 Thread GitBox
vvcephei commented on pull request #8902: URL: https://github.com/apache/kafka/pull/8902#issuecomment-656181031 Test this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] omkreddy merged pull request #8992: MINOR: Closing resources in SaslClientsWithInvalidCredentialsTest

2020-07-09 Thread GitBox
omkreddy merged pull request #8992: URL: https://github.com/apache/kafka/pull/8992 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Created] (KAFKA-10255) Fix flaky testOneWayReplicationWithAutorOffsetSync1 test

2020-07-09 Thread Luke Chen (Jira)
Luke Chen created KAFKA-10255: - Summary: Fix flaky testOneWayReplicationWithAutorOffsetSync1 test Key: KAFKA-10255 URL: https://issues.apache.org/jira/browse/KAFKA-10255 Project: Kafka Issue Type

[GitHub] [kafka] dajac commented on a change in pull request #8977: KAFKA-10162; Quota Enhancements (KIP-599)

2020-07-09 Thread GitBox
dajac commented on a change in pull request #8977: URL: https://github.com/apache/kafka/pull/8977#discussion_r452166182 ## File path: clients/src/main/java/org/apache/kafka/common/metrics/stats/TokenBucket.java ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Found

[GitHub] [kafka] cadonna commented on a change in pull request #8902: KAFKA-10179: Pass correct changelog topic to state serdes

2020-07-09 Thread GitBox
cadonna commented on a change in pull request #8902: URL: https://github.com/apache/kafka/pull/8902#discussion_r452165061 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java ## @@ -73,22 +73,23 @@ private final Set

[GitHub] [kafka] dajac commented on a change in pull request #8977: KAFKA-10162; Quota Enhancements (KIP-599)

2020-07-09 Thread GitBox
dajac commented on a change in pull request #8977: URL: https://github.com/apache/kafka/pull/8977#discussion_r452162969 ## File path: clients/src/main/java/org/apache/kafka/common/metrics/Sensor.java ## @@ -97,7 +97,25 @@ public static RecordingLevel forName(String name) {

[GitHub] [kafka] dajac commented on a change in pull request #8977: KAFKA-10162; Quota Enhancements (KIP-599)

2020-07-09 Thread GitBox
dajac commented on a change in pull request #8977: URL: https://github.com/apache/kafka/pull/8977#discussion_r452162828 ## File path: clients/src/main/java/org/apache/kafka/common/metrics/stats/TokenBucket.java ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Found

[jira] [Updated] (KAFKA-10254) 100% cpu usage by kafkaConsumer poll , when broker can‘t be connect

2020-07-09 Thread xiaotong.wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xiaotong.wang updated KAFKA-10254: -- Description: steps 1、start kafka broker  2、start kafka consumer and subscribe some topic wit

[jira] [Created] (KAFKA-10254) 100% cpu usage by kafkaConsumer poll , when broker can‘t be connect

2020-07-09 Thread xiaotong.wang (Jira)
xiaotong.wang created KAFKA-10254: - Summary: 100% cpu usage by kafkaConsumer poll , when broker can‘t be connect Key: KAFKA-10254 URL: https://issues.apache.org/jira/browse/KAFKA-10254 Project: Kafka

[jira] [Updated] (KAFKA-10254) 100% cpu usage by kafkaConsumer poll , when broker can‘t be connect

2020-07-09 Thread xiaotong.wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xiaotong.wang updated KAFKA-10254: -- Description: steps 1、start kafka broker  2、start kafka consumer and subscribe some topic wit

[GitHub] [kafka] cadonna commented on a change in pull request #8902: KAFKA-10179: Pass correct changelog topic to state serdes

2020-07-09 Thread GitBox
cadonna commented on a change in pull request #8902: URL: https://github.com/apache/kafka/pull/8902#discussion_r452148874 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java ## @@ -103,8 +104,12 @@ public void init(final Proce

[GitHub] [kafka] cadonna commented on a change in pull request #8902: KAFKA-10179: Pass correct changelog topic to state serdes

2020-07-09 Thread GitBox
cadonna commented on a change in pull request #8902: URL: https://github.com/apache/kafka/pull/8902#discussion_r452119998 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractProcessorContext.java ## @@ -45,24 +45,23 @@ protected Proces

[GitHub] [kafka] mimaison commented on a change in pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

2020-07-09 Thread GitBox
mimaison commented on a change in pull request #8295: URL: https://github.com/apache/kafka/pull/8295#discussion_r452140714 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -892,136 +894,175 @@ class KafkaApis(val requestChannel: RequestChannel, def handle

[GitHub] [kafka] mimaison commented on pull request #8878: MINOR: Generator config-specific HTML ids

2020-07-09 Thread GitBox
mimaison commented on pull request #8878: URL: https://github.com/apache/kafka/pull/8878#issuecomment-656062630 @omkreddy @ijuma What's your opinion on this change? Currently a number of config links collide and this is addressing it. However this will also break existing links.

[GitHub] [kafka] omkreddy merged pull request #3480: MINOR: Define the term tombstone, since it's used elsewhere in the docs

2020-07-09 Thread GitBox
omkreddy merged pull request #3480: URL: https://github.com/apache/kafka/pull/3480 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Assigned] (KAFKA-10028) Implement write path for feature versioning scheme

2020-07-09 Thread Kowshik Prakasam (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kowshik Prakasam reassigned KAFKA-10028: Assignee: Kowshik Prakasam > Implement write path for feature versioning scheme >

[GitHub] [kafka] kowshik opened a new pull request #9001: KAFKA-10028: Implement KIP-584 write path

2020-07-09 Thread GitBox
kowshik opened a new pull request #9001: URL: https://github.com/apache/kafka/pull/9001 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] cadonna commented on a change in pull request #8902: KAFKA-10179: Pass correct changelog topic to state serdes

2020-07-09 Thread GitBox
cadonna commented on a change in pull request #8902: URL: https://github.com/apache/kafka/pull/8902#discussion_r452119998 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractProcessorContext.java ## @@ -45,24 +45,23 @@ protected Proces

[GitHub] [kafka] omkreddy commented on pull request #8992: MINOR: Closing resources in SaslClientsWithInvalidCredentialsTest

2020-07-09 Thread GitBox
omkreddy commented on pull request #8992: URL: https://github.com/apache/kafka/pull/8992#issuecomment-656045969 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] akatona84 commented on a change in pull request #8992: MINOR: Closing resources in SaslClientsWithInvalidCredentialsTest

2020-07-09 Thread GitBox
akatona84 commented on a change in pull request #8992: URL: https://github.com/apache/kafka/pull/8992#discussion_r452108786 ## File path: core/src/test/scala/integration/kafka/api/SaslClientsWithInvalidCredentialsTest.scala ## @@ -74,48 +75,58 @@ class SaslClientsWithInvalidCr

[GitHub] [kafka] akatona84 commented on pull request #8992: MINOR: Closing resources in SaslClientsWithInvalidCredentialsTest

2020-07-09 Thread GitBox
akatona84 commented on pull request #8992: URL: https://github.com/apache/kafka/pull/8992#issuecomment-656038173 Thanks, @omkreddy for explaining how the consumers and prods are closed, updated my PR so only closing things where it is necessary. ---

[GitHub] [kafka] akatona84 edited a comment on pull request #8992: MINOR: Closing resources in SaslClientsWithInvalidCredentialsTest

2020-07-09 Thread GitBox
akatona84 edited a comment on pull request #8992: URL: https://github.com/apache/kafka/pull/8992#issuecomment-656038173 Thanks, @omkreddy for explaining how the consumers and prods are closed (I've missed that), updated my PR so only closing things where it is necessary. -

[GitHub] [kafka] akatona84 commented on a change in pull request #8992: MINOR: Closing resources in SaslClientsWithInvalidCredentialsTest

2020-07-09 Thread GitBox
akatona84 commented on a change in pull request #8992: URL: https://github.com/apache/kafka/pull/8992#discussion_r452108786 ## File path: core/src/test/scala/integration/kafka/api/SaslClientsWithInvalidCredentialsTest.scala ## @@ -74,48 +75,58 @@ class SaslClientsWithInvalidCr

[GitHub] [kafka] akatona84 commented on a change in pull request #8992: MINOR: Closing resources in SaslClientsWithInvalidCredentialsTest

2020-07-09 Thread GitBox
akatona84 commented on a change in pull request #8992: URL: https://github.com/apache/kafka/pull/8992#discussion_r452108786 ## File path: core/src/test/scala/integration/kafka/api/SaslClientsWithInvalidCredentialsTest.scala ## @@ -74,48 +75,58 @@ class SaslClientsWithInvalidCr

[GitHub] [kafka] soarez opened a new pull request #9000: KAFKA-10036 Improve handling and documentation of Suppliers

2020-07-09 Thread GitBox
soarez opened a new pull request #9000: URL: https://github.com/apache/kafka/pull/9000 Following up on #8752 which seems to have gone stale. @mjsax can you continue the review? This is an automated message from the Apa

[jira] [Commented] (KAFKA-10252) MeteredTimestampedKeyValueStore not setting up correct topic name for GlobalKTable associating StateStores

2020-07-09 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17154406#comment-17154406 ] Bruno Cadonna commented on KAFKA-10252: --- Thank you for the bug report, [~bulbfreem

[GitHub] [kafka] omkreddy commented on a change in pull request #8992: MINOR: Closing resources in SaslClientsWithInvalidCredentialsTest

2020-07-09 Thread GitBox
omkreddy commented on a change in pull request #8992: URL: https://github.com/apache/kafka/pull/8992#discussion_r452092180 ## File path: core/src/test/scala/integration/kafka/api/SaslClientsWithInvalidCredentialsTest.scala ## @@ -74,48 +75,58 @@ class SaslClientsWithInvalidCre

[GitHub] [kafka] omkreddy closed pull request #8808: KAFKA-10109: Fix double AdminClient creation in AclCommand

2020-07-09 Thread GitBox
omkreddy closed pull request #8808: URL: https://github.com/apache/kafka/pull/8808 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Resolved] (KAFKA-10109) kafka-acls.sh/AclCommand opens multiple AdminClients

2020-07-09 Thread Manikumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar resolved KAFKA-10109. --- Fix Version/s: 2.7.0 Resolution: Fixed Issue resolved by pull request 8808 [https://github.co

[GitHub] [kafka] showuon commented on pull request #8966: KAFKA-10220: add null check for configurationKey

2020-07-09 Thread GitBox
showuon commented on pull request #8966: URL: https://github.com/apache/kafka/pull/8966#issuecomment-656019261 Cool! Thanks, @omkreddy ! This is an automated message from the Apache Git Service. To respond to the message, ple

[jira] [Updated] (KAFKA-10253) Kafka Connect gets into an infinite rebalance loop

2020-07-09 Thread Konstantin Lalafaryan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantin Lalafaryan updated KAFKA-10253: -- Component/s: KafkaConnect > Kafka Connect gets into an infinite rebalance loop

[jira] [Updated] (KAFKA-10253) Kafka Connect gets into an infinite rebalance loop

2020-07-09 Thread Konstantin Lalafaryan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantin Lalafaryan updated KAFKA-10253: -- Summary: Kafka Connect gets into an infinite rebalance loop (was: Kafka Conne

[jira] [Updated] (KAFKA-10253) Kafka Connect gets into an infinite rebalance loop

2020-07-09 Thread Konstantin Lalafaryan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantin Lalafaryan updated KAFKA-10253: -- Description: Hello everyone!   We are running kafka-connect cluster  (3 work

[GitHub] [kafka] omkreddy edited a comment on pull request #8966: KAFKA-10220: add null check for configurationKey

2020-07-09 Thread GitBox
omkreddy edited a comment on pull request #8966: URL: https://github.com/apache/kafka/pull/8966#issuecomment-656014523 @showuon I normally use `kafka-merge-pr.py` script for merging PRs. This will do a direct push from local. In this case, github marks it as closed. You can check the comm

[jira] [Updated] (KAFKA-10253) Kafka Connect gets into an infinite rebalance loop

2020-07-09 Thread Konstantin Lalafaryan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantin Lalafaryan updated KAFKA-10253: -- Description: Hello everyone!   We are running kafka-connect cluster  (3 work

[jira] [Updated] (KAFKA-10253) Kafka Connect gets into a rebalance loop

2020-07-09 Thread Konstantin Lalafaryan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantin Lalafaryan updated KAFKA-10253: -- Description: Hello everyone!   We are running kafka-connect cluster  (3 work

[GitHub] [kafka] omkreddy commented on pull request #8966: KAFKA-10220: add null check for configurationKey

2020-07-09 Thread GitBox
omkreddy commented on pull request #8966: URL: https://github.com/apache/kafka/pull/8966#issuecomment-656014523 @showuon I normally use `kafka-merge-pr.py` script for merging PRs. This will do a direct push from local. In this case, github marks it as closed. You can check the commit of t

[jira] [Created] (KAFKA-10253) Kafka Connect gets into a rebalance loop

2020-07-09 Thread Konstantin Lalafaryan (Jira)
Konstantin Lalafaryan created KAFKA-10253: - Summary: Kafka Connect gets into a rebalance loop Key: KAFKA-10253 URL: https://issues.apache.org/jira/browse/KAFKA-10253 Project: Kafka Is

[jira] [Updated] (KAFKA-10253) Kafka Connect gets into a rebalance loop

2020-07-09 Thread Konstantin Lalafaryan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantin Lalafaryan updated KAFKA-10253: -- Description: Hello everyone!   We are running kafka-connect cluster  (3 work

[GitHub] [kafka] showuon commented on pull request #8966: KAFKA-10220: add null check for configurationKey

2020-07-09 Thread GitBox
showuon commented on pull request #8966: URL: https://github.com/apache/kafka/pull/8966#issuecomment-656008310 @omkreddy , sorry, I saw the PR is closed, instead of merging. Could you please check again. Thanks. This is an a

[GitHub] [kafka] omkreddy closed pull request #8966: KAFKA-10220: add null check for configurationKey

2020-07-09 Thread GitBox
omkreddy closed pull request #8966: URL: https://github.com/apache/kafka/pull/8966 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] omkreddy commented on pull request #8966: KAFKA-10220: add null check for configurationKey

2020-07-09 Thread GitBox
omkreddy commented on pull request #8966: URL: https://github.com/apache/kafka/pull/8966#issuecomment-656000189 @tombentley Thanks for the explanation. I will go ahead and merge the PR, This is an automated message from the

[GitHub] [kafka] dajac commented on a change in pull request #8999: MINOR; Return timed out connections as a List instead of a Set

2020-07-09 Thread GitBox
dajac commented on a change in pull request #8999: URL: https://github.com/apache/kafka/pull/8999#discussion_r452052951 ## File path: clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java ## @@ -443,13 +444,13 @@ public boolean isConnectionSetupTimeout(St

[GitHub] [kafka] rajinisivaram commented on a change in pull request #8999: MINOR; Return timed out connections as a List instead of a Set

2020-07-09 Thread GitBox
rajinisivaram commented on a change in pull request #8999: URL: https://github.com/apache/kafka/pull/8999#discussion_r452040424 ## File path: clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java ## @@ -443,13 +444,13 @@ public boolean isConnectionSetupTi

[GitHub] [kafka] dajac opened a new pull request #8999: MINOR; Return timed out connections as a List instead of a Set

2020-07-09 Thread GitBox
dajac opened a new pull request #8999: URL: https://github.com/apache/kafka/pull/8999 As pointed out by @ijuma in https://github.com/apache/kafka/pull/8990#discussion_r451059876, using a `Set` is not necessary as the caller only cares about having the list of timed out connections/nodes.

[jira] [Commented] (KAFKA-10252) MeteredTimestampedKeyValueStore not setting up correct topic name for GlobalKTable associating StateStores

2020-07-09 Thread Gordon Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17154293#comment-17154293 ] Gordon Wang commented on KAFKA-10252: - Updated patch for fix. > MeteredTimestampedK

[GitHub] [kafka] dajac commented on pull request #8998: MINOR; KafkaAdminClient#describeLogDirs should not fail all the futures when only one call fails

2020-07-09 Thread GitBox
dajac commented on pull request #8998: URL: https://github.com/apache/kafka/pull/8998#issuecomment-655961172 cc @cmccabe @ijuma This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] dajac opened a new pull request #8998: MINOR; KafkaAdminClient#describeLogDirs should not fail all the futures when only one call fails

2020-07-09 Thread GitBox
dajac opened a new pull request #8998: URL: https://github.com/apache/kafka/pull/8998 Following https://github.com/apache/kafka/pull/8985, I have found another case which incorrectly realised all futures when a failure occurs. ### Committer Checklist (excluded from commit message)

[jira] [Created] (KAFKA-10252) MeteredTimestampedKeyValueStore not setting up correct topic name for GlobalKTable associating StateStores

2020-07-09 Thread Gordon Wang (Jira)
Gordon Wang created KAFKA-10252: --- Summary: MeteredTimestampedKeyValueStore not setting up correct topic name for GlobalKTable associating StateStores Key: KAFKA-10252 URL: https://issues.apache.org/jira/browse/KAFKA

<    1   2