[
https://issues.apache.org/jira/browse/KAFKA-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169229#comment-17169229
]
John Roesler commented on KAFKA-10336:
--
Good thinking, Sophie, that does indeed seem possible.
>
abbccdda commented on a change in pull request #9102:
URL: https://github.com/apache/kafka/pull/9102#discussion_r463920622
##
File path:
clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java
##
@@ -228,6 +228,13 @@ public Password getPassword(String key) {
abbccdda commented on pull request #9108:
URL: https://github.com/apache/kafka/pull/9108#issuecomment-667466886
@albert02lowis I see, let's try to do all of them in one PR then.
This is an automated message from the Apache
kowshik commented on a change in pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#discussion_r463916470
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/UpdateFeaturesResponse.java
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache
albert02lowis commented on pull request #9108:
URL: https://github.com/apache/kafka/pull/9108#issuecomment-667462930
Hi, there's another unit test that need to be moved out
(`StreamStreamJoinIntegrationTest.shouldNotAccessJoinStoresWhenGivingName`) but
I thought of doing that in another
kowshik commented on a change in pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#discussion_r463916688
##
File path:
clients/src/main/resources/common/message/UpdateFinalizedFeaturesResponse.json
##
@@ -0,0 +1,28 @@
+// Licensed to the Apache Software
kowshik commented on a change in pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#discussion_r463916610
##
File path: core/src/main/scala/kafka/controller/KafkaController.scala
##
@@ -983,8 +1144,25 @@ class KafkaController(val config: KafkaConfig,
*/
kowshik commented on a change in pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#discussion_r463916470
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/UpdateFeaturesResponse.java
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache
kowshik commented on a change in pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#discussion_r463916219
##
File path:
clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java
##
@@ -3615,6 +3662,137 @@ public void
kowshik commented on a change in pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#discussion_r463915553
##
File path: core/src/main/scala/kafka/controller/KafkaController.scala
##
@@ -266,6 +275,178 @@ class KafkaController(val config: KafkaConfig,
}
kowshik commented on a change in pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#discussion_r463915406
##
File path: core/src/main/scala/kafka/controller/KafkaController.scala
##
@@ -1647,6 +1844,188 @@ class KafkaController(val config: KafkaConfig,
}
kowshik commented on a change in pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#discussion_r463912498
##
File path:
clients/src/main/java/org/apache/kafka/common/errors/FeatureUpdateFailedException.java
##
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache
kowshik commented on a change in pull request #9110:
URL: https://github.com/apache/kafka/pull/9110#discussion_r463914087
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -2227,14 +2210,17 @@ class Log(@volatile private var _dir: File,
* @param segments The log
kowshik commented on a change in pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#discussion_r463912498
##
File path:
clients/src/main/java/org/apache/kafka/common/errors/FeatureUpdateFailedException.java
##
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache
kowshik commented on a change in pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#discussion_r463912157
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##
@@ -4052,6 +4058,128 @@ void handleFailure(Throwable
chia7712 commented on pull request #9102:
URL: https://github.com/apache/kafka/pull/9102#issuecomment-667456986
> Are there any serde use cases that require client id?
I observed this issue when we are removing custom client id config. It
causes error as the metrics of our serde is
dhruvilshah3 commented on pull request #8850:
URL: https://github.com/apache/kafka/pull/8850#issuecomment-667454222
I attempted to improve the logging further. This also removes the side
effect of logging as part of evaluating the predicate.
https://github.com/apache/kafka/pull/9110
dhruvilshah3 opened a new pull request #9110:
URL: https://github.com/apache/kafka/pull/9110
This PR improves the logging for segment deletion to ensure that a reason is
logged for every segment that is deleted.
This is an
ableegoldman edited a comment on pull request #9024:
URL: https://github.com/apache/kafka/pull/9024#issuecomment-667447234
Ok I totally forgot about this PR.
@guozhangwang @mjsax Let's just merge the demotion of broker/zookeeper logs
and leave streams logs at INFO for now. If that's
ableegoldman commented on pull request #9024:
URL: https://github.com/apache/kafka/pull/9024#issuecomment-667447234
Ok I totally forgot about this PR.
Let's just merge the demotion of broker/zookeeper logs and leave streams
logs at INFO for now. If that's not sufficient for
ableegoldman commented on pull request #9094:
URL: https://github.com/apache/kafka/pull/9094#issuecomment-667445902
`EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta` failed,
all other tests passed
This is
chia7712 commented on pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#issuecomment-667442912
> So, it's just a rebase and there is no change in your PR?
The last change to this PR is to rename a class (according to @ijuma’s
comment)
kowshik commented on a change in pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#discussion_r463880076
##
File path: clients/src/main/java/org/apache/kafka/clients/admin/Admin.java
##
@@ -1214,6 +1215,71 @@ default AlterClientQuotasResult
[
https://issues.apache.org/jira/browse/KAFKA-8027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169189#comment-17169189
]
Guozhang Wang commented on KAFKA-8027:
--
We encountered similar issues in our benchmarks which is
[
https://issues.apache.org/jira/browse/KAFKA-8159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169187#comment-17169187
]
Sophie Blee-Goldman commented on KAFKA-8159:
A related bummer is that you can't do fetches
vvcephei commented on a change in pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#discussion_r463867098
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java
##
@@ -461,6 +463,42 @@ public void flush() {
ableegoldman edited a comment on pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#issuecomment-667306865
Kicked off system tests
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4081
This
[
https://issues.apache.org/jira/browse/KAFKA-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169176#comment-17169176
]
Guozhang Wang commented on KAFKA-:
--
Another walkaround for now, is to use `KTable#mapValues()`
rgroothuijsen commented on a change in pull request #9078:
URL: https://github.com/apache/kafka/pull/9078#discussion_r463845316
##
File path:
clients/src/main/java/org/apache/kafka/common/metrics/JmxReporter.java
##
@@ -272,8 +272,16 @@ public MBeanInfo getMBeanInfo() {
guozhangwang commented on a change in pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#discussion_r463790190
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -368,7 +313,96 @@ public void
ableegoldman commented on pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#issuecomment-667306865
Kicked off system tests
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4080/
This is an
guozhangwang commented on a change in pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#discussion_r463780418
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -368,7 +313,96 @@ public void
Johnny-Malizia commented on pull request #8936:
URL: https://github.com/apache/kafka/pull/8936#issuecomment-667297977
Apologies for my inactivity here, I had to take a little more time to
understand how/when the index files are currently being opened. I'll try to
have this resolved
guozhangwang commented on pull request #9094:
URL: https://github.com/apache/kafka/pull/9094#issuecomment-667297606
test this please
This is an automated message from the Apache Git Service.
To respond to the message, please
guozhangwang commented on pull request #9094:
URL: https://github.com/apache/kafka/pull/9094#issuecomment-667297400
test this please
This is an automated message from the Apache Git Service.
To respond to the message, please
[
https://issues.apache.org/jira/browse/KAFKA-10316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169062#comment-17169062
]
John Thomas commented on KAFKA-10316:
-
[~mjsax] The vote has been open for >72 hours, and the KIP
[
https://issues.apache.org/jira/browse/KAFKA-10186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169052#comment-17169052
]
John Thomas commented on KAFKA-10186:
-
[~ableegoldman] If we abort a transaction with any
[
https://issues.apache.org/jira/browse/KAFKA-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-10336:
--
Labels: bug user-experience (was: )
> Rolling upgrade with Suppression AND Standbys may
ableegoldman commented on a change in pull request #9096:
URL: https://github.com/apache/kafka/pull/9096#discussion_r463752139
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java
##
@@ -144,15 +144,35 @@ private boolean
ableegoldman commented on a change in pull request #9094:
URL: https://github.com/apache/kafka/pull/9094#discussion_r463750941
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/MetricsIntegrationTest.java
##
@@ -668,6 +671,9 @@ private void
[
https://issues.apache.org/jira/browse/KAFKA-10137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169045#comment-17169045
]
Sophie Blee-Goldman commented on KAFKA-10137:
-
Yeah I thought that might be the case,
[
https://issues.apache.org/jira/browse/KAFKA-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169038#comment-17169038
]
Sophie Blee-Goldman commented on KAFKA-10336:
-
Thanks for the detailed bug report. Quick
ableegoldman commented on a change in pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#discussion_r463738138
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -368,7 +313,96 @@ public void
abbccdda commented on pull request #9108:
URL: https://github.com/apache/kafka/pull/9108#issuecomment-667241038
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
hachikuji merged pull request #9109:
URL: https://github.com/apache/kafka/pull/9109
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
junrao commented on pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#issuecomment-667233872
@chia7712 : So, it's just a rebase and there is no change in your PR?
This is an automated message from the Apache
vvcephei commented on pull request #8993:
URL: https://github.com/apache/kafka/pull/8993#issuecomment-667214395
Thanks @guozhangwang ! I've merged to 2.5. If we do an 2.5.1RC1, it'll be
included. Otherwise, it'll go into 2.5.2. Either way, it will run as part of
nightly branch tests.
vvcephei merged pull request #8993:
URL: https://github.com/apache/kafka/pull/8993
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
abbccdda commented on a change in pull request #9105:
URL: https://github.com/apache/kafka/pull/9105#discussion_r463708981
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java
##
@@ -197,8 +197,8 @@ synchronized boolean
vvcephei edited a comment on pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#issuecomment-667212439
Sounds good, @guozhangwang . Another option is to make an internal config so
that we can parameterize the benchmarks and get a more thorough understanding
of the impact
abbccdda commented on a change in pull request #9078:
URL: https://github.com/apache/kafka/pull/9078#discussion_r463708722
##
File path:
clients/src/main/java/org/apache/kafka/common/metrics/JmxReporter.java
##
@@ -272,8 +272,16 @@ public MBeanInfo getMBeanInfo() {
vvcephei commented on pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#issuecomment-667212439
Sounds good, @guozhangwang . Another option is to make an internal config so
that we can parameterize the benchmarks and get a more thorough understanding
of the impact of this
rhauch commented on a change in pull request #9109:
URL: https://github.com/apache/kafka/pull/9109#discussion_r463705431
##
File path: docs/upgrade.html
##
@@ -49,6 +49,14 @@ Notable changes in 2
Fetch requests and other requests intended only for the leader or
[
https://issues.apache.org/jira/browse/KAFKA-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17168979#comment-17168979
]
John Roesler commented on KAFKA-10336:
--
I've upgraded this to a blocker for 2.7.0, so that we won't
[
https://issues.apache.org/jira/browse/KAFKA-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler updated KAFKA-10336:
-
Fix Version/s: 2.7.0
> Rolling upgrade with Suppression AND Standbys may throw exceptions
>
[
https://issues.apache.org/jira/browse/KAFKA-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler updated KAFKA-10336:
-
Affects Version/s: 2.6.0
2.3.0
2.4.0
[
https://issues.apache.org/jira/browse/KAFKA-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler updated KAFKA-10336:
-
Priority: Blocker (was: Major)
> Rolling upgrade with Suppression AND Standbys may throw
[
https://issues.apache.org/jira/browse/KAFKA-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17168977#comment-17168977
]
John Roesler commented on KAFKA-10322:
--
Hi all,
Thanks for your insights [~ableegoldman] !
I
John Roesler created KAFKA-10336:
Summary: Rolling upgrade with Suppression AND Standbys may throw
exceptions
Key: KAFKA-10336
URL: https://issues.apache.org/jira/browse/KAFKA-10336
Project: Kafka
abbccdda commented on a change in pull request #8295:
URL: https://github.com/apache/kafka/pull/8295#discussion_r463682515
##
File path:
clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java
##
@@ -4068,6 +4093,58 @@ public void
hachikuji opened a new pull request #9109:
URL: https://github.com/apache/kafka/pull/9109
Add some notable changes to the reassignment tool for the 2.6 release.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test
abbccdda commented on pull request #9096:
URL: https://github.com/apache/kafka/pull/9096#issuecomment-667173698
retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
rajinisivaram commented on pull request #9092:
URL: https://github.com/apache/kafka/pull/9092#issuecomment-667147526
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log
cadonna commented on a change in pull request #9098:
URL: https://github.com/apache/kafka/pull/9098#discussion_r463617899
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java
##
@@ -181,23 +181,39 @@ void openDB(final ProcessorContext
Alexander Sibiryakov created KAFKA-10335:
Summary: Blocking of producer IO thread when calling send() from
callback
Key: KAFKA-10335
URL: https://issues.apache.org/jira/browse/KAFKA-10335
cadonna commented on a change in pull request #9098:
URL: https://github.com/apache/kafka/pull/9098#discussion_r463578816
##
File path:
streams/test-utils/src/main/java/org/apache/kafka/streams/processor/MockProcessorContext.java
##
@@ -227,7 +228,8 @@ public
Luis Araujo created KAFKA-10334:
---
Summary: Transactions not working properly
Key: KAFKA-10334
URL: https://issues.apache.org/jira/browse/KAFKA-10334
Project: Kafka
Issue Type: Bug
cadonna commented on a change in pull request #9094:
URL: https://github.com/apache/kafka/pull/9094#discussion_r463514179
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/MetricsIntegrationTest.java
##
@@ -668,6 +671,9 @@ private void
cadonna commented on a change in pull request #9094:
URL: https://github.com/apache/kafka/pull/9094#discussion_r463514179
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/MetricsIntegrationTest.java
##
@@ -668,6 +671,9 @@ private void
Mickael Maison created KAFKA-10333:
--
Summary: Provide an API to retrieve Kafka Connect task
configurations
Key: KAFKA-10333
URL: https://issues.apache.org/jira/browse/KAFKA-10333
Project: Kafka
Mickael Maison created KAFKA-10332:
--
Summary: MirrorMaker2 fails to detect topic is remote topic is
created first
Key: KAFKA-10332
URL: https://issues.apache.org/jira/browse/KAFKA-10332
Project:
[
https://issues.apache.org/jira/browse/KAFKA-10332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison updated KAFKA-10332:
---
Summary: MirrorMaker2 fails to detect topic if remote topic is created
first (was:
Wojtek Konsek created KAFKA-10331:
-
Summary: MirrorMaker2 active-active replication without topic
renaming
Key: KAFKA-10331
URL: https://issues.apache.org/jira/browse/KAFKA-10331
Project: Kafka
mimaison commented on pull request #8295:
URL: https://github.com/apache/kafka/pull/8295#issuecomment-667010664
The test failure is unrelated. It's
`org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest >
shouldUpgradeFromEosAlphaToEosBeta[true]` again
[
https://issues.apache.org/jira/browse/KAFKA-10137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17168521#comment-17168521
]
Bruno Cadonna commented on KAFKA-10137:
---
I also noticed this the last time I looked at
[
https://issues.apache.org/jira/browse/KAFKA-8328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17168515#comment-17168515
]
ChenLin commented on KAFKA-8328:
Thanks for your attention, I will re submit the batch to the trunk
[
https://issues.apache.org/jira/browse/KAFKA-8328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17168514#comment-17168514
]
ChenLin commented on KAFKA-8328:
Thanks for your attention, I will re submit the batch to the trunk
inponomarev edited a comment on pull request #9107:
URL: https://github.com/apache/kafka/pull/9107#issuecomment-666749809
⚠️ Two differences with KIP specification, discussion needed⚠️
1. Instead of multiple overloaded variants of `Branched.with` we now have
`Branched.withFunction`
[
https://issues.apache.org/jira/browse/KAFKA-10282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bob Barrett resolved KAFKA-10282.
-
Resolution: Fixed
> Log metrics are removed if a log is deleted and re-created quickly enough
>
chia7712 commented on pull request #8978:
URL: https://github.com/apache/kafka/pull/8978#issuecomment-666943950
@kkonstantine Could you please take a look?
This is an automated message from the Apache Git Service.
To respond
80 matches
Mail list logo
