[GitHub] [kafka] highluck commented on a change in pull request #9105: MINOR: closable object Memory leak prevention

highluck commented on a change in pull request #9105: URL: https://github.com/apache/kafka/pull/9105#discussion_r464215307 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java ## @@ -197,8 +197,8 @@ synchronized boolean lock(fina

[GitHub] [kafka] chia7712 commented on a change in pull request #9102: KAFKA-10326 Both serializer and deserializer should be able to see th…

chia7712 commented on a change in pull request #9102: URL: https://github.com/apache/kafka/pull/9102#discussion_r464216698 ## File path: clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java ## @@ -228,6 +228,13 @@ public Password getPassword(String key) {

[GitHub] [kafka] highluck commented on a change in pull request #9105: MINOR: closable object Memory leak prevention

highluck commented on a change in pull request #9105: URL: https://github.com/apache/kafka/pull/9105#discussion_r464215307 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java ## @@ -197,8 +197,8 @@ synchronized boolean lock(fina

[GitHub] [kafka] kowshik commented on a change in pull request #9110: MINOR: Ensure a reason is logged for every segment deletion

kowshik commented on a change in pull request #9110: URL: https://github.com/apache/kafka/pull/9110#discussion_r464213840 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -2227,13 +2210,16 @@ class Log(@volatile private var _dir: File, * @param segments The log s

[GitHub] [kafka] chia7712 commented on pull request #9102: KAFKA-10326 Both serializer and deserializer should be able to see th…

chia7712 commented on pull request #9102: URL: https://github.com/apache/kafka/pull/9102#issuecomment-667819033 @guozhangwang thanks for reviews > One (very) minor thing is that, may also be overridden when passing into the coordinator object, i.e. the value read from ConsumerConfig

[GitHub] [kafka] abbccdda commented on pull request #9096: MINOR: Add comments to constrainedAssign and generalAssign method

abbccdda commented on pull request #9096: URL: https://github.com/apache/kafka/pull/9096#issuecomment-667819088 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] showuon commented on pull request #9096: MINOR: Add comments to constrainedAssign and generalAssign method

showuon commented on pull request #9096: URL: https://github.com/apache/kafka/pull/9096#issuecomment-667784086 Thanks @ableegoldman . I've updated based on your suggestion. Thanks. This is an automated message from the Apache

[GitHub] [kafka] guozhangwang commented on pull request #9102: KAFKA-10326 Both serializer and deserializer should be able to see th…

guozhangwang commented on pull request #9102: URL: https://github.com/apache/kafka/pull/9102#issuecomment-667734629 This change makes sense to me, thanks @chia7712 One (very) minor thing is that, `enableAutoCommit` may also be overridden when passing into the coordinator object, i.e

[GitHub] [kafka] RamanVerma commented on pull request #9112: KAFKA-10312 Fix error code returned by getPartitionMetadata

RamanVerma commented on pull request #9112: URL: https://github.com/apache/kafka/pull/9112#issuecomment-667719404 cc @hachikuji Not sure why I am not able to add anyone as a reviewer to the PR. I am not getting the add reviewers/recommended reviewers options. -

[GitHub] [kafka] RamanVerma commented on pull request #9112: KAFKA-10312 Fix error code returned by getPartitionMetadata

RamanVerma commented on pull request #9112: URL: https://github.com/apache/kafka/pull/9112#issuecomment-667719141 Ran `./gradlew core:test` locally. All tests passed. This is an automated message from the Apache Git Service.

[GitHub] [kafka] RamanVerma opened a new pull request #9112: KAFKA-10312 Fix error code returned by getPartitionMetadata

RamanVerma opened a new pull request #9112: URL: https://github.com/apache/kafka/pull/9112 MetadataCache#getPartitionMetadata returns an error when the topic's leader Id is present at MetadataCache but listener endpoint is not present for this leader. For older version, LEADER_NOT_AV

[jira] [Commented] (KAFKA-10316) Consider renaming getter method for Interactive Queries

[ https://issues.apache.org/jira/browse/KAFKA-10316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17169607#comment-17169607 ] John Thomas commented on KAFKA-10316: - Ah, I was just reading the KIP documentations

[jira] [Resolved] (KAFKA-10303) kafka producer says connect failed in cluster mode

[ https://issues.apache.org/jira/browse/KAFKA-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Soarez resolved KAFKA-10303. - Resolution: Incomplete > kafka producer says connect failed in cluster mode > --

[GitHub] [kafka] dhruvilshah3 commented on a change in pull request #9110: MINOR: Ensure a reason is logged for every segment deletion

dhruvilshah3 commented on a change in pull request #9110: URL: https://github.com/apache/kafka/pull/9110#discussion_r464100823 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -2227,14 +2210,17 @@ class Log(@volatile private var _dir: File, * @param segments The

[GitHub] [kafka] ijuma closed pull request #1417: KAFKA-3720 : Deprecated BufferExhaustedException and also removed its use and the related sensor metric

ijuma closed pull request #1417: URL: https://github.com/apache/kafka/pull/1417 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] ijuma commented on pull request #1417: KAFKA-3720 : Deprecated BufferExhaustedException and also removed its use and the related sensor metric

ijuma commented on pull request #1417: URL: https://github.com/apache/kafka/pull/1417#issuecomment-667686994 Superseded by #8399. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] ijuma commented on pull request #8399: KAFKA-3720: Change TimeoutException to BufferExhaustedException when no memory can be allocated for a record within max.block.ms

ijuma commented on pull request #8399: URL: https://github.com/apache/kafka/pull/8399#issuecomment-667686748 @soenkeliebau did you file the JIRA @junrao mentioned above? It would be good to reference it here. This is an auto