[GitHub] [kafka] omkreddy commented on pull request #9200: MINOR: mirror integration tests should not call System.exit

2020-08-18 Thread GitBox
omkreddy commented on pull request #9200: URL: https://github.com/apache/kafka/pull/9200#issuecomment-675864751 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] lbradstreet commented on a change in pull request #9200: MINOR: mirror integration tests should not call System.exit

2020-08-18 Thread GitBox
lbradstreet commented on a change in pull request #9200: URL: https://github.com/apache/kafka/pull/9200#discussion_r472723313 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorConnectorsIntegrationTest.java ## @@ -185,10 +192,9 @@ public void

[GitHub] [kafka] lbradstreet commented on a change in pull request #9200: MINOR: mirror integration tests should not call System.exit

2020-08-18 Thread GitBox
lbradstreet commented on a change in pull request #9200: URL: https://github.com/apache/kafka/pull/9200#discussion_r472723414 ## File path: core/src/test/scala/integration/kafka/tools/MirrorMakerIntegrationTest.scala ## @@ -29,14 +29,31 @@ import

[GitHub] [kafka] cmccabe commented on pull request #9197: Revert KAFKA-9309: Add the ability to translate Message to JSON

2020-08-18 Thread GitBox
cmccabe commented on pull request #9197: URL: https://github.com/apache/kafka/pull/9197#issuecomment-675859396 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] showuon commented on pull request #9149: KAFKA-10340: improve the logging to help user know what is going on

2020-08-18 Thread GitBox
showuon commented on pull request #9149: URL: https://github.com/apache/kafka/pull/9149#issuecomment-675858452 @kkonstantine , could you help review this PR to improve logging? Thanks. This is an automated message from the

[jira] [Commented] (KAFKA-8135) Kafka Producer deadlocked on flush call with intermittent broker unavailability

2020-08-18 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17180258#comment-17180258 ] Ismael Juma commented on KAFKA-8135: [~rana.deb23] I suggest filing a new issue and please provide

[GitHub] [kafka] cmccabe commented on pull request #9197: Revert KAFKA-9309: Add the ability to translate Message to JSON

2020-08-18 Thread GitBox
cmccabe commented on pull request #9197: URL: https://github.com/apache/kafka/pull/9197#issuecomment-675851293 There seems to be a Jenkins issue here: ``` 21:54:39 Fetching upstream changes from git://github.com/apache/kafka.git 21:54:39 > git fetch --tags --progress --

[GitHub] [kafka] cmccabe commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

2020-08-18 Thread GitBox
cmccabe commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r472693268 ## File path: core/src/test/scala/unit/kafka/admin/ConfigCommandTest.scala ## @@ -486,7 +486,9 @@ class ConfigCommandTest extends ZooKeeperTestHarness with

[GitHub] [kafka] cmccabe commented on pull request #9197: Revert KAFKA-9309: Add the ability to translate Message to JSON

2020-08-18 Thread GitBox
cmccabe commented on pull request #9197: URL: https://github.com/apache/kafka/pull/9197#issuecomment-675850067 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] cmccabe commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

2020-08-18 Thread GitBox
cmccabe commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r472688926 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DescribeUserScramCredentialsResult.java ## @@ -0,0 +1,50 @@ +/* + * Licensed to the

[jira] [Resolved] (KAFKA-9708) Connector does not prefer to use packaged classes during configuration

2020-08-18 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis resolved KAFKA-9708. --- Resolution: Fixed > Connector does not prefer to use packaged classes during

[jira] [Commented] (KAFKA-9708) Connector does not prefer to use packaged classes during configuration

2020-08-18 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17180249#comment-17180249 ] Konstantine Karantasis commented on KAFKA-9708: --- The PR was closed with a note that this

[jira] [Updated] (KAFKA-9708) Connector does not prefer to use packaged classes during configuration

2020-08-18 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-9708: -- Fix Version/s: 2.6.0 > Connector does not prefer to use packaged classes

[GitHub] [kafka] rondagostino commented on a change in pull request #9200: MINOR: mirror integration tests should not call System.exit

2020-08-18 Thread GitBox
rondagostino commented on a change in pull request #9200: URL: https://github.com/apache/kafka/pull/9200#discussion_r472636924 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorConnectorsIntegrationTest.java ## @@ -185,10 +192,9 @@ public void

[GitHub] [kafka] showuon commented on pull request #9062: KAFKA-8098: fix the flaky test by disabling the auto commit to avoid member rejoining

2020-08-18 Thread GitBox
showuon commented on pull request #9062: URL: https://github.com/apache/kafka/pull/9062#issuecomment-675828534 @abbccdda @omkreddy , could you review this PR? Thanks. This is an automated message from the Apache Git Service.

[GitHub] [kafka] showuon commented on pull request #9121: KAFKA-10351: add tests for IOExceptions for GlobalStateManagerImpl/OffsetCheckpoint

2020-08-18 Thread GitBox
showuon commented on pull request #9121: URL: https://github.com/apache/kafka/pull/9121#issuecomment-675828368 @mjsax , could you review this small PR? Thanks. This is an automated message from the Apache Git Service. To

[GitHub] [kafka] LMnet commented on pull request #8955: KAFKA-10020: Create a new version of a scala Serdes without name clash (KIP-616)

2020-08-18 Thread GitBox
LMnet commented on pull request #8955: URL: https://github.com/apache/kafka/pull/8955#issuecomment-675817076 Voting for the KIP successfully finished and this pull request could be merged now. This is an automated message

[GitHub] [kafka] rondagostino commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

2020-08-18 Thread GitBox
rondagostino commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r472575326 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DescribeUserScramCredentialsResult.java ## @@ -0,0 +1,50 @@ +/* + * Licensed to

[GitHub] [kafka] rondagostino commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

2020-08-18 Thread GitBox
rondagostino commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r472570823 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DescribeUserScramCredentialsResult.java ## @@ -0,0 +1,50 @@ +/* + * Licensed to

[GitHub] [kafka] rondagostino commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

2020-08-18 Thread GitBox
rondagostino commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r472574569 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DescribeUserScramCredentialsResult.java ## @@ -0,0 +1,50 @@ +/* + * Licensed to

[GitHub] [kafka] mjsax merged pull request #9198: HOTFIX: use Exit.exit instead of System.exit

2020-08-18 Thread GitBox
mjsax merged pull request #9198: URL: https://github.com/apache/kafka/pull/9198 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] rondagostino commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

2020-08-18 Thread GitBox
rondagostino commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r472570823 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DescribeUserScramCredentialsResult.java ## @@ -0,0 +1,50 @@ +/* + * Licensed to

[GitHub] [kafka] rondagostino commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

2020-08-18 Thread GitBox
rondagostino commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r472570823 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DescribeUserScramCredentialsResult.java ## @@ -0,0 +1,50 @@ +/* + * Licensed to

[GitHub] [kafka] lbradstreet opened a new pull request #9200: MINOR: mirror integration tests should not call System.exit

2020-08-18 Thread GitBox
lbradstreet opened a new pull request #9200: URL: https://github.com/apache/kafka/pull/9200 406635bcc9f2a4c439d198ea0549170de331323c switched System.exit to using Exit.exit, however the integration tests did not choose to override the exit procedure. This can cause invalid test

[GitHub] [kafka] vvcephei commented on a change in pull request #9137: KAFKA-9929: Support reverse iterator on KeyValueStore

2020-08-18 Thread GitBox
vvcephei commented on a change in pull request #9137: URL: https://github.com/apache/kafka/pull/9137#discussion_r472531237 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBPrefixIterator.java ## @@ -1,54 +0,0 @@ -/* - * Licensed to the

[GitHub] [kafka] cmccabe commented on pull request #9198: HOTFIX: use Exit.exit instead of System.exit

2020-08-18 Thread GitBox
cmccabe commented on pull request #9198: URL: https://github.com/apache/kafka/pull/9198#issuecomment-675755685 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] rondagostino commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

2020-08-18 Thread GitBox
rondagostino commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r472530253 ## File path: core/src/test/scala/unit/kafka/admin/ConfigCommandTest.scala ## @@ -486,7 +486,9 @@ class ConfigCommandTest extends ZooKeeperTestHarness

[GitHub] [kafka] cmccabe commented on pull request #9199: KAFKA-10418: alter topic configs via kafka-topics error text

2020-08-18 Thread GitBox
cmccabe commented on pull request #9199: URL: https://github.com/apache/kafka/pull/9199#issuecomment-675734800 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] cmccabe commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

2020-08-18 Thread GitBox
cmccabe commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r472507947 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DescribeUserScramCredentialsResult.java ## @@ -0,0 +1,50 @@ +/* + * Licensed to the

[GitHub] [kafka] mjsax commented on pull request #9067: MINOR: Streams integration tests should not call exit

2020-08-18 Thread GitBox
mjsax commented on pull request #9067: URL: https://github.com/apache/kafka/pull/9067#issuecomment-675733090 Seems I made a mistake cherry-picking to `2.6` -- I remember that there was a conflict; guess I resolved it incorrectly. Did a HOTFIX PR: #9198

[GitHub] [kafka] rondagostino commented on pull request #9199: KAFKA-10418: alter topic configs via kafka-topics error text

2020-08-18 Thread GitBox
rondagostino commented on pull request #9199: URL: https://github.com/apache/kafka/pull/9199#issuecomment-675731352 @cmccabe Can you take a look? This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] rondagostino opened a new pull request #9199: KAFKA-10418: alter topic configs via kafka-topics error text

2020-08-18 Thread GitBox
rondagostino opened a new pull request #9199: URL: https://github.com/apache/kafka/pull/9199 Changing a topic config with the `kafka-topics` command while connecting to Kafka via `--bootstrap-server` (rather than connecting to ZooKeeper via `--zookeeper`) is not supported. The desired

[GitHub] [kafka] mjsax opened a new pull request #9198: HOTFIX: use Exit.exit instead of System.exit

2020-08-18 Thread GitBox
mjsax opened a new pull request #9198: URL: https://github.com/apache/kafka/pull/9198 Follow up to #9067 -- seems I made an error resolving the unclean cherry-pick from `trunk` to `2.6`. Call for review @vvcephei @ijuma

[GitHub] [kafka] cmccabe commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

2020-08-18 Thread GitBox
cmccabe commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r472501147 ## File path: core/src/test/scala/unit/kafka/admin/ConfigCommandTest.scala ## @@ -486,7 +486,9 @@ class ConfigCommandTest extends ZooKeeperTestHarness with

[GitHub] [kafka] cmccabe commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

2020-08-18 Thread GitBox
cmccabe commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r472498809 ## File path: clients/src/test/java/org/apache/kafka/common/protocol/ProtoUtilsTest.java ## @@ -26,11 +26,18 @@ public void

[GitHub] [kafka] cmccabe commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

2020-08-18 Thread GitBox
cmccabe commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r472496932 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/UserScramCredentialsDescription.java ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] cmccabe commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

2020-08-18 Thread GitBox
cmccabe commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r472494891 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/Admin.java ## @@ -1214,6 +1215,64 @@ default AlterClientQuotasResult

[GitHub] [kafka] mimaison commented on pull request #8050: MINOR: Include call name in TimeoutException

2020-08-18 Thread GitBox
mimaison commented on pull request #8050: URL: https://github.com/apache/kafka/pull/8050#issuecomment-675714697 @omkreddy @hachikuji Can you take a look? Thanks This is an automated message from the Apache Git Service. To

[GitHub] [kafka] cmccabe commented on pull request #9194: KAFKA-10384: Separate converters from generated messages

2020-08-18 Thread GitBox
cmccabe commented on pull request #9194: URL: https://github.com/apache/kafka/pull/9194#issuecomment-675714307 JDK8 test failure looks like a Jenkins issue. ``` 13:29:01 Fetching upstream changes from git://github.com/apache/kafka.git 13:29:01 > git fetch --tags --progress --

[GitHub] [kafka] mimaison commented on pull request #9131: KAFKA-10367: Allow running the Streams demo app with a config file

2020-08-18 Thread GitBox
mimaison commented on pull request #9131: URL: https://github.com/apache/kafka/pull/9131#issuecomment-675713485 @mjsax Can you take another look? Thanks This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] cmccabe commented on pull request #9197: Revert KAFKA-9309: Add the ability to translate Message to JSON

2020-08-18 Thread GitBox
cmccabe commented on pull request #9197: URL: https://github.com/apache/kafka/pull/9197#issuecomment-675711065 Looks like there is a checkstyle issue upstream: ``` 12:59:42 > Task :streams:upgrade-system-tests-22:checkstyleTest FAILED 12:59:42 [ant:checkstyle] [ERROR]

[GitHub] [kafka] cmccabe merged pull request #9144: KAFKA-9705: (part-1) add redirection fields in the request header

2020-08-18 Thread GitBox
cmccabe merged pull request #9144: URL: https://github.com/apache/kafka/pull/9144 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] cmccabe commented on a change in pull request #9144: KAFKA-9705: (part-1) add redirection fields in the request header

2020-08-18 Thread GitBox
cmccabe commented on a change in pull request #9144: URL: https://github.com/apache/kafka/pull/9144#discussion_r472477998 ## File path: clients/src/main/java/org/apache/kafka/clients/KafkaClient.java ## @@ -189,16 +189,18 @@ ClientRequest newClientRequest(String nodeId,

[GitHub] [kafka] cmccabe commented on pull request #9144: KAFKA-9705: (part-1) add redirection fields in the request header

2020-08-18 Thread GitBox
cmccabe commented on pull request #9144: URL: https://github.com/apache/kafka/pull/9144#issuecomment-675703162 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] mimaison commented on pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

2020-08-18 Thread GitBox
mimaison commented on pull request #8295: URL: https://github.com/apache/kafka/pull/8295#issuecomment-675697535 @abbccdda Thanks for the reviews, can you take another look? This is an automated message from the Apache Git

[jira] [Updated] (KAFKA-10418) Unclear error/docs when altering topic configs via kafka-topics with --bootstrap-server

2020-08-18 Thread Ron Dagostino (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ron Dagostino updated KAFKA-10418: -- Summary: Unclear error/docs when altering topic configs via kafka-topics with

[jira] [Updated] (KAFKA-10418) Unclear error/docs when altering topic configs via kafka-topics with --bootstrap-server

2020-08-18 Thread Ron Dagostino (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ron Dagostino updated KAFKA-10418: -- Description: Changing a topic config with the kafka-topics command while connecting to Kafka

[jira] [Updated] (KAFKA-10418) Incomplete error/docs when altering topic configs via kafka-topics with --bootstrap-server

2020-08-18 Thread Ron Dagostino (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ron Dagostino updated KAFKA-10418: -- Summary: Incomplete error/docs when altering topic configs via kafka-topics with

[jira] [Created] (KAFKA-10419) KAFKA BROKER Shuts down when a topic is deleted manually from command line on Windows 1) operating System.

2020-08-18 Thread Ajay Kapoor (Jira)
Ajay Kapoor created KAFKA-10419: --- Summary: KAFKA BROKER Shuts down when a topic is deleted manually from command line on Windows 1) operating System. Key: KAFKA-10419 URL:

[jira] [Created] (KAFKA-10418) Unclear deprecation of altering topic configs via kafka-topics with --bootstrap-server

2020-08-18 Thread Ron Dagostino (Jira)
Ron Dagostino created KAFKA-10418: - Summary: Unclear deprecation of altering topic configs via kafka-topics with --bootstrap-server Key: KAFKA-10418 URL: https://issues.apache.org/jira/browse/KAFKA-10418

[GitHub] [kafka] ableegoldman commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

2020-08-18 Thread GitBox
ableegoldman commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r472441802 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/SlidingWindowedKStreamImplTest.java ## @@ -0,0 +1,438 @@ +/* + *

[GitHub] [kafka] lct45 commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

2020-08-18 Thread GitBox
lct45 commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r472440045 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/SlidingWindowedKStreamImplTest.java ## @@ -0,0 +1,438 @@ +/* + * Licensed to

[GitHub] [kafka] cmccabe opened a new pull request #9197: Revert KAFKA-9309: Add the ability to translate Message to JSON

2020-08-18 Thread GitBox
cmccabe opened a new pull request #9197: URL: https://github.com/apache/kafka/pull/9197 This reverts commit bf6dffe93bbe0fe33ad076ebccebb840d66b936d This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (KAFKA-10415) Provide an officially supported Node.js client

2020-08-18 Thread Matthew T. Adams (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17180036#comment-17180036 ] Matthew T. Adams commented on KAFKA-10415: -- [~ijuma] I understand.  Should I have filed an

[GitHub] [kafka] abbccdda commented on pull request #8846: KAFKA-9800: [KIP-580] Client Exponential Backoff Implementation

2020-08-18 Thread GitBox
abbccdda commented on pull request #8846: URL: https://github.com/apache/kafka/pull/8846#issuecomment-675675970 Some compilation errors: ``` 11:41:23 /home/jenkins/jenkins-slave/workspace/kafka-pr-jdk15-scala2.13/clients/src/main/java/org/apache/kafka/clients/Metadata.java:474:

[GitHub] [kafka] lct45 commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

2020-08-18 Thread GitBox
lct45 commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r472436400 ## File path: checkstyle/suppressions.xml ## @@ -167,6 +167,9 @@ + Review comment: We don't!

[GitHub] [kafka] guozhangwang commented on a change in pull request #9177: KAFKA-9924: Add RocksDB metric num-entries-active-mem-table

2020-08-18 Thread GitBox
guozhangwang commented on a change in pull request #9177: URL: https://github.com/apache/kafka/pull/9177#discussion_r472429141 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/metrics/RocksDBMetrics.java ## @@ -33,7 +35,7 @@ import static

[jira] [Updated] (KAFKA-10327) Make flush after some count of putted records in SinkTask

2020-08-18 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-10327: --- Labels: kip-required needs-kip (was: ) > Make flush after some count of

[GitHub] [kafka] guozhangwang commented on pull request #9177: KAFKA-9924: Add RocksDB metric num-entries-active-mem-table

2020-08-18 Thread GitBox
guozhangwang commented on pull request #9177: URL: https://github.com/apache/kafka/pull/9177#issuecomment-675651901 test this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] abbccdda commented on pull request #8846: KAFKA-9800: [KIP-580] Client Exponential Backoff Implementation

2020-08-18 Thread GitBox
abbccdda commented on pull request #8846: URL: https://github.com/apache/kafka/pull/8846#issuecomment-675647225 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Commented] (KAFKA-10415) Provide an officially supported Node.js client

2020-08-18 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17179995#comment-17179995 ] Ismael Juma commented on KAFKA-10415: - Thanks for the JIRA. One clarification, Apache Kafka doesn't

[jira] [Comment Edited] (KAFKA-10415) Provide an officially supported Node.js client

2020-08-18 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17179995#comment-17179995 ] Ismael Juma edited comment on KAFKA-10415 at 8/18/20, 6:14 PM: --- Thanks for

[GitHub] [kafka] guozhangwang commented on a change in pull request #9191: [WIP] KAFKA-10355: PoC

2020-08-18 Thread GitBox
guozhangwang commented on a change in pull request #9191: URL: https://github.com/apache/kafka/pull/9191#discussion_r472368768 ## File path: streams/src/main/java/org/apache/kafka/streams/errors/MissingSourceTopicException.java ## @@ -0,0 +1,26 @@ +/* + * Licensed to the

[GitHub] [kafka] vvcephei commented on a change in pull request #9148: KAFKA-10379: Implement the KIP-478 StreamBuilder#addGlobalStore()

2020-08-18 Thread GitBox
vvcephei commented on a change in pull request #9148: URL: https://github.com/apache/kafka/pull/9148#discussion_r472368613 ## File path: streams/src/test/java/org/apache/kafka/test/MockApiProcessorSupplier.java ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] wcarlson5 closed pull request #7492: Kafka 7499 production exception handler serialization exceptions

2020-08-18 Thread GitBox
wcarlson5 closed pull request #7492: URL: https://github.com/apache/kafka/pull/7492 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] vvcephei commented on a change in pull request #9148: KAFKA-10379: Implement the KIP-478 StreamBuilder#addGlobalStore()

2020-08-18 Thread GitBox
vvcephei commented on a change in pull request #9148: URL: https://github.com/apache/kafka/pull/9148#discussion_r472348482 ## File path: streams/src/test/java/org/apache/kafka/test/MockApiProcessor.java ## @@ -0,0 +1,174 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Resolved] (KAFKA-10395) TopologyTestDriver does not work with dynamic topic routing

2020-08-18 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman resolved KAFKA-10395. - Fix Version/s: 2.7.0 Resolution: Fixed > TopologyTestDriver does not

[GitHub] [kafka] vvcephei commented on a change in pull request #9148: KAFKA-10379: Implement the KIP-478 StreamBuilder#addGlobalStore()

2020-08-18 Thread GitBox
vvcephei commented on a change in pull request #9148: URL: https://github.com/apache/kafka/pull/9148#discussion_r472327085 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java ## @@ -667,7 +674,7 @@ public void

[jira] [Commented] (KAFKA-8606) Provide a method to fetch committed offsets for a collection of TopicPartition

2020-08-18 Thread Mark Roberts (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17179703#comment-17179703 ] Mark Roberts commented on KAFKA-8606: - I'm reasonably sure that this ticket can be closed as of 2.4

[GitHub] [kafka] rondagostino commented on a change in pull request #9142: MINOR: Fix delete_topic for system tests

2020-08-18 Thread GitBox
rondagostino commented on a change in pull request #9142: URL: https://github.com/apache/kafka/pull/9142#discussion_r472279480 ## File path: tests/kafkatest/services/kafka/kafka.py ## @@ -503,7 +503,7 @@ def create_topic(self, topic_cfg, node=None,

[GitHub] [kafka] cadonna commented on a change in pull request #9177: KAFKA-9924: Add RocksDB metric num-entries-active-mem-table

2020-08-18 Thread GitBox
cadonna commented on a change in pull request #9177: URL: https://github.com/apache/kafka/pull/9177#discussion_r472276615 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java ## @@ -415,9 +416,40 @@ public final

[GitHub] [kafka] cadonna commented on a change in pull request #9177: KAFKA-9924: Add RocksDB metric num-entries-active-mem-table

2020-08-18 Thread GitBox
cadonna commented on a change in pull request #9177: URL: https://github.com/apache/kafka/pull/9177#discussion_r472276615 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java ## @@ -415,9 +416,40 @@ public final

[jira] [Updated] (KAFKA-10417) suppress() with cogroup() throws ClassCastException

2020-08-18 Thread Wardha Perinkada Kattu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wardha Perinkada Kattu updated KAFKA-10417: --- Description: Streams operation - `cogroup()`, `aggregate()` followed by

[jira] [Created] (KAFKA-10417) suppress() with cogroup() throws ClassCastException

2020-08-18 Thread Wardha Perinkada Kattu (Jira)
Wardha Perinkada Kattu created KAFKA-10417: -- Summary: suppress() with cogroup() throws ClassCastException Key: KAFKA-10417 URL: https://issues.apache.org/jira/browse/KAFKA-10417 Project:

[jira] [Commented] (KAFKA-10370) WorkerSinkTask: IllegalStateException cased by consumer.seek(tp, offsets) when (tp, offsets) are supplied by WorkerSinkTaskContext

2020-08-18 Thread Ning Zhang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17179669#comment-17179669 ] Ning Zhang commented on KAFKA-10370: Hey [~ryannedolan] I updated the PR with the following code in

[GitHub] [kafka] vvcephei edited a comment on pull request #9177: KAFKA-9924: Add RocksDB metric num-entries-active-mem-table

2020-08-18 Thread GitBox
vvcephei edited a comment on pull request #9177: URL: https://github.com/apache/kafka/pull/9177#issuecomment-675522188 Looks like Jenkins shut down during the run last time or something. Retest this please This is an

[GitHub] [kafka] vvcephei commented on pull request #9177: KAFKA-9924: Add RocksDB metric num-entries-active-mem-table

2020-08-18 Thread GitBox
vvcephei commented on pull request #9177: URL: https://github.com/apache/kafka/pull/9177#issuecomment-675522188 Retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] vvcephei commented on pull request #9177: KAFKA-9924: Add RocksDB metric num-entries-active-mem-table

2020-08-18 Thread GitBox
vvcephei commented on pull request #9177: URL: https://github.com/apache/kafka/pull/9177#issuecomment-675521788 Thanks for the update, @cadonna . Just one reply above. This is an automated message from the Apache Git

[GitHub] [kafka] vvcephei commented on a change in pull request #9177: KAFKA-9924: Add RocksDB metric num-entries-active-mem-table

2020-08-18 Thread GitBox
vvcephei commented on a change in pull request #9177: URL: https://github.com/apache/kafka/pull/9177#discussion_r472250612 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java ## @@ -415,9 +416,40 @@ public final

[GitHub] [kafka] vvcephei merged pull request #9174: KAFKA-10395: relax output topic check in TTD to work with dynamic routing

2020-08-18 Thread GitBox
vvcephei merged pull request #9174: URL: https://github.com/apache/kafka/pull/9174 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] vvcephei commented on a change in pull request #9174: KAFKA-10395: relax output topic check in TTD to work with dynamic routing

2020-08-18 Thread GitBox
vvcephei commented on a change in pull request #9174: URL: https://github.com/apache/kafka/pull/9174#discussion_r472242890 ## File path: streams/test-utils/src/main/java/org/apache/kafka/streams/TopologyTestDriver.java ## @@ -805,10 +805,10 @@ public void

[jira] [Created] (KAFKA-10416) Provide an officially supported Deno client

2020-08-18 Thread Matthew T. Adams (Jira)
Matthew T. Adams created KAFKA-10416: Summary: Provide an officially supported Deno client Key: KAFKA-10416 URL: https://issues.apache.org/jira/browse/KAFKA-10416 Project: Kafka Issue

[jira] [Created] (KAFKA-10415) Provide an officially supported Node.js client

2020-08-18 Thread Matthew T. Adams (Jira)
Matthew T. Adams created KAFKA-10415: Summary: Provide an officially supported Node.js client Key: KAFKA-10415 URL: https://issues.apache.org/jira/browse/KAFKA-10415 Project: Kafka Issue

[jira] [Assigned] (KAFKA-10414) Upgrade api-util dependency - CVE-2018-1337

2020-08-18 Thread Daniel Urban (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Urban reassigned KAFKA-10414: Assignee: Daniel Urban > Upgrade api-util dependency - CVE-2018-1337 >

[jira] [Created] (KAFKA-10414) Upgrade api-util dependency - CVE-2018-1337

2020-08-18 Thread Daniel Urban (Jira)
Daniel Urban created KAFKA-10414: Summary: Upgrade api-util dependency - CVE-2018-1337 Key: KAFKA-10414 URL: https://issues.apache.org/jira/browse/KAFKA-10414 Project: Kafka Issue Type: Bug

[GitHub] [kafka] cadonna commented on a change in pull request #9191: [WIP] KAFKA-10355: PoC

2020-08-18 Thread GitBox
cadonna commented on a change in pull request #9191: URL: https://github.com/apache/kafka/pull/9191#discussion_r472228811 ## File path: streams/src/main/java/org/apache/kafka/streams/errors/MissingSourceTopicException.java ## @@ -0,0 +1,26 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] cadonna commented on a change in pull request #9191: [WIP] KAFKA-10355: PoC

2020-08-18 Thread GitBox
cadonna commented on a change in pull request #9191: URL: https://github.com/apache/kafka/pull/9191#discussion_r472217989 ## File path: streams/src/main/java/org/apache/kafka/streams/errors/MissingSourceTopicException.java ## @@ -0,0 +1,26 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] cadonna commented on a change in pull request #9177: KAFKA-9924: Add RocksDB metric num-entries-active-mem-table

2020-08-18 Thread GitBox
cadonna commented on a change in pull request #9177: URL: https://github.com/apache/kafka/pull/9177#discussion_r472200360 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java ## @@ -415,9 +416,40 @@ public final

[GitHub] [kafka] rhauch commented on pull request #9176: Allow replace all for RegexRouter

2020-08-18 Thread GitBox
rhauch commented on pull request #9176: URL: https://github.com/apache/kafka/pull/9176#issuecomment-675475664 @kkonstantine is correct that this changes the public API and therefore requires a KIP. Please also create a Jira issue, and change the title of this PR so that it starts

[jira] [Commented] (KAFKA-8135) Kafka Producer deadlocked on flush call with intermittent broker unavailability

2020-08-18 Thread Ranadeep Deb (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17179616#comment-17179616 ] Ranadeep Deb commented on KAFKA-8135: - I have been experiencing a similar issue in 2.12-2.3.0 I have

[jira] [Created] (KAFKA-10413) rebalancing leads to unevenly balanced connectors

2020-08-18 Thread yazgoo (Jira)
yazgoo created KAFKA-10413: -- Summary: rebalancing leads to unevenly balanced connectors Key: KAFKA-10413 URL: https://issues.apache.org/jira/browse/KAFKA-10413 Project: Kafka Issue Type: Bug

[GitHub] [kafka] cadonna commented on a change in pull request #9177: KAFKA-9924: Add RocksDB metric num-entries-active-mem-table

2020-08-18 Thread GitBox
cadonna commented on a change in pull request #9177: URL: https://github.com/apache/kafka/pull/9177#discussion_r472100951 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/metrics/RocksDBMetricsRecorder.java ## @@ -56,6 +62,9 @@ public void

[jira] [Commented] (KAFKA-10357) Handle accidental deletion of repartition-topics as exceptional failure

2020-08-18 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17179535#comment-17179535 ] Bruno Cadonna commented on KAFKA-10357: --- bq. Can we leverage the committed offsets somehow? It

[jira] [Created] (KAFKA-10412) Deprecate all setters of Headers

2020-08-18 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-10412: -- Summary: Deprecate all setters of Headers Key: KAFKA-10412 URL: https://issues.apache.org/jira/browse/KAFKA-10412 Project: Kafka Issue Type: Improvement

[GitHub] [kafka] nizhikov opened a new pull request #9196: KAFKA-10402: Upgrade system tests to python3

2020-08-18 Thread GitBox
nizhikov opened a new pull request #9196: URL: https://github.com/apache/kafka/pull/9196 For now, Kafka system tests use python2 which is outdated and not supported. This PR upgrades python to the third version. ### Committer Checklist (excluded from commit message) - [ ]

[GitHub] [kafka] jeqo commented on pull request #9138: KAFKA-9929: Support backward iterator on WindowStore

2020-08-18 Thread GitBox
jeqo commented on pull request #9138: URL: https://github.com/apache/kafka/pull/9138#issuecomment-675384593 @ableegoldman, this PR is ready for review  This is an automated message from the Apache Git Service. To

[GitHub] [kafka] stanislavkozlovski commented on pull request #6669: KAFKA-8238: Adding Number of messages/bytes read

2020-08-18 Thread GitBox
stanislavkozlovski commented on pull request #6669: URL: https://github.com/apache/kafka/pull/6669#issuecomment-675358064 Yeah, that'd be awesome! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] Sasilekha commented on pull request #9195: KAFKA-10092 Remove unnecessary enum modifier in NioEchoServer

2020-08-18 Thread GitBox
Sasilekha commented on pull request #9195: URL: https://github.com/apache/kafka/pull/9195#issuecomment-675358144 Hi @ notifygd Can you please review? This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] Sasilekha opened a new pull request #9195: KAFKA-10092 Remove unnecessary enum modifier in NioEchoServer

2020-08-18 Thread GitBox
Sasilekha opened a new pull request #9195: URL: https://github.com/apache/kafka/pull/9195 In NioEchoServer the enum has its constructor declared as private, which is redundant. We can remove this. public class NioEchoServer extends Thread { public enum MetricType {

[GitHub] [kafka] chia7712 commented on pull request #9162: MINOR: refactor Log to get rid of "return" in nested anonymous function

2020-08-18 Thread GitBox
chia7712 commented on pull request #9162: URL: https://github.com/apache/kafka/pull/9162#issuecomment-67533 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

  1   2   >