[GitHub] [kafka] cadonna commented on pull request #9177: KAFKA-9924: Add RocksDB metric num-entries-active-mem-table

2020-08-20 Thread GitBox
cadonna commented on pull request #9177: URL: https://github.com/apache/kafka/pull/9177#issuecomment-678075215 test this please This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [kafka] cadonna commented on pull request #9177: KAFKA-9924: Add RocksDB metric num-entries-active-mem-table

2020-08-20 Thread GitBox
cadonna commented on pull request #9177: URL: https://github.com/apache/kafka/pull/9177#issuecomment-678074711 test this please This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [kafka] cadonna commented on pull request #9177: KAFKA-9924: Add RocksDB metric num-entries-active-mem-table

2020-08-20 Thread GitBox
cadonna commented on pull request #9177: URL: https://github.com/apache/kafka/pull/9177#issuecomment-678075020 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [kafka] cadonna commented on pull request #9191: [WIP] KAFKA-10355: PoC

2020-08-20 Thread GitBox
cadonna commented on pull request #9191: URL: https://github.com/apache/kafka/pull/9191#issuecomment-678074158 @ableegoldman Yes, you are right there were checkstyle issues. Will fix them. This is an automated message from th

[GitHub] [kafka] cadonna commented on pull request #9177: KAFKA-9924: Add RocksDB metric num-entries-active-mem-table

2020-08-20 Thread GitBox
cadonna commented on pull request #9177: URL: https://github.com/apache/kafka/pull/9177#issuecomment-678074413 Retest this, please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] cmccabe merged pull request #9199: KAFKA-10418: alter topic configs via kafka-topics error text

2020-08-20 Thread GitBox
cmccabe merged pull request #9199: URL: https://github.com/apache/kafka/pull/9199 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [kafka] cmccabe commented on pull request #9199: KAFKA-10418: alter topic configs via kafka-topics error text

2020-08-20 Thread GitBox
cmccabe commented on pull request #9199: URL: https://github.com/apache/kafka/pull/9199#issuecomment-678066207 Thanks, @rondagostino. I think it's OK to just have in trunk for now. We already did a 2.6 release and this is not a critical fix, just a help text change. But if someone

[GitHub] [kafka] cmccabe commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

2020-08-20 Thread GitBox
cmccabe commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r474416682 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/UserScramCredentialsDescription.java ## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] cmccabe commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

2020-08-20 Thread GitBox
cmccabe commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r474416243 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DescribeUserScramCredentialsResult.java ## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apac

[GitHub] [kafka] mjsax commented on a change in pull request #9156: KAFKA-10077: Filter downstream of state-store results in spurious tombstones

2020-08-20 Thread GitBox
mjsax commented on a change in pull request #9156: URL: https://github.com/apache/kafka/pull/9156#discussion_r474361586 ## File path: streams/src/test/java/org/apache/kafka/streams/StreamsBuilderTest.java ## @@ -123,7 +123,7 @@ public void shouldAllowJoinMaterializedFilteredKT

[GitHub] [kafka] mjsax commented on a change in pull request #9156: KAFKA-10077: Filter downstream of state-store results in spurious tombstones

2020-08-20 Thread GitBox
mjsax commented on a change in pull request #9156: URL: https://github.com/apache/kafka/pull/9156#discussion_r474353890 ## File path: streams/src/test/java/org/apache/kafka/streams/StreamsBuilderTest.java ## @@ -123,7 +123,7 @@ public void shouldAllowJoinMaterializedFilteredKT

[GitHub] [kafka] mjsax commented on a change in pull request #9156: KAFKA-10077: Filter downstream of state-store results in spurious tombstones

2020-08-20 Thread GitBox
mjsax commented on a change in pull request #9156: URL: https://github.com/apache/kafka/pull/9156#discussion_r474353504 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableImpl.java ## @@ -203,6 +203,10 @@ public String queryableStoreName() {

[GitHub] [kafka] mjsax commented on pull request #9156: KAFKA-10077: Filter downstream of state-store results in spurious tombstones

2020-08-20 Thread GitBox
mjsax commented on pull request #9156: URL: https://github.com/apache/kafka/pull/9156#issuecomment-677982605 > Where as previously the user could choose to 'fix' the bad semantics by manually calling enableSendingOldValues themselves, if they cared. That is not entirely correct. `ena

[jira] [Commented] (KAFKA-10362) When resuming Streams active task with EOS, the checkpoint file should be deleted

2020-08-20 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17181498#comment-17181498 ] Guozhang Wang commented on KAFKA-10362: --- Hi [~ipasynkov], sure! If you have read t

[jira] [Comment Edited] (KAFKA-9649) Remove/Warn on use of TimeWindowedSerde with no specified window size

2020-08-20 Thread Leah Thomas (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17181472#comment-17181472 ] Leah Thomas edited comment on KAFKA-9649 at 8/20/20, 10:24 PM:

[jira] [Commented] (KAFKA-9649) Remove/Warn on use of TimeWindowedSerde with no specified window size

2020-08-20 Thread Leah Thomas (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17181472#comment-17181472 ] Leah Thomas commented on KAFKA-9649: Hey Sören, I started a KIP to take care of this

[GitHub] [kafka] bbejeck commented on pull request #8955: KAFKA-10020: Create a new version of a scala Serdes without name clash (KIP-616)

2020-08-20 Thread GitBox
bbejeck commented on pull request #8955: URL: https://github.com/apache/kafka/pull/8955#issuecomment-677930002 Ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [kafka] michael-carter-instaclustr commented on pull request #8844: KAFKA-9887 fix failed task or connector count on startup failure

2020-08-20 Thread GitBox
michael-carter-instaclustr commented on pull request #8844: URL: https://github.com/apache/kafka/pull/8844#issuecomment-677909122 What do you think @kkonstantine ? Is this something you could look at? This is an automated me

[GitHub] [kafka] rondagostino commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

2020-08-20 Thread GitBox
rondagostino commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r474236159 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DescribeUserScramCredentialsResult.java ## @@ -0,0 +1,50 @@ +/* + * Licensed to the

[GitHub] [kafka] rondagostino commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

2020-08-20 Thread GitBox
rondagostino commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r474226011 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/Admin.java ## @@ -1214,6 +1215,64 @@ default AlterClientQuotasResult alterClientQuo

[GitHub] [kafka] ableegoldman commented on pull request #9191: [WIP] KAFKA-10355: PoC

2020-08-20 Thread GitBox
ableegoldman commented on pull request #9191: URL: https://github.com/apache/kafka/pull/9191#issuecomment-677852192 Tests didn't run, possible checkstyle issue? Results already cleaned up unfortunately This is an automated m

[GitHub] [kafka] ableegoldman commented on a change in pull request #9137: KAFKA-9929: Support reverse iterator on KeyValueStore

2020-08-20 Thread GitBox
ableegoldman commented on a change in pull request #9137: URL: https://github.com/apache/kafka/pull/9137#discussion_r474213204 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBPrefixIterator.java ## @@ -1,54 +0,0 @@ -/* - * Licensed to the Ap

[GitHub] [kafka] vvcephei merged pull request #9148: KAFKA-10379: Implement the KIP-478 StreamBuilder#addGlobalStore()

2020-08-20 Thread GitBox
vvcephei merged pull request #9148: URL: https://github.com/apache/kafka/pull/9148 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] vvcephei commented on pull request #9148: KAFKA-10379: Implement the KIP-478 StreamBuilder#addGlobalStore()

2020-08-20 Thread GitBox
vvcephei commented on pull request #9148: URL: https://github.com/apache/kafka/pull/9148#issuecomment-677844729 Thanks @abbccdda ! This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] guozhangwang commented on pull request #9177: KAFKA-9924: Add RocksDB metric num-entries-active-mem-table

2020-08-20 Thread GitBox
guozhangwang commented on pull request #9177: URL: https://github.com/apache/kafka/pull/9177#issuecomment-677836579 LGTM. Leaving to @vvcephei for final review and merge. I think it is okay to not bookkeep the thread id and always rely on currentThread() assuming only one thread woul

[jira] [Commented] (KAFKA-10380) Make dist flatten rocksdbjni

2020-08-20 Thread Ewen Cheslack-Postava (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17181366#comment-17181366 ] Ewen Cheslack-Postava commented on KAFKA-10380: --- Probably the best solutio

[GitHub] [kafka] hachikuji commented on pull request #9112: KAFKA-10312 Fix error code returned by getPartitionMetadata

2020-08-20 Thread GitBox
hachikuji commented on pull request #9112: URL: https://github.com/apache/kafka/pull/9112#issuecomment-677786670 retest this please This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

2020-08-20 Thread GitBox
mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r474106591 ## File path: core/src/main/scala/kafka/server/AlterIsrChannelManager.scala ## @@ -0,0 +1,132 @@ +package kafka.server + +import java.util +import java.util.

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

2020-08-20 Thread GitBox
mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r474106591 ## File path: core/src/main/scala/kafka/server/AlterIsrChannelManager.scala ## @@ -0,0 +1,132 @@ +package kafka.server + +import java.util +import java.util.

[jira] [Updated] (KAFKA-9893) Configurable TCP connection timeout and improve the initial metadata fetch

2020-08-20 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck updated KAFKA-9893: --- Fix Version/s: 2.7.0 > Configurable TCP connection timeout and improve the initial metadata fetch > -

[jira] [Updated] (KAFKA-9893) Configurable TCP connection timeout and improve the initial metadata fetch

2020-08-20 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck updated KAFKA-9893: --- Component/s: core > Configurable TCP connection timeout and improve the initial metadata fetch >

[jira] [Updated] (KAFKA-9893) Configurable TCP connection timeout and improve the initial metadata fetch

2020-08-20 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck updated KAFKA-9893: --- Affects Version/s: 2.7.0 > Configurable TCP connection timeout and improve the initial metadata fetch

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

2020-08-20 Thread GitBox
mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r474070847 ## File path: core/src/main/scala/kafka/server/AlterIsrChannelManager.scala ## @@ -0,0 +1,132 @@ +package kafka.server + +import java.util +import java.util.

[jira] [Resolved] (KAFKA-9852) Lower block duration in BufferPoolTest to cut down on overall test runtime

2020-08-20 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-9852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sönke Liebau resolved KAFKA-9852. - Fix Version/s: 2.6.0 Resolution: Fixed > Lower block duration in BufferPoolTest to cut dow

[GitHub] [kafka] tomjiang1987 closed pull request #953: In daemon mode,redirect stdout to /dev/null

2020-08-20 Thread GitBox
tomjiang1987 closed pull request #953: URL: https://github.com/apache/kafka/pull/953 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] soenkeliebau commented on pull request #8399: KAFKA-3720: Change TimeoutException to BufferExhaustedException when no memory can be allocated for a record within max.block.ms

2020-08-20 Thread GitBox
soenkeliebau commented on pull request #8399: URL: https://github.com/apache/kafka/pull/8399#issuecomment-677744802 @ijuma apologies for the delayed response I did indeed open that [pull request ](https://github.com/apache/kafka/pull/8464) and an accompanying [issue](https://issues.

[GitHub] [kafka] bbejeck commented on pull request #9099: KAFKA-6733: Printing additional ConsumerRecord fields in DefaultMessageFormatter

2020-08-20 Thread GitBox
bbejeck commented on pull request #9099: URL: https://github.com/apache/kafka/pull/9099#issuecomment-677743288 Ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

2020-08-20 Thread GitBox
mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r474070847 ## File path: core/src/main/scala/kafka/server/AlterIsrChannelManager.scala ## @@ -0,0 +1,132 @@ +package kafka.server + +import java.util +import java.util.

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

2020-08-20 Thread GitBox
mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r474070847 ## File path: core/src/main/scala/kafka/server/AlterIsrChannelManager.scala ## @@ -0,0 +1,132 @@ +package kafka.server + +import java.util +import java.util.

[GitHub] [kafka] iprithv edited a comment on pull request #9204: KAFKA-6181 Examining log messages with {{--deep-iteration}} should show superset of fields

2020-08-20 Thread GitBox
iprithv edited a comment on pull request #9204: URL: https://github.com/apache/kafka/pull/9204#issuecomment-677733815 please review this @mjsax Thanks This is an automated message from the Apache Git Service. To respond to th

[GitHub] [kafka] iprithv commented on pull request #9204: KAFKA-6181 Examining log messages with {{--deep-iteration}} should show superset of fields

2020-08-20 Thread GitBox
iprithv commented on pull request #9204: URL: https://github.com/apache/kafka/pull/9204#issuecomment-677733815 please review this @mjsax This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [kafka] iprithv opened a new pull request #9204: KAFKA-6181 Examining log messages with {{--deep-iteration}} should show superset of fields

2020-08-20 Thread GitBox
iprithv opened a new pull request #9204: URL: https://github.com/apache/kafka/pull/9204 adding missing fields for --deep-iteration log messages. Missing fields include : partitionLeaderEpoch, baseSequence, lastSequence, etc.,

[GitHub] [kafka] omkreddy merged pull request #9203: MINOR: Fix typo in LeaderEpochFileCacheTest

2020-08-20 Thread GitBox
omkreddy merged pull request #9203: URL: https://github.com/apache/kafka/pull/9203 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Commented] (KAFKA-10362) When resuming Streams active task with EOS, the checkpoint file should be deleted

2020-08-20 Thread Ilia Pasynkov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17181231#comment-17181231 ] Ilia Pasynkov commented on KAFKA-10362: --- Hello, can I pick this task? > When resu

[jira] [Commented] (KAFKA-10422) Provide a `timesForOffsets` operation in kafka consumer

2020-08-20 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17181228#comment-17181228 ] Mickael Maison commented on KAFKA-10422: Yes, adding a new method to KafkaConsum

[GitHub] [kafka] dongjinleekr commented on pull request #9189: KAFKA-10407: Have KafkaLog4jAppender support `linger.ms` and `batch.size`

2020-08-20 Thread GitBox
dongjinleekr commented on pull request #9189: URL: https://github.com/apache/kafka/pull/9189#issuecomment-677677152 Congratulations, @huxihx! :smile: If you have some time, please have a look at the related issue: https://github.com/apache/kafka/pull/7898 cc/ @omkreddy -

[GitHub] [kafka] rondagostino commented on pull request #9199: KAFKA-10418: alter topic configs via kafka-topics error text

2020-08-20 Thread GitBox
rondagostino commented on pull request #9199: URL: https://github.com/apache/kafka/pull/9199#issuecomment-677671036 Actually, it turns out that the ability to use `kafka-configs --bootstrap-server` was only added in 2.5. So this could be backported to 2.5 and 2.6 (not all the way back to

[jira] [Commented] (KAFKA-8052) Intermittent INVALID_FETCH_SESSION_EPOCH error on FETCH request

2020-08-20 Thread Akshay Sharma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17181079#comment-17181079 ] Akshay Sharma commented on KAFKA-8052: -- [~rsivaram], Hi i'm seeing this issue in 2.3

[jira] [Updated] (KAFKA-10423) Logtash is restarting with invalid_fetch_session_epoch error

2020-08-20 Thread Akshay Sharma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akshay Sharma updated KAFKA-10423: -- Description: Logstash(input plugin is kafka) is restarting again and again with error as ment

[jira] [Updated] (KAFKA-10423) Logtash is restarting with invalid_fetch_session_epoch error

2020-08-20 Thread Akshay Sharma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akshay Sharma updated KAFKA-10423: -- Description: Logstash(input plugin is kafka) is restarting again and again with error as ment

[jira] [Created] (KAFKA-10423) Logtash is restarting with invalid_fetch_session_epoch error

2020-08-20 Thread Akshay Sharma (Jira)
Akshay Sharma created KAFKA-10423: - Summary: Logtash is restarting with invalid_fetch_session_epoch error Key: KAFKA-10423 URL: https://issues.apache.org/jira/browse/KAFKA-10423 Project: Kafka

[jira] [Created] (KAFKA-10422) Provide a `timesForOffsets` operation in kafka consumer

2020-08-20 Thread Guillaume Bort (Jira)
Guillaume Bort created KAFKA-10422: -- Summary: Provide a `timesForOffsets` operation in kafka consumer Key: KAFKA-10422 URL: https://issues.apache.org/jira/browse/KAFKA-10422 Project: Kafka I

[GitHub] [kafka] jeqo commented on pull request #9137: KAFKA-9929: Support reverse iterator on KeyValueStore

2020-08-20 Thread GitBox
jeqo commented on pull request #9137: URL: https://github.com/apache/kafka/pull/9137#issuecomment-677489429 @vvcephei thanks for your feedback! Inverting flag actually make things more readable. Changing to `forward` and `if (forward) {} else {}`. -

[GitHub] [kafka] mimaison commented on pull request #9136: KAFKA-10211: Add DirectoryConfigProvider

2020-08-20 Thread GitBox
mimaison commented on pull request #9136: URL: https://github.com/apache/kafka/pull/9136#issuecomment-677487738 @tombentley The change looks good to me but there's a checkstyle issue: ``` [ant:checkstyle] [ERROR] /Users/mickael/github-ws/kafka/clients/src/test/java/org/apache/kafka/co

[jira] [Comment Edited] (KAFKA-10134) High CPU issue during rebalance in Kafka consumer after upgrading to 2.5

2020-08-20 Thread Jerry Wei (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17180919#comment-17180919 ] Jerry Wei edited comment on KAFKA-10134 at 8/20/20, 8:53 AM: -

[jira] [Updated] (KAFKA-10134) High CPU issue during rebalance in Kafka consumer after upgrading to 2.5

2020-08-20 Thread Jerry Wei (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jerry Wei updated KAFKA-10134: -- Attachment: consumer3.log.2020-08-20.log > High CPU issue during rebalance in Kafka consumer after upg

[GitHub] [kafka] huxihx commented on pull request #9203: MINOR: Fix typo in LeaderEpochFileCacheTest

2020-08-20 Thread GitBox
huxihx commented on pull request #9203: URL: https://github.com/apache/kafka/pull/9203#issuecomment-677386992 @abbccdda Please review this minor patch. Thanks. This is an automated message from the Apache Git Service. To resp