cmccabe commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r479554911
##
File path:
core/src/test/scala/integration/kafka/api/EndToEndAuthorizationTest.scala
##
@@ -545,6 +558,16 @@ abstract class EndToEndAuthorizationTest ex
cmccabe commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r479554324
##
File path:
core/src/test/scala/integration/kafka/api/SaslClientsWithInvalidCredentialsTest.scala
##
@@ -248,4 +250,25 @@ class SaslClientsWithInvalidCre
cmccabe commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r479553827
##
File path:
core/src/test/scala/integration/kafka/api/SaslScramSslEndToEndAuthorizationTest.scala
##
@@ -42,7 +42,18 @@ class SaslScramSslEndToEndAuthori
cmccabe commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r479552810
##
File path:
core/src/test/scala/integration/kafka/server/DynamicBrokerReconfigurationTest.scala
##
@@ -1047,8 +1047,8 @@ class DynamicBrokerReconfigurati
cmccabe commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r479551061
##
File path:
core/src/test/scala/unit/kafka/admin/UserScramCredentialsCommandTest.scala
##
@@ -0,0 +1,135 @@
+/**
+ * Licensed to the Apache Software Foun
cmccabe commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r479548642
##
File path: core/src/test/scala/unit/kafka/server/ClientQuotasRequestTest.scala
##
@@ -166,14 +168,11 @@ class ClientQuotasRequestTest extends BaseRequest
cmccabe commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r479548121
##
File path: core/src/test/scala/unit/kafka/server/ClientQuotasRequestTest.scala
##
@@ -17,6 +17,8 @@
package kafka.server
+import java.util
Review c
cmccabe commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r479546505
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/DescribeUserScramCredentialsResult.java
##
@@ -0,0 +1,145 @@
+/*
+ * Licensed to the Apa
cmccabe commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r479546505
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/DescribeUserScramCredentialsResult.java
##
@@ -0,0 +1,145 @@
+/*
+ * Licensed to the Apa
cmccabe commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r479545936
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/DescribeUserScramCredentialsResult.java
##
@@ -0,0 +1,145 @@
+/*
+ * Licensed to the Apa
dielhennr edited a comment on pull request #9101:
URL: https://github.com/apache/kafka/pull/9101#issuecomment-683076305
Hi @jsancio I hope you're doing well. I added some work in progress to this
branch that includes new APIs and basic functionality for this feature using
the new APIs. Fit
ijuma commented on pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#issuecomment-683075891
This looks promising. One question, do we want every request to drain this
ReplicaManager queue or only the callers of `appendRecords`? I think this
answer affects the design a bit.
dielhennr commented on pull request #9101:
URL: https://github.com/apache/kafka/pull/9101#issuecomment-683076305
Hi @jsancio I hope you're doing well. I added some work in progress to this
branch that includes new APIs and basic functionality for this feature using
the APIs. Fitting user a
dielhennr closed pull request #9101:
URL: https://github.com/apache/kafka/pull/9101
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
ijuma commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r479475681
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -184,6 +184,7 @@ class KafkaApis(val requestChannel: RequestChannel,
case e: Fatal
ijuma commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r479474904
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -100,7 +102,8 @@ case class LogAppendInfo(var firstOffset: Option[Long],
junrao commented on pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#issuecomment-683052000
@ijuma @hachikuji @rajinisivaram : Do you want to take another look at the
latest solution from Chia-Ping? It (1) solves the known issues completely; (2)
doesn't require new thread
junrao commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r479467548
##
File path: core/src/main/scala/kafka/server/DelayedOperation.scala
##
@@ -100,41 +99,21 @@ abstract class DelayedOperation(override val delayMs: Long,
[
https://issues.apache.org/jira/browse/KAFKA-10445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-10445:
Labels: beginner needs-kip newbie (was: needs-kip)
> Align IQ SessionStore API with Insta
[
https://issues.apache.org/jira/browse/KAFKA-10445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-10445:
Labels: needs-kip (was: )
> Align IQ SessionStore API with Instant-based methods as ReadO
Jorge Esteban Quilcate Otoya created KAFKA-10445:
Summary: Align IQ SessionStore API with Instant-based methods as
ReadOnlyWindowStore
Key: KAFKA-10445
URL: https://issues.apache.org/jira/browse/KA
[
https://issues.apache.org/jira/browse/KAFKA-10434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jorge Esteban Quilcate Otoya updated KAFKA-10434:
-
Labels: kip-required (was: )
> Remove deprecated methods on Win
ijuma commented on pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#issuecomment-682991870
@chia7712 See KAFKA-10444 with regards to Jenkins.
This is an automated message from the Apache Git Service.
To resp
[
https://issues.apache.org/jira/browse/KAFKA-10444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma reassigned KAFKA-10444:
---
Assignee: David Arthur
> Migrate PR jobs to new Apache Infra Jenkins
>
Ismael Juma created KAFKA-10444:
---
Summary: Migrate PR jobs to new Apache Infra Jenkins
Key: KAFKA-10444
URL: https://issues.apache.org/jira/browse/KAFKA-10444
Project: Kafka
Issue Type: Task
chia7712 commented on pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#issuecomment-682879578
@junrao Thanks for all suggestions!
Is Jenkins on vacation? Could you trigger a system test?
This is an au
lct45 commented on a change in pull request #9157:
URL: https://github.com/apache/kafka/pull/9157#discussion_r479411830
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java
##
@@ -160,11 +160,18 @@ public void proces
junrao commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r479383807
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -85,6 +85,8 @@ object LogAppendInfo {
* @param validBytes The number of valid bytes
* @param
lct45 commented on a change in pull request #9039:
URL: https://github.com/apache/kafka/pull/9039#discussion_r479362665
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java
##
@@ -0,0 +1,303 @@
+/*
+ * Licensed to th
vvcephei commented on a change in pull request #8955:
URL: https://github.com/apache/kafka/pull/8955#discussion_r479356312
##
File path:
streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/serialization/Serdes.scala
##
@@ -0,0 +1,93 @@
+/*
+ * Copyright (C) 201
vvcephei commented on a change in pull request #9039:
URL: https://github.com/apache/kafka/pull/9039#discussion_r479344784
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java
##
@@ -0,0 +1,303 @@
+/*
+ * Licensed to
[
https://issues.apache.org/jira/browse/KAFKA-10307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17186569#comment-17186569
]
John Roesler edited comment on KAFKA-10307 at 8/28/20, 2:28 PM:
--
[
https://issues.apache.org/jira/browse/KAFKA-10307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler resolved KAFKA-10307.
--
Resolution: Not A Bug
This bug report was based on an invalid assumption that topologies would
[
https://issues.apache.org/jira/browse/KAFKA-10307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17186568#comment-17186568
]
John Roesler commented on KAFKA-10307:
--
Hey [~feyman] ,
It sounds like you're sayi
khaireddine120 commented on pull request #9207:
URL: https://github.com/apache/kafka/pull/9207#issuecomment-682442638
Hi @bbejeck
Thanks for the approval
Why the check is taking so long ?
This is an automated message f
[
https://issues.apache.org/jira/browse/KAFKA-7421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17185891#comment-17185891
]
Goltseva Taisiia edited comment on KAFKA-7421 at 8/28/20, 8:16 AM:
[
https://issues.apache.org/jira/browse/KAFKA-10375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17186348#comment-17186348
]
Satyawati Tripathi commented on KAFKA-10375:
Hey , can i take this up?
> Re
37 matches
Mail list logo
