chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r484209068
##
File path:
core/src/test/scala/unit/kafka/coordinator/AbstractCoordinatorConcurrencyTest.scala
##
@@ -201,8 +201,8 @@ object AbstractCoordinatorConcurr
junrao commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r484181930
##
File path:
core/src/test/scala/unit/kafka/coordinator/AbstractCoordinatorConcurrencyTest.scala
##
@@ -201,8 +201,8 @@ object AbstractCoordinatorConcurren
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r484164627
##
File path: core/src/main/scala/kafka/cluster/Partition.scala
##
@@ -1010,15 +1010,7 @@ class Partition(val topicPartition: TopicPartition,
}
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r484163863
##
File path: core/src/main/scala/kafka/server/DelayedOperation.scala
##
@@ -231,26 +214,27 @@ final class DelayedOperationPurgatory[T <:
DelayedOperation
[
https://issues.apache.org/jira/browse/KAFKA-9795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17191396#comment-17191396
]
Igor Vavrzhin commented on KAFKA-9795:
--
Why not? :)
> Add throttleTimeMs in logs
>
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r484138649
##
File path:
core/src/test/scala/unit/kafka/coordinator/AbstractCoordinatorConcurrencyTest.scala
##
@@ -201,8 +201,8 @@ object AbstractCoordinatorConcurr
junrao commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r484101769
##
File path: core/src/main/scala/kafka/server/DelayedOperation.scala
##
@@ -231,26 +214,27 @@ final class DelayedOperationPurgatory[T <:
DelayedOperation](
junrao commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r484101535
##
File path: core/src/main/scala/kafka/server/DelayedOperation.scala
##
@@ -231,26 +214,27 @@ final class DelayedOperationPurgatory[T <:
DelayedOperation](
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r484099709
##
File path: core/src/main/scala/kafka/server/DelayedOperation.scala
##
@@ -231,26 +214,27 @@ final class DelayedOperationPurgatory[T <:
DelayedOperation
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r484097948
##
File path:
core/src/test/scala/unit/kafka/coordinator/AbstractCoordinatorConcurrencyTest.scala
##
@@ -201,8 +201,8 @@ object AbstractCoordinatorConcurr
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r484097601
##
File path: core/src/main/scala/kafka/server/DelayedOperation.scala
##
@@ -231,26 +214,27 @@ final class DelayedOperationPurgatory[T <:
DelayedOperation
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r484097161
##
File path: core/src/main/scala/kafka/server/DelayedOperation.scala
##
@@ -231,26 +214,27 @@ final class DelayedOperationPurgatory[T <:
DelayedOperation
ableegoldman commented on a change in pull request #9157:
URL: https://github.com/apache/kafka/pull/9157#discussion_r484094512
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java
##
@@ -192,29 +213,125 @@ public voi
junrao commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r484090694
##
File path: core/src/main/scala/kafka/server/DelayedOperation.scala
##
@@ -231,26 +214,27 @@ final class DelayedOperationPurgatory[T <:
DelayedOperation](
jonhkr commented on pull request #9256:
URL: https://github.com/apache/kafka/pull/9256#issuecomment-687807680
Hey @omkreddy @ijuma, would you mind taking a look into this?
This is an automated message from the Apache Git Serv
jonhkr commented on pull request #9256:
URL: https://github.com/apache/kafka/pull/9256#issuecomment-687805835
The generated poms changed a bit.
- Dependencies in the `compile` scope were moved to `runtime`.
- Some dependencies were introduced (the ones that were previously exported
b
DOJI45 commented on pull request #9247:
URL: https://github.com/apache/kafka/pull/9247#issuecomment-687791255
@guozhangwang request you to please review PR
This is an automated message from the Apache Git Service.
To respond
vgvineet4 commented on pull request #9254:
URL: https://github.com/apache/kafka/pull/9254#issuecomment-687743208
@omkreddy Please have a look
This is an automated message from the Apache Git Service.
To respond to the message
chia7712 commented on pull request #8978:
URL: https://github.com/apache/kafka/pull/8978#issuecomment-687725573
@kkonstantine Could you please take a look?
This is an automated message from the Apache Git Service.
To respond
chia7712 commented on pull request #9182:
URL: https://github.com/apache/kafka/pull/9182#issuecomment-687725363
```
Build / JDK 11 /
org.apache.kafka.streams.integration.KStreamAggregationIntegrationTest.shouldAggregateSlidingWindows
Build / JDK 11 /
org.apache.kafka.streams.integrat
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r484039528
##
File path:
core/src/test/scala/unit/kafka/coordinator/AbstractCoordinatorConcurrencyTest.scala
##
@@ -201,8 +201,8 @@ object AbstractCoordinatorConcurr
brary commented on a change in pull request #9255:
URL: https://github.com/apache/kafka/pull/9255#discussion_r484034329
##
File path: clients/src/main/java/org/apache/kafka/common/utils/Utils.java
##
@@ -1271,4 +1274,35 @@ private static byte checkRange(final byte i) {
manijndl7 commented on pull request #9255:
URL: https://github.com/apache/kafka/pull/9255#issuecomment-687713711
Thanks @brary for Review i have done the changes can you please verify once
if things are good.
This is an auto
23 matches
Mail list logo
