kowshik commented on pull request #9456:
URL: https://github.com/apache/kafka/pull/9456#issuecomment-712612456
The test failure in JDK 8 is unrelated to this PR:
`org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta`.
chia7712 merged pull request #9452:
URL: https://github.com/apache/kafka/pull/9452
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
chia7712 commented on pull request #9452:
URL: https://github.com/apache/kafka/pull/9452#issuecomment-712612177
@jackyoh Thanks for this contribution. merge to trunk
This is an automated message from the Apache Git Service.
chia7712 commented on pull request #9452:
URL: https://github.com/apache/kafka/pull/9452#issuecomment-712611316
```
org.apache.kafka.streams.processor.internals.StateDirectoryTest.shouldCleanupObsoleteStateDirectoriesOnlyOnce
```
it is flaky and related to
[
https://issues.apache.org/jira/browse/KAFKA-10616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17217271#comment-17217271
]
Sagar Rao commented on KAFKA-10616:
---
Alright thanks [~ableegoldman], Let me know if we would need a
[
https://issues.apache.org/jira/browse/KAFKA-10616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17217261#comment-17217261
]
A. Sophie Blee-Goldman commented on KAFKA-10616:
By the way, we should actually fix this
chia7712 commented on pull request #9373:
URL: https://github.com/apache/kafka/pull/9373#issuecomment-712582389
@mikebin Thanks for this patch.
I noticed test ```shouldCleanupObsoleteStateDirectoriesOnlyOnce``` is flaky
and the root cause may be similar to
[
https://issues.apache.org/jira/browse/KAFKA-10616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17217258#comment-17217258
]
A. Sophie Blee-Goldman commented on KAFKA-10616:
I spoke with [~guozhang] earlier and
[
https://issues.apache.org/jira/browse/KAFKA-10616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman reassigned KAFKA-10616:
--
Assignee: Guozhang Wang
> StreamThread killed by
chia7712 commented on pull request #8489:
URL: https://github.com/apache/kafka/pull/8489#issuecomment-712563168
there is an existent bug after updating base image from openjdk:8 to
openjdk:11 (see https://github.com/apache/kafka/pull/9324). feel free to merge
the fix to your PR :)
ableegoldman commented on a change in pull request #9446:
URL: https://github.com/apache/kafka/pull/9446#discussion_r508185204
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignorTest.java
##
@@ -1899,14 +1973,18 @@ public
jackyoh commented on pull request #9452:
URL: https://github.com/apache/kafka/pull/9452#issuecomment-712562825
> @jackyoh Could you rebase PR to trigger QA?
OK, I am going to rebase PR. Thank you!
This is an automated
ableegoldman commented on a change in pull request #9446:
URL: https://github.com/apache/kafka/pull/9446#discussion_r508182677
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java
##
@@ -409,9 +396,18 @@ public
chia7712 commented on pull request #8870:
URL: https://github.com/apache/kafka/pull/8870#issuecomment-712558055
@ocadaruma Could you rebase it again? Our Jenkins was on vacation :(
This is an automated message from the
ableegoldman commented on a change in pull request #9446:
URL: https://github.com/apache/kafka/pull/9446#discussion_r508179485
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java
##
@@ -409,9 +396,18 @@ public
chia7712 commented on pull request #8794:
URL: https://github.com/apache/kafka/pull/8794#issuecomment-712557078
@afalko Could you rebase PR to trigger QA?
This is an automated message from the Apache Git Service.
To respond
chia7712 commented on pull request #5645:
URL: https://github.com/apache/kafka/pull/5645#issuecomment-712556570
@hasegeli Could you rebase it again? It seems our Jenkins was on vacation :(
This is an automated message from
chia7712 commented on pull request #9452:
URL: https://github.com/apache/kafka/pull/9452#issuecomment-712556303
@jackyoh Could you rebase PR to trigger QA?
This is an automated message from the Apache Git Service.
To respond
chia7712 commented on pull request #9452:
URL: https://github.com/apache/kafka/pull/9452#issuecomment-712555936
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
chia7712 merged pull request #9392:
URL: https://github.com/apache/kafka/pull/9392
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
chia7712 commented on pull request #9392:
URL: https://github.com/apache/kafka/pull/9392#issuecomment-712555155
@dajac Thanks for reviews. Merge it to trunk
This is an automated message from the Apache Git Service.
To
kowshik commented on pull request #9455:
URL: https://github.com/apache/kafka/pull/9455#issuecomment-712553960
@junrao Good idea. I've done a rebase now on top of latest `2.7` branch.
This is an automated message from the
[
https://issues.apache.org/jira/browse/KAFKA-10616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17217208#comment-17217208
]
Sagar Rao commented on KAFKA-10616:
---
hey [~ableegoldman], Can I take this one up?
> StreamThread
vvcephei commented on pull request #9338:
URL: https://github.com/apache/kafka/pull/9338#issuecomment-712471965
Thanks, @thake ! Sorry to disturb your vacation.
Please let me know if you want me to finish up this PR for you. If it helps,
I could incorporate your responses to my PR,
thake commented on pull request #9338:
URL: https://github.com/apache/kafka/pull/9338#issuecomment-712458128
Sorry for not giving any timely response. I'm currently on vacation but I
will do my best to update the PR tomorrow.
junrao commented on pull request #9455:
URL: https://github.com/apache/kafka/pull/9455#issuecomment-712449632
@kowshik : Maybe you can rebase this PR to trigger another test.
This is an automated message from the Apache Git
junrao commented on pull request #9455:
URL: https://github.com/apache/kafka/pull/9455#issuecomment-712445751
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
junrao commented on pull request #9455:
URL: https://github.com/apache/kafka/pull/9455#issuecomment-712445437
test this please
This is an automated message from the Apache Git Service.
To respond to the message, please log
junrao commented on pull request #9455:
URL: https://github.com/apache/kafka/pull/9455#issuecomment-712445006
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please log
junrao commented on pull request #9455:
URL: https://github.com/apache/kafka/pull/9455#issuecomment-712444921
This is probably due to https://github.com/apache/kafka/pull/9453. Just
merged that PR to 2.7.
This is an
junrao commented on pull request #9453:
URL: https://github.com/apache/kafka/pull/9453#issuecomment-712444727
@ijuma : Thanks for the PR. Merged to 2.7 branch too.
This is an automated message from the Apache Git Service.
To
kowshik commented on pull request #9455:
URL: https://github.com/apache/kafka/pull/9455#issuecomment-712436386
@abbccdda I'm not sure whats going on, there is a maven error in the CI run.
Would you be able to please trigger a retest ?
kowshik edited a comment on pull request #9455:
URL: https://github.com/apache/kafka/pull/9455#issuecomment-712404756
cc @abbccdda @junrao: This cherry-pick PR is ready for review.
This is an automated message from the
[
https://issues.apache.org/jira/browse/KAFKA-10605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler resolved KAFKA-10605.
--
Resolution: Fixed
> KIP-478: deprecate the replaced Processor API members
>
vvcephei commented on pull request #9448:
URL: https://github.com/apache/kafka/pull/9448#issuecomment-712430562
Cherry-picked to 2.7. Thanks!
This is an automated message from the Apache Git Service.
To respond to the
vvcephei merged pull request #9448:
URL: https://github.com/apache/kafka/pull/9448
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Cheng Tan created KAFKA-10619:
-
Summary: Producer will enable EOS by default
Key: KAFKA-10619
URL: https://issues.apache.org/jira/browse/KAFKA-10619
Project: Kafka
Issue Type: Improvement
abbccdda commented on pull request #9455:
URL: https://github.com/apache/kafka/pull/9455#issuecomment-712416257
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
kowshik commented on pull request #9456:
URL: https://github.com/apache/kafka/pull/9456#issuecomment-712414966
cc @abbccdda @junrao: This cherry-pick PR is ready for review.
This is an automated message from the Apache Git
kowshik edited a comment on pull request #9455:
URL: https://github.com/apache/kafka/pull/9455#issuecomment-712404756
cc @abbccdda @junrao : : This cherry-pick PR is ready for review.
This is an automated message from the
kowshik opened a new pull request #9456:
URL: https://github.com/apache/kafka/pull/9456
[KIP-584]: Cherry pick PR #9436 into AK 2.7 release branch. This PR improves
the code a bit to take care of a minor case.
This is an
vvcephei commented on a change in pull request #9446:
URL: https://github.com/apache/kafka/pull/9446#discussion_r508030073
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java
##
@@ -409,9 +396,18 @@ public
vvcephei commented on pull request #9338:
URL: https://github.com/apache/kafka/pull/9338#issuecomment-712406549
Hello @thake ,
I don't mean to bother you, but just wanted to check if you're able to
follow up on the last round of review. We have until Wednesday to make the
2.7.0
kowshik commented on pull request #9455:
URL: https://github.com/apache/kafka/pull/9455#issuecomment-712404756
cc @abbccdda @junrao
This is an automated message from the Apache Git Service.
To respond to the message, please
kowshik opened a new pull request #9455:
URL: https://github.com/apache/kafka/pull/9455
[KIP-584]: Cherry pick PR #9409 implementing a basic CLI tool for feature
versioning system, into AK 2.7 release branch.
This is an
vvcephei commented on pull request #9383:
URL: https://github.com/apache/kafka/pull/9383#issuecomment-712403417
Cherry-picked to 2.6
This is an automated message from the Apache Git Service.
To respond to the message, please
[
https://issues.apache.org/jira/browse/KAFKA-10455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler resolved KAFKA-10455.
--
Resolution: Fixed
> Probing rebalances are not guaranteed to be triggered by non-leader
dajac merged pull request #9447:
URL: https://github.com/apache/kafka/pull/9447
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
vvcephei commented on pull request #9383:
URL: https://github.com/apache/kafka/pull/9383#issuecomment-712380123
Cherry-picked to 2.7 (cc @bbejeck )
This is an automated message from the Apache Git Service.
To respond to the
rhauch commented on pull request #9429:
URL: https://github.com/apache/kafka/pull/9429#issuecomment-712368155
Rebased to get recent changes to fix the PR builds. Previous build was green
prior to my minor indentation changes, but I'll give this build a chance before
merging.
vvcephei commented on pull request #9383:
URL: https://github.com/apache/kafka/pull/9383#issuecomment-712362984
Thanks for the PR, @lct45 !
This is an automated message from the Apache Git Service.
To respond to the message,
vvcephei merged pull request #9383:
URL: https://github.com/apache/kafka/pull/9383
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
mjsax merged pull request #9368:
URL: https://github.com/apache/kafka/pull/9368
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/KAFKA-10405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17216991#comment-17216991
]
Matthias J. Sax commented on KAFKA-10405:
-
jolshan opened a new pull request #9454:
URL: https://github.com/apache/kafka/pull/9454
In order to support topic IDs, we need to create a public UUID class. This
class will be used in protocols. This PR creates the class, modifies code to
use the class in the message protocol and changes
xvrl commented on pull request #9429:
URL: https://github.com/apache/kafka/pull/9429#issuecomment-712340666
thanks for fixing the formatting @rhauch, feel free to merge
This is an automated message from the Apache Git
[
https://issues.apache.org/jira/browse/KAFKA-3042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17216963#comment-17216963
]
Jun Rao commented on KAFKA-3042:
[~manme...@gmail.com]: Thanks for the update. It would be useful to get
guozhangwang commented on pull request #8988:
URL: https://github.com/apache/kafka/pull/8988#issuecomment-712320235
System tests succeeded:
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4232/
Will deploy soak for a few days.
[
https://issues.apache.org/jira/browse/KAFKA-10332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Randall Hauch resolved KAFKA-10332.
---
Fix Version/s: 2.6.1
2.5.2
2.7.0
Reviewer:
tom1299 closed pull request #9135:
URL: https://github.com/apache/kafka/pull/9135
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
rajinisivaram merged pull request #9453:
URL: https://github.com/apache/kafka/pull/9453
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
rajinisivaram commented on pull request #9453:
URL: https://github.com/apache/kafka/pull/9453#issuecomment-712297603
Test failures not related, merging to trunk.
This is an automated message from the Apache Git Service.
To
Justine Olshan created KAFKA-10618:
--
Summary: Add UUID class, use in protocols
Key: KAFKA-10618
URL: https://issues.apache.org/jira/browse/KAFKA-10618
Project: Kafka
Issue Type: Sub-task
junrao merged pull request #9409:
URL: https://github.com/apache/kafka/pull/9409
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
efeg commented on pull request #9397:
URL: https://github.com/apache/kafka/pull/9397#issuecomment-712272753
> @efeg do you want to have a go at writing a more thorough class Javadoc
for Admin? If not I'll try to write something.
@tombentley Thanks for your help with this PR!
rhauch merged pull request #9343:
URL: https://github.com/apache/kafka/pull/9343
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
chia7712 commented on a change in pull request #9449:
URL: https://github.com/apache/kafka/pull/9449#discussion_r507852448
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##
@@ -3938,25 +3938,15 @@ private Call
rhauch commented on a change in pull request #9429:
URL: https://github.com/apache/kafka/pull/9429#discussion_r507840010
##
File path:
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorConnectorConfig.java
##
@@ -436,29 +444,47 @@ Duration
[
https://issues.apache.org/jira/browse/KAFKA-8370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17216797#comment-17216797
]
Randall Hauch commented on KAFKA-8370:
--
Verified that when setting
ijuma opened a new pull request #9453:
URL: https://github.com/apache/kafka/pull/9453
They were renamed in Apache Jenkins.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ]
cadonna commented on a change in pull request #9446:
URL: https://github.com/apache/kafka/pull/9446#discussion_r507730030
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java
##
@@ -409,9 +396,18 @@ public
dongjinleekr commented on pull request #9421:
URL: https://github.com/apache/kafka/pull/9421#issuecomment-712109230
@chia7712 Great. I will separate the other commits into independent PR to
make the commit clear. Stay tuned! :smile:
dajac commented on a change in pull request #9449:
URL: https://github.com/apache/kafka/pull/9449#discussion_r507630062
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##
@@ -3938,25 +3938,15 @@ private Call
tombentley commented on pull request #9397:
URL: https://github.com/apache/kafka/pull/9397#issuecomment-711858164
@efeg do you want to have a go at writing a more thorough class Javadoc for
`Admin`? If not I'll try to write something.
rajinisivaram commented on pull request #9450:
URL: https://github.com/apache/kafka/pull/9450#issuecomment-711831448
@omkreddy @chia7712 Thanks for the reviews. We don't currently return custom
error messages for metadata exceptions. But I guess there is no harm in
including
[
https://issues.apache.org/jira/browse/KAFKA-7094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17216521#comment-17216521
]
Shadi commented on KAFKA-7094:
--
[~wangzzu] This seems to have been fixed, can we close this ticket?
>
[
https://issues.apache.org/jira/browse/KAFKA-10583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-10583.
Resolution: Fixed
> Thread-safety of AdminClient is not documented
>
chia7712 commented on pull request #9397:
URL: https://github.com/apache/kafka/pull/9397#issuecomment-711789924
@efeg Thanks for the patch! merge it to trunk
This is an automated message from the Apache Git Service.
To
chia7712 merged pull request #9397:
URL: https://github.com/apache/kafka/pull/9397
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
[
https://issues.apache.org/jira/browse/KAFKA-10583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-10583:
---
Fix Version/s: 2.8.0
> Thread-safety of AdminClient is not documented
>
[
https://issues.apache.org/jira/browse/KAFKA-10499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dongjin Lee resolved KAFKA-10499.
-
Resolution: Fixed
Resolved with commit {{1443f24}} (see:
dajac commented on a change in pull request #9417:
URL: https://github.com/apache/kafka/pull/9417#discussion_r507536956
##
File path:
core/src/test/scala/unit/kafka/server/ControllerMutationQuotaTest.scala
##
@@ -381,16 +381,18 @@ class ControllerMutationQuotaTest extends
tombentley commented on pull request #9397:
URL: https://github.com/apache/kafka/pull/9397#issuecomment-711779114
@chia7712 `Tom Bentley ` is what's used in my commits.
This is an automated message from the Apache Git
chia7712 commented on pull request #4607:
URL: https://github.com/apache/kafka/pull/4607#issuecomment-711667534
@lamchakchan Thanks for your patch. Sorry that I'm going to close this PR
since the issue was resolved by
chia7712 closed pull request #4607:
URL: https://github.com/apache/kafka/pull/4607
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
chia7712 commented on pull request #4777:
URL: https://github.com/apache/kafka/pull/4777#issuecomment-711662516
@attila-s Thanks for your effort. Sorry that I'm going to close this PR
since ```BlockingChannel.scala``` was removed by
chia7712 closed pull request #4777:
URL: https://github.com/apache/kafka/pull/4777
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
chia7712 commented on pull request #5435:
URL: https://github.com/apache/kafka/pull/5435#issuecomment-711652041
@mowczare Thanks for this patch. There are some misspelling "intervall" in
the ```KGroupedStream.java```. Could you fix them also?
chia7712 commented on pull request #9369:
URL: https://github.com/apache/kafka/pull/9369#issuecomment-711644549
> Why inconsistent? This is the classical robustness principle: be lean in
what you accept and strict in what you produce.
sorry for unclear description. My point was that
Fleshgrinder commented on pull request #9369:
URL: https://github.com/apache/kafka/pull/9369#issuecomment-711638037
I can try to find the others.
Why inconsistent? This is the classical robustness principle: be lean in
what you accept and strict in what you produce.
90 matches
Mail list logo
