[jira] [Assigned] (KAFKA-10841) LogReadResult should be able to converted to FetchPartitionData

2020-12-10 Thread Tom Bentley (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tom Bentley reassigned KAFKA-10841: --- Assignee: GeordieMai > LogReadResult should be able to converted to FetchPartitionData > -

[jira] [Commented] (KAFKA-10841) LogReadResult should be able to converted to FetchPartitionData

2020-12-10 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17247676#comment-17247676 ] Chia-Ping Tsai commented on KAFKA-10841: [~Geordie] go ahead > LogReadResult sh

[jira] [Commented] (KAFKA-10841) LogReadResult should be able to converted to FetchPartitionData

2020-12-10 Thread GeordieMai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17247655#comment-17247655 ] GeordieMai commented on KAFKA-10841: [~chia7712] Can I take this?   > LogReadResul

[GitHub] [kafka] d8tltanc commented on a change in pull request #9485: KAKFA-10619: Idempotent producer will get authorized once it has a WRITE access to at least one topic

2020-12-10 Thread GitBox
d8tltanc commented on a change in pull request #9485: URL: https://github.com/apache/kafka/pull/9485#discussion_r540706117 ## File path: core/src/test/scala/unit/kafka/security/authorizer/AclAuthorizerTest.scala ## @@ -1040,19 +1117,24 @@ class AclAuthorizerTest extends ZooKee

[GitHub] [kafka] hachikuji opened a new pull request #9732: KAFKA-10842; Use `InterBrokerSendThread` for raft's outbound network channel

2020-12-10 Thread GitBox
hachikuji opened a new pull request #9732: URL: https://github.com/apache/kafka/pull/9732 This patch contains the following improvements: - Separate inbound/outbound request flows so that we can open the door for concurrent inbound request handling - Rewrite `KafkaNetworkChannel`

[GitHub] [kafka] d8tltanc commented on a change in pull request #9485: KAKFA-10619: Idempotent producer will get authorized once it has a WRITE access to at least one topic

2020-12-10 Thread GitBox
d8tltanc commented on a change in pull request #9485: URL: https://github.com/apache/kafka/pull/9485#discussion_r540705023 ## File path: core/src/test/scala/unit/kafka/security/authorizer/AclAuthorizerTest.scala ## @@ -100,8 +106,15 @@ class AclAuthorizerTest extends ZooKeeper

[jira] [Created] (KAFKA-10842) Refactor raft outbound request channel

2020-12-10 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-10842: --- Summary: Refactor raft outbound request channel Key: KAFKA-10842 URL: https://issues.apache.org/jira/browse/KAFKA-10842 Project: Kafka Issue Type: Sub-

[jira] [Created] (KAFKA-10841) LogReadResult should be able to converted to FetchPartitionData

2020-12-10 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-10841: -- Summary: LogReadResult should be able to converted to FetchPartitionData Key: KAFKA-10841 URL: https://issues.apache.org/jira/browse/KAFKA-10841 Project: Kafka

[jira] [Updated] (KAFKA-10841) LogReadResult should be able to converted to FetchPartitionData

2020-12-10 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-10841: --- Labels: newbie (was: ) > LogReadResult should be able to converted to FetchPartitionData >

[GitHub] [kafka] kowshik commented on a change in pull request #9728: MINOR: make sure all dir jobs are completed

2020-12-10 Thread GitBox
kowshik commented on a change in pull request #9728: URL: https://github.com/apache/kafka/pull/9728#discussion_r540684755 ## File path: core/src/test/scala/unit/kafka/log/LogManagerTest.scala ## @@ -680,4 +680,15 @@ class LogManagerTest { time.sleep(logConfig.fileDeleteDel

[GitHub] [kafka] kowshik commented on pull request #9731: MINOR: Make Log.recordVersion private and refactor to use the same

2020-12-10 Thread GitBox
kowshik commented on pull request #9731: URL: https://github.com/apache/kafka/pull/9731#issuecomment-742962406 Thanks for the review @chia7712 ! I've addressed the comments in 2d2b4a2e732b42397df62da141df30856e5c88db. This i

[GitHub] [kafka] kowshik commented on a change in pull request #9731: MINOR: Make Log.recordVersion private and refactor to use the same

2020-12-10 Thread GitBox
kowshik commented on a change in pull request #9731: URL: https://github.com/apache/kafka/pull/9731#discussion_r540683780 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -893,7 +892,7 @@ class Log(@volatile private var _dir: File, // offset (see below). The nex

[jira] [Assigned] (KAFKA-10768) Make ByteBufferInputStream.read(byte[], int, int) to follow the contract

2020-12-10 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-10768: -- Assignee: WANG CHIEN FENG (was: Arun Parthiban) > Make ByteBufferInputStream.read(by

[jira] [Commented] (KAFKA-10768) Make ByteBufferInputStream.read(byte[], int, int) to follow the contract

2020-12-10 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17247624#comment-17247624 ] Chia-Ping Tsai commented on KAFKA-10768: [~parth017] Sorry that I am going to as

[GitHub] [kafka] chia7712 commented on a change in pull request #9730: MINOR: fix error message

2020-12-10 Thread GitBox
chia7712 commented on a change in pull request #9730: URL: https://github.com/apache/kafka/pull/9730#discussion_r540676908 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EosBetaUpgradeIntegrationTest.java ## @@ -1045,8 +1045,8 @@ private void checkRes

[GitHub] [kafka] chia7712 commented on a change in pull request #9731: MINOR: Make Log.recordVersion private and refactor to use the same

2020-12-10 Thread GitBox
chia7712 commented on a change in pull request #9731: URL: https://github.com/apache/kafka/pull/9731#discussion_r540664521 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -893,7 +892,7 @@ class Log(@volatile private var _dir: File, // offset (see below). The ne

[GitHub] [kafka] kowshik commented on pull request #9731: MINOR: Make Log.recordVersion private and refactor to use the same

2020-12-10 Thread GitBox
kowshik commented on pull request #9731: URL: https://github.com/apache/kafka/pull/9731#issuecomment-742940711 cc @junrao @ijuma @chia7712 for review This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] kowshik opened a new pull request #9731: MINOR: Make Log.recordVersion private and refactor to use the same

2020-12-10 Thread GitBox
kowshik opened a new pull request #9731: URL: https://github.com/apache/kafka/pull/9731 Couple small changes in this PR: - I've made a small cleanup. I've converted `Log.recordVersion` to be private, since, it is used only inside `Log` class. I've also changed one of the callsites to re

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9697: KAFKA-10810: Replace stream threads

2020-12-10 Thread GitBox
wcarlson5 commented on a change in pull request #9697: URL: https://github.com/apache/kafka/pull/9697#discussion_r540661585 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/StreamsUncaughtExceptionHandlerIntegrationTest.java ## @@ -202,6 +213,29 @@ priv

[jira] [Resolved] (KAFKA-10463) the necessary utilities in Dockerfile should include git

2020-12-10 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-10463. Fix Version/s: 2.7.0 Resolution: Fixed > the necessary utilities in Dockerfile shou

[jira] [Assigned] (KAFKA-8073) Transient failure in kafka.api.UserQuotaTest.testThrottledProducerConsumer

2020-12-10 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-8073: - Assignee: (was: Chia-Ping Tsai) > Transient failure in kafka.api.UserQuotaTest.testT

[jira] [Resolved] (KAFKA-7036) Complete the docs of KafkaConsumer#poll

2020-12-10 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-7036. --- Resolution: Won't Fix > Complete the docs of KafkaConsumer#poll > ---

[jira] [Resolved] (KAFKA-9786) fix flaky MetricsTest.testGeneralBrokerTopicMetricsAreGreedilyRegistered

2020-12-10 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-9786. --- Resolution: Won't Fix > fix flaky MetricsTest.testGeneralBrokerTopicMetricsAreGreedilyRegiste

[GitHub] [kafka] d8tltanc commented on a change in pull request #9485: KAKFA-10619: Idempotent producer will get authorized once it has a WRITE access to at least one topic

2020-12-10 Thread GitBox
d8tltanc commented on a change in pull request #9485: URL: https://github.com/apache/kafka/pull/9485#discussion_r540658692 ## File path: core/src/main/scala/kafka/security/authorizer/AuthorizerWrapper.scala ## @@ -175,4 +181,32 @@ class AuthorizerWrapper(private[kafka] val base

[GitHub] [kafka] d8tltanc commented on a change in pull request #9485: KAKFA-10619: Idempotent producer will get authorized once it has a WRITE access to at least one topic

2020-12-10 Thread GitBox
d8tltanc commented on a change in pull request #9485: URL: https://github.com/apache/kafka/pull/9485#discussion_r540655651 ## File path: core/src/main/scala/kafka/security/authorizer/AuthorizerWrapper.scala ## @@ -175,4 +181,32 @@ class AuthorizerWrapper(private[kafka] val base

[GitHub] [kafka] d8tltanc commented on a change in pull request #9485: KAKFA-10619: Idempotent producer will get authorized once it has a WRITE access to at least one topic

2020-12-10 Thread GitBox
d8tltanc commented on a change in pull request #9485: URL: https://github.com/apache/kafka/pull/9485#discussion_r540655651 ## File path: core/src/main/scala/kafka/security/authorizer/AuthorizerWrapper.scala ## @@ -175,4 +181,32 @@ class AuthorizerWrapper(private[kafka] val base

[GitHub] [kafka] kowshik commented on pull request #9718: KAFKA-10832: Fix Log to use the correct ProducerStateManager instance when updating producers

2020-12-10 Thread GitBox
kowshik commented on pull request #9718: URL: https://github.com/apache/kafka/pull/9718#issuecomment-742922667 Thanks for the review, @junrao! I've addressed the comments in 5d798b7d884bd11e43884318ae3fc8d12e635c40. This is

[GitHub] [kafka] ijuma merged pull request #9129: MINOR: Update jmh to 1.27 for async profiler support

2020-12-10 Thread GitBox
ijuma merged pull request #9129: URL: https://github.com/apache/kafka/pull/9129 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] mjsax opened a new pull request #9730: MINOR: fix error message

2020-12-10 Thread GitBox
mjsax opened a new pull request #9730: URL: https://github.com/apache/kafka/pull/9730 Got the accumulator lambda wrong in #9688 Call for review @ableegoldman This is an automated message from the Apache Git Service.

[GitHub] [kafka] ijuma commented on a change in pull request #9129: MINOR: Update jmh to 1.27 for async profiler support

2020-12-10 Thread GitBox
ijuma commented on a change in pull request #9129: URL: https://github.com/apache/kafka/pull/9129#discussion_r540631610 ## File path: jmh-benchmarks/README.md ## @@ -1,10 +1,69 @@ -### JMH-Benchmark module +### JMH-Benchmarks module This module contains benchmarks written us

[GitHub] [kafka] mjsax commented on pull request #9688: KAFKA-10017: fix flaky EOS-beta upgrade test

2020-12-10 Thread GitBox
mjsax commented on pull request #9688: URL: https://github.com/apache/kafka/pull/9688#issuecomment-742911941 Merged to `trunk` and cherry-picked to `2.7`. This is an automated message from the Apache Git Service. To respond t

[GitHub] [kafka] mjsax merged pull request #9688: KAFKA-10017: fix flaky EOS-beta upgrade test

2020-12-10 Thread GitBox
mjsax merged pull request #9688: URL: https://github.com/apache/kafka/pull/9688 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9727: [KAFKA-10417] Update Cogrouped processor to work with suppress() and joins

2020-12-10 Thread GitBox
wcarlson5 commented on a change in pull request #9727: URL: https://github.com/apache/kafka/pull/9727#discussion_r540619198 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/CogroupedStreamAggregateBuilder.java ## @@ -115,24 +124,28 @@

[GitHub] [kafka] junrao commented on a change in pull request #9718: KAFKA-10832: Fix Log to use the correct ProducerStateManager instance when updating producers

2020-12-10 Thread GitBox
junrao commented on a change in pull request #9718: URL: https://github.com/apache/kafka/pull/9718#discussion_r540588994 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -2670,6 +2573,112 @@ object Log { private def isLogFile(file: File): Boolean = file.getPa

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9720: KAFKA-10555: Improve client state machine

2020-12-10 Thread GitBox
wcarlson5 commented on a change in pull request #9720: URL: https://github.com/apache/kafka/pull/9720#discussion_r540486098 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -1142,11 +1128,21 @@ private Thread shutdownHelper(final boolean erro

[GitHub] [kafka] lbradstreet commented on a change in pull request #9729: KAFKA-10839: improve consumer group coordinator unavailable message

2020-12-10 Thread GitBox
lbradstreet commented on a change in pull request #9729: URL: https://github.com/apache/kafka/pull/9729#discussion_r540578598 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java ## @@ -257,7 +257,7 @@ protected synchronized

[GitHub] [kafka] lbradstreet commented on a change in pull request #9729: KAFKA-10839: improve consumer group coordinator unavailable message

2020-12-10 Thread GitBox
lbradstreet commented on a change in pull request #9729: URL: https://github.com/apache/kafka/pull/9729#discussion_r540578510 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java ## @@ -1355,7 +1362,7 @@ public void run() {

[GitHub] [kafka] lbradstreet opened a new pull request #9729: KAFKA-10839: improve consumer group coordinator unavailable message

2020-12-10 Thread GitBox
lbradstreet opened a new pull request #9729: URL: https://github.com/apache/kafka/pull/9729 When a consumer encounters an issue that triggers marking it to mark coordinator as unknown, the error message it prints does not give much context about the error that triggered it. This change inc

[GitHub] [kafka] jolshan commented on a change in pull request #9626: KAFKA-10545: Create topic IDs and propagate to brokers

2020-12-10 Thread GitBox
jolshan commented on a change in pull request #9626: URL: https://github.com/apache/kafka/pull/9626#discussion_r540577792 ## File path: clients/src/main/java/org/apache/kafka/common/requests/LeaderAndIsrRequest.java ## @@ -138,14 +145,32 @@ public LeaderAndIsrResponse getError

[GitHub] [kafka] kowshik commented on a change in pull request #9718: KAFKA-10832: Fix Log to use the correct ProducerStateManager instance when updating producers

2020-12-10 Thread GitBox
kowshik commented on a change in pull request #9718: URL: https://github.com/apache/kafka/pull/9718#discussion_r540573082 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -2670,6 +2573,112 @@ object Log { private def isLogFile(file: File): Boolean = file.getP

[GitHub] [kafka] junrao commented on a change in pull request #9718: KAFKA-10832: Fix Log to use the correct ProducerStateManager instance when updating producers

2020-12-10 Thread GitBox
junrao commented on a change in pull request #9718: URL: https://github.com/apache/kafka/pull/9718#discussion_r540571244 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -2670,6 +2573,112 @@ object Log { private def isLogFile(file: File): Boolean = file.getPa

[jira] [Updated] (KAFKA-10840) Need way to catch auth issues in poll method of Java Kafka client

2020-12-10 Thread Devin G. Bost (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Devin G. Bost updated KAFKA-10840: -- Summary: Need way to catch auth issues in poll method of Java Kafka client (was: Need way to

[jira] [Created] (KAFKA-10840) Need way to catch auth issues in poll method

2020-12-10 Thread Devin G. Bost (Jira)
Devin G. Bost created KAFKA-10840: - Summary: Need way to catch auth issues in poll method Key: KAFKA-10840 URL: https://issues.apache.org/jira/browse/KAFKA-10840 Project: Kafka Issue Type: Im

[jira] [Created] (KAFKA-10839) Improve consumer group coordinator unavailable message

2020-12-10 Thread Lucas Bradstreet (Jira)
Lucas Bradstreet created KAFKA-10839: Summary: Improve consumer group coordinator unavailable message Key: KAFKA-10839 URL: https://issues.apache.org/jira/browse/KAFKA-10839 Project: Kafka

[GitHub] [kafka] jolshan commented on a change in pull request #9626: KAFKA-10545: Create topic IDs and propagate to brokers

2020-12-10 Thread GitBox
jolshan commented on a change in pull request #9626: URL: https://github.com/apache/kafka/pull/9626#discussion_r540537367 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1378,12 +1378,26 @@ class KafkaController(val config: KafkaConfig, val

[GitHub] [kafka] bbejeck removed a comment on pull request #9722: MINOR: add missing quickstart.html file

2020-12-10 Thread GitBox
bbejeck removed a comment on pull request #9722: URL: https://github.com/apache/kafka/pull/9722#issuecomment-742833112 I think it would help if @scott-confluent reviewed this as well This is an automated message from the Apac

[GitHub] [kafka] bbejeck commented on pull request #9722: MINOR: add missing quickstart.html file

2020-12-10 Thread GitBox
bbejeck commented on pull request #9722: URL: https://github.com/apache/kafka/pull/9722#issuecomment-742833112 I think it would help if @scott-confluent reviewed this as well This is an automated message from the Apache Git S

[jira] [Created] (KAFKA-10837) Fix javadoc issues and warnings in Connect

2020-12-10 Thread Konstantine Karantasis (Jira)
Konstantine Karantasis created KAFKA-10837: -- Summary: Fix javadoc issues and warnings in Connect Key: KAFKA-10837 URL: https://issues.apache.org/jira/browse/KAFKA-10837 Project: Kafka

[jira] [Created] (KAFKA-10838) Make member fields final if applicable in Connect

2020-12-10 Thread Konstantine Karantasis (Jira)
Konstantine Karantasis created KAFKA-10838: -- Summary: Make member fields final if applicable in Connect Key: KAFKA-10838 URL: https://issues.apache.org/jira/browse/KAFKA-10838 Project: Kafka

[jira] [Created] (KAFKA-10836) Use type inference and cleanup generic type declarations in Connect

2020-12-10 Thread Konstantine Karantasis (Jira)
Konstantine Karantasis created KAFKA-10836: -- Summary: Use type inference and cleanup generic type declarations in Connect Key: KAFKA-10836 URL: https://issues.apache.org/jira/browse/KAFKA-10836

[jira] [Created] (KAFKA-10834) Remove redundant type casts in Connect

2020-12-10 Thread Konstantine Karantasis (Jira)
Konstantine Karantasis created KAFKA-10834: -- Summary: Remove redundant type casts in Connect Key: KAFKA-10834 URL: https://issues.apache.org/jira/browse/KAFKA-10834 Project: Kafka Is

[jira] [Created] (KAFKA-10835) Replace Runnable and Callable overrides with lambdas in Connect

2020-12-10 Thread Konstantine Karantasis (Jira)
Konstantine Karantasis created KAFKA-10835: -- Summary: Replace Runnable and Callable overrides with lambdas in Connect Key: KAFKA-10835 URL: https://issues.apache.org/jira/browse/KAFKA-10835 P

[GitHub] [kafka] jolshan commented on a change in pull request #9626: KAFKA-10545: Create topic IDs and propagate to brokers

2020-12-10 Thread GitBox
jolshan commented on a change in pull request #9626: URL: https://github.com/apache/kafka/pull/9626#discussion_r540516535 ## File path: clients/src/main/java/org/apache/kafka/common/requests/LeaderAndIsrRequest.java ## @@ -138,14 +145,32 @@ public LeaderAndIsrResponse getError

[GitHub] [kafka] jolshan commented on a change in pull request #9626: KAFKA-10545: Create topic IDs and propagate to brokers

2020-12-10 Thread GitBox
jolshan commented on a change in pull request #9626: URL: https://github.com/apache/kafka/pull/9626#discussion_r540513762 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1378,12 +1378,26 @@ class KafkaController(val config: KafkaConfig, val

[GitHub] [kafka] jolshan commented on a change in pull request #9626: KAFKA-10545: Create topic IDs and propagate to brokers

2020-12-10 Thread GitBox
jolshan commented on a change in pull request #9626: URL: https://github.com/apache/kafka/pull/9626#discussion_r540513762 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1378,12 +1378,26 @@ class KafkaController(val config: KafkaConfig, val

[jira] [Updated] (KAFKA-8334) Occasional OffsetCommit Timeout

2020-12-10 Thread Lucas Bradstreet (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Bradstreet updated KAFKA-8334: Affects Version/s: (was: 1.1.0) > Occasional OffsetCommit Timeout > ---

[GitHub] [kafka] jolshan commented on a change in pull request #9626: KAFKA-10545: Create topic IDs and propagate to brokers

2020-12-10 Thread GitBox
jolshan commented on a change in pull request #9626: URL: https://github.com/apache/kafka/pull/9626#discussion_r540510301 ## File path: clients/src/main/java/org/apache/kafka/common/requests/LeaderAndIsrResponse.java ## @@ -45,8 +47,16 @@ public LeaderAndIsrResponse(Struct str

[jira] [Updated] (KAFKA-8334) Occasional OffsetCommit Timeout

2020-12-10 Thread Lucas Bradstreet (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Bradstreet updated KAFKA-8334: Affects Version/s: 2.0.0 2.1.0 2.2.0

[jira] [Updated] (KAFKA-8334) Occasional OffsetCommit Timeout

2020-12-10 Thread Lucas Bradstreet (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Bradstreet updated KAFKA-8334: Affects Version/s: 1.1.0 > Occasional OffsetCommit Timeout > --

[GitHub] [kafka] kowshik commented on pull request #9718: KAFKA-10832: Use the correct ProducerStateManager instance when updating producers

2020-12-10 Thread GitBox
kowshik commented on pull request #9718: URL: https://github.com/apache/kafka/pull/9718#issuecomment-742803224 @ijuma Thanks for the review! I've addressed your comments in 6d348bcc12f9e8b2ddf0552c089945b4eda67538. This

[jira] [Commented] (KAFKA-10802) Spurious log message when starting consumers

2020-12-10 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17247511#comment-17247511 ] Bill Bejeck commented on KAFKA-10802: - cherry-picked to 2.7 > Spurious log message

[GitHub] [kafka] bbejeck commented on pull request #9667: MINOR: Do not print log4j for memberId required

2020-12-10 Thread GitBox
bbejeck commented on pull request #9667: URL: https://github.com/apache/kafka/pull/9667#issuecomment-742799929 cherry-picked to 2.7 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [kafka] chia7712 commented on a change in pull request #9728: MINOR: make sure all dir jobs are completed

2020-12-10 Thread GitBox
chia7712 commented on a change in pull request #9728: URL: https://github.com/apache/kafka/pull/9728#discussion_r540486925 ## File path: core/src/main/scala/kafka/log/LogManager.scala ## @@ -435,6 +436,20 @@ class LogManager(logDirs: Seq[File], cleaner.startup() } +

[GitHub] [kafka] chia7712 commented on a change in pull request #9728: MINOR: make sure all dir jobs are completed

2020-12-10 Thread GitBox
chia7712 commented on a change in pull request #9728: URL: https://github.com/apache/kafka/pull/9728#discussion_r540484990 ## File path: core/src/test/scala/unit/kafka/log/LogManagerTest.scala ## @@ -680,4 +680,15 @@ class LogManagerTest { time.sleep(logConfig.fileDeleteDe

[jira] [Updated] (KAFKA-10802) Spurious log message when starting consumers

2020-12-10 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck updated KAFKA-10802: Fix Version/s: 2.7.0 > Spurious log message when starting consumers >

[GitHub] [kafka] chia7712 commented on a change in pull request #9728: MINOR: make sure all dir jobs are completed

2020-12-10 Thread GitBox
chia7712 commented on a change in pull request #9728: URL: https://github.com/apache/kafka/pull/9728#discussion_r540483941 ## File path: core/src/test/scala/unit/kafka/log/LogManagerTest.scala ## @@ -680,4 +680,15 @@ class LogManagerTest { time.sleep(logConfig.fileDeleteDe

[GitHub] [kafka] kowshik commented on a change in pull request #9728: MINOR: make sure all dir jobs are completed

2020-12-10 Thread GitBox
kowshik commented on a change in pull request #9728: URL: https://github.com/apache/kafka/pull/9728#discussion_r540478009 ## File path: core/src/test/scala/unit/kafka/log/LogManagerTest.scala ## @@ -680,4 +680,15 @@ class LogManagerTest { time.sleep(logConfig.fileDeleteDel

[GitHub] [kafka] kowshik commented on a change in pull request #9728: MINOR: make sure all dir jobs are completed

2020-12-10 Thread GitBox
kowshik commented on a change in pull request #9728: URL: https://github.com/apache/kafka/pull/9728#discussion_r540478009 ## File path: core/src/test/scala/unit/kafka/log/LogManagerTest.scala ## @@ -680,4 +680,15 @@ class LogManagerTest { time.sleep(logConfig.fileDeleteDel

[GitHub] [kafka] kowshik commented on a change in pull request #9680: MINOR: a small refactor for LogManage#shutdown

2020-12-10 Thread GitBox
kowshik commented on a change in pull request #9680: URL: https://github.com/apache/kafka/pull/9680#discussion_r540476157 ## File path: core/src/main/scala/kafka/log/LogManager.scala ## @@ -479,14 +479,14 @@ class LogManager(logDirs: Seq[File], try { for ((dir, di

[GitHub] [kafka] kowshik commented on a change in pull request #9680: MINOR: a small refactor for LogManage#shutdown

2020-12-10 Thread GitBox
kowshik commented on a change in pull request #9680: URL: https://github.com/apache/kafka/pull/9680#discussion_r540476157 ## File path: core/src/main/scala/kafka/log/LogManager.scala ## @@ -479,14 +479,14 @@ class LogManager(logDirs: Seq[File], try { for ((dir, di

[jira] [Commented] (KAFKA-10802) Spurious log message when starting consumers

2020-12-10 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17247490#comment-17247490 ] Ismael Juma commented on KAFKA-10802: - Thanks [~mimaison]! > Spurious log message w

[GitHub] [kafka] ijuma commented on a change in pull request #9728: MINOR: make sure all dir jobs are completed

2020-12-10 Thread GitBox
ijuma commented on a change in pull request #9728: URL: https://github.com/apache/kafka/pull/9728#discussion_r540467496 ## File path: core/src/main/scala/kafka/log/LogManager.scala ## @@ -435,6 +436,20 @@ class LogManager(logDirs: Seq[File], cleaner.startup() } + /

[GitHub] [kafka] chia7712 commented on pull request #9516: MINOR: make Send and Receive work with TransportLayer rather than Gat…

2020-12-10 Thread GitBox
chia7712 commented on pull request #9516: URL: https://github.com/apache/kafka/pull/9516#issuecomment-742769046 > This seems less safe than what we had before. Same for the transferFrom implementation. I think we want implementations to decide the right behavior for themselves. Fair

[GitHub] [kafka] chia7712 commented on a change in pull request #9728: MINOR: make sure all dir jobs are completed

2020-12-10 Thread GitBox
chia7712 commented on a change in pull request #9728: URL: https://github.com/apache/kafka/pull/9728#discussion_r540463850 ## File path: core/src/main/scala/kafka/log/LogManager.scala ## @@ -435,6 +436,20 @@ class LogManager(logDirs: Seq[File], cleaner.startup() } +

[GitHub] [kafka] ijuma commented on a change in pull request #9728: MINOR: make sure all dir jobs are completed

2020-12-10 Thread GitBox
ijuma commented on a change in pull request #9728: URL: https://github.com/apache/kafka/pull/9728#discussion_r540461670 ## File path: core/src/main/scala/kafka/log/LogManager.scala ## @@ -435,6 +436,20 @@ class LogManager(logDirs: Seq[File], cleaner.startup() } + /

[jira] [Updated] (KAFKA-10345) Add auto reloading for trust/key store paths

2020-12-10 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen updated KAFKA-10345: Summary: Add auto reloading for trust/key store paths (was: Add file-watch based update for trust

[jira] [Updated] (KAFKA-10345) Add file-watch based update for trust/key store paths

2020-12-10 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen updated KAFKA-10345: Description: With forwarding enabled, per-broker alter-config doesn't go to the target broker anym

[GitHub] [kafka] chia7712 commented on a change in pull request #9516: MINOR: make Send and Receive work with TransportLayer rather than Gat…

2020-12-10 Thread GitBox
chia7712 commented on a change in pull request #9516: URL: https://github.com/apache/kafka/pull/9516#discussion_r540448555 ## File path: clients/src/test/java/org/apache/kafka/common/record/LazyDownConversionRecordsTest.java ## @@ -160,20 +161,21 @@ private static MemoryRecord

[GitHub] [kafka] chia7712 commented on a change in pull request #9516: MINOR: make Send and Receive work with TransportLayer rather than Gat…

2020-12-10 Thread GitBox
chia7712 commented on a change in pull request #9516: URL: https://github.com/apache/kafka/pull/9516#discussion_r540448555 ## File path: clients/src/test/java/org/apache/kafka/common/record/LazyDownConversionRecordsTest.java ## @@ -160,20 +161,21 @@ private static MemoryRecord

[jira] [Commented] (KAFKA-10802) Spurious log message when starting consumers

2020-12-10 Thread Gary Russell (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17247449#comment-17247449 ] Gary Russell commented on KAFKA-10802: -- Thanks, guys, really appreciate it; I think

[GitHub] [kafka] lct45 commented on pull request #9708: [KAFKA-9126]: KIP-689: Add options to enable/disable logging for `StreamJoined`

2020-12-10 Thread GitBox
lct45 commented on pull request #9708: URL: https://github.com/apache/kafka/pull/9708#issuecomment-742742254 @vvcephei Thanks for the review! Overall the test coverage looks pretty good, IIUC the log config is never touched when logging is disabled so I don't think there's a NPE that we're

[GitHub] [kafka] lct45 commented on a change in pull request #9708: [KAFKA-9126]: KIP-689: Add options to enable/disable logging for `StreamJoined`

2020-12-10 Thread GitBox
lct45 commented on a change in pull request #9708: URL: https://github.com/apache/kafka/pull/9708#discussion_r540431368 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoinTest.java ## @@ -152,6 +155,52 @@ private void shouldLogAnd

[jira] [Assigned] (KAFKA-10802) Spurious log message when starting consumers

2020-12-10 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison reassigned KAFKA-10802: -- Assignee: Guozhang Wang > Spurious log message when starting consumers >

[jira] [Resolved] (KAFKA-10802) Spurious log message when starting consumers

2020-12-10 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-10802. Fix Version/s: 2.8.0 2.6.1 Resolution: Fixed > Spurious log mess

[jira] [Comment Edited] (KAFKA-10802) Spurious log message when starting consumers

2020-12-10 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17247431#comment-17247431 ] Bill Bejeck edited comment on KAFKA-10802 at 12/10/20, 7:07 PM: --

[jira] [Commented] (KAFKA-10802) Spurious log message when starting consumers

2020-12-10 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17247431#comment-17247431 ] Bill Bejeck commented on KAFKA-10802: - Thanks for the heads up [~mimaison] I need to

[jira] [Resolved] (KAFKA-9552) Stream should handle OutOfSequence exception thrown from Producer

2020-12-10 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-9552. Fix Version/s: 2.6.0 Resolution: Fixed > Stream should handle OutOfSequence exceptio

[jira] [Reopened] (KAFKA-9552) Stream should handle OutOfSequence exception thrown from Producer

2020-12-10 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reopened KAFKA-9552: > Stream should handle OutOfSequence exception thrown from Producer > -

[GitHub] [kafka] d8tltanc commented on a change in pull request #9485: KAKFA-10619: Idempotent producer will get authorized once it has a WRITE access to at least one topic

2020-12-10 Thread GitBox
d8tltanc commented on a change in pull request #9485: URL: https://github.com/apache/kafka/pull/9485#discussion_r540418386 ## File path: core/src/main/scala/kafka/security/authorizer/AuthorizerWrapper.scala ## @@ -71,15 +73,19 @@ object AuthorizerWrapper { } def convert

[GitHub] [kafka] dajac commented on a change in pull request #9689: KAFKA-10740; Replace OffsetsForLeaderEpochRequest.PartitionData with automated protocol

2020-12-10 Thread GitBox
dajac commented on a change in pull request #9689: URL: https://github.com/apache/kafka/pull/9689#discussion_r540406112 ## File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala ## @@ -268,11 +271,12 @@ abstract class AbstractFetcherThread(name: String,

[GitHub] [kafka] wcarlson5 edited a comment on pull request #9695: KAFKA-10500: Remove thread

2020-12-10 Thread GitBox
wcarlson5 edited a comment on pull request #9695: URL: https://github.com/apache/kafka/pull/9695#issuecomment-742706985 @cadonna > In the KIP, it says that a rebalance is triggered even under static membership. I could not find any code that ensures that. Shall we do that in a sepa

[jira] [Commented] (KAFKA-10802) Spurious log message when starting consumers

2020-12-10 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17247401#comment-17247401 ] Mickael Maison commented on KAFKA-10802: I'm backporting this fix to 2.6 and I'l

[GitHub] [kafka] wcarlson5 commented on pull request #9695: KAFKA-10500: Remove thread

2020-12-10 Thread GitBox
wcarlson5 commented on pull request #9695: URL: https://github.com/apache/kafka/pull/9695#issuecomment-742706985 @cadonna > In the KIP, it says that a rebalance is triggered even under static membership. I could not find any code that ensures that. Shall we do that in a separate PR

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9695: KAFKA-10500: Remove thread

2020-12-10 Thread GitBox
wcarlson5 commented on a change in pull request #9695: URL: https://github.com/apache/kafka/pull/9695#discussion_r540351596 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -924,25 +924,64 @@ private StreamThread createStreamThread(final long

[GitHub] [kafka] mimaison commented on pull request #9726: KAFKA-10833: Expose task configurations in Connect REST API

2020-12-10 Thread GitBox
mimaison commented on pull request #9726: URL: https://github.com/apache/kafka/pull/9726#issuecomment-742697895 @rhauch @kkonstantine can you take a look? Thanks This is an automated message from the Apache Git Service. To re

[GitHub] [kafka] dajac commented on a change in pull request #9689: KAFKA-10740; Replace OffsetsForLeaderEpochRequest.PartitionData with automated protocol

2020-12-10 Thread GitBox
dajac commented on a change in pull request #9689: URL: https://github.com/apache/kafka/pull/9689#discussion_r540382825 ## File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala ## @@ -268,11 +271,12 @@ abstract class AbstractFetcherThread(name: String,

[GitHub] [kafka] vvcephei commented on a change in pull request #9708: [KAFKA-9126]: KIP-689: Add options to enable/disable logging for `StreamJoined`

2020-12-10 Thread GitBox
vvcephei commented on a change in pull request #9708: URL: https://github.com/apache/kafka/pull/9708#discussion_r540375321 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/StreamJoined.java ## @@ -267,7 +296,49 @@ private StreamJoined(final Serde keySerde,

[GitHub] [kafka] ijuma commented on a change in pull request #9129: MINOR: Update jmh to 1.27 for async profiler support

2020-12-10 Thread GitBox
ijuma commented on a change in pull request #9129: URL: https://github.com/apache/kafka/pull/9129#discussion_r540373445 ## File path: jmh-benchmarks/README.md ## @@ -1,10 +1,69 @@ -### JMH-Benchmark module +### JMH-Benchmarks module This module contains benchmarks written us

[GitHub] [kafka] ijuma commented on a change in pull request #9129: MINOR: Update jmh to 1.27 for async profiler support

2020-12-10 Thread GitBox
ijuma commented on a change in pull request #9129: URL: https://github.com/apache/kafka/pull/9129#discussion_r540372753 ## File path: jmh-benchmarks/README.md ## @@ -1,10 +1,69 @@ -### JMH-Benchmark module +### JMH-Benchmarks module This module contains benchmarks written us

[GitHub] [kafka] lbradstreet commented on a change in pull request #9129: MINOR: Update jmh to 1.27 for async profiler support

2020-12-10 Thread GitBox
lbradstreet commented on a change in pull request #9129: URL: https://github.com/apache/kafka/pull/9129#discussion_r540361683 ## File path: jmh-benchmarks/README.md ## @@ -1,10 +1,69 @@ -### JMH-Benchmark module +### JMH-Benchmarks module This module contains benchmarks writ

  1   2   >