dengziming commented on a change in pull request #9955:
URL: https://github.com/apache/kafka/pull/9955#discussion_r563253676
##
File path:
clients/src/test/java/org/apache/kafka/clients/producer/MockProducerTest.java
##
@@ -114,7 +114,7 @@ public void testManualCompletion()
kkonstantine commented on pull request #9867:
URL: https://github.com/apache/kafka/pull/9867#issuecomment-766307470
I'm a bit surprise to hear that this doesn't come up with cherry-picks. In
Connect we backport any bugfix, usually 2-3 releases back. I believe it would
be a challenge to
g1geordie commented on a change in pull request #9955:
URL: https://github.com/apache/kafka/pull/9955#discussion_r563253451
##
File path:
clients/src/test/java/org/apache/kafka/clients/producer/MockProducerTest.java
##
@@ -114,7 +114,7 @@ public void testManualCompletion()
dajac merged pull request #9955:
URL: https://github.com/apache/kafka/pull/9955
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ijuma commented on pull request #9867:
URL: https://github.com/apache/kafka/pull/9867#issuecomment-766306681
I understood the intent, but I don't think it's worth it, personally.
Backports are not meant to be frequent, so I don't see why there would be
frequent conflicts. For clients and
kkonstantine commented on pull request #9867:
URL: https://github.com/apache/kafka/pull/9867#issuecomment-766306034
@ijuma what are trying to achieve here with backporting is to have a similar
basis for other future bugfixes that _will have to_ be applied to both the new
and the old
rohitrmd commented on pull request #9744:
URL: https://github.com/apache/kafka/pull/9744#issuecomment-766302189
@mjsax made changes as per the review. Can you please re-review?
This is an automated message from the Apache
rohitrmd commented on a change in pull request #9744:
URL: https://github.com/apache/kafka/pull/9744#discussion_r563247511
##
File path:
streams/src/test/java/org/apache/kafka/test/MockInternalProcessorContext.java
##
@@ -55,14 +55,9 @@ public
dengziming opened a new pull request #9955:
URL: https://github.com/apache/kafka/pull/9955
*More detailed description of your change*
1. assertTrue(!) -> assertFalse()
2. assertNotEquals(null, x) -> assertNotNul(x)
3. assertEquals(null, x) -> assertNull(x)
*Summary of
dengziming commented on pull request #9819:
URL: https://github.com/apache/kafka/pull/9819#issuecomment-766289814
@hachikuji ,Thank you for your suggestions, I found `DefaultRecordsSend`
similar to `UnalignedRecordsSend ` so I added a generic type
to`DefaultRecordsSend`, and also added a
ijuma merged pull request #9925:
URL: https://github.com/apache/kafka/pull/9925
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ijuma merged pull request #9953:
URL: https://github.com/apache/kafka/pull/9953
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
hachikuji merged pull request #9952:
URL: https://github.com/apache/kafka/pull/9952
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
[
https://issues.apache.org/jira/browse/KAFKA-12228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17270755#comment-17270755
]
Alexey Kashavkin edited comment on KAFKA-12228 at 1/23/21, 9:00 PM:
[
https://issues.apache.org/jira/browse/KAFKA-12228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17270755#comment-17270755
]
Alexey Kashavkin commented on KAFKA-12228:
--
I switched to different Oracle JDK versions, but no
chia7712 opened a new pull request #9954:
URL: https://github.com/apache/kafka/pull/9954
### Changes
1. add public ```FilterByKeyIterator``` to replace private
```FilterByKeyIterator``` in ```RecordHeaders``` and ```ConnectHeaders```
1. apply ```FlattenedIterator``` to code base
[
https://issues.apache.org/jira/browse/KAFKA-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17270739#comment-17270739
]
Stuart Perks edited comment on KAFKA-4113 at 1/23/21, 7:33 PM:
---
[~mjsax] I
[
https://issues.apache.org/jira/browse/KAFKA-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17270739#comment-17270739
]
Stuart Perks edited comment on KAFKA-4113 at 1/23/21, 7:33 PM:
---
[~mjsax] I
[
https://issues.apache.org/jira/browse/KAFKA-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17270739#comment-17270739
]
Stuart Perks commented on KAFKA-4113:
-
[~mjsax] I have a scenario where I have a KTable which is
[
https://issues.apache.org/jira/browse/KAFKA-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17270731#comment-17270731
]
ASF GitHub Bot commented on KAFKA-8930:
---
ryannedolan commented on a change in pull request #324:
chia7712 commented on a change in pull request #9949:
URL: https://github.com/apache/kafka/pull/9949#discussion_r563179261
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/LeaderAndIsrRequest.java
##
@@ -183,8 +182,7 @@ public long brokerEpoch() {
chia7712 closed pull request #9949:
URL: https://github.com/apache/kafka/pull/9949
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
ijuma opened a new pull request #9953:
URL: https://github.com/apache/kafka/pull/9953
A number of regressions were fixed (see "Fixed issues" section):
https://docs.gradle.org/6.8.1/release-notes.html
### Committer Checklist (excluded from commit message)
- [ ] Verify design
ijuma commented on pull request #9925:
URL: https://github.com/apache/kafka/pull/9925#issuecomment-766143833
@chia7712 Does this look ok to you? I am interested in making `unitTest`
fast, so would like to get this merged.
ijuma commented on a change in pull request #9949:
URL: https://github.com/apache/kafka/pull/9949#discussion_r563175967
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/LeaderAndIsrRequest.java
##
@@ -183,8 +182,7 @@ public long brokerEpoch() {
ijuma commented on a change in pull request #9949:
URL: https://github.com/apache/kafka/pull/9949#discussion_r563175967
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/LeaderAndIsrRequest.java
##
@@ -183,8 +182,7 @@ public long brokerEpoch() {
ijuma commented on a change in pull request #9949:
URL: https://github.com/apache/kafka/pull/9949#discussion_r563175881
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/LeaderAndIsrRequest.java
##
@@ -183,8 +182,7 @@ public long brokerEpoch() {
dengziming commented on a change in pull request #9769:
URL: https://github.com/apache/kafka/pull/9769#discussion_r563168372
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -1190,8 +1192,31 @@ class KafkaApis(val requestChannel: RequestChannel,
val
dajac commented on a change in pull request #9952:
URL: https://github.com/apache/kafka/pull/9952#discussion_r563150246
##
File path: core/src/main/scala/kafka/coordinator/group/GroupMetadata.scala
##
@@ -144,10 +144,9 @@ private object GroupMetadata extends Logging {
29 matches
Mail list logo
