[GitHub] [kafka] levzem commented on pull request #10053: KAFKA-10834: Remove redundant type casts in Connect

2021-02-04 Thread GitBox
levzem commented on pull request #10053: URL: https://github.com/apache/kafka/pull/10053#issuecomment-773495387 @kkonstantine would appreciate some  This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] levzem opened a new pull request #10053: KAFKA-10834: Remove redundant type casts in Connect

2021-02-04 Thread GitBox
levzem opened a new pull request #10053: URL: https://github.com/apache/kafka/pull/10053 Signed-off-by: Lev Zemlyanov *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping

[jira] [Commented] (KAFKA-7271) Fix ignored test in streams_upgrade_test.py: test_upgrade_downgrade_brokers

2021-02-04 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17279011#comment-17279011 ] Bruno Cadonna commented on KAFKA-7271: -- Split the ticket into two tickets: KAFKA-12292 and

[jira] [Created] (KAFKA-12292) Fix Ignored Downgrade Tests in streams_upgrade_test.py: test_upgrade_downgrade_brokers

2021-02-04 Thread Bruno Cadonna (Jira)
Bruno Cadonna created KAFKA-12292: - Summary: Fix Ignored Downgrade Tests in streams_upgrade_test.py: test_upgrade_downgrade_brokers Key: KAFKA-12292 URL: https://issues.apache.org/jira/browse/KAFKA-12292

[jira] [Created] (KAFKA-12291) Fix Ignored Upgrade Tests in streams_upgrade_test.py: test_upgrade_downgrade_brokers

2021-02-04 Thread Bruno Cadonna (Jira)
Bruno Cadonna created KAFKA-12291: - Summary: Fix Ignored Upgrade Tests in streams_upgrade_test.py: test_upgrade_downgrade_brokers Key: KAFKA-12291 URL: https://issues.apache.org/jira/browse/KAFKA-12291

[GitHub] [kafka] rhauch commented on pull request #9780: KAFKA-10021: Changed Kafka backing stores to use shared admin client to get end offsets and create topics

2021-02-04 Thread GitBox
rhauch commented on pull request #9780: URL: https://github.com/apache/kafka/pull/9780#issuecomment-773485918 Rebased on `trunk` to correct conflicts. This is an automated message from the Apache Git Service. To respond to

[jira] [Updated] (KAFKA-7271) Fix ignored test in streams_upgrade_test.py: test_upgrade_downgrade_brokers

2021-02-04 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-7271: - Priority: Blocker (was: Critical) > Fix ignored test in streams_upgrade_test.py:

[GitHub] [kafka] hachikuji commented on pull request #9756: KAFKA-10652: Adding size based linger semnatics to Raft metadata

2021-02-04 Thread GitBox
hachikuji commented on pull request #9756: URL: https://github.com/apache/kafka/pull/9756#issuecomment-773479357 @vamossagar12 Thanks, I missed the update. I will review today. This is an automated message from the Apache

[jira] [Updated] (KAFKA-9588) Add rocksdb event listeners in KS

2021-02-04 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-9588: - Fix Version/s: (was: 3.0.0) > Add rocksdb event listeners in KS >

[jira] [Updated] (KAFKA-12264) JMH BaseRecordBatchBenchmark ZSTD error

2021-02-04 Thread Jeff Kim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Kim updated KAFKA-12264: - Description: Classes that extend BaseRecordBatchBenchmark cannot run with (compression type = ZSTD,

[jira] [Updated] (KAFKA-12184) Once the Error Classification is better update the default streams uncaught exception handler to replace threads

2021-02-04 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-12184: -- Fix Version/s: (was: 3.0.0) > Once the Error Classification is better update the default

[GitHub] [kafka] hachikuji commented on a change in pull request #10005: MINOR: Add ConfigRepository, use in Partition and KafkaApis

2021-02-04 Thread GitBox
hachikuji commented on a change in pull request #10005: URL: https://github.com/apache/kafka/pull/10005#discussion_r570404954 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1881,7 +1884,11 @@ class ReplicaManager(val config: KafkaConfig,

[GitHub] [kafka] kkonstantine merged pull request #9867: KAFKA-10835: Replace Runnable and Callable overrides with lambdas in Connect

2021-02-04 Thread GitBox
kkonstantine merged pull request #9867: URL: https://github.com/apache/kafka/pull/9867 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] abbccdda commented on a change in pull request #9579: KAFKA-9751: Forward CreateTopicsRequest for FindCoordinator/Metadata when topic creation is needed

2021-02-04 Thread GitBox
abbccdda commented on a change in pull request #9579: URL: https://github.com/apache/kafka/pull/9579#discussion_r570396673 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1113,82 +1097,36 @@ class KafkaApis(val requestChannel: RequestChannel,

[GitHub] [kafka] jsancio commented on a change in pull request #10030: MINOR: Add KafkaEventQueue

2021-02-04 Thread GitBox
jsancio commented on a change in pull request #10030: URL: https://github.com/apache/kafka/pull/10030#discussion_r570367570 ## File path: metadata/src/main/java/org/apache/kafka/queue/KafkaEventQueue.java ## @@ -0,0 +1,420 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Created] (KAFKA-12290) Adding a new topic or removing an existing topic to/from --whitelist in mirrormaker config file stops all replication

2021-02-04 Thread Chris Cairns (Jira)
Chris Cairns created KAFKA-12290: Summary: Adding a new topic or removing an existing topic to/from --whitelist in mirrormaker config file stops all replication Key: KAFKA-12290 URL:

[GitHub] [kafka] vamossagar12 commented on pull request #10051: Adding documentation for KIP-614

2021-02-04 Thread GitBox
vamossagar12 commented on pull request #10051: URL: https://github.com/apache/kafka/pull/10051#issuecomment-773415951 done. This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] rondagostino commented on a change in pull request #10005: MINOR: Add ConfigRepository, use in Partition and KafkaApis

2021-02-04 Thread GitBox
rondagostino commented on a change in pull request #10005: URL: https://github.com/apache/kafka/pull/10005#discussion_r570342092 ## File path: core/src/main/scala/kafka/server/KafkaServer.scala ## @@ -348,15 +348,15 @@ class KafkaServer( /* start processing requests

[GitHub] [kafka] rondagostino commented on a change in pull request #10005: MINOR: Add ConfigRepository, use in Partition and KafkaApis

2021-02-04 Thread GitBox
rondagostino commented on a change in pull request #10005: URL: https://github.com/apache/kafka/pull/10005#discussion_r570326339 ## File path: core/src/main/scala/kafka/server/KafkaServer.scala ## @@ -348,15 +348,15 @@ class KafkaServer( /* start processing requests

[jira] [Updated] (KAFKA-12193) Re-resolve IPs when a client is disconnected

2021-02-04 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-12193: Fix Version/s: 2.7.1 > Re-resolve IPs when a client is disconnected >

[GitHub] [kafka] dajac commented on pull request #9902: KAFKA-12193: Re-resolve IPs after a client disconnects

2021-02-04 Thread GitBox
dajac commented on pull request #9902: URL: https://github.com/apache/kafka/pull/9902#issuecomment-773366825 I have picked the commit into 2.7 but could not pick it into 2.6 cleanly. @bob-barrett Could you open a PR for 2.6?

[jira] [Commented] (KAFKA-9527) Application Reset Tool Returns NPE when --to-datetime or --by-duration are run on --input-topics with empty partitions

2021-02-04 Thread Marco Lotz (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17278849#comment-17278849 ] Marco Lotz commented on KAFKA-9527: --- PR ready. Please let me know your thoughts and what needs changing

[jira] [Assigned] (KAFKA-9527) Application Reset Tool Returns NPE when --to-datetime or --by-duration are run on --input-topics with empty partitions

2021-02-04 Thread Marco Lotz (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marco Lotz reassigned KAFKA-9527: - Assignee: Marco Lotz (was: jbfletch) > Application Reset Tool Returns NPE when --to-datetime

[jira] [Commented] (KAFKA-9527) Application Reset Tool Returns NPE when --to-datetime or --by-duration are run on --input-topics with empty partitions

2021-02-04 Thread Marco Lotz (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17278825#comment-17278825 ] Marco Lotz commented on KAFKA-9527: --- [~jeqo] Understood. About returning the latest offset - if we

[GitHub] [kafka] cadonna commented on a change in pull request #10052: KAFKA-12289: Adding test cases for prefix scan in InMemoryKeyValueStore

2021-02-04 Thread GitBox
cadonna commented on a change in pull request #10052: URL: https://github.com/apache/kafka/pull/10052#discussion_r570207387 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/InMemoryKeyValueStoreTest.java ## @@ -60,4 +67,22 @@ public void

[GitHub] [kafka] omkreddy commented on a change in pull request #10002: MINOR: remove the indent in security doc

2021-02-04 Thread GitBox
omkreddy commented on a change in pull request #10002: URL: https://github.com/apache/kafka/pull/10002#discussion_r570196800 ## File path: docs/security.html ## @@ -320,10 +320,10 @@ SSL key and certificates in PEM format listeners If SSL is not

[GitHub] [kafka] tang7526 commented on a change in pull request #10012: MINOR: Refactor return statement and log info

2021-02-04 Thread GitBox
tang7526 commented on a change in pull request #10012: URL: https://github.com/apache/kafka/pull/10012#discussion_r570185975 ## File path: clients/src/main/java/org/apache/kafka/common/utils/StringUtils.java ## @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] tang7526 commented on a change in pull request #10012: MINOR: Refactor return statement and log info

2021-02-04 Thread GitBox
tang7526 commented on a change in pull request #10012: URL: https://github.com/apache/kafka/pull/10012#discussion_r570185975 ## File path: clients/src/main/java/org/apache/kafka/common/utils/StringUtils.java ## @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] tang7526 closed pull request #10012: MINOR: Refactor return statement and log info

2021-02-04 Thread GitBox
tang7526 closed pull request #10012: URL: https://github.com/apache/kafka/pull/10012 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] vamossagar12 commented on a change in pull request #10052: KAFKA-12289: Adding test cases for prefix scan in InMemoryKeyValueStore

2021-02-04 Thread GitBox
vamossagar12 commented on a change in pull request #10052: URL: https://github.com/apache/kafka/pull/10052#discussion_r570171267 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/InMemoryKeyValueStoreTest.java ## @@ -60,4 +67,22 @@ public void

[GitHub] [kafka] tombentley commented on a change in pull request #10004: MINOR : add memberId to JoinGroup Success message

2021-02-04 Thread GitBox
tombentley commented on a change in pull request #10004: URL: https://github.com/apache/kafka/pull/10004#discussion_r570162199 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java ## @@ -591,7 +591,7 @@ public void

[GitHub] [kafka] tombentley commented on a change in pull request #10012: MINOR: Refactor return statement and log info

2021-02-04 Thread GitBox
tombentley commented on a change in pull request #10012: URL: https://github.com/apache/kafka/pull/10012#discussion_r570158748 ## File path: clients/src/main/java/org/apache/kafka/common/utils/StringUtils.java ## @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software

[jira] [Resolved] (KAFKA-12193) Re-resolve IPs when a client is disconnected

2021-02-04 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-12193. Fix Version/s: 2.8.0 Resolution: Fixed > Re-resolve IPs when a client is

[GitHub] [kafka] mimaison merged pull request #9902: KAFKA-12193: Re-resolve IPs after a client disconnects

2021-02-04 Thread GitBox
mimaison merged pull request #9902: URL: https://github.com/apache/kafka/pull/9902 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] vamossagar12 commented on a change in pull request #9508: KAFKA-10648: Add Prefix Scan support to State Stores

2021-02-04 Thread GitBox
vamossagar12 commented on a change in pull request #9508: URL: https://github.com/apache/kafka/pull/9508#discussion_r570157727 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/CachingKeyValueStore.java ## @@ -291,6 +292,16 @@ public void

[GitHub] [kafka] mimaison commented on pull request #9902: KAFKA-12193: Re-resolve IPs after a client disconnects

2021-02-04 Thread GitBox
mimaison commented on pull request #9902: URL: https://github.com/apache/kafka/pull/9902#issuecomment-773243982 Tests passed on JDK 8. The failure on JDK 11 (`kafka.api.TransactionsTest.testAbortTransactionTimeout()`) looks unrelated.

[GitHub] [kafka] vamossagar12 commented on a change in pull request #9508: KAFKA-10648: Add Prefix Scan support to State Stores

2021-02-04 Thread GitBox
vamossagar12 commented on a change in pull request #9508: URL: https://github.com/apache/kafka/pull/9508#discussion_r570153122 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/InMemoryKeyValueStore.java ## @@ -103,6 +105,20 @@ public void

[GitHub] [kafka] vamossagar12 opened a new pull request #10052: KAFKA-12289: Adding test cases for prefix scan in InMemoryKeyValueStore

2021-02-04 Thread GitBox
vamossagar12 opened a new pull request #10052: URL: https://github.com/apache/kafka/pull/10052 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

[GitHub] [kafka] cadonna commented on a change in pull request #10051: Adding documentation for KIP-614

2021-02-04 Thread GitBox
cadonna commented on a change in pull request #10051: URL: https://github.com/apache/kafka/pull/10051#discussion_r570139416 ## File path: docs/streams/upgrade-guide.html ## @@ -154,6 +154,14 @@ Streams API turn on all higher levels, ie INFO and DEBUG. See

[jira] [Updated] (KAFKA-12289) Add Tests for prefixScan in InMemoryKeyValueStore

2021-02-04 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sagar Rao updated KAFKA-12289: -- Description: While reviewing, kIP-614, a comment was added to add a test  that directly tests the

[jira] [Assigned] (KAFKA-12289) Add Tests for prefixScan in InMemoryKeyValueStore

2021-02-04 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sagar Rao reassigned KAFKA-12289: - Assignee: Sagar Rao (was: Rohit Deshpande) > Add Tests for prefixScan in

[jira] [Created] (KAFKA-12289) Add Tests for prefixScan in InMemoryKeyValueStore

2021-02-04 Thread Sagar Rao (Jira)
Sagar Rao created KAFKA-12289: - Summary: Add Tests for prefixScan in InMemoryKeyValueStore Key: KAFKA-12289 URL: https://issues.apache.org/jira/browse/KAFKA-12289 Project: Kafka Issue Type:

[GitHub] [kafka] vamossagar12 commented on pull request #9756: KAFKA-10652: Adding size based linger semnatics to Raft metadata

2021-02-04 Thread GitBox
vamossagar12 commented on pull request #9756: URL: https://github.com/apache/kafka/pull/9756#issuecomment-773204238 @hachikuji did you get a chance to review this? This is an automated message from the Apache Git Service. To

[GitHub] [kafka] bob-barrett commented on a change in pull request #9902: KAFKA-12193: Re-resolve IPs after a client disconnects

2021-02-04 Thread GitBox
bob-barrett commented on a change in pull request #9902: URL: https://github.com/apache/kafka/pull/9902#discussion_r570072638 ## File path: clients/src/test/java/org/apache/kafka/clients/NetworkClientTest.java ## @@ -81,6 +85,19 @@ private final NetworkClient

[jira] [Commented] (KAFKA-12264) JMH BaseRecordBatchBenchmark ZSTD error

2021-02-04 Thread Jeff Kim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17278737#comment-17278737 ] Jeff Kim commented on KAFKA-12264: -- [~chia7712] yes, and a separate subclass to run specifically ZSTD +

[jira] [Commented] (KAFKA-12263) Improve MockClient RequestMatcher interface

2021-02-04 Thread Tom Bentley (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17278735#comment-17278735 ] Tom Bentley commented on KAFKA-12263: - [~hachikuji] any chance you could review my PR? > Improve

[GitHub] [kafka] tombentley commented on pull request #9972: KAFKA-8779: Reintroduce flaky tests

2021-02-04 Thread GitBox
tombentley commented on pull request #9972: URL: https://github.com/apache/kafka/pull/9972#issuecomment-773183761 Rebased to trigger CI again. @chia7712 please could to take another look when you have the chance? This

[GitHub] [kafka] vamossagar12 commented on pull request #9508: KAFKA-10648: Add Prefix Scan support to State Stores

2021-02-04 Thread GitBox
vamossagar12 commented on pull request #9508: URL: https://github.com/apache/kafka/pull/9508#issuecomment-773181642 Thanks @guozhangwang ! @cadonna I have added the doc here in this PR: https://github.com/apache/kafka/pull/10051. I will create a separate. ticket for the missing test

[GitHub] [kafka] vamossagar12 opened a new pull request #10051: Adding documentation for KIP-614

2021-02-04 Thread GitBox
vamossagar12 opened a new pull request #10051: URL: https://github.com/apache/kafka/pull/10051 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

[jira] [Commented] (KAFKA-12264) JMH BaseRecordBatchBenchmark ZSTD error

2021-02-04 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17278720#comment-17278720 ] Chia-Ping Tsai commented on KAFKA-12264: How about making sub classes offer messageVersion?

[GitHub] [kafka] bob-barrett commented on pull request #9902: KAFKA-12193: Re-resolve IPs after a client disconnects

2021-02-04 Thread GitBox
bob-barrett commented on pull request #9902: URL: https://github.com/apache/kafka/pull/9902#issuecomment-773171300 @dajac @mimaison @satishd Thanks for your reviews! In addition to PR feedback, I pushed a new change to `ClusterConnectionStatesTest`. I noticed while testing locally

[GitHub] [kafka] bob-barrett commented on a change in pull request #9902: KAFKA-12193: Re-resolve IPs after a client disconnects

2021-02-04 Thread GitBox
bob-barrett commented on a change in pull request #9902: URL: https://github.com/apache/kafka/pull/9902#discussion_r570072638 ## File path: clients/src/test/java/org/apache/kafka/clients/NetworkClientTest.java ## @@ -81,6 +85,19 @@ private final NetworkClient

[jira] [Updated] (KAFKA-12257) Consumer mishandles topics deleted and recreated with the same name

2021-02-04 Thread lqjacklee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lqjacklee updated KAFKA-12257: -- Attachment: KAFKA-12257-1.patch > Consumer mishandles topics deleted and recreated with the same

[jira] [Commented] (KAFKA-12286) Consider storage/cpu tradeoff in metadata record framing schema

2021-02-04 Thread Tom Bentley (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17278673#comment-17278673 ] Tom Bentley commented on KAFKA-12286: - {quote}we will have options to deal with it if it

<    1   2