[jira] [Updated] (KAFKA-12273) InterBrokerSendThread#pollOnce throws FatalExitError even though it is shutdown correctly

2021-02-16 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-12273: --- Fix Version/s: 2.8.0 > InterBrokerSendThread#pollOnce throws FatalExitError even though it

[GitHub] [kafka] chia7712 commented on pull request #10124: MINOR: apply Utils.isBlank to code base

2021-02-16 Thread GitBox
chia7712 commented on pull request #10124: URL: https://github.com/apache/kafka/pull/10124#issuecomment-780347504 @tang7526 Thanks for your patch. Could you fix following code also? 1.

[GitHub] [kafka] cadonna commented on a change in pull request #10052: KAFKA-12289: Adding test cases for prefix scan in InMemoryKeyValueStore

2021-02-16 Thread GitBox
cadonna commented on a change in pull request #10052: URL: https://github.com/apache/kafka/pull/10052#discussion_r577363631 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/InMemoryKeyValueStoreTest.java ## @@ -60,4 +67,22 @@ public void

[GitHub] [kafka] vamossagar12 commented on a change in pull request #10052: KAFKA-12289: Adding test cases for prefix scan in InMemoryKeyValueStore

2021-02-16 Thread GitBox
vamossagar12 commented on a change in pull request #10052: URL: https://github.com/apache/kafka/pull/10052#discussion_r577363103 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/InMemoryKeyValueStoreTest.java ## @@ -60,4 +67,22 @@ public void

[GitHub] [kafka] vamossagar12 commented on a change in pull request #10052: KAFKA-12289: Adding test cases for prefix scan in InMemoryKeyValueStore

2021-02-16 Thread GitBox
vamossagar12 commented on a change in pull request #10052: URL: https://github.com/apache/kafka/pull/10052#discussion_r577360887 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/InMemoryKeyValueStoreTest.java ## @@ -60,4 +67,22 @@ public void

[GitHub] [kafka] ijuma commented on pull request #10123: KAFKA-12327: Remove MethodHandle usage in CompressionType

2021-02-16 Thread GitBox
ijuma commented on pull request #10123: URL: https://github.com/apache/kafka/pull/10123#issuecomment-780326554 I'm not sure it's worth it since the cost of compressing on the broker during fetches is significantly higher than compressing during produce (the data is already on the heap for

[GitHub] [kafka] kamalcph opened a new pull request #10139: MINOR: Print the warning log before truncation.

2021-02-16 Thread GitBox
kamalcph opened a new pull request #10139: URL: https://github.com/apache/kafka/pull/10139 - After truncation, hw can be moved to the truncation offset. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and

[GitHub] [kafka] jsancio opened a new pull request #10138: KAFKA-12331: Use LEO for the base offset of LeaderChangeMessage batch

2021-02-16 Thread GitBox
jsancio opened a new pull request #10138: URL: https://github.com/apache/kafka/pull/10138 WIP *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.*

[GitHub] [kafka] chia7712 commented on pull request #9906: KAFKA-10885 Refactor MemoryRecordsBuilderTest/MemoryRecordsTest to avoid a lot of…

2021-02-16 Thread GitBox
chia7712 commented on pull request #9906: URL: https://github.com/apache/kafka/pull/9906#issuecomment-780309024 @g1geordie Thanks for your updating. I will merge it tomorrow :) This is an automated message from the Apache

[GitHub] [kafka] vvcephei commented on a change in pull request #10137: KAFKA-12268: Implement task idling semantics via currentLag API

2021-02-16 Thread GitBox
vvcephei commented on a change in pull request #10137: URL: https://github.com/apache/kafka/pull/10137#discussion_r577333186 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/Consumer.java ## @@ -243,6 +244,11 @@ */ Map endOffsets(Collection

[GitHub] [kafka] chia7712 commented on a change in pull request #10137: KAFKA-12268: Implement task idling semantics via currentLag API

2021-02-16 Thread GitBox
chia7712 commented on a change in pull request #10137: URL: https://github.com/apache/kafka/pull/10137#discussion_r577332179 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/Consumer.java ## @@ -243,6 +244,11 @@ */ Map endOffsets(Collection

[GitHub] [kafka] chia7712 commented on pull request #10123: KAFKA-12327: Remove MethodHandle usage in CompressionType

2021-02-16 Thread GitBox
chia7712 commented on pull request #10123: URL: https://github.com/apache/kafka/pull/10123#issuecomment-780303685 > Today, the solution would be to either: Include the relevant native compression libraries Limit topic data to the compression algorithms supported on the relevant

[GitHub] [kafka] vvcephei opened a new pull request #10137: KAFKA-12268: Implement task idling semantics via currentLag API

2021-02-16 Thread GitBox
vvcephei opened a new pull request #10137: URL: https://github.com/apache/kafka/pull/10137 Implements KIP-695 Reverts a previous behavior change to Consumer.poll and replaces it with a new Consumer.currentLag API, which returns the client's currently cached lag. Uses

[GitHub] [kafka] abbccdda commented on a change in pull request #10135: KAFKA-10348: Share client channel between forwarding and auto creation manager

2021-02-16 Thread GitBox
abbccdda commented on a change in pull request #10135: URL: https://github.com/apache/kafka/pull/10135#discussion_r577322703 ## File path: core/src/main/scala/kafka/server/KafkaServer.scala ## @@ -134,6 +134,8 @@ class KafkaServer( var autoTopicCreationManager:

[GitHub] [kafka] chia7712 commented on pull request #10130: MINOR: Fix typo in MirrorMaker

2021-02-16 Thread GitBox
chia7712 commented on pull request #10130: URL: https://github.com/apache/kafka/pull/10130#issuecomment-780286687 @runom Thanks for your patch :) This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] chia7712 merged pull request #10130: MINOR: Fix typo in MirrorMaker

2021-02-16 Thread GitBox
chia7712 merged pull request #10130: URL: https://github.com/apache/kafka/pull/10130 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] chia7712 commented on pull request #10130: MINOR: Fix typo in MirrorMaker

2021-02-16 Thread GitBox
chia7712 commented on pull request #10130: URL: https://github.com/apache/kafka/pull/10130#issuecomment-780286136 the error is traced by #10024 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] chia7712 merged pull request #10082: MINOR: use 'mapKey' to avoid unnecessary grouped data

2021-02-16 Thread GitBox
chia7712 merged pull request #10082: URL: https://github.com/apache/kafka/pull/10082 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] dengziming commented on a change in pull request #10135: KAFKA-10348: Share client channel between forwarding and auto creation manager

2021-02-16 Thread GitBox
dengziming commented on a change in pull request #10135: URL: https://github.com/apache/kafka/pull/10135#discussion_r577312082 ## File path: core/src/main/scala/kafka/server/KafkaServer.scala ## @@ -134,6 +134,8 @@ class KafkaServer( var autoTopicCreationManager:

[GitHub] [kafka] chia7712 commented on pull request #10082: MINOR: use 'mapKey' to avoid unnecessary grouped data

2021-02-16 Thread GitBox
chia7712 commented on pull request #10082: URL: https://github.com/apache/kafka/pull/10082#issuecomment-780282255 the error is traced by #10024 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] chia7712 commented on pull request #10082: MINOR: use 'mapKey' to avoid unnecessary grouped data

2021-02-16 Thread GitBox
chia7712 commented on pull request #10082: URL: https://github.com/apache/kafka/pull/10082#issuecomment-780282166 > Looks like ConsumerProtocolAssignment was also changed to have mapKey, so worth updating the PR to include that information. done

[GitHub] [kafka] dengziming opened a new pull request #10136: MONOR: Import classes that is used is docs to fix warnings.

2021-02-16 Thread GitBox
dengziming opened a new pull request #10136: URL: https://github.com/apache/kafka/pull/10136 *More detailed description of your change* Fix this: ![image](https://user-images.githubusercontent.com/26023240/108154064-43c36f00-7117-11eb-80dc-e62db0bac081.png) *Summary of

[jira] [Assigned] (KAFKA-12331) KafkaRaftClient should use the LEO when appending LeaderChangeMessage

2021-02-16 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson reassigned KAFKA-12331: --- Assignee: Jose Armando Garcia Sancio > KafkaRaftClient should use the LEO when

[jira] [Updated] (KAFKA-12331) KafkaRaftClient should use the LEO when appending LeaderChangeMessage

2021-02-16 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-12331: --- Description: KafkaMetadataLog's appendAsLeader expects the base

[jira] [Created] (KAFKA-12331) KafkaRaftClient should use the LEO when appending LeaderChangeMessage

2021-02-16 Thread Jose Armando Garcia Sancio (Jira)
Jose Armando Garcia Sancio created KAFKA-12331: -- Summary: KafkaRaftClient should use the LEO when appending LeaderChangeMessage Key: KAFKA-12331 URL: https://issues.apache.org/jira/browse/KAFKA-12331

[GitHub] [kafka] abbccdda opened a new pull request #10135: KAFKA-10348: Share client channel between forwarding and auto creation manager

2021-02-16 Thread GitBox
abbccdda opened a new pull request #10135: URL: https://github.com/apache/kafka/pull/10135 We want to consolidate forwarding and auto creation channel into one channel to reduce the unnecessary connections maintained between brokers and controller. ### Committer Checklist (excluded

[GitHub] [kafka] junrao commented on a change in pull request #10070: KAFKA-12276: Add the quorum controller code

2021-02-16 Thread GitBox
junrao commented on a change in pull request #10070: URL: https://github.com/apache/kafka/pull/10070#discussion_r577278241 ## File path: metadata/src/main/java/org/apache/kafka/controller/QuorumController.java ## @@ -0,0 +1,920 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] junrao commented on a change in pull request #10070: KAFKA-12276: Add the quorum controller code

2021-02-16 Thread GitBox
junrao commented on a change in pull request #10070: URL: https://github.com/apache/kafka/pull/10070#discussion_r577268593 ## File path: metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java ## @@ -0,0 +1,456 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] junrao commented on a change in pull request #10070: KAFKA-12276: Add the quorum controller code

2021-02-16 Thread GitBox
junrao commented on a change in pull request #10070: URL: https://github.com/apache/kafka/pull/10070#discussion_r577263866 ## File path: metadata/src/main/java/org/apache/kafka/controller/QuorumController.java ## @@ -0,0 +1,920 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] junrao commented on a change in pull request #10070: KAFKA-12276: Add the quorum controller code

2021-02-16 Thread GitBox
junrao commented on a change in pull request #10070: URL: https://github.com/apache/kafka/pull/10070#discussion_r577262652 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -0,0 +1,712 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] junrao commented on a change in pull request #10070: KAFKA-12276: Add the quorum controller code

2021-02-16 Thread GitBox
junrao commented on a change in pull request #10070: URL: https://github.com/apache/kafka/pull/10070#discussion_r577259797 ## File path: metadata/src/main/java/org/apache/kafka/controller/QuorumController.java ## @@ -0,0 +1,920 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] mjsax commented on pull request #9670: MINOR: Clarify config names for EOS versions 1 and 2

2021-02-16 Thread GitBox
mjsax commented on pull request #9670: URL: https://github.com/apache/kafka/pull/9670#issuecomment-780225430 Thanks @JimGalasyn! Merged to `trunk` and cherry-picked to `2.8`, `2.7`, and `2.6` branches. This is an automated

[GitHub] [kafka] mjsax merged pull request #9670: MINOR: Clarify config names for EOS versions 1 and 2

2021-02-16 Thread GitBox
mjsax merged pull request #9670: URL: https://github.com/apache/kafka/pull/9670 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (KAFKA-12328) Find out partition of a store iterator

2021-02-16 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17285569#comment-17285569 ] Matthias J. Sax commented on KAFKA-12328: - You should be able to use `ProcessorContext.taskId()`

[jira] [Updated] (KAFKA-12328) Find out partition of a store iterator

2021-02-16 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-12328: Component/s: streams > Find out partition of a store iterator >

[GitHub] [kafka] mjsax opened a new pull request #10134: TRIVIAL: fix JavaDocs formatting

2021-02-16 Thread GitBox
mjsax opened a new pull request #10134: URL: https://github.com/apache/kafka/pull/10134 Should be cherry-picked to `2.8` branch. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] hachikuji commented on a change in pull request #10063: KAFKA-12258: Add support for splitting appending records

2021-02-16 Thread GitBox
hachikuji commented on a change in pull request #10063: URL: https://github.com/apache/kafka/pull/10063#discussion_r577225891 ## File path: raft/src/main/java/org/apache/kafka/raft/internals/BatchAccumulator.java ## @@ -79,67 +80,110 @@ public BatchAccumulator( }

[GitHub] [kafka] hachikuji commented on a change in pull request #10063: KAFKA-12258: Add support for splitting appending records

2021-02-16 Thread GitBox
hachikuji commented on a change in pull request #10063: URL: https://github.com/apache/kafka/pull/10063#discussion_r577216920 ## File path: raft/src/main/java/org/apache/kafka/raft/RaftClient.java ## @@ -77,6 +79,29 @@ default void handleResign() {} */ void

[GitHub] [kafka] cmccabe commented on a change in pull request #10070: KAFKA-12276: Add the quorum controller code

2021-02-16 Thread GitBox
cmccabe commented on a change in pull request #10070: URL: https://github.com/apache/kafka/pull/10070#discussion_r577217605 ## File path: metadata/src/main/java/org/apache/kafka/controller/QuorumController.java ## @@ -0,0 +1,920 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] cmccabe commented on a change in pull request #10070: KAFKA-12276: Add the quorum controller code

2021-02-16 Thread GitBox
cmccabe commented on a change in pull request #10070: URL: https://github.com/apache/kafka/pull/10070#discussion_r577214559 ## File path: metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java ## @@ -0,0 +1,456 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] hachikuji merged pull request #10133: MINOR: Update raft README and add a more specific error message.

2021-02-16 Thread GitBox
hachikuji merged pull request #10133: URL: https://github.com/apache/kafka/pull/10133 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (KAFKA-12241) Partition offline when ISR shrinks to leader and LogDir goes offline

2021-02-16 Thread Ajay Patel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17285537#comment-17285537 ] Ajay Patel commented on KAFKA-12241: We have a different trigger for the ISR shrinkage, but the same

[GitHub] [kafka] cmccabe commented on a change in pull request #10070: KAFKA-12276: Add the quorum controller code

2021-02-16 Thread GitBox
cmccabe commented on a change in pull request #10070: URL: https://github.com/apache/kafka/pull/10070#discussion_r577188202 ## File path: metadata/src/main/java/org/apache/kafka/controller/QuorumController.java ## @@ -0,0 +1,920 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] cmccabe commented on a change in pull request #10070: KAFKA-12276: Add the quorum controller code

2021-02-16 Thread GitBox
cmccabe commented on a change in pull request #10070: URL: https://github.com/apache/kafka/pull/10070#discussion_r577187004 ## File path: metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java ## @@ -0,0 +1,456 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] cmccabe commented on a change in pull request #10070: KAFKA-12276: Add the quorum controller code

2021-02-16 Thread GitBox
cmccabe commented on a change in pull request #10070: URL: https://github.com/apache/kafka/pull/10070#discussion_r577187004 ## File path: metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java ## @@ -0,0 +1,456 @@ +/* + * Licensed to the Apache Software

[jira] [Updated] (KAFKA-12330) FetchSessionCache may cause starvation for partitions when FetchResponse is full

2021-02-16 Thread Lucas Bradstreet (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Bradstreet updated KAFKA-12330: - Description: The incremental FetchSessionCache sessions deprioritizes partitions where

[GitHub] [kafka] cmccabe commented on a change in pull request #10070: KAFKA-12276: Add the quorum controller code

2021-02-16 Thread GitBox
cmccabe commented on a change in pull request #10070: URL: https://github.com/apache/kafka/pull/10070#discussion_r577178197 ## File path: metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java ## @@ -0,0 +1,456 @@ +/* + * Licensed to the Apache Software

[jira] [Updated] (KAFKA-12330) FetchSessionCache may cause starvation for partitions when FetchResponse is full

2021-02-16 Thread Lucas Bradstreet (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Bradstreet updated KAFKA-12330: - Description: The incremental FetchSessionCache sessions deprioritizes partitions where

[jira] [Updated] (KAFKA-12330) FetchSessionCache may cause starvation for partitions when FetchResponse is full

2021-02-16 Thread Lucas Bradstreet (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Bradstreet updated KAFKA-12330: - Description: The incremental FetchSessionCache sessions deprioritizes partitions where

[GitHub] [kafka] cmccabe commented on a change in pull request #10070: KAFKA-12276: Add the quorum controller code

2021-02-16 Thread GitBox
cmccabe commented on a change in pull request #10070: URL: https://github.com/apache/kafka/pull/10070#discussion_r577176042 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -0,0 +1,712 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] cmccabe commented on a change in pull request #10070: KAFKA-12276: Add the quorum controller code

2021-02-16 Thread GitBox
cmccabe commented on a change in pull request #10070: URL: https://github.com/apache/kafka/pull/10070#discussion_r577176042 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -0,0 +1,712 @@ +/* + * Licensed to the Apache

[jira] [Created] (KAFKA-12330) FetchSessionCache may cause starvation for partitions when FetchResponse is full

2021-02-16 Thread Lucas Bradstreet (Jira)
Lucas Bradstreet created KAFKA-12330: Summary: FetchSessionCache may cause starvation for partitions when FetchResponse is full Key: KAFKA-12330 URL: https://issues.apache.org/jira/browse/KAFKA-12330

[GitHub] [kafka] cmccabe commented on a change in pull request #10070: KAFKA-12276: Add the quorum controller code

2021-02-16 Thread GitBox
cmccabe commented on a change in pull request #10070: URL: https://github.com/apache/kafka/pull/10070#discussion_r577167941 ## File path: metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java ## @@ -0,0 +1,367 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] cmccabe commented on a change in pull request #10070: KAFKA-12276: Add the quorum controller code

2021-02-16 Thread GitBox
cmccabe commented on a change in pull request #10070: URL: https://github.com/apache/kafka/pull/10070#discussion_r577167409 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -0,0 +1,712 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] cmccabe commented on a change in pull request #10070: KAFKA-12276: Add the quorum controller code

2021-02-16 Thread GitBox
cmccabe commented on a change in pull request #10070: URL: https://github.com/apache/kafka/pull/10070#discussion_r577163457 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -0,0 +1,712 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] rondagostino commented on a change in pull request #10070: KAFKA-12276: Add the quorum controller code

2021-02-16 Thread GitBox
rondagostino commented on a change in pull request #10070: URL: https://github.com/apache/kafka/pull/10070#discussion_r577148212 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -0,0 +1,712 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] cmccabe commented on a change in pull request #10070: KAFKA-12276: Add the quorum controller code

2021-02-16 Thread GitBox
cmccabe commented on a change in pull request #10070: URL: https://github.com/apache/kafka/pull/10070#discussion_r577117523 ## File path: metadata/src/main/java/org/apache/kafka/metalog/LocalLogManager.java ## @@ -0,0 +1,379 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] cmccabe commented on a change in pull request #10070: KAFKA-12276: Add the quorum controller code

2021-02-16 Thread GitBox
cmccabe commented on a change in pull request #10070: URL: https://github.com/apache/kafka/pull/10070#discussion_r577117523 ## File path: metadata/src/main/java/org/apache/kafka/metalog/LocalLogManager.java ## @@ -0,0 +1,379 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] cmccabe commented on a change in pull request #10070: KAFKA-12276: Add the quorum controller code

2021-02-16 Thread GitBox
cmccabe commented on a change in pull request #10070: URL: https://github.com/apache/kafka/pull/10070#discussion_r577148107 ## File path: metadata/src/main/java/org/apache/kafka/controller/QuorumController.java ## @@ -0,0 +1,920 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] cmccabe commented on a change in pull request #10070: KAFKA-12276: Add the quorum controller code

2021-02-16 Thread GitBox
cmccabe commented on a change in pull request #10070: URL: https://github.com/apache/kafka/pull/10070#discussion_r577143791 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -0,0 +1,712 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] cmccabe commented on a change in pull request #10070: KAFKA-12276: Add the quorum controller code

2021-02-16 Thread GitBox
cmccabe commented on a change in pull request #10070: URL: https://github.com/apache/kafka/pull/10070#discussion_r577146421 ## File path: metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java ## @@ -0,0 +1,456 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] cmccabe commented on a change in pull request #10070: KAFKA-12276: Add the quorum controller code

2021-02-16 Thread GitBox
cmccabe commented on a change in pull request #10070: URL: https://github.com/apache/kafka/pull/10070#discussion_r577143791 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -0,0 +1,712 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] jolshan opened a new pull request #10133: MINOR: Update raft README and add a more specific error message.

2021-02-16 Thread GitBox
jolshan opened a new pull request #10133: URL: https://github.com/apache/kafka/pull/10133 `test-raft-server-start.sh` requires the config to be specified with `--config`. I've included this in the README and added an error message for this specific case. ### Committer Checklist

[GitHub] [kafka] ableegoldman commented on a change in pull request #10052: KAFKA-12289: Adding test cases for prefix scan in InMemoryKeyValueStore

2021-02-16 Thread GitBox
ableegoldman commented on a change in pull request #10052: URL: https://github.com/apache/kafka/pull/10052#discussion_r577140223 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/InMemoryKeyValueStoreTest.java ## @@ -60,4 +67,22 @@ public void

[GitHub] [kafka] cmccabe commented on a change in pull request #10070: KAFKA-12276: Add the quorum controller code

2021-02-16 Thread GitBox
cmccabe commented on a change in pull request #10070: URL: https://github.com/apache/kafka/pull/10070#discussion_r577136289 ## File path: metadata/src/main/java/org/apache/kafka/controller/QuorumController.java ## @@ -0,0 +1,920 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] cmccabe commented on a change in pull request #10070: KAFKA-12276: Add the quorum controller code

2021-02-16 Thread GitBox
cmccabe commented on a change in pull request #10070: URL: https://github.com/apache/kafka/pull/10070#discussion_r577135430 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -0,0 +1,712 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] cmccabe commented on a change in pull request #10070: KAFKA-12276: Add the quorum controller code

2021-02-16 Thread GitBox
cmccabe commented on a change in pull request #10070: URL: https://github.com/apache/kafka/pull/10070#discussion_r577127231 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -0,0 +1,712 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] cmccabe commented on a change in pull request #10070: KAFKA-12276: Add the quorum controller code

2021-02-16 Thread GitBox
cmccabe commented on a change in pull request #10070: URL: https://github.com/apache/kafka/pull/10070#discussion_r577125115 ## File path: metadata/src/main/java/org/apache/kafka/controller/QuorumController.java ## @@ -0,0 +1,920 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] cmccabe commented on a change in pull request #10070: KAFKA-12276: Add the quorum controller code

2021-02-16 Thread GitBox
cmccabe commented on a change in pull request #10070: URL: https://github.com/apache/kafka/pull/10070#discussion_r577117523 ## File path: metadata/src/main/java/org/apache/kafka/metalog/LocalLogManager.java ## @@ -0,0 +1,379 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] JimGalasyn commented on pull request #9670: DOCS-6076: Clarify config names for EOS versions 1 and 2

2021-02-16 Thread GitBox
JimGalasyn commented on pull request #9670: URL: https://github.com/apache/kafka/pull/9670#issuecomment-780061593 @abbccdda @mjsax Is this ready to merge? This is an automated message from the Apache Git Service. To respond

[jira] [Comment Edited] (KAFKA-10888) Sticky partition leads to uneven product msg, resulting in abnormal delays in some partations

2021-02-16 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17285383#comment-17285383 ] Jason Gustafson edited comment on KAFKA-10888 at 2/16/21, 6:09 PM: --- We

[jira] [Commented] (KAFKA-10888) Sticky partition leads to uneven product msg, resulting in abnormal delays in some partations

2021-02-16 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17285383#comment-17285383 ] Jason Gustafson commented on KAFKA-10888: - We have found one cause of imbalance when the sticky

[jira] [Updated] (KAFKA-12313) Consider deprecating the default.windowed.serde.inner.class configs

2021-02-16 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-12313: -- Fix Version/s: 3.0.0 > Consider deprecating the default.windowed.serde.inner.class configs >

[GitHub] [kafka] purplefox opened a new pull request #10132: Fix ssl close

2021-02-16 Thread GitBox
purplefox opened a new pull request #10132: URL: https://github.com/apache/kafka/pull/10132 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

[jira] [Created] (KAFKA-12329) kafka-reassign-partitions command should give a better error message when a topic does not exist

2021-02-16 Thread David Jacot (Jira)
David Jacot created KAFKA-12329: --- Summary: kafka-reassign-partitions command should give a better error message when a topic does not exist Key: KAFKA-12329 URL: https://issues.apache.org/jira/browse/KAFKA-12329

[GitHub] [kafka] chia7712 merged pull request #10128: MINOR: remove duplicate code of serializing auto-generated data

2021-02-16 Thread GitBox
chia7712 merged pull request #10128: URL: https://github.com/apache/kafka/pull/10128 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] chia7712 commented on a change in pull request #10024: KAFKA-12273 InterBrokerSendThread#pollOnce throws FatalExitError even…

2021-02-16 Thread GitBox
chia7712 commented on a change in pull request #10024: URL: https://github.com/apache/kafka/pull/10024#discussion_r576927931 ## File path: core/src/main/scala/kafka/common/InterBrokerSendThread.scala ## @@ -78,6 +77,9 @@ abstract class InterBrokerSendThread(

[GitHub] [kafka] C0urante commented on pull request #10074: KAFKA-12305: Fix Flatten SMT for array types

2021-02-16 Thread GitBox
C0urante commented on pull request #10074: URL: https://github.com/apache/kafka/pull/10074#issuecomment-779866655 @gharris1727 @ncliang @tombentley anyone got time to take a look? This is an automated message from the Apache

[GitHub] [kafka] C0urante commented on pull request #10073: KAFKA-12303: Fix handling of null values by Flatten SMT

2021-02-16 Thread GitBox
C0urante commented on pull request #10073: URL: https://github.com/apache/kafka/pull/10073#issuecomment-779866596 @gharris1727 @ncliang @tombentley anyone got time to take a look? This is an automated message from the Apache

[jira] [Commented] (KAFKA-10383) KTable Join on Foreign key is opinionated

2021-02-16 Thread Marco Lotz (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17285225#comment-17285225 ] Marco Lotz commented on KAFKA-10383: [~vvcephei] I have sent the email to Kafka's dev list

[jira] [Commented] (KAFKA-3702) SslTransportLayer.close() does not shutdown gracefully

2021-02-16 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-3702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17285220#comment-17285220 ] Ismael Juma commented on KAFKA-3702: [~purplefox] it may be simplest if you submit a PR with the

[jira] [Commented] (KAFKA-3702) SslTransportLayer.close() does not shutdown gracefully

2021-02-16 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-3702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17285218#comment-17285218 ] Ismael Juma commented on KAFKA-3702: Also `isOutboundDone` says: {quote}Returns whether

[jira] [Commented] (KAFKA-3702) SslTransportLayer.close() does not shutdown gracefully

2021-02-16 Thread Tim Fox (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-3702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17285216#comment-17285216 ] Tim Fox commented on KAFKA-3702: >> A possible issue (identified by [~david.mao]) is that we don't check

[jira] [Commented] (KAFKA-3702) SslTransportLayer.close() does not shutdown gracefully

2021-02-16 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-3702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17285215#comment-17285215 ] Ismael Juma commented on KAFKA-3702: [~purplefox] The documentation for `closeOutbound` says you must

[jira] [Commented] (KAFKA-3702) SslTransportLayer.close() does not shutdown gracefully

2021-02-16 Thread Tim Fox (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-3702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17285212#comment-17285212 ] Tim Fox commented on KAFKA-3702: Maybe I am missing something but writing to the connection (via flush)

[GitHub] [kafka] MarcoLotz opened a new pull request #10131: KAFKA-5146 / move kafka-streams example to a new module

2021-02-16 Thread GitBox
MarcoLotz opened a new pull request #10131: URL: https://github.com/apache/kafka/pull/10131 Moved "streams-examples" to its own module outside kafka-streams module. Because of org.apache.kafka.streams.processor.internals.StateDirectory in kafka-streams module, I had to add the jackson

[jira] [Commented] (KAFKA-3702) SslTransportLayer.close() does not shutdown gracefully

2021-02-16 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-3702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17285199#comment-17285199 ] Ismael Juma commented on KAFKA-3702: A possible issue (identified by [~david.mao]) is that we don't

[jira] [Comment Edited] (KAFKA-5649) Producer is being closed generating ssl exception

2021-02-16 Thread Julian (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-5649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17285170#comment-17285170 ] Julian edited comment on KAFKA-5649 at 2/16/21, 12:45 PM: -- We have now moved to

[jira] [Comment Edited] (KAFKA-5649) Producer is being closed generating ssl exception

2021-02-16 Thread Julian (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-5649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17285170#comment-17285170 ] Julian edited comment on KAFKA-5649 at 2/16/21, 12:45 PM: -- We have now moved to

[GitHub] [kafka] cadonna commented on a change in pull request #10052: KAFKA-12289: Adding test cases for prefix scan in InMemoryKeyValueStore

2021-02-16 Thread GitBox
cadonna commented on a change in pull request #10052: URL: https://github.com/apache/kafka/pull/10052#discussion_r576789945 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/InMemoryKeyValueStoreTest.java ## @@ -60,4 +67,22 @@ public void

[jira] [Commented] (KAFKA-3702) SslTransportLayer.close() does not shutdown gracefully

2021-02-16 Thread Julian (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-3702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17285172#comment-17285172 ] Julian commented on KAFKA-3702: --- Hi, I came across this issue while searching in relation to the other two

[jira] [Created] (KAFKA-12328) Find out partition of a store iterator

2021-02-16 Thread fml2 (Jira)
fml2 created KAFKA-12328: Summary: Find out partition of a store iterator Key: KAFKA-12328 URL: https://issues.apache.org/jira/browse/KAFKA-12328 Project: Kafka Issue Type: Wish

[jira] [Commented] (KAFKA-5649) Producer is being closed generating ssl exception

2021-02-16 Thread Julian (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-5649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17285170#comment-17285170 ] Julian commented on KAFKA-5649: --- We have now moved to HDP 3.1.5 having spark 2.3.2 and Kafka 2+ but we are

[GitHub] [kafka] runom opened a new pull request #10130: MINOR: Fix typo in MirrorMaker

2021-02-16 Thread GitBox
runom opened a new pull request #10130: URL: https://github.com/apache/kafka/pull/10130 This PR fixes a typo. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify

[GitHub] [kafka] dajac opened a new pull request #10129: KAFKA-10817; Add clusterId validation to Fetch handling

2021-02-16 Thread GitBox
dajac opened a new pull request #10129: URL: https://github.com/apache/kafka/pull/10129 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade