[GitHub] [kafka] guozhangwang commented on pull request #10232: KAFKA-12352: Make sure all rejoin group and reset state has a reason

2021-03-05 Thread GitBox
guozhangwang commented on pull request #10232: URL: https://github.com/apache/kafka/pull/10232#issuecomment-791891198 We may reset generationa and request rejoin in two different places: 1) in join/sync-group handler, and 2) in joinGroupIfNeeded, when the future is received. The principle

[GitHub] [kafka] guozhangwang commented on a change in pull request #10232: KAFKA-12352: Make sure all rejoin group and reset state has a reason

2021-03-05 Thread GitBox
guozhangwang commented on a change in pull request #10232: URL: https://github.com/apache/kafka/pull/10232#discussion_r588847540 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java ## @@ -802,8 +801,10 @@ public void

[jira] [Updated] (KAFKA-12381) Incompatible change in verifiable_producer.log in 2.8

2021-03-05 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen updated KAFKA-12381: Fix Version/s: 2.8.0 > Incompatible change in verifiable_producer.log in 2.8 >

[jira] [Resolved] (KAFKA-12381) Incompatible change in verifiable_producer.log in 2.8

2021-03-05 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen resolved KAFKA-12381. - Resolution: Fixed > Incompatible change in verifiable_producer.log in 2.8 >

[GitHub] [kafka] guozhangwang commented on a change in pull request #10232: KAFKA-12352: Make sure all rejoin group and reset state has a reason

2021-03-05 Thread GitBox
guozhangwang commented on a change in pull request #10232: URL: https://github.com/apache/kafka/pull/10232#discussion_r588842618 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java ## @@ -775,8 +776,6 @@ public void

[GitHub] [kafka] ijuma opened a new pull request #10273: MINOR: Include number of members in group coordinator messages

2021-03-05 Thread GitBox
ijuma opened a new pull request #10273: URL: https://github.com/apache/kafka/pull/10273 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes)

[GitHub] [kafka] abbccdda commented on pull request #10240: KAFKA-12381: remove live broker checks for forwarding topic creation

2021-03-05 Thread GitBox
abbccdda commented on pull request #10240: URL: https://github.com/apache/kafka/pull/10240#issuecomment-791799082 Cherry-picked to 2.8 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] abbccdda merged pull request #10240: KAFKA-12381: remove live broker checks for forwarding topic creation

2021-03-05 Thread GitBox
abbccdda merged pull request #10240: URL: https://github.com/apache/kafka/pull/10240 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] abbccdda commented on pull request #10240: KAFKA-12381: remove live broker checks for forwarding topic creation

2021-03-05 Thread GitBox
abbccdda commented on pull request #10240: URL: https://github.com/apache/kafka/pull/10240#issuecomment-791798044 System test pass: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4419/ and only flaky tests are failing, merging

[jira] [Closed] (KAFKA-12347) Improve Kafka Streams ability to track progress

2021-03-05 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walker Carlson closed KAFKA-12347. -- > Improve Kafka Streams ability to track progress >

[jira] [Assigned] (KAFKA-9349) Investigate new member timeout for dynamic v4 JoinGroup

2021-03-05 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson reassigned KAFKA-9349: -- Assignee: (was: Jason Gustafson) > Investigate new member timeout for dynamic v4

[jira] [Commented] (KAFKA-12435) Several streams-test-utils classes missing from javadoc

2021-03-05 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17296367#comment-17296367 ] Ismael Juma commented on KAFKA-12435: - cc [~mjsax] [~vvcephei] > Several streams-test-utils classes

[jira] [Commented] (KAFKA-12435) Several streams-test-utils classes missing from javadoc

2021-03-05 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17296366#comment-17296366 ] Ismael Juma commented on KAFKA-12435: - If you run `aggregatedJavadoc` with Java 8, you will see some

[jira] [Created] (KAFKA-12435) Several streams-test-utils classes missing from javadoc

2021-03-05 Thread Ismael Juma (Jira)
Ismael Juma created KAFKA-12435: --- Summary: Several streams-test-utils classes missing from javadoc Key: KAFKA-12435 URL: https://issues.apache.org/jira/browse/KAFKA-12435 Project: Kafka Issue

[jira] [Updated] (KAFKA-12435) Several streams-test-utils classes missing from javadoc

2021-03-05 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-12435: Description: !image-2021-03-05-14-22-45-891.png! Only 3 of them show up currently ^. Source: 

[GitHub] [kafka] ijuma opened a new pull request #10272: MINOR: Various javadoc fixes

2021-03-05 Thread GitBox
ijuma opened a new pull request #10272: URL: https://github.com/apache/kafka/pull/10272 - Use consistent options for `javadoc` and `aggregatedJavadoc` - `aggregatedJavadoc` depends on `compileJava` - `connect-api` inherits `options.links` - `streams` and `streams-test-utils`

[jira] [Created] (KAFKA-12434) Admin API for DescribeProducers

2021-03-05 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-12434: --- Summary: Admin API for DescribeProducers Key: KAFKA-12434 URL: https://issues.apache.org/jira/browse/KAFKA-12434 Project: Kafka Issue Type: Sub-task

[jira] [Updated] (KAFKA-12432) Fix AdminClient timeout handling in the presence of badly behaved brokers

2021-03-05 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-12432: - Summary: Fix AdminClient timeout handling in the presence of badly behaved brokers (was:

[GitHub] [kafka] abbccdda merged pull request #10211: KAFKA-12347: updating TaskMetadata

2021-03-05 Thread GitBox
abbccdda merged pull request #10211: URL: https://github.com/apache/kafka/pull/10211 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] hachikuji commented on a change in pull request #10220: KAFKA-12383: Get RaftClusterTest.java and other KIP-500 junit tests working

2021-03-05 Thread GitBox
hachikuji commented on a change in pull request #10220: URL: https://github.com/apache/kafka/pull/10220#discussion_r588522951 ## File path: core/src/test/java/kafka/test/junit/ClusterTestExtensions.java ## @@ -199,12 +209,25 @@ private void processClusterTest(ClusterTest

[jira] [Created] (KAFKA-12433) Controller should create topic config records after topic record

2021-03-05 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-12433: --- Summary: Controller should create topic config records after topic record Key: KAFKA-12433 URL: https://issues.apache.org/jira/browse/KAFKA-12433 Project:

[GitHub] [kafka] hachikuji commented on a change in pull request #10252: KAFKA-12403; Ensure local state deleted on `RemoveTopicRecord` received

2021-03-05 Thread GitBox
hachikuji commented on a change in pull request #10252: URL: https://github.com/apache/kafka/pull/10252#discussion_r588524835 ## File path: core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala ## @@ -142,28 +145,19 @@ class BrokerMetadataListener(brokerId:

[GitHub] [kafka] hachikuji commented on a change in pull request #10240: KAFKA-12381: remove live broker checks for forwarding topic creation

2021-03-05 Thread GitBox
hachikuji commented on a change in pull request #10240: URL: https://github.com/apache/kafka/pull/10240#discussion_r588513624 ## File path: core/src/test/scala/unit/kafka/server/AutoTopicCreationManagerTest.scala ## @@ -146,29 +146,118 @@ class AutoTopicCreationManagerTest {

[jira] [Created] (KAFKA-12432) AdminClient will not honor connection setup or request timeouts in some cases

2021-03-05 Thread Colin McCabe (Jira)
Colin McCabe created KAFKA-12432: Summary: AdminClient will not honor connection setup or request timeouts in some cases Key: KAFKA-12432 URL: https://issues.apache.org/jira/browse/KAFKA-12432

[GitHub] [kafka] satishd edited a comment on pull request #10271: KAFKA-12429: Added serdes for the default implementation of RLMM based on an internal topic as storage.

2021-03-05 Thread GitBox
satishd edited a comment on pull request #10271: URL: https://github.com/apache/kafka/pull/10271#issuecomment-791545987 @junrao: This is built on top of https://github.com/apache/kafka/pull/10218. This is an automated

[GitHub] [kafka] satishd commented on pull request #10271: KAFKA-12429: Added serdes for the default implementation of RLMM based on an internal topic as storage.

2021-03-05 Thread GitBox
satishd commented on pull request #10271: URL: https://github.com/apache/kafka/pull/10271#issuecomment-791545987 @junrao This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] satishd opened a new pull request #10271: KAFKA-12429: Added serdes for the default implementation of RLMM based on an internal topic as storage.

2021-03-05 Thread GitBox
satishd opened a new pull request #10271: URL: https://github.com/apache/kafka/pull/10271 KAFKA-12429: Added serdes for the default implementation of RLMM based on an internal topic as storage. This topic will receive events of RemoteLogSegmentMetadata, RemoteLogSegmentUpdate, and

[GitHub] [kafka] ijuma commented on pull request #10269: KAFKA-12410 KafkaAPis ought to group fetch data before generating fet…

2021-03-05 Thread GitBox
ijuma commented on pull request #10269: URL: https://github.com/apache/kafka/pull/10269#issuecomment-791487213 Thanks for the PR. Can you check the perf impact of these changes? This is an automated message from the Apache

[jira] [Reopened] (KAFKA-12347) Improve Kafka Streams ability to track progress

2021-03-05 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walker Carlson reopened KAFKA-12347: > Improve Kafka Streams ability to track progress >

[GitHub] [kafka] mimaison commented on a change in pull request #9549: KIP-145: Add SMTs, HeaderFrom, DropHeaders and InsertHeader

2021-03-05 Thread GitBox
mimaison commented on a change in pull request #9549: URL: https://github.com/apache/kafka/pull/9549#discussion_r588262888 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/tools/TransformationDoc.java ## @@ -18,11 +18,15 @@ import

[GitHub] [kafka] rajinisivaram commented on a change in pull request #10267: KAFKA-12427: Don't update connection idle time for muted connections

2021-03-05 Thread GitBox
rajinisivaram commented on a change in pull request #10267: URL: https://github.com/apache/kafka/pull/10267#discussion_r588308473 ## File path: clients/src/main/java/org/apache/kafka/common/network/Selector.java ## @@ -517,7 +517,7 @@ void pollSelectionKeys(Set selectionKeys,

[GitHub] [kafka] rajinisivaram commented on pull request #10267: KAFKA-12427: Don't update connection idle time for muted connections

2021-03-05 Thread GitBox
rajinisivaram commented on pull request #10267: URL: https://github.com/apache/kafka/pull/10267#issuecomment-791420001 @splett2 Thanks for the PR. I think it would be better to store channels in `keysWithBufferedReads` only when the channel is not explicitly muted since we care about this

[jira] [Assigned] (KAFKA-12430) emit.heartbeats.enabled = false should disable heartbeats topic creation

2021-03-05 Thread Ivan Yurchenko (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Yurchenko reassigned KAFKA-12430: -- Assignee: Ivan Yurchenko > emit.heartbeats.enabled = false should disable heartbeats

[GitHub] [kafka] omkreddy merged pull request #10270: MINOR: Update log level in SaslServerAuthenticator

2021-03-05 Thread GitBox
omkreddy merged pull request #10270: URL: https://github.com/apache/kafka/pull/10270 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] mimaison commented on a change in pull request #10192: MINOR: Add missing unit tests for Mirror Connect

2021-03-05 Thread GitBox
mimaison commented on a change in pull request #10192: URL: https://github.com/apache/kafka/pull/10192#discussion_r588238922 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorSourceTaskTest.java ## @@ -86,4 +96,66 @@ public void

[GitHub] [kafka] pzygielo commented on pull request #8211: COMDEV-340 Fix project category

2021-03-05 Thread GitBox
pzygielo commented on pull request #8211: URL: https://github.com/apache/kafka/pull/8211#issuecomment-791330792 Now it has [separate issue (KAFKA-10775)](https://issues.apache.org/jira/browse/KAFKA-10775). What process shall be followed to have it corrected?

[jira] [Updated] (KAFKA-12431) Fetch Request/Response without Topic information

2021-03-05 Thread Peter Sinoros-Szabo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Sinoros-Szabo updated KAFKA-12431: Attachment: fetch-on-2.6.1.png fetch-on-2.4.1.png > Fetch

[jira] [Created] (KAFKA-12431) Fetch Request/Response without Topic information

2021-03-05 Thread Peter Sinoros-Szabo (Jira)
Peter Sinoros-Szabo created KAFKA-12431: --- Summary: Fetch Request/Response without Topic information Key: KAFKA-12431 URL: https://issues.apache.org/jira/browse/KAFKA-12431 Project: Kafka

[GitHub] [kafka] dpoldrugo edited a comment on pull request #10059: KAFKA-8562: SaslChannelBuilder - avoid (reverse) DNS lookup while building underlying SslTransportLayer

2021-03-05 Thread GitBox
dpoldrugo edited a comment on pull request #10059: URL: https://github.com/apache/kafka/pull/10059#issuecomment-791291261 @omkreddy well for as at Infobip it caused an incident which basically blocked all kafka traffic, just because of some clients didn't have PTR records and thus reverse

[GitHub] [kafka] dpoldrugo commented on pull request #10059: KAFKA-8562: SaslChannelBuilder - avoid (reverse) DNS lookup while building underlying SslTransportLayer

2021-03-05 Thread GitBox
dpoldrugo commented on pull request #10059: URL: https://github.com/apache/kafka/pull/10059#issuecomment-791291261 @omkreddy well for as at Infobip it caused an incident which basically blocked all kafka traffic, just because of some clients didn't have PTR records and thus reverse dns

[GitHub] [kafka] omkreddy opened a new pull request #10270: MINOR: Update log level in SaslServerAuthenticator

2021-03-05 Thread GitBox
omkreddy opened a new pull request #10270: URL: https://github.com/apache/kafka/pull/10270 We are logging CONNECTIONS_MAX_REAUTH_MS at debug level for each mechanism. This is spammy when we enable debug logs for SaslServerAuthenticator. Updating the log level to trace level. ###

[jira] [Created] (KAFKA-12430) emit.heartbeats.enabled = false should disable heartbeats topic creation

2021-03-05 Thread Ivan Yurchenko (Jira)
Ivan Yurchenko created KAFKA-12430: -- Summary: emit.heartbeats.enabled = false should disable heartbeats topic creation Key: KAFKA-12430 URL: https://issues.apache.org/jira/browse/KAFKA-12430

[GitHub] [kafka] chia7712 commented on a change in pull request #10269: KAFKA-12410 KafkaAPis ought to group fetch data before generating fet…

2021-03-05 Thread GitBox
chia7712 commented on a change in pull request #10269: URL: https://github.com/apache/kafka/pull/10269#discussion_r588138822 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -811,31 +821,40 @@ class KafkaApis(val requestChannel: RequestChannel,

[jira] [Commented] (KAFKA-10526) Explore performance impact of leader fsync deferral

2021-03-05 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17295880#comment-17295880 ] Sagar Rao commented on KAFKA-10526: --- hey [~hachikuji] sorry for bugging again on this but could you

[GitHub] [kafka] Iskuskov commented on pull request #9541: KAFKA-10675: Add schema name to ConnectSchema.validateValue() error message

2021-03-05 Thread GitBox
Iskuskov commented on pull request #9541: URL: https://github.com/apache/kafka/pull/9541#issuecomment-791263135 @kkonstantine, could you take a look at this please? This is an automated message from the Apache Git Service.