[
https://issues.apache.org/jira/browse/KAFKA-12537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-12537:
---
Affects Version/s: (was: 3.0.0)
> Single Threaded applications will not
[
https://issues.apache.org/jira/browse/KAFKA-12537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-12537:
---
Summary: Single Threaded applications will not work with
[
https://issues.apache.org/jira/browse/KAFKA-12537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman resolved KAFKA-12537.
Fix Version/s: 2.8.0
Resolution: Fixed
> Single Threaded EOS
ableegoldman edited a comment on pull request #10387:
URL: https://github.com/apache/kafka/pull/10387#issuecomment-808632135
Merged to trunk, just running the tests before pushing to 2.8 @vvcephei
edit: done
--
This is an automated message from the Apache Git Service.
To respond
ableegoldman commented on pull request #10387:
URL: https://github.com/apache/kafka/pull/10387#issuecomment-808632135
Merged to trunk, just running the tests before pushing to 2.8 @vvcephei
--
This is an automated message from the Apache Git Service.
To respond to the message, please
ableegoldman merged pull request #10387:
URL: https://github.com/apache/kafka/pull/10387
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
ableegoldman commented on a change in pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#discussion_r602659052
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -509,38 +519,60 @@ void
ableegoldman commented on pull request #10387:
URL: https://github.com/apache/kafka/pull/10387#issuecomment-808619295
Looks like just one unrelated flaky test failure:
`kafka.common.record.MemoryRecordsBuilderTest.[18] magic=1, bufferOffset=15,
compressionType=GZIP`
--
This is an
ableegoldman commented on a change in pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#discussion_r602652039
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -509,38 +519,60 @@ void
mjsax commented on a change in pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#discussion_r602643004
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -509,38 +519,60 @@ void handleRevocation(final
ableegoldman commented on a change in pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#discussion_r602641612
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -509,38 +519,60 @@ void
ableegoldman closed pull request #10417:
URL: https://github.com/apache/kafka/pull/10417
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
ableegoldman commented on pull request #10417:
URL: https://github.com/apache/kafka/pull/10417#issuecomment-808600449
Closing this PR since we've ported this fix over to
https://github.com/apache/kafka/pull/10387
--
This is an automated message from the Apache Git Service.
To respond to
yeralin commented on pull request #6592:
URL: https://github.com/apache/kafka/pull/6592#issuecomment-808566124
Bump
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For
ableegoldman commented on a change in pull request #10417:
URL: https://github.com/apache/kafka/pull/10417#discussion_r602616296
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/StreamsUncaughtExceptionHandlerIntegrationTest.java
##
@@ -177,6 +178,7 @@
ableegoldman commented on a change in pull request #10417:
URL: https://github.com/apache/kafka/pull/10417#discussion_r602616135
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/StreamsUncaughtExceptionHandlerIntegrationTest.java
##
@@ -177,6 +178,7 @@
vvcephei commented on a change in pull request #10378:
URL: https://github.com/apache/kafka/pull/10378#discussion_r602602147
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/SessionWindows.java
##
@@ -73,33 +72,16 @@
public final class SessionWindows {
ableegoldman commented on a change in pull request #10387:
URL: https://github.com/apache/kafka/pull/10387#discussion_r602606489
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -492,22 +492,18 @@ private void
mjsax commented on a change in pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#discussion_r602605779
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -509,38 +519,60 @@ void handleRevocation(final
mjsax commented on a change in pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#discussion_r602604314
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -509,41 +519,62 @@ void handleRevocation(final
wcarlson5 commented on pull request #10387:
URL: https://github.com/apache/kafka/pull/10387#issuecomment-808533844
@ableegoldman I removed the global only case improvement and made
https://issues.apache.org/jira/browse/KAFKA-12565.
Now this just has a fix for if there is one thread
[
https://issues.apache.org/jira/browse/KAFKA-12565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Walker Carlson updated KAFKA-12565:
---
Description:
Global thread only topologies should be able to shutdown applications via the
ableegoldman commented on a change in pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#discussion_r602602653
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -509,41 +519,62 @@ void
Walker Carlson created KAFKA-12565:
--
Summary: Global thread only topologies should be able to shutdown
applications via the uncaught exception handler
Key: KAFKA-12565
URL:
mjsax commented on a change in pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#discussion_r602602353
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -509,41 +519,62 @@ void handleRevocation(final
wcarlson5 commented on a change in pull request #10417:
URL: https://github.com/apache/kafka/pull/10417#discussion_r602601435
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/StreamsUncaughtExceptionHandlerIntegrationTest.java
##
@@ -177,6 +178,7 @@
ableegoldman commented on a change in pull request #10417:
URL: https://github.com/apache/kafka/pull/10417#discussion_r602595373
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##
@@ -565,59 +565,57 @@ public void run() {
kowshik commented on pull request #10280:
URL: https://github.com/apache/kafka/pull/10280#issuecomment-808514958
@junrao Just a heads up on the following. I'm working on the changes for
KAFKA-12552 (https://github.com/apache/kafka/pull/10401 to extract segments
map) and KAFKA-12553
mjsax commented on a change in pull request #10417:
URL: https://github.com/apache/kafka/pull/10417#discussion_r602591990
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamThreadTest.java
##
@@ -2333,6 +2334,75 @@ void runOnce() {
wcarlson5 commented on a change in pull request #10387:
URL: https://github.com/apache/kafka/pull/10387#discussion_r602591231
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -492,22 +492,18 @@ private void
mjsax commented on a change in pull request #10417:
URL: https://github.com/apache/kafka/pull/10417#discussion_r602590947
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##
@@ -565,59 +565,57 @@ public void run() {
*
ableegoldman commented on a change in pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#discussion_r601987024
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##
@@ -589,11 +589,7 @@ boolean runLoop() {
ableegoldman commented on a change in pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#discussion_r602587542
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##
@@ -611,6 +607,9 @@ boolean runLoop() {
wcarlson5 commented on a change in pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#discussion_r602585671
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##
@@ -611,6 +607,9 @@ boolean runLoop() {
wcarlson5 commented on a change in pull request #10387:
URL: https://github.com/apache/kafka/pull/10387#discussion_r602584888
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -492,22 +492,18 @@ private void
ableegoldman commented on a change in pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#discussion_r602584404
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -167,18 +167,7 @@ void
mjsax commented on a change in pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#discussion_r602581215
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -167,18 +167,7 @@ void handleCorruption(final Set
ableegoldman opened a new pull request #10417:
URL: https://github.com/apache/kafka/pull/10417
We've been amassing more and more `catch` blocks around the `runOnce` loop
in the StreamThread's `runLoop`. Some of these have complex handling which is
performed inside the catch block, such as
ableegoldman commented on a change in pull request #10412:
URL: https://github.com/apache/kafka/pull/10412#discussion_r602561350
##
File path: docs/streams/upgrade-guide.html
##
@@ -98,6 +98,9 @@ Streams API
WindowBytesStoreSupplier#segments: deprecated
[
https://issues.apache.org/jira/browse/KAFKA-10396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman resolved KAFKA-10396.
Resolution: Fixed
> Overall memory of container keep on growing due to
ableegoldman commented on a change in pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#discussion_r602528819
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##
@@ -611,6 +607,9 @@ boolean runLoop() {
guozhangwang commented on a change in pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#discussion_r602527847
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -167,18 +167,7 @@ void
ableegoldman commented on a change in pull request #10387:
URL: https://github.com/apache/kafka/pull/10387#discussion_r602525060
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -492,22 +492,18 @@ private void
ableegoldman commented on a change in pull request #10387:
URL: https://github.com/apache/kafka/pull/10387#discussion_r602525060
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -492,22 +492,18 @@ private void
ableegoldman commented on a change in pull request #10387:
URL: https://github.com/apache/kafka/pull/10387#discussion_r602525060
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -492,22 +492,18 @@ private void
[
https://issues.apache.org/jira/browse/KAFKA-10853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309621#comment-17309621
]
Kyle Ambroff-Kao commented on KAFKA-10853:
--
We spent a lot of time discussing this internally
ableegoldman commented on a change in pull request #10416:
URL: https://github.com/apache/kafka/pull/10416#discussion_r602495343
##
File path:
streams/src/test/java/org/apache/kafka/test/MockRocksDbConfigSetter.java
##
@@ -32,4 +32,9 @@ public void setConfig(final String
[
https://issues.apache.org/jira/browse/KAFKA-8784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-8784:
--
Description:
In 2.3 we added a new method to RocksDBConfigSetter that will be
wcarlson5 commented on a change in pull request #10387:
URL: https://github.com/apache/kafka/pull/10387#discussion_r602472401
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -492,22 +492,18 @@ private void
kowshik commented on a change in pull request #10280:
URL: https://github.com/apache/kafka/pull/10280#discussion_r602052452
##
File path: core/src/main/scala/kafka/log/LocalLog.scala
##
@@ -0,0 +1,1561 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or
wcarlson5 commented on a change in pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#discussion_r602456496
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##
@@ -611,6 +607,9 @@ boolean runLoop() {
wcarlson5 commented on pull request #10416:
URL: https://github.com/apache/kafka/pull/10416#issuecomment-808370533
@ableegoldman
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
wcarlson5 edited a comment on pull request #10416:
URL: https://github.com/apache/kafka/pull/10416#issuecomment-808370533
@ableegoldman for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
wcarlson5 opened a new pull request #10416:
URL: https://github.com/apache/kafka/pull/10416
remove default
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation
junrao commented on a change in pull request #10405:
URL: https://github.com/apache/kafka/pull/10405#discussion_r602428120
##
File path: clients/src/main/java/org/apache/kafka/common/record/FileRecords.java
##
@@ -249,6 +266,7 @@ public void renameTo(File f) throws IOException
highluck commented on pull request #9851:
URL: https://github.com/apache/kafka/pull/9851#issuecomment-808339074
@chia7712
thanks
updated code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
chia7712 commented on a change in pull request #10389:
URL: https://github.com/apache/kafka/pull/10389#discussion_r602393980
##
File path: core/src/test/scala/unit/kafka/server/ListOffsetsRequestTest.scala
##
@@ -154,7 +160,10 @@ class ListOffsetsRequestTest extends
[
https://issues.apache.org/jira/browse/KAFKA-12563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309493#comment-17309493
]
Bui Thanh MInh commented on KAFKA-12563:
It seems helpful, I will try, thanks.
> Something
[
https://issues.apache.org/jira/browse/KAFKA-12563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bui Thanh MInh resolved KAFKA-12563.
Resolution: Resolved
> Something wrong with MM2 metrics
>
[
https://issues.apache.org/jira/browse/KAFKA-7870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309487#comment-17309487
]
kai.tian commented on KAFKA-7870:
-
Hi Tyran, when our borker had this exception, we found that the value
ijuma commented on pull request #10414:
URL: https://github.com/apache/kafka/pull/10414#issuecomment-808245571
Thanks @rondagostino. I addressed the review comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
[
https://issues.apache.org/jira/browse/KAFKA-12563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309447#comment-17309447
]
Ryanne Dolan commented on KAFKA-12563:
--
You can look at the lag of the internal consumers to get an
ijuma commented on pull request #10415:
URL: https://github.com/apache/kafka/pull/10415#issuecomment-808230478
@rajinisivaram we have one test failure (`testUnsupportedTlsVersion`) in the
clients module with JDK 16:
> Failed authentication with localhost/127.0.0.1 (SSL handshake
ijuma opened a new pull request #10415:
URL: https://github.com/apache/kafka/pull/10415
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
rondagostino commented on a change in pull request #10414:
URL: https://github.com/apache/kafka/pull/10414#discussion_r602270763
##
File path: config/raft/README.md
##
@@ -65,16 +68,19 @@ controllers, you can tolerate 1 failure; with 5
controllers, you can tolerate 2
##
ijuma commented on a change in pull request #10389:
URL: https://github.com/apache/kafka/pull/10389#discussion_r602257805
##
File path: core/src/test/scala/unit/kafka/server/ListOffsetsRequestTest.scala
##
@@ -154,7 +160,10 @@ class ListOffsetsRequestTest extends
chia7712 commented on a change in pull request #10389:
URL: https://github.com/apache/kafka/pull/10389#discussion_r602237567
##
File path: core/src/test/scala/unit/kafka/server/ListOffsetsRequestTest.scala
##
@@ -154,7 +160,10 @@ class ListOffsetsRequestTest extends
ijuma opened a new pull request #10414:
URL: https://github.com/apache/kafka/pull/10414
Self-managed is also used in the context of Cloud vs on-prem and it can
be confusing.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ]
ijuma commented on a change in pull request #10389:
URL: https://github.com/apache/kafka/pull/10389#discussion_r602220116
##
File path: core/src/test/scala/unit/kafka/server/ListOffsetsRequestTest.scala
##
@@ -154,7 +160,10 @@ class ListOffsetsRequestTest extends
[
https://issues.apache.org/jira/browse/KAFKA-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309384#comment-17309384
]
Sagar Rao commented on KAFKA-12373:
---
hi [~jsancio], I have started looking at this and had a question:
chia7712 commented on a change in pull request #9851:
URL: https://github.com/apache/kafka/pull/9851#discussion_r602163446
##
File path:
clients/src/test/java/org/apache/kafka/common/requests/JoinGroupRequestTest.java
##
@@ -64,7 +65,7 @@ public void
chia7712 commented on pull request #10389:
URL: https://github.com/apache/kafka/pull/10389#issuecomment-808075755
unrelated failure. will merge trunk to trigger QA again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
[
https://issues.apache.org/jira/browse/KAFKA-10201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309285#comment-17309285
]
Tom Bentley commented on KAFKA-10201:
-
[~xvrl] are you intending to come back to this work?
>
[
https://issues.apache.org/jira/browse/KAFKA-12563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309281#comment-17309281
]
Bui Thanh MInh commented on KAFKA-12563:
Thanks, but as I understand the meaning of this metric,
[
https://issues.apache.org/jira/browse/KAFKA-7870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309279#comment-17309279
]
Tyran commented on KAFKA-7870:
--
Hi Kai, we have set our open file limit to 10 and our brokers do not
[
https://issues.apache.org/jira/browse/KAFKA-12478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309276#comment-17309276
]
hudeqi commented on KAFKA-12478:
Ok, If I submit a patch, do you prefer to modify the logic on the
[
https://issues.apache.org/jira/browse/KAFKA-7870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309275#comment-17309275
]
kai.tian commented on KAFKA-7870:
-
If the exception occurs in the broker section, this KAFKA-7757
[
https://issues.apache.org/jira/browse/KAFKA-12564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jessica Johann updated KAFKA-12564:
---
Description:
Libraries from build.sbt:
{{"org.apache.kafka" % "kafka_2.13" % "2.7.0",}}
[
https://issues.apache.org/jira/browse/KAFKA-12564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jessica Johann updated KAFKA-12564:
---
Description:
Libraries from build.sbt:
{{"org.apache.kafka" % "kafka_2.13" % "2.7.0",}}
[
https://issues.apache.org/jira/browse/KAFKA-12564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jessica Johann updated KAFKA-12564:
---
Description:
Libraries from build.sbt:
{{"org.apache.kafka" % "kafka_2.13" % "2.7.0",}}
[
https://issues.apache.org/jira/browse/KAFKA-12564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jessica Johann updated KAFKA-12564:
---
Description:
Libraries from build.sbt:
{{"org.apache.kafka" % "kafka_2.13" % "2.7.0",}}
Jessica Johann created KAFKA-12564:
--
Summary: KTable#filter-method called twice after aggregation
Key: KAFKA-12564
URL: https://issues.apache.org/jira/browse/KAFKA-12564
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna reassigned KAFKA-12519:
-
Assignee: Bruno Cadonna
> Consider Removing Streams Old Built-in Metrics Version
>
[
https://issues.apache.org/jira/browse/KAFKA-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna updated KAFKA-12519:
--
Labels: needs-kip (was: )
> Consider Removing Streams Old Built-in Metrics Version
>
showuon commented on pull request #10413:
URL: https://github.com/apache/kafka/pull/10413#issuecomment-808030560
@bbejeck @mjsax , could you help review this PR? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
showuon opened a new pull request #10413:
URL: https://github.com/apache/kafka/pull/10413
Finding this link issue when reading the streaming doc:
https://kafka.apache.org/27/documentation/streams/developer-guide/config-streams.html#optional-configuration-parameters
1.
kowshik commented on pull request #10280:
URL: https://github.com/apache/kafka/pull/10280#issuecomment-808012495
@junrao Thanks a lot for the review! I've addressed your comments in
63be325b8b3ff5514e22137bb02dfc70e10f7a72.
--
This is an automated message from the Apache Git Service.
To
kowshik commented on a change in pull request #10280:
URL: https://github.com/apache/kafka/pull/10280#discussion_r602062784
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -1816,8 +1292,12 @@ class Log(@volatile private var _dir: File,
*/
private def
kowshik commented on a change in pull request #10280:
URL: https://github.com/apache/kafka/pull/10280#discussion_r602071574
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -836,178 +581,15 @@ class Log(@volatile private var _dir: File,
kowshik commented on a change in pull request #10280:
URL: https://github.com/apache/kafka/pull/10280#discussion_r602052452
##
File path: core/src/main/scala/kafka/log/LocalLog.scala
##
@@ -0,0 +1,1561 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or
kowshik commented on a change in pull request #10280:
URL: https://github.com/apache/kafka/pull/10280#discussion_r602062784
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -1816,8 +1292,12 @@ class Log(@volatile private var _dir: File,
*/
private def
kowshik commented on a change in pull request #10280:
URL: https://github.com/apache/kafka/pull/10280#discussion_r602062784
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -1816,8 +1292,12 @@ class Log(@volatile private var _dir: File,
*/
private def
kowshik commented on a change in pull request #10280:
URL: https://github.com/apache/kafka/pull/10280#discussion_r602056487
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -1794,20 +1269,21 @@ class Log(@volatile private var _dir: File,
ret.toSeq.sortBy(-_)
kowshik commented on a change in pull request #10280:
URL: https://github.com/apache/kafka/pull/10280#discussion_r602056301
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -213,32 +208,38 @@ case object SnapshotGenerated extends
LogStartOffsetIncrementReason {
}
kowshik commented on a change in pull request #10280:
URL: https://github.com/apache/kafka/pull/10280#discussion_r602056245
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -213,32 +208,38 @@ case object SnapshotGenerated extends
LogStartOffsetIncrementReason {
}
kowshik commented on a change in pull request #10280:
URL: https://github.com/apache/kafka/pull/10280#discussion_r602055675
##
File path: core/src/main/scala/kafka/log/LocalLog.scala
##
@@ -0,0 +1,1561 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or
kowshik commented on a change in pull request #10280:
URL: https://github.com/apache/kafka/pull/10280#discussion_r602055217
##
File path: core/src/main/scala/kafka/log/LocalLog.scala
##
@@ -0,0 +1,1561 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or
kowshik commented on a change in pull request #10280:
URL: https://github.com/apache/kafka/pull/10280#discussion_r602055217
##
File path: core/src/main/scala/kafka/log/LocalLog.scala
##
@@ -0,0 +1,1561 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or
kowshik commented on a change in pull request #10280:
URL: https://github.com/apache/kafka/pull/10280#discussion_r602052452
##
File path: core/src/main/scala/kafka/log/LocalLog.scala
##
@@ -0,0 +1,1561 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or
kowshik commented on a change in pull request #10280:
URL: https://github.com/apache/kafka/pull/10280#discussion_r602052393
##
File path: core/src/main/scala/kafka/log/LocalLog.scala
##
@@ -0,0 +1,1561 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or
1 - 100 of 111 matches
Mail list logo
