showuon commented on a change in pull request #10552:
URL: https://github.com/apache/kafka/pull/10552#discussion_r629990096
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java
##
@@ -106,9 +104,9 @@ private boolean allSub
jlprat commented on pull request #10651:
URL: https://github.com/apache/kafka/pull/10651#issuecomment-838123810
Most of the changes are purely cosmetic:
- using the right tags for for embedding a code snippet
- escaping `<` and `>` characters to HTML encoded strings so they are
proper
jlprat commented on pull request #10651:
URL: https://github.com/apache/kafka/pull/10651#issuecomment-838120807
@cadonna I'll do it next time. I was doubting between providing a PR per
file or a PR per folder. (ended up doing PR for the Streams folder).
--
This is an automated message fr
cadonna commented on pull request #10651:
URL: https://github.com/apache/kafka/pull/10651#issuecomment-838119727
Do not worry about the test failures. First of all, your PR does not touch
any code, so there is no reason a test would fail due to your PR. Additionally,
the failing tests are
showuon commented on a change in pull request #10552:
URL: https://github.com/apache/kafka/pull/10552#discussion_r629988069
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java
##
@@ -40,6 +39,7 @@
private static fina
cadonna edited a comment on pull request #10651:
URL: https://github.com/apache/kafka/pull/10651#issuecomment-838118603
Thank for the PR!
For the next time, I would recommend to open smaller PRs. Almost 2000
additions is a lot even for docs. In my experience smaller PRs tend to be
cadonna commented on pull request #10651:
URL: https://github.com/apache/kafka/pull/10651#issuecomment-838118603
For the next time, I would recommend to open smaller PRs. Almost 2000
additions is a lot even for docs. In my experience smaller PRs tend to be
merged faster.
--
This is an a
cadonna commented on a change in pull request #10646:
URL: https://github.com/apache/kafka/pull/10646#discussion_r629968874
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java
##
@@ -128,8 +129,7 @@ public void setGlobal
jlprat commented on pull request #10672:
URL: https://github.com/apache/kafka/pull/10672#issuecomment-838046744
cc @vvcephei as mentioned on the mailing list, here there is a backport to
2.7
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
jlprat commented on pull request #10669:
URL: https://github.com/apache/kafka/pull/10669#issuecomment-838046575
cc @vvcephei as mentioned on the mailing list, here there is a backport to
2.8
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
jlprat opened a new pull request #10672:
URL: https://github.com/apache/kafka/pull/10672
…lding SslTransportLayer
This is a cherry picked commit of #10059 to branch 2.7
This patch moves the `peerHost` helper defined in `SslChannelBuilder` into
`SslFactor`. `SaslChannelBuilder`
DuongPTIT closed pull request #10670:
URL: https://github.com/apache/kafka/pull/10670
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, plea
chia7712 commented on pull request #10637:
URL: https://github.com/apache/kafka/pull/10637#issuecomment-837994346
> Is it possible to set up the gitignore to automatically ignore anything
under a generated/ subdirectory?
please take a look at #10671
--
This is an automated message
chia7712 opened a new pull request #10671:
URL: https://github.com/apache/kafka/pull/10671
for https://github.com/apache/kafka/pull/10637#issuecomment-837691327
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test cover
[
https://issues.apache.org/jira/browse/KAFKA-12635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17342374#comment-17342374
]
Angelos Kaltsikis commented on KAFKA-12635:
---
Hello [~yangguo1220],
Thanks for
DuongPTIT opened a new pull request #10670:
URL: https://github.com/apache/kafka/pull/10670
@rhauch Hi, please review this PR for me. Many thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
jlprat opened a new pull request #10669:
URL: https://github.com/apache/kafka/pull/10669
…lding SslTransportLayer
This is a cherry picked commit of https://github.com/apache/kafka/pull/10059
to branch 2.8
Original commit message:
This patch moves the `peerHost` helper defin
vitojeng opened a new pull request #10668:
URL: https://github.com/apache/kafka/pull/10668
In the PR #9821, @mjsax 's
[comment](https://github.com/apache/kafka/pull/9821#discussion_r556200365)
> We should use a try-with-resources clause to make sure close() is called.
>
> Seems
showuon commented on pull request #10665:
URL: https://github.com/apache/kafka/pull/10665#issuecomment-837956607
Failed tests are un-related. Thanks.
```
Build / JDK 15 and Scala 2.13 /
org.apache.kafka.common.record.MemoryRecordsBuilderTest.[6] magic=2,
bufferOffset=0, compressi
101 - 119 of 119 matches
Mail list logo
