[GitHub] [kafka] kowshik commented on a change in pull request #10684: MINOR: Improve Log layer segment iteration logic and few other areas

2021-05-12 Thread GitBox
kowshik commented on a change in pull request #10684: URL: https://github.com/apache/kafka/pull/10684#discussion_r631584810 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -1204,13 +1202,12 @@ class Log(@volatile private var _dir: File, // Do the read on

[GitHub] [kafka] kowshik commented on a change in pull request #10684: MINOR: Improve Log layer segment iteration logic and few other areas

2021-05-12 Thread GitBox
kowshik commented on a change in pull request #10684: URL: https://github.com/apache/kafka/pull/10684#discussion_r631581404 ## File path: core/src/main/scala/kafka/log/LogSegments.scala ## @@ -185,7 +184,7 @@ class LogSegments(topicPartition: TopicPartition) { * if

[GitHub] [kafka] ijuma commented on a change in pull request #10684: MINOR: Improve Log layer segment iteration logic and few other areas

2021-05-12 Thread GitBox
ijuma commented on a change in pull request #10684: URL: https://github.com/apache/kafka/pull/10684#discussion_r631564915 ## File path: core/src/main/scala/kafka/log/LogSegments.scala ## @@ -185,7 +184,7 @@ class LogSegments(topicPartition: TopicPartition) { * if

[GitHub] [kafka] romani commented on pull request #10656: MINOR: checkstyle version upgrade: 8.20 -->> 8.36.2

2021-05-12 Thread GitBox
romani commented on pull request #10656: URL: https://github.com/apache/kafka/pull/10656#issuecomment-840296162 When you finish build config update to define checkstyle version from CLI, please share with us command. We will do ``` git clone Git checkout ... Your build

[GitHub] [kafka] jsancio commented on a change in pull request #10431: KAFKA-12543: Change RawSnapshotReader ownership model

2021-05-12 Thread GitBox
jsancio commented on a change in pull request #10431: URL: https://github.com/apache/kafka/pull/10431#discussion_r631549424 ## File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala ## @@ -16,29 +16,30 @@ */ package kafka.raft -import java.io.{File, IOException}

[GitHub] [kafka] jsancio commented on a change in pull request #10431: KAFKA-12543: Change RawSnapshotReader ownership model

2021-05-12 Thread GitBox
jsancio commented on a change in pull request #10431: URL: https://github.com/apache/kafka/pull/10431#discussion_r631549244 ## File path: raft/src/main/java/org/apache/kafka/snapshot/Snapshots.java ## @@ -104,18 +105,29 @@ public static Path createTempFile(Path logDir,

[GitHub] [kafka] DuongPTIT commented on pull request #10677: KAFKA-12380 Executor in Connect's Worker is not shut down when the worker is

2021-05-12 Thread GitBox
DuongPTIT commented on pull request #10677: URL: https://github.com/apache/kafka/pull/10677#issuecomment-840281912 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] jsancio commented on a change in pull request #10431: KAFKA-12543: Change RawSnapshotReader ownership model

2021-05-12 Thread GitBox
jsancio commented on a change in pull request #10431: URL: https://github.com/apache/kafka/pull/10431#discussion_r631544872 ## File path: raft/src/main/java/org/apache/kafka/snapshot/Snapshots.java ## @@ -104,18 +105,29 @@ public static Path createTempFile(Path logDir,

[GitHub] [kafka] ccding commented on a change in pull request #10684: MINOR: Improve Log layer segment iteration logic and few other areas

2021-05-12 Thread GitBox
ccding commented on a change in pull request #10684: URL: https://github.com/apache/kafka/pull/10684#discussion_r631539787 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -1204,13 +1202,12 @@ class Log(@volatile private var _dir: File, // Do the read on

[GitHub] [kafka] jsancio commented on a change in pull request #10431: KAFKA-12543: Change RawSnapshotReader ownership model

2021-05-12 Thread GitBox
jsancio commented on a change in pull request #10431: URL: https://github.com/apache/kafka/pull/10431#discussion_r631543566 ## File path: raft/src/main/java/org/apache/kafka/snapshot/FileRawSnapshotReader.java ## @@ -54,8 +54,12 @@ public Records records() { }

[jira] [Commented] (KAFKA-12776) Producer sends messages out-of-order inspite of enabling idempotence

2021-05-12 Thread NEERAJ VAIDYA (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17343682#comment-17343682 ] NEERAJ VAIDYA commented on KAFKA-12776: --- Assuming that a Producer application is started, but

[GitHub] [kafka] DuongPTIT commented on pull request #10677: KAFKA-12380 Executor in Connect's Worker is not shut down when the worker is

2021-05-12 Thread GitBox
DuongPTIT commented on pull request #10677: URL: https://github.com/apache/kafka/pull/10677#issuecomment-840264920 Please retest this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] DuongPTIT opened a new pull request #10685: KAFKA-12380 Executor in Connect's Worker is not shut down when the worker is

2021-05-12 Thread GitBox
DuongPTIT opened a new pull request #10685: URL: https://github.com/apache/kafka/pull/10685 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

[GitHub] [kafka] ableegoldman commented on pull request #10676: KAFKA-12648: Pt. 0 - Add TopologyMetadata.Subtopology class for subtopology metadata

2021-05-12 Thread GitBox
ableegoldman commented on pull request #10676: URL: https://github.com/apache/kafka/pull/10676#issuecomment-840227278 Ready for review @wcarlson5 @guozhangwang @rodesai -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] kowshik commented on a change in pull request #10684: MINOR: Improve Log layer segment iteration logic and few other areas

2021-05-12 Thread GitBox
kowshik commented on a change in pull request #10684: URL: https://github.com/apache/kafka/pull/10684#discussion_r631501285 ## File path: core/src/main/scala/kafka/log/LogSegments.scala ## @@ -17,7 +17,6 @@ package kafka.log import java.io.File -import java.lang.{Long =>

[GitHub] [kafka] kowshik commented on pull request #10684: MINOR: Improve Log layer segment iteration logic and few other areas

2021-05-12 Thread GitBox
kowshik commented on pull request #10684: URL: https://github.com/apache/kafka/pull/10684#issuecomment-840215023 cc @junrao -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [kafka] kowshik commented on a change in pull request #10684: MINOR: Improve Log layer segment iteration logic and few other areas

2021-05-12 Thread GitBox
kowshik commented on a change in pull request #10684: URL: https://github.com/apache/kafka/pull/10684#discussion_r631501034 ## File path: core/src/main/scala/kafka/log/LogSegments.scala ## @@ -210,11 +209,23 @@ class LogSegments(topicPartition: TopicPartition) { * @return

[GitHub] [kafka] kowshik opened a new pull request #10684: MINOR: Improve Log layer segment iteration logic and few other areas

2021-05-12 Thread GitBox
kowshik opened a new pull request #10684: URL: https://github.com/apache/kafka/pull/10684 - In `Log.rebuildProducerState()` I've removed usage of the `allSegments` local variable. - In `Log.collectAbortedTransactions()` I'm now raising an exception when the segment can't be found. -

[GitHub] [kafka] dejan2609 commented on pull request #10606: KAFKA-12728: version upgrades: gradle (6.8.3 -->> 7.0.1) and gradle shadow plugin (6.1.0 -->> 7.0.0)

2021-05-12 Thread GitBox
dejan2609 commented on pull request #10606: URL: https://github.com/apache/kafka/pull/10606#issuecomment-840198347 Short update: - first issue occurs only for Java "1.8.0_292" (not only here but worldwide and it is recognized by Oracle) - second issue... I did report it to a Gradle,

[GitHub] [kafka] ableegoldman opened a new pull request #10683: KAFKA-12648: introduce TopologyMetadata to wrap InternalTopologyBuilders of named topologies

2021-05-12 Thread GitBox
ableegoldman opened a new pull request #10683: URL: https://github.com/apache/kafka/pull/10683 Next up after [#10609](https://github.com/apache/kafka/pull/10609) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] ableegoldman commented on pull request #10666: MINOR: prevent cleanup() from being called while Streams is still shutting down

2021-05-12 Thread GitBox
ableegoldman commented on pull request #10666: URL: https://github.com/apache/kafka/pull/10666#issuecomment-840173582 cc @guozhangwang @cadonna @wcarlson5 @lct45 to review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Commented] (KAFKA-6654) Customize SSLContext creation

2021-05-12 Thread Maulin Vasavada (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17343635#comment-17343635 ] Maulin Vasavada commented on KAFKA-6654: [~soarez] See the above. > Customize SSLContext

[jira] [Commented] (KAFKA-6654) Customize SSLContext creation

2021-05-12 Thread Maulin Vasavada (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17343634#comment-17343634 ] Maulin Vasavada commented on KAFKA-6654: KIP-519 addresses this issue. > Customize SSLContext

[GitHub] [kafka] eas5 opened a new pull request #10682: Refactored test using parameterization

2021-05-12 Thread GitBox
eas5 opened a new pull request #10682: URL: https://github.com/apache/kafka/pull/10682 Problem: (1) Conditions or full repetitions within a test method may produce a false test outcome. Once a condition is not met, and the code block inside the condition is not executed, a false

[jira] [Updated] (KAFKA-12774) kafka-streams 2.8: logging in uncaught-exceptionhandler doesn't go through log4j

2021-05-12 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-12774: --- Fix Version/s: 2.8.1 3.0.0 > kafka-streams 2.8: logging

[jira] [Commented] (KAFKA-12774) kafka-streams 2.8: logging in uncaught-exceptionhandler doesn't go through log4j

2021-05-12 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17343624#comment-17343624 ] Walker Carlson commented on KAFKA-12774: I looked at the code and it seems that in the replace

[GitHub] [kafka] ryannedolan opened a new pull request #10681: KIP 731 WIP Connect per-task record rate limiting

2021-05-12 Thread GitBox
ryannedolan opened a new pull request #10681: URL: https://github.com/apache/kafka/pull/10681 WIP concept for a flexible RateLimiter for Connect. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Updated] (KAFKA-12776) Producer sends messages out-of-order inspite of enabling idempotence

2021-05-12 Thread NEERAJ VAIDYA (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] NEERAJ VAIDYA updated KAFKA-12776: -- Description: I have an Apache Kafka 2.6 Producer which writes to topic-A (TA).  My

[GitHub] [kafka] cmccabe commented on pull request #10326: Avoid newly replicating brokers in RackAwareReplicaSelector

2021-05-12 Thread GitBox
cmccabe commented on pull request #10326: URL: https://github.com/apache/kafka/pull/10326#issuecomment-840123466 Does this need a KIP? cc @ijuma and @hachikuji -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] dejan2609 edited a comment on pull request #10606: KAFKA-12728: version upgrades: gradle (6.8.3 -->> 7.0.1) and gradle shadow plugin (6.1.0 -->> 7.0.0)

2021-05-12 Thread GitBox
dejan2609 edited a comment on pull request #10606: URL: https://github.com/apache/kafka/pull/10606#issuecomment-840090090 Also... both here on Jenkins and on my laptop there is another type of problems with some test failing like this: ```

[GitHub] [kafka] dejan2609 edited a comment on pull request #10606: KAFKA-12728: version upgrades: gradle (6.8.3 -->> 7.0.1) and gradle shadow plugin (6.1.0 -->> 7.0.0)

2021-05-12 Thread GitBox
dejan2609 edited a comment on pull request #10606: URL: https://github.com/apache/kafka/pull/10606#issuecomment-840090090 Also... both here on Jenkins and on my laptop there is another type of problems with some test failing like this: ```

[GitHub] [kafka] dejan2609 edited a comment on pull request #10606: KAFKA-12728: version upgrades: gradle (6.8.3 -->> 7.0.1) and gradle shadow plugin (6.1.0 -->> 7.0.0)

2021-05-12 Thread GitBox
dejan2609 edited a comment on pull request #10606: URL: https://github.com/apache/kafka/pull/10606#issuecomment-840090090 Also... both here on Jenkins and on my laptop there is another type of problems with some test failing like this: ```

[jira] [Commented] (KAFKA-12775) StreamsPartitionAssignor / ClientState throws an exception when a new Task gets added to a KStreams Application in a Backwards-Compatible Topology Change

2021-05-12 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17343588#comment-17343588 ] A. Sophie Blee-Goldman commented on KAFKA-12775: If it's any consolation, I just so

[GitHub] [kafka] dejan2609 commented on pull request #10658: POC for CheckStyle 8.42 regression (with 'Unnecessary Parentheses' errors)

2021-05-12 Thread GitBox
dejan2609 commented on pull request #10658: URL: https://github.com/apache/kafka/pull/10658#issuecomment-840092184 Note: comment (related to a different PR) was accidentally submitted here and then deleted... sorry for spamming. -- This is an automated message from the Apache Git

[GitHub] [kafka] dejan2609 edited a comment on pull request #10606: KAFKA-12728: version upgrades: gradle (6.8.3 -->> 7.0.1) and gradle shadow plugin (6.1.0 -->> 7.0.0)

2021-05-12 Thread GitBox
dejan2609 edited a comment on pull request #10606: URL: https://github.com/apache/kafka/pull/10606#issuecomment-840081435 Note: I am trying to exact JDK version for Github generated Jenkins build:

[GitHub] [kafka] dejan2609 commented on pull request #10606: KAFKA-12728: version upgrades: gradle (6.8.3 -->> 7.0.1) and gradle shadow plugin (6.1.0 -->> 7.0.0)

2021-05-12 Thread GitBox
dejan2609 commented on pull request #10606: URL: https://github.com/apache/kafka/pull/10606#issuecomment-840090090 Also... both here on Jenkins and on my laptop there is another type of problems with some test failing like this: ```

[GitHub] [kafka] dejan2609 removed a comment on pull request #10658: POC for CheckStyle 8.42 regression (with 'Unnecessary Parentheses' errors)

2021-05-12 Thread GitBox
dejan2609 removed a comment on pull request #10658: URL: https://github.com/apache/kafka/pull/10658#issuecomment-840084223 Also... both here and on my laptop there is another type of problem with some test failing like this: ```

[GitHub] [kafka] dejan2609 edited a comment on pull request #10606: KAFKA-12728: version upgrades: gradle (6.8.3 -->> 7.0.1) and gradle shadow plugin (6.1.0 -->> 7.0.0)

2021-05-12 Thread GitBox
dejan2609 edited a comment on pull request #10606: URL: https://github.com/apache/kafka/pull/10606#issuecomment-840081435 Note: I am trying to exact JDK version for Github generated Jenkins build:

[jira] [Updated] (KAFKA-12776) Producer sends messages out-of-order inspite of enabling idempotence

2021-05-12 Thread NEERAJ VAIDYA (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] NEERAJ VAIDYA updated KAFKA-12776: -- Attachment: mocker.zip > Producer sends messages out-of-order inspite of enabling idempotence

[jira] [Commented] (KAFKA-12775) StreamsPartitionAssignor / ClientState throws an exception when a new Task gets added to a KStreams Application in a Backwards-Compatible Topology Change

2021-05-12 Thread Nico Habermann (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17343578#comment-17343578 ] Nico Habermann commented on KAFKA-12775: [~ableegoldman] Thanks for the extra help! My case is a

[jira] [Comment Edited] (KAFKA-12775) StreamsPartitionAssignor / ClientState throws an exception when a new Task gets added to a KStreams Application in a Backwards-Compatible Topology Change

2021-05-12 Thread Nico Habermann (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17343578#comment-17343578 ] Nico Habermann edited comment on KAFKA-12775 at 5/12/21, 8:52 PM: --

[jira] [Created] (KAFKA-12776) Producer sends messages out-of-order inspite of enabling idempotence

2021-05-12 Thread NEERAJ VAIDYA (Jira)
NEERAJ VAIDYA created KAFKA-12776: - Summary: Producer sends messages out-of-order inspite of enabling idempotence Key: KAFKA-12776 URL: https://issues.apache.org/jira/browse/KAFKA-12776 Project:

[GitHub] [kafka] mjsax commented on a change in pull request #10673: MINOR: set replication.factor to 1 to make StreamsBrokerCompatibility…

2021-05-12 Thread GitBox
mjsax commented on a change in pull request #10673: URL: https://github.com/apache/kafka/pull/10673#discussion_r631388964 ## File path: tests/kafkatest/services/streams.py ## @@ -466,6 +466,15 @@ def __init__(self, test_context, kafka, processingMode):

[GitHub] [kafka] dejan2609 edited a comment on pull request #10606: KAFKA-12728: version upgrades: gradle (6.8.3 -->> 7.0.1) and gradle shadow plugin (6.1.0 -->> 7.0.0)

2021-05-12 Thread GitBox
dejan2609 edited a comment on pull request #10606: URL: https://github.com/apache/kafka/pull/10606#issuecomment-840081435 So, herewith some update: on my local box (Ubuntu Linux with Java 8) around 50 test fail in a same way; details: Gradle command: `./gradlew -PscalaVersion=2.12

[GitHub] [kafka] dejan2609 commented on pull request #10658: POC for CheckStyle 8.42 regression (with 'Unnecessary Parentheses' errors)

2021-05-12 Thread GitBox
dejan2609 commented on pull request #10658: URL: https://github.com/apache/kafka/pull/10658#issuecomment-840084223 Also... both here and on my laptop there is another type of problem with some test failing like this: ```

[GitHub] [kafka] junrao commented on a change in pull request #10431: KAFKA-12543: Change RawSnapshotReader ownership model

2021-05-12 Thread GitBox
junrao commented on a change in pull request #10431: URL: https://github.com/apache/kafka/pull/10431#discussion_r631363750 ## File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala ## @@ -16,29 +16,30 @@ */ package kafka.raft -import java.io.{File, IOException}

[GitHub] [kafka] dejan2609 commented on pull request #10606: KAFKA-12728: version upgrades: gradle (6.8.3 -->> 7.0.1) and gradle shadow plugin (6.1.0 -->> 7.0.0)

2021-05-12 Thread GitBox
dejan2609 commented on pull request #10606: URL: https://github.com/apache/kafka/pull/10606#issuecomment-840081435 So, herewith some update: on my local box (Ubuntu Linux with Java 8) around 50 test fail in a same way; details: Gradle command: `./gradlew -PscalaVersion=2.12 test`

[GitHub] [kafka] ccding opened a new pull request #10680: Rework on KAFKA-3968: fsync the parent directory of a segment file when the file is created

2021-05-12 Thread GitBox
ccding opened a new pull request #10680: URL: https://github.com/apache/kafka/pull/10680 Kafka does not call fsync() on the directory when a new log segment is created and flushed to disk. The problem is that following sequence of calls doesn't guarantee file durability: fd

[jira] [Commented] (KAFKA-12775) StreamsPartitionAssignor / ClientState throws an exception when a new Task gets added to a KStreams Application in a Backwards-Compatible Topology Change

2021-05-12 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17343508#comment-17343508 ] A. Sophie Blee-Goldman commented on KAFKA-12775: [~nhab] while Bruno is correct that

[GitHub] [kafka] ableegoldman commented on a change in pull request #10673: MINOR: set replication.factor to 1 to make StreamsBrokerCompatibility…

2021-05-12 Thread GitBox
ableegoldman commented on a change in pull request #10673: URL: https://github.com/apache/kafka/pull/10673#discussion_r631340308 ## File path: tests/kafkatest/services/streams.py ## @@ -466,6 +466,15 @@ def __init__(self, test_context, kafka, processingMode):

[GitHub] [kafka] yeralin commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2021-05-12 Thread GitBox
yeralin commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r631339580 ## File path: clients/src/main/java/org/apache/kafka/common/serialization/ListDeserializer.java ## @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache

[jira] [Commented] (KAFKA-12774) kafka-streams 2.8: logging in uncaught-exceptionhandler doesn't go through log4j

2021-05-12 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17343505#comment-17343505 ] A. Sophie Blee-Goldman commented on KAFKA-12774: Thanks for the report – regarding how

[GitHub] [kafka] ableegoldman commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2021-05-12 Thread GitBox
ableegoldman commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r631334877 ## File path: clients/src/test/java/org/apache/kafka/common/serialization/SerializationTest.java ## @@ -106,6 +110,190 @@ public void

[GitHub] [kafka] ableegoldman commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2021-05-12 Thread GitBox
ableegoldman commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r631328727 ## File path: docs/streams/upgrade-guide.html ## @@ -1104,6 +1104,12 @@ JoinWindows has no default size anymore:

[GitHub] [kafka] ableegoldman commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2021-05-12 Thread GitBox
ableegoldman commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r631327191 ## File path: clients/src/main/java/org/apache/kafka/common/serialization/ListDeserializer.java ## @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] yeralin commented on pull request #6592: KAFKA-8326: Introduce List Serde

2021-05-12 Thread GitBox
yeralin commented on pull request #6592: URL: https://github.com/apache/kafka/pull/6592#issuecomment-840015831 Ok, updated the KIP with serializing nulls for different strategies. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Resolved] (KAFKA-12775) StreamsPartitionAssignor / ClientState throws an exception when a new Task gets added to a KStreams Application in a Backwards-Compatible Topology Change

2021-05-12 Thread Nico Habermann (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nico Habermann resolved KAFKA-12775. Resolution: Invalid > StreamsPartitionAssignor / ClientState throws an exception when a

[jira] [Commented] (KAFKA-12775) StreamsPartitionAssignor / ClientState throws an exception when a new Task gets added to a KStreams Application in a Backwards-Compatible Topology Change

2021-05-12 Thread Nico Habermann (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17343430#comment-17343430 ] Nico Habermann commented on KAFKA-12775: Closing the ticket since KStreams was not meant to be

[GitHub] [kafka] dielhennr opened a new pull request #10679: KAFKA-12697: Add Global Topic and Partition count metrics to the Quorum Controller

2021-05-12 Thread GitBox
dielhennr opened a new pull request #10679: URL: https://github.com/apache/kafka/pull/10679 Added GlobalTopicCount and GlobalPartitionCount metrics to the QuorumControllerMetrics. The metrics are calculated by counting records as they are replayed e.g. replay(TopicRecord),

[jira] [Commented] (KAFKA-12671) Out of order processing with a transactional producer can lead to a stuck LastStableOffset

2021-05-12 Thread Travis Bischel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17343401#comment-17343401 ] Travis Bischel commented on KAFKA-12671: Hi [~Peyer], I believe that the Java producer has

[GitHub] [kafka] gharris1727 commented on pull request #8259: KAFKA-7421: Ensure Connect's PluginClassLoader is truly parallel capable and resolve deadlock occurrences

2021-05-12 Thread GitBox
gharris1727 commented on pull request #8259: URL: https://github.com/apache/kafka/pull/8259#issuecomment-839961263 Hi @kkonstantine @rhauch I've updated the comments and cleaned up some names, and applied your suggested changes. PTAL, thanks! -- This is an automated message from the

[jira] [Comment Edited] (KAFKA-12671) Out of order processing with a transactional producer can lead to a stuck LastStableOffset

2021-05-12 Thread Travis Bischel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340576#comment-17340576 ] Travis Bischel edited comment on KAFKA-12671 at 5/12/21, 5:25 PM: --

[jira] [Updated] (KAFKA-12671) Out of order processing with a transactional producer can lead to a stuck LastStableOffset

2021-05-12 Thread Travis Bischel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Travis Bischel updated KAFKA-12671: --- Priority: Major (was: Blocker) > Out of order processing with a transactional producer can

[GitHub] [kafka] dejan2609 commented on pull request #10606: KAFKA-12728: version upgrades: gradle (6.8.3 -->> 7.0.1) and gradle shadow plugin (6.1.0 -->> 7.0.0)

2021-05-12 Thread GitBox
dejan2609 commented on pull request #10606: URL: https://github.com/apache/kafka/pull/10606#issuecomment-839951560 Probably they are... I will try to isolate issue(s) and compare it with Gradle 7 release notes. -- This is an automated message from the Apache Git Service. To respond to

[jira] [Commented] (KAFKA-12775) StreamsPartitionAssignor / ClientState throws an exception when a new Task gets added to a KStreams Application in a Backwards-Compatible Topology Change

2021-05-12 Thread Nico Habermann (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17343340#comment-17343340 ] Nico Habermann commented on KAFKA-12775: [~cadonna] I see, thanks for the quick answer. To be

[jira] [Commented] (KAFKA-12775) StreamsPartitionAssignor / ClientState throws an exception when a new Task gets added to a KStreams Application in a Backwards-Compatible Topology Change

2021-05-12 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17343328#comment-17343328 ] Bruno Cadonna commented on KAFKA-12775: --- [~nhab] Thank you for filing this ticket and the minimal

[GitHub] [kafka] yeralin commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2021-05-12 Thread GitBox
yeralin commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r631158775 ## File path: clients/src/test/java/org/apache/kafka/common/serialization/SerializationTest.java ## @@ -106,6 +110,190 @@ public void

[GitHub] [kafka] yeralin commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2021-05-12 Thread GitBox
yeralin commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r631158775 ## File path: clients/src/test/java/org/apache/kafka/common/serialization/SerializationTest.java ## @@ -106,6 +110,190 @@ public void

[GitHub] [kafka] yeralin commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2021-05-12 Thread GitBox
yeralin commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r631158775 ## File path: clients/src/test/java/org/apache/kafka/common/serialization/SerializationTest.java ## @@ -106,6 +110,190 @@ public void

[GitHub] [kafka] cmccabe commented on pull request #10572: KAFKA-12697: Add metrics to Quorum Controller

2021-05-12 Thread GitBox
cmccabe commented on pull request #10572: URL: https://github.com/apache/kafka/pull/10572#issuecomment-839872278 Can you create a PR that has just the global topics count and global partitions count? Then we can keep the remaining metrics in this PR. That will make it easier to review

[GitHub] [kafka] cmccabe commented on a change in pull request #10572: KAFKA-12697: Add metrics to Quorum Controller

2021-05-12 Thread GitBox
cmccabe commented on a change in pull request #10572: URL: https://github.com/apache/kafka/pull/10572#discussion_r631152959 ## File path: metadata/src/main/java/org/apache/kafka/controller/BrokersToIsrs.java ## @@ -326,4 +326,14 @@ PartitionsOnReplicaIterator

[GitHub] [kafka] yeralin commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2021-05-12 Thread GitBox
yeralin commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r631151867 ## File path: clients/src/main/java/org/apache/kafka/common/serialization/ListDeserializer.java ## @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache

[jira] [Issue Comment Deleted] (KAFKA-12668) MockScheduler is not safe to use in concurrent code.

2021-05-12 Thread Maksim Iakunin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maksim Iakunin updated KAFKA-12668: --- Comment: was deleted (was: [~jagsancio], hello! Could you give me some test-case when a

[GitHub] [kafka] ijuma commented on pull request #10606: KAFKA-12728: version upgrades: gradle (6.8.3 -->> 7.0.1) and gradle shadow plugin (6.1.0 -->> 7.0.0)

2021-05-12 Thread GitBox
ijuma commented on pull request #10606: URL: https://github.com/apache/kafka/pull/10606#issuecomment-839854774 I don't think the issues are related to the shadow plugin. They're related to the gradle upgrade. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] ijuma merged pull request #10654: MINOR: Update jacoco to 0.8.7 for JDK 16 support

2021-05-12 Thread GitBox
ijuma merged pull request #10654: URL: https://github.com/apache/kafka/pull/10654 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[jira] [Commented] (KAFKA-10670) repo.maven.apache.org: Name or service not known

2021-05-12 Thread Lutz Weischer (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17343267#comment-17343267 ] Lutz Weischer commented on KAFKA-10670: --- v2.7.1 and current master work fine now. Thanks! >

[jira] [Commented] (KAFKA-12671) Out of order processing with a transactional producer can lead to a stuck LastStableOffset

2021-05-12 Thread Simon (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17343255#comment-17343255 ] Simon commented on KAFKA-12671: --- [~twmb] can you provide a producer code (java?), which will trigger this

[jira] [Updated] (KAFKA-12775) StreamsPartitionAssignor / ClientState throws an exception when a new Task gets added to a KStreams Application in a Backwards-Compatible Topology Change

2021-05-12 Thread Nico Habermann (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nico Habermann updated KAFKA-12775: --- Description: KAFKA-6145 and KAFKA-10079 added an [exception if the Partition Assignor tries

[jira] [Updated] (KAFKA-12775) StreamsPartitionAssignor / ClientState throws an exception when a new Task gets added to a KStreams Application in a Backwards-Compatible Topology Change

2021-05-12 Thread Nico Habermann (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nico Habermann updated KAFKA-12775: --- Description: KAFKA-6145 added an [exception if the Partition Assignor tries to look up the

[jira] [Updated] (KAFKA-12775) StreamsPartitionAssignor / ClientState throws an exception when a new Task gets added to a KStreams Application in a Backwards-Compatible Topology Change

2021-05-12 Thread Nico Habermann (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nico Habermann updated KAFKA-12775: --- Component/s: streams > StreamsPartitionAssignor / ClientState throws an exception when a

[jira] [Created] (KAFKA-12775) StreamsPartitionAssignor / ClientState throws an exception when a new Task gets added to a KStreams Application in a Backwards-Compatible Topology Change

2021-05-12 Thread Nico Habermann (Jira)
Nico Habermann created KAFKA-12775: -- Summary: StreamsPartitionAssignor / ClientState throws an exception when a new Task gets added to a KStreams Application in a Backwards-Compatible Topology Change Key: KAFKA-12775

[jira] [Commented] (KAFKA-12534) kafka-configs does not work with ssl enabled kafka broker.

2021-05-12 Thread Jordan Moore (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17343202#comment-17343202 ] Jordan Moore commented on KAFKA-12534: -- According to this documentation, the listener name (in

[jira] [Commented] (KAFKA-12534) kafka-configs does not work with ssl enabled kafka broker.

2021-05-12 Thread Jordan Moore (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17343196#comment-17343196 ] Jordan Moore commented on KAFKA-12534: -- It would appear my original comment has solved your error

[jira] [Commented] (KAFKA-12668) MockScheduler is not safe to use in concurrent code.

2021-05-12 Thread Maksim Iakunin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17343191#comment-17343191 ] Maksim Iakunin commented on KAFKA-12668: [~jagsancio], hello! Could you give me some test-case

[jira] [Created] (KAFKA-12774) kafka-streams 2.8: logging in uncaught-exceptionhandler doesn't go through log4j

2021-05-12 Thread Jira
Jørgen created KAFKA-12774: -- Summary: kafka-streams 2.8: logging in uncaught-exceptionhandler doesn't go through log4j Key: KAFKA-12774 URL: https://issues.apache.org/jira/browse/KAFKA-12774 Project: Kafka

[jira] [Commented] (KAFKA-12534) kafka-configs does not work with ssl enabled kafka broker.

2021-05-12 Thread kaushik srinivas (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17343135#comment-17343135 ] kaushik srinivas commented on KAFKA-12534: -- Hi [~cricket007] We have tried this out. File

[GitHub] [kafka] dongjinleekr opened a new pull request #10678: TRIVIAL: Fix type inconsistencies, unthrown exceptions, etc

2021-05-12 Thread GitBox
dongjinleekr opened a new pull request #10678: URL: https://github.com/apache/kafka/pull/10678 I found these glitches while working on [KAFKA-12768](https://issues.apache.org/jira/browse/KAFKA-12768), etc. Here are some explanations on the last commit: As of present,

[GitHub] [kafka] DuongPTIT opened a new pull request #10677: KAFKA-12380 Executor in Connect's Worker is not shut down when the worker is

2021-05-12 Thread GitBox
DuongPTIT opened a new pull request #10677: URL: https://github.com/apache/kafka/pull/10677 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

[GitHub] [kafka] chia7712 commented on a change in pull request #10673: MINOR: set replication.factor to 1 to make StreamsBrokerCompatibility…

2021-05-12 Thread GitBox
chia7712 commented on a change in pull request #10673: URL: https://github.com/apache/kafka/pull/10673#discussion_r630800233 ## File path: tests/kafkatest/services/streams.py ## @@ -466,6 +466,15 @@ def __init__(self, test_context, kafka, processingMode):

[GitHub] [kafka] chia7712 merged pull request #10671: MINOR: exclude all `src/generated` and `src/generated-test`

2021-05-12 Thread GitBox
chia7712 merged pull request #10671: URL: https://github.com/apache/kafka/pull/10671 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [kafka] chia7712 commented on pull request #10671: MINOR: exclude all `src/generated` and `src/generated-test`

2021-05-12 Thread GitBox
chia7712 commented on pull request #10671: URL: https://github.com/apache/kafka/pull/10671#issuecomment-839530020 > Thanks @chia7712 . Can you verify this by creating some test directories/file that follow this pattern, and make sure they don't show up? I had a vague impression that

[jira] [Commented] (KAFKA-3539) KafkaProducer.send() may block even though it returns the Future

2021-05-12 Thread Ewen Cheslack-Postava (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-3539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17343043#comment-17343043 ] Ewen Cheslack-Postava commented on KAFKA-3539: -- [~mjsax] They aren't really duplicates. It's

[GitHub] [kafka] holmofy commented on pull request #161: KAFKA-1543: Changing replication factor

2021-05-12 Thread GitBox
holmofy commented on pull request #161: URL: https://github.com/apache/kafka/pull/161#issuecomment-839495865 Excuse me, is this feature supported now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (KAFKA-12635) Mirrormaker 2 offset sync is incorrect if the target partition is empty

2021-05-12 Thread Ning Zhang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17343028#comment-17343028 ] Ning Zhang commented on KAFKA-12635: backport is a great point. I guess the review cycle will