[GitHub] [kafka] dengziming commented on pull request #10701: KAFKA-10437; Fix omitted TODO of KIP-478

2021-05-14 Thread GitBox
dengziming commented on pull request #10701: URL: https://github.com/apache/kafka/pull/10701#issuecomment-841594749 Hello @vvcephei, PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] dengziming opened a new pull request #10701: KAFKA-10437; Fix omitted TODO of KIP-478

2021-05-14 Thread GitBox
dengziming opened a new pull request #10701: URL: https://github.com/apache/kafka/pull/10701 *More detailed description of your change* It seems that #9396 leaves out a TODO, just fix it. *Summary of testing strategy (including rationale)* QA ### Committer Checklist

[GitHub] [kafka] zhaohaidao opened a new pull request #10700: KAFKA-12789: Remove Stale comments for meta response handling logic

2021-05-14 Thread GitBox
zhaohaidao opened a new pull request #10700: URL: https://github.com/apache/kafka/pull/10700 According to my understanding, the following paragraph looks like a stale comments. > public void handleSuccessfulResponse(RequestHeader requestHeader, long now, MetadataResponse response)

[jira] [Commented] (KAFKA-12776) Producer sends messages out-of-order inspite of enabling idempotence

2021-05-14 Thread NEERAJ VAIDYA (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344958#comment-17344958 ] NEERAJ VAIDYA commented on KAFKA-12776: --- [~ableegoldman], [~ijuma], [~tombentley] I think I kind

[jira] [Updated] (KAFKA-12789) Remove Stale comments for meta response handling logic

2021-05-14 Thread HaiyuanZhao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] HaiyuanZhao updated KAFKA-12789: Description: According to my understanding, the following paragraph looks like a stale comments.

[jira] [Updated] (KAFKA-12789) Remove Stale comments for meta response handling logic

2021-05-14 Thread HaiyuanZhao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] HaiyuanZhao updated KAFKA-12789: Description: According to my understanding, the following paragraph looks like a stale comments.

[jira] [Updated] (KAFKA-12789) Remove Stale comments for meta response handling logic

2021-05-14 Thread HaiyuanZhao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] HaiyuanZhao updated KAFKA-12789: Description: According to my understanding, the following paragraph looks like a stale comments.

[jira] [Updated] (KAFKA-12789) Remove Stale comments for meta response handling logic

2021-05-14 Thread HaiyuanZhao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] HaiyuanZhao updated KAFKA-12789: Description: According to my understanding, the following paragraph looks like a stale comments?

[jira] [Created] (KAFKA-12789) Remove Stale comments for meta response handling logic

2021-05-14 Thread HaiyuanZhao (Jira)
HaiyuanZhao created KAFKA-12789: --- Summary: Remove Stale comments for meta response handling logic Key: KAFKA-12789 URL: https://issues.apache.org/jira/browse/KAFKA-12789 Project: Kafka Issue

[GitHub] [kafka] ccding commented on pull request #10684: MINOR: Improve Log layer segment iteration logic and few other areas

2021-05-14 Thread GitBox
ccding commented on pull request #10684: URL: https://github.com/apache/kafka/pull/10684#issuecomment-841577947 LGTM Thanks @kowshik -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] junrao commented on a change in pull request #10494: KAFKA-12788: improve KRaft replica placement

2021-05-14 Thread GitBox
junrao commented on a change in pull request #10494: URL: https://github.com/apache/kafka/pull/10494#discussion_r632872729 ## File path: metadata/src/test/java/org/apache/kafka/controller/StripedReplicaPlacerTest.java ## @@ -0,0 +1,213 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] dielhennr commented on a change in pull request #10572: KAFKA-12697: Add OfflinePartitionCount and PreferredReplicaImbalanceCount metrics to Quorum Controller

2021-05-14 Thread GitBox
dielhennr commented on a change in pull request #10572: URL: https://github.com/apache/kafka/pull/10572#discussion_r632858915 ## File path: metadata/src/main/java/org/apache/kafka/controller/BrokersToIsrs.java ## @@ -139,10 +140,16 @@ public TopicIdPartition next() { *

[GitHub] [kafka] cmccabe commented on a change in pull request #10572: KAFKA-12697: Add OfflinePartitionCount and PreferredReplicaImbalanceCount metrics to Quorum Controller

2021-05-14 Thread GitBox
cmccabe commented on a change in pull request #10572: URL: https://github.com/apache/kafka/pull/10572#discussion_r632857030 ## File path: metadata/src/main/java/org/apache/kafka/controller/BrokersToIsrs.java ## @@ -139,10 +140,16 @@ public TopicIdPartition next() { *

[GitHub] [kafka] cmccabe opened a new pull request #10699: MINOR: Add support for ZK Authorizer with KRaft

2021-05-14 Thread GitBox
cmccabe opened a new pull request #10699: URL: https://github.com/apache/kafka/pull/10699 This patch adds support for running the ZooKeeper-based kafka.security.authorizer.AclAuthorizer with KRaft clusters. Set the authorizer.class.name config as well as the zookeeper.connect config while

[jira] [Commented] (KAFKA-12776) Producer sends messages out-of-order inspite of enabling idempotence

2021-05-14 Thread NEERAJ VAIDYA (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344914#comment-17344914 ] NEERAJ VAIDYA commented on KAFKA-12776: --- [~tombentley] Yes, this has been reproduced with a

[GitHub] [kafka] rondagostino commented on pull request #10694: MINOR: fix system test TestSecurityRollingUpgrade

2021-05-14 Thread GitBox
rondagostino commented on pull request #10694: URL: https://github.com/apache/kafka/pull/10694#issuecomment-841512146 Full system test output here:

[GitHub] [kafka] cmccabe commented on a change in pull request #10494: KAFKA-12788: improve KRaft replica placement

2021-05-14 Thread GitBox
cmccabe commented on a change in pull request #10494: URL: https://github.com/apache/kafka/pull/10494#discussion_r632806423 ## File path: metadata/src/test/java/org/apache/kafka/controller/StripedReplicaPlacerTest.java ## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] dejan2609 opened a new pull request #10698: KAFKA-12770: introduce `checkstyleVersion` build option (for overriding CheckStyle project-defined dependency version)

2021-05-14 Thread GitBox
dejan2609 opened a new pull request #10698: URL: https://github.com/apache/kafka/pull/10698 @ijuma please review this. JIRA ticket: https://issues.apache.org/jira/browse/KAFKA-12770 Related PR/comment: https://github.com/apache/kafka/pull/10656#issuecomment-835809154

[GitHub] [kafka] cmccabe commented on a change in pull request #10494: KAFKA-12788: improve KRaft replica placement

2021-05-14 Thread GitBox
cmccabe commented on a change in pull request #10494: URL: https://github.com/apache/kafka/pull/10494#discussion_r632796785 ## File path: metadata/src/main/java/org/apache/kafka/controller/StripedReplicaPlacer.java ## @@ -0,0 +1,411 @@ +/* + * Licensed to the Apache Software

[jira] [Updated] (KAFKA-12770) Gradle build: allow the CheckStyle version to be specified via parameter

2021-05-14 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-12770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dejan Stojadinović updated KAFKA-12770: --- Summary: Gradle build: allow the CheckStyle version to be specified via parameter

[GitHub] [kafka] cmccabe commented on a change in pull request #10494: KAFKA-12788: improve KRaft replica placement

2021-05-14 Thread GitBox
cmccabe commented on a change in pull request #10494: URL: https://github.com/apache/kafka/pull/10494#discussion_r632796424 ## File path: metadata/src/main/java/org/apache/kafka/controller/StripedReplicaPlacer.java ## @@ -0,0 +1,411 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] ableegoldman commented on a change in pull request #10690: MINOR: clarify message ordering with max in-flight requests and idempotent producer

2021-05-14 Thread GitBox
ableegoldman commented on a change in pull request #10690: URL: https://github.com/apache/kafka/pull/10690#discussion_r632788590 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java ## @@ -247,9 +248,10 @@ public static final String

[GitHub] [kafka] ableegoldman commented on a change in pull request #10690: MINOR: clarify message ordering with max in-flight requests and idempotent producer

2021-05-14 Thread GitBox
ableegoldman commented on a change in pull request #10690: URL: https://github.com/apache/kafka/pull/10690#discussion_r632787843 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java ## @@ -201,7 +201,8 @@ public static final String

[jira] [Closed] (KAFKA-12754) TaskMetadata endOffsets does not update when the offsets are read

2021-05-14 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walker Carlson closed KAFKA-12754. -- > TaskMetadata endOffsets does not update when the offsets are read >

[jira] [Commented] (KAFKA-12754) TaskMetadata endOffsets does not update when the offsets are read

2021-05-14 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344864#comment-17344864 ] Walker Carlson commented on KAFKA-12754: Huh, I guess I was wrong. Sorry! > TaskMetadata

[jira] [Updated] (KAFKA-12754) TaskMetadata endOffsets does not update when the offsets are read

2021-05-14 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walker Carlson updated KAFKA-12754: --- Affects Version/s: (was: 2.8.0) > TaskMetadata endOffsets does not update when the

[jira] [Commented] (KAFKA-12754) TaskMetadata endOffsets does not update when the offsets are read

2021-05-14 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344863#comment-17344863 ] A. Sophie Blee-Goldman commented on KAFKA-12754: [~wcarlson5] are you sure? I tried to

[GitHub] [kafka] cmccabe commented on a change in pull request #10494: KAFKA-12788: improve KRaft replica placement

2021-05-14 Thread GitBox
cmccabe commented on a change in pull request #10494: URL: https://github.com/apache/kafka/pull/10494#discussion_r632770796 ## File path: metadata/src/test/java/org/apache/kafka/controller/StripedReplicaPlacerTest.java ## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] cmccabe commented on a change in pull request #10494: KAFKA-12788: improve KRaft replica placement

2021-05-14 Thread GitBox
cmccabe commented on a change in pull request #10494: URL: https://github.com/apache/kafka/pull/10494#discussion_r632769701 ## File path: metadata/src/test/java/org/apache/kafka/controller/StripedReplicaPlacerTest.java ## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache

[jira] [Commented] (KAFKA-12754) TaskMetadata endOffsets does not update when the offsets are read

2021-05-14 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344857#comment-17344857 ] Walker Carlson commented on KAFKA-12754: [~ableegoldman] I think picking back to 2.8 would be

[jira] [Updated] (KAFKA-12754) TaskMetadata endOffsets does not update when the offsets are read

2021-05-14 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walker Carlson updated KAFKA-12754: --- Affects Version/s: 2.8.0 > TaskMetadata endOffsets does not update when the offsets are

[jira] [Created] (KAFKA-12788) Improve KRaft replica placement

2021-05-14 Thread Colin McCabe (Jira)
Colin McCabe created KAFKA-12788: Summary: Improve KRaft replica placement Key: KAFKA-12788 URL: https://issues.apache.org/jira/browse/KAFKA-12788 Project: Kafka Issue Type: Improvement

[GitHub] [kafka] cmccabe commented on pull request #10494: KAFKA-12788: improve KRaft replica placement

2021-05-14 Thread GitBox
cmccabe commented on pull request #10494: URL: https://github.com/apache/kafka/pull/10494#issuecomment-841470406 > @cmccabe : Thanks for the PR. A few comments below. Also, we probably want to associate a jira with the PR since it's a bit large. Fair. I created KAFKA-12788 for this

[jira] [Resolved] (KAFKA-12471) Implement createPartitions in KIP-500 mode

2021-05-14 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe resolved KAFKA-12471. -- Fix Version/s: 3.0.0 Resolution: Fixed > Implement createPartitions in KIP-500 mode >

[jira] [Resolved] (KAFKA-12334) Add the KIP-631 metadata shell

2021-05-14 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe resolved KAFKA-12334. -- Fix Version/s: 2.8.0 Resolution: Fixed Added in 2.8 > Add the KIP-631 metadata shell

[jira] [Resolved] (KAFKA-12275) KIP-500: Remove controllerOnly restriction from the DecommissionBroker API

2021-05-14 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe resolved KAFKA-12275. -- Fix Version/s: 2.8.0 Assignee: Colin McCabe Resolution: Fixed

[GitHub] [kafka] cmccabe merged pull request #10688: KAFKA-12778: Fix QuorumController request timeouts and electLeaders

2021-05-14 Thread GitBox
cmccabe merged pull request #10688: URL: https://github.com/apache/kafka/pull/10688 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Created] (KAFKA-12787) Configure and integrate controller snapshot with the RaftClient

2021-05-14 Thread Jose Armando Garcia Sancio (Jira)
Jose Armando Garcia Sancio created KAFKA-12787: -- Summary: Configure and integrate controller snapshot with the RaftClient Key: KAFKA-12787 URL: https://issues.apache.org/jira/browse/KAFKA-12787

[jira] [Assigned] (KAFKA-12647) Implement loading snapshot in the broker

2021-05-14 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio reassigned KAFKA-12647: -- Assignee: Colin McCabe (was: Jose Armando Garcia Sancio) >

[jira] [Resolved] (KAFKA-12754) TaskMetadata endOffsets does not update when the offsets are read

2021-05-14 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman resolved KAFKA-12754. Fix Version/s: 3.0.0 Resolution: Fixed > TaskMetadata endOffsets

[jira] [Commented] (KAFKA-12754) TaskMetadata endOffsets does not update when the offsets are read

2021-05-14 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344835#comment-17344835 ] A. Sophie Blee-Goldman commented on KAFKA-12754: [~wcarlson5] was this feature released

[GitHub] [kafka] ableegoldman merged pull request #10634: KAFKA-12754: Improve endOffsets for TaskMetadata

2021-05-14 Thread GitBox
ableegoldman merged pull request #10634: URL: https://github.com/apache/kafka/pull/10634 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [kafka] ableegoldman commented on pull request #10634: KAFKA-12754: Improve endOffsets for TaskMetadata

2021-05-14 Thread GitBox
ableegoldman commented on pull request #10634: URL: https://github.com/apache/kafka/pull/10634#issuecomment-841450435 Looks like just the usual flaky test failures in the build: `RaftClusterTest.testCreateClusterAndCreateAndManyTopicsWithManyPartitions()` and

[GitHub] [kafka] rondagostino commented on pull request #10697: MINOR: Add @cluster annotation to StreamsNamedRepartitionTopicTest

2021-05-14 Thread GitBox
rondagostino commented on pull request #10697: URL: https://github.com/apache/kafka/pull/10697#issuecomment-841448877 Tested locally to confirm that the added size is the correct one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] rondagostino opened a new pull request #10697: MINOR: Add @cluster annotation to StreamsNamedRepartitionTopicTest

2021-05-14 Thread GitBox
rondagostino opened a new pull request #10697: URL: https://github.com/apache/kafka/pull/10697 The StreamsNamedRepartitionTopicTest system tests did not have the `@cluster` annotation and was therefore taking up the entire cluster. For example, we see this in the log output:

[GitHub] [kafka] dejan2609 commented on pull request #10606: KAFKA-12728: version upgrades: gradle (6.8.3 -->> 7.0.2) and gradle shadow plugin (6.1.0 -->> 7.0.0)

2021-05-14 Thread GitBox
dejan2609 commented on pull request #10606: URL: https://github.com/apache/kafka/pull/10606#issuecomment-841421148 Test result on Jenkins shows no failures. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] cmccabe commented on pull request #10688: KAFKA-12778: Fix QuorumController request timeouts and electLeaders

2021-05-14 Thread GitBox
cmccabe commented on pull request #10688: URL: https://github.com/apache/kafka/pull/10688#issuecomment-841410862 > Generally, I don't like that we need to explicitly extract the timeout from the request and pass it into the controller call. It would nice if this could be generalized or

[GitHub] [kafka] mumrah opened a new pull request #10696: KAFKA-12777 Refactor and cleanup AutoTopicCreationManager

2021-05-14 Thread GitBox
mumrah opened a new pull request #10696: URL: https://github.com/apache/kafka/pull/10696 Rather than using multiple optional class members to determine if we are in ZK or KRaft mode, use inheritance. The factory method in AutoTopicCreationManager now makes the decision about which mode

[GitHub] [kafka] cmccabe commented on a change in pull request #10688: KAFKA-12778: Fix QuorumController request timeouts and electLeaders

2021-05-14 Thread GitBox
cmccabe commented on a change in pull request #10688: URL: https://github.com/apache/kafka/pull/10688#discussion_r632697059 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -800,19 +800,44 @@ void handleBrokerUnfenced(int

[GitHub] [kafka] cmccabe commented on a change in pull request #10688: KAFKA-12778: Fix QuorumController request timeouts and electLeaders

2021-05-14 Thread GitBox
cmccabe commented on a change in pull request #10688: URL: https://github.com/apache/kafka/pull/10688#discussion_r632696250 ## File path: metadata/src/main/java/org/apache/kafka/controller/QuorumController.java ## @@ -1165,4 +1192,22 @@ public long curClaimEpoch() {

[GitHub] [kafka] cmccabe commented on a change in pull request #10688: KAFKA-12778: Fix QuorumController request timeouts and electLeaders

2021-05-14 Thread GitBox
cmccabe commented on a change in pull request #10688: URL: https://github.com/apache/kafka/pull/10688#discussion_r632695450 ## File path: metadata/src/main/java/org/apache/kafka/controller/QuorumController.java ## @@ -1030,17 +1050,24 @@ private QuorumController(LogContext

[GitHub] [kafka] cmccabe commented on a change in pull request #10688: KAFKA-12778: Fix QuorumController request timeouts and electLeaders

2021-05-14 Thread GitBox
cmccabe commented on a change in pull request #10688: URL: https://github.com/apache/kafka/pull/10688#discussion_r632695254 ## File path: metadata/src/main/java/org/apache/kafka/controller/QuorumController.java ## @@ -1002,7 +1013,13 @@ private QuorumController(LogContext

[GitHub] [kafka] wcarlson5 commented on a change in pull request #10664: KAFKA-12749: Changelog topic config on suppressed KTable lost

2021-05-14 Thread GitBox
wcarlson5 commented on a change in pull request #10664: URL: https://github.com/apache/kafka/pull/10664#discussion_r632673138 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/SuppressedTest.java ## @@ -46,13 +48,13 @@ public void

[GitHub] [kafka] cmccabe opened a new pull request #10695: KAFKA-12783: Remove the deprecated ZK-based partition reassignment API

2021-05-14 Thread GitBox
cmccabe opened a new pull request #10695: URL: https://github.com/apache/kafka/pull/10695 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [kafka] rondagostino opened a new pull request #10694: MINOR: fix system test TestSecurityRollingUpgrade

2021-05-14 Thread GitBox
rondagostino opened a new pull request #10694: URL: https://github.com/apache/kafka/pull/10694 SecurityConfig for a Kafka cluster in a system test is cached due to https://github.com/apache/kafka/pull/8917, but we mutate the security config during some system tests, and those mutations

[jira] [Commented] (KAFKA-3968) fsync() is not called on parent directory when new FileMessageSet is flushed to disk

2021-05-14 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-3968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344701#comment-17344701 ] Jun Rao commented on KAFKA-3968: Merged the reworked PR [https://github.com/apache/kafka/pull/10680] to

[GitHub] [kafka] junrao merged pull request #10680: Rework on KAFKA-3968: fsync the parent directory of a segment file when the file is created

2021-05-14 Thread GitBox
junrao merged pull request #10680: URL: https://github.com/apache/kafka/pull/10680 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[jira] [Updated] (KAFKA-12761) Consumer offsets are deleted 7 days after last offset commit instead of EMPTY status

2021-05-14 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-12761: Component/s: (was: streams) > Consumer offsets are deleted 7 days after last offset

[GitHub] [kafka] wcarlson5 commented on pull request #10634: KAFKA-12754: Improve endOffsets for TaskMetadata

2021-05-14 Thread GitBox
wcarlson5 commented on pull request #10634: URL: https://github.com/apache/kafka/pull/10634#issuecomment-841342581 @ableegoldman I think it ready :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] wcarlson5 commented on a change in pull request #10634: KAFKA-12754: Improve endOffsets for TaskMetadata

2021-05-14 Thread GitBox
wcarlson5 commented on a change in pull request #10634: URL: https://github.com/apache/kafka/pull/10634#discussion_r632637377 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/TaskMetadataIntegrationTest.java ## @@ -0,0 +1,200 @@ +/* + * Licensed to the

[GitHub] [kafka] mumrah commented on a change in pull request #10688: KAFKA-12778: Fix QuorumController request timeouts and electLeaders

2021-05-14 Thread GitBox
mumrah commented on a change in pull request #10688: URL: https://github.com/apache/kafka/pull/10688#discussion_r632616511 ## File path: metadata/src/main/java/org/apache/kafka/controller/QuorumController.java ## @@ -1002,7 +1013,13 @@ private QuorumController(LogContext

[GitHub] [kafka] lbradstreet commented on a change in pull request #10620: KAFKA-12736: KafkaProducer.flush holds onto completed ProducerBatch(s) until flush completes

2021-05-14 Thread GitBox
lbradstreet commented on a change in pull request #10620: URL: https://github.com/apache/kafka/pull/10620#discussion_r632614924 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java ## @@ -710,8 +710,11 @@ private boolean

[GitHub] [kafka] dejan2609 commented on pull request #10606: KAFKA-12728: version upgrades: gradle (6.8.3 -->> 7.0.2) and gradle shadow plugin (6.1.0 -->> 7.0.0)

2021-05-14 Thread GitBox
dejan2609 commented on pull request #10606: URL: https://github.com/apache/kafka/pull/10606#issuecomment-841303016 Bumped/force-pushed (I took the liberty to skipped local testing on my end just to save some time). -- This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] ijuma commented on pull request #10606: KAFKA-12728: version upgrades: gradle (6.8.3 -->> 7.0.1) and gradle shadow plugin (6.1.0 -->> 7.0.0)

2021-05-14 Thread GitBox
ijuma commented on pull request #10606: URL: https://github.com/apache/kafka/pull/10606#issuecomment-841294495 Let's bump it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] dejan2609 edited a comment on pull request #10606: KAFKA-12728: version upgrades: gradle (6.8.3 -->> 7.0.1) and gradle shadow plugin (6.1.0 -->> 7.0.0)

2021-05-14 Thread GitBox
dejan2609 edited a comment on pull request #10606: URL: https://github.com/apache/kafka/pull/10606#issuecomment-841291321 FYI/note: Gradle 7.0.2 hotfix is released few hours ago (it solves one corner case on Alpine Linux): https://github.com/gradle/gradle/releases/tag/v7.0.2 Let me

[GitHub] [kafka] dejan2609 edited a comment on pull request #10606: KAFKA-12728: version upgrades: gradle (6.8.3 -->> 7.0.1) and gradle shadow plugin (6.1.0 -->> 7.0.0)

2021-05-14 Thread GitBox
dejan2609 edited a comment on pull request #10606: URL: https://github.com/apache/kafka/pull/10606#issuecomment-841291321 FYI/note: Gradle 7.0.2 hotfix is released few hours ago (it solves one corner case on Alpine Linux): https://github.com/gradle/gradle/releases/tag/v7.0.2 Let me

[GitHub] [kafka] dejan2609 commented on pull request #10606: KAFKA-12728: version upgrades: gradle (6.8.3 -->> 7.0.1) and gradle shadow plugin (6.1.0 -->> 7.0.0)

2021-05-14 Thread GitBox
dejan2609 commented on pull request #10606: URL: https://github.com/apache/kafka/pull/10606#issuecomment-841291321 FYI/note: Gradle 7.0.2 hotfix is released few hours ago (it solves one corner case on Alpine Linux): https://github.com/gradle/gradle/releases/tag/v7.0.2 Let me know

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10528: KAFKA-12497: Skip unnecessary source task offset commits

2021-05-14 Thread GitBox
kpatelatwork commented on a change in pull request #10528: URL: https://github.com/apache/kafka/pull/10528#discussion_r632541366 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/SourceTaskOffsetCommitter.java ## @@ -105,6 +105,11 @@ public void

[jira] [Commented] (KAFKA-12776) Producer sends messages out-of-order inspite of enabling idempotence

2021-05-14 Thread Tom Bentley (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344595#comment-17344595 ] Tom Bentley commented on KAFKA-12776: - [~neeraj.vaidya] can you reproduce this without using Spring,

[GitHub] [kafka] ijuma commented on a change in pull request #10690: MINOR: clarify message ordering with max in-flight requests and idempotent producer

2021-05-14 Thread GitBox
ijuma commented on a change in pull request #10690: URL: https://github.com/apache/kafka/pull/10690#discussion_r632510173 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java ## @@ -247,9 +248,10 @@ public static final String

[GitHub] [kafka] ijuma commented on a change in pull request #10690: MINOR: clarify message ordering with max in-flight requests and idempotent producer

2021-05-14 Thread GitBox
ijuma commented on a change in pull request #10690: URL: https://github.com/apache/kafka/pull/10690#discussion_r632509174 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java ## @@ -201,7 +201,8 @@ public static final String

[jira] [Comment Edited] (KAFKA-12776) Producer sends messages out-of-order inspite of enabling idempotence

2021-05-14 Thread NEERAJ VAIDYA (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344517#comment-17344517 ] NEERAJ VAIDYA edited comment on KAFKA-12776 at 5/14/21, 12:51 PM: -- Hi

[jira] [Comment Edited] (KAFKA-12776) Producer sends messages out-of-order inspite of enabling idempotence

2021-05-14 Thread NEERAJ VAIDYA (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344517#comment-17344517 ] NEERAJ VAIDYA edited comment on KAFKA-12776 at 5/14/21, 12:51 PM: -- Hi

[jira] [Created] (KAFKA-12786) Getting SslTransportLayerTest error

2021-05-14 Thread Sibelle (Jira)
Sibelle created KAFKA-12786: --- Summary: Getting SslTransportLayerTest error Key: KAFKA-12786 URL: https://issues.apache.org/jira/browse/KAFKA-12786 Project: Kafka Issue Type: Bug

[GitHub] [kafka] AndroideRob commented on a change in pull request #10591: Fix minor bugs in the existing documentation

2021-05-14 Thread GitBox
AndroideRob commented on a change in pull request #10591: URL: https://github.com/apache/kafka/pull/10591#discussion_r632489696 ## File path: docs/ops.html ## @@ -78,7 +78,7 @@ auto.leader.rebalance.enable=true You can also set this to false, but you will then need

[GitHub] [kafka] jlprat commented on pull request #10693: KAFKA-12625: Fix the NOTICE file

2021-05-14 Thread GitBox
jlprat commented on pull request #10693: URL: https://github.com/apache/kafka/pull/10693#issuecomment-841197433 Failures were https://issues.apache.org/jira/browse/KAFKA-9009 and https://issues.apache.org/jira/browse/KAFKA-12629 -- This is an automated message from the Apache Git

[jira] [Commented] (KAFKA-12774) kafka-streams 2.8: logging in uncaught-exceptionhandler doesn't go through log4j

2021-05-14 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-12774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344537#comment-17344537 ] Jørgen commented on KAFKA-12774: It actually works as expected when throwing from selectKey  So it

[GitHub] [kafka] jlprat commented on a change in pull request #10693: KAFKA-12625: Fix the NOTICE file

2021-05-14 Thread GitBox
jlprat commented on a change in pull request #10693: URL: https://github.com/apache/kafka/pull/10693#discussion_r632410626 ## File path: LICENSE-binary ## @@ -243,7 +243,6 @@ netty-handler-4.1.59.Final netty-resolver-4.1.59.Final netty-transport-4.1.59.Final

[GitHub] [kafka] jlprat commented on pull request #10651: MINOR: Kafka Streams code samples formating unification

2021-05-14 Thread GitBox
jlprat commented on pull request #10651: URL: https://github.com/apache/kafka/pull/10651#issuecomment-841165081 @cadonna Would you like me to split this PR into several ones? One per file, for example? -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (KAFKA-12776) Producer sends messages out-of-order inspite of enabling idempotence

2021-05-14 Thread NEERAJ VAIDYA (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344517#comment-17344517 ] NEERAJ VAIDYA commented on KAFKA-12776: --- Hi Tom The topic has just 1 partition. > Producer sends

[jira] [Commented] (KAFKA-10201) Update codebase to use more inclusive terms

2021-05-14 Thread Omnia Ibrahim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344516#comment-17344516 ] Omnia Ibrahim commented on KAFKA-10201: --- [~xvrl] if you still need help with the remaining items I

[GitHub] [kafka] jlprat commented on a change in pull request #10693: KAFKA-12625: Fix the NOTICE file

2021-05-14 Thread GitBox
jlprat commented on a change in pull request #10693: URL: https://github.com/apache/kafka/pull/10693#discussion_r632410626 ## File path: LICENSE-binary ## @@ -243,7 +243,6 @@ netty-handler-4.1.59.Final netty-resolver-4.1.59.Final netty-transport-4.1.59.Final

[GitHub] [kafka] jlprat commented on pull request #10693: KAFKA-12625: Fix the NOTICE file

2021-05-14 Thread GitBox
jlprat commented on pull request #10693: URL: https://github.com/apache/kafka/pull/10693#issuecomment-841123185 I would highly appreciate any hint on how to proceed for the dependencies that do not include a notice file in their jar files but might include them in their source code

[GitHub] [kafka] jlprat opened a new pull request #10693: KAFKA-12625: Fix the NOTICE file

2021-05-14 Thread GitBox
jlprat opened a new pull request #10693: URL: https://github.com/apache/kafka/pull/10693 Adds new NOTICE-binary file and packages it in the binary release This follows up the https://github.com/apache/kafka/pull/10474 pull where LICENSE was fix. Similarly as in that PR, I do not

[jira] [Created] (KAFKA-12784) ssl kafka failed

2021-05-14 Thread Trofimov (Jira)
Trofimov created KAFKA-12784: Summary: ssl kafka failed Key: KAFKA-12784 URL: https://issues.apache.org/jira/browse/KAFKA-12784 Project: Kafka Issue Type: Task Components: config,

[jira] [Updated] (KAFKA-6987) Reimplement KafkaFuture with CompletableFuture

2021-05-14 Thread Tom Bentley (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tom Bentley updated KAFKA-6987: --- Fix Version/s: 3.0.0 > Reimplement KafkaFuture with CompletableFuture >

[GitHub] [kafka] mimaison commented on pull request #10660: MINOR: Updating files with release 2.7.1

2021-05-14 Thread GitBox
mimaison commented on pull request #10660: URL: https://github.com/apache/kafka/pull/10660#issuecomment-841103731 Thanks @mjsax, I can see the artifacts now. I've rekicked the build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] cadonna commented on a change in pull request #10646: KAFKA-8897 Follow-up: Consolidate the global state stores

2021-05-14 Thread GitBox
cadonna commented on a change in pull request #10646: URL: https://github.com/apache/kafka/pull/10646#discussion_r632371505 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java ## @@ -128,8 +129,7 @@ public void

[GitHub] [kafka] ableegoldman commented on pull request #10690: MINOR: clarify message ordering with max in-flight requests and idempotent producer

2021-05-14 Thread GitBox
ableegoldman commented on pull request #10690: URL: https://github.com/apache/kafka/pull/10690#issuecomment-841084469 Wow, all checks actually passed! That's the second completely green build I've seen in 24 hours, must be my lucky day  -- This is an automated message from the Apache

[GitHub] [kafka] ableegoldman commented on a change in pull request #10690: MINOR: clarify message ordering with max in-flight requests and idempotent producer

2021-05-14 Thread GitBox
ableegoldman commented on a change in pull request #10690: URL: https://github.com/apache/kafka/pull/10690#discussion_r632355592 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java ## @@ -247,9 +248,10 @@ public static final String

[jira] [Assigned] (KAFKA-12625) Fix the NOTICE file

2021-05-14 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josep Prat reassigned KAFKA-12625: -- Assignee: Josep Prat > Fix the NOTICE file > --- > > Key:

[jira] [Commented] (KAFKA-12625) Fix the NOTICE file

2021-05-14 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344377#comment-17344377 ] Josep Prat commented on KAFKA-12625: [~vvcephei] As I see no assignee neither any PR in Github on

[jira] [Commented] (KAFKA-12776) Producer sends messages out-of-order inspite of enabling idempotence

2021-05-14 Thread Tom Bentley (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344376#comment-17344376 ] Tom Bentley commented on KAFKA-12776: - [~neeraj.vaidya] how many partitions does the topic have? I

[GitHub] [kafka] dejan2609 edited a comment on pull request #10606: KAFKA-12728: version upgrades: gradle (6.8.3 -->> 7.0.1) and gradle shadow plugin (6.1.0 -->> 7.0.0)

2021-05-14 Thread GitBox
dejan2609 edited a comment on pull request #10606: URL: https://github.com/apache/kafka/pull/10606#issuecomment-841055689 PR rebased, commits are squashed into one; tests on Jenkins are looking good: it seems that only one unrelated test failed. -- This is an automated message from the

[GitHub] [kafka] dejan2609 commented on pull request #10606: KAFKA-12728: version upgrades: gradle (6.8.3 -->> 7.0.1) and gradle shadow plugin (6.1.0 -->> 7.0.0)

2021-05-14 Thread GitBox
dejan2609 commented on pull request #10606: URL: https://github.com/apache/kafka/pull/10606#issuecomment-841055689 It seems that only one unrelated test failed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (KAFKA-12775) StreamsPartitionAssignor / ClientState throws an exception when a new Task gets added to a KStreams Application in a Backwards-Compatible Topology Change

2021-05-14 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344367#comment-17344367 ] Bruno Cadonna commented on KAFKA-12775: --- [~nhab] Would upgrading all Kafka Streams clients at once