[GitHub] [kafka] vahidhashemian commented on a change in pull request #10552: KAFKA-12675: improve the sticky general assignor scalability and performance

2021-05-23 Thread GitBox
vahidhashemian commented on a change in pull request #10552: URL: https://github.com/apache/kafka/pull/10552#discussion_r637664106 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -80,9 +80,7 @@ public

[GitHub] [kafka] dengziming commented on pull request #10748: MINOR: Add missing apiversion test for 3.0

2021-05-23 Thread GitBox
dengziming commented on pull request #10748: URL: https://github.com/apache/kafka/pull/10748#issuecomment-846699211 ping @mumrah for a review, maybe you forgot it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] dengziming opened a new pull request #10748: MINOR: Add missing apiversion test for 3.0

2021-05-23 Thread GitBox
dengziming opened a new pull request #10748: URL: https://github.com/apache/kafka/pull/10748 *More detailed description of your change* #10504 bump apiversion to 3.0.0, we'd better also add test for it. *Summary of testing strategy (including rationale)* Unit test --

[GitHub] [kafka] fqaiser94 commented on a change in pull request #10747: KAFKA-12446: Define KGroupedTable#aggregate subtractor + adder order of execution

2021-05-23 Thread GitBox
fqaiser94 commented on a change in pull request #10747: URL: https://github.com/apache/kafka/pull/10747#discussion_r637657442 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/ChangedSerializer.java ## @@ -45,34 +45,30 @@ public void

[GitHub] [kafka] fqaiser94 opened a new pull request #10747: KAFKA-12446: Define KGroupedTable#aggregate subtractor + adder order of execution

2021-05-23 Thread GitBox
fqaiser94 opened a new pull request #10747: URL: https://github.com/apache/kafka/pull/10747 # Problem For context, this issue was initially raised in the following

[jira] [Commented] (KAFKA-12773) Use UncheckedIOException when wrapping IOException

2021-05-23 Thread loboxu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350212#comment-17350212 ] loboxu commented on KAFKA-12773: ok > Use UncheckedIOException when wrapping IOException >

[jira] [Updated] (KAFKA-12839) SlidingWindow with timeDifference zero fails

2021-05-23 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-12839: Summary: SlidingWindow with timeDifference zero fails (was: SlidingWindow with

[jira] [Updated] (KAFKA-12839) SlidingWindow with timeDifference 0 fails

2021-05-23 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-12839: Summary: SlidingWindow with timeDifference 0 fails (was: SlidingWindow with size 0

[GitHub] [kafka] mjsax commented on pull request #10722: MINOR: update java doc for deprecated methods

2021-05-23 Thread GitBox
mjsax commented on pull request #10722: URL: https://github.com/apache/kafka/pull/10722#issuecomment-846673350 Thanks for the PR @showuon! Merged to `trunk`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] mjsax merged pull request #10722: MINOR: update java doc for deprecated methods

2021-05-23 Thread GitBox
mjsax merged pull request #10722: URL: https://github.com/apache/kafka/pull/10722 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[jira] [Updated] (KAFKA-12839) SlidingWindow with size 0 fails

2021-05-23 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-12839: Labels: needs-kip (was: ) > SlidingWindow with size 0 fails >

[GitHub] [kafka] satishd commented on pull request #10733: KAFKA-12816 Added tiered storage related configs including remote log manager configs.

2021-05-23 Thread GitBox
satishd commented on pull request #10733: URL: https://github.com/apache/kafka/pull/10733#issuecomment-846647638 @junrao @kowshik Please review the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Comment Edited] (KAFKA-8295) Optimize count() using RocksDB merge operator

2021-05-23 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350117#comment-17350117 ] Sagar Rao edited comment on KAFKA-8295 at 5/23/21, 6:54 PM: [~ableegoldman], 

[jira] [Commented] (KAFKA-9168) Integrate JNI direct buffer support to RocksDBStore

2021-05-23 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350118#comment-17350118 ] Sagar Rao commented on KAFKA-9168: -- [~ableegoldman], looks like Bruno has done his work on 

[jira] [Commented] (KAFKA-8295) Optimize count() using RocksDB merge operator

2021-05-23 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350117#comment-17350117 ] Sagar Rao commented on KAFKA-8295: -- [~ableegoldman],  So, I extended the rocksjava benchmarking code

[jira] [Commented] (KAFKA-12773) Use UncheckedIOException when wrapping IOException

2021-05-23 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350078#comment-17350078 ] Jose Armando Garcia Sancio commented on KAFKA-12773: No KIP is required for this

[GitHub] [kafka] KahnCheny opened a new pull request #10746: MINOR: remove unneccessary public keyword from ProducerInterceptor interface

2021-05-23 Thread GitBox
KahnCheny opened a new pull request #10746: URL: https://github.com/apache/kafka/pull/10746 remove unneccessary public keyword from ProducerInterceptor interface -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] tang7526 commented on a change in pull request #10534: KAFKA-806: Index may not always observe log.index.interval.bytes

2021-05-23 Thread GitBox
tang7526 commented on a change in pull request #10534: URL: https://github.com/apache/kafka/pull/10534#discussion_r637506753 ## File path: core/src/main/scala/kafka/log/LogSegment.scala ## @@ -162,15 +162,43 @@ class LogSegment private[log] (val log: FileRecords, //

[GitHub] [kafka] tang7526 commented on a change in pull request #10534: KAFKA-806: Index may not always observe log.index.interval.bytes

2021-05-23 Thread GitBox
tang7526 commented on a change in pull request #10534: URL: https://github.com/apache/kafka/pull/10534#discussion_r637506676 ## File path: core/src/main/scala/kafka/log/LogSegment.scala ## @@ -162,15 +162,43 @@ class LogSegment private[log] (val log: FileRecords, //