[GitHub] [kafka] kamalcph commented on pull request #10602: KAFKA-12724: Add 2.8.0 to system tests and streams upgrade tests.

2021-07-08 Thread GitBox
kamalcph commented on pull request #10602: URL: https://github.com/apache/kafka/pull/10602#issuecomment-876277111 @vvcephei Resolved the conflicts. Ran the below tests: ``` ./gradlew :streams:testAll TC_PATHS="tests/kafkatest/tests/streams/streams_upgrade_test.py" bash

[GitHub] [kafka] kamalcph commented on a change in pull request #10602: KAFKA-12724: Add 2.8.0 to system tests and streams upgrade tests.

2021-07-08 Thread GitBox
kamalcph commented on a change in pull request #10602: URL: https://github.com/apache/kafka/pull/10602#discussion_r666016083 ## File path: tests/kafkatest/tests/streams/streams_upgrade_test.py ## @@ -25,12 +25,12 @@ from kafkatest.services.zookeeper import ZookeeperService

[GitHub] [kafka] dongjinleekr commented on pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

2021-07-08 Thread GitBox
dongjinleekr commented on pull request #7898: URL: https://github.com/apache/kafka/pull/7898#issuecomment-876265899 Rebased onto the latest trunk. Could anyone review this PR? :bow: cc/ @kkonstantine -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] dongjinleekr commented on pull request #10826: KAFKA-7632: Support Compression Level

2021-07-08 Thread GitBox
dongjinleekr commented on pull request #10826: URL: https://github.com/apache/kafka/pull/10826#issuecomment-876259060 @kkonstantine Here it is - I rebased it onto the latest trunk. Could anyone review this PR? :pray: -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] dongjinleekr commented on pull request #10472: KAFKA-12613: Inconsistencies between Kafka Config and Log Config

2021-07-08 Thread GitBox
dongjinleekr commented on pull request #10472: URL: https://github.com/apache/kafka/pull/10472#issuecomment-876258437 @kowshik @rajinisivaram Could you kindly have a look? :bowing_man: -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] dongjinleekr removed a comment on pull request #10678: TRIVIAL: Fix type inconsistencies, unthrown exceptions, etc

2021-07-08 Thread GitBox
dongjinleekr removed a comment on pull request #10678: URL: https://github.com/apache/kafka/pull/10678#issuecomment-864781801 Rebased onto the latest trunk. cc/ @ijuma @cadonna -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] dongjinleekr commented on pull request #10678: TRIVIAL: Fix type inconsistencies, unthrown exceptions, etc

2021-07-08 Thread GitBox
dongjinleekr commented on pull request #10678: URL: https://github.com/apache/kafka/pull/10678#issuecomment-876256809 Rebased onto the latest trunk. cc/ @ijuma -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] showuon commented on pull request #10794: KAFKA-12677: return not_controller error in envelope response itself

2021-07-08 Thread GitBox
showuon commented on pull request #10794: URL: https://github.com/apache/kafka/pull/10794#issuecomment-876252977 Failed tests are unrelated. Thanks. ``` Build / ARM / kafka.raft.KafkaMetadataLogTest.testDeleteSnapshots() Build / ARM /

[GitHub] [kafka] showuon commented on pull request #10987: MINOR: improve the partitioner.class doc

2021-07-08 Thread GitBox
showuon commented on pull request #10987: URL: https://github.com/apache/kafka/pull/10987#issuecomment-876198201 @jolshan , I've updated. Also, thanks for pointing to the JIRA issue, I'll take a look when available. Please let me know if you have other suggestion. Thank you.

[GitHub] [kafka] showuon commented on pull request #10973: KAFKA-13033: COORDINATOR_NOT_AVAILABLE should be unmapped

2021-07-08 Thread GitBox
showuon commented on pull request #10973: URL: https://github.com/apache/kafka/pull/10973#issuecomment-876157588 @skaundinya15 , please take a look again when available. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] showuon commented on pull request #10973: KAFKA-13033: COORDINATOR_NOT_AVAILABLE should be unmapped

2021-07-08 Thread GitBox
showuon commented on pull request #10973: URL: https://github.com/apache/kafka/pull/10973#issuecomment-876157212 Failed tests are unrelated: ``` Build / ARM / kafka.raft.KafkaMetadataLogTest.testDeleteSnapshots() Build / ARM /

<    1   2   3