[jira] [Resolved] (KAFKA-13113) Add unregister support to the RaftClient.

2021-07-23 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-13113. - Resolution: Fixed > Add unregister support to the RaftClient. >

[GitHub] [kafka] hachikuji merged pull request #11109: KAFKA-13113: Support unregistering Raft listeners

2021-07-23 Thread GitBox
hachikuji merged pull request #11109: URL: https://github.com/apache/kafka/pull/11109 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] guozhangwang commented on pull request #11122: MINOR: remove unneeded comments to avoid misleading message

2021-07-23 Thread GitBox
guozhangwang commented on pull request #11122: URL: https://github.com/apache/kafka/pull/11122#issuecomment-885992700 Thanks @showuon ! Cherry-picked to 3.0 as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] guozhangwang merged pull request #11122: MINOR: remove unneeded comments to avoid misleading message

2021-07-23 Thread GitBox
guozhangwang merged pull request #11122: URL: https://github.com/apache/kafka/pull/11122 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] ableegoldman commented on pull request #11123: MINOR: factor state checks into descriptive methods and clarify javadocs

2021-07-23 Thread GitBox
ableegoldman commented on pull request #11123: URL: https://github.com/apache/kafka/pull/11123#issuecomment-885991859 Call for review on this minor cleanup PR to make the state handling a bit more clear and (hopefully) safe -- @wcarlson5 @mjsax @lct45 @cadonna @showuon -- This is an

[GitHub] [kafka] ableegoldman commented on a change in pull request #11123: MINOR: factor state checks into descriptive methods and clarify javadocs

2021-07-23 Thread GitBox
ableegoldman commented on a change in pull request #11123: URL: https://github.com/apache/kafka/pull/11123#discussion_r675938982 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -386,23 +405,23 @@ public void setStateListener(final

[GitHub] [kafka] ableegoldman commented on a change in pull request #11123: MINOR: factor state checks into descriptive methods and clarify javadocs

2021-07-23 Thread GitBox
ableegoldman commented on a change in pull request #11123: URL: https://github.com/apache/kafka/pull/11123#discussion_r675938650 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -235,10 +238,26 @@

[GitHub] [kafka] ableegoldman opened a new pull request #11123: MINOR: factor state checks into descriptive methods and clarify javadocs

2021-07-23 Thread GitBox
ableegoldman opened a new pull request #11123: URL: https://github.com/apache/kafka/pull/11123 Just a bit of minor cleanup that (a) does some prepwork for another PR I'm working on, (b) updates the javadocs & exception messages to report a more useful error to the user and describe what

[GitHub] [kafka] showuon commented on pull request #11122: MINOR: remove unneeded comments to avoid misleading message

2021-07-23 Thread GitBox
showuon commented on pull request #11122: URL: https://github.com/apache/kafka/pull/11122#issuecomment-885990340 @guozhangwang , sorry, I finally got time to check the updated PR: #11057, and found we forgot to remove this comment. Thanks. -- This is an automated message from the Apache

[GitHub] [kafka] showuon opened a new pull request #11122: MINOR: remove unneeded comments to avoid misleading message

2021-07-23 Thread GitBox
showuon opened a new pull request #11122: URL: https://github.com/apache/kafka/pull/11122 Found this comments left while we updating the PR: https://github.com/apache/kafka/pull/11057. We don't do deduplicate in Fetcher anymore, this comment should be removed to avoid misleading other

[GitHub] [kafka] showuon commented on pull request #11068: KAFKA-13081: detect doubly assigned parition (for v2.8)

2021-07-23 Thread GitBox
showuon commented on pull request #11068: URL: https://github.com/apache/kafka/pull/11068#issuecomment-885988011 @ableegoldman , please take a look. Thank you. Failed tests are unrelated. ``` Build / ARM / org.apache.kafka.common.network.SslTransportLayerTest.[2]

[GitHub] [kafka] showuon closed pull request #11072: [WIP] MINOR: stream stuck fix test

2021-07-23 Thread GitBox
showuon closed pull request #11072: URL: https://github.com/apache/kafka/pull/11072 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] showuon commented on a change in pull request #11105: KAFKA-13123: close KeyValueIterator instances in example code and tests

2021-07-23 Thread GitBox
showuon commented on a change in pull request #11105: URL: https://github.com/apache/kafka/pull/11105#discussion_r675934074 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBStoreTest.java ## @@ -872,62 +879,65 @@ public void

[GitHub] [kafka] jsancio commented on a change in pull request #11109: KAFKA-13113: Support unregistering Raft listeners

2021-07-23 Thread GitBox
jsancio commented on a change in pull request #11109: URL: https://github.com/apache/kafka/pull/11109#discussion_r675915832 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -2381,25 +2396,51 @@ public void complete() { } } -

[GitHub] [kafka] jsancio commented on a change in pull request #11109: KAFKA-13113: Support unregistering Raft listeners

2021-07-23 Thread GitBox
jsancio commented on a change in pull request #11109: URL: https://github.com/apache/kafka/pull/11109#discussion_r675914887 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -2381,25 +2396,51 @@ public void complete() { } } -

[jira] [Commented] (KAFKA-13122) resource leak due to not close KeyValueIterator implemented instances

2021-07-23 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17386595#comment-17386595 ] Luke Chen commented on KAFKA-13122: --- Thank you, I hope I've fixed all the resource leaks! > resource

[jira] [Resolved] (KAFKA-13008) Stream will stop processing data for a long time while waiting for the partition lag

2021-07-23 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-13008. --- Assignee: Guozhang Wang Resolution: Fixed > Stream will stop processing data for a

[jira] [Commented] (KAFKA-9295) KTableKTableForeignKeyInnerJoinMultiIntegrationTest#shouldInnerJoinMultiPartitionQueryable

2021-07-23 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17386592#comment-17386592 ] Guozhang Wang commented on KAFKA-9295: -- [~showuon] I've merged KAFKA-13008 for 3.0, please feel free

[GitHub] [kafka] guozhangwang commented on pull request #11057: KAFKA-13008: Try to refresh end offset when partitionLag returns empty

2021-07-23 Thread GitBox
guozhangwang commented on pull request #11057: URL: https://github.com/apache/kafka/pull/11057#issuecomment-885964615 Cherry-picked to 3.0 cc @kkonstantine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] guozhangwang merged pull request #11057: KAFKA-13008: Try to refresh end offset when partitionLag returns empty

2021-07-23 Thread GitBox
guozhangwang merged pull request #11057: URL: https://github.com/apache/kafka/pull/11057 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] ijuma commented on pull request #11117: MINOR: Remove older brokers from upgrade test

2021-07-23 Thread GitBox
ijuma commented on pull request #7: URL: https://github.com/apache/kafka/pull/7#issuecomment-885964115 Let's get this merged today so that we can have updated system test builds for 3.0 by Monday. Thanks! -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] ijuma edited a comment on pull request #11117: MINOR: Remove older brokers from upgrade test

2021-07-23 Thread GitBox
ijuma edited a comment on pull request #7: URL: https://github.com/apache/kafka/pull/7#issuecomment-885928234 @mjsax @ableegoldman What about `StreamsCooperativeRebalanceUpgradeTest`? I see: > # !!CAUTION!!: THIS LIST OF VERSIONS IS FIXED, NO VERSIONS MUST BE ADDED >

[GitHub] [kafka] jsancio commented on a change in pull request #11109: KAFKA-13113: Support unregistering Raft listeners

2021-07-23 Thread GitBox
jsancio commented on a change in pull request #11109: URL: https://github.com/apache/kafka/pull/11109#discussion_r675911600 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -2381,25 +2396,51 @@ public void complete() { } } -

[jira] [Commented] (KAFKA-13122) resource leak due to not close KeyValueIterator implemented instances

2021-07-23 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17386582#comment-17386582 ] Guozhang Wang commented on KAFKA-13122: --- Nice findings, thanks [~showuon]! > resource leak due to

[GitHub] [kafka] cmccabe merged pull request #11053: KAFKA-13015 Ducktape System Tests for Metadata Snapshots

2021-07-23 Thread GitBox
cmccabe merged pull request #11053: URL: https://github.com/apache/kafka/pull/11053 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] ableegoldman commented on pull request #11117: MINOR: Remove older brokers from upgrade test

2021-07-23 Thread GitBox
ableegoldman commented on pull request #7: URL: https://github.com/apache/kafka/pull/7#issuecomment-885960419 > Should I update this PR to include a change to StreamsCooperativeRebalanceUpgradeTest ? Oh, wait, no that's actually correct as-is. That list corresponds to

[GitHub] [kafka] hachikuji commented on a change in pull request #11109: KAFKA-13113: Support unregistering Raft listeners

2021-07-23 Thread GitBox
hachikuji commented on a change in pull request #11109: URL: https://github.com/apache/kafka/pull/11109#discussion_r675907789 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -2381,25 +2396,51 @@ public void complete() { } } -

[GitHub] [kafka] ableegoldman commented on pull request #11111: KAFKA-13126: guard against overflow when computing `joinGroupTimeoutMs`

2021-07-23 Thread GitBox
ableegoldman commented on pull request #1: URL: https://github.com/apache/kafka/pull/1#issuecomment-885959141 Merged to trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] ableegoldman merged pull request #11111: KAFKA-13126: guard against overflow when computing `joinGroupTimeoutMs`

2021-07-23 Thread GitBox
ableegoldman merged pull request #1: URL: https://github.com/apache/kafka/pull/1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Resolved] (KAFKA-13021) Improve Javadocs for API Changes and address followup from KIP-633

2021-07-23 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman resolved KAFKA-13021. Resolution: Fixed > Improve Javadocs for API Changes and address followup

[GitHub] [kafka] ableegoldman commented on pull request #11114: KAFKA-13021: clarify KIP-633 javadocs and address remaining feedback

2021-07-23 Thread GitBox
ableegoldman commented on pull request #4: URL: https://github.com/apache/kafka/pull/4#issuecomment-885958001 Merged to trunk and cherrypicked to 3.0 (cc @kkonstantine ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] ableegoldman merged pull request #11114: KAFKA-13021: clarify KIP-633 javadocs and address remaining feedback

2021-07-23 Thread GitBox
ableegoldman merged pull request #4: URL: https://github.com/apache/kafka/pull/4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] cmccabe merged pull request #11121: MINOR: Enable KRaft in transactions_test.py

2021-07-23 Thread GitBox
cmccabe merged pull request #11121: URL: https://github.com/apache/kafka/pull/11121 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (KAFKA-13021) Improve Javadocs for API Changes and address followup from KIP-633

2021-07-23 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-13021: --- Fix Version/s: 3.0.0 > Improve Javadocs for API Changes and address

[GitHub] [kafka] hachikuji merged pull request #11101: MINOR: Remove redundant fields in dump log record output

2021-07-23 Thread GitBox
hachikuji merged pull request #11101: URL: https://github.com/apache/kafka/pull/11101 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] ableegoldman commented on pull request #11113: KAFKA-13128: wait for all keys to be fully processed in #shouldQueryStoresAfterAddingAndRemovingStreamThread

2021-07-23 Thread GitBox
ableegoldman commented on pull request #3: URL: https://github.com/apache/kafka/pull/3#issuecomment-885952042 Merged to trunk and cherrypicked back to 2.8 and 3.0 (test fix @kkonstantine ) -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Updated] (KAFKA-13128) Flaky Test StoreQueryIntegrationTest.shouldQueryStoresAfterAddingAndRemovingStreamThread

2021-07-23 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-13128: --- Affects Version/s: 2.8.1 3.0.0 > Flaky Test >

[GitHub] [kafka] ijuma commented on pull request #11117: MINOR: Remove older brokers from upgrade test

2021-07-23 Thread GitBox
ijuma commented on pull request #7: URL: https://github.com/apache/kafka/pull/7#issuecomment-885950359 @ableegoldman I think the two cases you mentioned are potentially fixed by https://github.com/apache/kafka/commit/f34bb28ab6c69945d944abc1283cacecdaf4ef8e -- This is an

[GitHub] [kafka] mjsax commented on pull request #11117: MINOR: Remove older brokers from upgrade test

2021-07-23 Thread GitBox
mjsax commented on pull request #7: URL: https://github.com/apache/kafka/pull/7#issuecomment-885949840 Should I update this PR to include a change to `StreamsCooperativeRebalanceUpgradeTest` ? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] guozhangwang commented on pull request #11057: KAFKA-13008: Try to refresh end offset when partitionLag returns empty

2021-07-23 Thread GitBox
guozhangwang commented on pull request #11057: URL: https://github.com/apache/kafka/pull/11057#issuecomment-885943296 @ableegoldman I updated the PR to move to the "subscription" layer, so that effectively this would only apply to partitions that are in the subscription, and only for

[GitHub] [kafka] dielhennr opened a new pull request #11121: MINOR: Enable KRaft in transactions_test.py

2021-07-23 Thread GitBox
dielhennr opened a new pull request #11121: URL: https://github.com/apache/kafka/pull/11121 Enabling KRaft in this test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Resolved] (KAFKA-13127) Fix stray partition lookup logic

2021-07-23 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe resolved KAFKA-13127. -- Resolution: Fixed > Fix stray partition lookup logic > > >

[GitHub] [kafka] ableegoldman commented on pull request #11117: MINOR: Remove older brokers from upgrade test

2021-07-23 Thread GitBox
ableegoldman commented on pull request #7: URL: https://github.com/apache/kafka/pull/7#issuecomment-885935854 @ijuma yes, we can/should remove those older versions for the `StreamsCooperativeRebalanceUpgradeTest` as well. Not sure if that's the only reason for the failures, though

[GitHub] [kafka] cmccabe merged pull request #11118: KAFKA-13127; Fix stray topic partition deletion for kraft

2021-07-23 Thread GitBox
cmccabe merged pull request #8: URL: https://github.com/apache/kafka/pull/8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] ableegoldman merged pull request #11113: KAFKA-13128: wait for all keys to be fully processed in #shouldQueryStoresAfterAddingAndRemovingStreamThread

2021-07-23 Thread GitBox
ableegoldman merged pull request #3: URL: https://github.com/apache/kafka/pull/3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] ijuma commented on pull request #11117: MINOR: Remove older brokers from upgrade test

2021-07-23 Thread GitBox
ijuma commented on pull request #7: URL: https://github.com/apache/kafka/pull/7#issuecomment-885929118 For context, I'm asking as I see a bunch of failures here:

[GitHub] [kafka] ijuma edited a comment on pull request #11117: MINOR: Remove older brokers from upgrade test

2021-07-23 Thread GitBox
ijuma edited a comment on pull request #7: URL: https://github.com/apache/kafka/pull/7#issuecomment-885928234 @mjsax @ableegoldman What about `StreamsCooperativeRebalanceUpgradeTest`? I see: > # !!CAUTION!!: THIS LIST OF VERSIONS IS FIXED, NO VERSIONS MUST BE ADDED >

[GitHub] [kafka] ijuma commented on pull request #11117: MINOR: Remove older brokers from upgrade test

2021-07-23 Thread GitBox
ijuma commented on pull request #7: URL: https://github.com/apache/kafka/pull/7#issuecomment-885928234 @mjsax @ableegoldman What about `StreamsCooperativeRebalanceUpgradeTest`? I see: > # !!CAUTION!!: THIS LIST OF VERSIONS IS FIXED, NO VERSIONS MUST BE ADDED >

[jira] [Commented] (KAFKA-9203) kafka-client 2.3.1 fails to consume lz4 compressed topic

2021-07-23 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17386555#comment-17386555 ] Ismael Juma commented on KAFKA-9203: Merged the PR from [~xvrl]. > kafka-client 2.3.1 fails to

[GitHub] [kafka] ijuma merged pull request #10196: KAFKA-9203: Check for buggy LZ4 libraries and remove corresponding workarounds

2021-07-23 Thread GitBox
ijuma merged pull request #10196: URL: https://github.com/apache/kafka/pull/10196 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] ableegoldman commented on pull request #11113: KAFKA-13128: wait for all keys to be fully processed in #shouldQueryStoresAfterAddingAndRemovingStreamThread

2021-07-23 Thread GitBox
ableegoldman commented on pull request #3: URL: https://github.com/apache/kafka/pull/3#issuecomment-885922477 @wcarlson5 yeah I think we can flesh this test out even more, but I'm going to merge this fix for now so we can help stabilize the 3.0 release branch (and because we

[GitHub] [kafka] hachikuji commented on a change in pull request #11118: KAFKA-13127; Fix stray topic partition deletion for kraft

2021-07-23 Thread GitBox
hachikuji commented on a change in pull request #8: URL: https://github.com/apache/kafka/pull/8#discussion_r675860717 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -259,7 +259,7 @@ class Log(@volatile var logStartOffset: Long, import kafka.log.Log._

[GitHub] [kafka] patrickstuedi opened a new pull request #11120: Add support for infinite endpoints for range queries

2021-07-23 Thread GitBox
patrickstuedi opened a new pull request #11120: URL: https://github.com/apache/kafka/pull/11120 This PR adds support to open endpoint queries in the state store. KIP: https://cwiki.apache.org/confluence/display/KAFKA/KIP-763%3A+Range+queries+with+open+endpoints ###

[jira] [Commented] (KAFKA-13131) Consumer offsets lost during partition reassignment

2021-07-23 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17386536#comment-17386536 ] Ismael Juma commented on KAFKA-13131: - Can you please test with 2.8.0 or trunk? > Consumer offsets

[jira] [Resolved] (KAFKA-13116) KIP-724: Adjust system tests due to KAFKA-12944

2021-07-23 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-13116. - Resolution: Fixed > KIP-724: Adjust system tests due to KAFKA-12944 >

[GitHub] [kafka] ijuma commented on pull request #11115: KAFKA-13129: replace describe topic via zk with describe users

2021-07-23 Thread GitBox
ijuma commented on pull request #5: URL: https://github.com/apache/kafka/pull/5#issuecomment-885906003 No worries, I ran a few variations and they look good. Also cherry-picked this to 3.0. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] mumrah commented on a change in pull request #11118: KAFKA-13127; Fix stray topic partition deletion for kraft

2021-07-23 Thread GitBox
mumrah commented on a change in pull request #8: URL: https://github.com/apache/kafka/pull/8#discussion_r675854879 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -2220,7 +2220,7 @@ class ReplicaManager(val config: KafkaConfig,

[GitHub] [kafka] ijuma commented on pull request #11108: KAFKA-13116: Fix message_format_change_test and compatibility_test_new_broker_test failures

2021-07-23 Thread GitBox
ijuma commented on pull request #11108: URL: https://github.com/apache/kafka/pull/11108#issuecomment-885904139 The branch builder system tests passed btw. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] ijuma merged pull request #11108: KAFKA-13116: Fix message_format_change_test and compatibility_test_new_broker_test failures

2021-07-23 Thread GitBox
ijuma merged pull request #11108: URL: https://github.com/apache/kafka/pull/11108 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] ijuma commented on pull request #11108: KAFKA-13116: Fix message_format_change_test and compatibility_test_new_broker_test failures

2021-07-23 Thread GitBox
ijuma commented on pull request #11108: URL: https://github.com/apache/kafka/pull/11108#issuecomment-885903617 Failures are unrelated. Merging to master and cherry-picking to 3.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] izzyacademy commented on pull request #11114: KAFKA-13021: clarify KIP-633 javadocs and address remaining feedback

2021-07-23 Thread GitBox
izzyacademy commented on pull request #4: URL: https://github.com/apache/kafka/pull/4#issuecomment-885903272 Thanks for the clarification @ableegoldman you have added to the javadocs as well as the code changes I am glad you were able to work on it in time to make it into

[GitHub] [kafka] cmccabe commented on a change in pull request #11118: KAFKA-13127; Fix stray topic partition deletion for kraft

2021-07-23 Thread GitBox
cmccabe commented on a change in pull request #8: URL: https://github.com/apache/kafka/pull/8#discussion_r675851515 ## File path: core/src/test/scala/unit/kafka/server/AbstractApiVersionsRequestTest.scala ## @@ -24,10 +24,13 @@ import

[GitHub] [kafka] cmccabe commented on a change in pull request #11118: KAFKA-13127; Fix stray topic partition deletion for kraft

2021-07-23 Thread GitBox
cmccabe commented on a change in pull request #8: URL: https://github.com/apache/kafka/pull/8#discussion_r675850704 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -259,7 +259,7 @@ class Log(@volatile var logStartOffset: Long, import kafka.log.Log._

[GitHub] [kafka] cmccabe merged pull request #11119: MINOR: Add "controller" listener to AlterConfigsRequest

2021-07-23 Thread GitBox
cmccabe merged pull request #9: URL: https://github.com/apache/kafka/pull/9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (KAFKA-13130) Deprecate long based range queries in SessionStore

2021-07-23 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17386523#comment-17386523 ] A. Sophie Blee-Goldman commented on KAFKA-13130: Hey [~pstuedi], just a heads up there

[jira] [Updated] (KAFKA-13131) Consumer offsets lost during partition reassignment

2021-07-23 Thread Sergejs Andrejevs (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergejs Andrejevs updated KAFKA-13131: -- Description: While doing replicas reassignment of a *___consumer_offsets_* partition

[GitHub] [kafka] dielhennr opened a new pull request #11119: MINOR: Add "controller" listener to AlterConfigsRequest

2021-07-23 Thread GitBox
dielhennr opened a new pull request #9: URL: https://github.com/apache/kafka/pull/9 AlterConfigsRequest is handled in ControllerApis but does not have the "controller" listener. This PR adds the listener to the RPC. -- This is an automated message from the Apache Git Service. To

[jira] [Updated] (KAFKA-13120) Flesh out `streams_static_membership_test` to be more robust

2021-07-23 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-13120: --- Labels: newbie++ (was: ) > Flesh out `streams_static_membership_test` to

[jira] [Updated] (KAFKA-12473) Make the "cooperative-sticky, range" as the default assignor

2021-07-23 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-12473: Labels: kip (was: needs-kip) > Make the "cooperative-sticky, range" as the default

[GitHub] [kafka] niket-goel commented on a change in pull request #11053: KAFKA-13015 Ducktape System Tests for Metadata Snapshots

2021-07-23 Thread GitBox
niket-goel commented on a change in pull request #11053: URL: https://github.com/apache/kafka/pull/11053#discussion_r670853242 ## File path: tests/kafkatest/tests/core/snapshot_test.py ## @@ -0,0 +1,227 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [kafka] hachikuji opened a new pull request #11118: KAFKA-13127; Fix stray topic partition deletion for kraft

2021-07-23 Thread GitBox
hachikuji opened a new pull request #8: URL: https://github.com/apache/kafka/pull/8 This patch fixes `BrokerMetadataPublisher.findGhostReplicas` (renamed to `findStrayPartitions`) so that it returns the stray partitions. Previously it was returning the non-stray partitions.

[GitHub] [kafka] jsancio commented on a change in pull request #11053: KAFKA-13015 Ducktape System Tests for Metadata Snapshots

2021-07-23 Thread GitBox
jsancio commented on a change in pull request #11053: URL: https://github.com/apache/kafka/pull/11053#discussion_r675739938 ## File path: tests/kafkatest/tests/core/snapshot_test.py ## @@ -0,0 +1,251 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +#

[GitHub] [kafka] kkonstantine commented on pull request #11114: KAFKA-13021: clarify KIP-633 javadocs and address remaining feedback

2021-07-23 Thread GitBox
kkonstantine commented on pull request #4: URL: https://github.com/apache/kafka/pull/4#issuecomment-885803101 Approved for inclusion to 3.0 as well (mentioned on the list too). Thanks @ableegoldman -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] cmccabe commented on pull request #11109: KAFKA-13113: Support unregistering Raft listeners

2021-07-23 Thread GitBox
cmccabe commented on pull request #11109: URL: https://github.com/apache/kafka/pull/11109#issuecomment-885802283 Thanks for the explanation. I'd prefer just using a different listener instance. Should be straightforward for the controller + broker to do that since they use small helper

[GitHub] [kafka] jsancio commented on pull request #11109: KAFKA-13113: Support unregistering Raft listeners

2021-07-23 Thread GitBox
jsancio commented on pull request #11109: URL: https://github.com/apache/kafka/pull/11109#issuecomment-885800314 > I don't see why we need this context object. The listener itself is the context object. It should be able to unregister itself by just calling `RaftClient#unregister(this)`

[jira] [Updated] (KAFKA-12839) SlidingWindow with timeDifference zero fails

2021-07-23 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-12839: Labels: kip (was: needs-kip) > SlidingWindow with timeDifference zero fails >

[jira] [Updated] (KAFKA-12839) SlidingWindow with timeDifference zero fails

2021-07-23 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-12839: Description: Trying to use a sliding window with time-difference 0 (that is officially

[jira] [Updated] (KAFKA-13130) Deprecate long based range queries in SessionStore

2021-07-23 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-13130: Labels: needs-kip newbie newbie++ (was: newbie newbie++) > Deprecate long based range

[GitHub] [kafka] mjsax commented on a change in pull request #11105: KAFKA-13123: close KeyValueIterator instances in example code and tests

2021-07-23 Thread GitBox
mjsax commented on a change in pull request #11105: URL: https://github.com/apache/kafka/pull/11105#discussion_r675730815 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorTopologyTest.java ## @@ -118,6 +121,18 @@ public void cleanup()

[GitHub] [kafka] mjsax commented on a change in pull request #11105: KAFKA-13123: close KeyValueIterator instances in example code and tests

2021-07-23 Thread GitBox
mjsax commented on a change in pull request #11105: URL: https://github.com/apache/kafka/pull/11105#discussion_r675730406 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBStoreTest.java ## @@ -872,62 +879,65 @@ public void

[jira] [Commented] (KAFKA-13122) resource leak due to not close KeyValueIterator implemented instances

2021-07-23 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17386412#comment-17386412 ] Matthias J. Sax commented on KAFKA-13122: - Great catch! > resource leak due to not close

[GitHub] [kafka] cmccabe commented on pull request #11109: KAFKA-13113: Support unregistering Raft listeners

2021-07-23 Thread GitBox
cmccabe commented on pull request #11109: URL: https://github.com/apache/kafka/pull/11109#issuecomment-885788949 I don't see why we need this context object. The listener itself is the context object. It should be able to unregister itself by just calling `RaftClient#unregister(this)`

[GitHub] [kafka] jsancio commented on a change in pull request #11053: KAFKA-13015 Ducktape System Tests for Metadata Snapshots

2021-07-23 Thread GitBox
jsancio commented on a change in pull request #11053: URL: https://github.com/apache/kafka/pull/11053#discussion_r675722970 ## File path: tests/kafkatest/tests/core/snapshot_test.py ## @@ -0,0 +1,227 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +#

[GitHub] [kafka] mjsax commented on a change in pull request #11114: KAFKA-13021: clarify KIP-633 javadocs and address remaining feedback

2021-07-23 Thread GitBox
mjsax commented on a change in pull request #4: URL: https://github.com/apache/kafka/pull/4#discussion_r675707618 ## File path: docs/streams/upgrade-guide.html ## @@ -135,25 +135,30 @@ Streams API We removed the default implementation of

[GitHub] [kafka] ijuma commented on pull request #11117: MINOR: Remove older brokers from upgrade test

2021-07-23 Thread GitBox
ijuma commented on pull request #7: URL: https://github.com/apache/kafka/pull/7#issuecomment-885772931 We should cherry-pick this to 3.0 as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] mjsax commented on a change in pull request #11114: KAFKA-13021: clarify KIP-633 javadocs and address remaining feedback

2021-07-23 Thread GitBox
mjsax commented on a change in pull request #4: URL: https://github.com/apache/kafka/pull/4#discussion_r675706665 ## File path: docs/streams/upgrade-guide.html ## @@ -135,25 +135,30 @@ Streams API We removed the default implementation of

[GitHub] [kafka] mjsax commented on pull request #11117: MINOR: Remove older brokers from upgrade test

2021-07-23 Thread GitBox
mjsax commented on pull request #7: URL: https://github.com/apache/kafka/pull/7#issuecomment-885769807 Triggered https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4621/ -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] mjsax opened a new pull request #11117: MINOR: Remove older brokers from upgrade test

2021-07-23 Thread GitBox
mjsax opened a new pull request #7: URL: https://github.com/apache/kafka/pull/7 As of version 2.2.1 , Kafka Streams uses message headers and thus requires broker version 0.11.0 or newer. -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (KAFKA-8529) Flakey test ConsumerBounceTest#testCloseDuringRebalance

2021-07-23 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17386361#comment-17386361 ] Justine Olshan commented on KAFKA-8529: --- FYI: I just merged a PR that should cut down on flakiness

[jira] [Resolved] (KAFKA-8529) Flakey test ConsumerBounceTest#testCloseDuringRebalance

2021-07-23 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-8529. Resolution: Fixed > Flakey test ConsumerBounceTest#testCloseDuringRebalance >

[GitHub] [kafka] hachikuji merged pull request #11097: KAFKA-8529: Flakey test ConsumerBounceTest#testCloseDuringRebalance

2021-07-23 Thread GitBox
hachikuji merged pull request #11097: URL: https://github.com/apache/kafka/pull/11097 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (KAFKA-13131) Consumer offsets lost during partition reassignment

2021-07-23 Thread Sergejs Andrejevs (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17386342#comment-17386342 ] Sergejs Andrejevs commented on KAFKA-13131: --- Several comments at ticket

[GitHub] [kafka] jsancio opened a new pull request #11116: KAFKA-13114: Revert state and reregister raft listener

2021-07-23 Thread GitBox
jsancio opened a new pull request #6: URL: https://github.com/apache/kafka/pull/6 RaftClient's scheduleAppend may split the list of records into multiple batches. This means that it is possible for the active controller to see a committed offset for which it doesn't have an

[jira] [Created] (KAFKA-13131) Consumer offsets lost during partition reassignment

2021-07-23 Thread Sergejs Andrejevs (Jira)
Sergejs Andrejevs created KAFKA-13131: - Summary: Consumer offsets lost during partition reassignment Key: KAFKA-13131 URL: https://issues.apache.org/jira/browse/KAFKA-13131 Project: Kafka

[jira] [Updated] (KAFKA-13130) Deprecate long based range queries in SessionStore

2021-07-23 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-13130: - Component/s: (was: streams-test-utils) > Deprecate long based range queries in SessionStore

[jira] [Updated] (KAFKA-13130) Deprecate long based range queries in SessionStore

2021-07-23 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-13130: - Labels: newbie newbie++ (was: ) > Deprecate long based range queries in SessionStore >

[GitHub] [kafka] ijuma commented on pull request #11108: KAFKA-13116: Fix message_format_change_test and compatibility_test_new_broker_test failures

2021-07-23 Thread GitBox
ijuma commented on pull request #11108: URL: https://github.com/apache/kafka/pull/11108#issuecomment-885675954 To double-check the local results, I started the branch builder here too https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4620/ -- This is an automated message

[GitHub] [kafka] showuon commented on pull request #11115: KAFKA-13129: replace describe topic via zk with describe users

2021-07-23 Thread GitBox
showuon commented on pull request #5: URL: https://github.com/apache/kafka/pull/5#issuecomment-885649500 @ijuma , I have to admit that I cannot complete the `upgrade_test` test successfully in my local environment, and I think that's because my machine is not power enough to

[GitHub] [kafka] cadonna commented on pull request #10851: KAFKA-6718 / Rack aware standby task assignor

2021-07-23 Thread GitBox
cadonna commented on pull request #10851: URL: https://github.com/apache/kafka/pull/10851#issuecomment-885645624 @lkokhreidze FYI: I will be offline the next two weeks. I am sorry that I haven't had time to review this PR this week. -- This is an automated message from the Apache Git

[GitHub] [kafka] ijuma commented on pull request #11115: KAFKA-13129: replace describe topic via zk with describe users

2021-07-23 Thread GitBox
ijuma commented on pull request #5: URL: https://github.com/apache/kafka/pull/5#issuecomment-885611405 @showuon `upgrade_test` passes with these changes, I assume? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

  1   2   >