RivenSun2 edited a comment on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-942858528
@guozhangwang
Thank you for your reply
1. I agree that deleting the poll(long) method will make the code changes
easier, but this cannot solve the root cause,
RivenSun2 edited a comment on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-942858528
@guozhangwang
Thank you for your reply
1. I agree that deleting the poll(long) method will make the code changes
easier, but this cannot solve the root cause,
RivenSun2 edited a comment on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-942858528
@guozhangwang
Thank you for your reply
1. I agree that deleting the poll(long) method will make the code changes
easier, but this cannot solve the root cause,
RivenSun2 edited a comment on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-942858528
@guozhangwang
Thank you for your reply
1. I agree that deleting the poll(long) method will make the code changes
easier, but this cannot solve the root cause,
RivenSun2 edited a comment on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-942858528
@guozhangwang
Thank you for your reply
1. I agree that deleting the poll(long) method will make the code changes
easier, but this cannot solve the root cause,
RivenSun2 edited a comment on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-942858528
@guozhangwang
Thank you for your reply
1. I agree that deleting the poll(long) method will make the code changes
easier, but this cannot solve the root cause,
RivenSun2 edited a comment on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-942858528
@guozhangwang
Thank you for your reply
1. I agree that deleting the poll(long) method will make the code changes
easier, but this cannot solve the root cause,
RivenSun2 edited a comment on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-942858528
@guozhangwang
Thank you for your reply
1. I agree that deleting the poll(long) method will make the code changes
easier, but this cannot solve the root cause,
RivenSun2 edited a comment on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-942858528
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
RivenSun2 edited a comment on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-942858528
@guozhangwang
Thank you for your reply
1. I agree that deleting the poll(long) method will make the code changes
easier, but this cannot solve the root cause,
RivenSun2 commented on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-942858528
@guozhangwang
Thank you for your reply
1. I agree that deleting the poll(long) method will make the code changes
easier, but this cannot solve the root cause,
guozhangwang commented on a change in pull request #9293:
URL: https://github.com/apache/kafka/pull/9293#discussion_r728524198
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java
##
@@ -46,43 +46,90 @@
* @param
* @param
[
https://issues.apache.org/jira/browse/KAFKA-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-12909:
Fix Version/s: (was: 3.0.0)
3.1.0
> Allow users to opt-into
[
https://issues.apache.org/jira/browse/KAFKA-8613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-8613:
---
Fix Version/s: 3.1.0
> Make Grace Period Mandatory for Windowed Operations in Streams
>
jolshan commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r728455837
##
File path:
clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java
##
@@ -249,115 +215,126 @@ public String toString() {
*
jolshan commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r728455837
##
File path:
clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java
##
@@ -249,115 +215,126 @@ public String toString() {
*
jsancio commented on a change in pull request #10593:
URL: https://github.com/apache/kafka/pull/10593#discussion_r728399062
##
File path:
raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientSnapshotTest.java
##
@@ -1533,6 +1508,112 @@ public void
hachikuji commented on a change in pull request #10593:
URL: https://github.com/apache/kafka/pull/10593#discussion_r728392933
##
File path:
raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientSnapshotTest.java
##
@@ -1533,6 +1508,112 @@ public void
mjsax commented on a change in pull request #11380:
URL: https://github.com/apache/kafka/pull/11380#discussion_r728377936
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/JoinStoreIntegrationTest.java
##
@@ -131,4 +143,50 @@ public void
tombentley commented on a change in pull request #11393:
URL: https://github.com/apache/kafka/pull/11393#discussion_r728299299
##
File path:
clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java
##
@@ -251,397 +284,114 @@
private final
mimaison commented on a change in pull request #11394:
URL: https://github.com/apache/kafka/pull/11394#discussion_r728264561
##
File path: release.py
##
@@ -207,10 +217,10 @@ def get_jdk(prefs, version):
jdk_java_home = get_pref(prefs, 'jdk%d' % version, lambda:
guozhangwang commented on a change in pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#discussion_r728349026
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
##
@@ -994,11 +996,16 @@ public boolean
mimaison merged pull request #11378:
URL: https://github.com/apache/kafka/pull/11378
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
RivenSun2 removed a comment on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-942212161
@guozhangwang
To add, I think it is necessary to automatically clean up non-existent
offsets in the `onJoinPrepare` method
We now agree that offsetCommitTimer
rhauch commented on a change in pull request #11323:
URL: https://github.com/apache/kafka/pull/11323#discussion_r727228287
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/SubmittedRecords.java
##
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache
guozhangwang commented on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-941700809
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
ijuma commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r728096221
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -708,40 +701,41 @@ class KafkaApis(val requestChannel: RequestChannel,
None
RivenSun2 edited a comment on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-942212413
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
guozhangwang commented on a change in pull request #11368:
URL: https://github.com/apache/kafka/pull/11368#discussion_r727481457
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/KTableKTableForeignKeyInnerJoinCustomPartitionerIntegrationTest.java
##
@@
C0urante commented on a change in pull request #11323:
URL: https://github.com/apache/kafka/pull/11323#discussion_r728049488
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java
##
@@ -250,6 +248,9 @@ public void execute() {
guozhangwang merged pull request #11362:
URL: https://github.com/apache/kafka/pull/11362
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
guozhangwang commented on a change in pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#discussion_r727557427
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
##
@@ -994,11 +996,16 @@ public boolean
cmccabe merged pull request #11386:
URL: https://github.com/apache/kafka/pull/11386
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
guozhangwang merged pull request #11188:
URL: https://github.com/apache/kafka/pull/11188
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
RivenSun2 commented on a change in pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#discussion_r727884034
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
##
@@ -994,11 +996,16 @@ public boolean
RivenSun2 commented on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-942172371
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
cmccabe commented on pull request #11386:
URL: https://github.com/apache/kafka/pull/11386#issuecomment-941788779
Test failures look like flakes. Committing now. Thanks, @jsancio
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
jsancio commented on a change in pull request #10593:
URL: https://github.com/apache/kafka/pull/10593#discussion_r727462578
##
File path:
raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientSnapshotTest.java
##
@@ -1533,6 +1508,112 @@ public void
mimaison commented on a change in pull request #11393:
URL: https://github.com/apache/kafka/pull/11393#discussion_r728131618
##
File path:
clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java
##
@@ -251,397 +284,114 @@
private final
guozhangwang merged pull request #11234:
URL: https://github.com/apache/kafka/pull/11234
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dajac commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r727909392
##
File path:
clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java
##
@@ -249,115 +215,126 @@ public String toString() {
*
tombentley commented on a change in pull request #11393:
URL: https://github.com/apache/kafka/pull/11393#discussion_r728299299
##
File path:
clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java
##
@@ -251,397 +284,114 @@
private final
mimaison commented on a change in pull request #11394:
URL: https://github.com/apache/kafka/pull/11394#discussion_r728264561
##
File path: release.py
##
@@ -207,10 +217,10 @@ def get_jdk(prefs, version):
jdk_java_home = get_pref(prefs, 'jdk%d' % version, lambda:
mimaison opened a new pull request #11394:
URL: https://github.com/apache/kafka/pull/11394
- automatically upload artifacts to Apache Home using sftp
- fix the logic to find JDK 17
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
[
https://issues.apache.org/jira/browse/KAFKA-13364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17428318#comment-17428318
]
Matthias J. Sax commented on KAFKA-13364:
-
Not sure if I understand this request. Also, what do
[
https://issues.apache.org/jira/browse/KAFKA-13364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-13364:
Fix Version/s: (was: 2.5.1)
(was: 3.0.0)
> SQL Processor
[
https://issues.apache.org/jira/browse/KAFKA-13284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison reassigned KAFKA-13284:
--
Assignee: Mickael Maison
> Use sftp protocol in release.py to upload release
mimaison merged pull request #11378:
URL: https://github.com/apache/kafka/pull/11378
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Robin Moffatt created KAFKA-13374:
-
Summary: [Docs] - All reads from the leader of the partition even
after KIP-392?
Key: KAFKA-13374
URL: https://issues.apache.org/jira/browse/KAFKA-13374
Project:
dajac commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r728132912
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -708,40 +701,41 @@ class KafkaApis(val requestChannel: RequestChannel,
None
mimaison commented on a change in pull request #11393:
URL: https://github.com/apache/kafka/pull/11393#discussion_r728132165
##
File path:
clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java
##
@@ -251,397 +284,114 @@
private final
mimaison commented on a change in pull request #11393:
URL: https://github.com/apache/kafka/pull/11393#discussion_r728131618
##
File path:
clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java
##
@@ -251,397 +284,114 @@
private final
mimaison opened a new pull request #11393:
URL: https://github.com/apache/kafka/pull/11393
- Ensure we test all requests and responses
- Code cleanups
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test
ijuma commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r728127262
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -708,40 +701,41 @@ class KafkaApis(val requestChannel: RequestChannel,
None
dajac commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r728115288
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -708,40 +701,41 @@ class KafkaApis(val requestChannel: RequestChannel,
None
dajac commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r728124707
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -708,40 +701,41 @@ class KafkaApis(val requestChannel: RequestChannel,
None
dajac commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r728115288
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -708,40 +701,41 @@ class KafkaApis(val requestChannel: RequestChannel,
None
ijuma commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r728096221
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -708,40 +701,41 @@ class KafkaApis(val requestChannel: RequestChannel,
None
C0urante commented on a change in pull request #11323:
URL: https://github.com/apache/kafka/pull/11323#discussion_r728086626
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java
##
@@ -378,7 +370,7 @@ private boolean sendRecords()
Anatoly Tsyganenko created KAFKA-13373:
--
Summary: ValueTransformerWithKeySupplier doesn't work with store()
Key: KAFKA-13373
URL: https://issues.apache.org/jira/browse/KAFKA-13373
Project: Kafka
C0urante commented on a change in pull request #11323:
URL: https://github.com/apache/kafka/pull/11323#discussion_r728049488
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java
##
@@ -250,6 +248,9 @@ public void execute() {
RivenSun2 edited a comment on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-942212413
@guozhangwang
To add, I think it is necessary to automatically clean up non-existent
offsets in the `onJoinPrepare` method
We now agree that offsetCommitTimer
RivenSun2 edited a comment on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-942212413
@guozhangwang
To add, I think it is necessary to automatically clean up non-existent
offsets in the `onJoinPrepare` method
We now agree that offsetCommitTimer
dajac commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r727996093
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -708,40 +701,41 @@ class KafkaApis(val requestChannel: RequestChannel,
None
RivenSun2 edited a comment on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-942212413
@guozhangwang
To add, I think it is necessary to automatically clean up non-existent
offsets in the `onJoinPrepare` method
We now agree that offsetCommitTimer
RivenSun2 edited a comment on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-942212413
@guozhangwang
To add, I think it is necessary to automatically clean up non-existent
offsets in the `onJoinPrepare` method
We now agree that offsetCommitTimer
RivenSun2 removed a comment on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-942212161
@guozhangwang
To add, I think it is necessary to automatically clean up non-existent
offsets in the `onJoinPrepare` method
We now agree that offsetCommitTimer
RivenSun2 edited a comment on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-942212413
@guozhangwang
To add, I think it is necessary to automatically clean up non-existent
offsets in the `onJoinPrepare` method
We now agree that offsetCommitTimer
RivenSun2 commented on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-942212413
@guozhangwang
To add, I think it is necessary to automatically clean up non-existent
offsets in the `onJoinPrepare` method
We now agree that offsetCommitTimer can be
RivenSun2 commented on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-942212161
@guozhangwang
To add, I think it is necessary to automatically clean up non-existent
offsets in the `onJoinPrepare` method
We now agree that offsetCommitTimer can be
RivenSun2 commented on a change in pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#discussion_r727950795
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
##
@@ -994,11 +996,16 @@ public boolean
RivenSun2 commented on a change in pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#discussion_r727950795
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
##
@@ -994,11 +996,16 @@ public boolean
RivenSun2 commented on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-942172371
Thank you @guozhangwang for your reply, I have added some comments above,
please check it out.
Secondly, I have conducted an end-to-end test, the consumer is running
dajac commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r727909392
##
File path:
clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java
##
@@ -249,115 +215,126 @@ public String toString() {
*
RivenSun2 commented on a change in pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#discussion_r727884034
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
##
@@ -994,11 +996,16 @@ public boolean
RivenSun2 commented on a change in pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#discussion_r727884034
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
##
@@ -994,11 +996,16 @@ public boolean
RivenSun2 commented on a change in pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#discussion_r727884034
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
##
@@ -994,11 +996,16 @@ public boolean
RivenSun2 commented on a change in pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#discussion_r727884034
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
##
@@ -994,11 +996,16 @@ public boolean
RivenSun2 commented on a change in pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#discussion_r727884034
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
##
@@ -994,11 +996,16 @@ public boolean
[
https://issues.apache.org/jira/browse/KAFKA-13372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17428084#comment-17428084
]
Piotr Smolinski commented on KAFKA-13372:
-
Try checking the TLS server endpoint with OpenSSL.
[
https://issues.apache.org/jira/browse/KAFKA-13349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
loboxu reassigned KAFKA-13349:
--
Assignee: loboxu (was: Bartłomiej Stachura)
> Allow Iterator.remove on KeyValueIterator
>
81 matches
Mail list logo
