[
https://issues.apache.org/jira/browse/KAFKA-13386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergio Duran Vegas updated KAFKA-13386:
---
Description:
The join optimization assumes the serializer is deterministic and
[
https://issues.apache.org/jira/browse/KAFKA-13386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergio Duran Vegas updated KAFKA-13386:
---
Summary: Foreign Key Join filtering out valid records after a code change /
schema
Sergio Duran Vegas created KAFKA-13386:
--
Summary: Foreign Key Join filtering valid records after a code
change / schema evolved
Key: KAFKA-13386
URL: https://issues.apache.org/jira/browse/KAFKA-13386
vamossagar12 edited a comment on pull request #11211:
URL: https://github.com/apache/kafka/pull/11211#issuecomment-946918369
Thanks Sophie for that.
@showuon , I think your concern about persistent stores and custom stores is
still valid. The reason why I don't want to add the
YiDing-Duke commented on a change in pull request #11284:
URL: https://github.com/apache/kafka/pull/11284#discussion_r732341161
##
File path:
clients/src/test/java/org/apache/kafka/common/security/oauthbearer/secured/AccessTokenValidatorFactoryTest.java
##
@@ -0,0 +1,77 @@
YiDing-Duke commented on a change in pull request #11284:
URL: https://github.com/apache/kafka/pull/11284#discussion_r732339345
##
File path:
clients/src/test/java/org/apache/kafka/common/security/oauthbearer/secured/AccessTokenValidatorFactoryTest.java
##
@@ -0,0 +1,77 @@
cmccabe opened a new pull request #11417:
URL: https://github.com/apache/kafka/pull/11417
Change ZooKeeperTestHarness to QuorumTestHarness so that integration tests
which inherit from this
class can test both ZK and KRaft mode. Test cases which do this can specify
the modes they
ableegoldman commented on a change in pull request #11405:
URL: https://github.com/apache/kafka/pull/11405#discussion_r732310453
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java
##
@@ -2203,7 +2203,7 @@ public void
cmccabe merged pull request #11410:
URL: https://github.com/apache/kafka/pull/11410
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-13289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17430275#comment-17430275
]
Eugen Dück edited comment on KAFKA-13289 at 10/19/21, 10:47 PM:
We are
cmccabe commented on pull request #11410:
URL: https://github.com/apache/kafka/pull/11410#issuecomment-947161702
I reran `ConnectorRestartApiIntegrationTest` and didn't see a failure
locally. Will commit
--
This is an automated message from the Apache Git Service.
To respond to the
kirktrue commented on pull request #11284:
URL: https://github.com/apache/kafka/pull/11284#issuecomment-947122444
Thanks for the feedback, @YiDing-Duke!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
kirktrue commented on a change in pull request #11284:
URL: https://github.com/apache/kafka/pull/11284#discussion_r732259427
##
File path:
clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/OAuthBearerValidatorCallbackHandler.java
##
@@ -0,0 +1,112 @@
kirktrue commented on a change in pull request #11284:
URL: https://github.com/apache/kafka/pull/11284#discussion_r732259126
##
File path:
clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/OAuthBearerValidatorCallbackHandler.java
##
@@ -0,0 +1,112 @@
kirktrue commented on a change in pull request #11284:
URL: https://github.com/apache/kafka/pull/11284#discussion_r732258747
##
File path:
clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/OAuthBearerValidatorCallbackHandler.java
##
@@ -0,0 +1,112 @@
kirktrue commented on a change in pull request #11284:
URL: https://github.com/apache/kafka/pull/11284#discussion_r732258641
##
File path:
clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/OAuthBearerLoginCallbackHandler.java
##
@@ -0,0 +1,188 @@
+/*
kirktrue commented on a change in pull request #11284:
URL: https://github.com/apache/kafka/pull/11284#discussion_r732258376
##
File path:
clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/OAuthBearerLoginCallbackHandler.java
##
@@ -0,0 +1,188 @@
+/*
kirktrue commented on a change in pull request #11284:
URL: https://github.com/apache/kafka/pull/11284#discussion_r732258128
##
File path:
clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/Retry.java
##
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache
kirktrue commented on a change in pull request #11284:
URL: https://github.com/apache/kafka/pull/11284#discussion_r732257932
##
File path:
clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/HttpAccessTokenRetriever.java
##
@@ -0,0 +1,325 @@
+/*
+ *
kirktrue commented on a change in pull request #11284:
URL: https://github.com/apache/kafka/pull/11284#discussion_r732251460
##
File path:
clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/HttpAccessTokenRetriever.java
##
@@ -0,0 +1,325 @@
+/*
+ *
kirktrue commented on a change in pull request #11284:
URL: https://github.com/apache/kafka/pull/11284#discussion_r732251460
##
File path:
clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/HttpAccessTokenRetriever.java
##
@@ -0,0 +1,325 @@
+/*
+ *
vvcephei commented on a change in pull request #11405:
URL: https://github.com/apache/kafka/pull/11405#discussion_r732245277
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java
##
@@ -2203,7 +2203,7 @@ public void
vvcephei commented on pull request #11411:
URL: https://github.com/apache/kafka/pull/11411#issuecomment-947102353
Thanks, @ableegoldman !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
C0urante commented on a change in pull request #10907:
URL: https://github.com/apache/kafka/pull/10907#discussion_r73227
##
File path:
connect/api/src/main/java/org/apache/kafka/connect/source/TransactionContext.java
##
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache
C0urante commented on a change in pull request #10907:
URL: https://github.com/apache/kafka/pull/10907#discussion_r732232701
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/storage/OffsetStorageWriter.java
##
@@ -163,13 +181,24 @@ public synchronized
C0urante commented on a change in pull request #10907:
URL: https://github.com/apache/kafka/pull/10907#discussion_r732231502
##
File path:
connect/api/src/main/java/org/apache/kafka/connect/source/SourceConnector.java
##
@@ -28,4 +30,31 @@
protected
C0urante commented on a change in pull request #10907:
URL: https://github.com/apache/kafka/pull/10907#discussion_r732231269
##
File path:
connect/api/src/main/java/org/apache/kafka/connect/source/SourceTaskContext.java
##
@@ -38,4 +38,30 @@
* Get the
ableegoldman commented on pull request #11405:
URL: https://github.com/apache/kafka/pull/11405#issuecomment-947065671
All tests passed, but for two unrelated flaky test failures of:
`kafka.admin.LeaderElectionCommandTest.[1] Type=Raft,
Name=testTopicPartition, Security=PLAINTEXT`
--
ableegoldman commented on pull request #11411:
URL: https://github.com/apache/kafka/pull/11411#issuecomment-947064999
Thanks for the update. I've had some users hit upon the same
misunderstanding that I'm guessing sparked this
--
This is an automated message from the Apache Git Service.
ableegoldman commented on a change in pull request #11411:
URL: https://github.com/apache/kafka/pull/11411#discussion_r732203571
##
File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java
##
@@ -329,8 +329,10 @@
/** {@code acceptable.recovery.lag}
dielhennr commented on a change in pull request #10772:
URL: https://github.com/apache/kafka/pull/10772#discussion_r732112282
##
File path:
metadata/src/main/java/org/apache/kafka/controller/QuorumControllerMetrics.java
##
@@ -26,28 +26,36 @@
import java.util.Objects;
YiDing-Duke commented on a change in pull request #11284:
URL: https://github.com/apache/kafka/pull/11284#discussion_r732092804
##
File path:
clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/OAuthBearerValidatorCallbackHandler.java
##
@@ -0,0 +1,112
cmccabe commented on a change in pull request #11410:
URL: https://github.com/apache/kafka/pull/11410#discussion_r732092038
##
File path: core/src/test/scala/unit/kafka/utils/TestUtils.scala
##
@@ -346,6 +367,97 @@ object TestUtils extends Logging {
cmccabe commented on a change in pull request #11410:
URL: https://github.com/apache/kafka/pull/11410#discussion_r732090271
##
File path: core/src/test/scala/unit/kafka/utils/TestUtils.scala
##
@@ -346,6 +367,97 @@ object TestUtils extends Logging {
cmccabe commented on a change in pull request #11410:
URL: https://github.com/apache/kafka/pull/11410#discussion_r732089124
##
File path: core/src/test/scala/unit/kafka/utils/TestUtils.scala
##
@@ -1640,6 +1800,37 @@ object TestUtils extends Logging {
}, s"Timed out
YiDing-Duke commented on a change in pull request #11284:
URL: https://github.com/apache/kafka/pull/11284#discussion_r732088812
##
File path:
clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/OAuthBearerValidatorCallbackHandler.java
##
@@ -0,0 +1,112
YiDing-Duke commented on a change in pull request #11284:
URL: https://github.com/apache/kafka/pull/11284#discussion_r732088424
##
File path:
clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/OAuthBearerValidatorCallbackHandler.java
##
@@ -0,0 +1,112
cmccabe commented on a change in pull request #11410:
URL: https://github.com/apache/kafka/pull/11410#discussion_r732087662
##
File path: core/src/test/scala/unit/kafka/utils/TestUtils.scala
##
@@ -1220,37 +1348,42 @@ object TestUtils extends Logging {
}
}
-
- def
[
https://issues.apache.org/jira/browse/KAFKA-13373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17430650#comment-17430650
]
Matthias J. Sax commented on KAFKA-13373:
-
I did not look into it too deeply, but I guess it
hachikuji commented on a change in pull request #11410:
URL: https://github.com/apache/kafka/pull/11410#discussion_r732060868
##
File path: core/src/test/scala/unit/kafka/utils/TestUtils.scala
##
@@ -346,6 +367,97 @@ object TestUtils extends Logging {
vamossagar12 edited a comment on pull request #11211:
URL: https://github.com/apache/kafka/pull/11211#issuecomment-946918369
Thanks Sophie for that.
@showuon , I think your concern about persistent stores and custom stores is
still valid. The reason why I don't want to add the
vamossagar12 commented on pull request #11211:
URL: https://github.com/apache/kafka/pull/11211#issuecomment-946918369
Thanks Sophie for that.
@showuon , I think your concern about persistent stores and custom stores is
still valid. The reason why I don't want to add the
YiDing-Duke commented on a change in pull request #11284:
URL: https://github.com/apache/kafka/pull/11284#discussion_r732068749
##
File path:
clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/OAuthBearerLoginCallbackHandler.java
##
@@ -0,0 +1,188 @@
YiDing-Duke commented on a change in pull request #11284:
URL: https://github.com/apache/kafka/pull/11284#discussion_r732068187
##
File path:
clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/OAuthBearerLoginCallbackHandler.java
##
@@ -0,0 +1,188 @@
Colin McCabe created KAFKA-13385:
Summary: In the KRPC request header, translate null clientID to
empty
Key: KAFKA-13385
URL: https://issues.apache.org/jira/browse/KAFKA-13385
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-13373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Victoria Xia updated KAFKA-13373:
-
Labels: newbie (was: )
> ValueTransformerWithKeySupplier doesn't work with store()
>
cmccabe commented on pull request #10772:
URL: https://github.com/apache/kafka/pull/10772#issuecomment-946887188
thanks for this, @dielhennr. I left some comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
cmccabe commented on a change in pull request #10772:
URL: https://github.com/apache/kafka/pull/10772#discussion_r732038559
##
File path:
metadata/src/main/java/org/apache/kafka/controller/QuorumControllerMetrics.java
##
@@ -26,28 +26,36 @@
import java.util.Objects;
cmccabe commented on a change in pull request #10772:
URL: https://github.com/apache/kafka/pull/10772#discussion_r732036343
##
File path:
metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java
##
@@ -249,6 +256,10 @@ public void
cmccabe commented on a change in pull request #10772:
URL: https://github.com/apache/kafka/pull/10772#discussion_r732036343
##
File path:
metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java
##
@@ -249,6 +256,10 @@ public void
cmccabe commented on pull request #11410:
URL: https://github.com/apache/kafka/pull/11410#issuecomment-946860744
Test failures seem like flakes (they pass locally)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
cmccabe opened a new pull request #11416:
URL: https://github.com/apache/kafka/pull/11416
For CreateTopics, fix a bug where if one createTopics in a batch failed,
they would all fail with
the same error code. Make the error message for TOPIC_ALREADY_EXISTS
consistent with the ZK-based
[
https://issues.apache.org/jira/browse/KAFKA-13374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17430590#comment-17430590
]
Robin Moffatt commented on KAFKA-13374:
---
Looks good to me as a layperson - thanks for picking this
jeqo closed pull request #10507:
URL: https://github.com/apache/kafka/pull/10507
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-13384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexander updated KAFKA-13384:
--
Description:
We found a misbehavior on our Kafka cluster - version: 2.6.2
(Commit:da65af02e5856e34))
[
https://issues.apache.org/jira/browse/KAFKA-13384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexander updated KAFKA-13384:
--
Description:
We found a misbehavior on our Kafka cluster (version: 2.6.2
(Commit:da65af02e5856e34)),
[
https://issues.apache.org/jira/browse/KAFKA-13384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexander updated KAFKA-13384:
--
Description:
We found a misbehavior on our Kafka cluster (version: 2.6.2
(Commit:da65af02e5856e34)),
Alexander created KAFKA-13384:
-
Summary: FailedPartitionsCount metric is not updated if a
partition log file was corrupted
Key: KAFKA-13384
URL: https://issues.apache.org/jira/browse/KAFKA-13384
Project:
jeqo opened a new pull request #11415:
URL: https://github.com/apache/kafka/pull/11415
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
[
https://issues.apache.org/jira/browse/KAFKA-10543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17430507#comment-17430507
]
Jorge Esteban Quilcate Otoya commented on KAFKA-10543:
--
WIP:
[
https://issues.apache.org/jira/browse/KAFKA-10540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jorge Esteban Quilcate Otoya resolved KAFKA-10540.
--
Resolution: Fixed
https://github.com/apache/kafka/pull/11315
[
https://issues.apache.org/jira/browse/KAFKA-10539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jorge Esteban Quilcate Otoya resolved KAFKA-10539.
--
Resolution: Fixed
https://github.com/apache/kafka/pull/11356
satishd commented on pull request #11414:
URL: https://github.com/apache/kafka/pull/11414#issuecomment-946647417
@junrao This is a minor PR with the existing file name conventions and
throwing a proper error message while reading LeaderEpochCache with an
unsupported version.
--
This is
satishd opened a new pull request #11414:
URL: https://github.com/apache/kafka/pull/11414
MINOR: Renamed a few record definition files with the existing convention.
- Throwing an error message while reading LeaderEpochCheckpoint file with
an unsupported version.
### Committer
[
https://issues.apache.org/jira/browse/KAFKA-13374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17430448#comment-17430448
]
Luke Chen commented on KAFKA-13374:
---
Thank you for reporting and confirming, [~rmoff] [~jlaskowski] ,
[
https://issues.apache.org/jira/browse/KAFKA-13043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot updated KAFKA-13043:
Fix Version/s: (was: 3.1.0)
3.2.0
> Add Admin API for batched offset fetch
[
https://issues.apache.org/jira/browse/KAFKA-13043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17430444#comment-17430444
]
David Jacot commented on KAFKA-13043:
-
Moving this feature to 3.2.0 as [~skaundinya] does not have
[
https://issues.apache.org/jira/browse/KAFKA-13370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17430429#comment-17430429
]
Luke Chen commented on KAFKA-13370:
---
[~20100g], thanks for reporting the issue. PR is ready now:
showuon commented on pull request #11413:
URL: https://github.com/apache/kafka/pull/11413#issuecomment-946513668
@chia7712 , could you please take a look? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
showuon commented on a change in pull request #11413:
URL: https://github.com/apache/kafka/pull/11413#discussion_r731649801
##
File path:
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSourceTaskTest.java
##
@@ -1580,9 +1652,22 @@ private void
showuon commented on a change in pull request #11413:
URL: https://github.com/apache/kafka/pull/11413#discussion_r731648129
##
File path:
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSourceTaskTest.java
##
@@ -129,6 +129,7 @@
// is used in the
showuon commented on a change in pull request #11413:
URL: https://github.com/apache/kafka/pull/11413#discussion_r731647369
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java
##
@@ -550,16 +552,16 @@ public boolean
showuon commented on a change in pull request #11413:
URL: https://github.com/apache/kafka/pull/11413#discussion_r731645529
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java
##
@@ -514,9 +514,11 @@ public boolean
showuon opened a new pull request #11413:
URL: https://github.com/apache/kafka/pull/11413
In https://github.com/apache/kafka/pull/9642, we removed the unnecessary
`success` parameter, and use the `error` as the key to identify if the commit
successfully or failed. However, there are some
[
https://issues.apache.org/jira/browse/KAFKA-12559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17430335#comment-17430335
]
Aditya Upadhyaya commented on KAFKA-12559:
--
[~ableegoldman] I'd like to pick up this task if
[
https://issues.apache.org/jira/browse/KAFKA-13289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17430275#comment-17430275
]
Eugen Dück edited comment on KAFKA-13289 at 10/19/21, 6:33 AM:
---
We are
YiDing-Duke commented on a change in pull request #11284:
URL: https://github.com/apache/kafka/pull/11284#discussion_r731524967
##
File path:
clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/Retry.java
##
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the
77 matches
Mail list logo