[jira] [Commented] (KAFKA-9062) Handle stalled writes to RocksDB

2021-10-21 Thread James Cheng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17432797#comment-17432797 ] James Cheng commented on KAFKA-9062: [~vvcephei], you said that in 2.6, you removed "bulk loading".

[jira] [Commented] (KAFKA-9062) Handle stalled writes to RocksDB

2021-10-21 Thread James Cheng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17432794#comment-17432794 ] James Cheng commented on KAFKA-9062: Are there any metrics that we can measure and look at, to see if

[GitHub] [kafka] jolshan commented on pull request #11331: KAFKA-13111: Re-evaluate Fetch Sessions when using topic IDs

2021-10-21 Thread GitBox
jolshan commented on pull request #11331: URL: https://github.com/apache/kafka/pull/11331#issuecomment-949274575 TODOs: 1. Change inconsistent topic ID so it is no longer a top level error 2. Maybe refactor some of the receiving side code, we have a map with TopicIdPartition,

[GitHub] [kafka] ocadaruma commented on pull request #11422: KAFKA-9648: Add configuration to adjust listen backlog size for Acceptor

2021-10-21 Thread GitBox
ocadaruma commented on pull request #11422: URL: https://github.com/apache/kafka/pull/11422#issuecomment-949269755 Let me mention @rajinisivaram, @mimaison, @dajac here as you participated in the vote for KIP-764. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] RivenSun2 commented on pull request #11340: KAFKA-13310 : KafkaConsumer cannot jump out of the poll method, and the…

2021-10-21 Thread GitBox
RivenSun2 commented on pull request #11340: URL: https://github.com/apache/kafka/pull/11340#issuecomment-949189579 @guozhangwang @showuon and @hachikuji Thank you for paying so much attention to this issue and giving a lot of valuable discussions. > Hence it occurs to me that,

[GitHub] [kafka] kirktrue commented on pull request #11284: KAFKA-13202: KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

2021-10-21 Thread GitBox
kirktrue commented on pull request #11284: URL: https://github.com/apache/kafka/pull/11284#issuecomment-949090564 @junrao - I believe I've addressed all of the points listed except: 1. The listener/SASL mechanism prefix issues are really confusing to me because the code is currently

[GitHub] [kafka] kirktrue commented on a change in pull request #11284: KAFKA-13202: KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

2021-10-21 Thread GitBox
kirktrue commented on a change in pull request #11284: URL: https://github.com/apache/kafka/pull/11284#discussion_r734121443 ## File path: clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/RefreshingHttpsJwks.java ## @@ -0,0 +1,239 @@ +/* + * Licensed

[jira] [Comment Edited] (KAFKA-8197) Flaky Test kafka.server.DynamicBrokerConfigTest > testPasswordConfigEncoderSecretChange

2021-10-21 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17432749#comment-17432749 ] A. Sophie Blee-Goldman edited comment on KAFKA-8197 at 10/21/21, 11:56 PM:

[GitHub] [kafka] ableegoldman commented on pull request #11379: KAFKA-12994: Migrated SlidingWindowsTest to new API

2021-10-21 Thread GitBox
ableegoldman commented on pull request #11379: URL: https://github.com/apache/kafka/pull/11379#issuecomment-949085661 Yep -- see https://issues.apache.org/jira/browse/KAFKA-8197 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (KAFKA-8197) Flaky Test kafka.server.DynamicBrokerConfigTest > testPasswordConfigEncoderSecretChange

2021-10-21 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17432749#comment-17432749 ] A. Sophie Blee-Goldman commented on KAFKA-8197: --- Failed again: h3. Stacktrace

[GitHub] [kafka] kirktrue commented on a change in pull request #11284: KAFKA-13202: KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

2021-10-21 Thread GitBox
kirktrue commented on a change in pull request #11284: URL: https://github.com/apache/kafka/pull/11284#discussion_r734120121 ## File path: clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/JwksFileVerificationKeyResolver.java ## @@ -0,0 +1,79 @@ +/* +

[GitHub] [kafka] officialpatterson commented on pull request #11379: KAFKA-12994: Migrated SlidingWindowsTest to new API

2021-10-21 Thread GitBox
officialpatterson commented on pull request #11379: URL: https://github.com/apache/kafka/pull/11379#issuecomment-949084918 > LGTM -- just one unrelated flaky test failure in `kafka.server.DynamicBrokerConfigTest.testPasswordConfigEncoderSecretChange()` Do we track flaky tests in

[jira] [Resolved] (KAFKA-12994) Migrate all Tests to New API and Remove Suppression for Deprecation Warnings related to KIP-633

2021-10-21 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman resolved KAFKA-12994. Resolution: Fixed > Migrate all Tests to New API and Remove Suppression

[jira] [Commented] (KAFKA-12994) Migrate all Tests to New API and Remove Suppression for Deprecation Warnings related to KIP-633

2021-10-21 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17432748#comment-17432748 ] A. Sophie Blee-Goldman commented on KAFKA-12994: Last PR for this merged, thanks guys!

[GitHub] [kafka] ableegoldman merged pull request #11379: kafka-12994: Migrated SlidingWindowsTest to new API

2021-10-21 Thread GitBox
ableegoldman merged pull request #11379: URL: https://github.com/apache/kafka/pull/11379 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] kirktrue commented on a change in pull request #11284: KAFKA-13202: KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

2021-10-21 Thread GitBox
kirktrue commented on a change in pull request #11284: URL: https://github.com/apache/kafka/pull/11284#discussion_r734111966 ## File path: clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/ConfigurationUtils.java ## @@ -0,0 +1,277 @@ +/* + * Licensed

[GitHub] [kafka] kirktrue commented on a change in pull request #11284: KAFKA-13202: KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

2021-10-21 Thread GitBox
kirktrue commented on a change in pull request #11284: URL: https://github.com/apache/kafka/pull/11284#discussion_r734111966 ## File path: clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/ConfigurationUtils.java ## @@ -0,0 +1,277 @@ +/* + * Licensed

[GitHub] [kafka] kirktrue commented on a change in pull request #11284: KAFKA-13202: KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

2021-10-21 Thread GitBox
kirktrue commented on a change in pull request #11284: URL: https://github.com/apache/kafka/pull/11284#discussion_r734111852 ## File path: clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/ConfigurationUtils.java ## @@ -0,0 +1,277 @@ +/* + * Licensed

[GitHub] [kafka] ableegoldman commented on pull request #11405: KAFKA-12648: Wrap all exceptions thrown to handler as StreamsException & add TaskId field

2021-10-21 Thread GitBox
ableegoldman commented on pull request #11405: URL: https://github.com/apache/kafka/pull/11405#issuecomment-949073433 Merged to trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] ableegoldman merged pull request #11405: KAFKA-12648: Wrap all exceptions thrown to handler as StreamsException & add TaskId field

2021-10-21 Thread GitBox
ableegoldman merged pull request #11405: URL: https://github.com/apache/kafka/pull/11405 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] kirktrue commented on a change in pull request #11284: KAFKA-13202: KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

2021-10-21 Thread GitBox
kirktrue commented on a change in pull request #11284: URL: https://github.com/apache/kafka/pull/11284#discussion_r734107280 ## File path: clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/OAuthBearerLoginCallbackHandler.java ## @@ -0,0 +1,188 @@ +/*

[GitHub] [kafka] kirktrue commented on a change in pull request #11284: KAFKA-13202: KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

2021-10-21 Thread GitBox
kirktrue commented on a change in pull request #11284: URL: https://github.com/apache/kafka/pull/11284#discussion_r734106778 ## File path: clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/PemDirectoryVerificationKeyResolver.java ## @@ -0,0 +1,134 @@

[GitHub] [kafka] kirktrue commented on a change in pull request #11284: KAFKA-13202: KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

2021-10-21 Thread GitBox
kirktrue commented on a change in pull request #11284: URL: https://github.com/apache/kafka/pull/11284#discussion_r734100842 ## File path: clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/RefreshingHttpsJwks.java ## @@ -0,0 +1,239 @@ +/* + * Licensed

[GitHub] [kafka] kirktrue commented on a change in pull request #11284: KAFKA-13202: KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

2021-10-21 Thread GitBox
kirktrue commented on a change in pull request #11284: URL: https://github.com/apache/kafka/pull/11284#discussion_r734100491 ## File path: clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/RefreshingHttpsJwks.java ## @@ -0,0 +1,239 @@ +/* + * Licensed

[GitHub] [kafka] kirktrue commented on a change in pull request #11284: KAFKA-13202: KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

2021-10-21 Thread GitBox
kirktrue commented on a change in pull request #11284: URL: https://github.com/apache/kafka/pull/11284#discussion_r734096643 ## File path: clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/Retry.java ## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] kirktrue commented on a change in pull request #11284: KAFKA-13202: KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

2021-10-21 Thread GitBox
kirktrue commented on a change in pull request #11284: URL: https://github.com/apache/kafka/pull/11284#discussion_r734096345 ## File path: clients/src/main/java/org/apache/kafka/common/config/SaslConfigs.java ## @@ -75,30 +78,111 @@ public static final String

[GitHub] [kafka] kirktrue commented on a change in pull request #11284: KAFKA-13202: KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

2021-10-21 Thread GitBox
kirktrue commented on a change in pull request #11284: URL: https://github.com/apache/kafka/pull/11284#discussion_r734095192 ## File path: clients/src/main/java/org/apache/kafka/common/config/SaslConfigs.java ## @@ -75,30 +78,111 @@ public static final String

[GitHub] [kafka] kirktrue commented on a change in pull request #11284: KAFKA-13202: KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

2021-10-21 Thread GitBox
kirktrue commented on a change in pull request #11284: URL: https://github.com/apache/kafka/pull/11284#discussion_r734089482 ## File path: build.gradle ## @@ -1604,6 +1608,7 @@ project(':tools') { implementation libs.slf4jApi implementation libs.log4j +

[GitHub] [kafka] kirktrue commented on a change in pull request #11284: KAFKA-13202: KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

2021-10-21 Thread GitBox
kirktrue commented on a change in pull request #11284: URL: https://github.com/apache/kafka/pull/11284#discussion_r734089125 ## File path: build.gradle ## @@ -829,6 +829,7 @@ project(':core') { implementation libs.jacksonDataformatCsv implementation

[GitHub] [kafka] kirktrue commented on a change in pull request #11284: KAFKA-13202: KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

2021-10-21 Thread GitBox
kirktrue commented on a change in pull request #11284: URL: https://github.com/apache/kafka/pull/11284#discussion_r734086876 ## File path: clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/ConfigurationUtils.java ## @@ -0,0 +1,277 @@ +/* + * Licensed

[GitHub] [kafka] kirktrue commented on a change in pull request #11284: KAFKA-13202: KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

2021-10-21 Thread GitBox
kirktrue commented on a change in pull request #11284: URL: https://github.com/apache/kafka/pull/11284#discussion_r734086548 ## File path: clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/ConfigurationUtils.java ## @@ -0,0 +1,277 @@ +/* + * Licensed

[GitHub] [kafka] kirktrue commented on a change in pull request #11284: KAFKA-13202: KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

2021-10-21 Thread GitBox
kirktrue commented on a change in pull request #11284: URL: https://github.com/apache/kafka/pull/11284#discussion_r734083140 ## File path: clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/PemDirectoryVerificationKeyResolver.java ## @@ -0,0 +1,134 @@

[GitHub] [kafka] kirktrue commented on a change in pull request #11284: KAFKA-13202: KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

2021-10-21 Thread GitBox
kirktrue commented on a change in pull request #11284: URL: https://github.com/apache/kafka/pull/11284#discussion_r734082935 ## File path: clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/PemDirectoryVerificationKeyResolver.java ## @@ -0,0 +1,134 @@

[GitHub] [kafka] kirktrue commented on a change in pull request #11284: KAFKA-13202: KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

2021-10-21 Thread GitBox
kirktrue commented on a change in pull request #11284: URL: https://github.com/apache/kafka/pull/11284#discussion_r734081500 ## File path: clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/OAuthBearerValidatorCallbackHandler.java ## @@ -0,0 +1,112 @@

[GitHub] [kafka] kirktrue commented on a change in pull request #11284: KAFKA-13202: KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

2021-10-21 Thread GitBox
kirktrue commented on a change in pull request #11284: URL: https://github.com/apache/kafka/pull/11284#discussion_r734081204 ## File path: clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/OAuthBearerLoginCallbackHandler.java ## @@ -0,0 +1,188 @@ +/*

[jira] [Commented] (KAFKA-12559) Add a top-level Streams config for bounding off-heap memory

2021-10-21 Thread Aditya Upadhyaya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17432733#comment-17432733 ] Aditya Upadhyaya commented on KAFKA-12559: -- [~ableegoldman]: thanks :) I'll go through the KIP

[jira] [Assigned] (KAFKA-12559) Add a top-level Streams config for bounding off-heap memory

2021-10-21 Thread Aditya Upadhyaya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Upadhyaya reassigned KAFKA-12559: Assignee: Aditya Upadhyaya (was: Martin Sundeqvist) > Add a top-level Streams

[GitHub] [kafka] FlorianLehmann opened a new pull request #11425: KAFKA-13393 Documentation - Add missing arguments to create a topic

2021-10-21 Thread GitBox
FlorianLehmann opened a new pull request #11425: URL: https://github.com/apache/kafka/pull/11425 In the quickstart documentation (quickstart_createtopic) , there is a command specified to create a topic: `$ bin/kafka-topics.sh --create --topic quickstart-events --bootstrap-server

[jira] [Created] (KAFKA-13393) Update website documentation to include required arguments when creating a topic

2021-10-21 Thread Florian Lehmann (Jira)
Florian Lehmann created KAFKA-13393: --- Summary: Update website documentation to include required arguments when creating a topic Key: KAFKA-13393 URL: https://issues.apache.org/jira/browse/KAFKA-13393

[GitHub] [kafka] junrao merged pull request #11414: MINOR: Renamed a few record definition files with the existing convention.

2021-10-21 Thread GitBox
junrao merged pull request #11414: URL: https://github.com/apache/kafka/pull/11414 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] ableegoldman commented on pull request #11405: KAFKA-12648: Wrap all exceptions thrown to handler as StreamsException & add TaskId field

2021-10-21 Thread GitBox
ableegoldman commented on pull request #11405: URL: https://github.com/apache/kafka/pull/11405#issuecomment-948980709 Soaks have been healthy, and all tests passed except one flaky `kafka.admin.LeaderElectionCommandTest.[1] Type=Raft, Name=testElectionResultOutput, Security=PLAINTEXT`

[GitHub] [kafka] ableegoldman commented on pull request #11420: KAFKA-12648: extend IQ APIs to work with named topologies

2021-10-21 Thread GitBox
ableegoldman commented on pull request #11420: URL: https://github.com/apache/kafka/pull/11420#issuecomment-948964447 cc @wcarlson5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] JimGalasyn commented on pull request #11404: MINOR: update Kafka Streams standby task config

2021-10-21 Thread GitBox
JimGalasyn commented on pull request #11404: URL: https://github.com/apache/kafka/pull/11404#issuecomment-948928072 > > @astubbs There is a TOC at the top of the page... Not sure what else we could do? > > b) actually move the section to be the first section, as it's far more

[GitHub] [kafka] JimGalasyn commented on a change in pull request #11404: MINOR: update Kafka Streams standby task config

2021-10-21 Thread GitBox
JimGalasyn commented on a change in pull request #11404: URL: https://github.com/apache/kafka/pull/11404#discussion_r733974182 ## File path: docs/streams/developer-guide/config-streams.html ## @@ -680,14 +680,18 @@ default.windowed.value.serde.innerState section. +

[jira] [Comment Edited] (KAFKA-13388) Kafka Producer has no timeout for nodes stuck in CHECKING_API_VERSIONS

2021-10-21 Thread David Hoffman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17432667#comment-17432667 ] David Hoffman edited comment on KAFKA-13388 at 10/21/21, 6:47 PM: -- I

[jira] [Commented] (KAFKA-13388) Kafka Producer has no timeout for nodes stuck in CHECKING_API_VERSIONS

2021-10-21 Thread David Hoffman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17432667#comment-17432667 ] David Hoffman commented on KAFKA-13388: --- I have a screenshot of some logging I added that shows

[jira] [Updated] (KAFKA-13388) Kafka Producer has no timeout for nodes stuck in CHECKING_API_VERSIONS

2021-10-21 Thread David Hoffman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Hoffman updated KAFKA-13388: -- Attachment: image-2021-10-21-13-42-06-528.png > Kafka Producer has no timeout for nodes stuck

[GitHub] [kafka] kirktrue commented on a change in pull request #11284: KAFKA-13202: KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

2021-10-21 Thread GitBox
kirktrue commented on a change in pull request #11284: URL: https://github.com/apache/kafka/pull/11284#discussion_r733928342 ## File path: clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/AccessTokenRetrieverFactory.java ## @@ -0,0 +1,78 @@ +/* + *

[GitHub] [kafka] guozhangwang commented on pull request #11340: KAFKA-13310 : KafkaConsumer cannot jump out of the poll method, and the…

2021-10-21 Thread GitBox
guozhangwang commented on pull request #11340: URL: https://github.com/apache/kafka/pull/11340#issuecomment-948851978 Thanks everyone for the valuable discussions, this is a tricky issue indeed and worth some more clarifications, on the status quo. In general there are a lot of issues

[GitHub] [kafka] vamossagar12 commented on pull request #11211: KAFKA-12960: Enforcing strict retention time for WindowStore and Sess…

2021-10-21 Thread GitBox
vamossagar12 commented on pull request #11211: URL: https://github.com/apache/kafka/pull/11211#issuecomment-948851456 @guozhangwang 1) The in memory default state stores already does the filtering. Original thought was to make the Persistent Store be able to also enforce the same

[GitHub] [kafka] kirktrue commented on a change in pull request #11284: KAFKA-13202: KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

2021-10-21 Thread GitBox
kirktrue commented on a change in pull request #11284: URL: https://github.com/apache/kafka/pull/11284#discussion_r733901463 ## File path: clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/OAuthBearerValidatorCallbackHandler.java ## @@ -0,0 +1,112 @@

[GitHub] [kafka] kirktrue commented on a change in pull request #11284: KAFKA-13202: KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

2021-10-21 Thread GitBox
kirktrue commented on a change in pull request #11284: URL: https://github.com/apache/kafka/pull/11284#discussion_r733897632 ## File path: clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/ValidatorAccessTokenValidator.java ## @@ -0,0 +1,209 @@ +/* +

[GitHub] [kafka] vamossagar12 commented on pull request #11424: Kafka 13152: Replace "buffered.records.per.partition" with "input.buffer.max.bytes"

2021-10-21 Thread GitBox
vamossagar12 commented on pull request #11424: URL: https://github.com/apache/kafka/pull/11424#issuecomment-948846674 @guozhangwang Implementation of the KIP. Note that number of files is big as this renames the cache size config. -- This is an automated message from the Apache Git

[GitHub] [kafka] kirktrue commented on a change in pull request #11284: KAFKA-13202: KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

2021-10-21 Thread GitBox
kirktrue commented on a change in pull request #11284: URL: https://github.com/apache/kafka/pull/11284#discussion_r733900761 ## File path: clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/ValidatorAccessTokenValidator.java ## @@ -0,0 +1,209 @@ +/* +

[GitHub] [kafka] vamossagar12 opened a new pull request #11424: Kafka 13152: Replace "buffered.records.per.partition" with "input.buffer.max.bytes"

2021-10-21 Thread GitBox
vamossagar12 opened a new pull request #11424: URL: https://github.com/apache/kafka/pull/11424 This PR is an implementation of: https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=186878390. The following changes have been made: - Adding a new config

[GitHub] [kafka] kirktrue commented on a change in pull request #11284: KAFKA-13202: KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

2021-10-21 Thread GitBox
kirktrue commented on a change in pull request #11284: URL: https://github.com/apache/kafka/pull/11284#discussion_r733897632 ## File path: clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/ValidatorAccessTokenValidator.java ## @@ -0,0 +1,209 @@ +/* +

[GitHub] [kafka] kirktrue commented on a change in pull request #11284: KAFKA-13202: KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

2021-10-21 Thread GitBox
kirktrue commented on a change in pull request #11284: URL: https://github.com/apache/kafka/pull/11284#discussion_r733895025 ## File path: clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/ValidatorAccessTokenValidator.java ## @@ -0,0 +1,209 @@ +/* +

[GitHub] [kafka] guozhangwang commented on pull request #11211: KAFKA-12960: Enforcing strict retention time for WindowStore and Sess…

2021-10-21 Thread GitBox
guozhangwang commented on pull request #11211: URL: https://github.com/apache/kafka/pull/11211#issuecomment-948839504 Hi @vamossagar12 @ableegoldman I took a quick look at the PR and I have a few questions: * The fix itself seems to be applied only to persistent stores (built-in or

[GitHub] [kafka] kirktrue commented on a change in pull request #11284: KAFKA-13202: KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

2021-10-21 Thread GitBox
kirktrue commented on a change in pull request #11284: URL: https://github.com/apache/kafka/pull/11284#discussion_r733893905 ## File path: clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/ValidatorAccessTokenValidator.java ## @@ -0,0 +1,209 @@ +/* +

[GitHub] [kafka] kirktrue commented on a change in pull request #11284: KAFKA-13202: KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

2021-10-21 Thread GitBox
kirktrue commented on a change in pull request #11284: URL: https://github.com/apache/kafka/pull/11284#discussion_r733888042 ## File path: clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/HttpAccessTokenRetriever.java ## @@ -0,0 +1,325 @@ +/* + *

[GitHub] [kafka] kirktrue commented on a change in pull request #11284: KAFKA-13202: KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

2021-10-21 Thread GitBox
kirktrue commented on a change in pull request #11284: URL: https://github.com/apache/kafka/pull/11284#discussion_r733887473 ## File path: clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/HttpAccessTokenRetriever.java ## @@ -0,0 +1,325 @@ +/* + *

[GitHub] [kafka] kirktrue commented on a change in pull request #11284: KAFKA-13202: KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

2021-10-21 Thread GitBox
kirktrue commented on a change in pull request #11284: URL: https://github.com/apache/kafka/pull/11284#discussion_r733882914 ## File path: clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/HttpAccessTokenRetriever.java ## @@ -0,0 +1,325 @@ +/* + *

[GitHub] [kafka] kirktrue commented on a change in pull request #11284: KAFKA-13202: KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

2021-10-21 Thread GitBox
kirktrue commented on a change in pull request #11284: URL: https://github.com/apache/kafka/pull/11284#discussion_r733864413 ## File path: clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/HttpAccessTokenRetriever.java ## @@ -0,0 +1,325 @@ +/* + *

[GitHub] [kafka] kirktrue commented on a change in pull request #11284: KAFKA-13202: KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

2021-10-21 Thread GitBox
kirktrue commented on a change in pull request #11284: URL: https://github.com/apache/kafka/pull/11284#discussion_r733854104 ## File path: clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/HttpAccessTokenRetriever.java ## @@ -0,0 +1,325 @@ +/* + *

[GitHub] [kafka] kirktrue commented on a change in pull request #11284: KAFKA-13202: KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

2021-10-21 Thread GitBox
kirktrue commented on a change in pull request #11284: URL: https://github.com/apache/kafka/pull/11284#discussion_r733851806 ## File path: clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/ConfigurationUtils.java ## @@ -0,0 +1,277 @@ +/* + * Licensed

[GitHub] [kafka] kirktrue commented on a change in pull request #11284: KAFKA-13202: KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

2021-10-21 Thread GitBox
kirktrue commented on a change in pull request #11284: URL: https://github.com/apache/kafka/pull/11284#discussion_r733850703 ## File path: clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/ConfigurationUtils.java ## @@ -0,0 +1,277 @@ +/* + * Licensed

[GitHub] [kafka] sebbASF opened a new pull request #11423: Update doap_Kafka.rdf

2021-10-21 Thread GitBox
sebbASF opened a new pull request #11423: URL: https://github.com/apache/kafka/pull/11423 Wrong syntax; which is why Kafka does not appear in BigData category on projects.a.o -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (KAFKA-10413) rebalancing leads to unevenly balanced connectors

2021-10-21 Thread stuxnet (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17432564#comment-17432564 ] stuxnet commented on KAFKA-10413: - Hello,  I confirm that we also see the same issue, any news on this ?

[jira] [Commented] (KAFKA-13388) Kafka Producer has no timeout for nodes stuck in CHECKING_API_VERSIONS

2021-10-21 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17432563#comment-17432563 ] David Jacot commented on KAFKA-13388: - Interesting... It would be great if you could provide more

[GitHub] [kafka] ocadaruma opened a new pull request #11422: KAFKA-9648: Add configuration to adjust listen backlog size for Acceptor

2021-10-21 Thread GitBox
ocadaruma opened a new pull request #11422: URL: https://github.com/apache/kafka/pull/11422 https://issues.apache.org/jira/browse/KAFKA-9648 * This PR implements [KIP-764](https://cwiki.apache.org/confluence/display/KAFKA/KIP-764%3A+Configurable+backlog+size+for+creating+Acceptor)

[GitHub] [kafka] ccding commented on pull request #11345: Allow empty last segment to have missing offset index during recovery

2021-10-21 Thread GitBox
ccding commented on pull request #11345: URL: https://github.com/apache/kafka/pull/11345#issuecomment-948707270 @kowshik I will find some time to work on it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (KAFKA-13388) Kafka Producer has no timeout for nodes stuck in CHECKING_API_VERSIONS

2021-10-21 Thread David Hoffman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17432504#comment-17432504 ] David Hoffman commented on KAFKA-13388: --- [~dajac] Thanks for looking into this and replying. We

[jira] [Commented] (KAFKA-13391) Failure on Windows due to AccessDeniedAcception when attempting to fsync the parent directory

2021-10-21 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17432399#comment-17432399 ] Luke Chen commented on KAFKA-13391: --- Also happened in HDFS, and the solution is also to skip fsync

[jira] [Updated] (KAFKA-13392) Timeout Exception triggering reassign partitions with --bootstrap-server option

2021-10-21 Thread Yevgeniy Korin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yevgeniy Korin updated KAFKA-13392: --- Description: *Scenario when we faced with this issue:* One of three brokers is down. Add

[jira] [Created] (KAFKA-13392) Timeout Exception triggering reassign partitions with --bootstrap-server option

2021-10-21 Thread Yevgeniy Korin (Jira)
Yevgeniy Korin created KAFKA-13392: -- Summary: Timeout Exception triggering reassign partitions with --bootstrap-server option Key: KAFKA-13392 URL: https://issues.apache.org/jira/browse/KAFKA-13392

[jira] [Commented] (KAFKA-10493) KTable out-of-order updates are not being ignored

2021-10-21 Thread Nicholas Telford (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17432355#comment-17432355 ] Nicholas Telford commented on KAFKA-10493: -- Good to hear progress is being made on a solution.

[jira] [Assigned] (KAFKA-13391) Failure on Windows due to AccessDeniedAcception when attempting to fsync the parent directory

2021-10-21 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen reassigned KAFKA-13391: - Assignee: Luke Chen > Failure on Windows due to AccessDeniedAcception when attempting to fsync

[jira] [Assigned] (KAFKA-13390) Kafka 3 fails to run on Windows

2021-10-21 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen reassigned KAFKA-13390: - Assignee: Luke Chen > Kafka 3 fails to run on Windows > --- > >

[jira] [Commented] (KAFKA-13391) Failure on Windows due to AccessDeniedAcception when attempting to fsync the parent directory

2021-10-21 Thread Andy Wilkinson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17432337#comment-17432337 ] Andy Wilkinson commented on KAFKA-13391: This may be a duplicate of KAFKA-13390 which was also

[jira] [Created] (KAFKA-13391) Failure on Windows due to AccessDeniedAcception when attempting to fsync the parent directory

2021-10-21 Thread Andy Wilkinson (Jira)
Andy Wilkinson created KAFKA-13391: -- Summary: Failure on Windows due to AccessDeniedAcception when attempting to fsync the parent directory Key: KAFKA-13391 URL: https://issues.apache.org/jira/browse/KAFKA-13391

[jira] [Updated] (KAFKA-13390) Kafka 3 fails to run on Windows

2021-10-21 Thread Mykola Makhin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mykola Makhin updated KAFKA-13390: -- Priority: Minor (was: Major) > Kafka 3 fails to run on Windows >

[jira] [Updated] (KAFKA-13390) Kafka 3 fails to run on Windows

2021-10-21 Thread Mykola Makhin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mykola Makhin updated KAFKA-13390: -- Description: During startup Kafka creates some files in logs folder, but then outputs two

[jira] [Updated] (KAFKA-13390) Kafka 3 fails to run on Windows

2021-10-21 Thread Mykola Makhin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mykola Makhin updated KAFKA-13390: -- Description: During startup Kafka creates some files in logs folder, but then outputs two

[jira] [Updated] (KAFKA-13390) Kafka 3 fails to run on Windows

2021-10-21 Thread Mykola Makhin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mykola Makhin updated KAFKA-13390: -- Description: During startup Kafka creates some files in logs folder, but then outputs two

[jira] [Updated] (KAFKA-13390) Kafka 3 fails to run on Windows

2021-10-21 Thread Mykola Makhin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mykola Makhin updated KAFKA-13390: -- Description: During startup Kafka creates some files in logs folder, but then outputs two

[jira] [Updated] (KAFKA-13390) Kafka 3 fails to run on Windows

2021-10-21 Thread Mykola Makhin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mykola Makhin updated KAFKA-13390: -- Description: During startup Kafka creates some files in logs folder, but then outputs two

[jira] [Created] (KAFKA-13390) Kafka 3 fails to run on Windows

2021-10-21 Thread Mykola Makhin (Jira)
Mykola Makhin created KAFKA-13390: - Summary: Kafka 3 fails to run on Windows Key: KAFKA-13390 URL: https://issues.apache.org/jira/browse/KAFKA-13390 Project: Kafka Issue Type: Bug

[GitHub] [kafka] astubbs commented on pull request #11404: MINOR: update Kafka Streams standby task config

2021-10-21 Thread GitBox
astubbs commented on pull request #11404: URL: https://github.com/apache/kafka/pull/11404#issuecomment-948399673 > @astubbs There is a TOC at the top of the page... Not sure what else we could do? Yeah, but for such _critical_ settings, it's way too subtle. People don't read

[GitHub] [kafka] kowshik edited a comment on pull request #11345: Allow empty last segment to have missing offset index during recovery

2021-10-21 Thread GitBox
kowshik edited a comment on pull request #11345: URL: https://github.com/apache/kafka/pull/11345#issuecomment-948322460 @ccding Are you planning to add a unit test for this PR, and address the recent review comments? -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] kowshik commented on pull request #11345: Allow empty last segment to have missing offset index during recovery

2021-10-21 Thread GitBox
kowshik commented on pull request #11345: URL: https://github.com/apache/kafka/pull/11345#issuecomment-948322460 @ccding Are you planning to add a unit test for this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] showuon commented on pull request #11340: KAFKA-13310 : KafkaConsumer cannot jump out of the poll method, and the…

2021-10-21 Thread GitBox
showuon commented on pull request #11340: URL: https://github.com/apache/kafka/pull/11340#issuecomment-948316660 > And if the asynchronous submission fails all the time, we need to consider how to control a timeout period during multiple calls to consumer.poll. I don't think that

[GitHub] [kafka] RivenSun2 edited a comment on pull request #11340: KAFKA-13310 : KafkaConsumer cannot jump out of the poll method, and the…

2021-10-21 Thread GitBox
RivenSun2 edited a comment on pull request #11340: URL: https://github.com/apache/kafka/pull/11340#issuecomment-948271872 Hi @guozhangwang Thank you for your reply,I agree with most of your points, `KIP-580` is also a great optimization, I hope it can be completed as soon as possible.

[GitHub] [kafka] 3schwartz commented on a change in pull request #11418: MINOR: Write log differently according to the size of missingListenerPartitions

2021-10-21 Thread GitBox
3schwartz commented on a change in pull request #11418: URL: https://github.com/apache/kafka/pull/11418#discussion_r733361106 ## File path: clients/src/main/java/org/apache/kafka/clients/NetworkClient.java ## @@ -1080,8 +1080,13 @@ public void

[GitHub] [kafka] RivenSun2 edited a comment on pull request #11340: KAFKA-13310 : KafkaConsumer cannot jump out of the poll method, and the…

2021-10-21 Thread GitBox
RivenSun2 edited a comment on pull request #11340: URL: https://github.com/apache/kafka/pull/11340#issuecomment-948271872 Hi @guozhangwang Thank you for your reply,I agree with most of your points, `KIP-580` is also a great optimization, I hope it can be completed as soon as possible.

[GitHub] [kafka] RivenSun2 edited a comment on pull request #11340: KAFKA-13310 : KafkaConsumer cannot jump out of the poll method, and the…

2021-10-21 Thread GitBox
RivenSun2 edited a comment on pull request #11340: URL: https://github.com/apache/kafka/pull/11340#issuecomment-948271872 Hi @guozhangwang Thank you for your reply,I agree with most of your points, `KIP-580` is also a great optimization, I hope it can be completed as soon as possible.

[jira] [Commented] (KAFKA-13388) Kafka Producer has no timeout for nodes stuck in CHECKING_API_VERSIONS

2021-10-21 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17432238#comment-17432238 ] David Jacot commented on KAFKA-13388: - [~dhofftgt] Thanks for filing this issue. Which client

[GitHub] [kafka] RivenSun2 edited a comment on pull request #11340: KAFKA-13310 : KafkaConsumer cannot jump out of the poll method, and the…

2021-10-21 Thread GitBox
RivenSun2 edited a comment on pull request #11340: URL: https://github.com/apache/kafka/pull/11340#issuecomment-948271872 Hi @guozhangwang Thank you for your reply,I agree with most of your points, `KIP-580` is also a great optimization, I hope it can be completed as soon as possible.

[GitHub] [kafka] RivenSun2 edited a comment on pull request #11340: KAFKA-13310 : KafkaConsumer cannot jump out of the poll method, and the…

2021-10-21 Thread GitBox
RivenSun2 edited a comment on pull request #11340: URL: https://github.com/apache/kafka/pull/11340#issuecomment-948271872 Hi @guozhangwang Thank you for your reply,I agree with most of your points, `KIP-580` is also a great optimization, I hope it can be completed as soon as possible.

[jira] [Created] (KAFKA-13389) Add to kafka shell scripts checks about server state

2021-10-21 Thread Seweryn Habdank-Wojewodzki (Jira)
Seweryn Habdank-Wojewodzki created KAFKA-13389: -- Summary: Add to kafka shell scripts checks about server state Key: KAFKA-13389 URL: https://issues.apache.org/jira/browse/KAFKA-13389

[GitHub] [kafka] dajac merged pull request #11203: MINOR: Fixed "snasphot" naming issue

2021-10-21 Thread GitBox
dajac merged pull request #11203: URL: https://github.com/apache/kafka/pull/11203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

  1   2   >