[GitHub] [kafka] showuon commented on pull request #11613: MINOR: Update streamResetter option description

showuon commented on pull request #11613: URL: https://github.com/apache/kafka/pull/11613#issuecomment-997165583 @jeqo @mjsax , please help take a look. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] showuon opened a new pull request #11613: MINOR: Update streamResetter option description

showuon opened a new pull request #11613: URL: https://github.com/apache/kafka/pull/11613 In [KIP-171](https://cwiki.apache.org/confluence/display/KAFKA/KIP-171+-+Extend+Consumer+Group+Reset+Offset+for+Stream+Application), We added support to allow users to specify to reset offsets to a

[GitHub] [kafka] showuon closed pull request #11612: MINOR: Update stream resetter option description

showuon closed pull request #11612: URL: https://github.com/apache/kafka/pull/11612 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] showuon opened a new pull request #11612: MINOR: Update stream resetter option description

showuon opened a new pull request #11612: URL: https://github.com/apache/kafka/pull/11612 In [KIP-171](https://cwiki.apache.org/confluence/display/KAFKA/KIP-171+-+Extend+Consumer+Group+Reset+Offset+for+Stream+Application), We added support to allow users to specify to reset offsets to a

[jira] [Updated] (KAFKA-12399) Deprecate Log4J Appender

[ https://issues.apache.org/jira/browse/KAFKA-12399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dongjin Lee updated KAFKA-12399: Description: As a following job of KAFKA-9366, we have to entirely remove the log4j 1.2.7

[jira] [Updated] (KAFKA-12399) Deprecate Log4J Appender

[ https://issues.apache.org/jira/browse/KAFKA-12399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dongjin Lee updated KAFKA-12399: Summary: Deprecate Log4J Appender (was: Add log4j2 Appender) > Deprecate Log4J Appender >

[GitHub] [kafka] showuon commented on pull request #11596: MINOR: bump version in kraft readme

showuon commented on pull request #11596: URL: https://github.com/apache/kafka/pull/11596#issuecomment-997159268 @cmccabe , thanks for your comment. I've updated the PR. Please check again. Thank you. -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (KAFKA-13549) Add "delete interval" config

[ https://issues.apache.org/jira/browse/KAFKA-13549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461738#comment-17461738 ] Matthias J. Sax commented on KAFKA-13549: - You could also just do the KIP. Should not be too

[GitHub] [kafka] mjsax commented on pull request #11610: KAFKA-13549: Add delete.interval.ms to Streams

mjsax commented on pull request #11610: URL: https://github.com/apache/kafka/pull/11610#issuecomment-997113605 Thanks for the PR. Can you do a KIP for this? Happy to review the PR after the KIP is approved. -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Resolved] (KAFKA-13544) Deadlock during shutting down kafka broker because of connectivity problem with zookeeper

[ https://issues.apache.org/jira/browse/KAFKA-13544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-13544. - Fix Version/s: 3.2.0 Resolution: Fixed Merged the PR to trunk. > Deadlock during shutting down

[jira] [Created] (KAFKA-13555) Consider number if input topic partitions for task assignment

Matthias J. Sax created KAFKA-13555: --- Summary: Consider number if input topic partitions for task assignment Key: KAFKA-13555 URL: https://issues.apache.org/jira/browse/KAFKA-13555 Project: Kafka

[GitHub] [kafka] junrao merged pull request #11607: KAFKA-13544: fix FinalizedFeatureChangeListener deadlock

junrao merged pull request #11607: URL: https://github.com/apache/kafka/pull/11607 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] mjsax commented on a change in pull request #11582: KAFKA-13525: Implement KeyQuery in Streams IQv2

mjsax commented on a change in pull request #11582: URL: https://github.com/apache/kafka/pull/11582#discussion_r771749966 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java ## @@ -186,6 +203,68 @@ public boolean

[GitHub] [kafka] junrao merged pull request #11605: MINOR: replace lastOption call in LocalLog#flush() to prevent NoSuchElementException

junrao merged pull request #11605: URL: https://github.com/apache/kafka/pull/11605 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] mjsax commented on a change in pull request #11582: KAFKA-13525: Implement KeyQuery in Streams IQv2

mjsax commented on a change in pull request #11582: URL: https://github.com/apache/kafka/pull/11582#discussion_r771749813 ## File path: streams/src/main/java/org/apache/kafka/streams/query/QueryResult.java ## @@ -197,6 +197,18 @@ public R getResult() { return result;

[GitHub] [kafka] mjsax commented on a change in pull request #11582: KAFKA-13525: Implement KeyQuery in Streams IQv2

mjsax commented on a change in pull request #11582: URL: https://github.com/apache/kafka/pull/11582#discussion_r771733023 ## File path: streams/src/main/java/org/apache/kafka/streams/query/QueryResult.java ## @@ -197,6 +197,18 @@ public R getResult() { return result;

[GitHub] [kafka] mjsax commented on a change in pull request #11582: KAFKA-13525: Implement KeyQuery in Streams IQv2

mjsax commented on a change in pull request #11582: URL: https://github.com/apache/kafka/pull/11582#discussion_r771733023 ## File path: streams/src/main/java/org/apache/kafka/streams/query/QueryResult.java ## @@ -197,6 +197,18 @@ public R getResult() { return result;

[GitHub] [kafka] vvcephei commented on a change in pull request #11582: KAFKA-13525: Implement KeyQuery in Streams IQv2

vvcephei commented on a change in pull request #11582: URL: https://github.com/apache/kafka/pull/11582#discussion_r771746009 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java ## @@ -267,17 +281,41 @@ public boolean

[GitHub] [kafka] vvcephei commented on a change in pull request #11582: KAFKA-13525: Implement KeyQuery in Streams IQv2

vvcephei commented on a change in pull request #11582: URL: https://github.com/apache/kafka/pull/11582#discussion_r771745563 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java ## @@ -677,18 +638,56 @@ public void

[jira] [Commented] (KAFKA-9234) Consider using @Nullable and @Nonnull annotations

[ https://issues.apache.org/jira/browse/KAFKA-9234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461722#comment-17461722 ] Lars Bodewig commented on KAFKA-9234: - Is contribution for this issue still welcome? As far as I can

[GitHub] [kafka] guozhangwang commented on a change in pull request #11582: KAFKA-13525: Implement KeyQuery in Streams IQv2

guozhangwang commented on a change in pull request #11582: URL: https://github.com/apache/kafka/pull/11582#discussion_r771744164 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/StoreQueryUtils.java ## @@ -162,15 +163,39 @@ public static boolean

[GitHub] [kafka] guozhangwang merged pull request #11451: KAFKA-13419: Only reset generation ID when ILLEGAL_GENERATION error

guozhangwang merged pull request #11451: URL: https://github.com/apache/kafka/pull/11451 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] guozhangwang commented on a change in pull request #11451: KAFKA-13419: Only reset generation ID when ILLEGAL_GENERATION error

guozhangwang commented on a change in pull request #11451: URL: https://github.com/apache/kafka/pull/11451#discussion_r771742433 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java ## @@ -705,13 +705,13 @@ protected void

[GitHub] [kafka] vvcephei commented on a change in pull request #11582: KAFKA-13525: Implement KeyQuery in Streams IQv2

vvcephei commented on a change in pull request #11582: URL: https://github.com/apache/kafka/pull/11582#discussion_r771742317 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/StoreQueryUtils.java ## @@ -162,15 +163,39 @@ public static boolean

[GitHub] [kafka] vvcephei commented on a change in pull request #11582: KAFKA-13525: Implement KeyQuery in Streams IQv2

vvcephei commented on a change in pull request #11582: URL: https://github.com/apache/kafka/pull/11582#discussion_r771741301 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java ## @@ -253,12 +262,17 @@ public boolean

[jira] [Created] (KAFKA-13554) Rename RangeQuery to KeyRangeQuery

John Roesler created KAFKA-13554: Summary: Rename RangeQuery to KeyRangeQuery Key: KAFKA-13554 URL: https://issues.apache.org/jira/browse/KAFKA-13554 Project: Kafka Issue Type: Sub-task

[GitHub] [kafka] vvcephei commented on a change in pull request #11582: KAFKA-13525: Implement KeyQuery in Streams IQv2

vvcephei commented on a change in pull request #11582: URL: https://github.com/apache/kafka/pull/11582#discussion_r771741132 ## File path: streams/src/main/java/org/apache/kafka/streams/query/RangeQuery.java ## @@ -34,7 +34,7 @@ * */ @Evolving -public class RangeQuery

[jira] [Commented] (KAFKA-13077) Replication failing after unclean shutdown of ZK and all brokers

[ https://issues.apache.org/jira/browse/KAFKA-13077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461720#comment-17461720 ] Jun Rao commented on KAFKA-13077: - [~shivakumar] : So, it seems the issue is unrelated to file

[GitHub] [kafka] vvcephei commented on a change in pull request #11582: KAFKA-13525: Implement KeyQuery in Streams IQv2

vvcephei commented on a change in pull request #11582: URL: https://github.com/apache/kafka/pull/11582#discussion_r771739597 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java ## @@ -186,6 +203,68 @@ public boolean

[jira] [Created] (KAFKA-13553) Add DSL stores to IQv2StoreIntegrationTest

John Roesler created KAFKA-13553: Summary: Add DSL stores to IQv2StoreIntegrationTest Key: KAFKA-13553 URL: https://issues.apache.org/jira/browse/KAFKA-13553 Project: Kafka Issue Type:

[GitHub] [kafka] mjsax commented on a change in pull request #11582: KAFKA-13525: Implement KeyQuery in Streams IQv2

mjsax commented on a change in pull request #11582: URL: https://github.com/apache/kafka/pull/11582#discussion_r771738427 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/StoreQueryUtils.java ## @@ -42,16 +102,21 @@ private StoreQueryUtils() {

[GitHub] [kafka] guozhangwang commented on a change in pull request #11609: KAFKA-12648: fixes for query APIs and blocking calls

guozhangwang commented on a change in pull request #11609: URL: https://github.com/apache/kafka/pull/11609#discussion_r771737051 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsMetadataState.java ## @@ -349,8 +351,10 @@ private void

[GitHub] [kafka] mjsax commented on a change in pull request #11582: KAFKA-13525: Implement KeyQuery in Streams IQv2

mjsax commented on a change in pull request #11582: URL: https://github.com/apache/kafka/pull/11582#discussion_r771738126 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/StoreQueryUtils.java ## @@ -16,18 +16,78 @@ */ package

[GitHub] [kafka] mjsax commented on a change in pull request #11582: KAFKA-13525: Implement KeyQuery in Streams IQv2

mjsax commented on a change in pull request #11582: URL: https://github.com/apache/kafka/pull/11582#discussion_r771737792 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/StoreQueryUtils.java ## @@ -16,18 +16,78 @@ */ package

[GitHub] [kafka] vvcephei commented on a change in pull request #11582: KAFKA-13525: Implement KeyQuery in Streams IQv2

vvcephei commented on a change in pull request #11582: URL: https://github.com/apache/kafka/pull/11582#discussion_r771737653 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java ## @@ -186,6 +203,68 @@ public boolean

[GitHub] [kafka] mjsax commented on a change in pull request #11582: KAFKA-13525: Implement KeyQuery in Streams IQv2

mjsax commented on a change in pull request #11582: URL: https://github.com/apache/kafka/pull/11582#discussion_r771737576 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java ## @@ -186,6 +203,68 @@ public boolean

[GitHub] [kafka] mjsax commented on a change in pull request #11582: KAFKA-13525: Implement KeyQuery in Streams IQv2

mjsax commented on a change in pull request #11582: URL: https://github.com/apache/kafka/pull/11582#discussion_r771737277 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java ## @@ -186,6 +203,68 @@ public boolean

[GitHub] [kafka] vvcephei commented on a change in pull request #11582: KAFKA-13525: Implement KeyQuery in Streams IQv2

vvcephei commented on a change in pull request #11582: URL: https://github.com/apache/kafka/pull/11582#discussion_r771736938 ## File path: streams/src/main/java/org/apache/kafka/streams/query/QueryResult.java ## @@ -197,6 +197,18 @@ public R getResult() { return

[GitHub] [kafka] vvcephei commented on a change in pull request #11582: KAFKA-13525: Implement KeyQuery in Streams IQv2

vvcephei commented on a change in pull request #11582: URL: https://github.com/apache/kafka/pull/11582#discussion_r771735849 ## File path: streams/src/main/java/org/apache/kafka/streams/query/QueryResult.java ## @@ -197,6 +197,18 @@ public R getResult() { return

[GitHub] [kafka] vvcephei commented on a change in pull request #11582: KAFKA-13525: Implement KeyQuery in Streams IQv2

vvcephei commented on a change in pull request #11582: URL: https://github.com/apache/kafka/pull/11582#discussion_r771735440 ## File path: streams/src/main/java/org/apache/kafka/streams/query/QueryResult.java ## @@ -197,6 +197,18 @@ public R getResult() { return

[GitHub] [kafka] vvcephei commented on a change in pull request #11582: KAFKA-13525: Implement KeyQuery in Streams IQv2

vvcephei commented on a change in pull request #11582: URL: https://github.com/apache/kafka/pull/11582#discussion_r771735231 ## File path: streams/src/main/java/org/apache/kafka/streams/query/RangeQuery.java ## @@ -34,7 +34,7 @@ * */ @Evolving -public class RangeQuery

[GitHub] [kafka] mjsax commented on a change in pull request #11582: KAFKA-13525: Implement KeyQuery in Streams IQv2

mjsax commented on a change in pull request #11582: URL: https://github.com/apache/kafka/pull/11582#discussion_r771734218 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java ## @@ -186,6 +203,68 @@ public boolean

[GitHub] [kafka] mjsax commented on a change in pull request #11582: KAFKA-13525: Implement KeyQuery in Streams IQv2

mjsax commented on a change in pull request #11582: URL: https://github.com/apache/kafka/pull/11582#discussion_r771733605 ## File path: streams/src/main/java/org/apache/kafka/streams/query/QueryResult.java ## @@ -197,6 +197,18 @@ public R getResult() { return result;

[GitHub] [kafka] mjsax commented on a change in pull request #11582: KAFKA-13525: Implement KeyQuery in Streams IQv2

mjsax commented on a change in pull request #11582: URL: https://github.com/apache/kafka/pull/11582#discussion_r771733023 ## File path: streams/src/main/java/org/apache/kafka/streams/query/QueryResult.java ## @@ -197,6 +197,18 @@ public R getResult() { return result;

[jira] [Updated] (KAFKA-12495) Unbalanced connectors/tasks distribution will happen in Connect's incremental cooperative assignor

[ https://issues.apache.org/jira/browse/KAFKA-12495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-12495: -- Component/s: KafkaConnect > Unbalanced connectors/tasks distribution will happen in Connect's

[GitHub] [kafka] mjsax commented on a change in pull request #11582: KAFKA-13525: Implement KeyQuery in Streams IQv2

mjsax commented on a change in pull request #11582: URL: https://github.com/apache/kafka/pull/11582#discussion_r770076908 ## File path: streams/src/main/java/org/apache/kafka/streams/query/QueryResult.java ## @@ -197,6 +197,18 @@ public R getResult() { return result;

[GitHub] [kafka] guozhangwang commented on pull request #11609: KAFKA-12648: fixes for query APIs and blocking calls

guozhangwang commented on pull request #11609: URL: https://github.com/apache/kafka/pull/11609#issuecomment-997076409 @ableegoldman some related tests are failing, I will go ahead and review the code still. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] guozhangwang commented on a change in pull request #11582: KAFKA-13525: Implement KeyQuery in Streams IQv2

guozhangwang commented on a change in pull request #11582: URL: https://github.com/apache/kafka/pull/11582#discussion_r771731855 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java ## @@ -267,17 +281,41 @@ public boolean

[GitHub] [kafka] guozhangwang commented on a change in pull request #11582: KAFKA-13525: Implement KeyQuery in Streams IQv2

guozhangwang commented on a change in pull request #11582: URL: https://github.com/apache/kafka/pull/11582#discussion_r771726705 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java ## @@ -253,12 +262,17 @@ public boolean

[GitHub] [kafka] cmccabe commented on a change in pull request #11596: MINOR: bump version in kraft readme

cmccabe commented on a change in pull request #11596: URL: https://github.com/apache/kafka/pull/11596#discussion_r771719219 ## File path: config/kraft/README.md ## @@ -14,8 +14,8 @@ Most important of all, KRaft mode is more scalable. We expect to be able to [su # Quickstart

[GitHub] [kafka] cmccabe commented on pull request #11596: MINOR: bump version in kraft readme

cmccabe commented on pull request #11596: URL: https://github.com/apache/kafka/pull/11596#issuecomment-997061036 Hi @showuon , thanks for the PR! I left one comment. LGTM after that is addressed. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] rondagostino commented on a change in pull request #11606: MINOR: Add shutdown tests for KRaft

rondagostino commented on a change in pull request #11606: URL: https://github.com/apache/kafka/pull/11606#discussion_r771695520 ## File path: core/src/test/scala/unit/kafka/integration/KafkaServerTestHarness.scala ## @@ -67,6 +68,14 @@ abstract class KafkaServerTestHarness

[GitHub] [kafka] vvcephei commented on a change in pull request #11582: KAFKA-13525: Implement KeyQuery in Streams IQv2

vvcephei commented on a change in pull request #11582: URL: https://github.com/apache/kafka/pull/11582#discussion_r771687546 ## File path: streams/src/main/java/org/apache/kafka/streams/query/RangeQuery.java ## @@ -34,7 +34,7 @@ * */ @Evolving -public class RangeQuery

[GitHub] [kafka] wcarlson5 commented on pull request #11611: MINOR: prefix topics if internal config is set

wcarlson5 commented on pull request #11611: URL: https://github.com/apache/kafka/pull/11611#issuecomment-997025039 @ableegoldman This should make it so we can have topics prefixed with whatever is needed -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] wcarlson5 opened a new pull request #11611: MINOR: prefix topics if internal config is set

wcarlson5 opened a new pull request #11611: URL: https://github.com/apache/kafka/pull/11611 In order to move a topology to another runtime without having to copy over the internal topics it would be good to have the option to not prefix the internal topics with the application ID. So this

[GitHub] [kafka] gwenshap closed pull request #11555: MINOR: Correct usage of ConfigException in file and directory config providers

gwenshap closed pull request #11555: URL: https://github.com/apache/kafka/pull/11555 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] OneCricketeer commented on pull request #7965: KAFKA-9436: New Kafka Connect SMT for plainText => Struct(or Map)

OneCricketeer commented on pull request #7965: URL: https://github.com/apache/kafka/pull/7965#issuecomment-996944487 > suggest using grok patterns I knew I'd seen this somewhere before, but finally found it again https://github.com/streamthoughts/kafka-connect-transform-grok

[jira] [Assigned] (KAFKA-13546) Explicitly specifying default topic creation groups should not make connector fail

[ https://issues.apache.org/jira/browse/KAFKA-13546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] venkat teki reassigned KAFKA-13546: --- Assignee: venkat teki > Explicitly specifying default topic creation groups should not

[GitHub] [kafka] vvcephei commented on a change in pull request #11582: KAFKA-13525: Implement KeyQuery in Streams IQv2

vvcephei commented on a change in pull request #11582: URL: https://github.com/apache/kafka/pull/11582#discussion_r771530728 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/StoreQueryUtils.java ## @@ -42,16 +102,21 @@ private StoreQueryUtils() {

[GitHub] [kafka] vvcephei commented on a change in pull request #11582: KAFKA-13525: Implement KeyQuery in Streams IQv2

vvcephei commented on a change in pull request #11582: URL: https://github.com/apache/kafka/pull/11582#discussion_r771520958 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/StoreQueryUtils.java ## @@ -16,18 +16,78 @@ */ package

[GitHub] [kafka] vvcephei commented on a change in pull request #11582: KAFKA-13525: Implement KeyQuery in Streams IQv2

vvcephei commented on a change in pull request #11582: URL: https://github.com/apache/kafka/pull/11582#discussion_r771517463 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/StoreQueryUtils.java ## @@ -16,18 +16,78 @@ */ package

[GitHub] [kafka] vvcephei commented on a change in pull request #11582: KAFKA-13525: Implement KeyQuery in Streams IQv2

vvcephei commented on a change in pull request #11582: URL: https://github.com/apache/kafka/pull/11582#discussion_r771517463 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/StoreQueryUtils.java ## @@ -16,18 +16,78 @@ */ package

[GitHub] [kafka] vvcephei commented on a change in pull request #11582: KAFKA-13525: Implement KeyQuery in Streams IQv2

vvcephei commented on a change in pull request #11582: URL: https://github.com/apache/kafka/pull/11582#discussion_r771515988 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/StoreQueryUtils.java ## @@ -16,18 +16,78 @@ */ package

[GitHub] [kafka] vvcephei commented on a change in pull request #11582: KAFKA-13525: Implement KeyQuery in Streams IQv2

vvcephei commented on a change in pull request #11582: URL: https://github.com/apache/kafka/pull/11582#discussion_r771513674 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/StoreQueryUtils.java ## @@ -16,18 +16,78 @@ */ package

[GitHub] [kafka] vvcephei commented on a change in pull request #11582: KAFKA-13525: Implement KeyQuery in Streams IQv2

vvcephei commented on a change in pull request #11582: URL: https://github.com/apache/kafka/pull/11582#discussion_r771512115 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java ## @@ -186,6 +203,68 @@ public boolean

[GitHub] [kafka] vvcephei commented on a change in pull request #11582: KAFKA-13525: Implement KeyQuery in Streams IQv2

vvcephei commented on a change in pull request #11582: URL: https://github.com/apache/kafka/pull/11582#discussion_r771505654 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java ## @@ -186,6 +203,68 @@ public boolean

[jira] [Commented] (KAFKA-13549) Add "delete interval" config

[ https://issues.apache.org/jira/browse/KAFKA-13549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461528#comment-17461528 ] Nicholas Telford commented on KAFKA-13549: -- I drafted a patch for this and only noticed the

[GitHub] [kafka] vvcephei commented on a change in pull request #11582: KAFKA-13525: Implement KeyQuery in Streams IQv2

vvcephei commented on a change in pull request #11582: URL: https://github.com/apache/kafka/pull/11582#discussion_r771495764 ## File path: streams/src/main/java/org/apache/kafka/streams/query/KeyQuery.java ## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] vvcephei commented on a change in pull request #11582: KAFKA-13525: Implement KeyQuery in Streams IQv2

vvcephei commented on a change in pull request #11582: URL: https://github.com/apache/kafka/pull/11582#discussion_r771494393 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java ## @@ -186,6 +203,68 @@ public boolean

[GitHub] [kafka] vvcephei commented on a change in pull request #11582: KAFKA-13525: Implement KeyQuery in Streams IQv2

vvcephei commented on a change in pull request #11582: URL: https://github.com/apache/kafka/pull/11582#discussion_r771493968 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java ## @@ -186,6 +203,68 @@ public boolean

[GitHub] [kafka] vvcephei commented on a change in pull request #11582: KAFKA-13525: Implement KeyQuery in Streams IQv2

vvcephei commented on a change in pull request #11582: URL: https://github.com/apache/kafka/pull/11582#discussion_r771492764 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java ## @@ -186,6 +203,68 @@ public boolean

[GitHub] [kafka] vvcephei commented on a change in pull request #11582: KAFKA-13525: Implement KeyQuery in Streams IQv2

vvcephei commented on a change in pull request #11582: URL: https://github.com/apache/kafka/pull/11582#discussion_r771490884 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java ## @@ -186,6 +203,68 @@ public boolean

[GitHub] [kafka] nicktelford commented on pull request #11610: KAFKA-13549: Add delete.interval.ms to Streams

nicktelford commented on pull request #11610: URL: https://github.com/apache/kafka/pull/11610#issuecomment-996810481 @mjsax -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] nicktelford opened a new pull request #11610: KAFKA-13549: Add delete.interval.ms to Streams

nicktelford opened a new pull request #11610: URL: https://github.com/apache/kafka/pull/11610 Records are explicitly deleted once they have been fully consumed. Currently, this is done every time the Task is committed, resulting in "delete records" requests being sent every

[GitHub] [kafka] vvcephei commented on a change in pull request #11582: KAFKA-13525: Implement KeyQuery in Streams IQv2

vvcephei commented on a change in pull request #11582: URL: https://github.com/apache/kafka/pull/11582#discussion_r771472556 ## File path: streams/src/main/java/org/apache/kafka/streams/query/QueryResult.java ## @@ -197,6 +197,18 @@ public R getResult() { return

[GitHub] [kafka] vvcephei commented on a change in pull request #11582: KAFKA-13525: Implement KeyQuery in Streams IQv2

vvcephei commented on a change in pull request #11582: URL: https://github.com/apache/kafka/pull/11582#discussion_r771470456 ## File path: streams/src/main/java/org/apache/kafka/streams/query/QueryResult.java ## @@ -197,6 +197,18 @@ public R getResult() { return

[GitHub] [kafka] vvcephei commented on a change in pull request #11582: KAFKA-13525: Implement KeyQuery in Streams IQv2

vvcephei commented on a change in pull request #11582: URL: https://github.com/apache/kafka/pull/11582#discussion_r771466959 ## File path: streams/src/main/java/org/apache/kafka/streams/query/QueryResult.java ## @@ -29,10 +29,10 @@ */ public final class QueryResult { -

[GitHub] [kafka] vvcephei commented on a change in pull request #11582: KAFKA-13525: Implement KeyQuery in Streams IQv2

vvcephei commented on a change in pull request #11582: URL: https://github.com/apache/kafka/pull/11582#discussion_r771459374 ## File path: streams/src/main/java/org/apache/kafka/streams/query/FailureReason.java ## @@ -52,5 +52,12 @@ * The requested store partition does

[GitHub] [kafka] vvcephei commented on a change in pull request #11582: KAFKA-13525: Implement KeyQuery in Streams IQv2

vvcephei commented on a change in pull request #11582: URL: https://github.com/apache/kafka/pull/11582#discussion_r771454005 ## File path: streams/src/main/java/org/apache/kafka/streams/query/QueryResult.java ## @@ -197,6 +197,18 @@ public R getResult() { return

[jira] [Commented] (KAFKA-13502) Support configuring BROKER_LOGGER on controller-only KRaft nodes

[ https://issues.apache.org/jira/browse/KAFKA-13502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461478#comment-17461478 ] Ron Dagostino commented on KAFKA-13502: --- This is one aspect of the broader problem as described in

[jira] [Commented] (KAFKA-13552) Unable to dynamically change broker log levels on KRaft

[ https://issues.apache.org/jira/browse/KAFKA-13552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461476#comment-17461476 ] Ron Dagostino commented on KAFKA-13552: --- [~dengziming] Thanks for pointing that out. Although

[jira] [Updated] (KAFKA-13552) Unable to dynamically change broker log levels on KRaft

[ https://issues.apache.org/jira/browse/KAFKA-13552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ron Dagostino updated KAFKA-13552: -- Description: It is currently not possible to dynamically change the log level in KRaft. For

[jira] [Commented] (KAFKA-13547) Kafka - 1.0.0 | Remove log4j.jar

[ https://issues.apache.org/jira/browse/KAFKA-13547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461472#comment-17461472 ] Dongjin Lee commented on KAFKA-13547: - [~masood31] I am currently working on a preview version based

[GitHub] [kafka] showuon commented on a change in pull request #11566: KAFKA-13495: add reason to JoinGroupRequest

showuon commented on a change in pull request #11566: URL: https://github.com/apache/kafka/pull/11566#discussion_r771395371 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java ## @@ -467,6 +468,7 @@ boolean

[GitHub] [kafka] showuon commented on a change in pull request #11566: KAFKA-13495: add reason to JoinGroupRequest

showuon commented on a change in pull request #11566: URL: https://github.com/apache/kafka/pull/11566#discussion_r771384033 ## File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala ## @@ -1249,7 +1260,7 @@ class GroupCoordinator(val brokerId: Int,

[GitHub] [kafka] dajac commented on a change in pull request #11571: KAFKA-13496: add reason to LeaveGroupRequest

dajac commented on a change in pull request #11571: URL: https://github.com/apache/kafka/pull/11571#discussion_r771376907 ## File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala ## @@ -617,9 +617,10 @@ class GroupCoordinator(val brokerId: Int,

[GitHub] [kafka] dajac commented on a change in pull request #11566: KAFKA-13495: add reason to JoinGroupRequest

dajac commented on a change in pull request #11566: URL: https://github.com/apache/kafka/pull/11566#discussion_r771371068 ## File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala ## @@ -1249,7 +1260,7 @@ class GroupCoordinator(val brokerId: Int, //

[GitHub] [kafka] dajac commented on a change in pull request #11571: KAFKA-13496: add reason to LeaveGroupRequest

dajac commented on a change in pull request #11571: URL: https://github.com/apache/kafka/pull/11571#discussion_r771248687 ## File path: clients/src/main/resources/common/message/LeaveGroupResponse.json ## @@ -24,7 +24,9 @@ // Starting in version 3, we will make leave group

[GitHub] [kafka] cadonna commented on pull request #11600: KAFKA-12648: handle MissingSourceTopicException for named topologies

cadonna commented on pull request #11600: URL: https://github.com/apache/kafka/pull/11600#issuecomment-996549823 @ableegoldman There are checkstyle errors in the builds. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] tombentley commented on a change in pull request #11560: KAFKA-7589: Allow configuring network threads per listener

tombentley commented on a change in pull request #11560: URL: https://github.com/apache/kafka/pull/11560#discussion_r771207226 ## File path: core/src/main/scala/kafka/server/DynamicBrokerConfig.scala ## @@ -920,7 +919,7 @@ class DynamicListenerConfig(server: KafkaBroker)

[GitHub] [kafka] richard-axual commented on a change in pull request #11535: KAFKA-13476: Increase resilience timestamp decoding Kafka Streams

richard-axual commented on a change in pull request #11535: URL: https://github.com/apache/kafka/pull/11535#discussion_r771190189 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -1097,15 +1097,20 @@ long

[GitHub] [kafka] showuon commented on a change in pull request #11451: KAFKA-13419: Only reset generation ID when ILLEGAL_GENERATION error

showuon commented on a change in pull request #11451: URL: https://github.com/apache/kafka/pull/11451#discussion_r771181554 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java ## @@ -705,13 +705,13 @@ protected void

[GitHub] [kafka] showuon commented on a change in pull request #11451: KAFKA-13419: Only reset generation ID when ILLEGAL_GENERATION error

showuon commented on a change in pull request #11451: URL: https://github.com/apache/kafka/pull/11451#discussion_r771181062 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java ## @@ -755,18 +755,17 @@ protected void