cmccabe merged pull request #11606:
URL: https://github.com/apache/kafka/pull/11606
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-13585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot resolved KAFKA-13585.
-
Fix Version/s: 3.2.0
3.1.1
Reviewer: Jason Gustafson
dajac merged pull request #11665:
URL: https://github.com/apache/kafka/pull/11665
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-13617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17482231#comment-17482231
]
joecqupt commented on KAFKA-13617:
--
there has a trace log show those infos.
vvcephei commented on pull request #11682:
URL: https://github.com/apache/kafka/pull/11682#issuecomment-1021786440
Turned out that the new test I added on trunk was incompatible with the
`StoreQueryUtils.handleBasicQueries`. I fixed it and went ahead and added that
default impl to
splett2 commented on pull request #11714:
URL: https://github.com/apache/kafka/pull/11714#issuecomment-1021766294
@dajac do you mind reviewing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
splett2 opened a new pull request #11714:
URL: https://github.com/apache/kafka/pull/11714
### What
In the fetch path, we check `shouldLeaderThrottle` regardless of whether the
read is coming from a consumer or follower broker. This results in replication
quota being applied to consumer
[
https://issues.apache.org/jira/browse/KAFKA-10309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-10309:
Fix Version/s: 2.7.0
> KafkaProducer's sendOffsetsToTransaction should not block
vvcephei commented on pull request #11682:
URL: https://github.com/apache/kafka/pull/11682#issuecomment-1021720193
Oy, it looks like there's a compile error after that conflict resolution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
vvcephei commented on a change in pull request #11682:
URL: https://github.com/apache/kafka/pull/11682#discussion_r792216685
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/InMemoryTimeOrderedKeyValueBuffer.java
##
@@ -238,13 +243,22 @@ private
vvcephei commented on pull request #11682:
URL: https://github.com/apache/kafka/pull/11682#issuecomment-1021685037
Huh, I just used the GH UI to fix some merge conflicts, and it looks like it
chose to merge trunk into this branch :/
--
This is an automated message from the Apache Git
cwtrex edited a comment on pull request #7965:
URL: https://github.com/apache/kafka/pull/7965#issuecomment-1021635467
> > suggest using grok patterns
>
> I knew I'd seen this somewhere before, but finally found it again
>
>
cwtrex commented on pull request #7965:
URL: https://github.com/apache/kafka/pull/7965#issuecomment-1021635467
> > suggest using grok patterns
>
> I knew I'd seen this somewhere before, but finally found it again
>
>
[
https://issues.apache.org/jira/browse/KAFKA-13612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17482115#comment-17482115
]
Dominic Evans edited comment on KAFKA-13612 at 1/25/22, 9:26 PM:
-
[
https://issues.apache.org/jira/browse/KAFKA-13612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17482115#comment-17482115
]
Dominic Evans edited comment on KAFKA-13612 at 1/25/22, 9:25 PM:
-
[
https://issues.apache.org/jira/browse/KAFKA-13612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17482115#comment-17482115
]
Dominic Evans commented on KAFKA-13612:
---
[~hachikuji] I have no affiliation with Burrow, but I can
wcarlson5 closed pull request #11675:
URL: https://github.com/apache/kafka/pull/11675
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-13600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17482079#comment-17482079
]
Tim Patterson commented on KAFKA-13600:
---
Thanks [~cadonna]
I'm not sure I have the perfect
vvcephei commented on pull request #11713:
URL: https://github.com/apache/kafka/pull/11713#issuecomment-1021547852
Test failures were unrelated:
```
Build / JDK 8 and Scala 2.12 /
kafka.api.PlaintextAdminIntegrationTest.testReplicaCanFetchFromLogStartOffsetAfterDeleteRecords()
vvcephei merged pull request #11713:
URL: https://github.com/apache/kafka/pull/11713
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
vvcephei merged pull request #11702:
URL: https://github.com/apache/kafka/pull/11702
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
vvcephei commented on pull request #11702:
URL: https://github.com/apache/kafka/pull/11702#issuecomment-1021525012
Unrelated failures:
```
Build / JDK 11 and Scala 2.13 /
kafka.admin.LeaderElectionCommandTest.[1] Type=Raft,
Name=testAllTopicPartition, Security=PLAINTEXT
C0urante commented on pull request #11508:
URL: https://github.com/apache/kafka/pull/11508#issuecomment-1021504481
Thanks @mimaison, appreciate it! This should make KIP-618 a little easier to
implement (see the note
[here](https://github.com/apache/kafka/pull/10907#discussion_r786314621)
C0urante commented on a change in pull request #11508:
URL: https://github.com/apache/kafka/pull/11508#discussion_r792021213
##
File path:
clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java
##
@@ -1019,6 +1022,149 @@ public void
ableegoldman merged pull request #11686:
URL: https://github.com/apache/kafka/pull/11686
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ableegoldman commented on pull request #11686:
URL: https://github.com/apache/kafka/pull/11686#issuecomment-1021490937
Test failures are unrelated, merging to trunk 拾
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
[
https://issues.apache.org/jira/browse/KAFKA-13612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17482006#comment-17482006
]
Jason Gustafson edited comment on KAFKA-13612 at 1/25/22, 5:59 PM:
---
I
[
https://issues.apache.org/jira/browse/KAFKA-13612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17482006#comment-17482006
]
Jason Gustafson commented on KAFKA-13612:
-
I think there is a higher level question here which
mimaison commented on a change in pull request #11508:
URL: https://github.com/apache/kafka/pull/11508#discussion_r791977277
##
File path:
clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java
##
@@ -1019,6 +1022,149 @@ public void
[
https://issues.apache.org/jira/browse/KAFKA-12879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17481998#comment-17481998
]
Randall Hauch edited comment on KAFKA-12879 at 1/25/22, 5:52 PM:
-
The
[
https://issues.apache.org/jira/browse/KAFKA-12879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17481998#comment-17481998
]
Randall Hauch commented on KAFKA-12879:
---
The original intent of
[
https://issues.apache.org/jira/browse/KAFKA-13612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17481995#comment-17481995
]
Colin McCabe commented on KAFKA-13612:
--
At the end of the day, __consumer_offsets isn't an API. If
yyang48 commented on a change in pull request #11390:
URL: https://github.com/apache/kafka/pull/11390#discussion_r791968984
##
File path:
clients/src/main/java/org/apache/kafka/common/record/RemoteLogInputStream.java
##
@@ -0,0 +1,75 @@
+/*
+ * Licensed to the Apache Software
mimaison commented on pull request #7898:
URL: https://github.com/apache/kafka/pull/7898#issuecomment-1021440975
@dongjinleekr Thanks for your work.
I hope to start reviewing the log4j2 PRs later this week. Do you recommend
starting with this one or with
yyang48 commented on a change in pull request #11390:
URL: https://github.com/apache/kafka/pull/11390#discussion_r791957579
##
File path:
clients/src/main/java/org/apache/kafka/common/record/RemoteLogInputStream.java
##
@@ -0,0 +1,75 @@
+/*
+ * Licensed to the Apache Software
mjsax commented on a change in pull request #11584:
URL: https://github.com/apache/kafka/pull/11584#discussion_r791955444
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
##
@@ -1516,4 +1527,20 @@ RebalanceProtocol
vpapavas commented on a change in pull request #11682:
URL: https://github.com/apache/kafka/pull/11682#discussion_r791953273
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/ChangeLoggingKeyValueBytesStore.java
##
@@ -145,4 +145,9 @@ public void
yyang48 commented on a change in pull request #11390:
URL: https://github.com/apache/kafka/pull/11390#discussion_r791952565
##
File path:
clients/src/main/java/org/apache/kafka/common/record/RemoteLogInputStream.java
##
@@ -0,0 +1,75 @@
+/*
+ * Licensed to the Apache Software
vpapavas opened a new pull request #11713:
URL: https://github.com/apache/kafka/pull/11713
Fix the bug where the Metered window and session stores are returning an
empty position although the query result contains the correct position.
Also added checks in the store integration test
wcarlson5 commented on a change in pull request #11712:
URL: https://github.com/apache/kafka/pull/11712#discussion_r791937041
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/Tasks.java
##
@@ -270,6 +278,23 @@ Task task(final TaskId taskId) {
cadonna opened a new pull request #11712:
URL: https://github.com/apache/kafka/pull/11712
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of
mimaison commented on a change in pull request #11691:
URL: https://github.com/apache/kafka/pull/11691#discussion_r791845179
##
File path:
clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java
##
@@ -226,6 +227,11 @@ public Password getPassword(String key)
mjsax commented on a change in pull request #11455:
URL: https://github.com/apache/kafka/pull/11455#discussion_r791323385
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/GlobalKTableIntegrationTest.java
##
@@ -176,7 +177,9 @@ public void
guozhangwang commented on pull request #11686:
URL: https://github.com/apache/kafka/pull/11686#issuecomment-1020665875
Made a final pass on the latest commits. LGTM!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
dajac merged pull request #11708:
URL: https://github.com/apache/kafka/pull/11708
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ableegoldman commented on pull request #11609:
URL: https://github.com/apache/kafka/pull/11609#issuecomment-1021195931
test failures are unrelated, ready to merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
dengziming commented on pull request #10500:
URL: https://github.com/apache/kafka/pull/10500#issuecomment-1020820360
ping @abbccdda @hachikuji to have a look when you are free.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
guozhangwang commented on a change in pull request #11609:
URL: https://github.com/apache/kafka/pull/11609#discussion_r791262134
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/NamedTopologyIntegrationTest.java
##
@@ -635,6 +710,19 @@ public void
vvcephei commented on a change in pull request #11676:
URL: https://github.com/apache/kafka/pull/11676#discussion_r791343342
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/PositionCheckpointIntegrationTest.java
##
@@ -0,0 +1,777 @@
+/*
+ * Licensed
mimaison commented on pull request #11642:
URL: https://github.com/apache/kafka/pull/11642#issuecomment-1021099300
@dajac can you take a look? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
ccding closed pull request #11709:
URL: https://github.com/apache/kafka/pull/11709
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mjsax commented on a change in pull request #11584:
URL: https://github.com/apache/kafka/pull/11584#discussion_r791429259
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
##
@@ -1516,4 +1527,20 @@ RebalanceProtocol
ableegoldman commented on a change in pull request #11609:
URL: https://github.com/apache/kafka/pull/11609#discussion_r791115535
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##
@@ -1140,6 +1140,11 @@ private void
vvcephei commented on pull request #11702:
URL: https://github.com/apache/kafka/pull/11702#issuecomment-1020723191
Test failures were unrelated:
```
Build / JDK 11 and Scala 2.13 /
integration.kafka.server.FetchRequestBetweenDifferentIbpTest.testControllerOldToNewIBP()
showuon commented on a change in pull request #11584:
URL: https://github.com/apache/kafka/pull/11584#discussion_r791569474
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
##
@@ -1516,4 +1527,20 @@ RebalanceProtocol
sayantanu-dey commented on pull request #11703:
URL: https://github.com/apache/kafka/pull/11703#issuecomment-1020797877
> One meta comment regarding consolidating the functions: we have
`getPrefix` in multiple classes (and thanks @sayantanu-dey your PRs remove some
already), but there are
jsancio commented on a change in pull request #11711:
URL: https://github.com/apache/kafka/pull/11711#discussion_r791893829
##
File path: core/src/main/scala/kafka/server/ConfigAdminManager.scala
##
@@ -515,4 +512,16 @@ object ConfigAdminManager {
}
}
}
+
+ def
dajac commented on pull request #11701:
URL: https://github.com/apache/kafka/pull/11701#issuecomment-1020351046
There are failures in the system tests but they are not related to this
change. All the tests changed in this PR have passed.
cmccabe commented on pull request #11710:
URL: https://github.com/apache/kafka/pull/11710#issuecomment-1020677668
It would be nice to redo this without the volatiles, but for now, LGTM.
Thanks, @lbradstreet .
--
This is an automated message from the Apache Git Service.
To respond to the
ableegoldman merged pull request #11704:
URL: https://github.com/apache/kafka/pull/11704
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dengziming commented on pull request #10830:
URL: https://github.com/apache/kafka/pull/10830#issuecomment-1020819384
ping @cmccabe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
mjsax commented on a change in pull request #11675:
URL: https://github.com/apache/kafka/pull/11675#discussion_r79115
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -1321,11 +1322,22 @@ int process(final int
guozhangwang commented on pull request #11609:
URL: https://github.com/apache/kafka/pull/11609#issuecomment-1020690230
LGTM! Jenkins failed on compilation (checkstyle). Please feel free to merge
after addressing the nit comments and green build.
--
This is an automated message from the
showuon commented on pull request #11242:
URL: https://github.com/apache/kafka/pull/11242#issuecomment-1020885807
PR for the implementation: https://github.com/apache/kafka/pull/11705
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
dajac merged pull request #11701:
URL: https://github.com/apache/kafka/pull/11701
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ableegoldman merged pull request #11609:
URL: https://github.com/apache/kafka/pull/11609
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mjsax commented on pull request #11584:
URL: https://github.com/apache/kafka/pull/11584#issuecomment-1020784877
Finally updated this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
mattwong949 commented on a change in pull request #11694:
URL: https://github.com/apache/kafka/pull/11694#discussion_r791420348
##
File path:
clients/src/main/java/org/apache/kafka/common/record/DefaultRecordBatch.java
##
@@ -82,9 +82,9 @@
* are retained only until either a
dajac commented on pull request #11708:
URL: https://github.com/apache/kafka/pull/11708#issuecomment-1020369488
@omkreddy This is the cherry-pick for
https://github.com/apache/kafka/pull/11706 for 3.0. The cherry-pick was not
clean. Could you take a look please?
--
This is an automated
satishd commented on a change in pull request #11390:
URL: https://github.com/apache/kafka/pull/11390#discussion_r791322611
##
File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala
##
@@ -715,6 +727,58 @@ abstract class AbstractFetcherThread(name: String,
mimaison commented on pull request #11695:
URL: https://github.com/apache/kafka/pull/11695#issuecomment-1021050143
@tombentley @vvcephei @mjsax
As you voted on the KIP, can you take a look? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message,
kowshik commented on a change in pull request #11345:
URL: https://github.com/apache/kafka/pull/11345#discussion_r791176937
##
File path: core/src/main/scala/kafka/log/UnifiedLog.scala
##
@@ -1498,28 +1498,48 @@ class UnifiedLog(@volatile var logStartOffset: Long,
showuon closed pull request #11242:
URL: https://github.com/apache/kafka/pull/11242
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
patrickstuedi commented on a change in pull request #11676:
URL: https://github.com/apache/kafka/pull/11676#discussion_r791157542
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/ProcessorContext.java
##
@@ -85,8 +85,23 @@
* @throws
ableegoldman commented on pull request #11702:
URL: https://github.com/apache/kafka/pull/11702#issuecomment-1020816735
compiler error, fyi
thanks for the fix though!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
ccding commented on pull request #11709:
URL: https://github.com/apache/kafka/pull/11709#issuecomment-1020679187
Dropping this. Lucas will bring more fixes together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
dengziming commented on pull request #11677:
URL: https://github.com/apache/kafka/pull/11677#issuecomment-1020850019
I have some questions concerning the `VersionRange` entity. In zk-related
classes we use FinalizedVersionRange and SupportedVersionRange whereas in
kraft-related code we
jsancio commented on a change in pull request #11711:
URL: https://github.com/apache/kafka/pull/11711#discussion_r791893829
##
File path: core/src/main/scala/kafka/server/ConfigAdminManager.scala
##
@@ -515,4 +512,16 @@ object ConfigAdminManager {
}
}
}
+
+ def
dajac merged pull request #11701:
URL: https://github.com/apache/kafka/pull/11701
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Nicolas Guyomar created KAFKA-13617:
---
Summary: Enhance delete-expired-group-metadata logging
Key: KAFKA-13617
URL: https://issues.apache.org/jira/browse/KAFKA-13617
Project: Kafka
Issue
Dominique Mongelli created KAFKA-13616:
--
Summary: Log4j 1.X CVE-2022-23302/5/7 vulnerabilities
Key: KAFKA-13616
URL: https://issues.apache.org/jira/browse/KAFKA-13616
Project: Kafka
ableegoldman merged pull request #11609:
URL: https://github.com/apache/kafka/pull/11609
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ableegoldman commented on pull request #11609:
URL: https://github.com/apache/kafka/pull/11609#issuecomment-1021195931
test failures are unrelated, ready to merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
mimaison commented on pull request #11642:
URL: https://github.com/apache/kafka/pull/11642#issuecomment-1021099300
@dajac can you take a look? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
[
https://issues.apache.org/jira/browse/KAFKA-13406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17481754#comment-17481754
]
Tomaz Muraus commented on KAFKA-13406:
--
First thank you for fixing this bug.
I see that v3.1.0
mimaison commented on pull request #11695:
URL: https://github.com/apache/kafka/pull/11695#issuecomment-1021050143
@tombentley @vvcephei @mjsax
As you voted on the KIP, can you take a look? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message,
showuon commented on a change in pull request #11584:
URL: https://github.com/apache/kafka/pull/11584#discussion_r791569474
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
##
@@ -1516,4 +1527,20 @@ RebalanceProtocol
[
https://issues.apache.org/jira/browse/KAFKA-13334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17481628#comment-17481628
]
Maksim Zinal commented on KAFKA-13334:
--
Duplicating my comment from KAFKA-2170 here.
I've created
dajac merged pull request #11708:
URL: https://github.com/apache/kafka/pull/11708
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
89 matches
Mail list logo
