dengziming edited a comment on pull request #11659:
URL: https://github.com/apache/kafka/pull/11659#issuecomment-1031161651
@cmccabe Thank you, I closed this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
dengziming commented on pull request #11659:
URL: https://github.com/apache/kafka/pull/11659#issuecomment-1031161651
@cmccabe Thank you, I close this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
dengziming closed pull request #11659:
URL: https://github.com/apache/kafka/pull/11659
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
xdgrulez commented on pull request #10897:
URL: https://github.com/apache/kafka/pull/10897#issuecomment-1031141718
Hi Matthias,
I don't really have time but I'd like to get this done anyway ;)
I think reopening a new PR would be more sensible... the change is too old.
showuon commented on a change in pull request #11722:
URL: https://github.com/apache/kafka/pull/11722#discussion_r800338273
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java
##
@@ -578,41 +594,46 @@ private boolean
showuon commented on a change in pull request #11722:
URL: https://github.com/apache/kafka/pull/11722#discussion_r800322496
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java
##
@@ -578,41 +594,46 @@ private boolean
[
https://issues.apache.org/jira/browse/KAFKA-13629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen resolved KAFKA-13629.
---
Fix Version/s: 3.2.0
Reviewer: Ismael Juma
Resolution: Fixed
> Client producer use
showuon edited a comment on pull request #11721:
URL: https://github.com/apache/kafka/pull/11721#issuecomment-1031042300
@jasonk000 , thanks for the good improvement! I learned a lot from the PR!
Also updated the JIRA status. Thank you.
--
This is an automated message from the Apache
showuon commented on pull request #11721:
URL: https://github.com/apache/kafka/pull/11721#issuecomment-1031042300
@jasonk000 , thanks for the good improvement! I learned a lot from the PR!
Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message,
guozhangwang commented on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-1031034049
@RivenSun2 Thanks for the final commits and thanks to @showuon for making
more passes as well. I just did another pass and it looks good to me too! I
tried to resolve the
[
https://issues.apache.org/jira/browse/KAFKA-13289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17487820#comment-17487820
]
Eugen Dück commented on KAFKA-13289:
[~mjsax] Our Streams app has now been running in production for
jsancio commented on a change in pull request #11209:
URL: https://github.com/apache/kafka/pull/11209#discussion_r800268813
##
File path:
raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientSnapshotTest.java
##
@@ -1535,6 +1535,46 @@ public void
jsancio closed pull request #11159:
URL: https://github.com/apache/kafka/pull/11159
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jsancio commented on pull request #11159:
URL: https://github.com/apache/kafka/pull/11159#issuecomment-1030981141
This was already fixed in trunk. Closing the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
jsancio commented on pull request #11159:
URL: https://github.com/apache/kafka/pull/11159#issuecomment-1030979984
> @jsancio are you going to merge this?
Yes. I can merge it. @dielhennr can you resolve the conflicts?
--
This is an automated message from the Apache Git Service.
To
guozhangwang commented on a change in pull request #10525:
URL: https://github.com/apache/kafka/pull/10525#discussion_r800263685
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java
##
@@ -1305,10 +1305,16 @@ private
guozhangwang commented on pull request #10525:
URL: https://github.com/apache/kafka/pull/10525#issuecomment-1030974945
Re-trigger jenkins.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
jsancio commented on a change in pull request #11238:
URL: https://github.com/apache/kafka/pull/11238#discussion_r800260558
##
File path: tests/kafkatest/services/kafka/kafka.py
##
@@ -858,12 +859,27 @@ def signal_leader(self, topic, partition=0,
sig=signal.SIGTERM):
showuon commented on pull request #11124:
URL: https://github.com/apache/kafka/pull/11124#issuecomment-1030946835
Make sense to me. Close this PR and cycle it back after DSL redesign. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
showuon closed pull request #11124:
URL: https://github.com/apache/kafka/pull/11124
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-13563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang resolved KAFKA-13563.
---
Fix Version/s: 3.2.0
3.1.1
Resolution: Fixed
>
guozhangwang commented on pull request #11631:
URL: https://github.com/apache/kafka/pull/11631#issuecomment-1030935640
Merged to trunk, thanks @showuon ! Also cherry-picked to 3.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
guozhangwang merged pull request #11631:
URL: https://github.com/apache/kafka/pull/11631
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
guozhangwang commented on a change in pull request #11631:
URL: https://github.com/apache/kafka/pull/11631#discussion_r800245635
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
##
@@ -488,7 +492,7 @@ public boolean
ijuma merged pull request #11721:
URL: https://github.com/apache/kafka/pull/11721
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ijuma commented on pull request #11721:
URL: https://github.com/apache/kafka/pull/11721#issuecomment-1030919300
I updated the PR description to include the JMH results I got with JDK
17.0.2 and compiler blackhole mode.
--
This is an automated message from the Apache Git Service.
To
mjsax commented on pull request #11124:
URL: https://github.com/apache/kafka/pull/11124#issuecomment-1030907820
@showuon -- should we close this PR for now?
We have actually collected a few tickets that are not easy to fix without a
DSL re-design. I would propose to add a new Jira
ijuma opened a new pull request #11736:
URL: https://github.com/apache/kafka/pull/11736
We only use it in the legacy record formats (V0 and V1) and the CRC32
implementation in the standard library has received various performance
improvements over the years
mjsax commented on pull request #10897:
URL: https://github.com/apache/kafka/pull/10897#issuecomment-1030907208
@xdgrulez -- if you are still interested in working on this, it would be
great. The PR would needs to be rebased/updated though (or just close this one
an open a new PR?)
--
[
https://issues.apache.org/jira/browse/KAFKA-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17487750#comment-17487750
]
Matthias J. Sax commented on KAFKA-13641:
-
{quote}Is the plan to have type driven semantics?
lbradstreet commented on pull request #11376:
URL: https://github.com/apache/kafka/pull/11376#issuecomment-1030866772
> Are you planning to address the comments @lbradstreet ?
@ijuma thanks for the reminder.
--
This is an automated message from the Apache Git Service.
To respond
lbradstreet commented on a change in pull request #11376:
URL: https://github.com/apache/kafka/pull/11376#discussion_r800202601
##
File path:
core/src/test/scala/unit/kafka/controller/ReplicaStateMachineTest.scala
##
@@ -394,6 +394,23 @@ class ReplicaStateMachineTest {
}
lbradstreet commented on a change in pull request #11376:
URL: https://github.com/apache/kafka/pull/11376#discussion_r800202592
##
File path: core/src/main/scala/kafka/controller/ReplicaStateMachine.scala
##
@@ -204,13 +204,17 @@ class ZkReplicaStateMachine(config:
splett2 commented on a change in pull request #11586:
URL: https://github.com/apache/kafka/pull/11586#discussion_r800194330
##
File path: clients/src/main/java/org/apache/kafka/common/network/Selector.java
##
@@ -1144,7 +1149,11 @@ public void close() {
public
showuon commented on pull request #11681:
URL: https://github.com/apache/kafka/pull/11681#issuecomment-1030829409
@dajac , it doesn't work to put the admin client creating after
`cluster.waitForReadyBrokers()`, because the waitForReadyBrokers only wait for
all brokers registered and
showuon commented on pull request #11631:
URL: https://github.com/apache/kafka/pull/11631#issuecomment-1030826032
@guozhangwang , this PR is good for review now. I've fixed broken tests and
added tests. Thank you.
--
This is an automated message from the Apache Git Service.
To respond
showuon commented on pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#issuecomment-1030773435
@lkokhreidze , thanks for the PR. I'll take a look next week. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
showuon commented on pull request #11493:
URL: https://github.com/apache/kafka/pull/11493#issuecomment-1030773151
@tim-patterson , thanks for the PR. I'll review the PR next week. Thanks for
the improvement.
--
This is an automated message from the Apache Git Service.
To respond to the
38 matches
Mail list logo
