[jira] [Commented] (KAFKA-13641) Kafka Streams Scala: Add `Option` to `ValueJoiner` parameters

2022-02-09 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17489966#comment-17489966 ] Matthias J. Sax commented on KAFKA-13641: - {quote}Hope I didn't come across as rude or imply

[jira] [Commented] (KAFKA-13289) Bulk processing correctly ordered input data through a join with kafka-streams results in `Skipping record for expired segment`

2022-02-09 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17489962#comment-17489962 ] Matthias J. Sax commented on KAFKA-13289: - Great news! Thanks for sharing. Happy you got your

[jira] [Comment Edited] (KAFKA-13655) Cannot edit clients page

2022-02-09 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17489958#comment-17489958 ] Matthias J. Sax edited comment on KAFKA-13655 at 2/10/22, 5:05 AM: ---

[jira] [Resolved] (KAFKA-13655) Cannot edit clients page

2022-02-09 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-13655. - Resolution: Not A Bug > Cannot edit clients page > > >

[jira] [Commented] (KAFKA-13655) Cannot edit clients page

2022-02-09 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17489958#comment-17489958 ] Matthias J. Sax commented on KAFKA-13655: - Did you create an account (note the Jira and wiki are

[GitHub] [kafka] dengziming commented on a change in pull request #11603: MINOR: MetadataShell should handle ProducerIdsRecord

2022-02-09 Thread GitBox
dengziming commented on a change in pull request #11603: URL: https://github.com/apache/kafka/pull/11603#discussion_r803264649 ## File path: shell/src/main/java/org/apache/kafka/shell/MetadataNodeManager.java ## @@ -318,6 +320,15 @@ private void

[GitHub] [kafka] hachikuji commented on pull request #11520: KAFKA-13468: Consumers may hang because IOException in Log# does not trigger KafkaStorageException

2022-02-09 Thread GitBox
hachikuji commented on pull request #11520: URL: https://github.com/apache/kafka/pull/11520#issuecomment-1034437206 @functioner Good find. It does indeed look like `IoException` raised from `LogManager.getOrCreateLog` is not caught anywhere. In addition to catching, we probably need to

[GitHub] [kafka] artemlivshits commented on a change in pull request #11688: KAFKA-13435; Static membership protocol should let the leader skip assignment (KIP-814)

2022-02-09 Thread GitBox
artemlivshits commented on a change in pull request #11688: URL: https://github.com/apache/kafka/pull/11688#discussion_r803251907 ## File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala ## @@ -1306,23 +1326,46 @@ class GroupCoordinator(val brokerId:

[GitHub] [kafka] hachikuji edited a comment on pull request #11558: KAFKA-13323 Fixed variable name in KafkaConsumer

2022-02-09 Thread GitBox
hachikuji edited a comment on pull request #11558: URL: https://github.com/apache/kafka/pull/11558#issuecomment-1034428663 @vijaykriishna Thanks, the variable name fix LGTM. It does look a little strange to modify the one html snippet as part of this patch. Would it make sense to split

[GitHub] [kafka] dengziming commented on a change in pull request #11655: KAFKA-13316; Enable KRaft mode in CreateTopics tests

2022-02-09 Thread GitBox
dengziming commented on a change in pull request #11655: URL: https://github.com/apache/kafka/pull/11655#discussion_r803251469 ## File path: core/src/test/scala/unit/kafka/server/CreateTopicsRequestWithPolicyTest.scala ## @@ -55,11 +63,9 @@ class

[GitHub] [kafka] hachikuji commented on pull request #11558: KAFKA-13323 Fixed variable name in KafkaConsumer

2022-02-09 Thread GitBox
hachikuji commented on pull request #11558: URL: https://github.com/apache/kafka/pull/11558#issuecomment-1034428663 @vijaykriishna Thanks, the variable name fix LGTM. It does look a little strange to modify the one html snippet as part of this patch. Would it make sense to split that out

[GitHub] [kafka] dengziming commented on a change in pull request #11667: MINOR; Enable Kraft in ApiVersionTest

2022-02-09 Thread GitBox
dengziming commented on a change in pull request #11667: URL: https://github.com/apache/kafka/pull/11667#discussion_r803248389 ## File path: core/src/test/scala/unit/kafka/server/AbstractApiVersionsRequestTest.scala ## @@ -17,35 +17,45 @@ package kafka.server import

[GitHub] [kafka] hachikuji commented on a change in pull request #11603: MINOR: MetadataShell should handle ProducerIdsRecord

2022-02-09 Thread GitBox
hachikuji commented on a change in pull request #11603: URL: https://github.com/apache/kafka/pull/11603#discussion_r803244663 ## File path: shell/src/main/java/org/apache/kafka/shell/MetadataNodeManager.java ## @@ -318,6 +320,15 @@ private void

[GitHub] [kafka] vvcephei commented on pull request #11534: KAFKA-12939: After migrating processors, search the codebase for missed migrations

2022-02-09 Thread GitBox
vvcephei commented on pull request #11534: URL: https://github.com/apache/kafka/pull/11534#issuecomment-1034421613 Hey @jeqo , it looks like some of those test failures are related to this PR. I took a look at one of them, and it looks like it's due to us trying to cast the processor

[GitHub] [kafka] hachikuji commented on a change in pull request #11603: MINOR: MetadataShell should handle ProducerIdsRecord

2022-02-09 Thread GitBox
hachikuji commented on a change in pull request #11603: URL: https://github.com/apache/kafka/pull/11603#discussion_r803244663 ## File path: shell/src/main/java/org/apache/kafka/shell/MetadataNodeManager.java ## @@ -318,6 +320,15 @@ private void

[jira] [Commented] (KAFKA-13660) Replace log4j with reload4j

2022-02-09 Thread Dongjin Lee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17489905#comment-17489905 ] Dongjin Lee commented on KAFKA-13660: - Hi [~FireBurn], Thanks for your interest in this issue. I

[GitHub] [kafka] mjsax commented on a change in pull request #11584: MINOR: improve logging

2022-02-09 Thread GitBox
mjsax commented on a change in pull request #11584: URL: https://github.com/apache/kafka/pull/11584#discussion_r803222877 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java ## @@ -1516,4 +1527,20 @@ RebalanceProtocol

[GitHub] [kafka] hachikuji commented on a change in pull request #11655: KAFKA-13316; Enable KRaft mode in CreateTopics tests

2022-02-09 Thread GitBox
hachikuji commented on a change in pull request #11655: URL: https://github.com/apache/kafka/pull/11655#discussion_r802933225 ## File path: core/src/test/scala/unit/kafka/server/CreateTopicsRequestWithPolicyTest.scala ## @@ -55,11 +63,9 @@ class

[GitHub] [kafka] hachikuji commented on a change in pull request #11688: KAFKA-13435; Static membership protocol should let the leader skip assignment (KIP-814)

2022-02-09 Thread GitBox
hachikuji commented on a change in pull request #11688: URL: https://github.com/apache/kafka/pull/11688#discussion_r803165736 ## File path: core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala ## @@ -1791,4 +1793,34 @@ class PlaintextConsumerTest extends

[GitHub] [kafka] hachikuji commented on a change in pull request #11688: KAFKA-13435; Static membership protocol should let the leader skip assignment (KIP-814)

2022-02-09 Thread GitBox
hachikuji commented on a change in pull request #11688: URL: https://github.com/apache/kafka/pull/11688#discussion_r803159171 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java ## @@ -699,11 +702,15 @@ public void

[GitHub] [kafka] hachikuji commented on a change in pull request #11667: MINOR; Enable Kraft in ApiVersionTest

2022-02-09 Thread GitBox
hachikuji commented on a change in pull request #11667: URL: https://github.com/apache/kafka/pull/11667#discussion_r803154384 ## File path: core/src/test/scala/unit/kafka/server/AbstractApiVersionsRequestTest.scala ## @@ -17,35 +17,45 @@ package kafka.server import

[GitHub] [kafka] hachikuji commented on a change in pull request #11667: MINOR; Enable Kraft in ApiVersionTest

2022-02-09 Thread GitBox
hachikuji commented on a change in pull request #11667: URL: https://github.com/apache/kafka/pull/11667#discussion_r803154384 ## File path: core/src/test/scala/unit/kafka/server/AbstractApiVersionsRequestTest.scala ## @@ -17,35 +17,45 @@ package kafka.server import

[GitHub] [kafka] hachikuji opened a new pull request #11745: KAFKA-13661; Consistent permissions for CreatePartitions API

2022-02-09 Thread GitBox
hachikuji opened a new pull request #11745: URL: https://github.com/apache/kafka/pull/11745 In #11649, we fixed one permission inconsistency between kraft and zk authorization for the `CreatePartitions` request. Previously kraft was requireing `CREATE` permission on the `Topic` resource

[jira] [Commented] (KAFKA-13661) KRaft uses the wrong permission for adding topic partitions

2022-02-09 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17489845#comment-17489845 ] Jason Gustafson commented on KAFKA-13661: - Another minor difference in behavior is that KRaft

[GitHub] [kafka] vvcephei commented on a change in pull request #11534: KAFKA-12939: After migrating processors, search the codebase for missed migrations

2022-02-09 Thread GitBox
vvcephei commented on a change in pull request #11534: URL: https://github.com/apache/kafka/pull/11534#discussion_r803128144 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordDeserializer.java ## @@ -70,7 +70,10 @@ } catch (final

[GitHub] [kafka] prince-mahajan commented on a change in pull request #11742: KAFKA-13636: Fix for the group coordinator issue where the offsets are deleted for unstable groups

2022-02-09 Thread GitBox
prince-mahajan commented on a change in pull request #11742: URL: https://github.com/apache/kafka/pull/11742#discussion_r803115724 ## File path: core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataTest.scala ## @@ -259,6 +259,47 @@ class GroupMetadataTest {

[GitHub] [kafka] prince-mahajan commented on a change in pull request #11742: KAFKA-13636: Fix for the group coordinator issue where the offsets are deleted for unstable groups

2022-02-09 Thread GitBox
prince-mahajan commented on a change in pull request #11742: URL: https://github.com/apache/kafka/pull/11742#discussion_r803107096 ## File path: core/src/main/scala/kafka/coordinator/group/GroupMetadata.scala ## @@ -763,7 +763,7 @@ private[group] class GroupMetadata(val

[GitHub] [kafka] jeqo commented on a change in pull request #11534: KAFKA-12939: After migrating processors, search the codebase for missed migrations

2022-02-09 Thread GitBox
jeqo commented on a change in pull request #11534: URL: https://github.com/apache/kafka/pull/11534#discussion_r803098389 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordDeserializer.java ## @@ -70,7 +70,10 @@ } catch (final

[jira] [Created] (KAFKA-13662) Migrate DeserializationExceptionHandler to latest ProcessorContext API

2022-02-09 Thread Jorge Esteban Quilcate Otoya (Jira)
Jorge Esteban Quilcate Otoya created KAFKA-13662: Summary: Migrate DeserializationExceptionHandler to latest ProcessorContext API Key: KAFKA-13662 URL:

[GitHub] [kafka] jeffreyolchovy commented on pull request #719: KAFKA-3049: VerifiableProperties does not respect 'default' properties of underlying java.util.Properties instance

2022-02-09 Thread GitBox
jeffreyolchovy commented on pull request #719: URL: https://github.com/apache/kafka/pull/719#issuecomment-1034179990 @vvcephei The way I read the situation was that the ball was always in the court of the Kafka maintainers, and it sounded like they did not want to go down the approach of

[GitHub] [kafka] vvcephei commented on pull request #11534: KAFKA-12939: After migrating processors, search the codebase for missed migrations

2022-02-09 Thread GitBox
vvcephei commented on pull request #11534: URL: https://github.com/apache/kafka/pull/11534#issuecomment-1034166065 I've just kicked off a fresh CIT run (https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-11534/4/) to be sure this is still mergeable. -- This is an automated

[GitHub] [kafka] vvcephei commented on a change in pull request #11534: KAFKA-12939: After migrating processors, search the codebase for missed migrations

2022-02-09 Thread GitBox
vvcephei commented on a change in pull request #11534: URL: https://github.com/apache/kafka/pull/11534#discussion_r803052837 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordDeserializer.java ## @@ -70,7 +70,10 @@ } catch (final

[jira] [Resolved] (KAFKA-3790) Default options when removing ACLs do not comply with documentation

2022-02-09 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-3790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sébastien Launay resolved KAFKA-3790. - Resolution: Won't Fix > Default options when removing ACLs do not comply with

[jira] [Commented] (KAFKA-3790) Default options when removing ACLs do not comply with documentation

2022-02-09 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-3790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17489798#comment-17489798 ] Sébastien Launay commented on KAFKA-3790: - It's an oldie and since then we have access to the

[GitHub] [kafka] slaunay edited a comment on pull request #1468: KAFKA-3790: Allow for removal of non specific ACLs

2022-02-09 Thread GitBox
slaunay edited a comment on pull request #1468: URL: https://github.com/apache/kafka/pull/1468#issuecomment-1034159058 It's an oldie and since then we have access to the Admin API so I don't think it makes sense anymore to modify such long running behaviour of `kafka-acls`. I will

[jira] [Commented] (KAFKA-12256) auto commit causes delays due to retriable UNKNOWN_TOPIC_OR_PARTITION

2022-02-09 Thread Ryan Leslie (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17489797#comment-17489797 ] Ryan Leslie commented on KAFKA-12256: - [~RivenSun] [~guozhang] Hey guys, I see that

[GitHub] [kafka] slaunay commented on pull request #1468: KAFKA-3790: Allow for removal of non specific ACLs

2022-02-09 Thread GitBox
slaunay commented on pull request #1468: URL: https://github.com/apache/kafka/pull/1468#issuecomment-1034159058 It's an oldie and since then we have access to Admin API so I don't think it makes sense anymore to modify such long running behaviour of `kafka-acls`. I will close the JIRA

[jira] [Commented] (KAFKA-9366) Upgrade log4j to log4j2

2022-02-09 Thread Akansh Shandilya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17489791#comment-17489791 ] Akansh Shandilya commented on KAFKA-9366: - Voting has been done by multiple users, and more are

[jira] [Commented] (KAFKA-12495) Unbalanced connectors/tasks distribution will happen in Connect's incremental cooperative assignor

2022-02-09 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17489790#comment-17489790 ] Chris Egerton commented on KAFKA-12495: --- Hi [~showuon]! I'm taking time off right now but should

[jira] [Assigned] (KAFKA-12495) Unbalanced connectors/tasks distribution will happen in Connect's incremental cooperative assignor

2022-02-09 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton reassigned KAFKA-12495: - Assignee: Chris Egerton (was: Luke Chen) > Unbalanced connectors/tasks distribution

[jira] [Assigned] (KAFKA-12495) Unbalanced connectors/tasks distribution will happen in Connect's incremental cooperative assignor

2022-02-09 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton reassigned KAFKA-12495: - Assignee: Luke Chen (was: Chris Egerton) > Unbalanced connectors/tasks distribution

[GitHub] [kafka] lmr3796 commented on a change in pull request #11744: MINOR: Fix JavaDoc of OffsetIndex#append

2022-02-09 Thread GitBox
lmr3796 commented on a change in pull request #11744: URL: https://github.com/apache/kafka/pull/11744#discussion_r803031914 ## File path: core/src/main/scala/kafka/log/OffsetIndex.scala ## @@ -136,7 +136,7 @@ class OffsetIndex(_file: File, baseOffset: Long, maxIndexSize: Int

[GitHub] [kafka] vvcephei closed pull request #560: KAFKA-2423: Introduce Scalastyle

2022-02-09 Thread GitBox
vvcephei closed pull request #560: URL: https://github.com/apache/kafka/pull/560 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] vvcephei commented on pull request #560: KAFKA-2423: Introduce Scalastyle

2022-02-09 Thread GitBox
vvcephei commented on pull request #560: URL: https://github.com/apache/kafka/pull/560#issuecomment-1034122311 Hi @granthenke , It seems like this PR stalled. I'll close it out for now, but if you or anyone else want to resume this work, please feel free to re-open it (or start a

[GitHub] [kafka] vvcephei closed pull request #200: KAFKA-2512: Add version check to broker and clients.

2022-02-09 Thread GitBox
vvcephei closed pull request #200: URL: https://github.com/apache/kafka/pull/200 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] vvcephei commented on pull request #200: KAFKA-2512: Add version check to broker and clients.

2022-02-09 Thread GitBox
vvcephei commented on pull request #200: URL: https://github.com/apache/kafka/pull/200#issuecomment-1034122122 Hi @becketqin , It seems like this PR stalled. I'll close it out for now, but if you or anyone else want to resume this work, please feel free to re-open it (or start a

[GitHub] [kafka] vvcephei closed pull request #62: add support libvirt as provider. KAFKA-2183

2022-02-09 Thread GitBox
vvcephei closed pull request #62: URL: https://github.com/apache/kafka/pull/62 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] vvcephei commented on pull request #62: add support libvirt as provider. KAFKA-2183

2022-02-09 Thread GitBox
vvcephei commented on pull request #62: URL: https://github.com/apache/kafka/pull/62#issuecomment-1034121935 Hi @pronix , It seems like this PR stalled. I'll close it out for now, but if you or anyone else want to resume this work, please feel free to re-open it (or start a new

[GitHub] [kafka] vvcephei closed pull request #719: KAFKA-3049: VerifiableProperties does not respect 'default' properties of underlying java.util.Properties instance

2022-02-09 Thread GitBox
vvcephei closed pull request #719: URL: https://github.com/apache/kafka/pull/719 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] vvcephei commented on pull request #719: KAFKA-3049: VerifiableProperties does not respect 'default' properties of underlying java.util.Properties instance

2022-02-09 Thread GitBox
vvcephei commented on pull request #719: URL: https://github.com/apache/kafka/pull/719#issuecomment-1034121675 Hi @jeffreyolchovy , It seems like this PR stalled. I'll close it out for now, but if you or anyone else want to resume this work, please feel free to re-open it (or start

[GitHub] [kafka] vvcephei commented on pull request #735: KAFKA-3065: Remove unused topic partitions from RecordAccumulator

2022-02-09 Thread GitBox
vvcephei commented on pull request #735: URL: https://github.com/apache/kafka/pull/735#issuecomment-1034121499 Hi @rajinisivaram , It seems like this PR stalled. I'll close it out for now, but if you or anyone else want to resume this work, please feel free to re-open it (or start

[GitHub] [kafka] vvcephei closed pull request #735: KAFKA-3065: Remove unused topic partitions from RecordAccumulator

2022-02-09 Thread GitBox
vvcephei closed pull request #735: URL: https://github.com/apache/kafka/pull/735 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] vvcephei closed pull request #757: KAFKA-3082: Make LogManager.InitialTaskDelayMs configurable

2022-02-09 Thread GitBox
vvcephei closed pull request #757: URL: https://github.com/apache/kafka/pull/757 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] vvcephei commented on pull request #757: KAFKA-3082: Make LogManager.InitialTaskDelayMs configurable

2022-02-09 Thread GitBox
vvcephei commented on pull request #757: URL: https://github.com/apache/kafka/pull/757#issuecomment-1034121306 Ho @j-nowak , It seems like this PR stalled. I'll close it out for now, but if you or anyone else want to resume this work, please feel free to re-open it (or start a new

[GitHub] [kafka] vvcephei commented on pull request #824: KAFKA-3161: Fixed ProducerConfig/ConsumerConfig so that defaults are used in java.util.Properties

2022-02-09 Thread GitBox
vvcephei commented on pull request #824: URL: https://github.com/apache/kafka/pull/824#issuecomment-1034121012 Hi @crhyne , It seems like this PR stalled. I'll close it out for now, but if you or anyone else want to resume this work, please feel free to re-open it (or start a new

[GitHub] [kafka] vvcephei closed pull request #824: KAFKA-3161: Fixed ProducerConfig/ConsumerConfig so that defaults are used in java.util.Properties

2022-02-09 Thread GitBox
vvcephei closed pull request #824: URL: https://github.com/apache/kafka/pull/824 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] vvcephei commented on pull request #880: KAFKA-3190 Producer should not fire callback in Send() method

2022-02-09 Thread GitBox
vvcephei commented on pull request #880: URL: https://github.com/apache/kafka/pull/880#issuecomment-1034120832 Hi @becketqin , It seems like this PR stalled. I'll close it out for now, but if you or anyone else want to resume this work, please feel free to re-open it (or start a

[GitHub] [kafka] vvcephei closed pull request #880: KAFKA-3190 Producer should not fire callback in Send() method

2022-02-09 Thread GitBox
vvcephei closed pull request #880: URL: https://github.com/apache/kafka/pull/880 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] vvcephei closed pull request #907: KAFKA-3234; Clarify minISR in documentation and auto-generate topic configuration docs

2022-02-09 Thread GitBox
vvcephei closed pull request #907: URL: https://github.com/apache/kafka/pull/907 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] vvcephei commented on pull request #907: KAFKA-3234; Clarify minISR in documentation and auto-generate topic configuration docs

2022-02-09 Thread GitBox
vvcephei commented on pull request #907: URL: https://github.com/apache/kafka/pull/907#issuecomment-1034120532 Hi @jjkoshy , It seems like this PR stalled. I'll close it out for now, but if you or anyone else want to resume this work, please feel free to re-open it (or start a new

[GitHub] [kafka] vvcephei closed pull request #1035: KAFKA-3359 Parallel log-recovery of un-flushed segments on startup

2022-02-09 Thread GitBox
vvcephei closed pull request #1035: URL: https://github.com/apache/kafka/pull/1035 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] vvcephei closed pull request #983: KAFKA-3300: Avoid over allocating disk space and memory for index files.

2022-02-09 Thread GitBox
vvcephei closed pull request #983: URL: https://github.com/apache/kafka/pull/983 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] vvcephei commented on pull request #983: KAFKA-3300: Avoid over allocating disk space and memory for index files.

2022-02-09 Thread GitBox
vvcephei commented on pull request #983: URL: https://github.com/apache/kafka/pull/983#issuecomment-1034120088 Hi @becketqin , It seems like this PR stalled. I'll close it out for now, but if you or anyone else want to resume this work, please feel free to re-open it (or start a

[GitHub] [kafka] vvcephei commented on pull request #1035: KAFKA-3359 Parallel log-recovery of un-flushed segments on startup

2022-02-09 Thread GitBox
vvcephei commented on pull request #1035: URL: https://github.com/apache/kafka/pull/1035#issuecomment-1034119827 Hello, It seems like this PR stalled. I'll close it out for now, but if you or anyone else want to resume this work, please feel free to re-open it (or start a new one)!

[GitHub] [kafka] vvcephei commented on pull request #1078: Fixes for Windows #154

2022-02-09 Thread GitBox
vvcephei commented on pull request #1078: URL: https://github.com/apache/kafka/pull/1078#issuecomment-1034119371 Hi @JeffersJi , It seems like this PR stalled. I'll close it out for now, but if you or anyone else want to resume this work, please feel free to re-open it (or start a

[GitHub] [kafka] vvcephei closed pull request #1078: Fixes for Windows #154

2022-02-09 Thread GitBox
vvcephei closed pull request #1078: URL: https://github.com/apache/kafka/pull/1078 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] vvcephei commented on pull request #1111: KAFKA-3428 Remove metadata sync bottleneck from mirrormaker's producer

2022-02-09 Thread GitBox
vvcephei commented on pull request #: URL: https://github.com/apache/kafka/pull/#issuecomment-1034119203 Hi @maysamyabandeh , It seems like this PR stalled. I'll close it out for now, but if you or anyone else want to resume this work, please feel free to re-open it (or

[GitHub] [kafka] vvcephei closed pull request #1135: [KAFKA-3458] Selector should throw InterruptException when interrupted.

2022-02-09 Thread GitBox
vvcephei closed pull request #1135: URL: https://github.com/apache/kafka/pull/1135 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] vvcephei commented on pull request #1147: [KAFKA-3472] Allow MirrorMaker to copy selected partitions and choose target topic name

2022-02-09 Thread GitBox
vvcephei commented on pull request #1147: URL: https://github.com/apache/kafka/pull/1147#issuecomment-1034118707 Hi @ooasis , It seems like this PR stalled. I'll close it out for now, but if you or anyone else want to resume this work, please feel free to re-open it (or start a new

[GitHub] [kafka] vvcephei closed pull request #1111: KAFKA-3428 Remove metadata sync bottleneck from mirrormaker's producer

2022-02-09 Thread GitBox
vvcephei closed pull request #: URL: https://github.com/apache/kafka/pull/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] vvcephei commented on pull request #1135: [KAFKA-3458] Selector should throw InterruptException when interrupted.

2022-02-09 Thread GitBox
vvcephei commented on pull request #1135: URL: https://github.com/apache/kafka/pull/1135#issuecomment-1034118967 Hi @sruehl , It seems like this PR stalled. I'll close it out for now, but if you or anyone else want to resume this work, please feel free to re-open it (or start a new

[GitHub] [kafka] vvcephei closed pull request #1147: [KAFKA-3472] Allow MirrorMaker to copy selected partitions and choose target topic name

2022-02-09 Thread GitBox
vvcephei closed pull request #1147: URL: https://github.com/apache/kafka/pull/1147 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] lmr3796 commented on a change in pull request #11744: MINOR: Fix JavaDoc of OffsetIndex#append

2022-02-09 Thread GitBox
lmr3796 commented on a change in pull request #11744: URL: https://github.com/apache/kafka/pull/11744#discussion_r803018010 ## File path: core/src/main/scala/kafka/log/OffsetIndex.scala ## @@ -136,7 +136,7 @@ class OffsetIndex(_file: File, baseOffset: Long, maxIndexSize: Int

[GitHub] [kafka] vvcephei closed pull request #1150: KAFKA-3474: add metrics to track replica fetcher timeouts

2022-02-09 Thread GitBox
vvcephei closed pull request #1150: URL: https://github.com/apache/kafka/pull/1150 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] vvcephei commented on pull request #1150: KAFKA-3474: add metrics to track replica fetcher timeouts

2022-02-09 Thread GitBox
vvcephei commented on pull request #1150: URL: https://github.com/apache/kafka/pull/1150#issuecomment-1034118461 Hi @junrao , It seems like this PR stalled. I'll close it out for now, but if you or anyone else want to resume this work, please feel free to re-open it (or start a new

[GitHub] [kafka] vvcephei closed pull request #1244: MINOR: Docs for ACLs over SSL auth and KAFKA_OPTS

2022-02-09 Thread GitBox
vvcephei closed pull request #1244: URL: https://github.com/apache/kafka/pull/1244 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] vvcephei commented on pull request #1244: MINOR: Docs for ACLs over SSL auth and KAFKA_OPTS

2022-02-09 Thread GitBox
vvcephei commented on pull request #1244: URL: https://github.com/apache/kafka/pull/1244#issuecomment-1034118238 Hi @QwertyManiac , It seems like this PR stalled. I'll close it out for now, but if you or anyone else want to resume this work, please feel free to re-open it (or start

[GitHub] [kafka] vvcephei closed pull request #1269: KAFKA-3622: Use descriptive error message if port number is missing from url

2022-02-09 Thread GitBox
vvcephei closed pull request #1269: URL: https://github.com/apache/kafka/pull/1269 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] vvcephei commented on pull request #1269: KAFKA-3622: Use descriptive error message if port number is missing from url

2022-02-09 Thread GitBox
vvcephei commented on pull request #1269: URL: https://github.com/apache/kafka/pull/1269#issuecomment-1034118007 Hi @peterableda , It seems like this PR stalled. I'll close it out for now, but if you or anyone else want to resume this work, please feel free to re-open it (or start

[GitHub] [kafka] vvcephei commented on pull request #1415: KAFKA-3737: Change log level for error during produce request

2022-02-09 Thread GitBox
vvcephei commented on pull request #1415: URL: https://github.com/apache/kafka/pull/1415#issuecomment-1034117748 Hi @fhussonnois , It seems like this PR stalled. I'll close it out for now, but if you or anyone else want to resume this work, please feel free to re-open it (or start

[GitHub] [kafka] vvcephei closed pull request #1415: KAFKA-3737: Change log level for error during produce request

2022-02-09 Thread GitBox
vvcephei closed pull request #1415: URL: https://github.com/apache/kafka/pull/1415 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] vvcephei commented on pull request #1468: KAFKA-3790: Allow for removal of non specific ACLs

2022-02-09 Thread GitBox
vvcephei commented on pull request #1468: URL: https://github.com/apache/kafka/pull/1468#issuecomment-1034117452 Hi @slaunay , It seems like this PR stalled. I'll close it out for now, but if you or anyone else want to resume this work, please feel free to re-open it (or start a

[GitHub] [kafka] vvcephei closed pull request #1468: KAFKA-3790: Allow for removal of non specific ACLs

2022-02-09 Thread GitBox
vvcephei closed pull request #1468: URL: https://github.com/apache/kafka/pull/1468 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] lmr3796 closed pull request #11744: MINOR: Fix JavaDoc of OffsetIndex#append

2022-02-09 Thread GitBox
lmr3796 closed pull request #11744: URL: https://github.com/apache/kafka/pull/11744 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] mimaison commented on pull request #11731: KAFKA-13293: Reloading SSL Engine Factory

2022-02-09 Thread GitBox
mimaison commented on pull request #11731: URL: https://github.com/apache/kafka/pull/11731#issuecomment-1034113905 Thanks @teabot for the contribution! This PR adds new configurations and these are considered public API. So in order to accept this change we need a [Kafka Improvement

[GitHub] [kafka] mimaison commented on a change in pull request #11744: MINOR: Fix JavaDoc of OffsetIndex#append

2022-02-09 Thread GitBox
mimaison commented on a change in pull request #11744: URL: https://github.com/apache/kafka/pull/11744#discussion_r803007182 ## File path: core/src/main/scala/kafka/log/OffsetIndex.scala ## @@ -136,7 +136,7 @@ class OffsetIndex(_file: File, baseOffset: Long, maxIndexSize: Int

[GitHub] [kafka] mimaison commented on a change in pull request #11673: KAFKA-13577: Replace easymock with mockito in kafka:core - part 2

2022-02-09 Thread GitBox
mimaison commented on a change in pull request #11673: URL: https://github.com/apache/kafka/pull/11673#discussion_r802994307 ## File path: core/src/test/scala/unit/kafka/server/ReplicaManagerQuotasTest.scala ## @@ -157,10 +158,9 @@ class ReplicaManagerQuotasTest { def

[jira] [Commented] (KAFKA-13422) Even if the correct username and password are configured, when ClientBroker or KafkaClient tries to establish a SASL connection to ServerBroker, an exception is thrown

2022-02-09 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17489744#comment-17489744 ] Guozhang Wang commented on KAFKA-13422: --- I'm unfortunately less familiar with security.auth

[jira] [Commented] (KAFKA-13638) Slow KTable update when forwarding multiple values from transformer

2022-02-09 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17489741#comment-17489741 ] Bruno Cadonna commented on KAFKA-13638: --- [~Lejon] Could you try to use another state store

[jira] [Resolved] (KAFKA-13646) Implement KIP-801: KRaft authorizer

2022-02-09 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-13646. - Fix Version/s: 3.2.0 Resolution: Fixed > Implement KIP-801: KRaft authorizer >

[GitHub] [kafka] hachikuji merged pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-09 Thread GitBox
hachikuji merged pull request #11649: URL: https://github.com/apache/kafka/pull/11649 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] tombentley commented on a change in pull request #11673: KAFKA-13577: Replace easymock with mockito in kafka:core - part 2

2022-02-09 Thread GitBox
tombentley commented on a change in pull request #11673: URL: https://github.com/apache/kafka/pull/11673#discussion_r802922650 ## File path: core/src/test/scala/unit/kafka/server/ReplicaManagerQuotasTest.scala ## @@ -157,10 +158,9 @@ class ReplicaManagerQuotasTest { def

[jira] [Commented] (KAFKA-7500) MirrorMaker 2.0 (KIP-382)

2022-02-09 Thread Guram Savinov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17489723#comment-17489723 ] Guram Savinov commented on KAFKA-7500: -- Please update KIP-382 documentation:

[jira] [Created] (KAFKA-13661) KRaft uses the wrong permission for creating partitions

2022-02-09 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-13661: --- Summary: KRaft uses the wrong permission for creating partitions Key: KAFKA-13661 URL: https://issues.apache.org/jira/browse/KAFKA-13661 Project: Kafka

[jira] [Updated] (KAFKA-13661) KRaft uses the wrong permission for adding topic partitions

2022-02-09 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-13661: Summary: KRaft uses the wrong permission for adding topic partitions (was: KRaft uses

[jira] [Commented] (KAFKA-12468) Initial offsets are copied from source to target cluster

2022-02-09 Thread Guram Savinov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17489716#comment-17489716 ] Guram Savinov commented on KAFKA-12468: --- [~bdeneuter] there is IdentityReplicationPolicy which can

[jira] [Updated] (KAFKA-13517) Add ConfigurationKeys to ConfigResource class

2022-02-09 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-13517: --- Fix Version/s: (was: 2.8.1) > Add ConfigurationKeys to ConfigResource class >

[jira] [Updated] (KAFKA-13242) KRaft Controller doesn't handle UpdateFeaturesRequest

2022-02-09 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-13242: --- Fix Version/s: (was: 3.0.1) > KRaft Controller doesn't handle UpdateFeaturesRequest >

[jira] [Updated] (KAFKA-13228) ApiVersionRequest are not correctly handled in kraft mode

2022-02-09 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-13228: --- Fix Version/s: (was: 3.0.1) > ApiVersionRequest are not correctly handled in kraft mode

[jira] [Updated] (KAFKA-13188) Release the memory back into MemoryPool

2022-02-09 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-13188: --- Fix Version/s: (was: 3.0.1) > Release the memory back into MemoryPool >

  1   2   >