[jira] [Updated] (KAFKA-13692) stream thread blocked-time-ns-total metric does not include producer metadata wait time

2022-02-24 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-13692: -- Fix Version/s: 3.2.0 (was: 3.3.0) > stream thread

[jira] [Updated] (KAFKA-13692) stream thread blocked-time-ns-total metric does not include producer metadata wait time

2022-02-24 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-13692: -- Affects Version/s: 3.1.0 (was: 3.2.0) > stream thread

[GitHub] [kafka] cadonna commented on pull request #11805: KAFKA-13692: include metadata wait time in total blocked time

2022-02-24 Thread GitBox
cadonna commented on pull request #11805: URL: https://github.com/apache/kafka/pull/11805#issuecomment-1050598953 @rodesai Some failures seem related. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] RivenSun2 commented on pull request #11800: KAFKA-13689: Optimized the printing of AbstractConfig logs, and stripped unknownKeys from unusedKeys

2022-02-24 Thread GitBox
RivenSun2 commented on pull request #11800: URL: https://github.com/apache/kafka/pull/11800#issuecomment-1050597788 Hi @showuon Thank you for your reply. In fact, in the AbstractConfigTest class, I have asserted `unknown()` after `config.valuesWithPrefixOverride(prefix)`.

[GitHub] [kafka] showuon commented on a change in pull request #11800: KAFKA-13689: Optimized the printing of AbstractConfig logs, and stripped unknownKeys from unusedKeys

2022-02-24 Thread GitBox
showuon commented on a change in pull request #11800: URL: https://github.com/apache/kafka/pull/11800#discussion_r814517759 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java ## @@ -2849,6 +2850,45 @@ public void testUnusedConfigs() {

[jira] [Commented] (KAFKA-13694) Some InvalidRecordException messages are thrown away

2022-02-24 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497941#comment-17497941 ] RivenSun commented on KAFKA-13694: -- And another question, for the class in the generated directory, do

[jira] [Commented] (KAFKA-13694) Some InvalidRecordException messages are thrown away

2022-02-24 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497940#comment-17497940 ] RivenSun commented on KAFKA-13694: -- Hi [~showuon]  , [~guozhang]  Could you give any suggestions?

[jira] [Created] (KAFKA-13694) Some InvalidRecordException messages are thrown away

2022-02-24 Thread RivenSun (Jira)
RivenSun created KAFKA-13694: Summary: Some InvalidRecordException messages are thrown away Key: KAFKA-13694 URL: https://issues.apache.org/jira/browse/KAFKA-13694 Project: Kafka Issue Type:

[jira] [Commented] (KAFKA-13678) 2nd punctuation using STREAM_TIME does not respect scheduled interval

2022-02-24 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497935#comment-17497935 ] Matthias J. Sax commented on KAFKA-13678: - We believe it's important for the data re-processing

[jira] [Commented] (KAFKA-4212) Add a key-value store that is a TTL persistent cache

2022-02-24 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497934#comment-17497934 ] Matthias J. Sax commented on KAFKA-4212: A windowed-store is basically just a `` kv-store and it

[GitHub] [kafka] hachikuji commented on pull request #11733: KAFKA-13587; Implement leader recovery for KIP-704

2022-02-24 Thread GitBox
hachikuji commented on pull request #11733: URL: https://github.com/apache/kafka/pull/11733#issuecomment-1050566273 For this [comment](https://github.com/apache/kafka/pull/11733#discussion_r812044247): > If the version is `0` then this is guaranteed to be the default value `0` so

[jira] [Commented] (KAFKA-13693) Config in memory got inconsistency value

2022-02-24 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497928#comment-17497928 ] Luke Chen commented on KAFKA-13693: --- [~eaiqzha] , thanks for reporting the issue. Do you know how to

[GitHub] [kafka] hachikuji commented on pull request #11733: KAFKA-13587; Implement leader recovery for KIP-704

2022-02-24 Thread GitBox
hachikuji commented on pull request #11733: URL: https://github.com/apache/kafka/pull/11733#issuecomment-1050557349 In regard to this [comment](https://github.com/apache/kafka/pull/11733#discussion_r814422959): > Unclean leader election is not possible when there is only one replica

[GitHub] [kafka] showuon commented on a change in pull request #11777: KAFKA-10000: Add producer fencing API to admin client (KIP-618)

2022-02-24 Thread GitBox
showuon commented on a change in pull request #11777: URL: https://github.com/apache/kafka/pull/11777#discussion_r814498530 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/FenceProducersHandler.java ## @@ -0,0 +1,146 @@ +/* + * Licensed to the

[GitHub] [kafka] showuon commented on a change in pull request #11777: KAFKA-10000: Add producer fencing API to admin client (KIP-618)

2022-02-24 Thread GitBox
showuon commented on a change in pull request #11777: URL: https://github.com/apache/kafka/pull/11777#discussion_r814498530 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/FenceProducersHandler.java ## @@ -0,0 +1,146 @@ +/* + * Licensed to the

[GitHub] [kafka] C0urante commented on pull request #11777: KAFKA-10000: Add producer fencing API to admin client (KIP-618)

2022-02-24 Thread GitBox
C0urante commented on pull request #11777: URL: https://github.com/apache/kafka/pull/11777#issuecomment-1050532563 Thanks @showuon, appreciate it. I've addressed three of your comments and left a question about the remaining one. -- This is an automated message from the Apache Git

[GitHub] [kafka] C0urante commented on a change in pull request #11777: KAFKA-10000: Add producer fencing API to admin client (KIP-618)

2022-02-24 Thread GitBox
C0urante commented on a change in pull request #11777: URL: https://github.com/apache/kafka/pull/11777#discussion_r814480835 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/FenceProducersHandler.java ## @@ -0,0 +1,146 @@ +/* + * Licensed to the

[GitHub] [kafka] C0urante commented on a change in pull request #11777: KAFKA-10000: Add producer fencing API to admin client (KIP-618)

2022-02-24 Thread GitBox
C0urante commented on a change in pull request #11777: URL: https://github.com/apache/kafka/pull/11777#discussion_r814478255 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/FenceProducersHandler.java ## @@ -0,0 +1,146 @@ +/* + * Licensed to the

[GitHub] [kafka] C0urante commented on a change in pull request #11572: KAFKA-13510: Connect APIs to list all connector plugins and retrieve …

2022-02-24 Thread GitBox
C0urante commented on a change in pull request #11572: URL: https://github.com/apache/kafka/pull/11572#discussion_r814472999 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java ## @@ -750,4 +751,38 @@ private String trace(Throwable

[GitHub] [kafka] C0urante commented on a change in pull request #11572: KAFKA-13510: Connect APIs to list all connector plugins and retrieve …

2022-02-24 Thread GitBox
C0urante commented on a change in pull request #11572: URL: https://github.com/apache/kafka/pull/11572#discussion_r814469917 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/resources/ConnectorPluginsResource.java ## @@ -56,16 +69,49 @@

[GitHub] [kafka] C0urante commented on a change in pull request #11572: KAFKA-13510: Connect APIs to list all connector plugins and retrieve …

2022-02-24 Thread GitBox
C0urante commented on a change in pull request #11572: URL: https://github.com/apache/kafka/pull/11572#discussion_r814469917 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/resources/ConnectorPluginsResource.java ## @@ -56,16 +69,49 @@

[GitHub] [kafka] C0urante commented on a change in pull request #11572: KAFKA-13510: Connect APIs to list all connector plugins and retrieve …

2022-02-24 Thread GitBox
C0urante commented on a change in pull request #11572: URL: https://github.com/apache/kafka/pull/11572#discussion_r814469917 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/resources/ConnectorPluginsResource.java ## @@ -56,16 +69,49 @@

[GitHub] [kafka] C0urante commented on a change in pull request #11572: KAFKA-13510: Connect APIs to list all connector plugins and retrieve …

2022-02-24 Thread GitBox
C0urante commented on a change in pull request #11572: URL: https://github.com/apache/kafka/pull/11572#discussion_r814475362 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/Plugins.java ## @@ -168,6 +173,44 @@ public Connector

[GitHub] [kafka] C0urante commented on a change in pull request #11572: KAFKA-13510: Connect APIs to list all connector plugins and retrieve …

2022-02-24 Thread GitBox
C0urante commented on a change in pull request #11572: URL: https://github.com/apache/kafka/pull/11572#discussion_r814358703 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/Plugins.java ## @@ -168,6 +173,44 @@ public Connector

[GitHub] [kafka] RivenSun2 commented on a change in pull request #11800: KAFKA-13689: Optimized the printing of AbstractConfig logs, and stripped unknownKeys from unusedKeys

2022-02-24 Thread GitBox
RivenSun2 commented on a change in pull request #11800: URL: https://github.com/apache/kafka/pull/11800#discussion_r814473563 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java ## @@ -2866,6 +2866,25 @@ public void

[GitHub] [kafka] showuon commented on a change in pull request #11777: KAFKA-10000: Add producer fencing API to admin client (KIP-618)

2022-02-24 Thread GitBox
showuon commented on a change in pull request #11777: URL: https://github.com/apache/kafka/pull/11777#discussion_r814452150 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/AdminApiHandler.java ## @@ -122,4 +126,54 @@ public ApiResult( }

[jira] [Created] (KAFKA-13693) Config in memory got inconsistency value

2022-02-24 Thread Aiqin Zhang (Jira)
Aiqin Zhang created KAFKA-13693: --- Summary: Config in memory got inconsistency value Key: KAFKA-13693 URL: https://issues.apache.org/jira/browse/KAFKA-13693 Project: Kafka Issue Type: Bug

[GitHub] [kafka] showuon commented on pull request #11788: KAFKA-13673: disable idempotence when config conflicts

2022-02-24 Thread GitBox
showuon commented on pull request #11788: URL: https://github.com/apache/kafka/pull/11788#issuecomment-1050477547 @ijuma , please take a look again when available. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Created] (KAFKA-13692) stream thread blocked-time-ns-total metric does not include producer metadata wait time

2022-02-24 Thread Rohan Desai (Jira)
Rohan Desai created KAFKA-13692: --- Summary: stream thread blocked-time-ns-total metric does not include producer metadata wait time Key: KAFKA-13692 URL: https://issues.apache.org/jira/browse/KAFKA-13692

[GitHub] [kafka] rodesai opened a new pull request #11805: KAFKA-13692: include metadata wait time in total blocked time

2022-02-24 Thread GitBox
rodesai opened a new pull request #11805: URL: https://github.com/apache/kafka/pull/11805 This patch includes metadata wait time in total blocked time. First, this patch adds a new metric for total producer time spent waiting on metadata, called metadata-wait-time-ms-total. Then,

[GitHub] [kafka] showuon commented on pull request #11433: KAFKA-13295: Avoiding Transation timeouts arising due to long restora…

2022-02-24 Thread GitBox
showuon commented on pull request #11433: URL: https://github.com/apache/kafka/pull/11433#issuecomment-1050463207 Sorry, I'll review the PR to upgrade to log4j 2 first. That has higher priority. I'll check your PR after that. Thanks. -- This is an automated message from the Apache Git

[GitHub] [kafka] showuon commented on a change in pull request #11800: KAFKA-13689: Optimized the printing of AbstractConfig logs, and stripped unknownKeys from unusedKeys

2022-02-24 Thread GitBox
showuon commented on a change in pull request #11800: URL: https://github.com/apache/kafka/pull/11800#discussion_r814419358 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java ## @@ -2866,6 +2866,25 @@ public void testUnknownConfigs()

[GitHub] [kafka] jsancio commented on a change in pull request #11733: KAFKA-13587; Implement leader recovery for KIP-704

2022-02-24 Thread GitBox
jsancio commented on a change in pull request #11733: URL: https://github.com/apache/kafka/pull/11733#discussion_r814424904 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -1080,6 +1092,9 @@ class Partition(val topicPartition: TopicPartition, //

[GitHub] [kafka] jsancio commented on a change in pull request #11733: KAFKA-13587; Implement leader recovery for KIP-704

2022-02-24 Thread GitBox
jsancio commented on a change in pull request #11733: URL: https://github.com/apache/kafka/pull/11733#discussion_r814423091 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -542,7 +551,8 @@ class Partition(val topicPartition: TopicPartition,

[GitHub] [kafka] jsancio commented on a change in pull request #11733: KAFKA-13587; Implement leader recovery for KIP-704

2022-02-24 Thread GitBox
jsancio commented on a change in pull request #11733: URL: https://github.com/apache/kafka/pull/11733#discussion_r814422959 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -542,7 +551,8 @@ class Partition(val topicPartition: TopicPartition,

[GitHub] [kafka] jsancio commented on a change in pull request #11733: KAFKA-13587; Implement leader recovery for KIP-704

2022-02-24 Thread GitBox
jsancio commented on a change in pull request #11733: URL: https://github.com/apache/kafka/pull/11733#discussion_r814407849 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -760,44 +719,132 @@ BrokersToIsrs brokersToIsrs()

[GitHub] [kafka] lihaosky commented on pull request #11804: KAFKA-13542: add rebalance reason in Kafka Streams

2022-02-24 Thread GitBox
lihaosky commented on pull request #11804: URL: https://github.com/apache/kafka/pull/11804#issuecomment-1050410142 Hi @ableegoldman , can you take a look at this easy one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Assigned] (KAFKA-13542) Utilize the new Consumer#enforceRebalance(reason) API in Streams

2022-02-24 Thread Hao Li (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hao Li reassigned KAFKA-13542: -- Assignee: Hao Li > Utilize the new Consumer#enforceRebalance(reason) API in Streams >

[GitHub] [kafka] ecararus commented on pull request #11803: KAFKA-13691: Rename target topic to custom name

2022-02-24 Thread GitBox
ecararus commented on pull request #11803: URL: https://github.com/apache/kafka/pull/11803#issuecomment-1050407569 When I use mirrormaker it replicates the topics with different name, name of target is built based on sourceClusterAlias + separator + topic

[GitHub] [kafka] lihaosky opened a new pull request #11804: KAFKA-13542: add rebalance reason in Kafka Streams

2022-02-24 Thread GitBox
lihaosky opened a new pull request #11804: URL: https://github.com/apache/kafka/pull/11804 Add rebalance reason in Kafka Streams. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [

[GitHub] [kafka] ecararus opened a new pull request #11803: KAFKA-13691: Rename target topic to custom name

2022-02-24 Thread GitBox
ecararus opened a new pull request #11803: URL: https://github.com/apache/kafka/pull/11803 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

[GitHub] [kafka] guozhangwang commented on pull request #11802: [RFC][DO NOT MERGE]add new RocksDBTimeOrderedWindowStore

2022-02-24 Thread GitBox
guozhangwang commented on pull request #11802: URL: https://github.com/apache/kafka/pull/11802#issuecomment-1050395787 Also ping @vvcephei @mjsax to take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] ableegoldman merged pull request #11801: KAFKA-12738: send LeaveGroup request when thread dies to optimize replacement time

2022-02-24 Thread GitBox
ableegoldman merged pull request #11801: URL: https://github.com/apache/kafka/pull/11801 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] ableegoldman commented on pull request #11801: KAFKA-12738: send LeaveGroup request when thread dies to optimize replacement time

2022-02-24 Thread GitBox
ableegoldman commented on pull request #11801: URL: https://github.com/apache/kafka/pull/11801#issuecomment-1050377863 Test failures are unrelated

[GitHub] [kafka] rhauch commented on a change in pull request #11797: KAFKA-12879: Revert changes from KAFKA-12339 and instead add retry capability to KafkaBasedLog

2022-02-24 Thread GitBox
rhauch commented on a change in pull request #11797: URL: https://github.com/apache/kafka/pull/11797#discussion_r814336427 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/util/TopicAdmin.java ## @@ -703,6 +706,20 @@ public Config

[jira] [Created] (KAFKA-13691) Rename target topic to custom name.

2022-02-24 Thread Eugeniu Cararus (Jira)
Eugeniu Cararus created KAFKA-13691: --- Summary: Rename target topic to custom name. Key: KAFKA-13691 URL: https://issues.apache.org/jira/browse/KAFKA-13691 Project: Kafka Issue Type:

[jira] [Commented] (KAFKA-9376) Plugin class loader not found using MM2

2022-02-24 Thread Eugeniu Cararus (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497768#comment-17497768 ] Eugeniu Cararus commented on KAFKA-9376: Same issue here, manage to solve the issue by loading

[GitHub] [kafka] lihaosky opened a new pull request #11802: [RFC][DO NOT MERGE]add new RocksDBTimeOrderedWindowStore

2022-02-24 Thread GitBox
lihaosky opened a new pull request #11802: URL: https://github.com/apache/kafka/pull/11802 Initial State store implementation for `TimedWindow` and `SlidingWindow`. Changelog restoration and unit tests will be implemented later if direction looks good.

[jira] [Commented] (KAFKA-13461) KafkaController stops functioning as active controller after ZooKeeperClient auth failure

2022-02-24 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497763#comment-17497763 ] Jun Rao commented on KAFKA-13461: - Basically, when there is no JAAS configured for ZK client and the ZK

[GitHub] [kafka] junrao commented on pull request #11476: KAFKA-13407: Always start controller when broker wins election

2022-02-24 Thread GitBox
junrao commented on pull request #11476: URL: https://github.com/apache/kafka/pull/11476#issuecomment-1050314771 @edoardocomar : Thanks for the PR. As I mentioned in the jira, I believe this issue is fixed by https://issues.apache.org/jira/browse/KAFKA-13461 -- This is an automated

[jira] [Resolved] (KAFKA-13407) Kafka controller out of service after ZK leader restart

2022-02-24 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-13407. - Resolution: Fixed > Kafka controller out of service after ZK leader restart >

[jira] [Commented] (KAFKA-13407) Kafka controller out of service after ZK leader restart

2022-02-24 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497760#comment-17497760 ] Jun Rao commented on KAFKA-13407: - [~Olsson] : Thanks for the reply. I think we fixed this issue in

[GitHub] [kafka] hachikuji commented on a change in pull request #11733: KAFKA-13587; Implement leader recovery for KIP-704

2022-02-24 Thread GitBox
hachikuji commented on a change in pull request #11733: URL: https://github.com/apache/kafka/pull/11733#discussion_r814304074 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -760,44 +719,132 @@ BrokersToIsrs

[GitHub] [kafka] ableegoldman opened a new pull request #11801: KAFKA-12738: send LeaveGroup request when thread dies to optimize replacement time

2022-02-24 Thread GitBox
ableegoldman opened a new pull request #11801: URL: https://github.com/apache/kafka/pull/11801 Quick followup to #11787 to optimize the impact of the task backoff by reducing the time to replace a thread. I noticed it would take around the `session.timeout` for the new thread to come up

[GitHub] [kafka] junrao merged pull request #11793: MINOR: Skip fsync on parent directory to start Kafka on ZOS

2022-02-24 Thread GitBox
junrao merged pull request #11793: URL: https://github.com/apache/kafka/pull/11793 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] bbejeck commented on pull request #7082: KAFKA-8659: SetSchemaMetadata SMT fails on records with null value and schema

2022-02-24 Thread GitBox
bbejeck commented on pull request #7082: URL: https://github.com/apache/kafka/pull/7082#issuecomment-1050262085 @bfncs sorry to ask this, but I just noticed the date of the last commit - do you mind doing a rebase? Apologies again for not noticing before -- This is an automated message

[GitHub] [kafka] bbejeck commented on pull request #7082: KAFKA-8659: SetSchemaMetadata SMT fails on records with null value and schema

2022-02-24 Thread GitBox
bbejeck commented on pull request #7082: URL: https://github.com/apache/kafka/pull/7082#issuecomment-1050256311 > It would be nice to finally have this merged. Is there anything I could do to help? @bfncs kicked off the build again if we get green test runs I think we can merge

[jira] [Commented] (KAFKA-13690) Flaky test EosIntegrationTest.shouldWriteLatestOffsetsToCheckpointOnShutdown[at_least_once]

2022-02-24 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497725#comment-17497725 ] Guozhang Wang commented on KAFKA-13690: --- I'll see if I can find a quick fix for this flakiness. >

[jira] [Commented] (KAFKA-13690) Flaky test EosIntegrationTest.shouldWriteLatestOffsetsToCheckpointOnShutdown[at_least_once]

2022-02-24 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497723#comment-17497723 ] Guozhang Wang commented on KAFKA-13690: --- I took a quick look at

[GitHub] [kafka] ableegoldman merged pull request #11787: KAFKA-12738: track processing errors and implement constant-time task backoff

2022-02-24 Thread GitBox
ableegoldman merged pull request #11787: URL: https://github.com/apache/kafka/pull/11787 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] ableegoldman commented on pull request #11787: KAFKA-12738: tracking task errors

2022-02-24 Thread GitBox
ableegoldman commented on pull request #11787: URL: https://github.com/apache/kafka/pull/11787#issuecomment-1050219306 Test failures are unrelated (filed https://issues.apache.org/jira/browse/KAFKA-13690) Merging to trunk, but will do an immediate followup PR to: 1. delete

[jira] [Created] (KAFKA-13690) Flaky test EosIntegrationTest.shouldWriteLatestOffsetsToCheckpointOnShutdown[at_least_once]

2022-02-24 Thread A. Sophie Blee-Goldman (Jira)
A. Sophie Blee-Goldman created KAFKA-13690: -- Summary: Flaky test EosIntegrationTest.shouldWriteLatestOffsetsToCheckpointOnShutdown[at_least_once] Key: KAFKA-13690 URL:

[GitHub] [kafka] guozhangwang commented on a change in pull request #11787: KAFKA-12738: tracking task errors

2022-02-24 Thread GitBox
guozhangwang commented on a change in pull request #11787: URL: https://github.com/apache/kafka/pull/11787#discussion_r814202232 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskExecutionMetadata.java ## @@ -0,0 +1,98 @@ +/* + * Licensed to

[GitHub] [kafka] satishd commented on a change in pull request #11390: [KAFKA-13369] Follower fetch protocol changes for tiered storage.

2022-02-24 Thread GitBox
satishd commented on a change in pull request #11390: URL: https://github.com/apache/kafka/pull/11390#discussion_r814127632 ## File path: core/src/main/scala/kafka/log/remote/RemoteIndexCache.scala ## @@ -0,0 +1,223 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[jira] [Assigned] (KAFKA-12639) AbstractCoordinator ignores backoff timeout when joining the consumer group

2022-02-24 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-12639: - Assignee: Philip Nee > AbstractCoordinator ignores backoff timeout when joining the consumer

[jira] [Updated] (KAFKA-12639) AbstractCoordinator ignores backoff timeout when joining the consumer group

2022-02-24 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-12639: -- Component/s: clients > AbstractCoordinator ignores backoff timeout when joining the consumer group >

[GitHub] [kafka] jsancio commented on a change in pull request #11733: KAFKA-13587; Implement leader recovery for KIP-704

2022-02-24 Thread GitBox
jsancio commented on a change in pull request #11733: URL: https://github.com/apache/kafka/pull/11733#discussion_r814089014 ## File path: clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java ## @@ -110,6 +110,14 @@

[GitHub] [kafka] bfncs commented on pull request #7082: KAFKA-8659: SetSchemaMetadata SMT fails on records with null value and schema

2022-02-24 Thread GitBox
bfncs commented on pull request #7082: URL: https://github.com/apache/kafka/pull/7082#issuecomment-1050058139 It would be nice to finally have this merged. Is there anything I could do to help? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] lkokhreidze commented on pull request #10851: KAFKA-6718 / Rack aware standby task assignor

2022-02-24 Thread GitBox
lkokhreidze commented on pull request #10851: URL: https://github.com/apache/kafka/pull/10851#issuecomment-1050043629 Hi @cadonna Mind having another look? Hoping to finalise this PR as soon as possible :) Thanks -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] satishd commented on a change in pull request #11390: [KAFKA-13369] Follower fetch protocol changes for tiered storage.

2022-02-24 Thread GitBox
satishd commented on a change in pull request #11390: URL: https://github.com/apache/kafka/pull/11390#discussion_r814050149 ## File path: core/src/main/scala/kafka/log/remote/RemoteIndexCache.scala ## @@ -0,0 +1,223 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] satishd commented on a change in pull request #11390: [KAFKA-13369] Follower fetch protocol changes for tiered storage.

2022-02-24 Thread GitBox
satishd commented on a change in pull request #11390: URL: https://github.com/apache/kafka/pull/11390#discussion_r814046367 ## File path: core/src/main/scala/kafka/log/remote/RemoteIndexCache.scala ## @@ -0,0 +1,223 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] satishd commented on a change in pull request #11390: [KAFKA-13369] Follower fetch protocol changes for tiered storage.

2022-02-24 Thread GitBox
satishd commented on a change in pull request #11390: URL: https://github.com/apache/kafka/pull/11390#discussion_r814045120 ## File path: clients/src/main/resources/common/message/ListOffsetsResponse.json ## @@ -31,7 +31,10 @@ // Version 6 enables flexible versions. //

[GitHub] [kafka] satishd commented on a change in pull request #11390: [KAFKA-13369] Follower fetch protocol changes for tiered storage.

2022-02-24 Thread GitBox
satishd commented on a change in pull request #11390: URL: https://github.com/apache/kafka/pull/11390#discussion_r814041397 ## File path: core/src/main/scala/kafka/log/remote/RemoteLogManager.scala ## @@ -0,0 +1,285 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] satishd commented on a change in pull request #11390: [KAFKA-13369] Follower fetch protocol changes for tiered storage.

2022-02-24 Thread GitBox
satishd commented on a change in pull request #11390: URL: https://github.com/apache/kafka/pull/11390#discussion_r814039902 ## File path: core/src/main/scala/kafka/server/BrokerServer.scala ## @@ -437,6 +446,19 @@ class BrokerServer( } } + protected def

[GitHub] [kafka] satishd commented on a change in pull request #11390: [KAFKA-13369] Follower fetch protocol changes for tiered storage.

2022-02-24 Thread GitBox
satishd commented on a change in pull request #11390: URL: https://github.com/apache/kafka/pull/11390#discussion_r814036592 ## File path: core/src/main/scala/kafka/server/ReplicaFetcherThread.scala ## @@ -259,12 +270,12 @@ class ReplicaFetcherThread(name: String, val

[jira] [Commented] (KAFKA-13681) Sink event duplicates for partition-stuck stream application

2022-02-24 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497502#comment-17497502 ] Walker Carlson commented on KAFKA-13681: [~DrozD_0] Right now its only enabled with an

[GitHub] [kafka] satishd commented on a change in pull request #11390: [KAFKA-13369] Follower fetch protocol changes for tiered storage.

2022-02-24 Thread GitBox
satishd commented on a change in pull request #11390: URL: https://github.com/apache/kafka/pull/11390#discussion_r814031095 ## File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala ## @@ -715,6 +738,87 @@ abstract class AbstractFetcherThread(name: String,

[GitHub] [kafka] satishd commented on a change in pull request #11390: [KAFKA-13369] Follower fetch protocol changes for tiered storage.

2022-02-24 Thread GitBox
satishd commented on a change in pull request #11390: URL: https://github.com/apache/kafka/pull/11390#discussion_r814028646 ## File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala ## @@ -396,7 +421,12 @@ abstract class AbstractFetcherThread(name: String,

[GitHub] [kafka] jsancio merged pull request #11790: MINOR: Cleanup admin creation logic in integration tests

2022-02-24 Thread GitBox
jsancio merged pull request #11790: URL: https://github.com/apache/kafka/pull/11790 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] jsancio commented on a change in pull request #11733: KAFKA-13587; Implement leader recovery for KIP-704

2022-02-24 Thread GitBox
jsancio commented on a change in pull request #11733: URL: https://github.com/apache/kafka/pull/11733#discussion_r813999251 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -760,44 +719,132 @@ BrokersToIsrs brokersToIsrs()

[GitHub] [kafka] jsancio commented on a change in pull request #11733: KAFKA-13587; Implement leader recovery for KIP-704

2022-02-24 Thread GitBox
jsancio commented on a change in pull request #11733: URL: https://github.com/apache/kafka/pull/11733#discussion_r813998423 ## File path: core/src/test/scala/unit/kafka/cluster/PartitionTest.scala ## @@ -2015,6 +2067,8 @@ class PartitionTest extends AbstractPartitionTest {

[GitHub] [kafka] jsancio commented on a change in pull request #11733: KAFKA-13587; Implement leader recovery for KIP-704

2022-02-24 Thread GitBox
jsancio commented on a change in pull request #11733: URL: https://github.com/apache/kafka/pull/11733#discussion_r813998749 ## File path: metadata/src/main/java/org/apache/kafka/controller/PartitionChangeBuilder.java ## @@ -104,6 +107,14 @@ public PartitionChangeBuilder

[GitHub] [kafka] jsancio commented on a change in pull request #11733: KAFKA-13587; Implement leader recovery for KIP-704

2022-02-24 Thread GitBox
jsancio commented on a change in pull request #11733: URL: https://github.com/apache/kafka/pull/11733#discussion_r813998423 ## File path: core/src/test/scala/unit/kafka/cluster/PartitionTest.scala ## @@ -2015,6 +2067,8 @@ class PartitionTest extends AbstractPartitionTest {

[GitHub] [kafka] jsancio commented on a change in pull request #11733: KAFKA-13587; Implement leader recovery for KIP-704

2022-02-24 Thread GitBox
jsancio commented on a change in pull request #11733: URL: https://github.com/apache/kafka/pull/11733#discussion_r813997211 ## File path: core/src/test/scala/unit/kafka/cluster/PartitionTest.scala ## @@ -1077,6 +1078,58 @@ class PartitionTest extends AbstractPartitionTest {

[GitHub] [kafka] jsancio commented on a change in pull request #11733: KAFKA-13587; Implement leader recovery for KIP-704

2022-02-24 Thread GitBox
jsancio commented on a change in pull request #11733: URL: https://github.com/apache/kafka/pull/11733#discussion_r813996872 ## File path: core/src/test/scala/kafka/zk/TopicPartitionStateZNodeTest.scala ## @@ -0,0 +1,53 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] [kafka] jsancio commented on a change in pull request #11733: KAFKA-13587; Implement leader recovery for KIP-704

2022-02-24 Thread GitBox
jsancio commented on a change in pull request #11733: URL: https://github.com/apache/kafka/pull/11733#discussion_r813995003 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -760,44 +719,132 @@ BrokersToIsrs brokersToIsrs()

[GitHub] [kafka] jsancio commented on a change in pull request #11733: KAFKA-13587; Implement leader recovery for KIP-704

2022-02-24 Thread GitBox
jsancio commented on a change in pull request #11733: URL: https://github.com/apache/kafka/pull/11733#discussion_r813988441 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -760,44 +719,132 @@ BrokersToIsrs brokersToIsrs()

[jira] [Comment Edited] (KAFKA-4212) Add a key-value store that is a TTL persistent cache

2022-02-24 Thread Zhongda Zhao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497236#comment-17497236 ] Zhongda Zhao edited comment on KAFKA-4212 at 2/24/22, 10:10 AM: Through:

[GitHub] [kafka] ableegoldman commented on a change in pull request #11787: KAFKA-12738: tracking task errors

2022-02-24 Thread GitBox
ableegoldman commented on a change in pull request #11787: URL: https://github.com/apache/kafka/pull/11787#discussion_r813725686 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskExecutionMetadata.java ## @@ -0,0 +1,98 @@ +/* + * Licensed to

[GitHub] [kafka] ableegoldman commented on a change in pull request #11787: KAFKA-12738: tracking task errors

2022-02-24 Thread GitBox
ableegoldman commented on a change in pull request #11787: URL: https://github.com/apache/kafka/pull/11787#discussion_r813714182 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/ErrorHandlingIntegrationTest.java ## @@ -0,0 +1,165 @@ +/* + * Licensed to

[GitHub] [kafka] RivenSun2 edited a comment on pull request #11800: KAFKA-13689: Optimized the printing of AbstractConfig logs, and stripped unknownKeys from unusedKeys

2022-02-24 Thread GitBox
RivenSun2 edited a comment on pull request #11800: URL: https://github.com/apache/kafka/pull/11800#issuecomment-1049673076 @showuon Please help to check when you are available. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] RivenSun2 commented on pull request #11800: KAFKA-13689: Optimized the printing of AbstractConfig logs, and stripped unknownKeys from unusedKeys

2022-02-24 Thread GitBox
RivenSun2 commented on pull request #11800: URL: https://github.com/apache/kafka/pull/11800#issuecomment-1049673076 @showuon Please check when you are available. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Comment Edited] (KAFKA-4212) Add a key-value store that is a TTL persistent cache

2022-02-24 Thread Zhongda Zhao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497236#comment-17497236 ] Zhongda Zhao edited comment on KAFKA-4212 at 2/24/22, 9:42 AM: --- Through:

[jira] [Comment Edited] (KAFKA-4212) Add a key-value store that is a TTL persistent cache

2022-02-24 Thread Zhongda Zhao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497236#comment-17497236 ] Zhongda Zhao edited comment on KAFKA-4212 at 2/24/22, 9:41 AM: --- Through:

[jira] [Comment Edited] (KAFKA-4212) Add a key-value store that is a TTL persistent cache

2022-02-24 Thread Zhongda Zhao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497236#comment-17497236 ] Zhongda Zhao edited comment on KAFKA-4212 at 2/24/22, 9:40 AM: --- Through:

[GitHub] [kafka] showuon closed pull request #11798: yes added

2022-02-24 Thread GitBox
showuon closed pull request #11798: URL: https://github.com/apache/kafka/pull/11798 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] showuon commented on pull request #11798: yes added

2022-02-24 Thread GitBox
showuon commented on pull request #11798: URL: https://github.com/apache/kafka/pull/11798#issuecomment-1049663905 @madhusyath5620 , I guess you're testing something. I'm going to close this PR. You can reopen it if necessary. Thanks. -- This is an automated message from the Apache Git

[jira] [Commented] (KAFKA-13678) 2nd punctuation using STREAM_TIME does not respect scheduled interval

2022-02-24 Thread Lorenzo Cagnatel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497283#comment-17497283 ] Lorenzo Cagnatel commented on KAFKA-13678: -- When you talk about determinism in stream time

[jira] [Comment Edited] (KAFKA-4212) Add a key-value store that is a TTL persistent cache

2022-02-24 Thread Zhongda Zhao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497236#comment-17497236 ] Zhongda Zhao edited comment on KAFKA-4212 at 2/24/22, 9:29 AM: --- Through:

[jira] [Comment Edited] (KAFKA-4212) Add a key-value store that is a TTL persistent cache

2022-02-24 Thread Zhongda Zhao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497236#comment-17497236 ] Zhongda Zhao edited comment on KAFKA-4212 at 2/24/22, 9:27 AM: --- Through:

  1   2   >