[GitHub] [kafka] showuon commented on a change in pull request #11775: KAFKA-10000: Add all public-facing config properties related to exactly-once source support (KIP-618)

2022-03-03 Thread GitBox
showuon commented on a change in pull request #11775: URL: https://github.com/apache/kafka/pull/11775#discussion_r819316799 ## File path: connect/api/src/main/java/org/apache/kafka/connect/source/SourceConnector.java ## @@ -28,4 +30,46 @@ protected SourceConnectorContext

[jira] [Commented] (KAFKA-13422) Even if the correct username and password are configured, when ClientBroker or KafkaClient tries to establish a SASL connection to ServerBroker, an exception is thrown

2022-03-03 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17501165#comment-17501165 ] RivenSun commented on KAFKA-13422: -- Hi [~rsivaram]  [~ijuma] could you give any suggestions? Thanks.  

[jira] [Commented] (KAFKA-6106) Postpone normal processing of tasks within a thread until restoration of all tasks have completed

2022-03-03 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17501162#comment-17501162 ] Guozhang Wang commented on KAFKA-6106: -- As discussed with [~cadonna] offline, when we have completed

[jira] [Updated] (KAFKA-7934) Optimize restore for windowed and session stores

2022-03-03 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-7934: - Labels: new-streams-runtime-should-fix (was: ) > Optimize restore for windowed and session

[jira] [Updated] (KAFKA-12634) Should checkpoint after restore finished

2022-03-03 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-12634: -- Priority: Critical (was: Major) > Should checkpoint after restore finished >

[jira] [Updated] (KAFKA-12634) Should checkpoint after restore finished

2022-03-03 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-12634: -- Labels: new-streams-runtime-should-fix newbie++ (was: newbie++) > Should checkpoint after

[jira] [Updated] (KAFKA-6106) Postpone normal processing of tasks within a thread until restoration of all tasks have completed

2022-03-03 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-6106: - Labels: new-streams-runtime-should-fix newbie++ (was: newbie++) > Postpone normal processing of

[jira] [Updated] (KAFKA-13501) Avoid state restore via rebalance if standbys are enabled

2022-03-03 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-13501: -- Labels: new-streams-runtime-should-fix (was: ) > Avoid state restore via rebalance if

[GitHub] [kafka] guozhangwang commented on pull request #11830: KAFKA-13694: When the Broker side processes the ProduceRequest, it prints more specific information when the verification record fails.

2022-03-03 Thread GitBox
guozhangwang commented on pull request #11830: URL: https://github.com/apache/kafka/pull/11830#issuecomment-1058837418 Thanks @RivenSun2 , the changes LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (KAFKA-13686) NullPointerException in Selector.pollSelectionKeys

2022-03-03 Thread Antonio Ricardo Alexandre Brasil (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17501144#comment-17501144 ] Antonio Ricardo Alexandre Brasil commented on KAFKA-13686: -- Hi John, how do you

[GitHub] [kafka] Corlobin edited a comment on pull request #11841: KAFKA-13705: CoreUtils.swallow uses logging parameter instead of Logger

2022-03-03 Thread GitBox
Corlobin edited a comment on pull request #11841: URL: https://github.com/apache/kafka/pull/11841#issuecomment-1058803228 Hi Luke, thanks! I'm taking a look! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] Corlobin commented on pull request #11841: KAFKA-13705: CoreUtils.swallow uses logging parameter instead of Logger

2022-03-03 Thread GitBox
Corlobin commented on pull request #11841: URL: https://github.com/apache/kafka/pull/11841#issuecomment-1058803228 I'm taking a look! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] Corlobin removed a comment on pull request #11841: KAFKA-13705: CoreUtils.swallow uses logging parameter instead of Logger

2022-03-03 Thread GitBox
Corlobin removed a comment on pull request #11841: URL: https://github.com/apache/kafka/pull/11841#issuecomment-1058796530 Hi @showuon , thanks for replying Looks like a problem with every pull request, which is not related with the change I made Do you have any idea? -- This is

[GitHub] [kafka] Corlobin edited a comment on pull request #11841: KAFKA-13705: CoreUtils.swallow uses logging parameter instead of Logger

2022-03-03 Thread GitBox
Corlobin edited a comment on pull request #11841: URL: https://github.com/apache/kafka/pull/11841#issuecomment-1058796530 Hi @showuon , thanks for replying Looks like a problem with every pull request, which is not related with the change I made Do you have any idea? -- This is an

[GitHub] [kafka] Corlobin commented on pull request #11841: KAFKA-13705: CoreUtils.swallow uses logging parameter instead of Logger

2022-03-03 Thread GitBox
Corlobin commented on pull request #11841: URL: https://github.com/apache/kafka/pull/11841#issuecomment-1058796530 Hi @showuon , thanks for replying Looks like a problem with every pull request, not related with the change I made -- This is an automated message from the Apache Git

[GitHub] [kafka] LiamClarkeNZ opened a new pull request #11475: KAFKA-7077: Use default producer settings in Connect Worker

2022-03-03 Thread GitBox
LiamClarkeNZ opened a new pull request #11475: URL: https://github.com/apache/kafka/pull/11475 In KAFKA-7077 and the associated KIP-318, there's a desire to a) enable producer idempotence and b) set max in flight requests to 5 to improve throughput, as opposed to the previous hardwired 1.

[GitHub] [kafka] LiamClarkeNZ closed pull request #11475: KAFKA-7077: Use default producer settings in Connect Worker

2022-03-03 Thread GitBox
LiamClarkeNZ closed pull request #11475: URL: https://github.com/apache/kafka/pull/11475 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] LiamClarkeNZ commented on pull request #11475: KAFKA-7077: Use default producer settings in Connect Worker

2022-03-03 Thread GitBox
LiamClarkeNZ commented on pull request #11475: URL: https://github.com/apache/kafka/pull/11475#issuecomment-1058786901 > @LiamClarkeNZ , thanks for the PR. LGTM. But there's a bug cause the default idempotent producer is not enabled and get fixed recently. (ref: #11691 ) Could you rebase

[GitHub] [kafka] LiamClarkeNZ commented on pull request #11821: KAFKA-13672 Flaky test kafka.server.DynamicBrokerReconfigurationTest.testThreadPoolResize() [WIP]

2022-03-03 Thread GitBox
LiamClarkeNZ commented on pull request #11821: URL: https://github.com/apache/kafka/pull/11821#issuecomment-1058783102 Hi @showuon, I'm still investigating the root cause, when I do find it, I'll delete this PR and create a new one and ping you on it. I just needed a WIP PR to run

[GitHub] [kafka] showuon commented on a change in pull request #11843: MINOR: Correct Javadoc in FetchSessionHandler

2022-03-03 Thread GitBox
showuon commented on a change in pull request #11843: URL: https://github.com/apache/kafka/pull/11843#discussion_r819220063 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -454,7 +454,7 @@ String

[GitHub] [kafka] showuon commented on pull request #11722: KAFKA-13630: reduce amount of time that producer network thread holds batch queue lock

2022-03-03 Thread GitBox
showuon commented on pull request #11722: URL: https://github.com/apache/kafka/pull/11722#issuecomment-1058762845 @ijuma @artemlivshits , do you want to have another look at this PR? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] jasonk000 commented on pull request #11722: KAFKA-13630: reduce amount of time that producer network thread holds batch queue lock

2022-03-03 Thread GitBox
jasonk000 commented on pull request #11722: URL: https://github.com/apache/kafka/pull/11722#issuecomment-1058761519 hi @showuon , was there anything remaining here before we merge it? thx -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] showuon commented on pull request #11517: KAFKA-13466:when kafka-console-producer.sh, delete unused config batch.size

2022-03-03 Thread GitBox
showuon commented on pull request #11517: URL: https://github.com/apache/kafka/pull/11517#issuecomment-1058744568 Thanks for the contribution, @peterwanner ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] showuon merged pull request #11517: KAFKA-13466:when kafka-console-producer.sh, delete unused config batch.size

2022-03-03 Thread GitBox
showuon merged pull request #11517: URL: https://github.com/apache/kafka/pull/11517 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] showuon commented on pull request #11517: KAFKA-13466:when kafka-console-producer.sh, delete unused config batch.size

2022-03-03 Thread GitBox
showuon commented on pull request #11517: URL: https://github.com/apache/kafka/pull/11517#issuecomment-1058743569 Failed tests are unrelated and also failed in `trunk` branch. ``` Build / ARM /

[GitHub] [kafka] philipnee commented on a change in pull request #11797: KAFKA-12879: Revert changes from KAFKA-12339 and instead add retry capability to KafkaBasedLog

2022-03-03 Thread GitBox
philipnee commented on a change in pull request #11797: URL: https://github.com/apache/kafka/pull/11797#discussion_r819187176 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/util/RetryUtil.java ## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] rhauch commented on a change in pull request #11797: KAFKA-12879: Revert changes from KAFKA-12339 and instead add retry capability to KafkaBasedLog

2022-03-03 Thread GitBox
rhauch commented on a change in pull request #11797: URL: https://github.com/apache/kafka/pull/11797#discussion_r819182327 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/util/RetryUtil.java ## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] adamkotwasinski removed a comment on pull request #11843: MINOR: Correct Javadoc in FetchSessionHandler

2022-03-03 Thread GitBox
adamkotwasinski removed a comment on pull request #11843: URL: https://github.com/apache/kafka/pull/11843#issuecomment-1058647070 /retest -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] adamkotwasinski commented on pull request #11843: MINOR: Correct Javadoc in FetchSessionHandler

2022-03-03 Thread GitBox
adamkotwasinski commented on pull request #11843: URL: https://github.com/apache/kafka/pull/11843#issuecomment-1058647070 /retest -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] lihaosky commented on pull request #11820: [RFC][2/N] add restoration logic for RocksDBTimeOrderedWindowStore

2022-03-03 Thread GitBox
lihaosky commented on pull request #11820: URL: https://github.com/apache/kafka/pull/11820#issuecomment-1058631328 Don't need anymore -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] lihaosky closed pull request #11820: [RFC][2/N] add restoration logic for RocksDBTimeOrderedWindowStore

2022-03-03 Thread GitBox
lihaosky closed pull request #11820: URL: https://github.com/apache/kafka/pull/11820 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (KAFKA-13702) Connect RestClient overrides response status code on request failure

2022-03-03 Thread Antonio Ricardo Alexandre Brasil (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17501053#comment-17501053 ] Antonio Ricardo Alexandre Brasil commented on KAFKA-13702: -- I've made the PR:

[GitHub] [kafka] Corlobin opened a new pull request #11844: KAFKA#13702 - Connect RestClient overrides response status code on request failure

2022-03-03 Thread GitBox
Corlobin opened a new pull request #11844: URL: https://github.com/apache/kafka/pull/11844 As described in Jira: In case the submitted request status is >=400, the connect RestClient

[GitHub] [kafka] philipnee commented on a change in pull request #11797: KAFKA-12879: Revert changes from KAFKA-12339 and instead add retry capability to KafkaBasedLog

2022-03-03 Thread GitBox
philipnee commented on a change in pull request #11797: URL: https://github.com/apache/kafka/pull/11797#discussion_r819086900 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/util/RetryUtil.java ## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software

[jira] [Updated] (KAFKA-13687) Limit number of batches when using kafka-dump-log.sh

2022-03-03 Thread Sergio Troiano (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergio Troiano updated KAFKA-13687: --- Attachment: (was: FileRecords.java) > Limit number of batches when using

[jira] [Updated] (KAFKA-13687) Limit number of batches when using kafka-dump-log.sh

2022-03-03 Thread Sergio Troiano (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergio Troiano updated KAFKA-13687: --- Attachment: (was: DumpLogSegments.scala) > Limit number of batches when using

[GitHub] [kafka] adamkotwasinski opened a new pull request #11843: MINOR: Correct Javadoc in FetchSessionHandler

2022-03-03 Thread GitBox
adamkotwasinski opened a new pull request #11843: URL: https://github.com/apache/kafka/pull/11843 While debugging some client issues I found out that some Javadocs in FetchSessionHandler got misleading / outdated. ### Committer Checklist (excluded from commit message) - [ ]

[GitHub] [kafka] sciclon2 opened a new pull request #11842: []Limiting the amount of bytes to be read in a segment logs

2022-03-03 Thread GitBox
sciclon2 opened a new pull request #11842: URL: https://github.com/apache/kafka/pull/11842 ### Summary This PR allows to limit the output batches while they are inspected via the `kafka-dump-log.sh` script. The idea is to take samples from the logsegments without affecting a

[jira] [Commented] (KAFKA-13705) CoreUtils.swallow uses CoreUtils.logger but not logging parameter

2022-03-03 Thread Antonio Ricardo Alexandre Brasil (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17501024#comment-17501024 ] Antonio Ricardo Alexandre Brasil commented on KAFKA-13705: -- I've made the PR

[GitHub] [kafka] Corlobin opened a new pull request #11841: KAFKA-13705: CoreUtils.swallow uses logging parameter instead of Logger

2022-03-03 Thread GitBox
Corlobin opened a new pull request #11841: URL: https://github.com/apache/kafka/pull/11841 As described in the issue, the: - Javadoc says: **logging The logging instance to use for logging the thrown exception.** But logging parameter it is never used. The testing

[GitHub] [kafka] kirktrue commented on a change in pull request #11835: MINOR: refactor how ConfigurationControl checks for resource existence

2022-03-03 Thread GitBox
kirktrue commented on a change in pull request #11835: URL: https://github.com/apache/kafka/pull/11835#discussion_r819043511 ## File path: metadata/src/test/java/org/apache/kafka/controller/ReplicationControlManagerTest.java ## @@ -143,8 +143,12 @@ new

[GitHub] [kafka] rhauch commented on a change in pull request #11797: KAFKA-12879: Revert changes from KAFKA-12339 and instead add retry capability to KafkaBasedLog

2022-03-03 Thread GitBox
rhauch commented on a change in pull request #11797: URL: https://github.com/apache/kafka/pull/11797#discussion_r819024411 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/util/RetryUtil.java ## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] cmccabe commented on a change in pull request #11835: MINOR: refactor how ConfigurationControl checks for resource existence

2022-03-03 Thread GitBox
cmccabe commented on a change in pull request #11835: URL: https://github.com/apache/kafka/pull/11835#discussion_r819010753 ## File path: metadata/src/test/java/org/apache/kafka/controller/ReplicationControlManagerTest.java ## @@ -143,8 +143,12 @@ new

[jira] [Commented] (KAFKA-13707) Refactor - unify the naming convention of in-flight

2022-03-03 Thread Arvin Zheng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500996#comment-17500996 ] Arvin Zheng commented on KAFKA-13707: - Treated it as two words to alight with the config item

[GitHub] [kafka] ArvinZheng opened a new pull request #11840: KAFKA-13707: unify the naming convention of in-flight

2022-03-03 Thread GitBox
ArvinZheng opened a new pull request #11840: URL: https://github.com/apache/kafka/pull/11840 Update the codes and comments in kafka-clients to unify the naming convention of in-flight, treated it as two words to alight with the configuration item `max.in.flight.requests.per.connection`

[jira] [Created] (KAFKA-13707) Refactor - unify the naming convention of in-flight

2022-03-03 Thread Arvin Zheng (Jira)
Arvin Zheng created KAFKA-13707: --- Summary: Refactor - unify the naming convention of in-flight Key: KAFKA-13707 URL: https://issues.apache.org/jira/browse/KAFKA-13707 Project: Kafka Issue

[GitHub] [kafka] vincent81jiang opened a new pull request #11839: KAFKA-13706: remove closed connections from MockSelector.ready

2022-03-03 Thread GitBox
vincent81jiang opened a new pull request #11839: URL: https://github.com/apache/kafka/pull/11839 On connection close, remove closed connection from MockSelector.ready ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify

[jira] [Created] (KAFKA-13706) org.apache.kafka.test.MockSelector doesn't remove closed connections from its 'ready' field

2022-03-03 Thread Vincent Jiang (Jira)
Vincent Jiang created KAFKA-13706: - Summary: org.apache.kafka.test.MockSelector doesn't remove closed connections from its 'ready' field Key: KAFKA-13706 URL: https://issues.apache.org/jira/browse/KAFKA-13706

[GitHub] [kafka] junrao commented on pull request #11811: (docs) Add JavaDocs for org.apache.kafka.common.security.oauthbearer.secured

2022-03-03 Thread GitBox
junrao commented on pull request #11811: URL: https://github.com/apache/kafka/pull/11811#issuecomment-1058343997 @justinrlee : It would be useful to submit a similar PR to 3.1 too. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] junrao merged pull request #11811: (docs) Add JavaDocs for org.apache.kafka.common.security.oauthbearer.secured

2022-03-03 Thread GitBox
junrao merged pull request #11811: URL: https://github.com/apache/kafka/pull/11811 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] sciclon2 commented on pull request #11836: [KAFKA-13687] Allowing dumping logs for a small segment

2022-03-03 Thread GitBox
sciclon2 commented on pull request #11836: URL: https://github.com/apache/kafka/pull/11836#issuecomment-1058335732 sure, thanks a lot @mimaison you were really helpful !!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] sciclon2 closed pull request #11836: [KAFKA-13687] Allowing dumping logs for a small segment

2022-03-03 Thread GitBox
sciclon2 closed pull request #11836: URL: https://github.com/apache/kafka/pull/11836 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] kirktrue commented on a change in pull request #11835: MINOR: refactor how ConfigurationControl checks for resource existence

2022-03-03 Thread GitBox
kirktrue commented on a change in pull request #11835: URL: https://github.com/apache/kafka/pull/11835#discussion_r818918314 ## File path: metadata/src/test/java/org/apache/kafka/controller/ReplicationControlManagerTest.java ## @@ -143,8 +143,12 @@ new

[GitHub] [kafka] lihaosky commented on a change in pull request #11802: [RFC][1/N]add new RocksDBTimeOrderedWindowStore

2022-03-03 Thread GitBox
lihaosky commented on a change in pull request #11802: URL: https://github.com/apache/kafka/pull/11802#discussion_r818922500 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/PrefixedWindowKeySchemas.java ## @@ -0,0 +1,311 @@ +/* + * Licensed to the

[jira] [Commented] (KAFKA-13705) CoreUtils.swallow uses CoreUtils.logger but not logging parameter

2022-03-03 Thread Antonio Ricardo Alexandre Brasil (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500950#comment-17500950 ] Antonio Ricardo Alexandre Brasil commented on KAFKA-13705: -- So the logging

[GitHub] [kafka] kirktrue commented on pull request #11822: [WIP] MINOR: add test

2022-03-03 Thread GitBox
kirktrue commented on pull request #11822: URL: https://github.com/apache/kafka/pull/11822#issuecomment-1058322353 I was gonna try to review it, but it looks like it might be in progress still? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] kirktrue commented on a change in pull request #11838: KAFKA-1372: separate 400 error from 500 error in RestClient

2022-03-03 Thread GitBox
kirktrue commented on a change in pull request #11838: URL: https://github.com/apache/kafka/pull/11838#discussion_r818911900 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/RestClient.java ## @@ -139,6 +139,9 @@

[GitHub] [kafka] mimaison commented on pull request #11836: [KAFKA-13687] Allowing dumping logs for a small segment

2022-03-03 Thread GitBox
mimaison commented on pull request #11836: URL: https://github.com/apache/kafka/pull/11836#issuecomment-1058308160 It's probably best to close this PR and reopen the other one on trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] mimaison commented on pull request #11836: [KAFKA-13687] Allowing dumping logs for a small segment

2022-03-03 Thread GitBox
mimaison commented on pull request #11836: URL: https://github.com/apache/kafka/pull/11836#issuecomment-1058307690 I've granted you permissions on the wiki and in JIRA. You should now be able to create KIPa and assign JIRAs to yourself. Yes new features are only committed to trunk.

[jira] [Commented] (KAFKA-6035) Avoid creating changelog topics for state stores that are directly piped to a sink topic

2022-03-03 Thread Mohammad Yousuf Minhaj Zia (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500901#comment-17500901 ] Mohammad Yousuf Minhaj Zia commented on KAFKA-6035: --- Hey guys, just wanted to confirm.

[GitHub] [kafka] blcksrx opened a new pull request #11838: KAFKA-1372: separate 400 error from 500 error in RestClient

2022-03-03 Thread GitBox
blcksrx opened a new pull request #11838: URL: https://github.com/apache/kafka/pull/11838 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

[GitHub] [kafka] C0urante commented on pull request #11775: KAFKA-10000: Add all public-facing config properties related to exactly-once source support (KIP-618)

2022-03-03 Thread GitBox
C0urante commented on pull request #11775: URL: https://github.com/apache/kafka/pull/11775#issuecomment-1058255349 Marking ready for review since https://github.com/apache/kafka/pull/11773, though not yet merged, has been approved. -- This is an automated message from the Apache Git

[GitHub] [kafka] C0urante commented on a change in pull request #11773: KAFKA-10000: Add new source connector APIs related to exactly-once support (KIP-618)

2022-03-03 Thread GitBox
C0urante commented on a change in pull request #11773: URL: https://github.com/apache/kafka/pull/11773#discussion_r818829273 ## File path: connect/api/src/main/java/org/apache/kafka/connect/source/SourceConnector.java ## @@ -28,4 +30,46 @@ protected

[GitHub] [kafka] C0urante commented on a change in pull request #11775: KAFKA-10000: Add all public-facing config properties related to exactly-once source support (KIP-618)

2022-03-03 Thread GitBox
C0urante commented on a change in pull request #11775: URL: https://github.com/apache/kafka/pull/11775#discussion_r818841452 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedConfig.java ## @@ -192,6 +197,40 @@ public

[GitHub] [kafka] C0urante commented on a change in pull request #11775: KAFKA-10000: Add all public-facing config properties related to exactly-once source support (KIP-618)

2022-03-03 Thread GitBox
C0urante commented on a change in pull request #11775: URL: https://github.com/apache/kafka/pull/11775#discussion_r818848052 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedConfig.java ## @@ -396,13 +441,58 @@

[GitHub] [kafka] C0urante commented on a change in pull request #11775: KAFKA-10000: Add all public-facing config properties related to exactly-once source support (KIP-618)

2022-03-03 Thread GitBox
C0urante commented on a change in pull request #11775: URL: https://github.com/apache/kafka/pull/11775#discussion_r818837032 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/SourceConnectorConfig.java ## @@ -58,23 +119,87 @@ public Object

[jira] [Comment Edited] (KAFKA-12622) Automate LICENSE file validation

2022-03-03 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317093#comment-17317093 ] Mickael Maison edited comment on KAFKA-12622 at 3/3/22, 4:29 PM: - When

[GitHub] [kafka] C0urante commented on a change in pull request #11773: KAFKA-10000: Add new source connector APIs related to exactly-once support (KIP-618)

2022-03-03 Thread GitBox
C0urante commented on a change in pull request #11773: URL: https://github.com/apache/kafka/pull/11773#discussion_r818829273 ## File path: connect/api/src/main/java/org/apache/kafka/connect/source/SourceConnector.java ## @@ -28,4 +30,46 @@ protected

[GitHub] [kafka] savinov edited a comment on pull request #8656: KAFKA-9981; dedicated mm2 cluster lose the update operation.

2022-03-03 Thread GitBox
savinov edited a comment on pull request #8656: URL: https://github.com/apache/kafka/pull/8656#issuecomment-1058005727 In my case follower doesn't update configuration because **changed** flag keeps **false** value. Neither task count has been changed nor task configs.

[GitHub] [kafka] C0urante commented on pull request #11777: KAFKA-10000: Add producer fencing API to admin client (KIP-618)

2022-03-03 Thread GitBox
C0urante commented on pull request #11777: URL: https://github.com/apache/kafka/pull/11777#issuecomment-1058169598 Thanks Tom! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] C0urante commented on a change in pull request #11572: KAFKA-13510: Connect APIs to list all connector plugins and retrieve …

2022-03-03 Thread GitBox
C0urante commented on a change in pull request #11572: URL: https://github.com/apache/kafka/pull/11572#discussion_r817913673 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java ## @@ -750,4 +755,41 @@ private String trace(Throwable

[GitHub] [kafka] savinov edited a comment on pull request #8656: KAFKA-9981; dedicated mm2 cluster lose the update operation.

2022-03-03 Thread GitBox
savinov edited a comment on pull request #8656: URL: https://github.com/apache/kafka/pull/8656#issuecomment-1058005727 In my case follower doesn't update configuration because **changed** flag keeps **false** value.

[GitHub] [kafka] savinov edited a comment on pull request #8656: KAFKA-9981; dedicated mm2 cluster lose the update operation.

2022-03-03 Thread GitBox
savinov edited a comment on pull request #8656: URL: https://github.com/apache/kafka/pull/8656#issuecomment-1058005727 In my case follower doesn't update configuration because **changed** flag doesn't set to **true**.

[GitHub] [kafka] dajac commented on a change in pull request #11173: KAFKA-13509: Support max timestamp in GetOffsetShell

2022-03-03 Thread GitBox
dajac commented on a change in pull request #11173: URL: https://github.com/apache/kafka/pull/11173#discussion_r818717336 ## File path: core/src/test/scala/kafka/tools/GetOffsetShellTest.scala ## @@ -109,6 +111,46 @@ class GetOffsetShellTest extends KafkaServerTestHarness

[jira] [Updated] (KAFKA-13164) State store is attached to wrong node in the Kafka Streams topology

2022-03-03 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-13164: --- Fix Version/s: (was: 3.0.1) > State store is attached to wrong node in the Kafka

[GitHub] [kafka] mimaison commented on pull request #11788: KAFKA-13673: disable idempotence when config conflicts

2022-03-03 Thread GitBox
mimaison commented on pull request #11788: URL: https://github.com/apache/kafka/pull/11788#issuecomment-1058064726 Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [kafka] ijuma commented on pull request #11788: KAFKA-13673: disable idempotence when config conflicts

2022-03-03 Thread GitBox
ijuma commented on pull request #11788: URL: https://github.com/apache/kafka/pull/11788#issuecomment-1058063862 @mimaison I did the backports. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] ijuma commented on pull request #11788: KAFKA-13673: disable idempotence when config conflicts

2022-03-03 Thread GitBox
ijuma commented on pull request #11788: URL: https://github.com/apache/kafka/pull/11788#issuecomment-1058063555 Merged to trunk, 3.1 and 3.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] mimaison commented on pull request #11788: KAFKA-13673: disable idempotence when config conflicts

2022-03-03 Thread GitBox
mimaison commented on pull request #11788: URL: https://github.com/apache/kafka/pull/11788#issuecomment-1058058072 Back porting to 3.0 and 3.1 since we merged https://github.com/apache/kafka/commit/e6db0ca48c42c03655e3781b46ac09dae75cf33e into these branches -- This is an automated

[GitHub] [kafka] sciclon2 commented on pull request #11836: [KAFKA-13687] Allowing dumping logs for a small segment

2022-03-03 Thread GitBox
sciclon2 commented on pull request #11836: URL: https://github.com/apache/kafka/pull/11836#issuecomment-1058057779 thanks for the reply @mimaison , I sent earlier the email with both Ids, so I will wait, jira user: sergio_troi...@hotmail.com wiki di: sergio_troiano In the

[GitHub] [kafka] ijuma merged pull request #11788: KAFKA-13673: disable idempotence when config conflicts

2022-03-03 Thread GitBox
ijuma merged pull request #11788: URL: https://github.com/apache/kafka/pull/11788 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Resolved] (KAFKA-13510) KIP-769: Connect APIs to list all connector plugins and retrieve their configuration definitions

2022-03-03 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-13510. Resolution: Fixed > KIP-769: Connect APIs to list all connector plugins and retrieve

[GitHub] [kafka] mimaison commented on pull request #11572: KAFKA-13510: Connect APIs to list all connector plugins and retrieve …

2022-03-03 Thread GitBox
mimaison commented on pull request #11572: URL: https://github.com/apache/kafka/pull/11572#issuecomment-1058042085 Thanks @C0urante and @tombentley for the reviews! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] mimaison merged pull request #11572: KAFKA-13510: Connect APIs to list all connector plugins and retrieve …

2022-03-03 Thread GitBox
mimaison merged pull request #11572: URL: https://github.com/apache/kafka/pull/11572 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] mimaison commented on pull request #11836: [KAFKA-13687] Allowing dumping logs for a small segment

2022-03-03 Thread GitBox
mimaison commented on pull request #11836: URL: https://github.com/apache/kafka/pull/11836#issuecomment-1058035075 @sciclon2 To get permissions, you need to follow the steps in [Getting

[jira] [Commented] (KAFKA-13671) Power (ppc64le) support for kafka

2022-03-03 Thread Abhijit (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500729#comment-17500729 ] Abhijit commented on KAFKA-13671: - I cleared the /tmp dir that contained some stale dirs from previous

[GitHub] [kafka] savinov commented on pull request #8656: KAFKA-9981; dedicated mm2 cluster lose the update operation.

2022-03-03 Thread GitBox
savinov commented on pull request #8656: URL: https://github.com/apache/kafka/pull/8656#issuecomment-1058005727 Follower instance logs the messages: `Skipping reconfiguration of connector MirrorSourceConnector since it is not running`. It seems that mm2 instance initialization on

[GitHub] [kafka] savinov edited a comment on pull request #8656: KAFKA-9981; dedicated mm2 cluster lose the update operation.

2022-03-03 Thread GitBox
savinov edited a comment on pull request #8656: URL: https://github.com/apache/kafka/pull/8656#issuecomment-1057958472 Unfortunatelly this patch doesn't work with Kafka 3.1.0: https://github.com/savinov/kafka/commits/3.1.0-KAFKA-9981 The leader MirrorSourceTasks stop after follower has

[GitHub] [kafka] sciclon2 commented on pull request #11836: [KAFKA-13687] Allowing dumping logs for a small segment

2022-03-03 Thread GitBox
sciclon2 commented on pull request #11836: URL: https://github.com/apache/kafka/pull/11836#issuecomment-1057964547 sorry @mimaison looks like I don't have permission for the KIP creation, how it is supposed I get access ? thanks

[GitHub] [kafka] savinov edited a comment on pull request #8656: KAFKA-9981; dedicated mm2 cluster lose the update operation.

2022-03-03 Thread GitBox
savinov edited a comment on pull request #8656: URL: https://github.com/apache/kafka/pull/8656#issuecomment-1057958472 Unfortunatelly this patch doesn't work with Kafka 3.1.0: https://github.com/savinov/kafka/commits/3.1.0-KAFKA-9981 The leader MirrorSourceTasks stop after follower has

[GitHub] [kafka] savinov edited a comment on pull request #8656: KAFKA-9981; dedicated mm2 cluster lose the update operation.

2022-03-03 Thread GitBox
savinov edited a comment on pull request #8656: URL: https://github.com/apache/kafka/pull/8656#issuecomment-1057958472 Unfortunatelly this patch doesn't work with Kafka 3.1.0: https://github.com/savinov/kafka/commits/3.1.0-KAFKA-9981 The leader MirrorSourceTasks stop after follower has

[GitHub] [kafka] savinov edited a comment on pull request #8656: KAFKA-9981; dedicated mm2 cluster lose the update operation.

2022-03-03 Thread GitBox
savinov edited a comment on pull request #8656: URL: https://github.com/apache/kafka/pull/8656#issuecomment-1057958472 Unfortunatelly this patch doesn't work with Kafka 3.1.0: https://github.com/savinov/kafka/commits/3.1.0-KAFKA-9981 The leader MirrorSourceTasks stop after follower has

[GitHub] [kafka] savinov commented on pull request #8656: KAFKA-9981; dedicated mm2 cluster lose the update operation.

2022-03-03 Thread GitBox
savinov commented on pull request #8656: URL: https://github.com/apache/kafka/pull/8656#issuecomment-1057958472 Unfortunatelly this patch doesn't work with Kafka 3.1.0: https://github.com/savinov/kafka/commits/3.1.0-KAFKA-9981 The leader MirrorSourceTasks stop after follower has been

[GitHub] [kafka] showuon commented on pull request #11517: KAFKA-13466:when kafka-console-producer.sh, delete unused config batch.size

2022-03-03 Thread GitBox
showuon commented on pull request #11517: URL: https://github.com/apache/kafka/pull/11517#issuecomment-1057947020 retrigger the jenkins build again. https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-11517/5/ -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] tombentley commented on a change in pull request #11775: KAFKA-10000: Add all public-facing config properties related to exactly-once source support (KIP-618)

2022-03-03 Thread GitBox
tombentley commented on a change in pull request #11775: URL: https://github.com/apache/kafka/pull/11775#discussion_r818522400 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/SourceConnectorConfig.java ## @@ -47,6 +57,57 @@ + "created

[GitHub] [kafka] cadonna commented on pull request #10851: KAFKA-6718 / Rack aware standby task assignor

2022-03-03 Thread GitBox
cadonna commented on pull request #10851: URL: https://github.com/apache/kafka/pull/10851#issuecomment-1057900673 拾 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [kafka] tombentley merged pull request #11777: KAFKA-10000: Add producer fencing API to admin client (KIP-618)

2022-03-03 Thread GitBox
tombentley merged pull request #11777: URL: https://github.com/apache/kafka/pull/11777 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] tombentley commented on pull request #11777: KAFKA-10000: Add producer fencing API to admin client (KIP-618)

2022-03-03 Thread GitBox
tombentley commented on pull request #11777: URL: https://github.com/apache/kafka/pull/11777#issuecomment-1057896201 Merging since failing tests appear to be unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] tombentley commented on a change in pull request #11777: KAFKA-10000: Add producer fencing API to admin client (KIP-618)

2022-03-03 Thread GitBox
tombentley commented on a change in pull request #11777: URL: https://github.com/apache/kafka/pull/11777#discussion_r818485429 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/FenceProducersHandler.java ## @@ -0,0 +1,148 @@ +/* + * Licensed to the

[GitHub] [kafka] tombentley commented on a change in pull request #11773: KAFKA-10000: Add new source connector APIs related to exactly-once support (KIP-618)

2022-03-03 Thread GitBox
tombentley commented on a change in pull request #11773: URL: https://github.com/apache/kafka/pull/11773#discussion_r818483442 ## File path: connect/api/src/main/java/org/apache/kafka/connect/source/SourceConnector.java ## @@ -28,4 +30,46 @@ protected

  1   2   >