[GitHub] [kafka] showuon merged pull request #11880: MINOR: Fix comments in TransactionsTest

2022-03-10 Thread GitBox
showuon merged pull request #11880: URL: https://github.com/apache/kafka/pull/11880 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] showuon opened a new pull request #11881: MINOR: revert back to 60s session timeout for static membership roll bounce test

2022-03-10 Thread GitBox
showuon opened a new pull request #11881: URL: https://github.com/apache/kafka/pull/11881 In this PR: https://github.com/apache/kafka/pull/11236/files#diff-bd4be654a82d362772b2010a0fa22a44916ff0da241ca7e6072741f7ef710136L689-R696 , we tried to reduce the session timeout for running tests

[GitHub] [kafka] ddrid opened a new pull request #11880: MINOR: Fix comments in TransactionsTest

2022-03-10 Thread GitBox
ddrid opened a new pull request #11880: URL: https://github.com/apache/kafka/pull/11880 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing

[GitHub] [kafka] kowshik closed pull request #11815: MINOR: Eliminate FileRecords mutable flag

2022-03-10 Thread GitBox
kowshik closed pull request #11815: URL: https://github.com/apache/kafka/pull/11815 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] XiaoyiPeng opened a new pull request #11879: KAFKA-13728: fix PushHttpMetricsReporter no longer pushes metrics when network failure is recovered.

2022-03-10 Thread GitBox
XiaoyiPeng opened a new pull request #11879: URL: https://github.com/apache/kafka/pull/11879 The class `PushHttpMetricsReporter` no longer pushes metrics when network failure is recovered. I debugged the code and found the problem here :

[jira] [Created] (KAFKA-13728) PushHttpMetricsReporter no longer pushes metrics when network failure is recovered.

2022-03-10 Thread XiaoyiPeng (Jira)
XiaoyiPeng created KAFKA-13728: -- Summary: PushHttpMetricsReporter no longer pushes metrics when network failure is recovered. Key: KAFKA-13728 URL: https://issues.apache.org/jira/browse/KAFKA-13728

[jira] [Updated] (KAFKA-13727) Edge case in cleaner can result in premature removal of ABORT marker

2022-03-10 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-13727: Description: The log cleaner works by first building a map of the active keys beginning

[jira] [Created] (KAFKA-13727) Edge case in cleaner can result in premature removal of ABORT marker

2022-03-10 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-13727: --- Summary: Edge case in cleaner can result in premature removal of ABORT marker Key: KAFKA-13727 URL: https://issues.apache.org/jira/browse/KAFKA-13727 Project:

[GitHub] [kafka] wcarlson5 commented on pull request #11868: KAFKA-12648: fix flaky #shouldAddToEmptyInitialTopologyRemoveResetOffsetsThenAddSameNamedTopologyWithRepartitioning

2022-03-10 Thread GitBox
wcarlson5 commented on pull request #11868: URL: https://github.com/apache/kafka/pull/11868#issuecomment-1064636537 @guozhangwang yes that would be a concern. I think we need to document that these calls need to be made in the same order with the same topologies for each client.

[GitHub] [kafka] guozhangwang commented on pull request #11868: KAFKA-12648: fix flaky #shouldAddToEmptyInitialTopologyRemoveResetOffsetsThenAddSameNamedTopologyWithRepartitioning

2022-03-10 Thread GitBox
guozhangwang commented on pull request #11868: URL: https://github.com/apache/kafka/pull/11868#issuecomment-1064634922 @wcarlson5 @ableegoldman I'm wondering if we could still have live lock scenarios like this: say we have two topologies A and B, and two threads a and b each on a

[GitHub] [kafka] lihaosky opened a new pull request #11878: fix flaky EosIntegrationTest.shouldCommitCorrectOffsetIfInputTopicIsTransactional[at_least_once]

2022-03-10 Thread GitBox
lihaosky opened a new pull request #11878: URL: https://github.com/apache/kafka/pull/11878 In this test, we started Kafka Streams app and then write to input topic in transaction. It's possible when streams commit offset, transaction hasn't finished yet. So the streams committed offset

[GitHub] [kafka] bbejeck commented on pull request #11870: MINOR: jmh.sh swallows compile errors

2022-03-10 Thread GitBox
bbejeck commented on pull request #11870: URL: https://github.com/apache/kafka/pull/11870#issuecomment-1064613347 Merged #11870 to trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] bbejeck merged pull request #11870: MINOR: jmh.sh swallows compile errors

2022-03-10 Thread GitBox
bbejeck merged pull request #11870: URL: https://github.com/apache/kafka/pull/11870 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] bbejeck commented on pull request #11870: MINOR: jmh.sh swallows compile errors

2022-03-10 Thread GitBox
bbejeck commented on pull request #11870: URL: https://github.com/apache/kafka/pull/11870#issuecomment-1064609464 test failures unrelated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] ijuma commented on pull request #11870: MINOR: jmh.sh swallows compile errors

2022-03-10 Thread GitBox
ijuma commented on pull request #11870: URL: https://github.com/apache/kafka/pull/11870#issuecomment-1064595311 Go for it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [kafka] bbejeck commented on pull request #11870: MINOR: jmh.sh swallows compile errors

2022-03-10 Thread GitBox
bbejeck commented on pull request #11870: URL: https://github.com/apache/kafka/pull/11870#issuecomment-1064549485 @ijuma I was going to merge this do you have any objections or comments? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] ableegoldman commented on pull request #11873: MINOR: Revert "KAFKA-13542: add rebalance reason in Kafka Streams (#11804)"

2022-03-10 Thread GitBox
ableegoldman commented on pull request #11873: URL: https://github.com/apache/kafka/pull/11873#issuecomment-1064538600 Merged to trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] ableegoldman merged pull request #11873: MINOR: Revert "KAFKA-13542: add rebalance reason in Kafka Streams (#11804)"

2022-03-10 Thread GitBox
ableegoldman merged pull request #11873: URL: https://github.com/apache/kafka/pull/11873 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] ijuma commented on pull request #11873: MINOR: Revert "KAFKA-13542: add rebalance reason in Kafka Streams (#11804)"

2022-03-10 Thread GitBox
ijuma commented on pull request #11873: URL: https://github.com/apache/kafka/pull/11873#issuecomment-1064536922 Thanks for the details @wcarlson5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] ableegoldman commented on pull request #11873: MINOR: Revert "KAFKA-13542: add rebalance reason in Kafka Streams (#11804)"

2022-03-10 Thread GitBox
ableegoldman commented on pull request #11873: URL: https://github.com/apache/kafka/pull/11873#issuecomment-1064522689 Test failures are unrelated. Going to merge Thanks for digging into this @wcarlson5 and @lihaosky . I hope we can figure out the cause and fix it soon as I was

[jira] [Comment Edited] (KAFKA-12879) Compatibility break in Admin.listOffsets()

2022-03-10 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17504584#comment-17504584 ] Randall Hauch edited comment on KAFKA-12879 at 3/10/22, 9:22 PM: -

[jira] [Resolved] (KAFKA-12879) Compatibility break in Admin.listOffsets()

2022-03-10 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-12879. --- Reviewer: Randall Hauch Resolution: Fixed > Compatibility break in

[jira] [Updated] (KAFKA-12879) Compatibility break in Admin.listOffsets()

2022-03-10 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch updated KAFKA-12879: -- Fix Version/s: 3.2.0 > Compatibility break in Admin.listOffsets() >

[jira] [Updated] (KAFKA-12879) Compatibility break in Admin.listOffsets()

2022-03-10 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch updated KAFKA-12879: -- Fix Version/s: 3.0.2 2.7.3 2.6.4

[jira] [Commented] (KAFKA-12879) Compatibility break in Admin.listOffsets()

2022-03-10 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17504584#comment-17504584 ] Randall Hauch commented on KAFKA-12879: --- Update: I'm having trouble with backporting the Connect

[jira] [Comment Edited] (KAFKA-12879) Compatibility break in Admin.listOffsets()

2022-03-10 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17503891#comment-17503891 ] Randall Hauch edited comment on KAFKA-12879 at 3/10/22, 9:13 PM: - The

[GitHub] [kafka] C0urante commented on a change in pull request #11773: KAFKA-10000: Add new source connector APIs related to exactly-once support (KIP-618)

2022-03-10 Thread GitBox
C0urante commented on a change in pull request #11773: URL: https://github.com/apache/kafka/pull/11773#discussion_r824130593 ## File path: connect/api/src/main/java/org/apache/kafka/connect/source/SourceConnector.java ## @@ -28,4 +30,46 @@ protected

[GitHub] [kafka] C0urante commented on a change in pull request #11773: KAFKA-10000: Add new source connector APIs related to exactly-once support (KIP-618)

2022-03-10 Thread GitBox
C0urante commented on a change in pull request #11773: URL: https://github.com/apache/kafka/pull/11773#discussion_r824130593 ## File path: connect/api/src/main/java/org/apache/kafka/connect/source/SourceConnector.java ## @@ -28,4 +30,46 @@ protected

[GitHub] [kafka] junrao commented on pull request #11815: MINOR: Eliminate FileRecords mutable flag

2022-03-10 Thread GitBox
junrao commented on pull request #11815: URL: https://github.com/apache/kafka/pull/11815#issuecomment-1064456133 @kowshik : Thanks for the investigation. I agree that this does seem to justify keeping the mutable flag. -- This is an automated message from the Apache Git Service. To

[jira] [Assigned] (KAFKA-13699) ProcessorContext does not expose Stream Time

2022-03-10 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-13699: --- Assignee: Matthias J. Sax > ProcessorContext does not expose Stream Time >

[GitHub] [kafka] mjsax opened a new pull request #11877: KAKFA-13699: new ProcessorContext is missing methods

2022-03-10 Thread GitBox
mjsax opened a new pull request #11877: URL: https://github.com/apache/kafka/pull/11877 In added `currentSystemTimeMs()` and `currentStreamTimeMs()` to the `ProcessorContext` via KIP-622, but forgot to add both to the new `api.ProcessorContext`. -- This is an automated message from

[GitHub] [kafka] ableegoldman commented on pull request #11868: KAFKA-12648: fix flaky #shouldAddToEmptyInitialTopologyRemoveResetOffsetsThenAddSameNamedTopologyWithRepartitioning

2022-03-10 Thread GitBox
ableegoldman commented on pull request #11868: URL: https://github.com/apache/kafka/pull/11868#issuecomment-1064453252 Merged to trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] ableegoldman merged pull request #11868: KAFKA-12648: fix flaky #shouldAddToEmptyInitialTopologyRemoveResetOffsetsThenAddSameNamedTopologyWithRepartitioning

2022-03-10 Thread GitBox
ableegoldman merged pull request #11868: URL: https://github.com/apache/kafka/pull/11868 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] ableegoldman commented on pull request #11868: KAFKA-12648: fix flaky #shouldAddToEmptyInitialTopologyRemoveResetOffsetsThenAddSameNamedTopologyWithRepartitioning

2022-03-10 Thread GitBox
ableegoldman commented on pull request #11868: URL: https://github.com/apache/kafka/pull/11868#issuecomment-1064452750 Test failures are unrelated. Merging -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] bbejeck commented on pull request #11876: Minor typo: "result is a" > "result in a"

2022-03-10 Thread GitBox
bbejeck commented on pull request #11876: URL: https://github.com/apache/kafka/pull/11876#issuecomment-1064398452 Thanks for the contribution @aSemy! Could you file an identical PR for https://github.com/apache/kafka-site/blob/asf-site/30/streams/developer-guide/dsl-api.html and

[GitHub] [kafka] bbejeck commented on pull request #11876: Minor typo: "result is a" > "result in a"

2022-03-10 Thread GitBox
bbejeck commented on pull request #11876: URL: https://github.com/apache/kafka/pull/11876#issuecomment-1064394560 merged into trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] bbejeck merged pull request #11876: Minor typo: "result is a" > "result in a"

2022-03-10 Thread GitBox
bbejeck merged pull request #11876: URL: https://github.com/apache/kafka/pull/11876 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] bbejeck commented on pull request #11876: Minor typo: "result is a" > "result in a"

2022-03-10 Thread GitBox
bbejeck commented on pull request #11876: URL: https://github.com/apache/kafka/pull/11876#issuecomment-1064390638 PR is html only, so merging now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] aSemy opened a new pull request #11876: Minor typo: "result _is_ a" > "result _in_ a"

2022-03-10 Thread GitBox
aSemy opened a new pull request #11876: URL: https://github.com/apache/kafka/pull/11876 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing

[GitHub] [kafka] mimaison commented on pull request #11838: KAFKA-1372: separate 400 error from 500 error in RestClient

2022-03-10 Thread GitBox
mimaison commented on pull request #11838: URL: https://github.com/apache/kafka/pull/11838#issuecomment-1064341677 Thanks for the PR @blcksrx ! I'll try to take a look in the next few days -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] mimaison commented on a change in pull request #11773: KAFKA-10000: Add new source connector APIs related to exactly-once support (KIP-618)

2022-03-10 Thread GitBox
mimaison commented on a change in pull request #11773: URL: https://github.com/apache/kafka/pull/11773#discussion_r824001349 ## File path: connect/api/src/main/java/org/apache/kafka/connect/source/SourceConnector.java ## @@ -28,4 +30,46 @@ protected

[GitHub] [kafka] wcarlson5 closed pull request #11866: MINOR: Offset Result is separate

2022-03-10 Thread GitBox
wcarlson5 closed pull request #11866: URL: https://github.com/apache/kafka/pull/11866 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] wcarlson5 edited a comment on pull request #11873: MINOR: Revert "KAFKA-13542: add rebalance reason in Kafka Streams (#11804)"

2022-03-10 Thread GitBox
wcarlson5 edited a comment on pull request #11873: URL: https://github.com/apache/kafka/pull/11873#issuecomment-1064230020 @dajac @ijuma Hey I expanded the PR description a bit to include everything we know. I also was not sure how this causes a performance impact. It seems innocuous but

[GitHub] [kafka] wcarlson5 commented on pull request #11873: MINOR: Revert "KAFKA-13542: add rebalance reason in Kafka Streams (#11804)"

2022-03-10 Thread GitBox
wcarlson5 commented on pull request #11873: URL: https://github.com/apache/kafka/pull/11873#issuecomment-1064230020 @dajac @ijuma Hey I expanded the PR description a bit to include everything we know. I also was not sure how this causes a performance impact. It seems innocuous but i has a

[GitHub] [kafka] ijuma commented on pull request #11873: MINOR: Revert "KAFKA-13542: add rebalance reason in Kafka Streams (#11804)"

2022-03-10 Thread GitBox
ijuma commented on pull request #11873: URL: https://github.com/apache/kafka/pull/11873#issuecomment-1064164621 Is this method being called in a hot loop? One difference is that there is a string concatenation if the reason is not null. -- This is an automated message from the Apache

[GitHub] [kafka] ijuma commented on pull request #11873: MINOR: Revert "KAFKA-13542: add rebalance reason in Kafka Streams (#11804)"

2022-03-10 Thread GitBox
ijuma commented on pull request #11873: URL: https://github.com/apache/kafka/pull/11873#issuecomment-1064157672 We should not revert this without providing more detailed information, the PR doesn't include enough information. -- This is an automated message from the Apache Git Service.

[GitHub] [kafka] ijuma commented on pull request #11873: MINOR: Revert "KAFKA-13542: add rebalance reason in Kafka Streams (#11804)"

2022-03-10 Thread GitBox
ijuma commented on pull request #11873: URL: https://github.com/apache/kafka/pull/11873#issuecomment-1064156544 Have you verified that this revert actually fixes the regression? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] dajac commented on pull request #11873: MINOR: Revert "KAFKA-13542: add rebalance reason in Kafka Streams (#11804)"

2022-03-10 Thread GitBox
dajac commented on pull request #11873: URL: https://github.com/apache/kafka/pull/11873#issuecomment-1063998412 @wcarlson5 It would be great if we could get to the bottom on this. I don't really understand how that could impact the performances. -- This is an automated message from the

[GitHub] [kafka] cadonna commented on pull request #11873: MINOR: Revert "KAFKA-13542: add rebalance reason in Kafka Streams (#11804)"

2022-03-10 Thread GitBox
cadonna commented on pull request #11873: URL: https://github.com/apache/kafka/pull/11873#issuecomment-1063957270 Restarted builds -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] kowshik edited a comment on pull request #11815: MINOR: Eliminate FileRecords mutable flag

2022-03-10 Thread GitBox
kowshik edited a comment on pull request #11815: URL: https://github.com/apache/kafka/pull/11815#issuecomment-1063904350 @junrao Thanks for catching. I found the test failures to be valid. Thinking about it agian, now I'm not sure if it is feasible to proceed with eliminating the

[GitHub] [kafka] kowshik commented on pull request #11815: MINOR: Eliminate FileRecords mutable flag

2022-03-10 Thread GitBox
kowshik commented on pull request #11815: URL: https://github.com/apache/kafka/pull/11815#issuecomment-1063904350 @junrao Thanks for catching. I found the test failures to be valid. Thinking about it agian, now I'm not sure if it is feasible to proceed with eliminating the `mutable` flag,

[GitHub] [kafka] cadonna commented on pull request #10802: KAFKA-6718 / Update SubscriptionInfoData with clientTags

2022-03-10 Thread GitBox
cadonna commented on pull request #10802: URL: https://github.com/apache/kafka/pull/10802#issuecomment-1063898824 @lkokhreidze The system tests passed:

[GitHub] [kafka] mjsax commented on a change in pull request #11875: KAFKA-13721: asymetric join-winodws should not emit spurious left/outer join results

2022-03-10 Thread GitBox
mjsax commented on a change in pull request #11875: URL: https://github.com/apache/kafka/pull/11875#discussion_r823500646 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java ## @@ -211,7 +214,7 @@ private void

[GitHub] [kafka] mjsax opened a new pull request #11875: KAFKA-13721: asymetric join-winodws should not emit spurious left/outer join results

2022-03-10 Thread GitBox
mjsax opened a new pull request #11875: URL: https://github.com/apache/kafka/pull/11875 Call for review @spena @guozhangwang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Assigned] (KAFKA-13721) Left-join still emit spurious results in stream-stream joins in some cases

2022-03-10 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-13721: --- Assignee: Matthias J. Sax > Left-join still emit spurious results in stream-stream

[jira] [Commented] (KAFKA-10160) Kafka MM2 consumer configuration

2022-03-10 Thread Harsha Madduri (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17504090#comment-17504090 ] Harsha Madduri commented on KAFKA-10160: Thanks for pointing that out, [~mimaison]. My bad, I

[jira] [Commented] (KAFKA-10160) Kafka MM2 consumer configuration

2022-03-10 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17504077#comment-17504077 ] Mickael Maison commented on KAFKA-10160: [~harsham] This fix is in trunk, see