RivenSun2 commented on a change in pull request #11940:
URL: https://github.com/apache/kafka/pull/11940#discussion_r833923860
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java
##
@@ -530,6 +530,9 @@ private TransactionManager
guozhangwang commented on a change in pull request #11940:
URL: https://github.com/apache/kafka/pull/11940#discussion_r833912567
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java
##
@@ -530,6 +530,9 @@ private TransactionManager
vamossagar12 commented on a change in pull request #11433:
URL: https://github.com/apache/kafka/pull/11433#discussion_r833912049
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -262,6 +262,42 @@ private void
vamossagar12 commented on a change in pull request #11433:
URL: https://github.com/apache/kafka/pull/11433#discussion_r833912049
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -262,6 +262,42 @@ private void
RivenSun2 commented on pull request #11940:
URL: https://github.com/apache/kafka/pull/11940#issuecomment-1077069535
@guozhangwang
Of course, I briefly sort out where KafkaClient calls
`AbstractConfig.getBoolean` method.
Only the `KafkaProducer.configureTransactionState` method needs
[
https://issues.apache.org/jira/browse/KAFKA-13672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen resolved KAFKA-13672.
---
Fix Version/s: 3.3.0
Resolution: Fixed
> Race condition in DynamicBrokerConfig
>
showuon commented on pull request #11920:
URL: https://github.com/apache/kafka/pull/11920#issuecomment-1077046585
@cadonna , also cherry-pick back to 3.2 branch. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
[
https://issues.apache.org/jira/browse/KAFKA-13542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17511577#comment-17511577
]
Hao Li commented on KAFKA-13542:
[~mjsax] , [~cadonna] , I haven't got time to figure out why this
showuon merged pull request #11920:
URL: https://github.com/apache/kafka/pull/11920
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-9826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17511576#comment-17511576
]
zhangzhisheng commented on KAFKA-9826:
--
[~junrao] kafka version from 2.4.1 to 2.8.1，the issue has
showuon commented on pull request #11920:
URL: https://github.com/apache/kafka/pull/11920#issuecomment-1077041046
Failed tests are unrelated.
```
Build / JDK 11 and Scala 2.13 /
org.apache.kafka.streams.integration.PurgeRepartitionTopicIntegrationTest.shouldRestoreState
showuon commented on pull request #10367:
URL: https://github.com/apache/kafka/pull/10367#issuecomment-1077035346
@C0urante , sure, please file another PR for other comments. And thanks for
the comments. However, I'm still concerned that @kkonstantine doesn't like the
current solution,
[
https://issues.apache.org/jira/browse/KAFKA-13714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler resolved KAFKA-13714.
--
Fix Version/s: 3.2.0
Assignee: John Roesler
Resolution: Fixed
> Flaky test
vvcephei commented on pull request #11926:
URL: https://github.com/apache/kafka/pull/11926#issuecomment-1077034307
Cherry-picked to 3.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
guozhangwang commented on pull request #11940:
URL: https://github.com/apache/kafka/pull/11940#issuecomment-1077031424
Hi @RivenSun2 I think we also want to call `ignore` when certain producer
feature is disabled as well?
--
This is an automated message from the Apache Git Service.
To
showuon commented on a change in pull request #11936:
URL: https://github.com/apache/kafka/pull/11936#discussion_r833881280
##
File path: core/src/test/scala/kafka/tools/GetOffsetShellTest.scala
##
@@ -166,6 +166,13 @@ class GetOffsetShellTest extends KafkaServerTestHarness
showuon commented on a change in pull request #11936:
URL: https://github.com/apache/kafka/pull/11936#discussion_r833881280
##
File path: core/src/test/scala/kafka/tools/GetOffsetShellTest.scala
##
@@ -166,6 +166,13 @@ class GetOffsetShellTest extends KafkaServerTestHarness
vvcephei merged pull request #11926:
URL: https://github.com/apache/kafka/pull/11926
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
vvcephei commented on pull request #11926:
URL: https://github.com/apache/kafka/pull/11926#issuecomment-1077021766
Test failures unrelated:
```
Build / JDK 8 and Scala 2.12 /
org.apache.kafka.common.network.SslTransportLayerTest.[1] tlsProtocol=TLSv1.2,
showuon commented on a change in pull request #11433:
URL: https://github.com/apache/kafka/pull/11433#discussion_r833872517
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -262,6 +262,42 @@ private void
showuon commented on a change in pull request #11433:
URL: https://github.com/apache/kafka/pull/11433#discussion_r833872517
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -262,6 +262,42 @@ private void
[
https://issues.apache.org/jira/browse/KAFKA-9366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17511547#comment-17511547
]
Luke Chen commented on KAFKA-9366:
--
[~brandonk] and all, we are aware of the log4j CVE issue is
[
https://issues.apache.org/jira/browse/KAFKA-13765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17511546#comment-17511546
]
Ryan Leslie commented on KAFKA-13765:
-
[~guozhang] Are you referring to
[
https://issues.apache.org/jira/browse/KAFKA-13542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17511537#comment-17511537
]
Matthias J. Sax commented on KAFKA-13542:
-
Curious: did we figure out why the patch resulted in
[
https://issues.apache.org/jira/browse/KAFKA-13766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17511534#comment-17511534
]
Guozhang Wang commented on KAFKA-13766:
---
cc [~dajac]
> Use `max.poll.interval.ms` as the timeout
Guozhang Wang created KAFKA-13766:
-
Summary: Use `max.poll.interval.ms` as the timeout during
complete-rebalance phase
Key: KAFKA-13766
URL: https://issues.apache.org/jira/browse/KAFKA-13766
Project:
[
https://issues.apache.org/jira/browse/KAFKA-13689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17511533#comment-17511533
]
RivenSun commented on KAFKA-13689:
--
[~guozhang] Thank you for your reply.
I will create a PR(11940) to
RivenSun2 commented on pull request #11940:
URL: https://github.com/apache/kafka/pull/11940#issuecomment-1076963317
Hi @guozhangwang
please help to review PR when available.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
RivenSun2 opened a new pull request #11940:
URL: https://github.com/apache/kafka/pull/11940
optimize the log output of logUnused method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
Guozhang Wang created KAFKA-13765:
-
Summary: Describe-consumer admin should not return unstable
membership information
Key: KAFKA-13765
URL: https://issues.apache.org/jira/browse/KAFKA-13765
Project:
kkonstantine commented on pull request #11908:
URL: https://github.com/apache/kafka/pull/11908#issuecomment-1076948497
I rebased to get the changes from https://github.com/apache/kafka/pull/11933
and get a green run of system tests
--
This is an automated message from the Apache Git
kkonstantine commented on a change in pull request #11908:
URL: https://github.com/apache/kafka/pull/11908#discussion_r833823045
##
File path: docs/connect.html
##
@@ -74,6 +74,7 @@ Running
Kafka Connectconfig.storage.topic (default
connect-configs) - topic to use for
[
https://issues.apache.org/jira/browse/KAFKA-13689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17511522#comment-17511522
]
Guozhang Wang commented on KAFKA-13689:
---
Hi [~RivenSun] I think I agree with you on the general
kkonstantine commented on pull request #11933:
URL: https://github.com/apache/kafka/pull/11933#issuecomment-1076884660
Thanks @rhauch. The fix has now been merged to trunk and cherry picked to
3.2, 3.1 and 3.0 with the appropriate adjustments to the upgrade notes. cc
@cadonna @tombentley
[
https://issues.apache.org/jira/browse/KAFKA-13759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konstantine Karantasis resolved KAFKA-13759.
Resolution: Fixed
> Disable producer idempotence by default in producers
[
https://issues.apache.org/jira/browse/KAFKA-13759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17511516#comment-17511516
]
Konstantine Karantasis commented on KAFKA-13759:
This issue has been now been merged on
[
https://issues.apache.org/jira/browse/KAFKA-13759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konstantine Karantasis updated KAFKA-13759:
---
Description:
https://issues.apache.org/jira/browse/KAFKA-7077 was merged
[
https://issues.apache.org/jira/browse/KAFKA-13759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konstantine Karantasis updated KAFKA-13759:
---
Fix Version/s: 3.2.0
3.1.1
3.0.2
>
[
https://issues.apache.org/jira/browse/KAFKA-13759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konstantine Karantasis updated KAFKA-13759:
---
Summary: Disable producer idempotence by default in producers instantiated
kkonstantine merged pull request #11933:
URL: https://github.com/apache/kafka/pull/11933
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-13763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-13763:
--
Description:
The
ijuma commented on a change in pull request #11938:
URL: https://github.com/apache/kafka/pull/11938#discussion_r833746787
##
File path: README.md
##
@@ -180,15 +180,21 @@ Please note for this to work you should create/update
user maven settings (typic
...
-###
[
https://issues.apache.org/jira/browse/KAFKA-13764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17511504#comment-17511504
]
Chris Egerton commented on KAFKA-13764:
---
Discussed earlier during review of
Chris Egerton created KAFKA-13764:
-
Summary: Potential improvements for Connect incremental
rebalancing logic
Key: KAFKA-13764
URL: https://issues.apache.org/jira/browse/KAFKA-13764
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-13763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17511497#comment-17511497
]
Chris Egerton commented on KAFKA-13763:
---
Discussed earlier during review of
Chris Egerton created KAFKA-13763:
-
Summary: Improve unit testing coverage for
IncrementalCooperativeAssignor
Key: KAFKA-13763
URL: https://issues.apache.org/jira/browse/KAFKA-13763
Project: Kafka
C0urante commented on a change in pull request #10367:
URL: https://github.com/apache/kafka/pull/10367#discussion_r833730613
##
File path:
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignorTest.java
##
@@ -180,6 +208,155
C0urante commented on a change in pull request #10367:
URL: https://github.com/apache/kafka/pull/10367#discussion_r833730504
##
File path:
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignorTest.java
##
@@ -180,6 +208,155
[
https://issues.apache.org/jira/browse/KAFKA-13404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17511487#comment-17511487
]
Chris Egerton edited comment on KAFKA-13404 at 3/23/22, 8:59 PM:
-
Thanks
vvcephei commented on a change in pull request #11926:
URL: https://github.com/apache/kafka/pull/11926#discussion_r833701992
##
File path: build.gradle
##
@@ -207,7 +207,7 @@ if (file('.git').exists()) {
} else {
rat.enabled = false
}
-println("Starting build with version
[
https://issues.apache.org/jira/browse/KAFKA-13404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17511487#comment-17511487
]
Chris Egerton commented on KAFKA-13404:
---
Thanks [~yujhe.li]. Agreed that an ideal fix for this
C0urante commented on pull request #11869:
URL: https://github.com/apache/kafka/pull/11869#issuecomment-1076799542
@showuon @mimaison would either of you have time for this? Might be worth
trying to include in the 3.2.0 release if we're still considering
non-regressions.
--
This is an
kkonstantine commented on pull request #11933:
URL: https://github.com/apache/kafka/pull/11933#issuecomment-1076781304
Thanks @rhauch. I've incorporated your suggestions in all places. The PR is
ready for another pass
--
This is an automated message from the Apache Git Service.
To
C0urante commented on pull request #10367:
URL: https://github.com/apache/kafka/pull/10367#issuecomment-107650
Thanks @showuon. In that case, I can file separate issues for a lot of the
comments I've made here, and we can try to keep this PR as focused as possible
for the sake of
yyu1993 commented on a change in pull request #11939:
URL: https://github.com/apache/kafka/pull/11939#discussion_r833676286
##
File path:
log4j-appender/src/main/java/org/apache/kafka/log4jappender/KafkaLog4jAppender.java
##
@@ -290,6 +291,7 @@ public void activateOptions() {
ijuma commented on a change in pull request #11939:
URL: https://github.com/apache/kafka/pull/11939#discussion_r833658737
##
File path:
log4j-appender/src/main/java/org/apache/kafka/log4jappender/KafkaLog4jAppender.java
##
@@ -290,6 +291,7 @@ public void activateOptions() {
[
https://issues.apache.org/jira/browse/KAFKA-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17511452#comment-17511452
]
Yang Yu commented on KAFKA-13761:
-
Hi [~ijuma] , I have a PR for disabling idemptence, could you review?
rhauch commented on a change in pull request #11933:
URL: https://github.com/apache/kafka/pull/11933#discussion_r833637529
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java
##
@@ -648,6 +648,12 @@ private WorkerTask
[
https://issues.apache.org/jira/browse/KAFKA-13758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17511447#comment-17511447
]
Sree Vaddi commented on KAFKA-13758:
Work Around:
- restart the broker node. ({*}tried and
vvcephei merged pull request #11938:
URL: https://github.com/apache/kafka/pull/11938
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
kkonstantine commented on pull request #11933:
URL: https://github.com/apache/kafka/pull/11933#issuecomment-1076612664
Tests passed on the latest run with a couple of failures that don't seem
relevant. Yet, because one failure was on `SourceConnectorsIntegrationTest` I'm
rerunning these
yyu1993 opened a new pull request #11939:
URL: https://github.com/apache/kafka/pull/11939
When a log entry is appended to a Kafka topic using KafkaLog4jAppender, the
producer.send operation may hit a deadlock if the producer network thread also
tries to append a log at the same log level.
[
https://issues.apache.org/jira/browse/KAFKA-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17511372#comment-17511372
]
Ismael Juma commented on KAFKA-13761:
-
I suggest we do the simplest change first (disable
vvcephei opened a new pull request #11938:
URL: https://github.com/apache/kafka/pull/11938
The current README instruction for local publishing boils the ocean by
building and installing every jar in the project with both 2.12 and 2.13. While
that is some times what people want to do, they
[
https://issues.apache.org/jira/browse/KAFKA-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17511283#comment-17511283
]
Dongjin Lee commented on KAFKA-13761:
-
Hi [~yyu1993] [~showuon],
It seems like this issue is a
dongjinleekr commented on pull request #7898:
URL: https://github.com/apache/kafka/pull/7898#issuecomment-1076403226
Rebased onto the latest trunk. cc/ @edoardocomar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
[
https://issues.apache.org/jira/browse/KAFKA-9366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17511262#comment-17511262
]
Brandon Kimbrough commented on KAFKA-9366:
--
[~cadonna] did I really just see that you kicked
dengziming commented on pull request #11937:
URL: https://github.com/apache/kafka/pull/11937#issuecomment-1076372788
Maybe we can use the file in checkstyle/checkstyle.xml to force scala code
style, but this is a big change and should be done with the approval of at
least 3 PMC members. 樂
dengziming commented on pull request #11936:
URL: https://github.com/apache/kafka/pull/11936#issuecomment-1076366161
> Is this related to the failure we saw here
Sadly not, the [failure](
showuon commented on pull request #11923:
URL: https://github.com/apache/kafka/pull/11923#issuecomment-1076362860
cc @cadonna , do you want to have another look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
[
https://issues.apache.org/jira/browse/KAFKA-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17511246#comment-17511246
]
Luke Chen commented on KAFKA-13761:
---
[~ijuma] , I agree. And we should further throw exception to note
[
https://issues.apache.org/jira/browse/KAFKA-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17511236#comment-17511236
]
Ismael Juma commented on KAFKA-13761:
-
I think we probably want to disable idempotence for the log4j
cadonna commented on pull request #11920:
URL: https://github.com/apache/kafka/pull/11920#issuecomment-1076319050
@dajac @showuon: Once this PR is merged, could one of you cherry-pick it to
the 3.2 branch?
--
This is an automated message from the Apache Git Service.
To respond to the
[
https://issues.apache.org/jira/browse/KAFKA-13542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17511223#comment-17511223
]
Bruno Cadonna commented on KAFKA-13542:
---
[~lihaosky] and [~ableegoldman] do you plan to fix this
[
https://issues.apache.org/jira/browse/KAFKA-8575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17511220#comment-17511220
]
Bruno Cadonna commented on KAFKA-8575:
--
[~ableegoldman] Is this still a blocker for AK 3.2?
>
[
https://issues.apache.org/jira/browse/KAFKA-13762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kamesh updated KAFKA-13762:
---
Description:
Out of 9 brokers only 3 brokers coming up. Totally 3 VMs Each VM is having 3
brokers
We are
Kamesh created KAFKA-13762:
--
Summary: Kafka brokers are not coming up
Key: KAFKA-13762
URL: https://issues.apache.org/jira/browse/KAFKA-13762
Project: Kafka
Issue Type: Bug
Reporter:
[
https://issues.apache.org/jira/browse/KAFKA-12399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna updated KAFKA-12399:
--
Fix Version/s: 3.3.0
(was: 3.2.0)
> Deprecate Log4J Appender
>
[
https://issues.apache.org/jira/browse/KAFKA-9366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna updated KAFKA-9366:
-
Fix Version/s: 3.3.0
(was: 3.2.0)
> Upgrade log4j to log4j2
>
LiamClarkeNZ commented on a change in pull request #11920:
URL: https://github.com/apache/kafka/pull/11920#discussion_r833158538
##
File path: core/src/main/scala/kafka/server/DynamicBrokerConfig.scala
##
@@ -535,24 +539,24 @@ class DynamicBrokerConfig(private val kafkaConfig:
LiamClarkeNZ commented on a change in pull request #11920:
URL: https://github.com/apache/kafka/pull/11920#discussion_r833158352
##
File path: core/src/main/scala/kafka/server/DynamicBrokerConfig.scala
##
@@ -35,6 +35,7 @@ import org.apache.kafka.common.network.{ListenerName,
LiamClarkeNZ commented on a change in pull request #11920:
URL: https://github.com/apache/kafka/pull/11920#discussion_r833158112
##
File path: core/src/main/scala/kafka/server/DynamicBrokerConfig.scala
##
@@ -201,8 +202,11 @@ class DynamicBrokerConfig(private val kafkaConfig:
cadonna commented on a change in pull request #11760:
URL: https://github.com/apache/kafka/pull/11760#discussion_r833117940
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java
##
@@ -102,45 +108,27 @@ static int
dajac commented on a change in pull request #11920:
URL: https://github.com/apache/kafka/pull/11920#discussion_r833118468
##
File path: core/src/main/scala/kafka/server/DynamicBrokerConfig.scala
##
@@ -35,6 +35,7 @@ import org.apache.kafka.common.network.{ListenerName,
dajac opened a new pull request #11937:
URL: https://github.com/apache/kafka/pull/11937
I made a few edits to make the code style more consistent while reading that
file.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ]
LiamClarkeNZ commented on a change in pull request #11920:
URL: https://github.com/apache/kafka/pull/11920#discussion_r833094619
##
File path: core/src/main/scala/kafka/server/DynamicBrokerConfig.scala
##
@@ -201,7 +202,9 @@ class DynamicBrokerConfig(private val kafkaConfig:
LiamClarkeNZ commented on a change in pull request #11920:
URL: https://github.com/apache/kafka/pull/11920#discussion_r833089404
##
File path: core/src/main/scala/kafka/server/DynamicBrokerConfig.scala
##
@@ -535,8 +538,8 @@ class DynamicBrokerConfig(private val kafkaConfig:
LiamClarkeNZ commented on a change in pull request #11920:
URL: https://github.com/apache/kafka/pull/11920#discussion_r833080985
##
File path: core/src/main/scala/kafka/server/DynamicBrokerConfig.scala
##
@@ -201,7 +202,9 @@ class DynamicBrokerConfig(private val kafkaConfig:
LiamClarkeNZ commented on a change in pull request #11920:
URL: https://github.com/apache/kafka/pull/11920#discussion_r833080985
##
File path: core/src/main/scala/kafka/server/DynamicBrokerConfig.scala
##
@@ -201,7 +202,9 @@ class DynamicBrokerConfig(private val kafkaConfig:
LiamClarkeNZ commented on a change in pull request #11920:
URL: https://github.com/apache/kafka/pull/11920#discussion_r833080985
##
File path: core/src/main/scala/kafka/server/DynamicBrokerConfig.scala
##
@@ -201,7 +202,9 @@ class DynamicBrokerConfig(private val kafkaConfig:
LiamClarkeNZ commented on a change in pull request #11920:
URL: https://github.com/apache/kafka/pull/11920#discussion_r833080985
##
File path: core/src/main/scala/kafka/server/DynamicBrokerConfig.scala
##
@@ -201,7 +202,9 @@ class DynamicBrokerConfig(private val kafkaConfig:
[
https://issues.apache.org/jira/browse/KAFKA-13689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17511136#comment-17511136
]
RivenSun edited comment on KAFKA-13689 at 3/23/22, 10:04 AM:
-
Hi [~guozhang]
[
https://issues.apache.org/jira/browse/KAFKA-13689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17511136#comment-17511136
]
RivenSun edited comment on KAFKA-13689 at 3/23/22, 10:02 AM:
-
Hi [~guozhang]
[
https://issues.apache.org/jira/browse/KAFKA-13689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17511136#comment-17511136
]
RivenSun edited comment on KAFKA-13689 at 3/23/22, 10:01 AM:
-
Hi [~guozhang]
LiamClarkeNZ commented on pull request #11920:
URL: https://github.com/apache/kafka/pull/11920#issuecomment-1076165670
> @LiamClarkeNZ Thanks for the patch! I left a few comments below. Could you
please better explain the race condition in the description?
Definitely :) Will do so
dajac commented on a change in pull request #11920:
URL: https://github.com/apache/kafka/pull/11920#discussion_r833010111
##
File path: core/src/main/scala/kafka/server/DynamicBrokerConfig.scala
##
@@ -201,7 +202,9 @@ class DynamicBrokerConfig(private val kafkaConfig:
[
https://issues.apache.org/jira/browse/KAFKA-13689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17511136#comment-17511136
]
RivenSun commented on KAFKA-13689:
--
Hi [~guozhang] I thought about it carefully, maybe we are thinking
dajac commented on pull request #11936:
URL: https://github.com/apache/kafka/pull/11936#issuecomment-1076082992
@dengziming Is this related to the failure we saw here:
https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-11900/4/tests?
I will review the PR
showuon commented on pull request #11691:
URL: https://github.com/apache/kafka/pull/11691#issuecomment-1076036468
No, I'm not Yang Yu :)
Glad we found out the root cause!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
[
https://issues.apache.org/jira/browse/KAFKA-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17511079#comment-17511079
]
Luke Chen commented on KAFKA-13761:
---
Nice find!
> KafkaLog4jAppender deadlocks when idempotence is
1 - 100 of 111 matches
Mail list logo
