RivenSun2 commented on code in PR #12010:
URL: https://github.com/apache/kafka/pull/12010#discussion_r845759271
##
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorMakerConfigTest.java:
##
@@ -49,15 +53,15 @@ public void testClusterConfigProperties() {
EvansJahja commented on PR #12012:
URL: https://github.com/apache/kafka/pull/12012#issuecomment-1092379826
Hi @dajac, could I ask for your review on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
showuon commented on code in PR #12010:
URL: https://github.com/apache/kafka/pull/12010#discussion_r845685014
##
clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java:
##
@@ -1083,6 +1083,26 @@ public String toString() {
}
}
+public static
showuon commented on code in PR #12006:
URL: https://github.com/apache/kafka/pull/12006#discussion_r845677599
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -187,7 +187,7 @@ private void
ddrid commented on code in PR #12006:
URL: https://github.com/apache/kafka/pull/12006#discussion_r845672887
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -187,7 +187,7 @@ private void startSequencesAtBeginning(TopicPartition
dengziming commented on code in PR #11681:
URL: https://github.com/apache/kafka/pull/11681#discussion_r845640296
##
core/src/test/java/kafka/testkit/KafkaClusterTestKit.java:
##
@@ -373,13 +373,19 @@ public void startup() throws ExecutionException,
InterruptedException {
Colin McCabe created KAFKA-13807:
Summary: Ensure that we can set log.flush.interval.ms with
IncrementalAlterConfigs
Key: KAFKA-13807
URL: https://issues.apache.org/jira/browse/KAFKA-13807
Project:
tmbull commented on PR #8103:
URL: https://github.com/apache/kafka/pull/8103#issuecomment-1092308800
Is there any update on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
mjsax commented on code in PR #11896:
URL: https://github.com/apache/kafka/pull/11896#discussion_r845465254
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamWindowAggregate.java:
##
@@ -80,22 +109,54 @@ public void enableSendingOldValues() {
[
https://issues.apache.org/jira/browse/KAFKA-7509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17519199#comment-17519199
]
Matthias J. Sax commented on KAFKA-7509:
Thanks for staying on top of this. The filtering code is
[
https://issues.apache.org/jira/browse/KAFKA-9296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17519194#comment-17519194
]
Jun Rao commented on KAFKA-9296:
[~vongosling] : It would be useful to provide a bit more detail on when
ijuma opened a new pull request, #12014:
URL: https://github.com/apache/kafka/pull/12014
This regressed in ca375d8004c1 due to a typo. We need tests
for our builds. :)
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify
[
https://issues.apache.org/jira/browse/KAFKA-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17519175#comment-17519175
]
Matthias J. Sax commented on KAFKA-12909:
-
Not that _inner_ join result are still instant, even
rittikaadhikari commented on code in PR #12005:
URL: https://github.com/apache/kafka/pull/12005#discussion_r845546314
##
core/src/main/scala/kafka/server/LeaderEndPoint.scala:
##
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
[
https://issues.apache.org/jira/browse/KAFKA-13803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rittika Adhikari updated KAFKA-13803:
-
Description:
Currently, AbstractFetcherThread has a series of protected APIs which
rittikaadhikari commented on code in PR #12005:
URL: https://github.com/apache/kafka/pull/12005#discussion_r845546314
##
core/src/main/scala/kafka/server/LeaderEndPoint.scala:
##
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
[
https://issues.apache.org/jira/browse/KAFKA-7491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17519124#comment-17519124
]
Karsten Schnitter commented on KAFKA-7491:
--
Hi, this issue has not seen much action in quite
dajac commented on code in PR #12005:
URL: https://github.com/apache/kafka/pull/12005#discussion_r845478395
##
core/src/main/scala/kafka/server/LeaderEndPoint.scala:
##
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor
dajac commented on code in PR #12005:
URL: https://github.com/apache/kafka/pull/12005#discussion_r845476205
##
core/src/main/scala/kafka/server/ReplicaFetcherThread.scala:
##
@@ -213,62 +174,6 @@ class ReplicaFetcherThread(name: String,
"equal or larger than your
rittikaadhikari commented on code in PR #12005:
URL: https://github.com/apache/kafka/pull/12005#discussion_r845476760
##
core/src/main/scala/kafka/server/LeaderEndPoint.scala:
##
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
dajac commented on code in PR #12005:
URL: https://github.com/apache/kafka/pull/12005#discussion_r845476205
##
core/src/main/scala/kafka/server/ReplicaFetcherThread.scala:
##
@@ -213,62 +174,6 @@ class ReplicaFetcherThread(name: String,
"equal or larger than your
jeqo commented on PR #11999:
URL: https://github.com/apache/kafka/pull/11999#issuecomment-1092096823
cc @vvcephei
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
dajac commented on code in PR #12005:
URL: https://github.com/apache/kafka/pull/12005#discussion_r845468553
##
core/src/main/scala/kafka/server/LeaderEndPoint.scala:
##
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor
cadonna commented on PR #11681:
URL: https://github.com/apache/kafka/pull/11681#issuecomment-1092089272
@showuon @dengziming @hachikuji @dajac What is the status of this PR? This
PR would resolve a blocker for the 3.2.0 release. Would be great if we could
merge this PR as soon as possible?
dajac commented on code in PR #12005:
URL: https://github.com/apache/kafka/pull/12005#discussion_r845466834
##
core/src/main/scala/kafka/server/LeaderEndPoint.scala:
##
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor
dajac commented on code in PR #12005:
URL: https://github.com/apache/kafka/pull/12005#discussion_r845466434
##
core/src/main/scala/kafka/server/LeaderEndPoint.scala:
##
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor
[
https://issues.apache.org/jira/browse/KAFKA-13805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17519093#comment-17519093
]
Bruno Cadonna commented on KAFKA-13805:
---
[~kirktrue] Ah, got it! You are right! I updated the
[
https://issues.apache.org/jira/browse/KAFKA-13805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna updated KAFKA-13805:
--
Description:
https://nvd.nist.gov/vuln/detail/CVE-2020-36518
|Packages|Package
xvrl commented on code in PR #11998:
URL: https://github.com/apache/kafka/pull/11998#discussion_r845459993
##
core/src/test/scala/integration/kafka/server/DynamicBrokerReconfigurationTest.scala:
##
@@ -1813,14 +1812,20 @@ class TestMetricsReporter extends MetricsReporter with
cadonna opened a new pull request, #12013:
URL: https://github.com/apache/kafka/pull/12013
Just a test
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation
[
https://issues.apache.org/jira/browse/KAFKA-13805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17519087#comment-17519087
]
Kirk True edited comment on KAFKA-13805 at 4/7/22 6:37 PM:
---
[~cadonna] - Sorry
[
https://issues.apache.org/jira/browse/KAFKA-13805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17519087#comment-17519087
]
Kirk True commented on KAFKA-13805:
---
[~cadonna] - Sorry for the confusion... I was mentioning the
[
https://issues.apache.org/jira/browse/KAFKA-13805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17519082#comment-17519082
]
Bruno Cadonna commented on KAFKA-13805:
---
[~kirktrue] Under "Known Affected Software
Jose Armando Garcia Sancio created KAFKA-13806:
--
Summary: Check CRC when reading snapshots
Key: KAFKA-13806
URL: https://issues.apache.org/jira/browse/KAFKA-13806
Project: Kafka
kirktrue commented on code in PR #11998:
URL: https://github.com/apache/kafka/pull/11998#discussion_r845436714
##
core/src/test/scala/integration/kafka/server/DynamicBrokerReconfigurationTest.scala:
##
@@ -1813,14 +1812,20 @@ class TestMetricsReporter extends MetricsReporter
artemlivshits commented on code in PR #12006:
URL: https://github.com/apache/kafka/pull/12006#discussion_r845433136
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -187,7 +187,7 @@ private void
[
https://issues.apache.org/jira/browse/KAFKA-13805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17519073#comment-17519073
]
Kirk True edited comment on KAFKA-13805 at 4/7/22 6:07 PM:
---
According to
[
https://issues.apache.org/jira/browse/KAFKA-13805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17519073#comment-17519073
]
Kirk True commented on KAFKA-13805:
---
According to
[
https://issues.apache.org/jira/browse/KAFKA-13805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna updated KAFKA-13805:
--
Fix Version/s: (was: 3.1.2)
> Upgrade vulnerable dependencies march 2022
>
[
https://issues.apache.org/jira/browse/KAFKA-13805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna updated KAFKA-13805:
--
Affects Version/s: (was: 3.1.1)
> Upgrade vulnerable dependencies march 2022
>
[
https://issues.apache.org/jira/browse/KAFKA-13805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17519059#comment-17519059
]
Bruno Cadonna edited comment on KAFKA-13805 at 4/7/22 5:45 PM:
---
[
https://issues.apache.org/jira/browse/KAFKA-13805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17519059#comment-17519059
]
Bruno Cadonna commented on KAFKA-13805:
---
[~shivakumar] Are you referring to the following CVE?
[
https://issues.apache.org/jira/browse/KAFKA-13805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna updated KAFKA-13805:
--
Fix Version/s: 3.1.2
2.8.2
3.0.2
> Upgrade vulnerable
[
https://issues.apache.org/jira/browse/KAFKA-13805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna updated KAFKA-13805:
--
Priority: Blocker (was: Major)
> Upgrade vulnerable dependencies march 2022
>
[
https://issues.apache.org/jira/browse/KAFKA-13805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna updated KAFKA-13805:
--
Fix Version/s: (was: 3.0.1)
(was: 3.2.0)
[
https://issues.apache.org/jira/browse/KAFKA-13805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna updated KAFKA-13805:
--
Affects Version/s: 3.0.1
3.1.1
> Upgrade vulnerable dependencies march
[
https://issues.apache.org/jira/browse/KAFKA-8575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna updated KAFKA-8575:
-
Priority: Critical (was: Blocker)
> Investigate removing EAGER protocol & cleaning up task
[
https://issues.apache.org/jira/browse/KAFKA-8575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna updated KAFKA-8575:
-
Fix Version/s: (was: 3.2.0)
> Investigate removing EAGER protocol & cleaning up task
[
https://issues.apache.org/jira/browse/KAFKA-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xavier Léauté updated KAFKA-6204:
-
Fix Version/s: 3.3.0
(was: 3.2.0)
> Interceptor and MetricsReporter
[
https://issues.apache.org/jira/browse/KAFKA-13805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shivakumar updated KAFKA-13805:
---
Description:
|Packages|Package Version|CVSS|Fix Status|
Shivakumar created KAFKA-13805:
--
Summary: Upgrade vulnerable dependencies march 2022
Key: KAFKA-13805
URL: https://issues.apache.org/jira/browse/KAFKA-13805
Project: Kafka
Issue Type: Bug
ddrid commented on code in PR #12006:
URL: https://github.com/apache/kafka/pull/12006#discussion_r844881404
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -187,7 +187,7 @@ private void startSequencesAtBeginning(TopicPartition
[
https://issues.apache.org/jira/browse/KAFKA-13571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17518846#comment-17518846
]
Jordan Moore edited comment on KAFKA-13571 at 4/7/22 12:21 PM:
---
Please
[
https://issues.apache.org/jira/browse/KAFKA-13571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17518846#comment-17518846
]
Jordan Moore commented on KAFKA-13571:
--
It should work just fine. Please check the startup logs for
[
https://issues.apache.org/jira/browse/KAFKA-13762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17518845#comment-17518845
]
Jordan Moore commented on KAFKA-13762:
--
[~kkameshm90] Please lower the priority as it is not a
EvansJahja opened a new pull request, #12012:
URL: https://github.com/apache/kafka/pull/12012
```
Usage:
./kafka-console-consumer.sh --bootstrap-server kafka:9092 --include '.*'
--property print.topic=true
Example output:
Topic:hello.world{"msg": "abc"}
```
EvansJahja closed pull request #12011: MINOR: add print.topic property in
console consumer
URL: https://github.com/apache/kafka/pull/12011
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/KAFKA-13804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen updated KAFKA-13804:
--
Description:
Currently, when the broker hit exception, or SIGINT signal received, we will
first log
Luke Chen created KAFKA-13804:
-
Summary: Log broker shutdown reason at the end of log output
Key: KAFKA-13804
URL: https://issues.apache.org/jira/browse/KAFKA-13804
Project: Kafka
Issue Type:
EvansJahja opened a new pull request, #12011:
URL: https://github.com/apache/kafka/pull/12011
```
Usage:
./kafka-console-consumer.sh --bootstrap-server kafka:9092 --include '.*'
--property print.topic=true
Example output:
Topic:hello.world{"msg": "abc"}
```
showuon merged PR #12007:
URL: https://github.com/apache/kafka/pull/12007
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
showuon commented on PR #12007:
URL: https://github.com/apache/kafka/pull/12007#issuecomment-1091493302
Failed tests are unrelated:
```
Build / ARM /
kafka.network.ConnectionQuotasTest.testListenerConnectionRateLimitWhenActualRateAboveLimit()
```
--
This is an automated message
[
https://issues.apache.org/jira/browse/KAFKA-13793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17518732#comment-17518732
]
RivenSun commented on KAFKA-13793:
--
Hi [~showuon] , please help review PR-12010.
Thanks.
> Add
bozhao12 closed pull request #12009: MINOR: Fix method annotation
URL: https://github.com/apache/kafka/pull/12009
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
RivenSun2 commented on PR #12010:
URL: https://github.com/apache/kafka/pull/12010#issuecomment-1091397361
Hi @showuon
could you help to review the PR?
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
RivenSun2 opened a new pull request, #12010:
URL: https://github.com/apache/kafka/pull/12010
Add validators for configs that lack validators
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
bozhao12 commented on PR #12009:
URL: https://github.com/apache/kafka/pull/12009#issuecomment-1091395431
@showuon Sorry, I deleted the remote branch by mistake, I submitted a new
Pull Request. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message,
bozhao12 opened a new pull request, #12009:
URL: https://github.com/apache/kafka/pull/12009
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including
bozhao12 closed pull request #12007: MINOR: Fix method annotation
URL: https://github.com/apache/kafka/pull/12007
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
ddrid commented on code in PR #12006:
URL: https://github.com/apache/kafka/pull/12006#discussion_r844881404
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -187,7 +187,7 @@ private void startSequencesAtBeginning(TopicPartition
showuon commented on PR #11971:
URL: https://github.com/apache/kafka/pull/11971#issuecomment-1091344371
> We have found the root cause of the original issue. It was a bug in our
benchmark setup so it had nothing to do with this change in the end. We can
still keep this change as it looks
[
https://issues.apache.org/jira/browse/KAFKA-13801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot resolved KAFKA-13801.
-
Fix Version/s: 3.3.0
Reviewer: David Jacot
Assignee: Xavier Léauté
dajac merged PR #11998:
URL: https://github.com/apache/kafka/pull/11998
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-13793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17518660#comment-17518660
]
RivenSun commented on KAFKA-13793:
--
Kafka itself supports five sasl mechanisms, GSSAPI (Kerberos),
dajac commented on PR #11971:
URL: https://github.com/apache/kafka/pull/11971#issuecomment-1091191284
We have found the root cause of the original issue. It was a bug in our
benchmark setup so it had nothing to do with this change in the end. We can
still keep this change as it looks
showuon commented on PR #12008:
URL: https://github.com/apache/kafka/pull/12008#issuecomment-1091143247
@ableegoldman , please take a look. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
showuon opened a new pull request, #12008:
URL: https://github.com/apache/kafka/pull/12008
Follow up on #11490
After change:
### Committer Checklist
[
https://issues.apache.org/jira/browse/KAFKA-9296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17518617#comment-17518617
]
Von Gosling commented on KAFKA-9296:
[~junrao] Any update for this, I have received some reports from
showuon commented on PR #11490:
URL: https://github.com/apache/kafka/pull/11490#issuecomment-1091128095
> Could we move this warning to the streams/upgrade-guide.html file instead?
Agree. Will do immediately.
> I guess we should be vague about which version we'll actually
showuon merged PR #11979:
URL: https://github.com/apache/kafka/pull/11979
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
showuon commented on PR #11979:
URL: https://github.com/apache/kafka/pull/11979#issuecomment-1091125080
Failed tests are unrelated:
```
Build / ARM /
kafka.network.ConnectionQuotasTest.testListenerConnectionRateLimitWhenActualRateAboveLimit()
```
--
This is an automated message
showuon commented on code in PR #11979:
URL: https://github.com/apache/kafka/pull/11979#discussion_r844739227
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -790,7 +781,6 @@ private void
bozhao12 commented on code in PR #12007:
URL: https://github.com/apache/kafka/pull/12007#discussion_r844728993
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/SubscriptionState.java:
##
@@ -617,7 +617,7 @@ public synchronized void
83 matches
Mail list logo
