[GitHub] [kafka] dengziming commented on pull request #12053: MINOR: Displaying default configs better in MetadataShell

2022-04-14 Thread GitBox
dengziming commented on PR #12053: URL: https://github.com/apache/kafka/pull/12053#issuecomment-1099869359 Change output from: ``` [ Kafka Metadata Shell ] >> ls /configs/broker >> ``` to ``` [ Kafka Metadata Shell ] >> ls /configs/broker/ >>

[GitHub] [kafka] dengziming opened a new pull request, #12053: MINOR: Displaying default configs better in MetadataShell

2022-04-14 Thread GitBox
dengziming opened a new pull request, #12053: URL: https://github.com/apache/kafka/pull/12053 *More detailed description of your change* When debugging some bugs related to configs, I find we are unable to show default broker/topic configs since the resourceName="". I changed it to

[GitHub] [kafka] showuon commented on a diff in pull request #12024: MINOR: Move some integration tests to unit tests

2022-04-14 Thread GitBox
showuon commented on code in PR #12024: URL: https://github.com/apache/kafka/pull/12024#discussion_r851035284 ## core/src/test/scala/unit/kafka/admin/ConfigCommandTest.scala: ## @@ -479,6 +460,9 @@ class ConfigCommandTest extends QuorumTestHarness with Logging {

[jira] [Commented] (KAFKA-13653) Proactively discover alive brokers from bootstrap server lists when all nodes are down

2022-04-14 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17522633#comment-17522633 ] Luke Chen commented on KAFKA-13653: --- Thanks for pointing it out, [~ijuma] , I've found the old ticket

[jira] [Resolved] (KAFKA-13653) Proactively discover alive brokers from bootstrap server lists when all nodes are down

2022-04-14 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-13653. --- Resolution: Duplicate > Proactively discover alive brokers from bootstrap server lists when all

[jira] [Assigned] (KAFKA-12495) Unbalanced connectors/tasks distribution will happen in Connect's incremental cooperative assignor

2022-04-14 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen reassigned KAFKA-12495: - Assignee: (was: Luke Chen) > Unbalanced connectors/tasks distribution will happen in

[jira] [Commented] (KAFKA-12495) Unbalanced connectors/tasks distribution will happen in Connect's incremental cooperative assignor

2022-04-14 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17522621#comment-17522621 ] Luke Chen commented on KAFKA-12495: --- I agree this is not a regression and is not a blocker for v3.2.0.

[GitHub] [kafka] RivenSun2 commented on pull request #12041: MINOR: ignore unused configuration when ConsumerCoordinator is not constructed

2022-04-14 Thread GitBox
RivenSun2 commented on PR #12041: URL: https://github.com/apache/kafka/pull/12041#issuecomment-1099797049 In other words, for a configuration (including `unknownConfig`), if neither Kafka nor the user retrieves this configuration when the KafkaClient completes initialization, the log

[GitHub] [kafka] RivenSun2 commented on pull request #12041: MINOR: ignore unused configuration when ConsumerCoordinator is not constructed

2022-04-14 Thread GitBox
RivenSun2 commented on PR #12041: URL: https://github.com/apache/kafka/pull/12041#issuecomment-1099790057 Hi @C0urante Thank you for your reply. I see what you mean. What we now expect is that a configuration is supplied but not used due to special behavior inside KafkaClient, and we

[GitHub] [kafka] dengziming commented on pull request #11522: KAFKA-13242: Ensure UpdateFeatures is properly handled in KRaft

2022-04-14 Thread GitBox
dengziming commented on PR #11522: URL: https://github.com/apache/kafka/pull/11522#issuecomment-1099784828 See #12036 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [kafka] dengziming closed pull request #11522: KAFKA-13242: Ensure UpdateFeatures is properly handled in KRaft

2022-04-14 Thread GitBox
dengziming closed pull request #11522: KAFKA-13242: Ensure UpdateFeatures is properly handled in KRaft URL: https://github.com/apache/kafka/pull/11522 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] C0urante commented on pull request #12041: MINOR: ignore unused configuration when ConsumerCoordinator is not constructed

2022-04-14 Thread GitBox
C0urante commented on PR #12041: URL: https://github.com/apache/kafka/pull/12041#issuecomment-1099784651 @RivenSun2 Isn't this a correct message to log? These properties are unused if a group ID is supplied, aren't they? That lines up pretty well with the new log message wording of

[GitHub] [kafka] C0urante commented on pull request #12041: MINOR: ignore unused configuration when ConsumerCoordinator is not constructed

2022-04-14 Thread GitBox
C0urante commented on PR #12041: URL: https://github.com/apache/kafka/pull/12041#issuecomment-1099784467 Isn't this a correct message to log? These properties are unused if a group ID is supplied, aren't they? That lines up pretty well with the new log message wording of "supplied but are

[jira] [Resolved] (KAFKA-13242) KRaft Controller doesn't handle UpdateFeaturesRequest

2022-04-14 Thread dengziming (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dengziming resolved KAFKA-13242. Resolution: Fixed > KRaft Controller doesn't handle UpdateFeaturesRequest >

[GitHub] [kafka] RivenSun2 commented on pull request #12052: KAFKA-13799: Improve documentation for Kafka zero-copy

2022-04-14 Thread GitBox
RivenSun2 commented on PR #12052: URL: https://github.com/apache/kafka/pull/12052#issuecomment-1099778447 Hi @guozhangwang could you help to review the PR? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] RivenSun2 opened a new pull request, #12052: KAFKA-13799: Improve documentation for Kafka zero-copy

2022-04-14 Thread GitBox
RivenSun2 opened a new pull request, #12052: URL: https://github.com/apache/kafka/pull/12052 Improve documentation for Kafka zero-copy. Kafka combines pagecache and zero-copy to greatly improve message consumption efficiency. But zero-copy only works in PlaintextTransportLayer.

[jira] [Comment Edited] (KAFKA-13799) Improve documentation for Kafka zero-copy

2022-04-14 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17522604#comment-17522604 ] RivenSun edited comment on KAFKA-13799 at 4/15/22 1:35 AM: --- [~guozhang] 

[jira] [Comment Edited] (KAFKA-13799) Improve documentation for Kafka zero-copy

2022-04-14 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17522604#comment-17522604 ] RivenSun edited comment on KAFKA-13799 at 4/15/22 1:35 AM: --- [~guozhang] 

[jira] [Commented] (KAFKA-13799) Improve documentation for Kafka zero-copy

2022-04-14 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17522604#comment-17522604 ] RivenSun commented on KAFKA-13799: -- [~guozhang]  Thanks for your reply. Later  I will create a minor

[jira] [Updated] (KAFKA-13773) Data loss after recovery from crash due to full hard disk

2022-04-14 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-13773: -- Priority: Critical (was: Major) > Data loss after recovery from crash due to full hard disk

[jira] [Updated] (KAFKA-13773) Data loss after recovery from crash due to full hard disk

2022-04-14 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-13773: -- Component/s: log (was: log cleaner) > Data loss after recovery from

[jira] [Commented] (KAFKA-13799) Improve documentation for Kafka zero-copy

2022-04-14 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17522601#comment-17522601 ] Guozhang Wang commented on KAFKA-13799: --- [~RivenSun] I agree with you assessment. We can update

[GitHub] [kafka] RivenSun2 commented on pull request #12048: MINOR: Remove redundant conditional judgments in Selector.clear()

2022-04-14 Thread GitBox
RivenSun2 commented on PR #12048: URL: https://github.com/apache/kafka/pull/12048#issuecomment-1099744951 Ok ,thanks a lot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [kafka] guozhangwang commented on pull request #12048: MINOR: Remove redundant conditional judgments in Selector.clear()

2022-04-14 Thread GitBox
guozhangwang commented on PR #12048: URL: https://github.com/apache/kafka/pull/12048#issuecomment-1099744235 I think just removing it is fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] RivenSun2 commented on pull request #12048: MINOR: Remove redundant conditional judgments in Selector.clear()

2022-04-14 Thread GitBox
RivenSun2 commented on PR #12048: URL: https://github.com/apache/kafka/pull/12048#issuecomment-1099743628 @guozhangwang Sorry, I originally wanted to resubmit an edit, it might be easier to read and understand. `if (sendFailed || !hasPending)` WDYT? Thanks. -- This is an

[GitHub] [kafka] guozhangwang commented on pull request #12041: MINOR: ignore unused configuration when ConsumerCoordinator is not constructed

2022-04-14 Thread GitBox
guozhangwang commented on PR #12041: URL: https://github.com/apache/kafka/pull/12041#issuecomment-1099741042 LGTM. Merged to trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] guozhangwang merged pull request #12041: MINOR: ignore unused configuration when ConsumerCoordinator is not constructed

2022-04-14 Thread GitBox
guozhangwang merged PR #12041: URL: https://github.com/apache/kafka/pull/12041 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] RivenSun2 commented on pull request #12048: MINOR: Remove redundant conditional judgments in Selector.clear()

2022-04-14 Thread GitBox
RivenSun2 commented on PR #12048: URL: https://github.com/apache/kafka/pull/12048#issuecomment-1099740076 Thanks, i just deleted my last comment, because it's wrong. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] guozhangwang commented on pull request #12030: KAFKA-13785: [5/N][emit final] cache for time ordered window store

2022-04-14 Thread GitBox
guozhangwang commented on PR #12030: URL: https://github.com/apache/kafka/pull/12030#issuecomment-1099739916 @lihaosky The jenkins build failed on the following: ```

[GitHub] [kafka] guozhangwang commented on pull request #12030: KAFKA-13785: [5/N][emit final] cache for time ordered window store

2022-04-14 Thread GitBox
guozhangwang commented on PR #12030: URL: https://github.com/apache/kafka/pull/12030#issuecomment-1099739650 Re-triggered jenkins, will merge if we can have a green build. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12030: KAFKA-13785: [5/N][emit final] cache for time ordered window store

2022-04-14 Thread GitBox
guozhangwang commented on code in PR #12030: URL: https://github.com/apache/kafka/pull/12030#discussion_r850922180 ## streams/src/main/java/org/apache/kafka/streams/state/internals/TimeOrderedCachingWindowStore.java: ## @@ -0,0 +1,694 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] guozhangwang merged pull request #12048: MINOR: Remove redundant conditional judgments in Selector.clear()

2022-04-14 Thread GitBox
guozhangwang merged PR #12048: URL: https://github.com/apache/kafka/pull/12048 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] guozhangwang commented on pull request #12048: MINOR: Remove redundant conditional judgments in Selector.clear()

2022-04-14 Thread GitBox
guozhangwang commented on PR #12048: URL: https://github.com/apache/kafka/pull/12048#issuecomment-1099739013 > There may be a problem with the logic of this code, missing a case: > when `sendFailed` is true, `doClose` should also be executed. I see what you mean now. I think it's

[GitHub] [kafka] cmccabe commented on a diff in pull request #12033: KAFKA-13807: Fix incrementalAlterConfig and refactor some things

2022-04-14 Thread GitBox
cmccabe commented on code in PR #12033: URL: https://github.com/apache/kafka/pull/12033#discussion_r850918223 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -1602,13 +1651,21 @@ public CompletableFuture beginWritingSnapshot() { }

[GitHub] [kafka] cmccabe commented on a diff in pull request #12033: KAFKA-13807: Fix incrementalAlterConfig and refactor some things

2022-04-14 Thread GitBox
cmccabe commented on code in PR #12033: URL: https://github.com/apache/kafka/pull/12033#discussion_r850917391 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -582,16 +582,17 @@ ReplicationControlManager replicationControl() { return

[GitHub] [kafka] RivenSun2 commented on pull request #12048: MINOR: Remove redundant conditional judgments in Selector.clear()

2022-04-14 Thread GitBox
RivenSun2 commented on PR #12048: URL: https://github.com/apache/kafka/pull/12048#issuecomment-1099734098 @guozhangwang There may be a problem with the logic of this code, missing a case: when `sendFailed` is true, `doClose` should also be executed. -- This is an automated message

[GitHub] [kafka] cmccabe commented on a diff in pull request #12033: KAFKA-13807: Fix incrementalAlterConfig and refactor some things

2022-04-14 Thread GitBox
cmccabe commented on code in PR #12033: URL: https://github.com/apache/kafka/pull/12033#discussion_r850913141 ## core/src/main/scala/kafka/log/LogConfig.scala: ## @@ -473,8 +473,8 @@ object LogConfig { FlushMessagesProp -> asList( new

[GitHub] [kafka] mumrah closed pull request #11677: KAFKA-13410 Add KRaft metadata.version for KIP-778

2022-04-14 Thread GitBox
mumrah closed pull request #11677: KAFKA-13410 Add KRaft metadata.version for KIP-778 URL: https://github.com/apache/kafka/pull/11677 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] mumrah commented on pull request #11677: KAFKA-13410 Add KRaft metadata.version for KIP-778

2022-04-14 Thread GitBox
mumrah commented on PR #11677: URL: https://github.com/apache/kafka/pull/11677#issuecomment-1099729093 The `metadata.version` parts of this PR were split out into https://github.com/apache/kafka/pull/12050 -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] RivenSun2 commented on pull request #12048: MINOR: Remove redundant conditional judgments in Selector.clear()

2022-04-14 Thread GitBox
RivenSun2 commented on PR #12048: URL: https://github.com/apache/kafka/pull/12048#issuecomment-1099693054 Hi @guozhangwang yes i understand what you mean. `// Remove closed channels after all their buffered receives have been processed or if a send was requested for

[jira] [Commented] (KAFKA-8178) KafkaProducer#send(ProducerRecord,Callback) may block for up to 60 seconds

2022-04-14 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17522550#comment-17522550 ] Guozhang Wang commented on KAFKA-8178: -- I think it's fair to update the docs to explicitly state

[GitHub] [kafka] lihaosky commented on a diff in pull request #12030: KAFKA-13785: [5/N][emit final] cache for time ordered window store

2022-04-14 Thread GitBox
lihaosky commented on code in PR #12030: URL: https://github.com/apache/kafka/pull/12030#discussion_r850851250 ## streams/src/main/java/org/apache/kafka/streams/state/internals/TimeOrderedCachingWindowStore.java: ## @@ -0,0 +1,694 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12044: KAFKA-12738: implement exponential backoff for tasks

2022-04-14 Thread GitBox
guozhangwang commented on code in PR #12044: URL: https://github.com/apache/kafka/pull/12044#discussion_r850797609 ## clients/src/test/java/org/apache/kafka/common/utils/ExponentialBackoffTest.java: ## @@ -20,30 +20,42 @@ import org.junit.jupiter.api.Test; import static

[GitHub] [kafka] ehumber commented on a diff in pull request #7283: KAFKA-8862: Use consistent exception messages for nonexistent partition

2022-04-14 Thread GitBox
ehumber commented on code in PR #7283: URL: https://github.com/apache/kafka/pull/7283#discussion_r850798257 ## clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java: ## @@ -1053,6 +1048,14 @@ private ClusterAndWaitTime waitOnMetadata(String topic, Integer

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12030: KAFKA-13785: [5/N][emit final] cache for time ordered window store

2022-04-14 Thread GitBox
guozhangwang commented on code in PR #12030: URL: https://github.com/apache/kafka/pull/12030#discussion_r850788768 ## streams/src/main/java/org/apache/kafka/streams/state/internals/PrefixedWindowKeySchemas.java: ## @@ -34,13 +34,17 @@ public class PrefixedWindowKeySchemas {

[GitHub] [kafka] cadonna merged pull request #12051: MINOR: Update LICENSE-binary

2022-04-14 Thread GitBox
cadonna merged PR #12051: URL: https://github.com/apache/kafka/pull/12051 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] cadonna opened a new pull request, #12051: MINOR: Update LICENSE-binary

2022-04-14 Thread GitBox
cadonna opened a new pull request, #12051: URL: https://github.com/apache/kafka/pull/12051 Updates the license file. Validate with `./gradlewAll releaseTarGz` `tar xf core/build/distributions/kafka_2.13-3.3.0-SNAPSHOT.tgz` `cd xf kafka_2.13-3.3.0-SNAPSHOT` `for f in

[jira] [Updated] (KAFKA-12622) Automate LICENSE file validation

2022-04-14 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-12622: -- Fix Version/s: 3.3.0 (was: 3.2.0) > Automate LICENSE file validation >

[jira] [Updated] (KAFKA-8391) Flaky Test RebalanceSourceConnectorsIntegrationTest#testDeleteConnector

2022-04-14 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-8391: - Priority: Critical (was: Blocker) > Flaky Test

[jira] [Updated] (KAFKA-12283) Flaky Test RebalanceSourceConnectorsIntegrationTest#testMultipleWorkersRejoining

2022-04-14 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-12283: -- Fix Version/s: (was: 3.2.0) > Flaky Test >

[jira] [Updated] (KAFKA-8391) Flaky Test RebalanceSourceConnectorsIntegrationTest#testDeleteConnector

2022-04-14 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-8391: - Fix Version/s: (was: 3.2.0) > Flaky Test

[jira] [Updated] (KAFKA-12283) Flaky Test RebalanceSourceConnectorsIntegrationTest#testMultipleWorkersRejoining

2022-04-14 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-12283: -- Priority: Critical (was: Blocker) > Flaky Test >

[GitHub] [kafka] gitlw commented on a diff in pull request #12029: KAFKA-13815: Avoid reinitialization for a replica that is being deleted

2022-04-14 Thread GitBox
gitlw commented on code in PR #12029: URL: https://github.com/apache/kafka/pull/12029#discussion_r850757573 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -2615,7 +2615,10 @@ class ReplicaManagerTest { @Test def

[jira] [Updated] (KAFKA-12495) Unbalanced connectors/tasks distribution will happen in Connect's incremental cooperative assignor

2022-04-14 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-12495: -- Priority: Critical (was: Blocker) > Unbalanced connectors/tasks distribution will happen in

[jira] [Updated] (KAFKA-12495) Unbalanced connectors/tasks distribution will happen in Connect's incremental cooperative assignor

2022-04-14 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-12495: -- Fix Version/s: (was: 3.2.0) > Unbalanced connectors/tasks distribution will happen in

[GitHub] [kafka] mumrah opened a new pull request, #12050: KAFKA-13830 Introduce metadata.version for KRaft

2022-04-14 Thread GitBox
mumrah opened a new pull request, #12050: URL: https://github.com/apache/kafka/pull/12050 This patch includes a new metadata.version which is planned to replace IBP in KRaft clusters. The kafka-storage tool now allows a user to specify a specific metadata.version to bootstrap into the

[jira] [Comment Edited] (KAFKA-12909) Allow users to opt-into spurious left/outer stream-stream join improvement

2022-04-14 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17522502#comment-17522502 ] Matthias J. Sax edited comment on KAFKA-12909 at 4/14/22 7:12 PM: --

[jira] [Commented] (KAFKA-12909) Allow users to opt-into spurious left/outer stream-stream join improvement

2022-04-14 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17522502#comment-17522502 ] Matthias J. Sax commented on KAFKA-12909: - {quote}It makes sense but it is still kind of hard to

[jira] [Created] (KAFKA-13830) Introduce metadata.version in KRaft

2022-04-14 Thread David Arthur (Jira)
David Arthur created KAFKA-13830: Summary: Introduce metadata.version in KRaft Key: KAFKA-13830 URL: https://issues.apache.org/jira/browse/KAFKA-13830 Project: Kafka Issue Type: Sub-task

[jira] [Resolved] (KAFKA-13823) Remove "max" version level from finalized features

2022-04-14 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur resolved KAFKA-13823. -- Fix Version/s: 3.3.0 Resolution: Fixed > Remove "max" version level from finalized

[GitHub] [kafka] lihaosky commented on a diff in pull request #12030: KAFKA-13785: [5/N][emit final] cache for time ordered window store

2022-04-14 Thread GitBox
lihaosky commented on code in PR #12030: URL: https://github.com/apache/kafka/pull/12030#discussion_r850689043 ## streams/src/main/java/org/apache/kafka/streams/state/internals/TimeOrderedCachingWindowStore.java: ## @@ -0,0 +1,694 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (KAFKA-12495) Unbalanced connectors/tasks distribution will happen in Connect's incremental cooperative assignor

2022-04-14 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17522472#comment-17522472 ] Chris Egerton commented on KAFKA-12495: --- I believe the risks of rebalance storms are being

[GitHub] [kafka] junrao commented on a diff in pull request #12029: KAFKA-13815: Avoid reinitialization for a replica that is being deleted

2022-04-14 Thread GitBox
junrao commented on code in PR #12029: URL: https://github.com/apache/kafka/pull/12029#discussion_r850679270 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -2615,7 +2615,10 @@ class ReplicaManagerTest { @Test def

[jira] [Commented] (KAFKA-12495) Unbalanced connectors/tasks distribution will happen in Connect's incremental cooperative assignor

2022-04-14 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17522464#comment-17522464 ] Konstantine Karantasis commented on KAFKA-12495: With respect to release logistics, I

[GitHub] [kafka] wcarlson5 commented on a diff in pull request #12044: KAFKA-12738: implement exponential backoff for tasks

2022-04-14 Thread GitBox
wcarlson5 commented on code in PR #12044: URL: https://github.com/apache/kafka/pull/12044#discussion_r849921212 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskExecutor.java: ## @@ -223,15 +227,15 @@ void commitOffsetsOrTransaction(final Map

[GitHub] [kafka] gitlw commented on a diff in pull request #12029: KAFKA-13815: Avoid reinitialization for a replica that is being deleted

2022-04-14 Thread GitBox
gitlw commented on code in PR #12029: URL: https://github.com/apache/kafka/pull/12029#discussion_r850665758 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -573,9 +576,14 @@ class UnifiedLog(@volatile var logStartOffset: Long, case None => if

[GitHub] [kafka] gitlw commented on a diff in pull request #12029: KAFKA-13815: Avoid reinitialization for a replica that is being deleted

2022-04-14 Thread GitBox
gitlw commented on code in PR #12029: URL: https://github.com/apache/kafka/pull/12029#discussion_r850665085 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -2615,7 +2615,10 @@ class ReplicaManagerTest { @Test def

[GitHub] [kafka] artemlivshits commented on a diff in pull request #12049: KAFKA-10888: Sticky partition leads to uneven produce msg

2022-04-14 Thread GitBox
artemlivshits commented on code in PR #12049: URL: https://github.com/apache/kafka/pull/12049#discussion_r850625357 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/ProducerBatch.java: ## @@ -103,7 +103,18 @@ public ProducerBatch(TopicPartition tp,

[GitHub] [kafka] gitlw commented on a diff in pull request #12029: KAFKA-13815: Avoid reinitialization for a replica that is being deleted

2022-04-14 Thread GitBox
gitlw commented on code in PR #12029: URL: https://github.com/apache/kafka/pull/12029#discussion_r850657561 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -2615,7 +2615,10 @@ class ReplicaManagerTest { @Test def

[GitHub] [kafka] gitlw commented on a diff in pull request #12029: KAFKA-13815: Avoid reinitialization for a replica that is being deleted

2022-04-14 Thread GitBox
gitlw commented on code in PR #12029: URL: https://github.com/apache/kafka/pull/12029#discussion_r850657561 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -2615,7 +2615,10 @@ class ReplicaManagerTest { @Test def

[GitHub] [kafka] Gerrrr commented on a diff in pull request #11945: KAFKA-13769: Explicitly route FK join results to correct partitions

2022-04-14 Thread GitBox
Ge commented on code in PR #11945: URL: https://github.com/apache/kafka/pull/11945#discussion_r850656607 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionResponseWrapper.java: ## @@ -21,22 +21,30 @@ import java.util.Arrays;

[GitHub] [kafka] Gerrrr commented on a diff in pull request #11945: KAFKA-13769: Explicitly route FK join results to correct partitions

2022-04-14 Thread GitBox
Ge commented on code in PR #11945: URL: https://github.com/apache/kafka/pull/11945#discussion_r850656191 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionWrapperSerde.java: ## @@ -141,17 +204,29 @@ public SubscriptionWrapper

[GitHub] [kafka] Gerrrr commented on a diff in pull request #11945: KAFKA-13769: Explicitly route FK join results to correct partitions

2022-04-14 Thread GitBox
Ge commented on code in PR #11945: URL: https://github.com/apache/kafka/pull/11945#discussion_r850653002 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionWrapper.java: ## @@ -23,12 +23,15 @@ public class SubscriptionWrapper

[GitHub] [kafka] Gerrrr commented on a diff in pull request #11945: KAFKA-13769: Explicitly route FK join results to correct partitions

2022-04-14 Thread GitBox
Ge commented on code in PR #11945: URL: https://github.com/apache/kafka/pull/11945#discussion_r850652693 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionResponseWrapper.java: ## @@ -21,22 +21,30 @@ import java.util.Arrays;

[GitHub] [kafka] junrao commented on a diff in pull request #10826: KAFKA-7632: Support Compression Level

2022-04-14 Thread GitBox
junrao commented on code in PR #10826: URL: https://github.com/apache/kafka/pull/10826#discussion_r849786048 ## clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java: ## @@ -523,6 +532,45 @@ boolean idempotenceEnabled() { return

[GitHub] [kafka] cmccabe commented on pull request #12036: KAFKA-13823 Feature flag changes from KIP-778

2022-04-14 Thread GitBox
cmccabe commented on PR #12036: URL: https://github.com/apache/kafka/pull/12036#issuecomment-1099415675 Thanks, @mumrah. Committed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] cmccabe merged pull request #12036: KAFKA-13823 Feature flag changes from KIP-778

2022-04-14 Thread GitBox
cmccabe merged PR #12036: URL: https://github.com/apache/kafka/pull/12036 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] artemlivshits opened a new pull request, #12049: KAFKA-10888: Sticky partition leads to uneven produce msg

2022-04-14 Thread GitBox
artemlivshits opened a new pull request, #12049: URL: https://github.com/apache/kafka/pull/12049 The design is described in detail in KIP-794 https://cwiki.apache.org/confluence/display/KAFKA/KIP-794%3A+Strictly+Uniform+Sticky+Partitioner. Implementation notes: The default

[GitHub] [kafka] ijuma commented on a diff in pull request #10826: KAFKA-7632: Support Compression Level

2022-04-14 Thread GitBox
ijuma commented on code in PR #10826: URL: https://github.com/apache/kafka/pull/10826#discussion_r850515974 ## clients/src/main/java/org/apache/kafka/common/compress/KafkaLZ4BlockOutputStream.java: ## @@ -41,6 +41,10 @@ public final class KafkaLZ4BlockOutputStream extends

[GitHub] [kafka] ijuma commented on a diff in pull request #10826: KAFKA-7632: Support Compression Level

2022-04-14 Thread GitBox
ijuma commented on code in PR #10826: URL: https://github.com/apache/kafka/pull/10826#discussion_r850514430 ## clients/src/main/java/org/apache/kafka/common/compress/GzipOutputStream.java: ## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] ijuma commented on a diff in pull request #10826: KAFKA-7632: Support Compression Level

2022-04-14 Thread GitBox
ijuma commented on code in PR #10826: URL: https://github.com/apache/kafka/pull/10826#discussion_r850511813 ## clients/src/main/java/org/apache/kafka/common/compress/GzipOutputStream.java: ## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] ijuma commented on a diff in pull request #10826: KAFKA-7632: Support Compression Level

2022-04-14 Thread GitBox
ijuma commented on code in PR #10826: URL: https://github.com/apache/kafka/pull/10826#discussion_r850510536 ## clients/src/main/java/org/apache/kafka/common/compress/GzipConfig.java: ## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [kafka] ijuma commented on a diff in pull request #10826: KAFKA-7632: Support Compression Level

2022-04-14 Thread GitBox
ijuma commented on code in PR #10826: URL: https://github.com/apache/kafka/pull/10826#discussion_r850509560 ## clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java: ## @@ -523,6 +532,45 @@ boolean idempotenceEnabled() { return

[GitHub] [kafka] ijuma commented on a diff in pull request #10826: KAFKA-7632: Support Compression Level

2022-04-14 Thread GitBox
ijuma commented on code in PR #10826: URL: https://github.com/apache/kafka/pull/10826#discussion_r850506417 ## clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java: ## @@ -188,6 +190,12 @@ public class ProducerConfig extends AbstractConfig {

[GitHub] [kafka] ijuma commented on pull request #10826: KAFKA-7632: Support Compression Level

2022-04-14 Thread GitBox
ijuma commented on PR #10826: URL: https://github.com/apache/kafka/pull/10826#issuecomment-1099245217 @mimaison yeah, I just edited my message. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] mimaison commented on pull request #10826: KAFKA-7632: Support Compression Level

2022-04-14 Thread GitBox
mimaison commented on PR #10826: URL: https://github.com/apache/kafka/pull/10826#issuecomment-1099244913 As far as I can tell this is implementing KIP-390 and it received 3 binding votes: https://lists.apache.org/thread/wnd6ky3kjzv9gkzc39qy5gg2pp20ovs1 -- This is an automated message

[GitHub] [kafka] ijuma commented on pull request #10826: KAFKA-7632: Support Compression Level

2022-04-14 Thread GitBox
ijuma commented on PR #10826: URL: https://github.com/apache/kafka/pull/10826#issuecomment-1099240705 @mimaison fyi, I think we need more votes in the KIP thread. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] mimaison commented on a diff in pull request #10826: KAFKA-7632: Support Compression Level

2022-04-14 Thread GitBox
mimaison commented on code in PR #10826: URL: https://github.com/apache/kafka/pull/10826#discussion_r850466685 ## clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java: ## @@ -188,6 +190,12 @@ public class ProducerConfig extends AbstractConfig {

[jira] [Commented] (KAFKA-12495) Unbalanced connectors/tasks distribution will happen in Connect's incremental cooperative assignor

2022-04-14 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17522328#comment-17522328 ] Bruno Cadonna commented on KAFKA-12495: --- [~showuon] [~ChrisEgerton] [~kkonstantine] Is this a

[jira] [Updated] (KAFKA-13827) Data Loss on moving to KRAFT mode from v3.1

2022-04-14 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-13827: - Component/s: kraft > Data Loss on moving to KRAFT mode from v3.1 >

[jira] [Commented] (KAFKA-13827) Data Loss on moving to KRAFT mode from v3.1

2022-04-14 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17522327#comment-17522327 ] David Arthur commented on KAFKA-13827: -- [~gargsha] by "v2.8/v3.1", do you mean you were running IBP

[jira] [Commented] (KAFKA-13653) Proactively discover alive brokers from bootstrap server lists when all nodes are down

2022-04-14 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17522326#comment-17522326 ] Ismael Juma commented on KAFKA-13653: - This is a long-standing issue and there's already a Jira for

[GitHub] [kafka] ijuma commented on a diff in pull request #7283: KAFKA-8862: Use consistent exception messages for nonexistent partition

2022-04-14 Thread GitBox
ijuma commented on code in PR #7283: URL: https://github.com/apache/kafka/pull/7283#discussion_r850457061 ## clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java: ## @@ -1032,18 +1032,13 @@ private ClusterAndWaitTime waitOnMetadata(String topic, Integer

[GitHub] [kafka] ijuma commented on a diff in pull request #7283: KAFKA-8862: Use consistent exception messages for nonexistent partition

2022-04-14 Thread GitBox
ijuma commented on code in PR #7283: URL: https://github.com/apache/kafka/pull/7283#discussion_r850452641 ## clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java: ## @@ -1053,6 +1048,14 @@ private ClusterAndWaitTime waitOnMetadata(String topic, Integer

[GitHub] [kafka] showuon commented on pull request #10367: KAFKA-12495: allow consecutive revoke in incremental cooperative assignor in connector

2022-04-14 Thread GitBox
showuon commented on PR #10367: URL: https://github.com/apache/kafka/pull/10367#issuecomment-1099185348 My comment is put in [jira ticket](https://issues.apache.org/jira/browse/KAFKA-12495). Thanks. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] cadonna commented on pull request #10367: KAFKA-12495: allow consecutive revoke in incremental cooperative assignor in connector

2022-04-14 Thread GitBox
cadonna commented on PR #10367: URL: https://github.com/apache/kafka/pull/10367#issuecomment-1099159615 @kkonstantine Thank you for your thoughts! From a 3.2.0 release perspective your proposal seems to be a change that we should postpone to a later release since feature freeze and code

[jira] [Commented] (KAFKA-13829) The function of max.in.flight.requests.per.connection parameter does not work, it conflicts with the underlying NIO sending data

2022-04-14 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17522282#comment-17522282 ] RivenSun commented on KAFKA-13829: -- > we are saying that we can send the subsequent request without

[jira] [Comment Edited] (KAFKA-13829) The function of max.in.flight.requests.per.connection parameter does not work, it conflicts with the underlying NIO sending data

2022-04-14 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17522271#comment-17522271 ] Ismael Juma edited comment on KAFKA-13829 at 4/14/22 12:26 PM: --- I think

[jira] [Commented] (KAFKA-13829) The function of max.in.flight.requests.per.connection parameter does not work, it conflicts with the underlying NIO sending data

2022-04-14 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17522271#comment-17522271 ] Ismael Juma commented on KAFKA-13829: - I think this is behaving as expected. We are not saying that

[jira] [Commented] (KAFKA-13664) log.preallocate option causes CorruptRecordException

2022-04-14 Thread Vyacheslav Ksenz (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17522215#comment-17522215 ] Vyacheslav Ksenz commented on KAFKA-13664: -- Hi! There is no reaction to ticket for two months.

  1   2   >