dajac commented on code in PR #12035:
URL: https://github.com/apache/kafka/pull/12035#discussion_r858303688
##
streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java:
##
@@ -1498,6 +1516,37 @@ public synchronized boolean close(final Duration
timeout) throws
guozhangwang commented on code in PR #12035:
URL: https://github.com/apache/kafka/pull/12035#discussion_r858263213
##
streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java:
##
@@ -1498,6 +1516,37 @@ public synchronized boolean close(final Duration
timeout) throws
[
https://issues.apache.org/jira/browse/KAFKA-13716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17527866#comment-17527866
]
Luke Chen commented on KAFKA-13716:
---
[~divijvaidya] , I saw you have another PR to address this issue:
philipnee closed pull request #12088: KAFKA-12841 bug fix and tests
URL: https://github.com/apache/kafka/pull/12088
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
[
https://issues.apache.org/jira/browse/KAFKA-13856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17527841#comment-17527841
]
Justinwins commented on KAFKA-13856:
HashMap cannot be "put" and traversed by two threads
arunmathew88 commented on PR #11438:
URL: https://github.com/apache/kafka/pull/11438#issuecomment-1109219047
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
Justinwins created KAFKA-13856:
--
Summary: MirrorCheckpointTask meets ConcurrentModificationException
Key: KAFKA-13856
URL: https://issues.apache.org/jira/browse/KAFKA-13856
Project: Kafka
Issue
dengziming commented on code in PR #12072:
URL: https://github.com/apache/kafka/pull/12072#discussion_r858159547
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersionValidator.java:
##
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation
junrao commented on code in PR #12029:
URL: https://github.com/apache/kafka/pull/12029#discussion_r858099615
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -674,21 +682,29 @@ class UnifiedLog(@volatile var logStartOffset: Long,
}
/**
- * Rename the directory
[
https://issues.apache.org/jira/browse/KAFKA-13403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17527800#comment-17527800
]
Haruki Okada commented on KAFKA-13403:
--
[~showuon] Hi, could you help reviewing the PR
[
https://issues.apache.org/jira/browse/KAFKA-13855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17527797#comment-17527797
]
Haruki Okada commented on KAFKA-13855:
--
I guess that's same cause as
junrao commented on PR #12064:
URL: https://github.com/apache/kafka/pull/12064#issuecomment-1109120987
@cadonna : Could we merge this PR to 3.2? It fixes an issue in 3.2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
junrao merged PR #12064:
URL: https://github.com/apache/kafka/pull/12064
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jsancio merged PR #11732:
URL: https://github.com/apache/kafka/pull/11732
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mt206 opened a new pull request, #12094:
URL: https://github.com/apache/kafka/pull/12094
*More detailed description of your change,
The html document generation has some errors in it, specifically related to
protocols. The two issues identified and resolved are:
- Missing ``
dajac commented on code in PR #12029:
URL: https://github.com/apache/kafka/pull/12029#discussion_r858031776
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -674,21 +682,29 @@ class UnifiedLog(@volatile var logStartOffset: Long,
}
/**
- * Rename the directory
dajac commented on code in PR #12035:
URL: https://github.com/apache/kafka/pull/12035#discussion_r858024381
##
streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java:
##
@@ -1498,6 +1516,37 @@ public synchronized boolean close(final Duration
timeout) throws
dajac commented on code in PR #12035:
URL: https://github.com/apache/kafka/pull/12035#discussion_r858019261
##
streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java:
##
@@ -1498,6 +1516,37 @@ public synchronized boolean close(final Duration
timeout) throws
ahuang98 commented on code in PR #12072:
URL: https://github.com/apache/kafka/pull/12072#discussion_r858015440
##
server-common/src/test/java/org/apache/kafka/server/common/MetadataVersionTest.java:
##
@@ -0,0 +1,361 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
dajac merged PR #12081:
URL: https://github.com/apache/kafka/pull/12081
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mumrah commented on code in PR #12072:
URL: https://github.com/apache/kafka/pull/12072#discussion_r857970386
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -0,0 +1,280 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
[
https://issues.apache.org/jira/browse/KAFKA-13716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17527730#comment-17527730
]
Richard Joerger commented on KAFKA-13716:
-
Hi Team,
I'd like to work on this particular
guozhangwang commented on PR #12041:
URL: https://github.com/apache/kafka/pull/12041#issuecomment-1108911987
@C0urante Yes I agree this is a fair question to debate on, and I personally
think that it could be very subjective --- as you can see in
guozhangwang commented on code in PR #12035:
URL: https://github.com/apache/kafka/pull/12035#discussion_r857910667
##
streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java:
##
@@ -1498,6 +1516,37 @@ public synchronized boolean close(final Duration
timeout) throws
guozhangwang commented on code in PR #12035:
URL: https://github.com/apache/kafka/pull/12035#discussion_r857908050
##
streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java:
##
@@ -1498,6 +1516,37 @@ public synchronized boolean close(final Duration
timeout) throws
[
https://issues.apache.org/jira/browse/KAFKA-13855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Ivanov updated KAFKA-13855:
--
Description:
Hello,
We faced an issue when one of Kafka broker in cluster has failed with an
Sergey Ivanov created KAFKA-13855:
-
Summary: FileNotFoundException: Error while rolling log segment
for topic partition in dir
Key: KAFKA-13855
URL: https://issues.apache.org/jira/browse/KAFKA-13855
junrao commented on code in PR #12029:
URL: https://github.com/apache/kafka/pull/12029#discussion_r857864434
##
core/src/test/scala/unit/kafka/log/UnifiedLogTest.scala:
##
@@ -3325,6 +3325,32 @@ class UnifiedLogTest {
assertEquals(1, log.numberOfSegments)
}
+ /**
+
hachikuji commented on code in PR #11951:
URL: https://github.com/apache/kafka/pull/11951#discussion_r857852045
##
core/src/main/scala/kafka/server/BrokerLifecycleManager.scala:
##
@@ -333,7 +353,11 @@ class BrokerLifecycleManager(val config: KafkaConfig,
}
private def
hachikuji merged PR #12032:
URL: https://github.com/apache/kafka/pull/12032
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ahuang98 commented on code in PR #12072:
URL: https://github.com/apache/kafka/pull/12072#discussion_r857807415
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersionValidator.java:
##
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation
C0urante commented on PR #11773:
URL: https://github.com/apache/kafka/pull/11773#issuecomment-1108752944
@tombentley @mimaison I'd really appreciate another pass if you can find the
time this week. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the
David Arthur created KAFKA-13854:
Summary: Refactor ApiVersion to MetadataVersion
Key: KAFKA-13854
URL: https://issues.apache.org/jira/browse/KAFKA-13854
Project: Kafka
Issue Type: Sub-task
mumrah commented on PR #12072:
URL: https://github.com/apache/kafka/pull/12072#issuecomment-1108659307
I fixed a conflict from `trunk` so the build could run
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
mumrah commented on code in PR #12072:
URL: https://github.com/apache/kafka/pull/12072#discussion_r857673849
##
core/src/test/scala/unit/kafka/api/ApiVersionTest.scala:
##
@@ -184,6 +184,37 @@ class ApiVersionTest {
assertEquals("3.2", KAFKA_3_2_IV0.shortVersion)
}
+
divijvaidya commented on PR #12045:
URL: https://github.com/apache/kafka/pull/12045#issuecomment-1108621881
Hey @apovzner @dajac, did you get a chance to take a look at this? Please
let me know if I can make explanation simpler or if you have any questions.
--
This is an automated
viktorsomogyi commented on code in PR #10738:
URL: https://github.com/apache/kafka/pull/10738#discussion_r857632186
##
core/src/test/scala/unit/kafka/security/token/delegation/DelegationTokenManagerTest.scala:
##
@@ -315,13 +314,20 @@ class DelegationTokenManagerTest extends
C0urante commented on code in PR #11983:
URL: https://github.com/apache/kafka/pull/11983#discussion_r857610529
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignorTest.java:
##
@@ -1375,24 +1171,6 @@ private void
viktorsomogyi commented on code in PR #10738:
URL: https://github.com/apache/kafka/pull/10738#discussion_r857571909
##
core/src/main/scala/kafka/security/authorizer/AclEntry.scala:
##
@@ -100,9 +100,10 @@ object AclEntry {
resourceType match {
case
vamossagar12 commented on PR #11211:
URL: https://github.com/apache/kafka/pull/11211#issuecomment-1108243111
@showuon i have pushed the commit as discussed. Plz review whenever you get
the chance
--
This is an automated message from the Apache Git Service.
To respond to the message,
vamossagar12 commented on code in PR #11211:
URL: https://github.com/apache/kafka/pull/11211#discussion_r857375620
##
streams/src/test/java/org/apache/kafka/streams/state/internals/AbstractDualSchemaRocksDBSegmentedBytesStoreTest.java:
##
@@ -157,43 +157,34 @@ public void
vamossagar12 commented on code in PR #11211:
URL: https://github.com/apache/kafka/pull/11211#discussion_r857375173
##
streams/src/main/java/org/apache/kafka/streams/state/internals/AbstractRocksDBSegmentedBytesStore.java:
##
@@ -234,7 +275,11 @@ public void put(final Bytes key,
divijvaidya commented on PR #12087:
URL: https://github.com/apache/kafka/pull/12087#issuecomment-1108235535
Known flaky tests failing unrelated to this change
```
Build / JDK 17 and Scala 2.13 /
shouldBootstrapTwoBrokersWithFollowerThrottle() –
kafka.server.ReplicationQuotasTest
[
https://issues.apache.org/jira/browse/KAFKA-13840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17527348#comment-17527348
]
Luke Chen commented on KAFKA-13840:
---
[~kyle.stehbens] , thanks for the reply.
If it is using
showuon commented on code in PR #11983:
URL: https://github.com/apache/kafka/pull/11983#discussion_r857284813
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignorTest.java:
##
@@ -1375,24 +1171,6 @@ private void
45 matches
Mail list logo
