[GitHub] [kafka] akhileshchg commented on a diff in pull request #12106: KAFKA-13861: Fix the validateOnly behavior for CreatePartitions requests in KRaft mode

akhileshchg commented on code in PR #12106: URL: https://github.com/apache/kafka/pull/12106#discussion_r863475611 ## metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java: ## @@ -1364,7 +1364,8 @@ Boolean isBrokerUnfenced(int brokerId) {

[GitHub] [kafka] akhileshchg commented on a diff in pull request #12106: KAFKA-13861: Fix the validateOnly behavior for CreatePartitions requests in KRaft mode

akhileshchg commented on code in PR #12106: URL: https://github.com/apache/kafka/pull/12106#discussion_r863474931 ## core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala: ## @@ -499,23 +504,28 @@ class PlaintextAdminIntegrationTest extends

[GitHub] [kafka] dengziming commented on pull request #11889: KAFKA-13667: Make listeners mandatory in kraft mode

dengziming commented on PR #11889: URL: https://github.com/apache/kafka/pull/11889#issuecomment-1115729719 @showuon Oh yeah, I think I misunderstood your intention here. Firstly I think it's weird to have a config optional for the broker node but mandatory for the controller node and

[GitHub] [kafka] C0urante commented on a diff in pull request #11983: KAFKA-13763 (2): Refactor IncrementalCooperativeAssignor for improved unit testing

C0urante commented on code in PR #11983: URL: https://github.com/apache/kafka/pull/11983#discussion_r863330742 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/ConnectProtocolCompatibilityTest.java: ## @@ -51,95 +41,58 @@ public class

[GitHub] [kafka] C0urante commented on pull request #11983: KAFKA-13763 (2): Refactor IncrementalCooperativeAssignor for improved unit testing

C0urante commented on PR #11983: URL: https://github.com/apache/kafka/pull/11983#issuecomment-1115554702 Thanks @showuon, good call with the improvement to the serialization logic. Took a bit of legwork but I've pushed a change that implements that and also cleans up some testing clutter;

[GitHub] [kafka] C0urante commented on a diff in pull request #11983: KAFKA-13763 (2): Refactor IncrementalCooperativeAssignor for improved unit testing

C0urante commented on code in PR #11983: URL: https://github.com/apache/kafka/pull/11983#discussion_r863330276 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java: ## @@ -336,13 +332,16 @@ ClusterAssignment

[GitHub] [kafka] C0urante commented on a diff in pull request #11983: KAFKA-13763 (2): Refactor IncrementalCooperativeAssignor for improved unit testing

C0urante commented on code in PR #11983: URL: https://github.com/apache/kafka/pull/11983#discussion_r863330276 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java: ## @@ -336,13 +332,16 @@ ClusterAssignment

[GitHub] [kafka] C0urante commented on a diff in pull request #11983: KAFKA-13763 (2): Refactor IncrementalCooperativeAssignor for improved unit testing

C0urante commented on code in PR #11983: URL: https://github.com/apache/kafka/pull/11983#discussion_r863329552 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeConnectProtocol.java: ## @@ -230,15 +230,16 @@ public static

[jira] [Commented] (KAFKA-13859) SCRAM authentication issues with kafka-clients 3.0.1

[ https://issues.apache.org/jira/browse/KAFKA-13859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17531010#comment-17531010 ] Luke Chen commented on KAFKA-13859: --- [~opayne] , thanks for the response. That confirmed our

[GitHub] [kafka] showuon commented on pull request #12105: KAFKA-13859: Disable idempotence on SCRAM authentication

showuon commented on PR #12105: URL: https://github.com/apache/kafka/pull/12105#issuecomment-1115548710 > To be clear, the broker would have to be older than 2.8 for the issue to occur. The server change for KIP-679 happened in Apache Kafka 2.8. Yes, the user confirmed that their

[GitHub] [kafka] showuon commented on a diff in pull request #11983: KAFKA-13763 (2): Refactor IncrementalCooperativeAssignor for improved unit testing

showuon commented on code in PR #11983: URL: https://github.com/apache/kafka/pull/11983#discussion_r863325064 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java: ## @@ -336,13 +332,16 @@ ClusterAssignment

[GitHub] [kafka] C0urante commented on a diff in pull request #11983: KAFKA-13763 (2): Refactor IncrementalCooperativeAssignor for improved unit testing

C0urante commented on code in PR #11983: URL: https://github.com/apache/kafka/pull/11983#discussion_r863308185 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java: ## @@ -108,18 +107,15 @@ public Map

[GitHub] [kafka] C0urante commented on a diff in pull request #11983: KAFKA-13763 (2): Refactor IncrementalCooperativeAssignor for improved unit testing

C0urante commented on code in PR #11983: URL: https://github.com/apache/kafka/pull/11983#discussion_r863308048 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java: ## @@ -336,13 +332,16 @@ ClusterAssignment

[GitHub] [kafka] C0urante commented on pull request #12041: MINOR: ignore unused configuration when ConsumerCoordinator is not constructed

C0urante commented on PR #12041: URL: https://github.com/apache/kafka/pull/12041#issuecomment-1115515896 Thanks Guozhang. I think the cost of logging warnings in cases like this is fairly low as users can and should adjust their configurations to not use nonsensical properties, and the

[jira] [Commented] (KAFKA-13857) The listOffsets method of KafkaAdminClient should support returning logEndOffset of topicPartition

[ https://issues.apache.org/jira/browse/KAFKA-13857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17531003#comment-17531003 ] RivenSun commented on KAFKA-13857: -- [~guozhang] Thank you for your reply and approval. I don't have a

[GitHub] [kafka] LeonSamuel opened a new pull request, #12115: Update README.md

LeonSamuel opened a new pull request, #12115: URL: https://github.com/apache/kafka/pull/12115 As someone new to Kafka, it would have been welcoming to see a succinct high-level overview of what Kafka is as the first piece of documentation. As I clicked on the home page of Kafka website, I

[GitHub] [kafka] hachikuji commented on a diff in pull request #12106: KAFKA-13861: Fix the validateOnly behavior for CreatePartitions requests in KRaft mode

hachikuji commented on code in PR #12106: URL: https://github.com/apache/kafka/pull/12106#discussion_r863259182 ## core/src/test/scala/unit/kafka/server/ControllerApisTest.scala: ## @@ -730,8 +729,45 @@ class ControllerApisTest { request.topics().add(new

[jira] [Commented] (KAFKA-13867) Improve JavaDoc for MetadataVersion.java

[ https://issues.apache.org/jira/browse/KAFKA-13867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530971#comment-17530971 ] Alyssa Huang commented on KAFKA-13867: -- ^ just confirming that you mean

[GitHub] [kafka] cmccabe commented on pull request #12072: KAFKA-13854 Refactor ApiVersion to MetadataVersion

cmccabe commented on PR #12072: URL: https://github.com/apache/kafka/pull/12072#issuecomment-1115466993 Thanks for this PR, @ahuang98. And thanks to everyone who reviewed. I filed https://issues.apache.org/jira/browse/KAFKA-13867 for two very minor issues that we discussed here (one

[jira] [Commented] (KAFKA-13867) Improve JavaDoc for MetadataVersion.java

[ https://issues.apache.org/jira/browse/KAFKA-13867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530969#comment-17530969 ] Colin McCabe commented on KAFKA-13867: -- I also suggest renaming `MetadataVersion#version` to

[jira] [Created] (KAFKA-13867) Improve JavaDoc for MetadataVersion.java

Colin McCabe created KAFKA-13867: Summary: Improve JavaDoc for MetadataVersion.java Key: KAFKA-13867 URL: https://issues.apache.org/jira/browse/KAFKA-13867 Project: Kafka Issue Type:

[GitHub] [kafka] cmccabe commented on a diff in pull request #12072: KAFKA-13854 Refactor ApiVersion to MetadataVersion

cmccabe commented on code in PR #12072: URL: https://github.com/apache/kafka/pull/12072#discussion_r863258243 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -0,0 +1,334 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] cmccabe merged pull request #12072: KAFKA-13854 Refactor ApiVersion to MetadataVersion

cmccabe merged PR #12072: URL: https://github.com/apache/kafka/pull/12072 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] cmccabe commented on a diff in pull request #12072: KAFKA-13854 Refactor ApiVersion to MetadataVersion

cmccabe commented on code in PR #12072: URL: https://github.com/apache/kafka/pull/12072#discussion_r863255928 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersionValidator.java: ## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] akhileshchg commented on a diff in pull request #12106: KAFKA-13861: Fix the validateOnly behavior for CreatePartitions requests in KRaft mode

akhileshchg commented on code in PR #12106: URL: https://github.com/apache/kafka/pull/12106#discussion_r863179905 ## core/src/test/java/kafka/test/MockController.java: ## @@ -410,10 +410,16 @@ public CompletableFuture updateFeatures( throw new

[jira] [Commented] (KAFKA-13864) Change the visibility of a KafkaProducer and KafkaConsumer constructor

[ https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530937#comment-17530937 ] François Rosière commented on KAFKA-13864: -- [~cadonna], table updated and discussion started.

[jira] [Comment Edited] (KAFKA-13864) Change the visibility of a KafkaProducer and KafkaConsumer constructor

[ https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530937#comment-17530937 ] François Rosière edited comment on KAFKA-13864 at 5/2/22 8:44 PM: --

[GitHub] [kafka] akhileshchg commented on a diff in pull request #12106: KAFKA-13861: Fix the validateOnly behavior for CreatePartitions requests in KRaft mode

akhileshchg commented on code in PR #12106: URL: https://github.com/apache/kafka/pull/12106#discussion_r863095080 ## core/src/test/java/kafka/test/MockController.java: ## @@ -410,10 +410,16 @@ public CompletableFuture updateFeatures( throw new

[jira] [Updated] (KAFKA-13636) Committed offsets could be deleted during a rebalance if a group did not commit for a while

[ https://issues.apache.org/jira/browse/KAFKA-13636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Olson updated KAFKA-13636: - Description: The group coordinator might delete invalid offsets during a group rebalance.

[GitHub] [kafka] cadonna commented on a diff in pull request #12114: MINOR: Note that slf4j-log4j in version 1.7.35+ should be used

cadonna commented on code in PR #12114: URL: https://github.com/apache/kafka/pull/12114#discussion_r863082871 ## docs/upgrade.html: ## @@ -73,7 +73,11 @@ Notable changes in 3 via Connect worker and/or connector configuration. Connect may enable idempotent

[jira] [Created] (KAFKA-13866) Support more advanced time retention policies

Matthias J. Sax created KAFKA-13866: --- Summary: Support more advanced time retention policies Key: KAFKA-13866 URL: https://issues.apache.org/jira/browse/KAFKA-13866 Project: Kafka Issue

[GitHub] [kafka] ahuang98 commented on a diff in pull request #12072: KAFKA-13854 Refactor ApiVersion to MetadataVersion

ahuang98 commented on code in PR #12072: URL: https://github.com/apache/kafka/pull/12072#discussion_r863014438 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersionValidator.java: ## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] mimaison commented on pull request #11773: KAFKA-10000: Add new source connector APIs related to exactly-once support (KIP-618)

mimaison commented on PR #11773: URL: https://github.com/apache/kafka/pull/11773#issuecomment-1115108546 Sorry @C0urante for the delays, we were at Kafka Summit last week and I'm still trying to catch up on stuff. I'm hoping to take another look this week. -- This is an automated message

[GitHub] [kafka] mimaison commented on pull request #12067: KAFKA-13780: Generate OpenAPI file for Connect REST API

mimaison commented on PR #12067: URL: https://github.com/apache/kafka/pull/12067#issuecomment-1115103573 @kkonstantine @rhauch Can you take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] cmccabe merged pull request #12107: MINOR: fix ClientQuotasRequestTest.testAlterClientQuotasBadIp

cmccabe merged PR #12107: URL: https://github.com/apache/kafka/pull/12107 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] C0urante commented on a diff in pull request #11874: Fix typos in configuration docs

C0urante commented on code in PR #11874: URL: https://github.com/apache/kafka/pull/11874#discussion_r862970744 ## clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java: ## @@ -216,8 +216,10 @@ private static final String

[jira] [Commented] (KAFKA-13859) SCRAM authentication issues with kafka-clients 3.0.1

[ https://issues.apache.org/jira/browse/KAFKA-13859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530796#comment-17530796 ] Oliver Payne commented on KAFKA-13859: -- Sorry for the late response. I see that this has already

[GitHub] [kafka] ijuma commented on a diff in pull request #12114: MINOR: Note that slf4j-log4j in version 1.7.35+ should be used

ijuma commented on code in PR #12114: URL: https://github.com/apache/kafka/pull/12114#discussion_r862968313 ## docs/upgrade.html: ## @@ -73,7 +73,11 @@ Notable changes in 3 via Connect worker and/or connector configuration. Connect may enable idempotent producers

[GitHub] [kafka] ijuma commented on a diff in pull request #12114: MINOR: Note that slf4j-log4j in version 1.7.35+ should be used

ijuma commented on code in PR #12114: URL: https://github.com/apache/kafka/pull/12114#discussion_r862967880 ## docs/upgrade.html: ## @@ -73,7 +73,11 @@ Notable changes in 3 via Connect worker and/or connector configuration. Connect may enable idempotent producers

[GitHub] [kafka] C0urante commented on pull request #11773: KAFKA-10000: Add new source connector APIs related to exactly-once support (KIP-618)

C0urante commented on PR #11773: URL: https://github.com/apache/kafka/pull/11773#issuecomment-1115054516 @tombentley @mimaison I'd really like it if we could confirm the intended direction for this API. I'm willing to go whichever direction you believe is best, but (as Tom has noted) given

[jira] [Commented] (KAFKA-13864) Change the visibility of a KafkaProducer and KafkaConsumer constructor

[ https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530788#comment-17530788 ] Bruno Cadonna commented on KAFKA-13864: --- [~frosiere] When you write a KIP you need to follow the

[GitHub] [kafka] cadonna commented on pull request #12114: MINOR: Note that slf4j-log4j in version 1.7.35+ should be used

cadonna commented on PR #12114: URL: https://github.com/apache/kafka/pull/12114#issuecomment-1115025366 @ijuma -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [kafka] cadonna opened a new pull request, #12114: MINOR: Note that slf4j-log4j in version 1.7.35+ should be used

cadonna opened a new pull request, #12114: URL: https://github.com/apache/kafka/pull/12114 Adds a note to the upgrade notes to use slf4j-log4j version 1.7.35+ [1] or slf4j-reload4j to avoid possible compatibility issues originating from the logging framework [2]. [1]

[GitHub] [kafka] YeonCheolGit commented on a diff in pull request #12019: KAFKA-13764: Improve balancing algorithm for Connect incremental rebalancing

YeonCheolGit commented on code in PR #12019: URL: https://github.com/apache/kafka/pull/12019#discussion_r862388033 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java: ## @@ -110,14 +114,18 @@ public Map

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12045: KAFKA-12319: Change calculation of window size used to calculate `Rate`

divijvaidya commented on code in PR #12045: URL: https://github.com/apache/kafka/pull/12045#discussion_r862915029 ## clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java: ## @@ -34,22 +34,38 @@ */ public abstract class SampledStat implements

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12045: KAFKA-12319: Change calculation of window size used to calculate `Rate`

divijvaidya commented on code in PR #12045: URL: https://github.com/apache/kafka/pull/12045#discussion_r862909115 ## clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java: ## @@ -138,6 +170,46 @@ public boolean isComplete(long timeMs, MetricConfig

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12045: KAFKA-12319: Change calculation of window size used to calculate `Rate`

divijvaidya commented on code in PR #12045: URL: https://github.com/apache/kafka/pull/12045#discussion_r862908720 ## clients/src/main/java/org/apache/kafka/common/metrics/stats/Rate.java: ## @@ -52,10 +51,6 @@ public Rate(TimeUnit unit, SampledStat stat) { this.unit =

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12045: KAFKA-12319: Change calculation of window size used to calculate `Rate`

divijvaidya commented on code in PR #12045: URL: https://github.com/apache/kafka/pull/12045#discussion_r862908241 ## clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java: ## @@ -110,25 +127,40 @@ public String toString() { protected void

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12045: KAFKA-12319: Change calculation of window size used to calculate `Rate`

divijvaidya commented on code in PR #12045: URL: https://github.com/apache/kafka/pull/12045#discussion_r862908032 ## clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java: ## @@ -87,8 +103,9 @@ public Sample oldest(long now) { Sample oldest =

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12045: KAFKA-12319: Change calculation of window size used to calculate `Rate`

divijvaidya commented on code in PR #12045: URL: https://github.com/apache/kafka/pull/12045#discussion_r862906685 ## clients/src/main/java/org/apache/kafka/common/metrics/stats/Rate.java: ## @@ -68,28 +63,61 @@ public double measure(MetricConfig config, long now) { }

[GitHub] [kafka] divijvaidya commented on pull request #12045: KAFKA-12319: Change calculation of window size used to calculate `Rate`

divijvaidya commented on PR #12045: URL: https://github.com/apache/kafka/pull/12045#issuecomment-1114895474 @mimaison Thinking about it, I can actually reduce the code changes such that no modifications to any public interface is made. Do you still think a KIP is required for this change

[GitHub] [kafka] chromy96 commented on a diff in pull request #11916: KAFKA-12703; Allow unencrypted private keys when using PEM files

chromy96 commented on code in PR #11916: URL: https://github.com/apache/kafka/pull/11916#discussion_r862846428 ## clients/src/test/java/org/apache/kafka/common/security/ssl/DefaultSslEngineFactoryTest.java: ## @@ -291,7 +289,14 @@ public void testPemKeyStoreFileNoKeyPassword()

[GitHub] [kafka] chromy96 commented on a diff in pull request #11916: KAFKA-12703; Allow unencrypted private keys when using PEM files

chromy96 commented on code in PR #11916: URL: https://github.com/apache/kafka/pull/11916#discussion_r862845752 ## clients/src/test/java/org/apache/kafka/common/security/ssl/DefaultSslEngineFactoryTest.java: ## @@ -291,7 +289,14 @@ public void testPemKeyStoreFileNoKeyPassword()

[GitHub] [kafka] divijvaidya commented on pull request #12045: KAFKA-12319: Change calculation of window size used to calculate `Rate`

divijvaidya commented on PR #12045: URL: https://github.com/apache/kafka/pull/12045#issuecomment-1114879179 Thanks for checking @mimaison. As I explained above, the test is flaky since the logic of computation of `Rate` has a bug and hence, in worst case scenario it can exceed whatever

[GitHub] [kafka] mimaison commented on a diff in pull request #12045: KAFKA-12319: Change calculation of window size used to calculate `Rate`

mimaison commented on code in PR #12045: URL: https://github.com/apache/kafka/pull/12045#discussion_r862834421 ## clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java: ## @@ -110,25 +127,40 @@ public String toString() { protected void

[GitHub] [kafka] Hangleton commented on a diff in pull request #12045: KAFKA-12319: Change calculation of window size used to calculate `Rate`

Hangleton commented on code in PR #12045: URL: https://github.com/apache/kafka/pull/12045#discussion_r862786317 ## clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java: ## @@ -87,8 +103,9 @@ public Sample oldest(long now) { Sample oldest =

[jira] [Comment Edited] (KAFKA-13864) Change the visibility of a KafkaProducer and KafkaConsumer constructor

[ https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530722#comment-17530722 ] François Rosière edited comment on KAFKA-13864 at 5/2/22 12:52 PM: ---

[jira] [Commented] (KAFKA-13864) Change the visibility of a KafkaProducer and KafkaConsumer constructor

[ https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530722#comment-17530722 ] François Rosière commented on KAFKA-13864: -- KIP-832 has been created. > Change the visibility

[jira] [Commented] (KAFKA-13864) Change the visibility of a KafkaProducer and KafkaConsumer constructor

[ https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530716#comment-17530716 ] Bruno Cadonna commented on KAFKA-13864: --- [~frosiere] You should be all set now! > Change the

[jira] [Commented] (KAFKA-13864) Change the visibility of a KafkaProducer and KafkaConsumer constructor

[ https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530707#comment-17530707 ] François Rosière commented on KAFKA-13864: -- Make sense... frosiere is my account name on both

[GitHub] [kafka] Hangleton commented on a diff in pull request #12045: KAFKA-12319: Change calculation of window size used to calculate `Rate`

Hangleton commented on code in PR #12045: URL: https://github.com/apache/kafka/pull/12045#discussion_r862786317 ## clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java: ## @@ -87,8 +103,9 @@ public Sample oldest(long now) { Sample oldest =

[jira] [Comment Edited] (KAFKA-13864) Change the visibility of a KafkaProducer and KafkaConsumer constructor

[ https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530703#comment-17530703 ] Bruno Cadonna edited comment on KAFKA-13864 at 5/2/22 12:06 PM: Any

[jira] [Commented] (KAFKA-13864) Change the visibility of a KafkaProducer and KafkaConsumer constructor

[ https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530703#comment-17530703 ] Bruno Cadonna commented on KAFKA-13864: --- Any change that impacts the public interface of a class

[jira] [Comment Edited] (KAFKA-13864) Change the visibility of a KafkaProducer and KafkaConsumer constructor

[ https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530697#comment-17530697 ] François Rosière edited comment on KAFKA-13864 at 5/2/22 11:59 AM: ---

[jira] [Commented] (KAFKA-13864) Change the visibility of a KafkaProducer and KafkaConsumer constructor

[ https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530697#comment-17530697 ] François Rosière commented on KAFKA-13864: -- KIP looks overkill in this specific case as we

[jira] [Commented] (KAFKA-13864) Change the visibility of a KafkaProducer and KafkaConsumer constructor

[ https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530694#comment-17530694 ] Bruno Cadonna commented on KAFKA-13864: --- [~Jack-Lee] Could you please open a GitHub PR against

[jira] [Commented] (KAFKA-13864) Change the visibility of a KafkaProducer and KafkaConsumer constructor

[ https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530689#comment-17530689 ] lqjacklee commented on KAFKA-13864: --- [~frosiere] [~cadonna]  please help review the patch. Once we

[jira] [Updated] (KAFKA-13864) Change the visibility of a KafkaProducer and KafkaConsumer constructor

[ https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lqjacklee updated KAFKA-13864: -- Attachment: interceptor_constructor_client.patch > Change the visibility of a KafkaProducer and

[GitHub] [kafka] divijvaidya commented on pull request #12113: MINOR: Small cleanups in connect/mirror

divijvaidya commented on PR #12113: URL: https://github.com/apache/kafka/pull/12113#issuecomment-1114739908 Hey @mimaison, one of the flaky tests failing for this PR is `testListenerConnectionRateLimitWhenActualRateAboveLimit() – kafka.network.ConnectionQuotasTest` which I have fixed as

[jira] [Commented] (KAFKA-13864) Change the visibility of a KafkaProducer and KafkaConsumer constructor

[ https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530677#comment-17530677 ] Bruno Cadonna commented on KAFKA-13864: --- [~frosiere][~Jack-Lee] I think this ticket needs a KIP

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12106: KAFKA-13861: Fix the validateOnly behavior for CreatePartitions requests in KRaft mode

divijvaidya commented on code in PR #12106: URL: https://github.com/apache/kafka/pull/12106#discussion_r862747446 ## core/src/main/scala/kafka/server/ControllerApis.scala: ## @@ -767,7 +767,7 @@ class ControllerApis(val requestChannel: RequestChannel,

[jira] [Updated] (KAFKA-13864) Change the visibility of a KafkaProducer and KafkaConsumer constructor

[ https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-13864: -- Labels: needs-kip (was: ) > Change the visibility of a KafkaProducer and KafkaConsumer

[jira] [Updated] (KAFKA-13864) Change the visibility of a KafkaProducer and KafkaConsumer constructor

[ https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] François Rosière updated KAFKA-13864: - Description: To allow implementing Spring managed interceptors for producers and

[jira] [Updated] (KAFKA-13864) Change the visibility of a KafkaProducer and KafkaConsumer constructor

[ https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] François Rosière updated KAFKA-13864: - Description: To allow implementing Spring managed interceptors for producers and

[jira] [Assigned] (KAFKA-13864) Change the visibility of a KafkaProducer and KafkaConsumer constructor

[ https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lqjacklee reassigned KAFKA-13864: - Assignee: lqjacklee > Change the visibility of a KafkaProducer and KafkaConsumer constructor >

[jira] [Updated] (KAFKA-13864) Change the visibility of a KafkaProducer and KafkaConsumer constructor

[ https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] François Rosière updated KAFKA-13864: - Description: To allow implementing Spring managed interceptors for producers and

[jira] [Updated] (KAFKA-13864) Change the visibility of a KafkaProducer and KafkaConsumer constructor

[ https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] François Rosière updated KAFKA-13864: - Description: To allow implementing Spring managed interceptors for producers and

[jira] [Updated] (KAFKA-13864) Change the visibility of a KafkaProducer and KafkaConsumer constructor

[ https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] François Rosière updated KAFKA-13864: - Description: To allow implementing Spring managed interceptors for producers and

[jira] [Updated] (KAFKA-13864) Change the visibility of a KafkaProducer and KafkaConsumer constructor

[ https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] François Rosière updated KAFKA-13864: - Description: To allow implementing Spring managed interceptors for producers and

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12112: MINOR: Fix flaky testDescribeUnderReplicatedPartitions

divijvaidya commented on code in PR #12112: URL: https://github.com/apache/kafka/pull/12112#discussion_r862714992 ## core/src/test/scala/integration/kafka/admin/TopicCommandIntegrationTest.scala: ## @@ -586,11 +586,14 @@ class TopicCommandIntegrationTest extends

[jira] [Resolved] (KAFKA-13865) Fix ResponseSendTimeMs metric in RequestChannel.scala was removed repeatedly

[ https://issues.apache.org/jira/browse/KAFKA-13865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-13865. --- Fix Version/s: 3.3.0 Resolution: Fixed > Fix ResponseSendTimeMs metric in

[GitHub] [kafka] showuon merged pull request #12111: KAFKA-13865: Fix ResponseSendTimeMs metric in RequestChannel.scala was removed repeatedly

showuon merged PR #12111: URL: https://github.com/apache/kafka/pull/12111 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] mimaison commented on pull request #11844: KAFKA#13702 - Connect RestClient overrides response status code on request failure

mimaison commented on PR #11844: URL: https://github.com/apache/kafka/pull/11844#issuecomment-1114635179 @Corlobin I agree with @C0urante, it would be good to have a test for this. Are you interested in trying the approach that has been suggested? -- This is an automated message from the

[GitHub] [kafka] mimaison opened a new pull request, #12113: MINOR: Small cleanups in connect/mirror

mimaison opened a new pull request, #12113: URL: https://github.com/apache/kafka/pull/12113 - Make a few fields `final` - Remove unnecessary `throws` ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and

[jira] [Assigned] (KAFKA-13773) Data loss after recovery from crash due to full hard disk

[ https://issues.apache.org/jira/browse/KAFKA-13773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen reassigned KAFKA-13773: - Assignee: Luke Chen > Data loss after recovery from crash due to full hard disk >