[jira] [Updated] (KAFKA-14070) Improve documentation for queryMetadataForKey for state stores with Processor API

2022-07-13 Thread Balaji Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balaji Rao updated KAFKA-14070: --- Summary: Improve documentation for queryMetadataForKey for state stores with Processor API (was:

[jira] [Updated] (KAFKA-14070) Improve documentation for queryMetadataForKey

2022-07-13 Thread Balaji Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balaji Rao updated KAFKA-14070: --- Description: Using {{queryMetadataForKey}} for state stores with Processor API is tricky. One

[jira] [Updated] (KAFKA-14070) Improve documentation for queryMetadataForKey

2022-07-13 Thread Balaji Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balaji Rao updated KAFKA-14070: --- Description: Using {{queryMetadataForKey}} for state stores with Processor API is tricky. One

[jira] [Commented] (KAFKA-14070) Improve documentation for queryMetadataForKey

2022-07-13 Thread Balaji Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17566639#comment-17566639 ] Balaji Rao commented on KAFKA-14070: Hi [~guozhang], thank you for your interest. When I was

[jira] [Updated] (KAFKA-14070) Improve documentation for queryMetadataForKey

2022-07-13 Thread Balaji Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balaji Rao updated KAFKA-14070: --- Description: Using {{queryMetadataForKey}} for state stores with Processor API is tricky. One

[jira] [Updated] (KAFKA-14070) Improve documentation for queryMetadataForKey

2022-07-13 Thread Balaji Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balaji Rao updated KAFKA-14070: --- Description: When using key-value state stores with Processor API, one can add key-value state

[GitHub] [kafka] mjsax commented on pull request #12377: KAFKA-14008: Add docs for Streams metrics introduced in KIP-846

2022-07-13 Thread GitBox
mjsax commented on PR #12377: URL: https://github.com/apache/kafka/pull/12377#issuecomment-1183826801 Also cherry-picked to `3.3` branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] mjsax commented on pull request #12377: KAFKA-14008: Add docs for Streams metrics introduced in KIP-846

2022-07-13 Thread GitBox
mjsax commented on PR #12377: URL: https://github.com/apache/kafka/pull/12377#issuecomment-1183825127 Thanks for the PR! Merged to `trunk`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] mjsax merged pull request #12377: KAFKA-14008: Add docs for Streams metrics introduced in KIP-846

2022-07-13 Thread GitBox
mjsax merged PR #12377: URL: https://github.com/apache/kafka/pull/12377 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] junrao commented on a diff in pull request #12347: KAFKA-13919: expose log recovery metrics

2022-07-13 Thread GitBox
junrao commented on code in PR #12347: URL: https://github.com/apache/kafka/pull/12347#discussion_r920568430 ## core/src/test/scala/unit/kafka/log/LogManagerTest.scala: ## @@ -638,6 +641,221 @@ class LogManagerTest { assertTrue(logManager.partitionsInitializing.isEmpty)

[jira] [Commented] (KAFKA-13846) Add an overloaded metricOrElseCreate function in Metrics

2022-07-13 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17566542#comment-17566542 ] Jose Armando Garcia Sancio commented on KAFKA-13846: [~guozhang] [~sagarrao] The

[jira] [Updated] (KAFKA-13883) KIP-835: Monitor Quorum

2022-07-13 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-13883: --- Fix Version/s: 3.3.0 > KIP-835: Monitor Quorum >

[jira] [Commented] (KAFKA-13217) Reconsider skipping the LeaveGroup on close() or add an overload that does so

2022-07-13 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17566513#comment-17566513 ] Jose Armando Garcia Sancio commented on KAFKA-13217: [~dsayan] [~ableegoldman] Some

[jira] [Updated] (KAFKA-13299) Accept listeners that have the same port but use IPv4 vs IPv6

2022-07-13 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-13299: --- Fix Version/s: 3.3.0 > Accept listeners that have the same port but

[jira] [Assigned] (KAFKA-13299) Accept listeners that have the same port but use IPv4 vs IPv6

2022-07-13 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio reassigned KAFKA-13299: -- Assignee: Matthew de Detrich > Accept listeners that have

[GitHub] [kafka] jsancio commented on pull request #11478: KAFKA-13299: Accept duplicate listener on port for IPv4/IPv6

2022-07-13 Thread GitBox
jsancio commented on PR #11478: URL: https://github.com/apache/kafka/pull/11478#issuecomment-1183739794 @mimaison If you approve and merge this soon. I am okay with you cherry picking it to the 3.3 branch. -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Updated] (KAFKA-7739) Kafka Tiered Storage

2022-07-13 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-7739: -- Fix Version/s: (was: 3.3.0) > Kafka Tiered Storage >

[jira] [Commented] (KAFKA-13715) Add "generation" field into consumer protocol

2022-07-13 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17566511#comment-17566511 ] Jose Armando Garcia Sancio commented on KAFKA-13715: [~showuon] This KIPs page

[jira] [Commented] (KAFKA-13410) KRaft Upgrades

2022-07-13 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17566510#comment-17566510 ] Jose Armando Garcia Sancio commented on KAFKA-13410: [~mumrah] This KIP and issue is

[jira] [Commented] (KAFKA-12473) Make the "cooperative-sticky, range" as the default assignor

2022-07-13 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17566509#comment-17566509 ] Jose Armando Garcia Sancio commented on KAFKA-12473: [~ableegoldman] [~showuon] This

[jira] [Commented] (KAFKA-10000) Atomic commit of source connector records and offsets

2022-07-13 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17566508#comment-17566508 ] Jose Armando Garcia Sancio commented on KAFKA-1: [~ChrisEgerton] , This KIP is

[jira] [Commented] (KAFKA-6945) Add support to allow users to acquire delegation tokens for other users

2022-07-13 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17566507#comment-17566507 ] Jose Armando Garcia Sancio commented on KAFKA-6945: --- [~viktorsomogyi] [~omkreddy]

[jira] [Commented] (KAFKA-7739) Kafka Tiered Storage

2022-07-13 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17566504#comment-17566504 ] Jose Armando Garcia Sancio commented on KAFKA-7739: --- [~satish.duggana] [~sriharsha] ,

[GitHub] [kafka] rajinisivaram commented on pull request #10964: KAFKA-13043: Implement Admin APIs for offsetFetch batching

2022-07-13 Thread GitBox
rajinisivaram commented on PR #10964: URL: https://github.com/apache/kafka/pull/10964#issuecomment-1183710977 @dajac Thanks for the reviews, I have addressed the comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] rajinisivaram commented on a diff in pull request #10964: KAFKA-13043: Implement Admin APIs for offsetFetch batching

2022-07-13 Thread GitBox
rajinisivaram commented on code in PR #10964: URL: https://github.com/apache/kafka/pull/10964#discussion_r920541321 ## clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java: ## @@ -3263,6 +3282,95 @@ public void testListConsumerGroupOffsets() throws

[GitHub] [kafka] mumrah commented on a diff in pull request #12318: MINOR: Support --release in FeatureCommand

2022-07-13 Thread GitBox
mumrah commented on code in PR #12318: URL: https://github.com/apache/kafka/pull/12318#discussion_r920433990 ## core/src/test/scala/unit/kafka/admin/FeatureCommandTest.scala: ## @@ -107,4 +116,17 @@ class FeatureCommandTest extends BaseRequestTest {

[GitHub] [kafka] mumrah commented on pull request #12374: KAFKA-14039 Fix AlterConfigPolicy usage in KRaft

2022-07-13 Thread GitBox
mumrah commented on PR #12374: URL: https://github.com/apache/kafka/pull/12374#issuecomment-1183592500 @hachikuji I added coverage for the new behavior in the test you mentioned. The test will first set a regular broker config, and later verify that it isn't passed to the policy when we're

[GitHub] [kafka] mumrah commented on pull request #11096: Adding reviewers.py to help tag reviewers in commit message

2022-07-13 Thread GitBox
mumrah commented on PR #11096: URL: https://github.com/apache/kafka/pull/11096#issuecomment-1183560594 @ijuma I've been using this script for a while now with good results. Can we merge this and defer improvements to future PRs? -- This is an automated message from the Apache Git

[GitHub] [kafka] mumrah opened a new pull request, #12403: KAFKA-13166 Fix missing ControllerApis error handling

2022-07-13 Thread GitBox
mumrah opened a new pull request, #12403: URL: https://github.com/apache/kafka/pull/12403 In ControllerApis, we are making use of the CompletableFuture-s returned by QuorumController to add callbacks via `whenComplete`. Since these chained methods on CompletableFuture return a _new_

[GitHub] [kafka] dajac commented on a diff in pull request #10964: KAFKA-13043: Implement Admin APIs for offsetFetch batching

2022-07-13 Thread GitBox
dajac commented on code in PR #10964: URL: https://github.com/apache/kafka/pull/10964#discussion_r920377874 ## clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java: ## @@ -3263,6 +3282,95 @@ public void testListConsumerGroupOffsets() throws Exception

[GitHub] [kafka] dajac commented on a diff in pull request #10964: KAFKA-13043: Implement Admin APIs for offsetFetch batching

2022-07-13 Thread GitBox
dajac commented on code in PR #10964: URL: https://github.com/apache/kafka/pull/10964#discussion_r920378132 ## clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java: ## @@ -3263,6 +3282,95 @@ public void testListConsumerGroupOffsets() throws Exception

[GitHub] [kafka] dajac commented on a diff in pull request #10964: KAFKA-13043: Implement Admin APIs for offsetFetch batching

2022-07-13 Thread GitBox
dajac commented on code in PR #10964: URL: https://github.com/apache/kafka/pull/10964#discussion_r920365489 ## clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java: ## @@ -3263,6 +3282,95 @@ public void testListConsumerGroupOffsets() throws Exception

[GitHub] [kafka] dajac commented on a diff in pull request #10964: KAFKA-13043: Implement Admin APIs for offsetFetch batching

2022-07-13 Thread GitBox
dajac commented on code in PR #10964: URL: https://github.com/apache/kafka/pull/10964#discussion_r920356871 ## clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java: ## @@ -3263,6 +3282,95 @@ public void testListConsumerGroupOffsets() throws Exception

[jira] [Commented] (KAFKA-14069) Allow custom configuration of foreign key join internal topics

2022-07-13 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17566419#comment-17566419 ] Guozhang Wang commented on KAFKA-14069: --- Hello [~ebrard], thanks for bringing this ticket up.

[jira] [Commented] (KAFKA-12901) Metadata not updated after broker restart.

2022-07-13 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17566418#comment-17566418 ] Jun Rao commented on KAFKA-12901: - [~suriyav] : Thanks for the reply. We recently fixed

[jira] [Commented] (KAFKA-14070) Improve documentation for queryMetadataForKey

2022-07-13 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17566414#comment-17566414 ] Guozhang Wang commented on KAFKA-14070: --- Hello [~balajirrao], thanks for filing this ticket. Could

[jira] [Commented] (KAFKA-13953) kafka Console consumer fails with CorruptRecordException

2022-07-13 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17566412#comment-17566412 ] Jun Rao commented on KAFKA-13953: - [~doguscan] : It's possible that a Kafka bug caused the corruption.

[GitHub] [kafka] rajinisivaram commented on pull request #10964: KAFKA-13043: Implement Admin APIs for offsetFetch batching

2022-07-13 Thread GitBox
rajinisivaram commented on PR #10964: URL: https://github.com/apache/kafka/pull/10964#issuecomment-1183439218 @dajac Thanks for the review, I have addressed all the comments except the additional unit test. Will it be ok if that is added in a follow-on PR? I need to figure out how to make

[jira] [Commented] (KAFKA-13868) Website updates to satisfy Apache privacy policies

2022-07-13 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17566399#comment-17566399 ] Divij Vaidya commented on KAFKA-13868: -- - It's using scripts hosted on Cloudflare CDN -> Fixed in

[jira] [Commented] (KAFKA-13868) Website updates to satisfy Apache privacy policies

2022-07-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17566400#comment-17566400 ] ASF GitHub Bot commented on KAFKA-13868: divijvaidya commented on PR #422: URL:

[jira] [Commented] (KAFKA-13868) Website updates to satisfy Apache privacy policies

2022-07-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17566398#comment-17566398 ] ASF GitHub Bot commented on KAFKA-13868: divijvaidya opened a new pull request, #422: URL:

[GitHub] [kafka] rajinisivaram commented on a diff in pull request #10964: KAFKA-13043: Implement Admin APIs for offsetFetch batching

2022-07-13 Thread GitBox
rajinisivaram commented on code in PR #10964: URL: https://github.com/apache/kafka/pull/10964#discussion_r920259415 ## clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java: ## @@ -3263,6 +3282,95 @@ public void testListConsumerGroupOffsets() throws

[jira] [Commented] (KAFKA-13559) The broker's ProduceResponse may be delayed for 300ms

2022-07-13 Thread Badai Aqrandista (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17566379#comment-17566379 ] Badai Aqrandista commented on KAFKA-13559: -- I have reproduced this issue reliably. Processing

[GitHub] [kafka] dajac commented on pull request #12184: KAFKA-13911: Fix the rate window size calculation for edge cases

2022-07-13 Thread GitBox
dajac commented on PR #12184: URL: https://github.com/apache/kafka/pull/12184#issuecomment-1183371092 @divijvaidya I am sorry but I did not have the time to look into this one yet and I will be away for the next three weeks. I may be able to take a look when I come back. -- This is an

[jira] [Assigned] (KAFKA-13868) Website updates to satisfy Apache privacy policies

2022-07-13 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya reassigned KAFKA-13868: Assignee: Divij Vaidya > Website updates to satisfy Apache privacy policies >

[GitHub] [kafka] dajac commented on a diff in pull request #10964: KAFKA-13043: Implement Admin APIs for offsetFetch batching

2022-07-13 Thread GitBox
dajac commented on code in PR #10964: URL: https://github.com/apache/kafka/pull/10964#discussion_r919825138 ## clients/src/main/java/org/apache/kafka/clients/admin/Admin.java: ## @@ -915,23 +916,57 @@ default ListConsumerGroupsResult listConsumerGroups() { /** *

[jira] [Commented] (KAFKA-13868) Website updates to satisfy Apache privacy policies

2022-07-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17566358#comment-17566358 ] ASF GitHub Bot commented on KAFKA-13868: divijvaidya commented on PR #421: URL:

[jira] [Commented] (KAFKA-13868) Website updates to satisfy Apache privacy policies

2022-07-13 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17566356#comment-17566356 ] Divij Vaidya commented on KAFKA-13868: -- Addressed "It's missing a link to the privacy policy" ->

[jira] [Commented] (KAFKA-13868) Website updates to satisfy Apache privacy policies

2022-07-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17566353#comment-17566353 ] ASF GitHub Bot commented on KAFKA-13868: divijvaidya opened a new pull request, #421: URL:

[GitHub] [kafka] showuon commented on pull request #12347: KAFKA-13919: expose log recovery metrics

2022-07-13 Thread GitBox
showuon commented on PR #12347: URL: https://github.com/apache/kafka/pull/12347#issuecomment-1183235977 @junrao , I've addressed all the comments in this commit: https://github.com/apache/kafka/pull/12347/commits/42a69155f748f62cb854aff6e0ab3103698c47cd. Thanks. -- This is an automated

[GitHub] [kafka] showuon commented on a diff in pull request #12347: KAFKA-13919: expose log recovery metrics

2022-07-13 Thread GitBox
showuon commented on code in PR #12347: URL: https://github.com/apache/kafka/pull/12347#discussion_r920088305 ## core/src/main/scala/kafka/log/LogManager.scala: ## @@ -317,6 +338,11 @@ class LogManager(logDirs: Seq[File], val offlineDirs = mutable.Set.empty[(String,

[GitHub] [kafka] showuon commented on a diff in pull request #12347: KAFKA-13919: expose log recovery metrics

2022-07-13 Thread GitBox
showuon commented on code in PR #12347: URL: https://github.com/apache/kafka/pull/12347#discussion_r920087197 ## core/src/main/scala/kafka/log/LogManager.scala: ## @@ -366,25 +392,31 @@ class LogManager(logDirs: Seq[File], val numLogsLoaded = new AtomicInteger(0)

[GitHub] [kafka] showuon commented on a diff in pull request #12347: KAFKA-13919: expose log recovery metrics

2022-07-13 Thread GitBox
showuon commented on code in PR #12347: URL: https://github.com/apache/kafka/pull/12347#discussion_r920084388 ## core/src/main/scala/kafka/log/LogLoader.scala: ## @@ -424,8 +433,13 @@ class LogLoader( // we had an invalid message, delete all remaining log

[GitHub] [kafka] showuon commented on a diff in pull request #12347: KAFKA-13919: expose log recovery metrics

2022-07-13 Thread GitBox
showuon commented on code in PR #12347: URL: https://github.com/apache/kafka/pull/12347#discussion_r920083300 ## core/src/main/scala/kafka/log/LogManager.scala: ## @@ -90,6 +90,10 @@ class LogManager(logDirs: Seq[File], private val _liveLogDirs: ConcurrentLinkedQueue[File] =

[GitHub] [kafka] showuon commented on a diff in pull request #12347: KAFKA-13919: expose log recovery metrics

2022-07-13 Thread GitBox
showuon commented on code in PR #12347: URL: https://github.com/apache/kafka/pull/12347#discussion_r920082431 ## core/src/main/scala/kafka/log/LogManager.scala: ## @@ -366,25 +392,30 @@ class LogManager(logDirs: Seq[File], val numLogsLoaded = new AtomicInteger(0)

[jira] [Assigned] (KAFKA-13959) Controller should unfence Broker with busy metadata log

2022-07-13 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio reassigned KAFKA-13959: -- Assignee: dengziming > Controller should unfence Broker with

[GitHub] [kafka] jsancio commented on pull request #12274: KAFKA-13959: Controller should unfence Broker with busy metadata log

2022-07-13 Thread GitBox
jsancio commented on PR #12274: URL: https://github.com/apache/kafka/pull/12274#issuecomment-1183190708 > maybe we should allow the lastAppliedOffset to be behind by A records (or time) to unfence the broker. @dengziming Here are my thoughts ### Improve logic for unfencing

[GitHub] [kafka] showuon commented on a diff in pull request #12347: KAFKA-13919: expose log recovery metrics

2022-07-13 Thread GitBox
showuon commented on code in PR #12347: URL: https://github.com/apache/kafka/pull/12347#discussion_r920044770 ## core/src/main/scala/kafka/log/LogLoader.scala: ## @@ -424,9 +432,11 @@ class LogLoader( // we had an invalid message, delete all remaining log

[jira] [Commented] (KAFKA-13868) Website updates to satisfy Apache privacy policies

2022-07-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17566303#comment-17566303 ] ASF GitHub Bot commented on KAFKA-13868: divijvaidya commented on PR #420: URL:

[GitHub] [kafka] rajinisivaram commented on a diff in pull request #10964: KAFKA-13043: Implement Admin APIs for offsetFetch batching

2022-07-13 Thread GitBox
rajinisivaram commented on code in PR #10964: URL: https://github.com/apache/kafka/pull/10964#discussion_r919995216 ## clients/src/main/java/org/apache/kafka/clients/admin/Admin.java: ## @@ -915,23 +916,56 @@ default ListConsumerGroupsResult listConsumerGroups() { /**

[GitHub] [kafka] blcksrx commented on pull request #12400: KAFKA-13648: KRaft ClusterInstance does not allow for deferred start

2022-07-13 Thread GitBox
blcksrx commented on PR #12400: URL: https://github.com/apache/kafka/pull/12400#issuecomment-1183127918 In situations, such as different configs for brokers, this `AutoStart` is helpful. As an example, I believe this ticket needs flexibility

[GitHub] [kafka] dengziming commented on pull request #12400: KAFKA-13648: KRaft ClusterInstance does not allow for deferred start

2022-07-13 Thread GitBox
dengziming commented on PR #12400: URL: https://github.com/apache/kafka/pull/12400#issuecomment-1183120119 Thank you for this PR @blcksrx , the change looks reasonable, for my understanding, what is the motivation for this change? did you find the AutoStart is useful while working on

[jira] [Commented] (KAFKA-13868) Website updates to satisfy Apache privacy policies

2022-07-13 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17566269#comment-17566269 ] Divij Vaidya commented on KAFKA-13868: -- Fixed "It's using Google Fonts" ->

[jira] [Commented] (KAFKA-13868) Website updates to satisfy Apache privacy policies

2022-07-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17566267#comment-17566267 ] ASF GitHub Bot commented on KAFKA-13868: divijvaidya opened a new pull request, #420: URL:

[jira] [Comment Edited] (KAFKA-13953) kafka Console consumer fails with CorruptRecordException

2022-07-13 Thread Doguscan Namal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17566253#comment-17566253 ] Doguscan Namal edited comment on KAFKA-13953 at 7/13/22 11:01 AM: -- *

[jira] [Comment Edited] (KAFKA-13953) kafka Console consumer fails with CorruptRecordException

2022-07-13 Thread Doguscan Namal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17566253#comment-17566253 ] Doguscan Namal edited comment on KAFKA-13953 at 7/13/22 11:00 AM: -- *

[GitHub] [kafka] fvaleri commented on pull request #12401: Minor: replace .kafka with .log in implementation documentation

2022-07-13 Thread GitBox
fvaleri commented on PR #12401: URL: https://github.com/apache/kafka/pull/12401#issuecomment-1183073005 > Nice catch! One question: the original image has "kafka log implementation" title on top of it. Did you intend to remove it? I think that's redundant information and most of the

[jira] [Commented] (KAFKA-13953) kafka Console consumer fails with CorruptRecordException

2022-07-13 Thread Doguscan Namal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17566253#comment-17566253 ] Doguscan Namal commented on KAFKA-13953: * Changing the leaders to the toher replicas did not

[GitHub] [kafka] showuon commented on pull request #12401: Minor: replace .kafka with .log in implementation documentation

2022-07-13 Thread GitBox
showuon commented on PR #12401: URL: https://github.com/apache/kafka/pull/12401#issuecomment-1183042772 Also, in the image, it should be "my-topic-0/344...log", right? Not sure if this image should be consistent with the "my-topic" name. Or at least, there should be appending the partition

[GitHub] [kafka] divijvaidya commented on pull request #12333: MINOR: fix `LogCleanerManagerTest.testLogsUnderCleanupIneligibleForCompaction()` for `Defaults.LogMessageTimestampType = "LogAppendTime"`

2022-07-13 Thread GitBox
divijvaidya commented on PR #12333: URL: https://github.com/apache/kafka/pull/12333#issuecomment-1183042362 @ijuma this is a good change to improve tests. Please review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] divijvaidya commented on pull request #12281: KAFKA-13971: Fix atomicity violations caused by improper usage of ConcurrentHashMap - part2

2022-07-13 Thread GitBox
divijvaidya commented on PR #12281: URL: https://github.com/apache/kafka/pull/12281#issuecomment-1183040254 @C0urante please review when you get a chance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] divijvaidya commented on pull request #12228: KAFKA-13950: Fix resource leaks

2022-07-13 Thread GitBox
divijvaidya commented on PR #12228: URL: https://github.com/apache/kafka/pull/12228#issuecomment-1183039507 @ijuma I have addressed your comments. Please review when you get a chance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] showuon commented on pull request #12401: Minor: replace .kafka with .log in implementation documentation

2022-07-13 Thread GitBox
showuon commented on PR #12401: URL: https://github.com/apache/kafka/pull/12401#issuecomment-1183039445 Nice catch! One question: the original image has "kafka log implementation" title on top of it. Did you intend to remove it? -- This is an automated message from the Apache Git

[GitHub] [kafka] divijvaidya commented on pull request #12184: KAFKA-13911: Fix the rate window size calculation for edge cases

2022-07-13 Thread GitBox
divijvaidya commented on PR #12184: URL: https://github.com/apache/kafka/pull/12184#issuecomment-1183038942 @tombentley @mimaison Would you like to review this one please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] dajac commented on pull request #12388: KAFKA-14013: Limit the length of the `reason` field sent on the wire

2022-07-13 Thread GitBox
dajac commented on PR #12388: URL: https://github.com/apache/kafka/pull/12388#issuecomment-1182948012 @etolbakov I don't have any that I can recommend at the moment. You can take a look in Jira though. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] dengziming commented on pull request #12274: KAFKA-13959: Controller should unfence Broker with busy metadata log

2022-07-13 Thread GitBox
dengziming commented on PR #12274: URL: https://github.com/apache/kafka/pull/12274#issuecomment-1182937575 > I see. This would not work for co-located Kafka servers, right? @jsancio you are right, this is why I'm trying to find a simpler solution, for example, letting the broker send

[jira] [Commented] (KAFKA-12901) Metadata not updated after broker restart.

2022-07-13 Thread Suriya Vijayaraghavan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17566217#comment-17566217 ] Suriya Vijayaraghavan commented on KAFKA-12901: --- And Yes, thank you for mentioning that

[jira] [Commented] (KAFKA-12901) Metadata not updated after broker restart.

2022-07-13 Thread Suriya Vijayaraghavan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17566216#comment-17566216 ] Suriya Vijayaraghavan commented on KAFKA-12901: --- [~junrao]    Not completely, but yes, I

[GitHub] [kafka] ijuma commented on a diff in pull request #12365: KAFKA-14020: Performance regression in Producer

2022-07-13 Thread GitBox
ijuma commented on code in PR #12365: URL: https://github.com/apache/kafka/pull/12365#discussion_r919749970 ## clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java: ## @@ -1491,20 +1495,25 @@ public void setPartition(int partition) { if

[GitHub] [kafka] ijuma commented on a diff in pull request #12365: KAFKA-14020: Performance regression in Producer

2022-07-13 Thread GitBox
ijuma commented on code in PR #12365: URL: https://github.com/apache/kafka/pull/12365#discussion_r919747090 ## clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java: ## @@ -1491,20 +1495,25 @@ public void setPartition(int partition) { if

[GitHub] [kafka] nicolasguyomar commented on a diff in pull request #12394: Minor : Improve Exception log

2022-07-13 Thread GitBox
nicolasguyomar commented on code in PR #12394: URL: https://github.com/apache/kafka/pull/12394#discussion_r919723479 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -1154,8 +1154,9 @@ class Partition(val topicPartition: TopicPartition, // Avoid writing

[GitHub] [kafka] rajinisivaram commented on pull request #10964: KAFKA-13043: Implement Admin APIs for offsetFetch batching

2022-07-13 Thread GitBox
rajinisivaram commented on PR #10964: URL: https://github.com/apache/kafka/pull/10964#issuecomment-1182845981 @dajac Thanks for the review and the great suggestions. I have updated the PR, please take another look, thank you! -- This is an automated message from the Apache Git Service.

[GitHub] [kafka] rajinisivaram commented on a diff in pull request #10964: KAFKA-13043: Implement Admin APIs for offsetFetch batching

2022-07-13 Thread GitBox
rajinisivaram commented on code in PR #10964: URL: https://github.com/apache/kafka/pull/10964#discussion_r919719830 ## clients/src/main/java/org/apache/kafka/clients/admin/internals/ListConsumerGroupOffsetsHandler.java: ## @@ -82,16 +69,30 @@ public AdminApiLookupStrategy

[GitHub] [kafka] rajinisivaram commented on a diff in pull request #10964: KAFKA-13043: Implement Admin APIs for offsetFetch batching

2022-07-13 Thread GitBox
rajinisivaram commented on code in PR #10964: URL: https://github.com/apache/kafka/pull/10964#discussion_r919717158 ## clients/src/main/java/org/apache/kafka/clients/admin/ListConsumerGroupOffsetsResult.java: ## @@ -17,33 +17,72 @@ package org.apache.kafka.clients.admin;

[GitHub] [kafka] rajinisivaram commented on a diff in pull request #10964: KAFKA-13043: Implement Admin APIs for offsetFetch batching

2022-07-13 Thread GitBox
rajinisivaram commented on code in PR #10964: URL: https://github.com/apache/kafka/pull/10964#discussion_r919716503 ## clients/src/main/java/org/apache/kafka/clients/admin/Admin.java: ## @@ -915,23 +916,56 @@ default ListConsumerGroupsResult listConsumerGroups() { /**

[GitHub] [kafka] dajac commented on pull request #12395: MINOR: Run MessageFormatChangeTest in ZK mode only

2022-07-13 Thread GitBox
dajac commented on PR #12395: URL: https://github.com/apache/kafka/pull/12395#issuecomment-1182831635 Merged to trunk and 3.3. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] dajac merged pull request #12395: MINOR: Run MessageFormatChangeTest in ZK mode only

2022-07-13 Thread GitBox
dajac merged PR #12395: URL: https://github.com/apache/kafka/pull/12395 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: