[GitHub] [kafka] jnh5y commented on a diff in pull request #12408: KAFKA-14076 Fix issues with KafkaStreams.CloseOptions

2022-07-20 Thread GitBox
jnh5y commented on code in PR #12408: URL: https://github.com/apache/kafka/pull/12408#discussion_r926217527 ## streams/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsCloseOptionsIntegrationTest.java: ## @@ -0,0 +1,198 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jnh5y commented on a diff in pull request #12408: KAFKA-14076 Fix issues with KafkaStreams.CloseOptions

2022-07-20 Thread GitBox
jnh5y commented on code in PR #12408: URL: https://github.com/apache/kafka/pull/12408#discussion_r926216992 ## streams/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsCloseOptionsIntegrationTest.java: ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] dengziming commented on pull request #12294: KAFKA-13990: KRaft controller should return right features in ApiVersionResponse

2022-07-20 Thread GitBox
dengziming commented on PR #12294: URL: https://github.com/apache/kafka/pull/12294#issuecomment-1190983840 cc @mumrah -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [kafka] aiquestion commented on a diff in pull request #12349: KAFKA-14024: Consumer keeps Commit offset in onJoinPrepare in Cooperative rebalance

2022-07-20 Thread GitBox
aiquestion commented on code in PR #12349: URL: https://github.com/apache/kafka/pull/12349#discussion_r926201391 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java: ## @@ -1299,17 +1300,79 @@ public void

[GitHub] [kafka] mjsax commented on a diff in pull request #12408: KAFKA-14076 Fix issues with KafkaStreams.CloseOptions

2022-07-20 Thread GitBox
mjsax commented on code in PR #12408: URL: https://github.com/apache/kafka/pull/12408#discussion_r926113246 ## streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java: ## @@ -1516,48 +1520,41 @@ public synchronized boolean close(final Duration timeout) throws

[GitHub] [kafka] mjsax commented on a diff in pull request #12408: KAFKA-14076 Fix issues with KafkaStreams.CloseOptions

2022-07-20 Thread GitBox
mjsax commented on code in PR #12408: URL: https://github.com/apache/kafka/pull/12408#discussion_r926113971 ## streams/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsCloseOptionsIntegrationTest.java: ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] splett2 commented on a diff in pull request #12416: KAFKA-13559: Fix issue where responses intermittently takes 300+ ms to respond, even when the server is idle.

2022-07-20 Thread GitBox
splett2 commented on code in PR #12416: URL: https://github.com/apache/kafka/pull/12416#discussion_r926147113 ## core/src/test/scala/unit/kafka/network/SocketServerTest.scala: ## @@ -1878,6 +1878,98 @@ class SocketServerTest { }, false) } + /** + * Tests for

[GitHub] [kafka] C0urante commented on a diff in pull request #12422: KAFKA-13982: Move WorkerConfigTransformerTest to use Mockito

2022-07-20 Thread GitBox
C0urante commented on code in PR #12422: URL: https://github.com/apache/kafka/pull/12422#discussion_r926146499 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerConfigTransformerTest.java: ## @@ -53,64 +50,72 @@ public class WorkerConfigTransformerTest {

[jira] [Comment Edited] (KAFKA-14089) Flaky ExactlyOnceSourceIntegrationTest.testSeparateOffsetsTopic

2022-07-20 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17569204#comment-17569204 ] Chris Egerton edited comment on KAFKA-14089 at 7/20/22 11:41 PM: - Thanks

[jira] [Comment Edited] (KAFKA-14089) Flaky ExactlyOnceSourceIntegrationTest.testSeparateOffsetsTopic

2022-07-20 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17569204#comment-17569204 ] Chris Egerton edited comment on KAFKA-14089 at 7/20/22 11:28 PM: - Thanks

[jira] [Commented] (KAFKA-14089) Flaky ExactlyOnceSourceIntegrationTest.testSeparateOffsetsTopic

2022-07-20 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17569204#comment-17569204 ] Chris Egerton commented on KAFKA-14089: --- Thanks [~mimaison]. We don't assert on order of records,

[jira] [Assigned] (KAFKA-14089) Flaky ExactlyOnceSourceIntegrationTest.testSeparateOffsetsTopic

2022-07-20 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton reassigned KAFKA-14089: - Assignee: Chris Egerton > Flaky

[GitHub] [kafka] C0urante commented on pull request #11783: KAFKA-10000: System tests (KIP-618)

2022-07-20 Thread GitBox
C0urante commented on PR #11783: URL: https://github.com/apache/kafka/pull/11783#issuecomment-1190816405 Ah, thanks for the update Luke! In the meantime, I've discovered and addressed a few more issues that surfaced during my local runs yesterday: Since follower workers don't retry

[jira] [Created] (KAFKA-14091) Suddenly-killed tasks can leave hanging transactions open

2022-07-20 Thread Chris Egerton (Jira)
Chris Egerton created KAFKA-14091: - Summary: Suddenly-killed tasks can leave hanging transactions open Key: KAFKA-14091 URL: https://issues.apache.org/jira/browse/KAFKA-14091 Project: Kafka

[jira] [Updated] (KAFKA-13897) Add 3.1.1 to system tests and streams upgrade tests

2022-07-20 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-13897: - Fix Version/s: (was: 3.2.1) > Add 3.1.1 to system tests and streams upgrade tests >

[GitHub] [kafka] mumrah merged pull request #12424: RELEASE: Add 3.2 upgrade docs

2022-07-20 Thread GitBox
mumrah merged PR #12424: URL: https://github.com/apache/kafka/pull/12424 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] jnh5y commented on a diff in pull request #12408: KAFKA-14076 Fix issues with KafkaStreams.CloseOptions

2022-07-20 Thread GitBox
jnh5y commented on code in PR #12408: URL: https://github.com/apache/kafka/pull/12408#discussion_r925972749 ## streams/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsCloseOptionsIntegrationTest.java: ## @@ -0,0 +1,198 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jnh5y commented on a diff in pull request #12408: KAFKA-14076 Fix issues with KafkaStreams.CloseOptions

2022-07-20 Thread GitBox
jnh5y commented on code in PR #12408: URL: https://github.com/apache/kafka/pull/12408#discussion_r925971253 ## streams/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsCloseOptionsIntegrationTest.java: ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] rhauch commented on a diff in pull request #12424: RELEASE: Add 3.2 upgrade docs

2022-07-20 Thread GitBox
rhauch commented on code in PR #12424: URL: https://github.com/apache/kafka/pull/12424#discussion_r925969756 ## docs/upgrade.html: ## @@ -61,6 +61,22 @@ Upgrading to 3.2.0 from any vers +Notable changes in 3.2.1 + +A problem with OAuth token refresh was

[GitHub] [kafka] jnh5y commented on a diff in pull request #12408: KAFKA-14076 Fix issues with KafkaStreams.CloseOptions

2022-07-20 Thread GitBox
jnh5y commented on code in PR #12408: URL: https://github.com/apache/kafka/pull/12408#discussion_r925969588 ## streams/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsCloseOptionsIntegrationTest.java: ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jnh5y commented on a diff in pull request #12408: KAFKA-14076 Fix issues with KafkaStreams.CloseOptions

2022-07-20 Thread GitBox
jnh5y commented on code in PR #12408: URL: https://github.com/apache/kafka/pull/12408#discussion_r925966739 ## streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java: ## @@ -1474,7 +1482,7 @@ private void closeToError() { if (!setState(State.PENDING_ERROR)) {

[jira] [Created] (KAFKA-14090) Allow Kafka Streams to be configured to not create internal topics

2022-07-20 Thread Abraham Leal (Jira)
Abraham Leal created KAFKA-14090: Summary: Allow Kafka Streams to be configured to not create internal topics Key: KAFKA-14090 URL: https://issues.apache.org/jira/browse/KAFKA-14090 Project: Kafka

[GitHub] [kafka] jnh5y commented on a diff in pull request #12408: KAFKA-14076 Fix issues with KafkaStreams.CloseOptions

2022-07-20 Thread GitBox
jnh5y commented on code in PR #12408: URL: https://github.com/apache/kafka/pull/12408#discussion_r925960794 ## streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java: ## @@ -1431,6 +1434,10 @@ private Thread shutdownHelper(final boolean error) { } private

[GitHub] [kafka] mjsax commented on a diff in pull request #12408: KAFKA-14076 Fix issues with KafkaStreams.CloseOptions

2022-07-20 Thread GitBox
mjsax commented on code in PR #12408: URL: https://github.com/apache/kafka/pull/12408#discussion_r925952015 ## streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java: ## @@ -1431,6 +1434,10 @@ private Thread shutdownHelper(final boolean error) { } private

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12397: KAFKA-10199: Cleanup TaskManager and Task interfaces

2022-07-20 Thread GitBox
guozhangwang commented on code in PR #12397: URL: https://github.com/apache/kafka/pull/12397#discussion_r925945110 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/PartitionGroup.java: ## @@ -216,8 +216,9 @@ long partitionTimestamp(final TopicPartition

[GitHub] [kafka] cadonna commented on a diff in pull request #12397: KAFKA-10199: Cleanup TaskManager and Task interfaces

2022-07-20 Thread GitBox
cadonna commented on code in PR #12397: URL: https://github.com/apache/kafka/pull/12397#discussion_r925917621 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StandbyTask.java: ## @@ -234,6 +236,43 @@ public void closeCleanAndRecycleState() {

[GitHub] [kafka] jnh5y commented on a diff in pull request #12408: KAFKA-14076 Fix issues with KafkaStreams.CloseOptions

2022-07-20 Thread GitBox
jnh5y commented on code in PR #12408: URL: https://github.com/apache/kafka/pull/12408#discussion_r925895182 ## streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java: ## @@ -1474,7 +1482,7 @@ private void closeToError() { if (!setState(State.PENDING_ERROR)) {

[GitHub] [kafka] jnh5y commented on a diff in pull request #12408: KAFKA-14076 Fix issues with KafkaStreams.CloseOptions

2022-07-20 Thread GitBox
jnh5y commented on code in PR #12408: URL: https://github.com/apache/kafka/pull/12408#discussion_r925894827 ## streams/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsCloseOptionsIntegrationTest.java: ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12397: KAFKA-10199: Cleanup TaskManager and Task interfaces

2022-07-20 Thread GitBox
guozhangwang commented on code in PR #12397: URL: https://github.com/apache/kafka/pull/12397#discussion_r925892759 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StandbyTask.java: ## @@ -234,6 +236,43 @@ public void closeCleanAndRecycleState() {

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12397: KAFKA-10199: Cleanup TaskManager and Task interfaces

2022-07-20 Thread GitBox
guozhangwang commented on code in PR #12397: URL: https://github.com/apache/kafka/pull/12397#discussion_r925882848 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/Tasks.java: ## @@ -34,29 +33,40 @@ import java.util.TreeMap; import

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12397: KAFKA-10199: Cleanup TaskManager and Task interfaces

2022-07-20 Thread GitBox
guozhangwang commented on code in PR #12397: URL: https://github.com/apache/kafka/pull/12397#discussion_r925881686 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractTask.java: ## @@ -55,25 +57,28 @@ public abstract class AbstractTask implements Task

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12397: KAFKA-10199: Cleanup TaskManager and Task interfaces

2022-07-20 Thread GitBox
guozhangwang commented on code in PR #12397: URL: https://github.com/apache/kafka/pull/12397#discussion_r925880702 ## clients/src/main/java/org/apache/kafka/common/utils/Utils.java: ## @@ -1307,9 +1307,9 @@ public Set characteristics() { } @SafeVarargs -public

[GitHub] [kafka] mjsax commented on a diff in pull request #12408: KAFKA-14076 Fix issues with KafkaStreams.CloseOptions

2022-07-20 Thread GitBox
mjsax commented on code in PR #12408: URL: https://github.com/apache/kafka/pull/12408#discussion_r925862925 ## streams/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsCloseOptionsIntegrationTest.java: ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] mjsax commented on a diff in pull request #12408: KAFKA-14076 Fix issues with KafkaStreams.CloseOptions

2022-07-20 Thread GitBox
mjsax commented on code in PR #12408: URL: https://github.com/apache/kafka/pull/12408#discussion_r925862925 ## streams/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsCloseOptionsIntegrationTest.java: ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on pull request #12378: MINOR : lower Metadata info log to debug for topic ID change

2022-07-20 Thread GitBox
jolshan commented on PR #12378: URL: https://github.com/apache/kafka/pull/12378#issuecomment-1190539986 Ah looks like the issue is that the oldID is null (not the new ID). As described by this comment: ``` // If the new topic ID is valid and different from the

[jira] [Commented] (KAFKA-13700) Kafka reporting CorruptRecordException exception

2022-07-20 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17569115#comment-17569115 ] Divij Vaidya commented on KAFKA-13700: -- cc: [~junrao] for visibility since he is answering another

[jira] [Commented] (KAFKA-13700) Kafka reporting CorruptRecordException exception

2022-07-20 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17569114#comment-17569114 ] Divij Vaidya commented on KAFKA-13700: -- Few questions to understand the situation better. Let's

[GitHub] [kafka] jnh5y commented on a diff in pull request #12408: KAFKA-14076 Fix issues with KafkaStreams.CloseOptions

2022-07-20 Thread GitBox
jnh5y commented on code in PR #12408: URL: https://github.com/apache/kafka/pull/12408#discussion_r925809931 ## streams/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsCloseOptionsIntegrationTest.java: ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jnh5y commented on a diff in pull request #12408: KAFKA-14076 Fix issues with KafkaStreams.CloseOptions

2022-07-20 Thread GitBox
jnh5y commented on code in PR #12408: URL: https://github.com/apache/kafka/pull/12408#discussion_r925808463 ## streams/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsCloseOptionsIntegrationTest.java: ## @@ -0,0 +1,198 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jnh5y commented on a diff in pull request #12408: KAFKA-14076 Fix issues with KafkaStreams.CloseOptions

2022-07-20 Thread GitBox
jnh5y commented on code in PR #12408: URL: https://github.com/apache/kafka/pull/12408#discussion_r925805004 ## streams/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsCloseOptionsIntegrationTest.java: ## @@ -0,0 +1,198 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jnh5y commented on a diff in pull request #12408: KAFKA-14076 Fix issues with KafkaStreams.CloseOptions

2022-07-20 Thread GitBox
jnh5y commented on code in PR #12408: URL: https://github.com/apache/kafka/pull/12408#discussion_r925804504 ## streams/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsCloseOptionsIntegrationTest.java: ## @@ -0,0 +1,198 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jnh5y commented on a diff in pull request #12408: KAFKA-14076 Fix issues with KafkaStreams.CloseOptions

2022-07-20 Thread GitBox
jnh5y commented on code in PR #12408: URL: https://github.com/apache/kafka/pull/12408#discussion_r925804187 ## streams/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsCloseOptionsIntegrationTest.java: ## @@ -0,0 +1,198 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (KAFKA-13953) kafka Console consumer fails with CorruptRecordException

2022-07-20 Thread Doguscan Namal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17569104#comment-17569104 ] Doguscan Namal commented on KAFKA-13953: [~junrao] 1) The DumpLogSegment tool fails to output

[jira] [Resolved] (KAFKA-14020) Performance regression in Producer

2022-07-20 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-14020. - Resolution: Fixed merged the PR to 3.3. > Performance regression in Producer >

[GitHub] [kafka] junrao commented on pull request #12365: KAFKA-14020: Performance regression in Producer

2022-07-20 Thread GitBox
junrao commented on PR #12365: URL: https://github.com/apache/kafka/pull/12365#issuecomment-1190432816 cherry-picked the PR to 3.3. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] junrao merged pull request #12365: KAFKA-14020: Performance regression in Producer

2022-07-20 Thread GitBox
junrao merged PR #12365: URL: https://github.com/apache/kafka/pull/12365 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] rhauch commented on a diff in pull request #12424: RELEASE: Add 3.2 upgrade docs

2022-07-20 Thread GitBox
rhauch commented on code in PR #12424: URL: https://github.com/apache/kafka/pull/12424#discussion_r925721375 ## docs/upgrade.html: ## @@ -61,6 +61,20 @@ Upgrading to 3.2.0 from any vers +Notable changes in 3.2.1 + +A problem with OAuth token refresh was

[GitHub] [kafka] mumrah opened a new pull request, #12424: RELEASE: Add 3.2 upgrade docs

2022-07-20 Thread GitBox
mumrah opened a new pull request, #12424: URL: https://github.com/apache/kafka/pull/12424 Looking through the issues fixed in https://cwiki.apache.org/confluence/display/KAFKA/Release+Plan+3.2.1, I didn't see any changes to public APIs (config/metrics/CLI/etc) or any changes to default

[jira] [Commented] (KAFKA-14002) Update Zookeeper client version to 3.8.0

2022-07-20 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17569027#comment-17569027 ] David Arthur commented on KAFKA-14002: -- Removing 3.2.1 from the fix version. > Update Zookeeper

[jira] [Updated] (KAFKA-14002) Update Zookeeper client version to 3.8.0

2022-07-20 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-14002: - Fix Version/s: (was: 3.2.1) > Update Zookeeper client version to 3.8.0 >

[GitHub] [kafka] showuon commented on pull request #12347: KAFKA-13919: expose log recovery metrics

2022-07-20 Thread GitBox
showuon commented on PR #12347: URL: https://github.com/apache/kafka/pull/12347#issuecomment-1190273171 @tombentley , I've addressed your comments in this commit: https://github.com/apache/kafka/pull/12347/commits/42cd5ac41eb2cc83548066ea053dad47a0eddd22 . Thank you. -- This is an

[GitHub] [kafka] showuon commented on a diff in pull request #12347: KAFKA-13919: expose log recovery metrics

2022-07-20 Thread GitBox
showuon commented on code in PR #12347: URL: https://github.com/apache/kafka/pull/12347#discussion_r925591743 ## core/src/main/scala/kafka/log/LogManager.scala: ## @@ -307,6 +309,27 @@ class LogManager(logDirs: Seq[File], log } + // factory class for naming the log

[GitHub] [kafka] showuon commented on pull request #11783: KAFKA-10000: System tests (KIP-618)

2022-07-20 Thread GitBox
showuon commented on PR #11783: URL: https://github.com/apache/kafka/pull/11783#issuecomment-1190242675 @C0urante , my team members are trying to configure the testing environment to run a system test against this branch. But it still needs some time. @jsancio , it would be great if

[GitHub] [kafka] cadonna commented on a diff in pull request #12397: KAFKA-10199: Cleanup TaskManager and Task interfaces

2022-07-20 Thread GitBox
cadonna commented on code in PR #12397: URL: https://github.com/apache/kafka/pull/12397#discussion_r925471614 ## clients/src/main/java/org/apache/kafka/common/utils/Utils.java: ## @@ -1307,9 +1307,9 @@ public Set characteristics() { } @SafeVarargs -public static

[GitHub] [kafka] urbandan commented on pull request #12392: KAFKA-14053: Transactional producer should bump the epoch and skip ab…

2022-07-20 Thread GitBox
urbandan commented on PR #12392: URL: https://github.com/apache/kafka/pull/12392#issuecomment-1190135063 @showuon @artemlivshits Can you please take a look at this PR? This is the issue we had a thread about on the dev list. -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] viktorsomogyi commented on pull request #12392: KAFKA-14053: Transactional producer should bump the epoch and skip ab…

2022-07-20 Thread GitBox
viktorsomogyi commented on PR #12392: URL: https://github.com/apache/kafka/pull/12392#issuecomment-1190132574 @hachikuji would you please review this PR as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Created] (KAFKA-14089) Flaky ExactlyOnceSourceIntegrationTest.testSeparateOffsetsTopic

2022-07-20 Thread Mickael Maison (Jira)
Mickael Maison created KAFKA-14089: -- Summary: Flaky ExactlyOnceSourceIntegrationTest.testSeparateOffsetsTopic Key: KAFKA-14089 URL: https://issues.apache.org/jira/browse/KAFKA-14089 Project: Kafka

[jira] [Commented] (KAFKA-14089) Flaky ExactlyOnceSourceIntegrationTest.testSeparateOffsetsTopic

2022-07-20 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17568972#comment-17568972 ] Mickael Maison commented on KAFKA-14089: cc [~ChrisEgerton] > Flaky

[GitHub] [kafka] tombentley commented on a diff in pull request #12347: KAFKA-13919: expose log recovery metrics

2022-07-20 Thread GitBox
tombentley commented on code in PR #12347: URL: https://github.com/apache/kafka/pull/12347#discussion_r925348863 ## core/src/main/scala/kafka/log/LogLoader.scala: ## @@ -64,6 +65,7 @@ object LogLoader extends Logging { * @param recoveryPointCheckpoint The checkpoint of the

[GitHub] [kafka] showuon commented on pull request #12401: Minor: replace .kafka with .log in implementation documentation

2022-07-20 Thread GitBox
showuon commented on PR #12401: URL: https://github.com/apache/kafka/pull/12401#issuecomment-1190089583 Only doc change, so don't need to worry about test results. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] mimaison closed pull request #11838: KAFKA-1372: separate 400 error from 500 error in RestClient

2022-07-20 Thread GitBox
mimaison closed pull request #11838: KAFKA-1372: separate 400 error from 500 error in RestClient URL: https://github.com/apache/kafka/pull/11838 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] mimaison commented on pull request #11838: KAFKA-1372: separate 400 error from 500 error in RestClient

2022-07-20 Thread GitBox
mimaison commented on PR #11838: URL: https://github.com/apache/kafka/pull/11838#issuecomment-1190089277 We merged https://github.com/apache/kafka/pull/12320, so closing this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] showuon merged pull request #12401: Minor: replace .kafka with .log in implementation documentation

2022-07-20 Thread GitBox
showuon merged PR #12401: URL: https://github.com/apache/kafka/pull/12401 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] mimaison closed pull request #11844: KAFKA#13702 - Connect RestClient overrides response status code on request failure

2022-07-20 Thread GitBox
mimaison closed pull request #11844: KAFKA#13702 - Connect RestClient overrides response status code on request failure URL: https://github.com/apache/kafka/pull/11844 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] mimaison commented on pull request #11844: KAFKA#13702 - Connect RestClient overrides response status code on request failure

2022-07-20 Thread GitBox
mimaison commented on PR #11844: URL: https://github.com/apache/kafka/pull/11844#issuecomment-1190088514 We merged https://github.com/apache/kafka/pull/12320, so closing this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Resolved] (KAFKA-13702) Connect RestClient overrides response status code on request failure

2022-07-20 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-13702. Fix Version/s: 3.4.0 Resolution: Fixed > Connect RestClient overrides response

[jira] [Commented] (KAFKA-13158) Replace EasyMock and PowerMock with Mockito for ConnectClusterStateImplTest

2022-07-20 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17568965#comment-17568965 ] Ismael Juma commented on KAFKA-13158: - Updated the Jira title to only refer to

[jira] [Updated] (KAFKA-13158) Replace EasyMock and PowerMock with Mockito for ConnectClusterStateImplTest

2022-07-20 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-13158: Summary: Replace EasyMock and PowerMock with Mockito for ConnectClusterStateImplTest (was:

[GitHub] [kafka] ijuma commented on a diff in pull request #12422: KAFKA-13982: Move WorkerConfigTransformerTest to use Mockito

2022-07-20 Thread GitBox
ijuma commented on code in PR #12422: URL: https://github.com/apache/kafka/pull/12422#discussion_r925416275 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerConfigTransformerTest.java: ## @@ -53,64 +50,72 @@ public class WorkerConfigTransformerTest {

[GitHub] [kafka] fvaleri commented on pull request #12401: Minor: replace .kafka with .log in implementation documentation

2022-07-20 Thread GitBox
fvaleri commented on PR #12401: URL: https://github.com/apache/kafka/pull/12401#issuecomment-1190050259 > > I think that's redundant information and most of the other images don't have a title. That said, I'm not against adding it back, it's just a matter of preference. > > Yes, I

[GitHub] [kafka] mimaison merged pull request #12320: KAFKA-13702: Connect RestClient overrides response status code on request failure

2022-07-20 Thread GitBox
mimaison merged PR #12320: URL: https://github.com/apache/kafka/pull/12320 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (KAFKA-13158) Replace EasyMock and PowerMock with Mockito for ConnectClusterStateImpl Test and ConnectorPluginsResourceTest

2022-07-20 Thread Christo Lolov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christo Lolov updated KAFKA-13158: -- Labels: connect runtime (was: a) > Replace EasyMock and PowerMock with Mockito for

[jira] [Updated] (KAFKA-13158) Replace EasyMock and PowerMock with Mockito for ConnectClusterStateImpl Test and ConnectorPluginsResourceTest

2022-07-20 Thread Christo Lolov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christo Lolov updated KAFKA-13158: -- Labels: a (was: connect runtime) > Replace EasyMock and PowerMock with Mockito for

[jira] [Assigned] (KAFKA-13158) Replace EasyMock and PowerMock with Mockito for ConnectClusterStateImpl Test and ConnectorPluginsResourceTest

2022-07-20 Thread Christo Lolov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christo Lolov reassigned KAFKA-13158: - Assignee: Christo Lolov (was: YI-CHEN WANG) > Replace EasyMock and PowerMock with

[GitHub] [kafka] clolov commented on pull request #12423: KAFKA-13158: Move ConnectClusterStateImpl to use Mockito

2022-07-20 Thread GitBox
clolov commented on PR #12423: URL: https://github.com/apache/kafka/pull/12423#issuecomment-1190043748 Hi @C0urante hopefully another quick review :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] clolov opened a new pull request, #12423: KAFKA-13158: Move ConnectClusterStateImpl to use Mockito

2022-07-20 Thread GitBox
clolov opened a new pull request, #12423: URL: https://github.com/apache/kafka/pull/12423 Addressing https://issues.apache.org/jira/browse/KAFKA-13158 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] cadonna commented on pull request #12285: KAFKA-14001: Migrate streams module to JUnit 5 - Part 1

2022-07-20 Thread GitBox
cadonna commented on PR #12285: URL: https://github.com/apache/kafka/pull/12285#issuecomment-1190036847 @clolov could you please rebase your PR since there are conflicts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] cadonna commented on a diff in pull request #12285: KAFKA-14001: Migrate streams module to JUnit 5 - Part 1

2022-07-20 Thread GitBox
cadonna commented on code in PR #12285: URL: https://github.com/apache/kafka/pull/12285#discussion_r925333066 ## streams/src/test/java/org/apache/kafka/streams/integration/ErrorHandlingIntegrationTest.java: ## @@ -52,36 +52,46 @@ import static

[jira] [Commented] (KAFKA-13158) Replace EasyMock and PowerMock with Mockito for ConnectClusterStateImpl Test and ConnectorPluginsResourceTest

2022-07-20 Thread Christo Lolov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17568944#comment-17568944 ] Christo Lolov commented on KAFKA-13158: --- ConnectorPluginsResourceTest appears to have already been

[GitHub] [kafka] clolov commented on a diff in pull request #12422: KAFKA-13982: Move WorkerConfigTransformerTest to use Mockito

2022-07-20 Thread GitBox
clolov commented on code in PR #12422: URL: https://github.com/apache/kafka/pull/12422#discussion_r925346037 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerConfigTransformerTest.java: ## @@ -53,64 +50,72 @@ public class WorkerConfigTransformerTest {

[GitHub] [kafka] clolov commented on a diff in pull request #12422: KAFKA-13982: Move WorkerConfigTransformerTest to use Mockito

2022-07-20 Thread GitBox
clolov commented on code in PR #12422: URL: https://github.com/apache/kafka/pull/12422#discussion_r925345205 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerConfigTransformerTest.java: ## @@ -53,64 +50,72 @@ public class WorkerConfigTransformerTest {

[GitHub] [kafka] showuon commented on pull request #12401: Minor: replace .kafka with .log in implementation documentation

2022-07-20 Thread GitBox
showuon commented on PR #12401: URL: https://github.com/apache/kafka/pull/12401#issuecomment-1190003899 > I think that's redundant information and most of the other images don't have a title. That said, I'm not against adding it back, it's just a matter of preference. Yes, I agree.

[GitHub] [kafka] clolov commented on a diff in pull request #12422: KAFKA-13982: Move WorkerConfigTransformerTest to use Mockito

2022-07-20 Thread GitBox
clolov commented on code in PR #12422: URL: https://github.com/apache/kafka/pull/12422#discussion_r925339313 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerConfigTransformerTest.java: ## @@ -144,10 +149,6 @@ public void subscribe(String path, Set keys,

[GitHub] [kafka] clolov commented on a diff in pull request #12422: KAFKA-13982: Move WorkerConfigTransformerTest to use Mockito

2022-07-20 Thread GitBox
clolov commented on code in PR #12422: URL: https://github.com/apache/kafka/pull/12422#discussion_r925337713 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerConfigTransformerTest.java: ## @@ -53,64 +50,72 @@ public class WorkerConfigTransformerTest {

[GitHub] [kafka] clolov commented on pull request #12409: KAFKA-14058: Migrate ExactlyOnceWorkerSourceTaskTest from EasyMock and PowerMock to Mockito

2022-07-20 Thread GitBox
clolov commented on PR #12409: URL: https://github.com/apache/kafka/pull/12409#issuecomment-1189989887 I find this refactor quite readable. Looks good to me :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (KAFKA-13868) Website updates to satisfy Apache privacy policies

2022-07-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17568922#comment-17568922 ] ASF GitHub Bot commented on KAFKA-13868: mimaison merged PR #424: URL:

[GitHub] [kafka] clolov commented on pull request #12410: MINOR: Remove unused ShutdownableThread class and ineffective ThreadedTest classes

2022-07-20 Thread GitBox
clolov commented on PR #12410: URL: https://github.com/apache/kafka/pull/12410#issuecomment-1189957440 Looks great to me! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [kafka] ijuma commented on pull request #12365: KAFKA-14020: Performance regression in Producer

2022-07-20 Thread GitBox
ijuma commented on PR #12365: URL: https://github.com/apache/kafka/pull/12365#issuecomment-1189943978 @junrao the updated version looks good to me. Thanks @artemlivshits for the patience and iterations. -- This is an automated message from the Apache Git Service. To respond to the