guozhangwang commented on code in PR #12583:
URL: https://github.com/apache/kafka/pull/12583#discussion_r963256124
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java:
##
@@ -867,37 +870,47 @@ void runOnce() {
}
private void
yashmayya commented on code in PR #12561:
URL: https://github.com/apache/kafka/pull/12561#discussion_r963252105
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java:
##
@@ -285,18 +292,13 @@ ClusterAssignment
[
https://issues.apache.org/jira/browse/KAFKA-14190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17600563#comment-17600563
]
Ismael Juma edited comment on KAFKA-14190 at 9/6/22 3:25 AM:
-
[
https://issues.apache.org/jira/browse/KAFKA-14190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17600563#comment-17600563
]
Ismael Juma commented on KAFKA-14190:
-
`AdminZkClient` is an internal class and compatibility was
[
https://issues.apache.org/jira/browse/KAFKA-9397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma resolved KAFKA-9397.
Resolution: Fixed
> Deprecate Direct Zookeeper access in Kafka Administrative Tools
>
[
https://issues.apache.org/jira/browse/KAFKA-9397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma updated KAFKA-9397:
---
Fix Version/s: 2.5.0
> Deprecate Direct Zookeeper access in Kafka Administrative Tools
>
ijuma commented on PR #12584:
URL: https://github.com/apache/kafka/pull/12584#issuecomment-1237612164
@dajac do we need to backport this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ijuma commented on PR #12588:
URL: https://github.com/apache/kafka/pull/12588#issuecomment-1237611620
@omkreddy @showuon Can you please review this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
showuon commented on code in PR #12561:
URL: https://github.com/apache/kafka/pull/12561#discussion_r963205224
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java:
##
@@ -286,30 +294,43 @@ ClusterAssignment
dengziming commented on PR #12589:
URL: https://github.com/apache/kafka/pull/12589#issuecomment-1237602051
I think this can fix the problem, but I'm also wondering why not call
`renounce` when we throw an`ApiException`.
--
This is an automated message from the Apache Git Service.
To
[
https://issues.apache.org/jira/browse/KAFKA-14196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17600552#comment-17600552
]
Philip Nee commented on KAFKA-14196:
Kind of originated from this commit:
[
https://issues.apache.org/jira/browse/KAFKA-14196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philip Nee updated KAFKA-14196:
---
Description:
Several flaky tests under OffsetValidationTest are indicating potential
consumer
[
https://issues.apache.org/jira/browse/KAFKA-14024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17600551#comment-17600551
]
Philip Nee commented on KAFKA-14024:
Hey [~aiquestion] and [~showuon] - Seem like the changes here
[
https://issues.apache.org/jira/browse/KAFKA-14024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philip Nee reassigned KAFKA-14024:
--
Assignee: Shawn Wang (was: Philip Nee)
> Consumer stuck during cooperative rebalance for
[
https://issues.apache.org/jira/browse/KAFKA-14024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philip Nee reassigned KAFKA-14024:
--
Assignee: Philip Nee (was: Shawn Wang)
> Consumer stuck during cooperative rebalance for
dengziming closed pull request #11645: KAFKA-13005: Support jbod in KRaft
URL: https://github.com/apache/kafka/pull/11645
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
showuon commented on PR #11783:
URL: https://github.com/apache/kafka/pull/11783#issuecomment-1237555233
@jsancio , do you have the test results for the system test?
We ran the test in our system for these 2 test suite:
```
tests/kafkatest/tests/connect/connect_distributed_test.py
showuon commented on PR #11516:
URL: https://github.com/apache/kafka/pull/11516#issuecomment-1237549764
@rhauch , do you want to take a quick look for this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
clolov commented on PR #12492:
URL: https://github.com/apache/kafka/pull/12492#issuecomment-1237211750
@cadonna a polite bump for review :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/KAFKA-7109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya updated KAFKA-7109:
Fix Version/s: 3.4.0
> KafkaConsumer should close its incremental fetch sessions on close
>
vpapavas commented on code in PR #12555:
URL: https://github.com/apache/kafka/pull/12555#discussion_r962965501
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/InternalStreamsBuilder.java:
##
@@ -356,6 +362,95 @@ private void mergeDuplicateSourceNodes() {
rykovsi closed pull request #12560: KAFKA-14182: Chenge
StandardAuthorizerData.java from RuntimeException to log.info
URL: https://github.com/apache/kafka/pull/12560
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
divijvaidya commented on PR #12465:
URL: https://github.com/apache/kafka/pull/12465#issuecomment-1237083200
@cadonna please review when you get a chance. You can also refer to previous
PR https://github.com/apache/kafka/pull/12465 and note that the comments
provided there have been
[
https://issues.apache.org/jira/browse/KAFKA-14184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17600356#comment-17600356
]
Bruno Cadonna edited comment on KAFKA-14184 at 9/5/22 1:40 PM:
---
divijvaidya opened a new pull request, #12590:
URL: https://github.com/apache/kafka/pull/12590
## Problem
When consumer is closed, fetch sessions associated with the consumer should
notify the server about it's intention to close using a Fetch call with epoch =
-1 (identified by
[
https://issues.apache.org/jira/browse/KAFKA-14130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17600387#comment-17600387
]
Eslam commented on KAFKA-14130:
---
Thank you [~guozhang] and good Job! :)
> Reduce
[
https://issues.apache.org/jira/browse/KAFKA-14197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17600383#comment-17600383
]
Luke Chen commented on KAFKA-14197:
---
And one silly question: Why don't we do renounce for
showuon commented on PR #12589:
URL: https://github.com/apache/kafka/pull/12589#issuecomment-1236946010
Not sure if this change makes sense. Please help comment. Thanks.
@dengziming @hachikuji @jsancio
--
This is an automated message from the Apache Git Service.
To respond to the
showuon opened a new pull request, #12589:
URL: https://github.com/apache/kafka/pull/12589
…sting API error
When writeEvent failed, we'll try to renounce the controller state. But if
the error is an `ApiException`, we'll just throw exception. The problem
happened when trying to
[
https://issues.apache.org/jira/browse/KAFKA-14184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17600356#comment-17600356
]
Bruno Cadonna commented on KAFKA-14184:
---
[~suresh.ru] Have you tried using 2.7.2 or even a later
[
https://issues.apache.org/jira/browse/KAFKA-14197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17600352#comment-17600352
]
Luke Chen commented on KAFKA-14197:
---
OK, I've checked, there's the problem: the exception:
[
https://issues.apache.org/jira/browse/KAFKA-14197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen updated KAFKA-14197:
--
Description:
In kraft ControllerWriteEvent, we start by trying to apply the record to
controller
vpapavas commented on code in PR #12555:
URL: https://github.com/apache/kafka/pull/12555#discussion_r962781264
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/InternalStreamsBuilder.java:
##
@@ -356,6 +381,95 @@ private void mergeDuplicateSourceNodes() {
cadonna commented on code in PR #12583:
URL: https://github.com/apache/kafka/pull/12583#discussion_r962743402
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java:
##
@@ -770,7 +771,7 @@ void runOnce() {
long totalCommitLatency = 0L;
sudeshwasnik commented on code in PR #12462:
URL: https://github.com/apache/kafka/pull/12462#discussion_r962733119
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java:
##
@@ -273,26 +273,29 @@ public RecordAppendResult append(String
[
https://issues.apache.org/jira/browse/KAFKA-14197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17600305#comment-17600305
]
Luke Chen commented on KAFKA-14197:
---
Thanks for the hint! I'll take a look!
> Kraft broker fails to
cadonna commented on code in PR #12583:
URL: https://github.com/apache/kafka/pull/12583#discussion_r962717234
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java:
##
@@ -867,37 +868,47 @@ void runOnce() {
}
private void
cadonna commented on code in PR #12583:
URL: https://github.com/apache/kafka/pull/12583#discussion_r962711819
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java:
##
@@ -396,8 +397,7 @@ public static StreamThread create(final TopologyMetadata
sudeshwasnik commented on PR #12462:
URL: https://github.com/apache/kafka/pull/12462#issuecomment-1236760679
hey @artemlivshits , thanks for pointing out that if we just check if
partition's producerBatches are empty -> we may get stuck selecting the same
partition if producerBatches keep
[
https://issues.apache.org/jira/browse/KAFKA-14197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17600279#comment-17600279
]
dengziming commented on KAFKA-14197:
Basically, a record will be persisted after being applied, it
sudeshwasnik commented on code in PR #12462:
URL: https://github.com/apache/kafka/pull/12462#discussion_r962664564
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java:
##
@@ -273,26 +273,29 @@ public RecordAppendResult append(String
sudeshwasnik commented on code in PR #12462:
URL: https://github.com/apache/kafka/pull/12462#discussion_r962663696
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java:
##
@@ -273,26 +273,29 @@ public RecordAppendResult append(String
[
https://issues.apache.org/jira/browse/KAFKA-14194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot reassigned KAFKA-14194:
---
Assignee: Andrew Dean
> NPE in Cluster.nodeIfOnline
> ---
>
>
dajac merged PR #12584:
URL: https://github.com/apache/kafka/pull/12584
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
showuon commented on code in PR #12574:
URL: https://github.com/apache/kafka/pull/12574#discussion_r962589238
##
core/src/main/scala/kafka/server/BrokerServer.scala:
##
@@ -448,6 +448,7 @@ class BrokerServer(
try {
showuon commented on code in PR #12574:
URL: https://github.com/apache/kafka/pull/12574#discussion_r962589238
##
core/src/main/scala/kafka/server/BrokerServer.scala:
##
@@ -448,6 +448,7 @@ class BrokerServer(
try {
showuon commented on code in PR #12574:
URL: https://github.com/apache/kafka/pull/12574#discussion_r962589238
##
core/src/main/scala/kafka/server/BrokerServer.scala:
##
@@ -448,6 +448,7 @@ class BrokerServer(
try {
dengziming commented on PR #9577:
URL: https://github.com/apache/kafka/pull/9577#issuecomment-1236593661
go to KIP-858
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
dengziming closed pull request #9577: KAFKA-9837: KIP-589 new RPC for notifying
controller log dir failure
URL: https://github.com/apache/kafka/pull/9577
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
[
https://issues.apache.org/jira/browse/KAFKA-14165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Prem Kamal reassigned KAFKA-14165:
--
Assignee: (was: Prem Kamal)
> ConfigTransformer.DEFAULT_PATTERN fails on Windows
nizhikov commented on code in PR #12574:
URL: https://github.com/apache/kafka/pull/12574#discussion_r962507630
##
core/src/main/scala/kafka/server/BrokerServer.scala:
##
@@ -448,6 +448,7 @@ class BrokerServer(
try {
51 matches
Mail list logo
