guozhangwang commented on code in PR #12739:
URL: https://github.com/apache/kafka/pull/12739#discussion_r994141999
##
streams/src/test/java/org/apache/kafka/streams/state/internals/TimeOrderedCachingPersistentWindowStoreTest.java:
##
@@ -138,51 +144,69 @@ public void setUp() {
[
https://issues.apache.org/jira/browse/KAFKA-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616757#comment-17616757
]
Shekhar Prasad Rajak commented on KAFKA-14133:
--
PR #12739 for
shekhar-rajak opened a new pull request, #12739:
URL: https://github.com/apache/kafka/pull/12739
Related to KAFKA-14059 and KAFKA-14132
Link:
* https://issues.apache.org/jira/browse/KAFKA-14133
* https://issues.apache.org/jira/browse/KAFKA-14132
### Committer
showuon commented on PR #11211:
URL: https://github.com/apache/kafka/pull/11211#issuecomment-1276917798
Thanks for the patience, @vamossagar12 !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
showuon merged PR #11211:
URL: https://github.com/apache/kafka/pull/11211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
showuon commented on PR #11211:
URL: https://github.com/apache/kafka/pull/11211#issuecomment-1276916375
Failed tests are unrelated.
```
Build / JDK 11 and Scala 2.13 /
org.apache.kafka.controller.QuorumControllerTest.testBalancePartitionLeaders()
```
--
This is an automated
hachikuji commented on code in PR #12738:
URL: https://github.com/apache/kafka/pull/12738#discussion_r994016187
##
core/src/test/scala/integration/kafka/server/KRaftClusterTest.scala:
##
@@ -811,20 +811,29 @@ class KRaftClusterTest {
divijvaidya commented on code in PR #12735:
URL: https://github.com/apache/kafka/pull/12735#discussion_r994015093
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/ErrorHandlingTaskTest.java:
##
@@ -374,30 +344,37 @@ public void testErrorHandlingInSourceTasks()
alexec closed pull request #12699: KIP-873: Add PipeDeserializer/PipeSerialize
URL: https://github.com/apache/kafka/pull/12699
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
alexec closed pull request #12698: KIP-873: Add ExceptionHandlingDeserializer
URL: https://github.com/apache/kafka/pull/12698
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
hachikuji commented on code in PR #12736:
URL: https://github.com/apache/kafka/pull/12736#discussion_r993999005
##
metadata/src/main/java/org/apache/kafka/controller/BrokerHeartbeatManager.java:
##
@@ -400,12 +412,13 @@ long lowestActiveOffset() {
}
/**
- * Mark
guozhangwang merged PR #12737:
URL: https://github.com/apache/kafka/pull/12737
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
guozhangwang commented on PR #12737:
URL: https://github.com/apache/kafka/pull/12737#issuecomment-1276844346
Thanks for the reviews @vvcephei @ableegoldman , I will try to improve the
javadocs in the next PR while merging this one as-is.
Also none of the interface functions here are
hachikuji commented on code in PR #12736:
URL: https://github.com/apache/kafka/pull/12736#discussion_r993980280
##
metadata/src/main/java/org/apache/kafka/controller/BrokerHeartbeatManager.java:
##
@@ -276,7 +277,7 @@ Collection brokers() {
}
// VisibleForTesting
-
guozhangwang commented on code in PR #12737:
URL: https://github.com/apache/kafka/pull/12737#discussion_r993980012
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/tasks/TaskManager.java:
##
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache Software
guozhangwang commented on code in PR #12737:
URL: https://github.com/apache/kafka/pull/12737#discussion_r993979720
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/tasks/TaskManager.java:
##
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache Software
guozhangwang commented on code in PR #12737:
URL: https://github.com/apache/kafka/pull/12737#discussion_r993978872
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/tasks/TaskExecutor.java:
##
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software
guozhangwang commented on code in PR #12737:
URL: https://github.com/apache/kafka/pull/12737#discussion_r993975293
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/tasks/TaskExecutor.java:
##
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software
ahuang98 commented on code in PR #12736:
URL: https://github.com/apache/kafka/pull/12736#discussion_r993968289
##
metadata/src/main/java/org/apache/kafka/controller/BrokerHeartbeatManager.java:
##
@@ -276,7 +277,7 @@ Collection brokers() {
}
// VisibleForTesting
-
ahuang98 commented on code in PR #12736:
URL: https://github.com/apache/kafka/pull/12736#discussion_r993968289
##
metadata/src/main/java/org/apache/kafka/controller/BrokerHeartbeatManager.java:
##
@@ -276,7 +277,7 @@ Collection brokers() {
}
// VisibleForTesting
-
ahuang98 commented on code in PR #12736:
URL: https://github.com/apache/kafka/pull/12736#discussion_r993968289
##
metadata/src/main/java/org/apache/kafka/controller/BrokerHeartbeatManager.java:
##
@@ -276,7 +277,7 @@ Collection brokers() {
}
// VisibleForTesting
-
ableegoldman commented on PR #11433:
URL: https://github.com/apache/kafka/pull/11433#issuecomment-1276822852
Hey @vamossagar12 , sorry for the seriously long silence on this -- it was
important and I shouldn't have let it slip. Anyways I know you pointed me to a
specific question about
ableegoldman commented on code in PR #12737:
URL: https://github.com/apache/kafka/pull/12737#discussion_r993948622
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/tasks/TaskExecutor.java:
##
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software
hachikuji commented on code in PR #12736:
URL: https://github.com/apache/kafka/pull/12736#discussion_r993931747
##
metadata/src/main/java/org/apache/kafka/controller/BrokerHeartbeatManager.java:
##
@@ -276,7 +277,7 @@ Collection brokers() {
}
// VisibleForTesting
-
niket-goel commented on PR #12733:
URL: https://github.com/apache/kafka/pull/12733#issuecomment-1276769574
PS submitted https://github.com/apache/kafka/pull/12733 to try to address
one of the Flaky tests above.
--
This is an automated message from the Apache Git Service.
To respond to
cmccabe commented on code in PR #12715:
URL: https://github.com/apache/kafka/pull/12715#discussion_r991501134
##
metadata/src/main/java/org/apache/kafka/image/MetadataImage.java:
##
@@ -120,17 +116,17 @@ public AclsImage acls() {
return acls;
}
-public void
David Mao created KAFKA-14295:
-
Summary: FetchMessageConversionsPerSec meter not recorded
Key: KAFKA-14295
URL: https://issues.apache.org/jira/browse/KAFKA-14295
Project: Kafka
Issue Type: Bug
jsancio commented on code in PR #12715:
URL: https://github.com/apache/kafka/pull/12715#discussion_r993773605
##
core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala:
##
@@ -179,8 +184,13 @@ class BrokerMetadataListener(
snapshotter.foreach { snapshotter
hachikuji commented on code in PR #12736:
URL: https://github.com/apache/kafka/pull/12736#discussion_r993756766
##
metadata/src/main/java/org/apache/kafka/controller/BrokerHeartbeatManager.java:
##
@@ -414,7 +420,9 @@ void updateControlledShutdownOffset(int brokerId, long
hachikuji merged PR #12732:
URL: https://github.com/apache/kafka/pull/12732
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
soarez commented on code in PR #12729:
URL: https://github.com/apache/kafka/pull/12729#discussion_r993735973
##
core/src/main/scala/kafka/zk/AdminZkClient.scala:
##
@@ -365,6 +365,29 @@ class AdminZkClient(zkClient: KafkaZkClient) extends
Logging {
case ConfigType.Ip =>
shekhar-rajak commented on PR #12735:
URL: https://github.com/apache/kafka/pull/12735#issuecomment-1276537604
Thanks @divijvaidya for the comments. I have done some changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
niket-goel commented on PR #12733:
URL: https://github.com/apache/kafka/pull/12733#issuecomment-1276537439
All failing tests seem to have failed due to general flakiness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
guozhangwang opened a new pull request, #12737:
URL: https://github.com/apache/kafka/pull/12737
1. TaskExecutor is the interface for a processor thread. It takes at most
one task to process at a given time from the task manager. When being asked
from the task manager to un-assign the
philipnee commented on PR #12672:
URL: https://github.com/apache/kafka/pull/12672#issuecomment-1276490455
Hey @guozhangwang , much thanks for the detail reviews, I tried to address
some of the comments, please review them. In particular:
1. poll timeout logic
2. InterruptException
vvcephei commented on PR #11211:
URL: https://github.com/apache/kafka/pull/11211#issuecomment-1276484490
Hey @showuon , I see you already approved this PR, and it doesn't look like
any of the following questions were blockers. Do you want to go ahead and merge
it?
--
This is an
ahuang98 opened a new pull request, #12736:
URL: https://github.com/apache/kafka/pull/12736
The `controlledShutDownOffset` is defined as the "offset at which the broker
should complete its controlled shutdown, or -1 if the broker is not performing
a controlled shutdown". The controller
niket-goel commented on PR #12733:
URL: https://github.com/apache/kafka/pull/12733#issuecomment-1276460657
Interesting test failures on this. All are in related code, but not if sure
if there are flakes or actual failures. Will run some local tests to verify.
```
Build / JDK 8 and
Vicky Papavasileiou created KAFKA-14294:
---
Summary: Kafka Streams should commit transaction even no records
are processed
Key: KAFKA-14294
URL: https://issues.apache.org/jira/browse/KAFKA-14294
[
https://issues.apache.org/jira/browse/KAFKA-14294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vicky Papavasileiou updated KAFKA-14294:
Summary: Kafka Streams should commit transaction when no records are
processed
[
https://issues.apache.org/jira/browse/KAFKA-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya updated KAFKA-14132:
-
Description:
{color:#de350b}Some of the tests below use EasyMock as well. For those migrate
divijvaidya commented on code in PR #12735:
URL: https://github.com/apache/kafka/pull/12735#discussion_r993621273
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/ErrorHandlingTaskTest.java:
##
@@ -224,85 +231,68 @@ public void tearDown() {
if (metrics
[
https://issues.apache.org/jira/browse/KAFKA-14266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616499#comment-17616499
]
Chris Egerton commented on KAFKA-14266:
---
That's good to hear, thanks [~LucentWong]!
>
calmera commented on code in PR #12188:
URL: https://github.com/apache/kafka/pull/12188#discussion_r993559392
##
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamBranchTest.java:
##
@@ -59,7 +59,7 @@ public void testKStreamBranch() {
[
https://issues.apache.org/jira/browse/KAFKA-14293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Patrik Márton updated KAFKA-14293:
--
Component/s: KafkaConnect
> Basic Auth filter should set the SecurityContext after a
[
https://issues.apache.org/jira/browse/KAFKA-14293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Patrik Márton reassigned KAFKA-14293:
-
Assignee: Patrik Márton
> Basic Auth filter should set the SecurityContext after a
calmera commented on code in PR #12188:
URL: https://github.com/apache/kafka/pull/12188#discussion_r993550391
##
streams/src/main/java/org/apache/kafka/streams/Topology.java:
##
@@ -737,6 +737,91 @@ public synchronized Topology addStateStore(final
StoreBuilder storeBuilder,
[
https://issues.apache.org/jira/browse/KAFKA-14099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton resolved KAFKA-14099.
---
Fix Version/s: 3.4.0
Reviewer: Chris Egerton
Resolution: Fixed
> No REST
C0urante merged PR #12434:
URL: https://github.com/apache/kafka/pull/12434
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
zigarn commented on PR #12434:
URL: https://github.com/apache/kafka/pull/12434#issuecomment-1276269841
@C0urante No problem. Your scenario is fine by me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
C0urante commented on PR #12434:
URL: https://github.com/apache/kafka/pull/12434#issuecomment-1276267039
Apologies for the delay @zigarn, and thank you for sticking with this.
I'm still not sure we should be relying on the Scala `LogCaptureAppender`,
but I don't want to ask you to
[
https://issues.apache.org/jira/browse/KAFKA-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616459#comment-17616459
]
Shekhar Prasad Rajak commented on KAFKA-14133:
--
I am working on StreamsMetricsImplTest
dajac commented on PR #12674:
URL: https://github.com/apache/kafka/pull/12674#issuecomment-1276256629
Jason and I discussed offline. Returning `OFFSET_NOT_AVAILABLE` is not
really appropriate here because clients may not expect it on the fetch path.
The issue is that we have never
[
https://issues.apache.org/jira/browse/KAFKA-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616454#comment-17616454
]
Shekhar Prasad Rajak commented on KAFKA-14133:
--
I am working on PR
[
https://issues.apache.org/jira/browse/KAFKA-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616450#comment-17616450
]
Shekhar Prasad Rajak commented on KAFKA-14132:
--
https://github.com/apache/kafka/pull/12735
shekhar-rajak commented on code in PR #12735:
URL: https://github.com/apache/kafka/pull/12735#discussion_r993520740
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/ErrorHandlingTaskTest.java:
##
@@ -494,72 +502,29 @@ private void
shekhar-rajak commented on code in PR #12735:
URL: https://github.com/apache/kafka/pull/12735#discussion_r993519986
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/ErrorHandlingTaskTest.java:
##
@@ -494,72 +502,29 @@ private void
shekhar-rajak commented on code in PR #12735:
URL: https://github.com/apache/kafka/pull/12735#discussion_r993519420
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/ErrorHandlingTaskTest.java:
##
@@ -494,72 +502,29 @@ private void
shekhar-rajak commented on code in PR #12735:
URL: https://github.com/apache/kafka/pull/12735#discussion_r993518887
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/ErrorHandlingTaskTest.java:
##
@@ -349,13 +340,15 @@ public void testErrorHandlingInSinkTasks()
shekhar-rajak commented on code in PR #12735:
URL: https://github.com/apache/kafka/pull/12735#discussion_r993517764
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/ErrorHandlingTaskTest.java:
##
@@ -177,16 +180,14 @@ public class ErrorHandlingTaskTest {
shekhar-rajak opened a new pull request, #12735:
URL: https://github.com/apache/kafka/pull/12735
Related to KAFKA-14059 and KAFKA-14132
Link:
* https://issues.apache.org/jira/browse/KAFKA-14133
* https://issues.apache.org/jira/browse/KAFKA-14132
### Committer
C0urante merged PR #10910:
URL: https://github.com/apache/kafka/pull/10910
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
C0urante commented on PR #12355:
URL: https://github.com/apache/kafka/pull/12355#issuecomment-1276195174
@showuon Would you mind giving this a pass? Should be a quick one!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
C0urante commented on code in PR #12355:
URL: https://github.com/apache/kafka/pull/12355#discussion_r993477767
##
connect/file/src/main/java/org/apache/kafka/connect/file/FileStreamSourceConnector.java:
##
@@ -95,4 +96,18 @@ public void stop() {
public ConfigDef config() {
dajac commented on PR #12734:
URL: https://github.com/apache/kafka/pull/12734#issuecomment-1276174598
This is an potential alternative to
https://github.com/apache/kafka/pull/12674.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
dajac opened a new pull request, #12734:
URL: https://github.com/apache/kafka/pull/12734
Fetching from a follower is only allowed from version 11 of the fetch
request. Our intent was to allow it assuming that those would also implement
KIP-320 (leader epoch). It turns out that some clients
Patrik Márton created KAFKA-14293:
-
Summary: Basic Auth filter should set the SecurityContext after a
successful login
Key: KAFKA-14293
URL: https://issues.apache.org/jira/browse/KAFKA-14293
Project:
[
https://issues.apache.org/jira/browse/KAFKA-7739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17616235#comment-17616235
]
Evan Williams commented on KAFKA-7739:
--
[~satish.duggana] How is this KIP moving along? 3.3.1 is
68 matches
Mail list logo
