[GitHub] [kafka] guozhangwang merged pull request #12754: Kafka Streams Threading P3: TaskManager Impl

2022-10-14 Thread GitBox
guozhangwang merged PR #12754: URL: https://github.com/apache/kafka/pull/12754 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] guozhangwang opened a new pull request, #12754: Kafka Streams Threading P3: TaskManager Impl

2022-10-14 Thread GitBox
guozhangwang opened a new pull request, #12754: URL: https://github.com/apache/kafka/pull/12754 0. Add name to task executors. 1. DefaultTaskManager implementation, for interacting with the TaskExecutors and support add/remove/lock APIs. 2. Related unit tests. ### Committer

[GitHub] [kafka] guozhangwang merged pull request #12744: Kafka Streams Threading P2: Skeleton TaskExecutor Impl

2022-10-14 Thread GitBox
guozhangwang merged PR #12744: URL: https://github.com/apache/kafka/pull/12744 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] ijuma commented on a diff in pull request #12752: KAFKA-14303 Fix batch.size=0 in BuiltInPartitioner

2022-10-14 Thread GitBox
ijuma commented on code in PR #12752: URL: https://github.com/apache/kafka/pull/12752#discussion_r996192499 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java: ## @@ -127,7 +127,9 @@ public RecordAccumulator(LogContext logContext,

[GitHub] [kafka] ijuma commented on a diff in pull request #12752: KAFKA-14303 Fix batch.size=0 in BuiltInPartitioner

2022-10-14 Thread GitBox
ijuma commented on code in PR #12752: URL: https://github.com/apache/kafka/pull/12752#discussion_r996190731 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/BuiltInPartitioner.java: ## @@ -56,6 +56,9 @@ public class BuiltInPartitioner { public

[GitHub] [kafka] soarez commented on pull request #12752: KAFKA-14303 Fix batch.size=0 in BuiltInPartitioner

2022-10-14 Thread GitBox
soarez commented on PR #12752: URL: https://github.com/apache/kafka/pull/12752#issuecomment-1279487451 @showuon @ijuma should this one also be backported to 3.3? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] soarez commented on pull request #12752: KAFKA-14303 Fix batch.size=0 in BuiltInPartitioner

2022-10-14 Thread GitBox
soarez commented on PR #12752: URL: https://github.com/apache/kafka/pull/12752#issuecomment-1279487116 Failing tests are unrelated: ``` :clients:unitTest CooperativeStickyAssignorTest > testLargeAssignmentAndGroupWithNonEqualSubscription() :clients:unitTest StickyAssignorTest >

[jira] [Updated] (KAFKA-14298) Getting null pointer exception

2022-10-14 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-14298: Component/s: clients (was: KafkaConnect) > Getting null pointer exception >

[jira] [Commented] (KAFKA-14298) Getting null pointer exception

2022-10-14 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17617967#comment-17617967 ] Greg Harris commented on KAFKA-14298: - [~ramkychowdary0560] I'm not familiar with

[jira] [Updated] (KAFKA-14298) Getting null pointer exception

2022-10-14 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-14298: Description: Getting null pointer exception.   {noformat} java.lang.NullPointerException at

[GitHub] [kafka] Scanteianu opened a new pull request, #12753: MINOR: Document Offset and Partition 0-indexing, fix typo

2022-10-14 Thread GitBox
Scanteianu opened a new pull request, #12753: URL: https://github.com/apache/kafka/pull/12753 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* Add comments to

[jira] [Created] (KAFKA-14305) KRaft Metadata Transactions

2022-10-14 Thread David Arthur (Jira)
David Arthur created KAFKA-14305: Summary: KRaft Metadata Transactions Key: KAFKA-14305 URL: https://issues.apache.org/jira/browse/KAFKA-14305 Project: Kafka Issue Type: New Feature

[GitHub] [kafka] jsancio merged pull request #12707: MINOR: add kraft controller log level entry in log4j prop

2022-10-14 Thread GitBox
jsancio merged PR #12707: URL: https://github.com/apache/kafka/pull/12707 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] jsancio commented on a diff in pull request #12750: MINOR: Inline "Running a Kafka broker in KRaft mode" in README.md

2022-10-14 Thread GitBox
jsancio commented on code in PR #12750: URL: https://github.com/apache/kafka/pull/12750#discussion_r996023706 ## README.md: ## @@ -83,15 +83,17 @@ fail due to code changes. You can just run: ./gradlew processMessages processTestMessages +### Running a Kafka broker in

[jira] [Created] (KAFKA-14304) ZooKeeper to KRaft Migration

2022-10-14 Thread David Arthur (Jira)
David Arthur created KAFKA-14304: Summary: ZooKeeper to KRaft Migration Key: KAFKA-14304 URL: https://issues.apache.org/jira/browse/KAFKA-14304 Project: Kafka Issue Type: New Feature

[GitHub] [kafka] cadonna commented on a diff in pull request #12465: KAFKA-12950: Replace EasyMock and PowerMock with Mockito for KafkaStreamsTest

2022-10-14 Thread GitBox
cadonna commented on code in PR #12465: URL: https://github.com/apache/kafka/pull/12465#discussion_r995965165 ## streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java: ## @@ -1096,7 +1096,7 @@ private Optional removeStreamThread(final long timeoutMs) throws Timeout

[GitHub] [kafka] cadonna commented on a diff in pull request #12465: KAFKA-12950: Replace EasyMock and PowerMock with Mockito for KafkaStreamsTest

2022-10-14 Thread GitBox
cadonna commented on code in PR #12465: URL: https://github.com/apache/kafka/pull/12465#discussion_r995964228 ## streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java: ## @@ -1096,7 +1096,7 @@ private Optional removeStreamThread(final long timeoutMs) throws Timeout

[GitHub] [kafka] cadonna commented on pull request #12743: KAFKA-14299: Fix incorrect pauses in separate state restoration

2022-10-14 Thread GitBox
cadonna commented on PR #12743: URL: https://github.com/apache/kafka/pull/12743#issuecomment-1279253105 Some failures regarding `SmokeTestDriverIntegrationTest` seem related. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (KAFKA-14080) too many node disconnected message in kafka-clients

2022-10-14 Thread Philip Bourke (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17617865#comment-17617865 ] Philip Bourke commented on KAFKA-14080: --- same issue as

[GitHub] [kafka] jsancio commented on a diff in pull request #11023: KAFKA-13115 Update doSend doc about possible blocking

2022-10-14 Thread GitBox
jsancio commented on code in PR #11023: URL: https://github.com/apache/kafka/pull/11023#discussion_r995913999 ## clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java: ## @@ -778,9 +778,10 @@ public Future send(ProducerRecord record) { /** *

[GitHub] [kafka] soarez commented on pull request #12752: KAFKA-14303 Fix batch.size=0 in BuiltInPartitioner

2022-10-14 Thread GitBox
soarez commented on PR #12752: URL: https://github.com/apache/kafka/pull/12752#issuecomment-1279151952 @artemlivshits could you take a look at this one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] lucasbru commented on pull request #12749: KAFKA-14299: Fix busy polling with separate state restoration

2022-10-14 Thread GitBox
lucasbru commented on PR #12749: URL: https://github.com/apache/kafka/pull/12749#issuecomment-1279148211 @guozhangwang @cadonna Do you want to have a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] wcarlson5 commented on a diff in pull request #12465: KAFKA-12950: Replace EasyMock and PowerMock with Mockito for KafkaStreamsTest

2022-10-14 Thread GitBox
wcarlson5 commented on code in PR #12465: URL: https://github.com/apache/kafka/pull/12465#discussion_r995860323 ## streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java: ## @@ -1096,7 +1096,7 @@ private Optional removeStreamThread(final long timeoutMs) throws

[GitHub] [kafka] soarez opened a new pull request, #12752: KAFKA-14303 Fix batch.size=0 in BuiltInPartitioner

2022-10-14 Thread GitBox
soarez opened a new pull request, #12752: URL: https://github.com/apache/kafka/pull/12752 This fixes an bug which causes a call to producer.send(record) with a record without a key and configured with batch.size=0 never to return. Without specifying a key or a custom partitioner the

[GitHub] [kafka] ijuma commented on pull request #12621: CC-17475 Migrate connect system tests to KRaft

2022-10-14 Thread GitBox
ijuma commented on PR #12621: URL: https://github.com/apache/kafka/pull/12621#issuecomment-1279070040 cc @rondagostino -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [kafka] ijuma commented on pull request #12666: KAFKA-14244: Add guard against accidental calls to halt JVM during testing

2022-10-14 Thread GitBox
ijuma commented on PR #12666: URL: https://github.com/apache/kafka/pull/12666#issuecomment-1279069434 I think there's no way around the junit extension, but I was wondering if we could use that with the `Exit` classes versus the security manager approach. Then we don't have to depend on

[GitHub] [kafka] ijuma commented on pull request #12148: MINOR: Remove unnecessary log4j-appender dependency and tweak explicit log4j dependency

2022-10-14 Thread GitBox
ijuma commented on PR #12148: URL: https://github.com/apache/kafka/pull/12148#issuecomment-1279058422 @omkreddy Rebased. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [kafka] ijuma opened a new pull request, #12751: MINOR: Include TLS version in transport layer debug log

2022-10-14 Thread GitBox
ijuma opened a new pull request, #12751: URL: https://github.com/apache/kafka/pull/12751 This was helpful when debugging an issue recently. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build

[GitHub] [kafka] ijuma commented on a diff in pull request #12734: KAFKA-14255; Return an empty record instead of an OffsetOutOfRangeException when fetching from a follower without a leader epoch

2022-10-14 Thread GitBox
ijuma commented on code in PR #12734: URL: https://github.com/apache/kafka/pull/12734#discussion_r995790517 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -1339,6 +1341,26 @@ class Partition(val topicPartition: TopicPartition, } } +// Fetching

[GitHub] [kafka] ijuma commented on pull request #12657: MINOR: More verbose display granularity in gradle test logging

2022-10-14 Thread GitBox
ijuma commented on PR #12657: URL: https://github.com/apache/kafka/pull/12657#issuecomment-1279038561 Very nice, thanks for improving this! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] ijuma commented on pull request #12688: MINOR: Delete config/kraft/README.md

2022-10-14 Thread GitBox
ijuma commented on PR #12688: URL: https://github.com/apache/kafka/pull/12688#issuecomment-1279035666 Since I broke this, I went ahead and submitted a PR https://github.com/apache/kafka/pull/12750 Thanks for flagging this @conradlco . -- This is an automated message from the

[GitHub] [kafka] ijuma opened a new pull request, #12750: MINOR: Inline "Running a Kafka broker in KRaft mode"

2022-10-14 Thread GitBox
ijuma opened a new pull request, #12750: URL: https://github.com/apache/kafka/pull/12750 Also moved KRaft mode above zk mode. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ]

[GitHub] [kafka] lucasbru opened a new pull request, #12749: KAFKA-14299: Fix busy polling with separate state restoration

2022-10-14 Thread GitBox
lucasbru opened a new pull request, #12749: URL: https://github.com/apache/kafka/pull/12749 StreamThread in state PARTITIONS_ASSIGNED was running in a busy loop until restoration is finished, stealing CPU cycles from restoration and other StreamThreads on the machine. Added unit

[jira] [Commented] (KAFKA-14133) Remaining EasyMock to Mockito tests

2022-10-14 Thread Shekhar Prasad Rajak (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17617714#comment-17617714 ] Shekhar Prasad Rajak commented on KAFKA-14133: -- Please help in PR review:    *

[jira] [Assigned] (KAFKA-14303) Producer.send without record key and batch.size=0 goes into infinite loop

2022-10-14 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Soarez reassigned KAFKA-14303: --- Assignee: Igor Soarez > Producer.send without record key and batch.size=0 goes into

[jira] [Commented] (KAFKA-14303) Producer.send without record key and batch.size=0 goes into infinite loop

2022-10-14 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17617712#comment-17617712 ] Igor Soarez commented on KAFKA-14303: -  [~showuon] Yes, I'm currently investigating and hoping to

[GitHub] [kafka] shekhar-rajak commented on pull request #12739: Replace EasyMock and PowerMock with Mockito | TimeOrderedCachingPersistentWindowStoreTest

2022-10-14 Thread GitBox
shekhar-rajak commented on PR #12739: URL: https://github.com/apache/kafka/pull/12739#issuecomment-1278967518 Ping for the PR review @C0urante Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] shekhar-rajak commented on pull request #12739: Replace EasyMock and PowerMock with Mockito | TimeOrderedCachingPersistentWindowStoreTest

2022-10-14 Thread GitBox
shekhar-rajak commented on PR #12739: URL: https://github.com/apache/kafka/pull/12739#issuecomment-1278966484 Thanks @guozhangwang for the review. I have updated the PR, please have a look. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] shekhar-rajak commented on pull request #12735: Replace EasyMock and PowerMock with Mockito in connect/runtime/ErrorHandlingTaskTest | KAFKA-14059

2022-10-14 Thread GitBox
shekhar-rajak commented on PR #12735: URL: https://github.com/apache/kafka/pull/12735#issuecomment-1278952145 Thanks @divijvaidya for the review. I have updated the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] shekhar-rajak commented on pull request #12735: Replace EasyMock and PowerMock with Mockito in connect/runtime/ErrorHandlingTaskTest | KAFKA-14059

2022-10-14 Thread GitBox
shekhar-rajak commented on PR #12735: URL: https://github.com/apache/kafka/pull/12735#issuecomment-1278951012 Failing tests seem unrelated [ org.apache.kafka.connect.mirror.integration.IdentityReplicationIntegrationTest.testReplication() KStream ] -- This is an automated

[GitHub] [kafka] shekhar-rajak commented on pull request #12739: Replace EasyMock and PowerMock with Mockito | TimeOrderedCachingPersistentWindowStoreTest

2022-10-14 Thread GitBox
shekhar-rajak commented on PR #12739: URL: https://github.com/apache/kafka/pull/12739#issuecomment-1278946808 Failing tests seem unrelated [ kafka.admin.ResetConsumerGroupOffsetTest.testResetOffsetsToZonedDateTime,

[jira] [Commented] (KAFKA-14303) Producer.send without record key and batch.size=0 goes into infinite loop

2022-10-14 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17617696#comment-17617696 ] Luke Chen commented on KAFKA-14303: --- [~soarez] , thanks for reporting the issue. Looks like you've

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #12561: KAFKA-12495: Exponential backoff retry to prevent rebalance storms when worker joins after revoking rebalance

2022-10-14 Thread GitBox
vamossagar12 commented on code in PR #12561: URL: https://github.com/apache/kafka/pull/12561#discussion_r995680008 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorIncrementalTest.java: ## @@ -517,13 +517,13 @@ public void

[jira] [Commented] (KAFKA-14303) Producer.send without record key and batch.size=0 goes into infinite loop

2022-10-14 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17617666#comment-17617666 ] Igor Soarez commented on KAFKA-14303: - The issue can be more specifically replicated with a unit

[jira] [Updated] (KAFKA-14302) Infinite probing rebalance if a changelog topic got emptied

2022-10-14 Thread Damien Gasparina (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Damien Gasparina updated KAFKA-14302: - Description: If a store, with a changelog topic, has been fully emptied, it could

[jira] [Created] (KAFKA-14303) Producer.send without record key and batch.size=0 goes into infinite loop

2022-10-14 Thread Igor Soarez (Jira)
Igor Soarez created KAFKA-14303: --- Summary: Producer.send without record key and batch.size=0 goes into infinite loop Key: KAFKA-14303 URL: https://issues.apache.org/jira/browse/KAFKA-14303 Project:

[jira] [Created] (KAFKA-14302) Infinite probing rebalance if a changelog topic got emptied

2022-10-14 Thread Damien Gasparina (Jira)
Damien Gasparina created KAFKA-14302: Summary: Infinite probing rebalance if a changelog topic got emptied Key: KAFKA-14302 URL: https://issues.apache.org/jira/browse/KAFKA-14302 Project: Kafka

[GitHub] [kafka] shekhar-rajak commented on pull request #12739: Replace EasyMock and PowerMock with Mockito | TimeOrderedCachingPersistentWindowStoreTest

2022-10-14 Thread GitBox
shekhar-rajak commented on PR #12739: URL: https://github.com/apache/kafka/pull/12739#issuecomment-1278750513 Not sure why these checks failed. These failures are not looking relevant. Please someone help. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] showuon commented on pull request #12688: MINOR: Delete config/kraft/README.md

2022-10-14 Thread GitBox
showuon commented on PR #12688: URL: https://github.com/apache/kafka/pull/12688#issuecomment-1278745345 @conradlco , nice find. Are you interested in submitting a PR to fix it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] conradlco commented on pull request #12688: MINOR: Delete config/kraft/README.md

2022-10-14 Thread GitBox
conradlco commented on PR #12688: URL: https://github.com/apache/kafka/pull/12688#issuecomment-1278739819 @ijuma - hi Ismael, I just went to the main branch readme: https://github.com/apache/kafka#readme and this now has a broken link to this deleted readme, cheers. -- This is an

[GitHub] [kafka] showuon opened a new pull request, #12748: KAFKA-13715: add generationId field in subscription

2022-10-14 Thread GitBox
showuon opened a new pull request, #12748: URL: https://github.com/apache/kafka/pull/12748 KIP-792 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation

[GitHub] [kafka] cadonna commented on a diff in pull request #12465: KAFKA-12950: Replace EasyMock and PowerMock with Mockito for KafkaStreamsTest

2022-10-14 Thread GitBox
cadonna commented on code in PR #12465: URL: https://github.com/apache/kafka/pull/12465#discussion_r995461375 ## streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java: ## @@ -1096,7 +1096,7 @@ private Optional removeStreamThread(final long timeoutMs) throws Timeout

[GitHub] [kafka] cadonna commented on a diff in pull request #12743: KAFKA-14299: Fix incorrect pauses in separate state restoration

2022-10-14 Thread GitBox
cadonna commented on code in PR #12743: URL: https://github.com/apache/kafka/pull/12743#discussion_r995454259 ## streams/src/test/java/org/apache/kafka/streams/integration/SmokeTestDriverIntegrationTest.java: ## @@ -42,18 +43,18 @@ import static

[GitHub] [kafka] cadonna commented on a diff in pull request #12743: KAFKA-14299: Fix incorrect pauses in separate state restoration

2022-10-14 Thread GitBox
cadonna commented on code in PR #12743: URL: https://github.com/apache/kafka/pull/12743#discussion_r995452727 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java: ## @@ -1481,6 +1481,36 @@ public void

[GitHub] [kafka] lucasbru commented on a diff in pull request #12743: KAFKA-14299: Fix incorrect pauses in separate state restoration

2022-10-14 Thread GitBox
lucasbru commented on code in PR #12743: URL: https://github.com/apache/kafka/pull/12743#discussion_r995065939 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java: ## @@ -1481,6 +1481,36 @@ public void

[jira] [Commented] (KAFKA-14287) Multi noded with kraft combined mode will fail shutdown

2022-10-14 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17617521#comment-17617521 ] Luke Chen commented on KAFKA-14287: --- Thanks for the reply. But I don't know how we can fix this issue