dajac commented on PR #12308:
URL: https://github.com/apache/kafka/pull/12308#issuecomment-1308349599
@Stephan14 Many tests, related to your change, failed in the last build.
Could you please take a look?
```
Build / JDK 11 and Scala 2.13 /
[
https://issues.apache.org/jira/browse/KAFKA-14363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot resolved KAFKA-14363.
-
Resolution: Fixed
> Add new `group-coordinator` module
> --
>
>
dajac merged PR #12827:
URL: https://github.com/apache/kafka/pull/12827
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
clolov commented on PR #12809:
URL: https://github.com/apache/kafka/pull/12809#issuecomment-1308324630
Thank you for the review! All of these are valid suggestions, I will aim to
get them done today.
--
This is an automated message from the Apache Git Service.
To respond to the message,
cmccabe commented on code in PR #12776:
URL: https://github.com/apache/kafka/pull/12776#discussion_r1017514589
##
core/src/main/scala/kafka/server/metadata/DynamicConfigPublisher.scala:
##
@@ -0,0 +1,126 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or
cmccabe commented on code in PR #12776:
URL: https://github.com/apache/kafka/pull/12776#discussion_r1017514589
##
core/src/main/scala/kafka/server/metadata/DynamicConfigPublisher.scala:
##
@@ -0,0 +1,126 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or
cmccabe opened a new pull request, #12837:
URL: https://github.com/apache/kafka/pull/12837
Extract jointly owned parts of BrokerServer and ControllerServer into
JointServer. Shut down JointServer when the last component using it shuts down.
(But make sure to stop the raft manager before
showuon commented on PR #12748:
URL: https://github.com/apache/kafka/pull/12748#issuecomment-1308231893
@dajac , I've addressed all comments. Please take a look when available.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
showuon commented on code in PR #12748:
URL: https://github.com/apache/kafka/pull/12748#discussion_r1017442642
##
clients/src/test/java/org/apache/kafka/clients/consumer/CooperativeStickyAssignorTest.java:
##
@@ -78,6 +80,26 @@ public void testDecodeGeneration() {
[
https://issues.apache.org/jira/browse/KAFKA-12679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17630754#comment-17630754
]
A. Sophie Blee-Goldman commented on KAFKA-12679:
Ah ok, thanks for the update. Regarding
[
https://issues.apache.org/jira/browse/KAFKA-12679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17630746#comment-17630746
]
BIRINDER TIWANA commented on KAFKA-12679:
-
Actually the root cause of our issue turned out to be
showuon commented on code in PR #12748:
URL: https://github.com/apache/kafka/pull/12748#discussion_r1017395682
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerProtocolTest.java:
##
@@ -146,43 +165,22 @@ public void
showuon commented on code in PR #12748:
URL: https://github.com/apache/kafka/pull/12748#discussion_r1017395458
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerProtocolTest.java:
##
@@ -247,4 +245,42 @@ public void
showuon commented on code in PR #12748:
URL: https://github.com/apache/kafka/pull/12748#discussion_r1017394471
##
clients/src/test/java/org/apache/kafka/clients/consumer/CooperativeStickyAssignorTest.java:
##
@@ -78,6 +80,26 @@ public void testDecodeGeneration() {
[
https://issues.apache.org/jira/browse/KAFKA-12679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17630721#comment-17630721
]
A. Sophie Blee-Goldman commented on KAFKA-12679:
Huh, I thought we had already fixed
[
https://issues.apache.org/jira/browse/KAFKA-14362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17630717#comment-17630717
]
A. Sophie Blee-Goldman commented on KAFKA-14362:
Hey [~Carlstedt] you're right about why
[
https://issues.apache.org/jira/browse/KAFKA-14282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17630710#comment-17630710
]
A. Sophie Blee-Goldman commented on KAFKA-14282:
Here we go:
[
https://issues.apache.org/jira/browse/KAFKA-14282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman reassigned KAFKA-14282:
--
Assignee: A. Sophie Blee-Goldman
> RecordCollector throws exception
[
https://issues.apache.org/jira/browse/KAFKA-14282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-14282:
---
Fix Version/s: 3.4.0
> RecordCollector throws exception on message
ableegoldman opened a new pull request, #12836:
URL: https://github.com/apache/kafka/pull/12836
Users have been seeing a large number of these error messages being logged
by the RecordCollectorImpl:
```
Unable to records bytes produced to topic XXX by sink node YYY as the node
is
[
https://issues.apache.org/jira/browse/KAFKA-14282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17630707#comment-17630707
]
A. Sophie Blee-Goldman commented on KAFKA-14282:
Oh wait I think I know what's going on
[
https://issues.apache.org/jira/browse/KAFKA-14360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman reassigned KAFKA-14360:
--
Assignee: A. Sophie Blee-Goldman
> Documentation: Streams Security
[
https://issues.apache.org/jira/browse/KAFKA-14360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-14360:
---
Fix Version/s: 3.4.0
> Documentation: Streams Security page has broken
[
https://issues.apache.org/jira/browse/KAFKA-14360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17630702#comment-17630702
]
A. Sophie Blee-Goldman commented on KAFKA-14360:
Weird, thanks for finding this – I'm
jeffkbkim commented on code in PR #12783:
URL: https://github.com/apache/kafka/pull/12783#discussion_r1017328926
##
core/src/main/scala/kafka/server/ReplicaFetcherThread.scala:
##
@@ -135,6 +151,13 @@ class ReplicaFetcherThread(name: String,
logAppendInfo
}
+ private
ableegoldman opened a new pull request, #12835:
URL: https://github.com/apache/kafka/pull/12835
Add a new `#transactionInFlight` API to the StreamsProducer to expose the
flag of the same name, then check whether there is an open transaction when we
determine whether or not to perform a
[
https://issues.apache.org/jira/browse/KAFKA-14294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman reassigned KAFKA-14294:
--
Assignee: A. Sophie Blee-Goldman
> Kafka Streams should commit
[
https://issues.apache.org/jira/browse/KAFKA-14294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17630678#comment-17630678
]
A. Sophie Blee-Goldman commented on KAFKA-14294:
I guess we should just remove that
[
https://issues.apache.org/jira/browse/KAFKA-13891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-13891:
---
Fix Version/s: 3.4.0
(was: 3.3.0)
[
https://issues.apache.org/jira/browse/KAFKA-13891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman reopened KAFKA-13891:
Reopening – original fix was reverted, we should instead fix this
ableegoldman commented on code in PR #12809:
URL: https://github.com/apache/kafka/pull/12809#discussion_r1017262697
##
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter.java:
##
@@ -338,14 +338,13 @@ public
hachikuji commented on code in PR #12776:
URL: https://github.com/apache/kafka/pull/12776#discussion_r1017244308
##
core/src/main/scala/kafka/server/metadata/DynamicConfigPublisher.scala:
##
@@ -0,0 +1,126 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
hachikuji commented on code in PR #12776:
URL: https://github.com/apache/kafka/pull/12776#discussion_r1017244308
##
core/src/main/scala/kafka/server/metadata/DynamicConfigPublisher.scala:
##
@@ -0,0 +1,126 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
hachikuji commented on code in PR #12776:
URL: https://github.com/apache/kafka/pull/12776#discussion_r1017238973
##
core/src/main/scala/kafka/server/KafkaRaftServer.scala:
##
@@ -69,95 +64,54 @@ class KafkaRaftServer(
private val controllerQuorumVotersFuture =
jsancio commented on code in PR #12833:
URL: https://github.com/apache/kafka/pull/12833#discussion_r1017191691
##
core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala:
##
@@ -398,8 +398,11 @@ class BrokerMetadataListener(
build()
try {
kirktrue closed pull request #12816: KAFKA-14274: take 2
URL: https://github.com/apache/kafka/pull/12816
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
kirktrue closed pull request #12831: KAFKA-14365: Refactor Fetcher to allow
different implementations
URL: https://github.com/apache/kafka/pull/12831
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
kirktrue opened a new pull request, #12834:
URL: https://github.com/apache/kafka/pull/12834
(This is a stacked PR on top of #12832.)
Introduce the generalized `Fetcher` interface, update `DefaultFetcher` to
implement the `Fetcher` interface, and update relevant call sites to use the
cmccabe opened a new pull request, #12833:
URL: https://github.com/apache/kafka/pull/12833
Properly close ImageWriter objects in BrokerMetadataListener and
BrokerMetadataSnapshotter. Add a time limit on BrokerMetadataSnapshotterTest.
--
This is an automated message from the Apache Git
Colin McCabe created KAFKA-14370:
Summary: Properly close ImageWriter objects
Key: KAFKA-14370
URL: https://issues.apache.org/jira/browse/KAFKA-14370
Project: Kafka
Issue Type: Bug
[
https://issues.apache.org/jira/browse/KAFKA-14362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mikael updated KAFKA-14362:
---
Description:
Trigger scenario:
Two Kafka client application instances on separate EC2 instances with one
kirktrue opened a new pull request, #12832:
URL: https://github.com/apache/kafka/pull/12832
Rename `Fetcher` to `DefaultFetcher` as part of process to allow multiple
implementations of the `Fetcher` API.
*More detailed description of your change,
if necessary. The PR title and PR
[
https://issues.apache.org/jira/browse/KAFKA-14366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17630581#comment-17630581
]
Philip Nee commented on KAFKA-14366:
Hey [~Chetu] - thanks for reporting this, could you kindly
[
https://issues.apache.org/jira/browse/KAFKA-14358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
José Armando García Sancio reassigned KAFKA-14358:
--
Assignee: José Armando García Sancio
> Users should not be
Domenic Bove created KAFKA-14369:
Summary: Docs - KRAFT controller authentication example
Key: KAFKA-14369
URL: https://issues.apache.org/jira/browse/KAFKA-14369
Project: Kafka
Issue Type:
[
https://issues.apache.org/jira/browse/KAFKA-14369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Domenic Bove updated KAFKA-14369:
-
Description:
The [Kafka Listener docs
[
https://issues.apache.org/jira/browse/KAFKA-8059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Harris reassigned KAFKA-8059:
--
Assignee: Greg Harris
> Flaky Test DynamicConnectionQuotaTest #testDynamicConnectionQuota
>
[
https://issues.apache.org/jira/browse/KAFKA-12511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Harris reassigned KAFKA-12511:
---
Assignee: Greg Harris
> Flaky test
>
[
https://issues.apache.org/jira/browse/KAFKA-8115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Harris reassigned KAFKA-8115:
--
Assignee: Greg Harris
> Flaky Test CoordinatorTest#testTaskRequestWithOldStartMsGetsUpdated
>
[
https://issues.apache.org/jira/browse/KAFKA-14357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17630534#comment-17630534
]
Mickael Maison commented on KAFKA-14357:
I took a look at these APIs to see what can be done.
*
C0urante commented on PR #12366:
URL: https://github.com/apache/kafka/pull/12366#issuecomment-1307551086
This was proposed in the original PR for MM2, but decided against:
https://github.com/apache/kafka/pull/6295#discussion_r290372816
I was on the fence about adding something now
cadonna merged PR #12808:
URL: https://github.com/apache/kafka/pull/12808
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
cadonna commented on PR #12808:
URL: https://github.com/apache/kafka/pull/12808#issuecomment-1307526346
Build failures are not related:
```
Build / JDK 11 and Scala 2.13 /
kafka.network.ConnectionQuotasTest.testListenerConnectionRateLimitWhenActualRateAboveLimit()
```
--
This is
cmccabe merged PR #12829:
URL: https://github.com/apache/kafka/pull/12829
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dajac commented on code in PR #12827:
URL: https://github.com/apache/kafka/pull/12827#discussion_r1016821182
##
build.gradle:
##
@@ -1222,6 +1225,42 @@ project(':metadata') {
}
}
+project(':group-coordinator') {
+ archivesBaseName = "kafka-group-coordinator"
+
+
ijuma commented on code in PR #12827:
URL: https://github.com/apache/kafka/pull/12827#discussion_r1016813429
##
build.gradle:
##
@@ -1222,6 +1225,42 @@ project(':metadata') {
}
}
+project(':group-coordinator') {
+ archivesBaseName = "kafka-group-coordinator"
+
+
[
https://issues.apache.org/jira/browse/KAFKA-14358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lucia Cerchie reassigned KAFKA-14358:
-
Assignee: Lucia Cerchie (was: José Armando García Sancio)
> Users should not be able
[
https://issues.apache.org/jira/browse/KAFKA-14128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lucia Cerchie reassigned KAFKA-14128:
-
Assignee: Lucia Cerchie
> Kafka Streams terminates on topic check
>
[
https://issues.apache.org/jira/browse/KAFKA-14358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lucia Cerchie reassigned KAFKA-14358:
-
Assignee: (was: Lucia Cerchie)
> Users should not be able to create a regular
dajac commented on code in PR #12827:
URL: https://github.com/apache/kafka/pull/12827#discussion_r1016794520
##
build.gradle:
##
@@ -1222,6 +1225,41 @@ project(':metadata') {
}
}
+project(':group-coordinator') {
+ archivesBaseName = "kafka-group-coordinator"
+
+
dajac commented on code in PR #12827:
URL: https://github.com/apache/kafka/pull/12827#discussion_r1016794025
##
build.gradle:
##
@@ -1222,6 +1225,41 @@ project(':metadata') {
}
}
+project(':group-coordinator') {
+ archivesBaseName = "kafka-group-coordinator"
+
+
Stephan14 commented on PR #12308:
URL: https://github.com/apache/kafka/pull/12308#issuecomment-1307399716
@dajac I have fix it and can you review it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
Stephan14 commented on code in PR #12308:
URL: https://github.com/apache/kafka/pull/12308#discussion_r1016779023
##
core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorTest.scala:
##
@@ -1036,6 +1036,52 @@ class GroupCoordinatorTest {
assertEquals(Errors.NONE,
C0urante commented on PR #12544:
URL: https://github.com/apache/kafka/pull/12544#issuecomment-1307392191
Thanks Mickael!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
C0urante merged PR #12544:
URL: https://github.com/apache/kafka/pull/12544
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ijuma commented on code in PR #12827:
URL: https://github.com/apache/kafka/pull/12827#discussion_r1016751779
##
build.gradle:
##
@@ -1222,6 +1225,41 @@ project(':metadata') {
}
}
+project(':group-coordinator') {
+ archivesBaseName = "kafka-group-coordinator"
+
+
ijuma commented on code in PR #12827:
URL: https://github.com/apache/kafka/pull/12827#discussion_r1016750711
##
build.gradle:
##
@@ -1222,6 +1225,41 @@ project(':metadata') {
}
}
+project(':group-coordinator') {
+ archivesBaseName = "kafka-group-coordinator"
+
+
lucasbru commented on code in PR #12795:
URL: https://github.com/apache/kafka/pull/12795#discussion_r1016657641
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##
@@ -1908,6 +1888,7 @@ public void
lucasbru commented on code in PR #12795:
URL: https://github.com/apache/kafka/pull/12795#discussion_r1016657214
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java:
##
@@ -277,6 +294,9 @@ private void addTask(final Task task) {
lucasbru commented on code in PR #12795:
URL: https://github.com/apache/kafka/pull/12795#discussion_r1016644371
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java:
##
@@ -115,6 +117,7 @@ public void run() {
private void
Yash Mayya created KAFKA-14368:
--
Summary: Add an offset write REST API to Kafka Connect
Key: KAFKA-14368
URL: https://issues.apache.org/jira/browse/KAFKA-14368
Project: Kafka
Issue Type: New
cadonna commented on code in PR #12795:
URL: https://github.com/apache/kafka/pull/12795#discussion_r1016598938
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java:
##
@@ -115,6 +117,7 @@ public void run() {
private void
OmniaGM commented on code in PR #12577:
URL: https://github.com/apache/kafka/pull/12577#discussion_r1015481020
##
connect/mirror-client/src/main/java/org/apache/kafka/connect/mirror/MirrorClientConfig.java:
##
@@ -69,6 +74,17 @@ public ReplicationPolicy replicationPolicy() {
OmniaGM commented on PR #12366:
URL: https://github.com/apache/kafka/pull/12366#issuecomment-1307124622
> Thanks @OmniaGM, good idea. I've updated the README and added an
integration test that verifies that MM2 can still run with exactly-once support
enabled.
>
> I should note that
soarez commented on PR #12752:
URL: https://github.com/apache/kafka/pull/12752#issuecomment-1307037576
Could you have another look @ijuma?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/KAFKA-14294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lucas Brutschy reassigned KAFKA-14294:
--
Assignee: (was: Lucas Brutschy)
> Kafka Streams should commit transaction when
[
https://issues.apache.org/jira/browse/KAFKA-14294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lucas Brutschy reassigned KAFKA-14294:
--
Assignee: Lucas Brutschy
> Kafka Streams should commit transaction when no records
[
https://issues.apache.org/jira/browse/KAFKA-13891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17630331#comment-17630331
]
Bruno Cadonna commented on KAFKA-13891:
---
[~jdrean] [~ableegoldman] [~dajac] [~showuon] Should we
David Jacot created KAFKA-14367:
---
Summary: Introduce `GroupCoordinator` interface
Key: KAFKA-14367
URL: https://issues.apache.org/jira/browse/KAFKA-14367
Project: Kafka
Issue Type: Sub-task
[
https://issues.apache.org/jira/browse/KAFKA-14294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17630328#comment-17630328
]
Bruno Cadonna commented on KAFKA-14294:
---
Streams does not commit a transaction if no records have
dajac commented on code in PR #12783:
URL: https://github.com/apache/kafka/pull/12783#discussion_r1016427264
##
core/src/test/scala/unit/kafka/server/ReplicaFetcherThreadTest.scala:
##
@@ -1100,6 +1102,67 @@ class ReplicaFetcherThreadTest {
dajac commented on code in PR #12783:
URL: https://github.com/apache/kafka/pull/12783#discussion_r1016425287
##
core/src/main/scala/kafka/server/ReplicaFetcherThread.scala:
##
@@ -135,6 +151,13 @@ class ReplicaFetcherThread(name: String,
logAppendInfo
}
+ private def
mimaison commented on PR #12577:
URL: https://github.com/apache/kafka/pull/12577#issuecomment-1306884230
Thanks @OmniaGM for the updates. A few test failures seem related:
83 matches
Mail list logo
