ableegoldman commented on PR #12893:
URL: https://github.com/apache/kafka/pull/12893#issuecomment-1326058963
> I see that I also need to make a build trigger request
By the way, this is thankfully no longer the case (it used to be really
annoying and only worked like half the time)
a364176773 commented on PR #12898:
URL: https://github.com/apache/kafka/pull/12898#issuecomment-1326035502
@C0urante PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
dengziming closed pull request #12199: KAFKA-13609: Use INVALID_CONFIG when
config value is null or broker config validation fails
URL: https://github.com/apache/kafka/pull/12199
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
[
https://issues.apache.org/jira/browse/KAFKA-14415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17638119#comment-17638119
]
A. Sophie Blee-Goldman commented on KAFKA-14415:
Nice find, I bet the assumption when
dajac opened a new pull request, #12902:
URL: https://github.com/apache/kafka/pull/12902
WIP
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including
gharris1727 commented on code in PR #12876:
URL: https://github.com/apache/kafka/pull/12876#discussion_r1030729122
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/DistributedHerderTest.java:
##
@@ -2179,6 +2135,7 @@ public void
[
https://issues.apache.org/jira/browse/KAFKA-14417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justine Olshan updated KAFKA-14417:
---
Affects Version/s: 3.4.0
> Producer doesn't handle REQUEST_TIMED_OUT for
gharris1727 commented on code in PR #12876:
URL: https://github.com/apache/kafka/pull/12876#discussion_r1030712499
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/DistributedHerderTest.java:
##
@@ -3735,6 +3750,19 @@ private ClusterConfigState
OmniaGM commented on code in PR #12858:
URL: https://github.com/apache/kafka/pull/12858#discussion_r1030668387
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -1992,6 +1992,186 @@ class KafkaApisTest {
OmniaGM commented on code in PR #12858:
URL: https://github.com/apache/kafka/pull/12858#discussion_r1030667864
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -1992,6 +1992,186 @@ class KafkaApisTest {
OmniaGM commented on code in PR #12858:
URL: https://github.com/apache/kafka/pull/12858#discussion_r1030666809
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -1992,6 +1992,186 @@ class KafkaApisTest {
dajac opened a new pull request, #12901:
URL: https://github.com/apache/kafka/pull/12901
This patch adds `TnxOffsetCommit` to the new `GroupCoordinator` interface
and updates `KafkaApis` to use it.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and
[
https://issues.apache.org/jira/browse/KAFKA-14400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17637240#comment-17637240
]
Victor van den Hoven edited comment on KAFKA-14400 at 11/23/22 4:09 PM:
OmniaGM commented on code in PR #12886:
URL: https://github.com/apache/kafka/pull/12886#discussion_r1030626743
##
core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala:
##
@@ -0,0 +1,169 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
OmniaGM commented on code in PR #12886:
URL: https://github.com/apache/kafka/pull/12886#discussion_r1030626609
##
core/src/main/java/kafka/server/builders/KafkaApisBuilder.java:
##
@@ -178,6 +179,7 @@ public KafkaApis build() {
metadataSupport,
andymg3 commented on code in PR #12305:
URL: https://github.com/apache/kafka/pull/12305#discussion_r933670311
##
clients/src/main/java/org/apache/kafka/common/internals/Topic.java:
##
@@ -33,7 +33,7 @@ public class Topic {
public static final String LEGAL_CHARS =
andymg3 commented on code in PR #12305:
URL: https://github.com/apache/kafka/pull/12305#discussion_r933670311
##
clients/src/main/java/org/apache/kafka/common/internals/Topic.java:
##
@@ -33,7 +33,7 @@ public class Topic {
public static final String LEGAL_CHARS =
C0urante commented on code in PR #12876:
URL: https://github.com/apache/kafka/pull/12876#discussion_r1030468497
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java:
##
@@ -436,15 +436,15 @@ public void tick() {
//
C0urante commented on PR #12891:
URL: https://github.com/apache/kafka/pull/12891#issuecomment-1325247099
@divijvaidya Is string interpolation accounted for with the graphic included
in the description? Forgive me, I'm not familiar with the tooling used to
generate it. It might also help to
divijvaidya commented on PR #12900:
URL: https://github.com/apache/kafka/pull/12900#issuecomment-1325228855
@mdedetrich I believe that you are somewhat of an expert in scala? Mind
looking at this PR please?
--
This is an automated message from the Apache Git Service.
To respond to the
divijvaidya commented on PR #12891:
URL: https://github.com/apache/kafka/pull/12891#issuecomment-1325227441
> @divijvaidya , thanks for the PR. Do you think we can add the check in
`kafka.utils.Logging#trace`?
Hey @showuon
That would not prevent serialization of string which is
divijvaidya opened a new pull request, #12900:
URL: https://github.com/apache/kafka/pull/12900
Multiple changes to improve performance of Scala collection in the code.
Some examples of improvements include:
1. filtering before sorting instead of sorting and then filtering
2.
[
https://issues.apache.org/jira/browse/KAFKA-14176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-14176:
--
Fix Version/s: 3.4.0
> Reduce visibility of WorkerConfig.lookupKafkaClusterId
>
[
https://issues.apache.org/jira/browse/KAFKA-12610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton resolved KAFKA-12610.
---
Fix Version/s: 3.4.0
Resolution: Fixed
> Resources on classpath break
[
https://issues.apache.org/jira/browse/KAFKA-12610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton reassigned KAFKA-12610:
-
Assignee: Greg Harris (was: Nigel Liang)
> Resources on classpath break
C0urante merged PR #12805:
URL: https://github.com/apache/kafka/pull/12805
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mimaison opened a new pull request, #12899:
URL: https://github.com/apache/kafka/pull/12899
This also adds 3 new Gradle tasks
(`:connect:mirror:genMirrorSourceConfigDocs`,
`:connect:mirror:genMirrorCheckpointConfigDocs` and
`:connect:mirror:genMirrorHeartbeatConfigDocs`) to generate the
tombentley commented on code in PR #12895:
URL: https://github.com/apache/kafka/pull/12895#discussion_r1030288075
##
clients/src/main/java/org/apache/kafka/clients/admin/package-info.java:
##
@@ -0,0 +1,20 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
a364176773 opened a new pull request, #12898:
URL: https://github.com/apache/kafka/pull/12898
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
In case the server
[
https://issues.apache.org/jira/browse/KAFKA-14362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17637682#comment-17637682
]
Mikael commented on KAFKA-14362:
Hang on, I just spotted something in spring-kafka: failed offset
dajac commented on PR #12845:
URL: https://github.com/apache/kafka/pull/12845#issuecomment-1324739555
I have addressed Jason's comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
dajac commented on code in PR #12845:
URL: https://github.com/apache/kafka/pull/12845#discussion_r1030180438
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorRequestContext.java:
##
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software
dajac commented on code in PR #12845:
URL: https://github.com/apache/kafka/pull/12845#discussion_r1030179126
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorRequestContext.java:
##
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software
Scanteianu commented on PR #12753:
URL: https://github.com/apache/kafka/pull/12753#issuecomment-1324718868
@showuon thanks for the comments, addressed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
[
https://issues.apache.org/jira/browse/KAFKA-14362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17637614#comment-17637614
]
Mikael commented on KAFKA-14362:
This patch in kafka-clients fixed the duplication issue with my
35 matches
Mail list logo
