[GitHub] [kafka] yashmayya commented on pull request #12947: KAFKA-6586: Refactor ConnectDistributed and ConnectStandalone to re-use shared logic

2022-12-03 Thread GitBox
yashmayya commented on PR #12947: URL: https://github.com/apache/kafka/pull/12947#issuecomment-1336336173 Hi @C0urante, would you be able to take a look at this whenever possible? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] ijuma merged pull request #12949: MINOR: Remove unused `ApiUtils`

2022-12-03 Thread GitBox
ijuma merged PR #12949: URL: https://github.com/apache/kafka/pull/12949 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] ijuma commented on pull request #12948: MINOR: Add JDK 19 & Scala 2.13 CI build

2022-12-03 Thread GitBox
ijuma commented on PR #12948: URL: https://github.com/apache/kafka/pull/12948#issuecomment-1336297376 #12675 needs to be merged for this to work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] ijuma commented on a diff in pull request #12675: KAFKA-14256: Upgrade from Scala 2.13.8 to 2.13.10

2022-12-03 Thread GitBox
ijuma commented on code in PR #12675: URL: https://github.com/apache/kafka/pull/12675#discussion_r1038894058 ## build.gradle: ## @@ -647,6 +647,9 @@ subprojects { "-Xlint:unused" ] +if (versions.baseScala == '2.13') +

[GitHub] [kafka] ijuma opened a new pull request, #12950: MINOR: Remove KafkaTimer

2022-12-03 Thread GitBox
ijuma opened a new pull request, #12950: URL: https://github.com/apache/kafka/pull/12950 It doesn't add much value since lambdas were introduced in Java 8. Also remove KafkaTimerTest. ### Committer Checklist (excluded from commit message) - [ ] Verify design and

[GitHub] [kafka] ijuma opened a new pull request, #12949: MINOR: Remove unused `ApiUtils`

2022-12-03 Thread GitBox
ijuma opened a new pull request, #12949: URL: https://github.com/apache/kafka/pull/12949 Also remove `ApiUtilsTest`. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify

[jira] [Updated] (KAFKA-14437) Enhance StripedReplicaPlacer to account for existing partition assignments

2022-12-03 Thread Andrew Grant (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Grant updated KAFKA-14437: - Description: Currently, in StripedReplicaPlacer we don’t take existing partition assignments

[GitHub] [kafka] ijuma opened a new pull request, #12948: MINOR: Add JDK 19 & Scala 2.13 CI build

2022-12-03 Thread GitBox
ijuma opened a new pull request, #12948: URL: https://github.com/apache/kafka/pull/12948 It's good for us to track the latest JDK version supported by Gradle. Given that Scala 2.12 support has been deprecated, I did not include a Scala 2.12 variant. ### Committer

[GitHub] [kafka] mumrah commented on pull request #12946: KAFKA-14427 ZK client support for migrations

2022-12-03 Thread GitBox
mumrah commented on PR #12946: URL: https://github.com/apache/kafka/pull/12946#issuecomment-1336208057 @dengziming -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [kafka] yashmayya opened a new pull request, #12947: KAFKA-6586: Refactor ConnectDistributed and ConnectStandalone to re-use shared logic

2022-12-03 Thread GitBox
yashmayya opened a new pull request, #12947: URL: https://github.com/apache/kafka/pull/12947 - From the [JIRA ticket](https://issues.apache.org/jira/browse/KAFKA-6586): > The main methods in ConnectDistributed and ConnectStandalone have a lot of duplication, and it'd be good to refactor

[jira] [Assigned] (KAFKA-6586) Refactor Connect executables

2022-12-03 Thread Yash Mayya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yash Mayya reassigned KAFKA-6586: - Assignee: Yash Mayya > Refactor Connect executables > > >

[jira] [Updated] (KAFKA-14440) Local state wipeout with EOS

2022-12-03 Thread Abdullah alkhawatrah (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abdullah alkhawatrah updated KAFKA-14440: - Description: Hey, I have a kafka streams service that aggregates events from

[jira] [Updated] (KAFKA-14440) Local state wipeout with EOS

2022-12-03 Thread Abdullah alkhawatrah (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abdullah alkhawatrah updated KAFKA-14440: - Description: Hey, I have a kafka streams service that aggregates events from

[jira] [Created] (KAFKA-14440) Local state wipeout with EOS

2022-12-03 Thread Abdullah alkhawatrah (Jira)
Abdullah alkhawatrah created KAFKA-14440: Summary: Local state wipeout with EOS Key: KAFKA-14440 URL: https://issues.apache.org/jira/browse/KAFKA-14440 Project: Kafka Issue Type: Bug

[GitHub] [kafka] yashmayya commented on a diff in pull request #12800: KAFKA-14342: KafkaOffsetBackingStore should clear offsets for source partitions on tombstone messages

2022-12-03 Thread GitBox
yashmayya commented on code in PR #12800: URL: https://github.com/apache/kafka/pull/12800#discussion_r1038756498 ## connect/runtime/src/test/java/org/apache/kafka/connect/storage/KafkaOffsetBackingStoreTest.java: ## @@ -329,6 +329,60 @@ public void testGetSetNull() throws

[jira] [Commented] (KAFKA-14439) Specify returned errors for various APIs and versions

2022-12-03 Thread Tom Bentley (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642800#comment-17642800 ] Tom Bentley commented on KAFKA-14439: - FWIW I spent some time on this a few years ago, see