[jira] [Created] (KAFKA-14687) Possible issue on documentation : producerConfig -> retries

2023-02-07 Thread Ahmed Toumi (Jira)
Ahmed Toumi created KAFKA-14687: --- Summary: Possible issue on documentation : producerConfig -> retries Key: KAFKA-14687 URL: https://issues.apache.org/jira/browse/KAFKA-14687 Project: Kafka Is

[GitHub] [kafka] clolov commented on pull request #13212: MINOR: Remove accidental unnecessary code; fix comment references; use bulk operations

2023-02-07 Thread via GitHub
clolov commented on PR #13212: URL: https://github.com/apache/kafka/pull/13212#issuecomment-1420626007 @divijvaidya for visibility -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [kafka] clolov opened a new pull request, #13212: MINOR: Remove accidental unnecessary code; fix comment references; use bulk operations

2023-02-07 Thread via GitHub
clolov opened a new pull request, #13212: URL: https://github.com/apache/kafka/pull/13212 I ran IntelliJ IDEA's Code Inspection and corrected occurrences of the following: * https://www.jetbrains.com/help/idea/list-of-java-inspections.html#javadoc (declaration has problems in Javadoc ref

[GitHub] [kafka] mimaison commented on pull request #12366: KAFKA-14021: Implement new KIP-618 APIs in MirrorSourceConnector

2023-02-07 Thread via GitHub
mimaison commented on PR #12366: URL: https://github.com/apache/kafka/pull/12366#issuecomment-1420613374 @C0urante Let's try to get this in. If you rebase I'll take another look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] rajinisivaram opened a new pull request, #13211: KAFKA-14676: Include all SASL configs in login cache key to ensure clients in a JVM can use different OAuth configs

2023-02-07 Thread via GitHub
rajinisivaram opened a new pull request, #13211: URL: https://github.com/apache/kafka/pull/13211 We currently cache login managers in static maps for both static JAAS config using system property and for JAAS config specified using Kafka config `sasl.jaas.config`. In addition to the JAAS co

[GitHub] [kafka] mimaison commented on pull request #13208: KAFKA-5756: Wait for concurrent offset flush to complete before starting next flush

2023-02-07 Thread via GitHub
mimaison commented on PR #13208: URL: https://github.com/apache/kafka/pull/13208#issuecomment-1420604272 Thanks @gharris1727 for the PR! The changes look good to me. Since it's an old and tricky issue, I'd like @C0urante to also take a look, if possible, before merging. -- This is an aut

[GitHub] [kafka] fvaleri commented on a diff in pull request #13122: KAFKA-14594: Move LogDirsCommand to tools module

2023-02-07 Thread via GitHub
fvaleri commented on code in PR #13122: URL: https://github.com/apache/kafka/pull/13122#discussion_r1098517712 ## clients/src/test/java/org/apache/kafka/clients/admin/MockAdminClient.java: ## @@ -870,7 +870,37 @@ synchronized public AlterReplicaLogDirsResult alterReplicaLogDirs

[GitHub] [kafka] fvaleri commented on a diff in pull request #13122: KAFKA-14594: Move LogDirsCommand to tools module

2023-02-07 Thread via GitHub
fvaleri commented on code in PR #13122: URL: https://github.com/apache/kafka/pull/13122#discussion_r1098445584 ## tools/src/main/java/org/apache/kafka/tools/LogDirsCommand.java: ## @@ -0,0 +1,174 @@ +package org.apache.kafka.tools; + +import com.fasterxml.jackson.core.JsonProces

[GitHub] [kafka] fvaleri commented on a diff in pull request #13122: KAFKA-14594: Move LogDirsCommand to tools module

2023-02-07 Thread via GitHub
fvaleri commented on code in PR #13122: URL: https://github.com/apache/kafka/pull/13122#discussion_r1098445584 ## tools/src/main/java/org/apache/kafka/tools/LogDirsCommand.java: ## @@ -0,0 +1,174 @@ +package org.apache.kafka.tools; + +import com.fasterxml.jackson.core.JsonProces

[GitHub] [kafka] clolov commented on pull request #13210: MINOR: Remove accidental unnecessary code

2023-02-07 Thread via GitHub
clolov commented on PR #13210: URL: https://github.com/apache/kafka/pull/13210#issuecomment-1420581252 @divijvaidya for visibility -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [kafka] clolov opened a new pull request, #13210: MINOR: Remove accidental unnecessary code

2023-02-07 Thread via GitHub
clolov opened a new pull request, #13210: URL: https://github.com/apache/kafka/pull/13210 I ran IntelliJ IDEA's Code Inspection and corrected occurrences of the following: * https://www.jetbrains.com/help/idea/list-of-java-inspections.html#class-structure (final method in final class)

[GitHub] [kafka] mimaison commented on a diff in pull request #13203: KAFKA-14048: Add new `__consumer_offsets` records from KIP-848

2023-02-07 Thread via GitHub
mimaison commented on code in PR #13203: URL: https://github.com/apache/kafka/pull/13203#discussion_r1098462254 ## group-coordinator/src/main/resources/common/message/ConsumerGroupCurrentMemberAssignmentKey.json: ## @@ -0,0 +1,26 @@ +// Licensed to the Apache Software Foundation

[GitHub] [kafka] satishd merged pull request #13046: KAFKA-14551 Move/Rewrite LeaderEpochFileCache and its dependencies to the storage module.

2023-02-07 Thread via GitHub
satishd merged PR #13046: URL: https://github.com/apache/kafka/pull/13046 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[jira] [Commented] (KAFKA-14631) Compression optimization: do not read the key/value for last record in the batch

2023-02-07 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17685186#comment-17685186 ] Divij Vaidya commented on KAFKA-14631: -- Today, in the code, we validate that not un

[jira] [Commented] (KAFKA-14635) Compression optimization: Use direct memory buffers for (de)compression

2023-02-07 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17685183#comment-17685183 ] Divij Vaidya commented on KAFKA-14635: -- This might not have much benefit since Zstd

[GitHub] [kafka] satishd commented on pull request #13046: KAFKA-14551 Move/Rewrite LeaderEpochFileCache and its dependencies to the storage module.

2023-02-07 Thread via GitHub
satishd commented on PR #13046: URL: https://github.com/apache/kafka/pull/13046#issuecomment-1420484181 Test failures do not seem to be related to the PR changes, merging to trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[jira] [Commented] (KAFKA-14630) Update zstd-jni version to 1.5.2-5

2023-02-07 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17685181#comment-17685181 ] Divij Vaidya commented on KAFKA-14630: -- I have added a new feature to zstd-jni whic

[GitHub] [kafka] fvaleri commented on pull request #13171: KAFKA-14584: Move StateChangeLogMerger tool

2023-02-07 Thread via GitHub
fvaleri commented on PR #13171: URL: https://github.com/apache/kafka/pull/13171#issuecomment-1420398056 Given that clearly nobody is using this tool, I'm wondering if we should deprecate in 3.5 and remove in 4.0. -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [kafka] satishd commented on a diff in pull request #13206: [KAFKA-14685] Refactor logic to handle OFFSET_MOVED_TO_TIERED_STORAGE error

2023-02-07 Thread via GitHub
satishd commented on code in PR #13206: URL: https://github.com/apache/kafka/pull/13206#discussion_r1098319549 ## core/src/main/java/kafka/server/ReplicaFetcherTierStateMachine.java: ## @@ -0,0 +1,246 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [kafka] dajac commented on pull request #13203: KAFKA-14048: Add new `__consumer_offsets` records from KIP-848

2023-02-07 Thread via GitHub
dajac commented on PR #13203: URL: https://github.com/apache/kafka/pull/13203#issuecomment-1420381203 Hey @mimaison. As you reviewed https://github.com/apache/kafka/pull/13200, do you mind reviewing this one? -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Assigned] (KAFKA-14513) Add broker side PartitionAssignor interface

2023-02-07 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot reassigned KAFKA-14513: --- Assignee: David Jacot > Add broker side PartitionAssignor interface > -

[jira] [Resolved] (KAFKA-14678) Move __consumer_offsets records from core to group-coordinator

2023-02-07 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-14678. - Fix Version/s: 3.5.0 Resolution: Fixed > Move __consumer_offsets records from core to gro

[GitHub] [kafka] dajac merged pull request #13200: KAFKA-14678: Move `__consumer_offsets` records from `core` to `group-coordinator`

2023-02-07 Thread via GitHub
dajac merged PR #13200: URL: https://github.com/apache/kafka/pull/13200 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

<    1   2