[GitHub] [kafka] cmccabe commented on pull request #13686: MINOR: Create the MetadataNode classes to introspect MetadataImage

cmccabe commented on PR #13686: URL: https://github.com/apache/kafka/pull/13686#issuecomment-1543363569 > Also noting that this significantly changes the directory structure that the metadata shell presents. Agreed. The shell contents are interface-unstable, though. Maybe

[GitHub] [kafka] cmccabe commented on a diff in pull request #13686: MINOR: Create the MetadataNode classes to introspect MetadataImage

cmccabe commented on code in PR #13686: URL: https://github.com/apache/kafka/pull/13686#discussion_r1190653264 ## metadata/src/main/java/org/apache/kafka/image/node/ScramCredentialDataNode.java: ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] hudeqi commented on pull request #13473: KAFKA-14866:Remove controller module metrics when broker is shutting down

hudeqi commented on PR #13473: URL: https://github.com/apache/kafka/pull/13473#issuecomment-1543327504 @dajac When you get a chance, please take a look. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] hudeqi commented on pull request #13473: KAFKA-14866:Remove controller module metrics when broker is shutting down

hudeqi commented on PR #13473: URL: https://github.com/apache/kafka/pull/13473#issuecomment-1543326829 > Hey @hudeqi I had a similar PR merge recently (#13623) and the comments I received in that PR could be applied to this one also. Specifically, > > 1. the metric names could be

[GitHub] [kafka] kamalcph commented on a diff in pull request #13535: KAFKA-9579 Fetch implementation for records in the remote storage through a specific purgatory.

kamalcph commented on code in PR #13535: URL: https://github.com/apache/kafka/pull/13535#discussion_r1190617224 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -600,25 +623,212 @@ public String toString() { } } -long

[GitHub] [kafka] fqaiser94 commented on a diff in pull request #13656: KAFKA-14911: Add system tests for rolling upgrade path of KIP-904

fqaiser94 commented on code in PR #13656: URL: https://github.com/apache/kafka/pull/13656#discussion_r1190413444 ## tests/kafkatest/tests/streams/streams_upgrade_test.py: ## @@ -236,6 +237,96 @@ def test_rolling_upgrade_with_2_bounces(self, from_version, to_version):

[GitHub] [kafka] fqaiser94 commented on a diff in pull request #13656: KAFKA-14911: Add system tests for rolling upgrade path of KIP-904

fqaiser94 commented on code in PR #13656: URL: https://github.com/apache/kafka/pull/13656#discussion_r1190413444 ## tests/kafkatest/tests/streams/streams_upgrade_test.py: ## @@ -236,6 +237,96 @@ def test_rolling_upgrade_with_2_bounces(self, from_version, to_version):

[GitHub] [kafka] fqaiser94 commented on a diff in pull request #13656: KAFKA-14911: Add system tests for rolling upgrade path of KIP-904

fqaiser94 commented on code in PR #13656: URL: https://github.com/apache/kafka/pull/13656#discussion_r1190418116 ## tests/kafkatest/tests/streams/streams_upgrade_test.py: ## @@ -236,6 +237,96 @@ def test_rolling_upgrade_with_2_bounces(self, from_version, to_version):

[GitHub] [kafka] fqaiser94 commented on a diff in pull request #13656: KAFKA-14911: Add system tests for rolling upgrade path of KIP-904

fqaiser94 commented on code in PR #13656: URL: https://github.com/apache/kafka/pull/13656#discussion_r1190413444 ## tests/kafkatest/tests/streams/streams_upgrade_test.py: ## @@ -236,6 +237,96 @@ def test_rolling_upgrade_with_2_bounces(self, from_version, to_version):

[GitHub] [kafka] fqaiser94 commented on a diff in pull request #13656: KAFKA-14911: Add system tests for rolling upgrade path of KIP-904

fqaiser94 commented on code in PR #13656: URL: https://github.com/apache/kafka/pull/13656#discussion_r1190412985 ## tests/kafkatest/tests/streams/streams_upgrade_test.py: ## @@ -236,6 +237,96 @@ def test_rolling_upgrade_with_2_bounces(self, from_version, to_version):

[GitHub] [kafka] hudeqi commented on a diff in pull request #13697: MINOR:code optimization in QuorumController

hudeqi commented on code in PR #13697: URL: https://github.com/apache/kafka/pull/13697#discussion_r1190576044 ## metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java: ## @@ -350,6 +350,7 @@ public void testFenceMultipleBrokers() throws Throwable {

[GitHub] [kafka] dengziming merged pull request #13693: MINOR: fix a small typo in SharedServer.scala

dengziming merged PR #13693: URL: https://github.com/apache/kafka/pull/13693 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] dengziming commented on a diff in pull request #13697: MINOR:code optimization in QuorumController

dengziming commented on code in PR #13697: URL: https://github.com/apache/kafka/pull/13697#discussion_r1190566126 ## metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java: ## @@ -350,6 +350,7 @@ public void testFenceMultipleBrokers() throws Throwable {

[jira] [Updated] (KAFKA-14983) Upgrade jetty-server to 9.4.51

[ https://issues.apache.org/jira/browse/KAFKA-14983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-14983: -- Fix Version/s: 3.4.1 > Upgrade jetty-server to 9.4.51 > -- > >

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13663: KAFKA-14500; [2/N] Rewrite GroupMetadata in Java

jeffkbkim commented on code in PR #13663: URL: https://github.com/apache/kafka/pull/13663#discussion_r1190519534 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java: ## @@ -0,0 +1,958 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13663: KAFKA-14500; [2/N] Rewrite GroupMetadata in Java

jeffkbkim commented on code in PR #13663: URL: https://github.com/apache/kafka/pull/13663#discussion_r1190517157 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java: ## @@ -0,0 +1,958 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jeffkbkim opened a new pull request, #13704: KAFKA-14500; [3/N] add GroupMetadataKey/Value record helpers

jeffkbkim opened a new pull request, #13704: URL: https://github.com/apache/kafka/pull/13704 This PR enables the new group metadata manager to generate GroupMetadataKey/Value records. Built on top of https://github.com/apache/kafka/pull/13663. Files to review: *

[GitHub] [kafka] jolshan commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

jolshan commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1190477811 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -0,0 +1,865 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] cmccabe commented on a diff in pull request #13686: MINOR: Create the MetadataNode classes to introspect MetadataImage

cmccabe commented on code in PR #13686: URL: https://github.com/apache/kafka/pull/13686#discussion_r1190463495 ## metadata/src/main/java/org/apache/kafka/image/node/ConfigurationsImageNode.java: ## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] jolshan commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

jolshan commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1190455545 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -0,0 +1,865 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

jolshan commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1190454574 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -0,0 +1,865 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

jolshan commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1190437758 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -0,0 +1,865 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

jolshan commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1190447106 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -0,0 +1,865 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

jolshan commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1190445435 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -0,0 +1,865 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] cmccabe commented on a diff in pull request #13686: MINOR: Create the MetadataNode classes to introspect MetadataImage

cmccabe commented on code in PR #13686: URL: https://github.com/apache/kafka/pull/13686#discussion_r1190440507 ## metadata/src/main/java/org/apache/kafka/image/node/ConfigurationImageNode.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] jolshan commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

jolshan commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1190438367 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -0,0 +1,865 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

jolshan commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1190437758 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -0,0 +1,865 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

jolshan commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1190436747 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -0,0 +1,865 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] cmccabe commented on a diff in pull request #13686: MINOR: Create the MetadataNode classes to introspect MetadataImage

cmccabe commented on code in PR #13686: URL: https://github.com/apache/kafka/pull/13686#discussion_r1190434740 ## metadata/src/main/java/org/apache/kafka/image/node/ClientQuotasImageNode.java: ## @@ -0,0 +1,157 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] jolshan commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

jolshan commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1190433019 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -0,0 +1,865 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (KAFKA-14911) Add system tests for rolling upgrade path of KIP-904

[ https://issues.apache.org/jira/browse/KAFKA-14911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721555#comment-17721555 ] Farooq Qaiser commented on KAFKA-14911: --- My apologies, I only saw this message yesterday, let me

[GitHub] [kafka] jolshan commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

jolshan commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1190428691 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -0,0 +1,865 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] fqaiser94 commented on a diff in pull request #13656: KAFKA-14911: Add system tests for rolling upgrade path of KIP-904

fqaiser94 commented on code in PR #13656: URL: https://github.com/apache/kafka/pull/13656#discussion_r1190418116 ## tests/kafkatest/tests/streams/streams_upgrade_test.py: ## @@ -236,6 +237,96 @@ def test_rolling_upgrade_with_2_bounces(self, from_version, to_version):

[GitHub] [kafka] fqaiser94 commented on a diff in pull request #13656: KAFKA-14911: Add system tests for rolling upgrade path of KIP-904

fqaiser94 commented on code in PR #13656: URL: https://github.com/apache/kafka/pull/13656#discussion_r1190412985 ## tests/kafkatest/tests/streams/streams_upgrade_test.py: ## @@ -236,6 +237,96 @@ def test_rolling_upgrade_with_2_bounces(self, from_version, to_version):

[GitHub] [kafka] cmccabe commented on a diff in pull request #13686: MINOR: Create the MetadataNode classes to introspect MetadataImage

cmccabe commented on code in PR #13686: URL: https://github.com/apache/kafka/pull/13686#discussion_r1190417412 ## metadata/src/main/java/org/apache/kafka/image/node/MetadataImageNode.java: ## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] cmccabe commented on a diff in pull request #13686: MINOR: Create the MetadataNode classes to introspect MetadataImage

cmccabe commented on code in PR #13686: URL: https://github.com/apache/kafka/pull/13686#discussion_r1190417412 ## metadata/src/main/java/org/apache/kafka/image/node/MetadataImageNode.java: ## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] jolshan commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

jolshan commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1190417026 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -0,0 +1,865 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

jolshan commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1190416089 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -0,0 +1,865 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

jolshan commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1190415641 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -0,0 +1,865 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jeqo commented on pull request #12647: KAFKA-14191: Add end-to-end latency metrics to Connectors

jeqo commented on PR #12647: URL: https://github.com/apache/kafka/pull/12647#issuecomment-1542836120 @sfc-gh-japatel thanks for the interest and reminder! Bumping the vote thread on the mailing list as there is 1 binding vote missing. -- This is an automated message from the Apache Git

[GitHub] [kafka] cmccabe commented on a diff in pull request #13686: MINOR: Create the MetadataNode classes to introspect MetadataImage

cmccabe commented on code in PR #13686: URL: https://github.com/apache/kafka/pull/13686#discussion_r1190379066 ## metadata/src/main/java/org/apache/kafka/image/node/ProducerIdsImageNode.java: ## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] ableegoldman commented on pull request #13695: HOTFIX: fix the VersionedKeyValueToBytesStoreAdapter#isOpen API

ableegoldman commented on PR #13695: URL: https://github.com/apache/kafka/pull/13695#issuecomment-1542782902 Merged to trunk and cherrypicked to 3.5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] ableegoldman merged pull request #13695: HOTFIX: fix the VersionedKeyValueToBytesStoreAdapter#isOpen API

ableegoldman merged PR #13695: URL: https://github.com/apache/kafka/pull/13695 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (KAFKA-14981) Set `group.instance.id` in streams consumer so that rebalance will not happen if a instance is restarted

[ https://issues.apache.org/jira/browse/KAFKA-14981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721546#comment-17721546 ] A. Sophie Blee-Goldman commented on KAFKA-14981: Have we resolved all the known issues

[GitHub] [kafka] rondagostino commented on pull request #13686: MINOR: Create the MetadataNode classes to introspect MetadataImage

rondagostino commented on PR #13686: URL: https://github.com/apache/kafka/pull/13686#issuecomment-1542774765 Also noting that this significantly changes the directory structure that the metadata shell presents. We have `/local` and `/image`, for example, with whatever is currently under

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13663: KAFKA-14500; [2/N] Rewrite GroupMetadata in Java

rreddy-22 commented on code in PR #13663: URL: https://github.com/apache/kafka/pull/13663#discussion_r1190358529 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java: ## @@ -0,0 +1,958 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13663: KAFKA-14500; [2/N] Rewrite GroupMetadata in Java

rreddy-22 commented on code in PR #13663: URL: https://github.com/apache/kafka/pull/13663#discussion_r1190358529 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java: ## @@ -0,0 +1,958 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13663: KAFKA-14500; [2/N] Rewrite GroupMetadata in Java

rreddy-22 commented on code in PR #13663: URL: https://github.com/apache/kafka/pull/13663#discussion_r1190358529 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java: ## @@ -0,0 +1,958 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13663: KAFKA-14500; [2/N] Rewrite GroupMetadata in Java

rreddy-22 commented on code in PR #13663: URL: https://github.com/apache/kafka/pull/13663#discussion_r1190358529 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java: ## @@ -0,0 +1,958 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13663: KAFKA-14500; [2/N] Rewrite GroupMetadata in Java

rreddy-22 commented on code in PR #13663: URL: https://github.com/apache/kafka/pull/13663#discussion_r1190356950 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java: ## @@ -0,0 +1,958 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13663: KAFKA-14500; [2/N] Rewrite GroupMetadata in Java

rreddy-22 commented on code in PR #13663: URL: https://github.com/apache/kafka/pull/13663#discussion_r1190339738 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java: ## @@ -0,0 +1,958 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] rondagostino commented on a diff in pull request #13686: MINOR: Create the MetadataNode classes to introspect MetadataImage

rondagostino commented on code in PR #13686: URL: https://github.com/apache/kafka/pull/13686#discussion_r1190240987 ## metadata/src/main/java/org/apache/kafka/image/node/ProducerIdsImageNode.java: ## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13663: KAFKA-14500; [2/N] Rewrite GroupMetadata in Java

rreddy-22 commented on code in PR #13663: URL: https://github.com/apache/kafka/pull/13663#discussion_r119078 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java: ## @@ -0,0 +1,958 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13663: KAFKA-14500; [2/N] Rewrite GroupMetadata in Java

rreddy-22 commented on code in PR #13663: URL: https://github.com/apache/kafka/pull/13663#discussion_r1190331659 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java: ## @@ -0,0 +1,958 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13663: KAFKA-14500; [2/N] Rewrite GroupMetadata in Java

rreddy-22 commented on code in PR #13663: URL: https://github.com/apache/kafka/pull/13663#discussion_r1190330383 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java: ## @@ -0,0 +1,958 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13663: KAFKA-14500; [2/N] Rewrite GroupMetadata in Java

rreddy-22 commented on code in PR #13663: URL: https://github.com/apache/kafka/pull/13663#discussion_r1190329439 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java: ## @@ -0,0 +1,958 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13663: KAFKA-14500; [2/N] Rewrite GroupMetadata in Java

rreddy-22 commented on code in PR #13663: URL: https://github.com/apache/kafka/pull/13663#discussion_r1190316117 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroupState.java: ## @@ -0,0 +1,126 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13663: KAFKA-14500; [2/N] Rewrite GroupMetadata in Java

rreddy-22 commented on code in PR #13663: URL: https://github.com/apache/kafka/pull/13663#discussion_r1190315524 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroupState.java: ## @@ -0,0 +1,126 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13663: KAFKA-14500; [2/N] Rewrite GroupMetadata in Java

rreddy-22 commented on code in PR #13663: URL: https://github.com/apache/kafka/pull/13663#discussion_r1190313449 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/generic/GenericGroupTest.java: ## @@ -0,0 +1,936 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13663: KAFKA-14500; [2/N] Rewrite GroupMetadata in Java

rreddy-22 commented on code in PR #13663: URL: https://github.com/apache/kafka/pull/13663#discussion_r1190312512 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java: ## @@ -0,0 +1,958 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13663: KAFKA-14500; [2/N] Rewrite GroupMetadata in Java

rreddy-22 commented on code in PR #13663: URL: https://github.com/apache/kafka/pull/13663#discussion_r1190308136 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java: ## @@ -0,0 +1,958 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13663: KAFKA-14500; [2/N] Rewrite GroupMetadata in Java

rreddy-22 commented on code in PR #13663: URL: https://github.com/apache/kafka/pull/13663#discussion_r1190306648 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java: ## @@ -0,0 +1,958 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13663: KAFKA-14500; [2/N] Rewrite GroupMetadata in Java

rreddy-22 commented on code in PR #13663: URL: https://github.com/apache/kafka/pull/13663#discussion_r1190300876 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java: ## @@ -0,0 +1,958 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13663: KAFKA-14500; [2/N] Rewrite GroupMetadata in Java

rreddy-22 commented on code in PR #13663: URL: https://github.com/apache/kafka/pull/13663#discussion_r1190295837 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java: ## @@ -0,0 +1,958 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13663: KAFKA-14500; [2/N] Rewrite GroupMetadata in Java

rreddy-22 commented on code in PR #13663: URL: https://github.com/apache/kafka/pull/13663#discussion_r1190294950 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java: ## @@ -0,0 +1,958 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] vamossagar12 commented on pull request #13701: KAFKA-14978 ExactlyOnceWorkerSourceTask should remove parent metrics …

vamossagar12 commented on PR #13701: URL: https://github.com/apache/kafka/pull/13701#issuecomment-1542610652 Thanks @viktorsomogyi . I am assuming there would be a PR against trunk as well(could find only against 3.3, 3.4, 3.5)? -- This is an automated message from the Apache Git

[GitHub] [kafka] vamossagar12 commented on pull request #13701: KAFKA-14978 ExactlyOnceWorkerSourceTask should remove parent metrics …

vamossagar12 commented on PR #13701: URL: https://github.com/apache/kafka/pull/13701#issuecomment-1542609157 LGTM, @viktorsomogyi . I see 3 PRs with more or less the same changes. I am assuming those would be closed? -- This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] cmccabe opened a new pull request, #13703: MINOR: Standardize controller log4j output for replaying records

cmccabe opened a new pull request, #13703: URL: https://github.com/apache/kafka/pull/13703 Standardize controller log4j output for replaying important records. The log message should include word "replayed" to make it clear that this is a record replay. Log the replay of records for ACLs,

[GitHub] [kafka] machi1990 commented on pull request #13702: KAFKA-14985: attempt to fix ConnectionQuotasTest.testListenerConnectionRateLimitWhenActualRateAboveLimit() test by bumping episilon to 8 f

machi1990 commented on PR #13702: URL: https://github.com/apache/kafka/pull/13702#issuecomment-1542588642 Thanks @divijvaidya thanks. I'll close this PR in favor of https://github.com/apache/kafka/pull/12045 -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] machi1990 closed pull request #13702: KAFKA-14985: attempt to fix ConnectionQuotasTest.testListenerConnectionRateLimitWhenActualRateAboveLimit() test by bumping episilon to 8 from 7

machi1990 closed pull request #13702: KAFKA-14985: attempt to fix ConnectionQuotasTest.testListenerConnectionRateLimitWhenActualRateAboveLimit() test by bumping episilon to 8 from 7 URL: https://github.com/apache/kafka/pull/13702 -- This is an automated message from the Apache Git Service.

[jira] [Commented] (KAFKA-14985) ConnectionQuotasTest.testListenerConnectionRateLimitWhenActualRateAboveLimit() test is flaky

[ https://issues.apache.org/jira/browse/KAFKA-14985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721490#comment-17721490 ] Manyanda Chitimbo commented on KAFKA-14985: --- Thanks [~divijvaidya]  >

[GitHub] [kafka] divijvaidya commented on pull request #13702: KAFKA-14985: attempt to fix ConnectionQuotasTest.testListenerConnectionRateLimitWhenActualRateAboveLimit() test by bumping episilon to 8

divijvaidya commented on PR #13702: URL: https://github.com/apache/kafka/pull/13702#issuecomment-1542584930 @machi1990 I am afraid just changing the bound is not going to help. Please see open PR https://github.com/apache/kafka/pull/12045 associated with this fix for details and let me

[GitHub] [kafka] kirktrue commented on a diff in pull request #13678: KAFKA-10337: await async commits in commitSync even if no offsets given

kirktrue commented on code in PR #13678: URL: https://github.com/apache/kafka/pull/13678#discussion_r1190226530 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java: ## @@ -1223,6 +1233,26 @@ public void maybeAutoCommitOffsetsAsync(long

[jira] [Resolved] (KAFKA-14985) ConnectionQuotasTest.testListenerConnectionRateLimitWhenActualRateAboveLimit() test is flaky

[ https://issues.apache.org/jira/browse/KAFKA-14985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya resolved KAFKA-14985. -- Resolution: Duplicate Resolving as duplicate of existing open JIRA. >

[jira] [Commented] (KAFKA-14985) ConnectionQuotasTest.testListenerConnectionRateLimitWhenActualRateAboveLimit() test is flaky

[ https://issues.apache.org/jira/browse/KAFKA-14985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721486#comment-17721486 ] Divij Vaidya commented on KAFKA-14985: -- We already have an open Jira (and a pending PR) for this:

[GitHub] [kafka] kirktrue commented on a diff in pull request #13678: KAFKA-10337: await async commits in commitSync even if no offsets given

kirktrue commented on code in PR #13678: URL: https://github.com/apache/kafka/pull/13678#discussion_r1190210077 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java: ## @@ -1132,6 +1136,7 @@ public void onSuccess(Void value) {

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13663: KAFKA-14500; [2/N] Rewrite GroupMetadata in Java

jeffkbkim commented on code in PR #13663: URL: https://github.com/apache/kafka/pull/13663#discussion_r1190204060 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java: ## @@ -0,0 +1,967 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13663: KAFKA-14500; [2/N] Rewrite GroupMetadata in Java

jeffkbkim commented on code in PR #13663: URL: https://github.com/apache/kafka/pull/13663#discussion_r1190199871 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/generic/GenericGroupTest.java: ## @@ -0,0 +1,876 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13663: KAFKA-14500; [2/N] Rewrite GroupMetadata in Java

jeffkbkim commented on code in PR #13663: URL: https://github.com/apache/kafka/pull/13663#discussion_r1190181383 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java: ## @@ -0,0 +1,967 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jlprat commented on a diff in pull request #13170: MINOR: Remove unused methods in CoreUtils

jlprat commented on code in PR #13170: URL: https://github.com/apache/kafka/pull/13170#discussion_r1190178039 ## core/src/test/scala/unit/kafka/utils/CoreUtilsTest.scala: ## @@ -223,7 +204,7 @@ class CoreUtilsTest extends Logging { val map = new ConcurrentHashMap[Int,

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13663: KAFKA-14500; [2/N] Rewrite GroupMetadata in Java

jeffkbkim commented on code in PR #13663: URL: https://github.com/apache/kafka/pull/13663#discussion_r1190177045 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java: ## @@ -0,0 +1,967 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] machi1990 commented on pull request #13702: KAFKA-14985: attempt to fix ConnectionQuotasTest.testListenerConnectionRateLimitWhenActualRateAboveLimit() test by bumping episilon to 8 f

machi1990 commented on PR #13702: URL: https://github.com/apache/kafka/pull/13702#issuecomment-1542524201 @rajinisivaram @apovzner can you've a look once you've some time? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] machi1990 opened a new pull request, #13702: KAFKA-14985: attempt to fix ConnectionQuotasTest.testListenerConnectionRateLimitWhenActualRateAboveLimit() test by bumping episilon to 8

machi1990 opened a new pull request, #13702: URL: https://github.com/apache/kafka/pull/13702 The test was observed to be failing with ``` ConnectionQuotasTest > testListenerConnectionRateLimitWhenActualRateAboveLimit() FAILED java.util.concurrent.ExecutionException:

[jira] [Assigned] (KAFKA-14985) ConnectionQuotasTest.testListenerConnectionRateLimitWhenActualRateAboveLimit() test is flaky

[ https://issues.apache.org/jira/browse/KAFKA-14985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manyanda Chitimbo reassigned KAFKA-14985: - Assignee: Manyanda Chitimbo >

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13663: KAFKA-14500; [2/N] Rewrite GroupMetadata in Java

jeffkbkim commented on code in PR #13663: URL: https://github.com/apache/kafka/pull/13663#discussion_r1190175577 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java: ## @@ -0,0 +1,967 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] machi1990 commented on pull request #13665: KAFKA-12485: Speed up Consumer#committed by returning cached offsets for owned partitions

machi1990 commented on PR #13665: URL: https://github.com/apache/kafka/pull/13665#issuecomment-1542514663 @ableegoldman @showuon can you've a look at this draft PR once you've sometime? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Commented] (KAFKA-14985) ConnectionQuotasTest.testListenerConnectionRateLimitWhenActualRateAboveLimit() test is flaky

[ https://issues.apache.org/jira/browse/KAFKA-14985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721469#comment-17721469 ] Manyanda Chitimbo commented on KAFKA-14985: --- A quick fix will be to bump the epsilon to a

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13663: KAFKA-14500; [2/N] Rewrite GroupMetadata in Java

jeffkbkim commented on code in PR #13663: URL: https://github.com/apache/kafka/pull/13663#discussion_r1190154104 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java: ## @@ -0,0 +1,967 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] dajac commented on pull request #13694: MINOR: add test tag for testDeadToDeadIllegalTransition

dajac commented on PR #13694: URL: https://github.com/apache/kafka/pull/13694#issuecomment-1542496068 Let me re-trigger the tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] jeffkbkim commented on pull request #13694: MINOR: add test tag for testDeadToDeadIllegalTransition

jeffkbkim commented on PR #13694: URL: https://github.com/apache/kafka/pull/13694#issuecomment-1542491308 @dajac the test failures look unrelated but i've noticed that sometimes the same tests fail altogether -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] erikvanoosten commented on pull request #13678: KAFKA-10337: await async commits in commitSync even if no offsets given

erikvanoosten commented on PR #13678: URL: https://github.com/apache/kafka/pull/13678#issuecomment-1542480034 > Hey @erikvanoosten, Thanks for the PR! Could you add checks for inflightCommits count gets set to 0 in a few of the callback testing function like

[GitHub] [kafka] machi1990 commented on pull request #13664: KAFKA-14961: harden DefaultBackgroundThreadTest.testStartupAndTearDown test

machi1990 commented on PR #13664: URL: https://github.com/apache/kafka/pull/13664#issuecomment-1542460521 Thanks @philipnee this should be good to be merged @vvcephei thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] viktorsomogyi opened a new pull request, #13701: KAFKA-14978 ExactlyOnceWorkerSourceTask should remove parent metrics …

viktorsomogyi opened a new pull request, #13701: URL: https://github.com/apache/kafka/pull/13701 …(#13690) Reviewers: Chris Egerton , Viktor Somogyi-Vass -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Created] (KAFKA-14985) ConnectionQuotasTest.testListenerConnectionRateLimitWhenActualRateAboveLimit() test is flaky

Manyanda Chitimbo created KAFKA-14985: - Summary: ConnectionQuotasTest.testListenerConnectionRateLimitWhenActualRateAboveLimit() test is flaky Key: KAFKA-14985 URL:

[GitHub] [kafka] machi1990 commented on pull request #13700: KAFKA-14959: remove delayed queue and exempt sensors during ClientQuota and ClientRequestQuota managers shutdown

machi1990 commented on PR #13700: URL: https://github.com/apache/kafka/pull/13700#issuecomment-1542448724 I am wondering if these sensors that are dynamically created should be removed as well:

[GitHub] [kafka] machi1990 commented on pull request #13700: KAFKA-14959: remove delayed queue and exempt sensors during ClientQuota and ClientRequestQuota managers shutdown

machi1990 commented on PR #13700: URL: https://github.com/apache/kafka/pull/13700#issuecomment-1542446635 @rajinisivaram @dajac please review when you've the chance -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] machi1990 opened a new pull request, #13700: KAFKA-14959: remove delayed queue and exempt sensors during ClientQuota and ClientRequestQuota managers shutdown

machi1990 opened a new pull request, #13700: URL: https://github.com/apache/kafka/pull/13700 Follows up on https://github.com/apache/kafka/pull/13623#discussion_r1182592921 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ]

[jira] [Created] (KAFKA-14984) DynamicBrokerReconfigurationTest.testThreadPoolResize() test is flaky

Manyanda Chitimbo created KAFKA-14984: - Summary: DynamicBrokerReconfigurationTest.testThreadPoolResize() test is flaky Key: KAFKA-14984 URL: https://issues.apache.org/jira/browse/KAFKA-14984

[GitHub] [kafka] C0urante commented on pull request #13690: KAFKA-14978 ExactlyOnceWorkerSourceTask should remove parent metrics

C0urante commented on PR #13690: URL: https://github.com/apache/kafka/pull/13690#issuecomment-1542437079 We don't have this automated (to my knowledge). For backports, we can cherry-pick and push directly to the branch. PRs aren't necessary but if you'd like a second pair of eyes to, e.g.,

[GitHub] [kafka] viktorsomogyi commented on pull request #13690: KAFKA-14978 ExactlyOnceWorkerSourceTask should remove parent metrics

viktorsomogyi commented on PR #13690: URL: https://github.com/apache/kafka/pull/13690#issuecomment-1542434744 @C0urante thanks. I'll cherry-pick it to 3.3 soon and open a PR. Btw does Kafka have an automated way or do you usually do it manually by git cherry-pick and creating PR either via

  1   2   >